Project

General

Profile

Activity

From 03/28/2024 to 04/26/2024

04/26/2024

07:52 AM Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'
8593a was merged to trunk rev 15169 and archived.
8593a_h2 was merged to fwd-h2 rev 46 and archived.
Constantin Asofiei
07:39 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You can go ahead with the merge of 8593a and 8636g. Greg Shah
02:37 AM Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei
02:06 AM Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'
Yes. I had to upgrade to latest 6667i (after recent rebase), reconvert are set a new baseline. After, I patched @(859... Alexandru Lungu

04/25/2024

07:17 PM Bug #8683: SQL operations not saved when session is closed
In a customer application we encountered a case when SQL statements which apparently were executed were not actually ... Ovidiu Maxiniuc
07:04 PM Bug #8683 (New): SQL operations not saved when session is closed
Ovidiu Maxiniuc
06:48 PM Bug #6492: problems with dynamic queries for meta tables
This particular issue was fixed in 8437b/15175, by qualifying the table name with its database (except for temporary ... Ovidiu Maxiniuc
04:27 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, please let me know if you managed to run ChUI - I'd like to merge these tomorrow. Constantin Asofiei
05:30 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You can test them both (8593a + 8636g). I've uploaded fwd-h2 1.46 and 8593a rev 15161 has the change in build.gradle... Constantin Asofiei
05:00 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> ETF testing passed. Alexandru, if you can run a ChUI regression testing with this and 8363g, please let me know.
...
Alexandru Lungu
03:18 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test t...
Constantin Asofiei

04/24/2024

10:51 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test these changes. Constantin Asofiei
08:36 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> This is a huge thing. Removing a batch will make the @MultiplexScanIndex@ quite unstable. I...
Constantin Asofiei
08:30 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> I need to double-check for undoable temp-tables. The case I'm thinking is a @empty-temp...
Alexandru Lungu
07:45 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Oh, the invariant I was talking about is @removed.cardinality == 0@ when killing a multiple...
Constantin Asofiei
04:24 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Do you mean that the invariant was broken and now it was fix...
Alexandru Lungu
04:10 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Do you mean that the invariant was broken and now it was fixed by @clearPrimaryKey@? I unde...
Constantin Asofiei
03:46 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> > * @rowCount -= removed.cardinality;@ is something that is theoretical irrelevant. The ...
Alexandru Lungu
02:19 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> The FWD direct-access changes are OK!
> Also, getting rid of the @forceDelete@ is good, bu...
Constantin Asofiei

04/23/2024

10:47 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
The FWD direct-access changes are OK!
Also, getting rid of the @forceDelete@ is good, but requires extensive testing...
Alexandru Lungu
09:11 AM Feature #7960: Allow query logs to be collected in a H2 database
Changes are now on branch 7960a, rev 15157.
Regarding your concern: *Make sure that this kind of logging is not happ...
Ioana-Cristina Prioteasa
06:28 AM Feature #7960: Allow query logs to be collected in a H2 database
Review of 7960a:
* For @P2JLoggingDatabaseHelper@ construct:
** Separate the connection from statement execution:...
Alexandru Lungu
06:05 AM Feature #7960 (Review): Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa
06:05 AM Feature #7960 (WIP): Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa
06:04 AM Feature #7960: Allow query logs to be collected in a H2 database
I added the necessary modifications to support this feature, changes are now on branch 7960a, rev 15156. Ioana-Cristina Prioteasa
04:25 AM Feature #7366: improve performance of buffer.fill
Ovidiu Maxiniuc wrote:
> I think I understand the idea: if the same query can be reused for a child buffer, it does ...
Constantin Asofiei

04/22/2024

12:36 PM Feature #7366: improve performance of buffer.fill
Review of 8363g, r15157/8.
I think I understand the idea: if the same query can be reused for a child buffer, it d...
Ovidiu Maxiniuc
09:20 AM Feature #7366: improve performance of buffer.fill
Eric/Ovidiu: please review 8363g rev 15158. Constantin Asofiei
08:03 AM Feature #7366: improve performance of buffer.fill
Changes related to this are in 8363g rev 15158: Allow the query to be reset to its initialization state, so the same ... Constantin Asofiei
09:01 AM Bug #7473 (Review): rewrite toString() implementation for Dataset, StaticTempTable and TempTableB...
I modified the code following your advices and managed to implement "getDataAsJson" method for "DataSet" as well.
...
Eduard Baciu
02:44 AM Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'
Created task branch 8593a from trunk rev 15157, with:
* For a NEW temp record which was not flushed and is being del...
Constantin Asofiei

04/20/2024

05:31 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Previously we used the @UPDATE ... SET _MULTIPLEX = ?@ paired with a @ReversibleBulkDelete@, which was meant to resto... Constantin Asofiei

04/19/2024

05:31 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
Yes, I think this what we need. Some advices:
* do not involve @ErrorManager@ in @toString()@: even if you use it in...
Ovidiu Maxiniuc
09:48 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
I rewrote toString function for StaticTempTable and TempTableBuilder using a StringBuilder in which i added elements(... Eduard Baciu
07:55 AM Bug #8593 (WIP): H2 performance improvement for table 'truncate by multiplex'
Greg Shah

04/17/2024

01:49 PM Bug #8648: Recheck ACTIVATE and DEACTIVATE procedures on appserver calls
This task is a continuation of 8444d (merged to trunk as rev. 15153) to investigate all @invoke*@ methods from the @A... Alexandru Lungu
01:48 PM Bug #8648 (Closed): Recheck ACTIVATE and DEACTIVATE procedures on appserver calls
Alexandru Lungu

04/11/2024

03:56 PM Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
The caching mechanism is in place since the early implementation. Since the structure of the JAST in which the constr... Ovidiu Maxiniuc
01:07 PM Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
What we need to implement for method/constructor matching is actually the Java compiler's algorithm for linking the c... Constantin Asofiei
12:59 PM Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
@RuntimeJastInterpreter.findMatchingConstructor@ currently returns @null@ when it finds more than one c'tor whose sig... Eric Faulhaber
12:26 PM Bug #8621 (New): better resolution of ambiguous constructors/methods in RuntimeJastInterpreter
Eric Faulhaber

04/10/2024

02:38 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Just a thing that was on my mind and wanted to have it here as well:
For NO-UNDO cases, we used to rollback (trans...
Alexandru Lungu
01:25 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right?
...
Eric Faulhaber
12:04 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right? Alexandru Lungu
11:29 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Greg Shah wrote:
> Seems like a long-standing leak of records. If that built up to a large number, it might be both...
Eric Faulhaber
08:52 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Seems like a long-standing leak of records. If that built up to a large number, it might be both a memory leak and a... Greg Shah
07:59 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> Still, why are we updating with a @<delete-multiplex>@ instead of actually deleting them? I...
Eric Faulhaber
07:30 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> For MultiplexedScanIndex, the target batch in setRow(key, row) is calculated from the record's key (which is not ch... Alexandru Lungu
06:46 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
No, the @empty-temp-table@ is the problem, while executing in a transaction, for an undoable temp-table - this does n... Constantin Asofiei
06:41 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> For an undoable temp-table, a @EMPTY-TEMP-TABLE@ results in a @UPDATE tt1 SET _multiplex...
Alexandru Lungu
05:11 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
The recreate is this:
* @mpid1.p@...
Constantin Asofiei
03:59 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only fo...
Alexandru Lungu

04/09/2024

01:07 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only for a certain multiplex*. This... Constantin Asofiei

04/08/2024

03:40 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...
@WRITE-JSON@ will always leave the current/working buffer empty when it is finished, causing it content to be eventua... Ovidiu Maxiniuc
02:48 PM Bug #7473 (WIP): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuil...
Ovidiu, are you aware if the @WRITE-JSON@ was finally rewritten without side-effects? Otherwise, Eduard B. can pick i... Alexandru Lungu
05:19 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei wrote:
> You mean the Row.key is not the same as the internal PK?
I mean Row.key to be the same ...
Constantin Asofiei
05:15 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
You mean the Row.key is not the same as the internal PK?
Also, there is 'recid' index (with just this column) in H...
Constantin Asofiei
04:45 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:... Alexandru Lungu
03:08 AM Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'
Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:
...
Constantin Asofiei
02:56 AM Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'
Constantin Asofiei
08:34 PM Bug #8554 (Test): resolving temp-tables in a class hierarchy
Greg Shah

04/06/2024

01:41 PM Bug #8554: resolving temp-tables in a class hierarchy
Branch 8554a was merged into trunk as rev. 15125 and archived. Constantin Asofiei
12:40 PM Bug #8554: resolving temp-tables in a class hierarchy
You can merge to trunk now.
Hynek: 8152a can merge after 8554a.
Greg Shah
03:15 AM Bug #8554 (Merge Pending): resolving temp-tables in a class hierarchy
Ovidiu, I've fixed the visibility in rev 15127 (after rebase).
ETF testing passed. It can be merged to trunk.
Constantin Asofiei

04/05/2024

06:11 PM Bug #8589: Deprecate the shared temporary database completely
Unless there is a _significant_ memory savings or some other substantial advantage of shared mode, I think we should ... Eric Faulhaber
03:45 AM Bug #8589: Deprecate the shared temporary database completely
In the original support for _temp database, one single in-memory database was created. All sessions used that single ... Alexandru Lungu
03:05 AM Bug #8589 (New): Deprecate the shared temporary database completely
Alexandru Lungu

04/04/2024

06:39 PM Bug #8554: resolving temp-tables in a class hierarchy
Review of 8554a, r15120-15122.
I am OK with the code. I'm sorry I made a mess with condition codes which do and do...
Ovidiu Maxiniuc
04:21 PM Bug #8554: resolving temp-tables in a class hierarchy
Ovidiu, please review this, I'll get ETF testing tomorrow and if is OK, I'd like to merge this tomorrow. Constantin Asofiei
07:41 AM Bug #8554 (Review): resolving temp-tables in a class hierarchy
15122 fixes some issues, javadocs and some errors which must not set ERROR-STATUS:ERROR. This can be reviewed.
I'...
Constantin Asofiei
05:31 AM Bug #8554 (WIP): resolving temp-tables in a class hierarchy
Created task branch 8554a from trunk rev 15119.
15120 and 15121 has a rough fix for this - need to validate it.
Constantin Asofiei

04/01/2024

08:49 AM Bug #8554: resolving temp-tables in a class hierarchy
@DATASET:CREATE-LIKE("<dataset-name>")@ needs to be checked, too. Constantin Asofiei

03/31/2024

10:35 AM Bug #8554: resolving temp-tables in a class hierarchy
There are some problems when resolving temp-tables in a hierarchy.
* @oo.Test1@:...
Constantin Asofiei
10:28 AM Bug #8554 (Test): resolving temp-tables in a class hierarchy
Constantin Asofiei
 

Also available in: Atom