Project

General

Profile

Activity

From 11/22/2013 to 12/21/2013

12/21/2013

03:57 PM Feature #1787: implement batch mode support
Merging StandardServer.java with recent code base(10425). Will be used in testing from now. Eugenie Lyzenko
07:52 AM Feature #1787: implement batch mode support
Merging ErrorManager.java with recent code base(10424). Will be used in testing from now. Eugenie Lyzenko

12/20/2013

06:41 PM Feature #1787: implement batch mode support
> That is good. Get this tested.
The testing is on the way.
Eugenie Lyzenko
06:39 PM Feature #1787: implement batch mode support
That is good. Get this tested. Greg Shah
06:23 PM Feature #1787: implement batch mode support
> After adding the comments, upload that version and start testing.
OK. The comments have been added.
Eugenie Lyzenko
06:09 PM Feature #1787: implement batch mode support
Code Review 1220a
I am fine with the changes.
> The key point here is he have to return some correct values her...
Greg Shah
01:18 PM Feature #1787: implement batch mode support
This update cleans previous notes.
Also I remembered one point under the question. The @BatchPrimitives.java@ clas...
Eugenie Lyzenko
11:20 AM Feature #1787: implement batch mode support
> Normally it should not happen but may be failure in initErrorWriter()? Is this not necessary?
It is good that yo...
Greg Shah
10:33 AM Feature #1787: implement batch mode support
> 1. All EVL** comments need to be removed so that this can be finalized. In general, I prefer if you do not use this... Eugenie Lyzenko
09:14 AM Feature #1787: implement batch mode support
Code Review 1219a
1. All EVL** comments need to be removed so that this can be finalized. In general, I prefer if...
Greg Shah
04:44 PM Feature #1811: implement the AJAX client driver
Related to JS frameworks. I have some experience using jQuery but no experience using other frameworks.
Marius Gligor
02:30 PM Feature #1811: implement the AJAX client driver
Yes I did that when I tested Admin Console on my local station. So I have to do tests on my local station and after t... Marius Gligor
02:14 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> After the local tests you suggest me to repeat the regression tests?
Yes
> What I want to d...
Constantin Asofiei
02:03 PM Feature #1811: implement the AJAX client driver
I did something similar with AdminConsole if you remember.
After the local tests you suggest me to repeat the regres...
Marius Gligor
01:54 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> Monday I want to do runtime tests first on my workstation and then on devsvr01.
Regression t...
Constantin Asofiei
01:48 PM Feature #1811: implement the AJAX client driver
Here are the latest changes that I made. Monday I want to do runtime tests first on my workstation and then on devsvr... Marius Gligor
01:14 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: can you make the sudoers file changes? See the postbuild.sh for details.
Yes, I can...
Constantin Asofiei
01:06 PM Feature #1811: implement the AJAX client driver
> Also keep in mind that the p2j.jar location detection is done on the server instance and is absolute to the user on... Greg Shah
01:02 PM Feature #1811: implement the AJAX client driver
Here are some details on our approach in regard to javascript frameworks.
1. Cross-browser compatibility is still ...
Greg Shah
12:55 PM Feature #1811: implement the AJAX client driver
Also keep in mind that the p2j.jar location detection is done on the server instance
and is absolute to the user on ...
Marius Gligor
12:45 PM Feature #1811: implement the AJAX client driver
We can detect the location of p2j.jar as you already mention and I use this method in the previous snapshots but I th... Marius Gligor
12:02 PM Feature #1811: implement the AJAX client driver
> I think we should be able to determine the library path and the classpath dynamically.
This will work as a defa...
Greg Shah
11:59 AM Feature #1811: implement the AJAX client driver
Actually, I think we should be able to determine the library path and the classpath dynamically. See the code in @App... Constantin Asofiei
11:18 AM Feature #1811: implement the AJAX client driver
> Keep in mind that each user on devsrv01 has a ~/testing/majic/p2j folder.
This is why I prefer to use relative p...
Greg Shah
11:13 AM Feature #1811: implement the AJAX client driver
> We cannot provide relative paths for this values we have to specify absolute paths.
Most production environments...
Greg Shah
10:20 AM Feature #1811: implement the AJAX client driver
I think the solution for devsrv01 is not about setting relative paths, but computing the full paths dynamically for e... Constantin Asofiei
10:08 AM Feature #1811: implement the AJAX client driver
Classpath, native libraries path and spawner location should be shared by all web clients.
We cannot provide relativ...
Marius Gligor
09:57 AM Feature #1811: implement the AJAX client driver
I still prefer you to test on devsrv01 with the chui web active. This will make sure that we have a real chui enviro... Greg Shah
09:28 AM Feature #1811: implement the AJAX client driver
Also I could provide platform specific (Linux/Windows) default values and do only runtime tests with Majic build on m... Marius Gligor
09:23 AM Feature #1811: implement the AJAX client driver
> If the server standard subject is not added to admin ACL the pool is empty and no client could be spawned.
I'm f...
Greg Shah
09:06 AM Feature #1811: implement the AJAX client driver
I provided default values for all this parameters (see ClientBuilderOptions).
Now the server starts without errors...
Marius Gligor
08:45 AM Feature #1811: implement the AJAX client driver
... Greg Shah

12/19/2013

06:07 PM Feature #1787: implement batch mode support
The update implements the strange 4GL feature founded during debugging batch mode redirected cases. The @ENABLE@ stat... Eugenie Lyzenko
02:37 PM Feature #1811: implement the AJAX client driver
Code Review 1219b
The changes look good.
Greg Shah
01:03 PM Feature #1811: implement the AJAX client driver
I added a conditional build variable ${have.pam} for Linux / Unix native build targets in build.xml script file.
The...
Marius Gligor
12:27 PM Feature #1811: implement the AJAX client driver
OK. Now the project was successfully build on devsvr01.
Nevertheless I'm going to add the PAM variable for conditio...
Marius Gligor
12:19 PM Feature #1811: implement the AJAX client driver
> Another option is to define a build variable like -Dpam=yes in order to build spawn.c with PAM option.
> By defaul...
Greg Shah
12:01 PM Feature #1811: implement the AJAX client driver
Another option is to define a build variable like -Dpam=yes in order to build spawn.c with PAM option.
By default th...
Marius Gligor
11:42 AM Feature #1811: implement the AJAX client driver
In order to install PAM libraries we need to install this package:
sudo apt-get install libpam0g-dev
Marius Gligor
11:21 AM Feature #1811: implement the AJAX client driver
I've started to do the regression tests. When I executed this step:
run_regression.sh build && run_regression.sh s...
Marius Gligor
08:52 AM Feature #1811: implement the AJAX client driver
Code Review 1219a
Everything looks good. Please get this regression tested (only runtime testing is needed).
I...
Greg Shah
08:07 AM Feature #1811: implement the AJAX client driver
I did some small changes inside the security package to allow update of user accounts stored in security cache.
1....
Marius Gligor

12/18/2013

01:22 PM Feature #1811: implement the AJAX client driver
Unfortunately I found that changing the TAB characters in makefile results in a make error related to missing separat... Marius Gligor
01:05 PM Feature #1811: implement the AJAX client driver
Code Review 1218a
Really good improvements. Yes, we are close now.
> 5. For security reasons when an account i...
Greg Shah
12:20 PM Feature #1811: implement the AJAX client driver
I've fixed almost all the issues reported on your code reviews with some remarks:
1. In TemporaryAccountPool, the ...
Marius Gligor
09:27 AM Feature #1811: implement the AJAX client driver
> In my opinion authentication is done relative rarely and isn't used intensively by users.
In comparison to the r...
Greg Shah
09:16 AM Feature #1811: implement the AJAX client driver
According to my tests without a "refresh" the account changes (enable/disable) are not "visible" and when the client ... Marius Gligor
08:41 AM Feature #1811: implement the AJAX client driver
> in UpdateAccountTask.run, we are calling AdminServerImpl.targetRefresh();. This is a very expensive operation (as i... Greg Shah
03:13 AM Feature #1811: implement the AJAX client driver
Review for 1217a (beside Greg's notes):
* in @makefile.spawn@, you are using tabs for indenting. More, in @postbuild...
Constantin Asofiei
09:12 PM Feature #1811: implement the AJAX client driver
After #2201, you will next be working on #2212. I will add more details/guidance tomorrow. If you run out of work b... Greg Shah
08:59 PM Feature #1811: implement the AJAX client driver
Code Review 1217a
1. @if(web)@ in ClientCore should be @if (web)@.
2. In TemporaryAccountPool, the import of Lo...
Greg Shah
01:11 PM Feature #1791: implement dynamic UI support
Here it is. Vadim Gindin
01:07 PM Feature #1791: implement dynamic UI support
Please post the final changes. Greg Shah
01:02 PM Feature #1791: implement dynamic UI support
Regression passed, committed to bzr rev #10421. Vadim Gindin
08:20 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Notes about your findings:
# please merge your update and post it here.
# you need to hard code the expected values...
Constantin Asofiei
04:32 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
A quick note about the MethodInvoker problems: some static proxies got bad after the handle resource ID changes, I'm ... Constantin Asofiei
09:09 PM Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
This task is for time management only. Please put all history into the parent task #1811. Greg Shah
09:09 PM Feature #2212 (Closed): design websockets protocol for bidirectional communication between the ja...
Greg Shah
07:21 PM Feature #1787: implement batch mode support
The next update for review. Includes small fixed discovered in test-cases debugging and code to suppress the batch mo... Eugenie Lyzenko

12/17/2013

06:59 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
I've committed all tests for LAST-EVENT I have. rev #1075. Vadim Gindin
06:15 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
13) Asynchronous calls... Vadim Gindin
07:24 PM Feature #1782: implement LAST-EVENT system handle and associated attributes

Here are the test cases. I rewrote it to make it simpler and independent of key presses or other events.
1) Read...
Vadim Gindin
06:46 AM Feature #1811: implement the AJAX client driver
Add code to terminate the thread on server shut down some minor changes. Marius Gligor

12/16/2013

01:24 PM Feature #1811: implement the AJAX client driver
New design. Fixed size for temporary accounts pool. Marius Gligor
12:57 PM Feature #1811: implement the AJAX client driver
OK. I started to change the design to have a fixed pool of accounts.
Marius Gligor
11:24 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 5. On heavy loaded systems when the pool potentially became empty a new temporary account is ...
Constantin Asofiei
11:17 AM Feature #1811: implement the AJAX client driver
I fixed the enable/disable temporary account using the AssociatedThread class.
Bellow is a short description of temp...
Marius Gligor

12/13/2013

02:53 PM Feature #1787: implement batch mode support
The update for the review includes:
1. Merging with the recent code base
2. Changes for notes 1-7 from #65 above
...
Eugenie Lyzenko
11:38 AM Feature #1811: implement the AJAX client driver
> The result is here http://www.gmax.ws/tty.html
> It's just an exercise but I think that looks good, isn't it?
V...
Greg Shah
11:37 AM Feature #1811: implement the AJAX client driver
Code Review 1213a
The changes continue to move in the right direction. Some minor feedback:
1. I prefer to hav...
Greg Shah
11:20 AM Feature #1811: implement the AJAX client driver
OK. I fixed the authentication issue using security:authentication:type=program like AdminLogon do.
Using an interac...
Marius Gligor
08:44 AM Feature #1811: implement the AJAX client driver
> In this case the authentication for p4g converted application should be done using JS TTY emulator.
> Is this true...
Greg Shah
08:14 AM Feature #1811: implement the AJAX client driver
I implemented the temporary account pool by deleting all temporary accounts and create new ones on server start-up.
...
Marius Gligor
07:28 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
> 2) Msgupdate.p
I think this test is a little too far ahead of our understanding of the LAST-EVENT behaviour. For ...
Constantin Asofiei
05:51 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Here are test cases:
> 1) same.p - testing equality of all three handles.
> [...]
>
> Wor...
Constantin Asofiei
08:27 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Here are test cases:
1) same.p - testing equality of all three handles....
Vadim Gindin

12/12/2013

04:26 PM Feature #1811: implement the AJAX client driver
> The problem is that we have to store the password like AdminConsole and send the clear password encrypted as enviro... Greg Shah
04:16 PM Feature #1811: implement the AJAX client driver
Another solution is to delete all accounts from temps group on each server start-up and create new accounts.
The pas...
Marius Gligor
03:56 PM Feature #1811: implement the AJAX client driver
I have an idea. We can use a random string constant like a "salt" and the password should be constructed
from user n...
Marius Gligor
03:16 PM Feature #1811: implement the AJAX client driver
Also the Base64 encryption/decryption algorithm is used. Basically isn't a strong encryption. Marius Gligor
02:38 PM Feature #1811: implement the AJAX client driver
In the mean time I found why the password format are different. AdminConsole does not store the clear password encryp... Marius Gligor
01:52 PM Feature #1811: implement the AJAX client driver
> 1. The pool is created from the StandardServer thread on start-up when we have enough rights to manipulate user acc... Greg Shah
01:30 PM Feature #1811: implement the AJAX client driver
I started to design and implements the temporary account pool. Finally I was able to create user accounts from Standa... Marius Gligor
02:37 AM Feature #1811: implement the AJAX client driver
I fixed the issue by adding the process standard to the subject list in ACL (see bellow)
Now I'm able to create user...
Marius Gligor
11:10 AM Feature #1787: implement batch mode support
> The client init code requires the terminal subsystem to be in real console mode(e.g. double buffered terminal outpu... Greg Shah
10:20 AM Feature #1787: implement batch mode support
> I'm referring to the code that initializes batch mode here. I understand that the actual honoring of batchmode will... Eugenie Lyzenko
08:53 AM Feature #1787: implement batch mode support
> In batch mode this produces the "No output destination" error box(as native Windows dialog).
OK.
> So current...
Greg Shah
08:32 AM Feature #1787: implement batch mode support
> Actually, I think we need to remove all the Swing code and we don't need any JNI support.
>
> In Windows ChUI, a...
Eugenie Lyzenko
07:03 AM Feature #1787: implement batch mode support
> But actually the UI code is complicated itself(for console driver itself). We have multiple UI calls for single 4GL... Greg Shah
08:48 PM Feature #1787: implement batch mode support
1. OK. Understood.
2. Yes, agree. this is not so simple as we want it to be. But actually the UI code is complicat...
Eugenie Lyzenko
10:10 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
About the update:
@methods_attributes.rules@
- header is merged wrong
@KeyBoard@...
Constantin Asofiei
08:20 AM Feature #1801: add some frame options
Yes, I understand. I just don't understand why they would ever have had a protermcap that was not properly setup wit... Greg Shah
08:13 AM Feature #1801: add some frame options
Greg, see the #2210 - @C-LABEL@ is emitted only when compiling (and converting) on UNIX, which they no longer do; the... Constantin Asofiei
07:06 AM Feature #1801: add some frame options
Also, I don't understand how the color names are mapped to the color numbers in the protermcap. The only place the m... Greg Shah
02:02 AM Feature #1801: add some frame options
#2210 was added with details about how the colors in the server project are used. Basically, they are defined in the ... Constantin Asofiei

12/11/2013

06:45 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
Here is following update and several open questions mostly about the FUNCTION implementation.
1) Proposed update w...
Vadim Gindin
02:46 PM Feature #1811: implement the AJAX client driver
I'm using SecurityAdmin instead AdminServerImpl but unfortunately the problem remains the same.
On the server direct...
Marius Gligor
01:57 PM Feature #1811: implement the AJAX client driver
> wouldn't adding them to the "live" security cache generation expose them to the Admin Console
Yes, but that is p...
Greg Shah
01:53 PM Feature #1811: implement the AJAX client driver
I think you should bypass AdminServerImpl entirely and just use SecurityAdmin to add a new user.
> I added AdminSe...
Constantin Asofiei
01:41 PM Feature #1811: implement the AJAX client driver
I added AdminServerImpl.setTargetLive(true) to solve the previous issue but now It said that I have no admin rights. ... Marius Gligor
01:20 PM Feature #1811: implement the AJAX client driver
I tried to create a temporary account when the StandardSever start-up using AdminServerImpl.addUser() but with no suc... Marius Gligor
01:12 PM Feature #1811: implement the AJAX client driver
> Is this the right way that we could follow, using such a connection to get access to the AdminExports interface?
...
Greg Shah
01:00 PM Feature #1811: implement the AJAX client driver
On StandardServer start-up the AdminExports interface is registered:
ifaces = new Class[] { AdminExports.class };
...
Marius Gligor
09:21 AM Feature #1811: implement the AJAX client driver
> 1. I would like to use this helper class to create and delete temporary users. Is this OK?
Yes, this should be O...
Greg Shah
07:41 AM Feature #1811: implement the AJAX client driver
Today I started to implement the direct connection using a strong random subject id and password passed as environmen... Marius Gligor
10:05 AM Feature #1787: implement batch mode support
Code Review 1210a
1. In StandardServer, the call to ErrorManager.initErrorWriterServer() should be placed in regis...
Greg Shah
08:50 PM Feature #1787: implement batch mode support
This update includes some fixes and improvements to make it working under Windows. In this case we have to fully init... Eugenie Lyzenko

12/10/2013

03:48 PM Feature #1811: implement the AJAX client driver
The problem is that on Linux/UNIX, command line args are visible to anyone. Using encryption would require both side... Greg Shah
03:11 PM Feature #1811: implement the AJAX client driver
A more portable solution is to send the random generated user-id and password directly as arguments in command line.
...
Marius Gligor
01:49 PM Feature #1811: implement the AJAX client driver
> Regarding the singleton instance of TransportSecurity please read the javadoc for SecurityManager#getTransportSecur... Greg Shah
01:04 PM Feature #1811: implement the AJAX client driver
OK Thanks. I will try to do that.
Regarding the singleton instance of TransportSecurity please read the javadoc for ...
Marius Gligor
12:30 PM Feature #1811: implement the AJAX client driver
> Only a single auth-mode and a single plugin can be defined per server instance?
No, we allow different auth mode...
Greg Shah
12:29 PM Feature #1811: implement the AJAX client driver
> 1. Could you explain me in a few words what kind of information is stored in this files?
> 2. Is any server depend...
Greg Shah
11:38 AM Feature #1811: implement the AJAX client driver
Inside directory.xml I just found:
<node class="authMode" name="auth-mode">
<node-attribute name="mode" value="...
Marius Gligor
11:10 AM Feature #1811: implement the AJAX client driver
Today I started to learn about SecurityManager and SessionManager which are complex technologies.
So far I investiga...
Marius Gligor
01:52 PM Feature #1801: add some frame options
Please ask Guy for some details. I guess we need to know:
* How do they normally "install" the various custom col...
Greg Shah
01:22 PM Feature #1801: add some frame options
Greg Shah wrote:
> I don't have a copy of the protermcap file, but I suspect that it must be available on lindev01 o...
Constantin Asofiei
12:36 PM Feature #1801: add some frame options
> Do we have access to 4GL file where the custom colors are defined? Because we have color phrases like COLOR C-LABEL... Greg Shah
12:10 PM Feature #1801: add some frame options
The work for #2037 should start with the COLOR implementation. The IN WINDOW clause should be already covered by #202... Constantin Asofiei

12/09/2013

06:39 PM Feature #1811: implement the AJAX client driver
Code Review 1209a
I am fine with the changes.
Greg Shah
02:23 PM Feature #1811: implement the AJAX client driver
This is similar to the additional array approach I noted, but I agree a list (specifically linked list) is a better i... Eric Faulhaber
02:13 PM Feature #1811: implement the AJAX client driver
Eric, about optimizing the @RandomWordGenerator.fillRandomSlots@ - take a look at this approach:
- each possible slo...
Constantin Asofiei
02:02 PM Feature #1811: implement the AJAX client driver
You can also look on devsrv01 at the ~/testing/majic/run/batch/ directory to find examples of batch client configurat... Greg Shah
01:56 PM Feature #1811: implement the AJAX client driver
Eric Faulhaber wrote:
> See @com.goldencode.util.RandomWordGenerator@ and its use in @com.goldencode.persist.Databas...
Eric Faulhaber
01:44 PM Feature #1811: implement the AJAX client driver
> do we have anything already made for appserver that can help us here? How do the new appserver "clients" authentica... Constantin Asofiei
01:36 PM Feature #1811: implement the AJAX client driver
See @com.goldencode.util.RandomWordGenerator@ and its use in @com.goldencode.persist.DatabaseManager.createEmbeddedPr... Eric Faulhaber
12:42 PM Feature #1811: implement the AJAX client driver
Eric has done some work with creating an authentication token for remote database access. Perhaps that can help.
...
Greg Shah
10:14 AM Feature #1811: implement the AJAX client driver
OK. Where I can find such an example in our p2j project? Marius Gligor
09:32 AM Feature #1811: implement the AJAX client driver
Before I get into a deep review of these new options, what about my preferred solution as documented in note 74?
>...
Greg Shah
09:26 AM Feature #1811: implement the AJAX client driver
1. The archive contains some small improvements. I extended the use of quoted string on file name and path strings as... Marius Gligor
06:16 PM Feature #1791: implement dynamic UI support
We will come back to the rest of this later. Let's get the M7 changes tested and committed. Greg Shah
02:00 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
What needs to be done in CHUI/batch mode, for M7 (part of #2018):
- the window system handles all point to the same ...
Constantin Asofiei

12/08/2013

03:32 PM Feature #1787: implement batch mode support
The @GenericFrame.java@ has been merged with the recent code base. Eugenie Lyzenko

12/07/2013

05:31 PM Feature #1787: implement batch mode support
After testing the update for review. What new/changed:
1. The requirement to separate @SET/PROMPT-FOR/UPDATE@ reacti...
Eugenie Lyzenko
05:37 AM Feature #1791: implement dynamic UI support
OK, the implementation looks good. Please merge with the latest revision, remove any changes in LogicalTerminal that ... Constantin Asofiei

12/06/2013

06:14 PM Feature #1791: implement dynamic UI support
Here is the widget-pool (in CREATE statements) simple tests:... Vadim Gindin
12:44 PM Feature #1811: implement the AJAX client driver
I tested the Windows spawner and found to work properly.
I fixed also some issues related to fonts, monospace fonts ...
Marius Gligor
11:55 AM Feature #1811: implement the AJAX client driver
Code Review 1206a
The code is moving forward nicely. Keep up the good work.
Greg Shah
11:15 AM Feature #1811: implement the AJAX client driver
> In other words we can consider also the case on which the size of the box character is equals to font size.
> I ...
Greg Shah
09:30 AM Feature #1811: implement the AJAX client driver
Today I started top test the spawner on Windows OS environment and I found some interesting issues.
1. The font Mo...
Marius Gligor
05:18 AM Feature #1811: implement the AJAX client driver
I changed the winspawn.c to use dynamic DLL link instead a static link.
As a result of this changes the makefile bui...
Marius Gligor

12/05/2013

06:03 PM Feature #1787: implement batch mode support
This update adds stream cases messages and stops for the clients. In addition to error writer implementation when ser... Eugenie Lyzenko
10:42 AM Feature #1787: implement batch mode support
The status update. Almost all statements are verified. The current work is to handle @OUTPUT TO TERMINAL@ statement w... Eugenie Lyzenko
12:18 PM Feature #1811: implement the AJAX client driver
1. For Linux spawner I added PAM support and syslog audit.
Basically the spawner can be build with or without PAM su...
Marius Gligor
10:35 AM Feature #1811: implement the AJAX client driver
I have a Windows 7 64bit OS installed on my laptop.
Using ant native target the 64bit platform is detected and the s...
Marius Gligor
10:23 AM Feature #1811: implement the AJAX client driver
For point 1:
Are you building both 64 bit and 32 bit targets on only 64-bit Windows system?
Eugenie Lyzenko
10:19 AM Feature #1811: implement the AJAX client driver
> libuserenv.a
> libshlwapi.a
What are these?
As a general rule, I prefer to dynamically link to DLLs that are...
Greg Shah
09:39 AM Feature #1811: implement the AJAX client driver
1. I downloaded and copied the MinGW binaries for both Win 32 and Win 64 bit platforms as follow:
c:\mingw32 ...
Marius Gligor
09:52 AM Feature #1791: implement dynamic UI support
DynamicWidgetFactory:
1. max line width is 98, so please format accordingly
2. something I forgot to mention: widge...
Constantin Asofiei

12/04/2013

05:00 PM Feature #1791: implement dynamic UI support
My next update.
Constantin Asofiei wrote:
> Update review:
> # @DynamicWidgetFactory.createWindow@ - I think you...
Vadim Gindin
04:55 PM Feature #1811: implement the AJAX client driver
> Eugenie: do you have any ideas?
I think the best way is to take precompiled binaries(e.g from here: http://code....
Eugenie Lyzenko
02:34 PM Feature #1811: implement the AJAX client driver
I guess I should point out that our ant build.xml and src/native/makefile already works for mingw on 32-bit Windows, ... Greg Shah
02:25 PM Feature #1811: implement the AJAX client driver
> My idea is to use the Linux syslog to audit the execution of child processes.
> Please let me know if you agree th...
Greg Shah
01:16 PM Feature #1811: implement the AJAX client driver
1. Today I succeeded to build the spawner for Windows OS using MinGW compiler.
MinGW does no support main functio...
Marius Gligor
09:57 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
> Also I was expecting that action attribute will work as LABEL attribute..
No, we need the action (aka function) t...
Constantin Asofiei
09:30 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
> # in LT.applyChanges, where do you save lastActionName? I expect it be in some LT instan...
Vadim Gindin
09:09 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
# in LT.applyChanges, where do you save lastActionName? I expect it be in some LT instance field, which later on is r... Constantin Asofiei

12/03/2013

02:14 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
It helped. Current problems.
1) It's hard to summarize behavior of Progress.
1a) We know, that LABEL=ENTRY (high...
Vadim Gindin
11:19 AM Feature #1811: implement the AJAX client driver
> 3. Indeed we can configure sudoers to allow particular command to be executed without any password prompting.
> In...
Greg Shah
10:31 AM Feature #1811: implement the AJAX client driver
1. In think that Windows and non-Windows (which are effectively all UNIX/Linux) detection is enough. Os.java has been... Marius Gligor
08:29 AM Feature #1811: implement the AJAX client driver
About the Windows approach and winspawn.zip:
1. Please do not use the MS VisualStudio or Visual C++ tools. It wou...
Greg Shah
08:23 PM Feature #1811: implement the AJAX client driver
Code Review 1202b
This is really good work. Some feedback:
1. Please look at src/com/goldencode/p2j/util/Envir...
Greg Shah

12/02/2013

06:21 PM Feature #1787: implement batch mode support
This update adds OS-COMMAND support for batch mode. Continue testing for all problematic statements/OS Eugenie Lyzenko
01:04 PM Feature #1811: implement the AJAX client driver
This is the first Windows OS version of our spawner. Its looks and works like the Linux spawner.
I'm using Microsoft...
Marius Gligor
12:39 PM Feature #1811: implement the AJAX client driver
Fixed javadoc errors on ChuiSimulator.java Marius Gligor
11:38 AM Feature #1811: implement the AJAX client driver
Please fix these two javadoc errors as part of your update:... Greg Shah
03:50 AM Feature #1811: implement the AJAX client driver
1. I did some minor changes on the current implementation:
- The target root /chui is now hard coded.
- On the spaw...
Marius Gligor

11/30/2013

10:39 AM Feature #1811: implement the AJAX client driver
I will do the code review next. First, I wanted to get some basic answers to you.
> When the user open https://&l...
Greg Shah
08:54 AM Feature #1791: implement dynamic UI support
Update review:
# @DynamicWidgetFactory.createWindow@ - I think you are missing a return, in case the window can't be...
Constantin Asofiei
08:29 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Are you referring to the fact that you want to access the KeyReader$WorkArea class from @LogicalTerminal.applyChanges... Constantin Asofiei
08:18 AM Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> This means the SESSION:BATCH-MODE attribute has read-only access, not changeable, correct m...
Constantin Asofiei

11/29/2013

03:24 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
I'm sorry, I need to describe the problem more concretely. It is in a fact that we have 2 different WorkArea instance... Vadim Gindin
04:16 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
PS: please upgrade your project and merge the update with the latest P2J revision. Constantin Asofiei
04:14 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
The state synchronization code (ClientState and ServerState) is currently executed in the Reader and Writer threads; ... Constantin Asofiei
02:55 PM Feature #1791: implement dynamic UI support
Well, I'm close to finish this task. See next update.
By the way DISPLAY methods are not implemented. Will we make ...
Vadim Gindin
01:57 PM Feature #2201 (Review): implement the web client process spawning and server redirect
Marius Gligor
10:28 AM Feature #1811: implement the AJAX client driver
1. Spawner is now integrated with p2j project.

- I did minor changes into spawn.c to manage (close) the file...
Marius Gligor
09:04 AM Feature #1787: implement batch mode support
> 5. I assume that when 4GL code does @SESSION:BATCH-MODE = true.@ or @SESSION:BATCH-MODE = false.@ that the 4GL can ... Eugenie Lyzenko

11/28/2013

01:26 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
Here is the code. The problem I can see is that a process that got changes from the client and calls @LogicalTerminal... Vadim Gindin
01:35 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim Gindin wrote:
> I tried to implement but at this moment it don't work.
Well, then tell/show us where you get ...
Constantin Asofiei
01:21 PM Feature #1811: implement the AJAX client driver
This is really good work. It seems very close to what we need. Some feedback:
1. There are a few coding conventi...
Greg Shah
05:28 AM Feature #1811: implement the AJAX client driver
Makefile improvements. Marius Gligor

11/27/2013

05:30 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
> I think the solution will be to push to the server the name of the last event (i.e. the function of the last presse... Vadim Gindin
07:39 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim Gindin wrote:
> > * have you tested the READ-RESPONSE/CONNECT events?
>
> Yes I did. Current implementatio...
Constantin Asofiei
05:19 PM Feature #1787: implement batch mode support
The new drop for review.
1. Completed Javadoc comments.
2. Added handling of @PAUSE@ like processing when we need t...
Eugenie Lyzenko
01:18 PM Feature #1811: implement the AJAX client driver
Add GCC flags on makefile for a RELEASE build not a DEBUG one. Marius Gligor
01:08 PM Feature #1811: implement the AJAX client driver
Today I finished to design and implements a spawner tool working like "su" command but allow us to specify the user p... Marius Gligor
08:23 AM Feature #1791: implement dynamic UI support
The server project uses the @IN WINDOW@ clause only with the @DISPLAY@ statement, in only one program; that program a... Constantin Asofiei
08:17 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Check #1791 note 30 and forward for a discussion for findings about the current-/default-/active-window behaviour in ... Constantin Asofiei

11/26/2013

04:15 PM Feature #1791: implement dynamic UI support
I'm posting update about CREATE WINDOW errors.
IN WINDOW clause is used in a big amount of statements:
ENABLE, f...
Vadim Gindin
11:54 AM Feature #1791: implement dynamic UI support
AFAIK the trigger phrase in the CREATE statement is not used by the server project, so should not be worked by #2027.... Constantin Asofiei
11:50 AM Feature #1791: implement dynamic UI support
I'm sorry, I muddled files with same names in different folders.. My mistake. You're right. Embedded assign works cor... Vadim Gindin
01:32 AM Feature #1791: implement dynamic UI support
Vadim Gindin wrote:
> I'm trying to implement conversion of full form of CREATE WIDGET statement - a form with assig...
Constantin Asofiei
11:27 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
> About the update:
> * AsyncRequestImpl is missing history entry
Thank you, I've added.
...
Vadim Gindin
04:33 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
About the update:
* AsyncRequestImpl is missing history entry
* have you tested the READ-RESPONSE/CONNECT events?
...
Constantin Asofiei

11/25/2013

05:39 PM Feature #1791: implement dynamic UI support
I am surprised that the "embedded assign" portion is not working. I think it was working properly back in April.
...
Greg Shah
05:04 PM Feature #1791: implement dynamic UI support
I'm trying to implement conversion of full form of CREATE WIDGET statement - a form with assign statement.
I wrote s...
Vadim Gindin
12:47 PM Feature #1791: implement dynamic UI support
Right now we store it on the server in EnvironmentOps. See isBatchMode() and setBatchMode() in that class.
We als...
Greg Shah
12:24 PM Feature #1791: implement dynamic UI support
How to distinguish batch mode from usual mode? Vadim Gindin
02:48 PM Feature #1787: implement batch mode support
The update for your review. Includes:
1. ErrorWriter is cleaned from UI related classes.
2. ErrorWriter* implementa...
Eugenie Lyzenko
01:28 PM Feature #1787: implement batch mode support
> So do we need to have two separate error writer implementations, one for client side and one for server side?
Ye...
Greg Shah
01:08 PM Feature #1787: implement batch mode support
> Yes, the described approach should eliminate this dependency.
OK. I have cleaned almost everything UI related fr...
Eugenie Lyzenko
10:14 AM Feature #1787: implement batch mode support
> This is the state before I started to work on batch mode. And the client member is used in ErrorManager class.
...
Greg Shah
09:26 AM Feature #1787: implement batch mode support
The question.
> 6. The ErrorManager class must NOT have any references to com.goldencode.p2j.ui.* or any UI relate...
Eugenie Lyzenko
01:08 PM Feature #1811: implement the AJAX client driver
> In this case the p2j design should be slightly changed to provide paths inside the user account home directory for ... Greg Shah
12:35 PM Feature #1811: implement the AJAX client driver
New changes in the current design.

1. In p2j when the user open the following URL https://<host>:<admin_port>/c...
Marius Gligor
09:50 AM Feature #1811: implement the AJAX client driver
This is really good work. Some thoughts:
1. Each spawned process must have a controlling terminal. You can use t...
Greg Shah
12:23 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
By the way. When user presses the button (RETURN key code), key function is CHOOSE (EVENT-TYPE:PROGRESS). In other ca... Vadim Gindin
12:09 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
Here is next update. LABEL is implemented correctly but EVENT-TYPE is not implemented correctly.
When user presses th...
Vadim Gindin

11/24/2013

08:47 AM Feature #1787: implement batch mode support
Code Review 1119a
This is a move in the right direction, but there are some important changes to make:
1. The E...
Greg Shah
08:13 AM Feature #1787: implement batch mode support
The idea makes sense. Greg Shah

11/23/2013

04:14 PM Feature #1787: implement batch mode support
The question. I'm working on PAUSE statement handling for batch mode and other statements like this that silently ign... Eugenie Lyzenko
03:29 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Vadim Gindin wrote:
> I found that EVENT-TYPE for Key Functions: CHOOSE, VALUE_CHANGED, DEFAULT_ACTION is PROGRESS. ...
Constantin Asofiei
07:08 PM Feature #1791: implement dynamic UI support
Good. Make sure to generate the proper errors in our code. That means that we should be pretty safe for M7. Greg Shah

11/22/2013

04:55 PM Feature #1791: implement dynamic UI support
Simple test:... Vadim Gindin
04:17 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
Constantin Asofiei wrote:
>..
> * Keyboard.isSynth - make sure the javadoc can be seen nicely in html (i.e. add a <...
Vadim Gindin
07:05 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
Two notes about the changes:
* Keyboard.java - unneeded import
* Keyboard.isSynth - make sure the javadoc can be se...
Constantin Asofiei
11:38 AM Feature #1811: implement the AJAX client driver
Today I started to do tests using the spawn command written in C.
Here are the results.
I did some changes inside...
Marius Gligor
 

Also available in: Atom