Project

General

Profile

Activity

From 01/16/2014 to 02/14/2014

02/14/2014

05:37 PM Feature #1805: add missing UI method support
Good findings. Go ahead and implement the proper behavior.... Greg Shah
05:56 AM Feature #1805: add missing UI method support
1) query is not opened.... Vadim Gindin
12:00 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> Here are the changes which passed today regression tests.
You can go ahead and release it.
Constantin Asofiei
11:49 AM Feature #1811: implement the AJAX client driver
Here are the changes which passed today regression tests. Marius Gligor
11:04 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I fixed this issue by replacing the "monospaced" with "monospace" in tty.screen.js line 377 b...
Constantin Asofiei
10:57 AM Feature #1811: implement the AJAX client driver
1. Regarding fonts: During development I realized that fonts are rendered slightly different on web browsers and Java... Marius Gligor
09:16 AM Feature #1811: implement the AJAX client driver
I found another problem in @ClientCore@ this time. There are cases when the P2J Client terminates via @System.exit@. ... Constantin Asofiei
07:26 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I saw that you already did some changes inside WebClientSpawner and the code was moved to Cli...
Constantin Asofiei
07:23 AM Feature #1811: implement the AJAX client driver
I saw that you already did some changes inside WebClientSpawner and the code was moved to ClientSpawner.
However the ...
Marius Gligor
07:15 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> The bug must be fixed in line 123 as follow:
OK, I'll include the fix with my #2124 update, ...
Constantin Asofiei
07:07 AM Feature #1811: implement the AJAX client driver
Unfortunately I found another NPE bug which occur if the spawn or spawn.exe is missing.
In this case the ProcessBuil...
Marius Gligor
06:52 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I just manage to reproduce the bug. I started than I stopped the server without any other act...
Constantin Asofiei
06:46 AM Feature #1811: implement the AJAX client driver
I just manage to reproduce the bug. I started than I stopped the server without any other action and the bug occurs.
...
Marius Gligor
06:32 AM Feature #1811: implement the AJAX client driver
TemporaryAccountWorker thread is used to enable/disable temporary accounts.
Since this operation require a specific ...
Marius Gligor
06:12 AM Feature #1811: implement the AJAX client driver
It's a bug. In TemporaryAccountWorker line 119 I omitted to check the callerLatch for null value.
The correct code s...
Marius Gligor
05:38 AM Feature #1811: implement the AJAX client driver
Marius, I've managed to get a NPE in @TemporaryAccountPoolWorker@:... Constantin Asofiei
06:04 AM Feature #1787: implement batch mode support
Constantin, The config options to start batch mode is:
@swing="client:driver:type=chui_batch client:driver:backgroun...
Eugenie Lyzenko
05:05 AM Feature #1787: implement batch mode support
Eugenie, I've used this configuration to start a client, on linux: @client:driver:type=chui_batch client:mode:batch=t... Constantin Asofiei

02/13/2014

02:38 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The assumption that they were using a circular linked list is valid, but the rules to add the new field-group are obs... Constantin Asofiei
08:36 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> 1. Strange, but access sibling attributes (PREV-SIBLING, NEXT-SIBLING) of field-groups itself distorted generated g... Constantin Asofiei
01:09 PM Feature #1787: implement batch mode support
The update uploaded that implements the messageBox() processing for background mode for you to review. The simulated ... Eugenie Lyzenko
07:49 AM Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> > Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p...
Constantin Asofiei
07:39 AM Feature #1787: implement batch mode support
> Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p with a MESSAGE ... VIEW-A... Eugenie Lyzenko
04:52 AM Feature #1787: implement batch mode support
LE: the @all the pro -b, bpro, and prowin32 -b ways of starting a batch program@ part needs to be expanded with (for ... Constantin Asofiei
04:40 AM Feature #1787: implement batch mode support
Eugenie: the modal message boxes are not supported by background mode. On linux @pro -b -p@ with a @MESSAGE ... VIEW-... Constantin Asofiei
12:23 PM Feature #1811: implement the AJAX client driver
Code Review 0213b
The changes look good. Please get it runtime regression tested.
Greg Shah
11:22 AM Feature #1811: implement the AJAX client driver
Renamed sync() method to initRemoteTerminal()
I implemented also the screen characters message caching.
Marius Gligor
10:52 AM Feature #1811: implement the AJAX client driver
OK. I have an idea to cache also the text messages. I'm going to implements this feature.
Marius Gligor
10:47 AM Feature #1811: implement the AJAX client driver
Code Review 0213a
I am fine with the code, except for 1 change. I should have looked more carefully at the @sync(...
Greg Shah
09:06 AM Feature #1811: implement the AJAX client driver
1. Regarding sync() method. This is a private method called from the onConnect(session) method, when a new session is... Marius Gligor
09:08 AM Feature #2240 (Review): implement proper color support in the Swing ChUI and AJAX ChUI clients
Marius Gligor

02/12/2014

06:04 PM Feature #1811: implement the AJAX client driver
Code Review 0212a
1. Please note that our maximum line length is 98 characters. The docs haven't been updated. Y...
Greg Shah
12:42 PM Feature #1811: implement the AJAX client driver
1. AWT Color instances are build using now RGB values in ColorPalette.
2. The code used to set the Font color attr...
Marius Gligor
04:14 PM Feature #1805: add missing UI method support
I'm not sure. Having it on our list may be just a mistake. Please write a testcase (or find one in the testcases/ua... Greg Shah
01:57 PM Feature #1805: add missing UI method support
As far as I can see @DESELECT-ROWS@ method is really implemented.. What needs to be done in the task #2144 for this t... Vadim Gindin

02/11/2014

05:41 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm trying to identify when the Progress creates auxiliary field-group. There are possible 2 variants:
1. Progress cr...
Vadim Gindin
05:34 PM Feature #1811: implement the AJAX client driver
Code Review 0211a
1. In ColorPalette, let's use RGB values instead of the AWT Color instances. This is more unive...
Greg Shah
05:25 PM Feature #1811: implement the AJAX client driver
> 2. According to the P4G manuals the DEFAULT_COLOR_TABLE has 16 colors (0...15) which are reserved, that is, SHOULD ... Greg Shah
12:54 PM Feature #1811: implement the AJAX client driver
> Seems that pfcolor 3 cannot be converted or not supported.
Looks like PFCOLOR is parsed ok and a valid AST is...
Hynek Cihlar
11:56 AM Feature #1811: implement the AJAX client driver
Based on the current COLOR implementation for ChUI native driver I implemented the COLOR for ChUI Swing driver too. (... Marius Gligor
01:54 PM Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
Also note that PFCOLOR in the other statements doesn't generate the actual assignment. So the only option to set PFCO... Hynek Cihlar
01:51 PM Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
The code ... Hynek Cihlar
01:09 PM Bug #2241 (New): Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
Hynek Cihlar
06:39 AM Feature #1787: implement batch mode support
This is the log after running run_batch.p on windev01 within an appserver. Same as input redirection on linux: all te... Constantin Asofiei
06:15 AM Feature #1787: implement batch mode support
Eugenie, I've ran the attached program (which executes all your tests except @batch_test0.p@) using the @pro -b -p ru... Constantin Asofiei

02/10/2014

04:16 PM Feature #1787: implement batch mode support
Testcases have been added. Eugenie Lyzenko
10:15 AM Feature #1811: implement the AJAX client driver
Today I did a lot of investigations related to COLOR implementation on CHUI Swing and WEB clients.
First I attached ...
Marius Gligor
08:51 AM Feature #1811: implement the AJAX client driver
Please add some javadoc to describe these important points. Greg Shah
02:14 AM Feature #1811: implement the AJAX client driver
We have 2 jetty handlers for two targets ./ and ./index.html which load the same page:
1. When the user is first r...
Marius Gligor

02/09/2014

01:08 PM Feature #1811: implement the AJAX client driver
I am not sure how the custom colors will be defined for the Swing and Web chuis, but at the moment color-map.xml may ... Hynek Cihlar
12:37 PM Feature #1811: implement the AJAX client driver
> Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which ... Hynek Cihlar

02/07/2014

06:39 PM Feature #1811: implement the AJAX client driver
Marius, I'm merging your 0206a.zip update with mine and mainPage and indexPage handlers in ChuiWebDriver.startupServe... Constantin Asofiei
12:53 PM Feature #1811: implement the AJAX client driver
First, I should have previously mentioned that details about the most recent color work can be found in #1801.
> 1...
Greg Shah
12:13 PM Feature #1811: implement the AJAX client driver
Today I started to work on issue #2240 regarding color implementation on swing and web chui clients.
I studied the i...
Marius Gligor
09:33 AM Feature #1811: implement the AJAX client driver
Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459.
Marius Gligor
08:23 AM Feature #1811: implement the AJAX client driver
Yes. You just need to post your assessment of the regression testing into Redmine, not the results themselves. At t... Greg Shah
08:21 AM Feature #1811: implement the AJAX client driver
May I delete the attached files containing the test results? Marius Gligor
08:15 AM Feature #1811: implement the AJAX client driver
The tc_job_002 is expected to fail at that point, so this testing passes.
Please commit the update and distribute it.
Greg Shah
08:00 AM Feature #1811: implement the AJAX client driver
Here are the results of my regression tests.
For the first time the CTRL-C test passed.
The main test part has onl...
Marius Gligor
06:22 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Well, I finished the test for the case of any sequence of DOWN and UP calls.
Test: _mixedupdown1.p_
Description: Th...
Vadim Gindin
09:43 AM Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
Greg Shah
09:07 AM Feature #2238 (Review): investigate and resolve issues related to browser "session management"
Marius Gligor
09:42 AM Feature #2212 (Closed): design websockets protocol for bidirectional communication between the ja...
Greg Shah
09:30 AM Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459.
Marius Gligor
09:07 AM Feature #2212 (Review): design websockets protocol for bidirectional communication between the ja...
Marius Gligor
04:11 AM Feature #2240 (WIP): implement proper color support in the Swing ChUI and AJAX ChUI clients
Marius Gligor

02/06/2014

12:44 PM Feature #1811: implement the AJAX client driver
I sow now that is missing. It wasn't add to bzr. I will include this file also on the next commit.
Thanks.
Marius Gligor
12:38 PM Feature #1811: implement the AJAX client driver
Marius, a note about 0129a.zip: the archive has a @tty.keymap.js@ file which is not in bzr rev 10457. Please check 01... Constantin Asofiei
12:11 PM Feature #1811: implement the AJAX client driver
Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which is... Greg Shah
12:06 PM Feature #1811: implement the AJAX client driver
OK. Get this regression tested. Greg Shah
12:02 PM Feature #1811: implement the AJAX client driver
From my point of view I think no. Marius Gligor
11:57 AM Feature #1811: implement the AJAX client driver
Code Review 0206a
It looks really good. Other than adding real color support, is there anything else left to do?
...
Greg Shah
11:45 AM Feature #1811: implement the AJAX client driver
Sorry, it was my mistake. I have a short script to build the archive and I had a small problem inside the script.
Pl...
Marius Gligor
10:50 AM Feature #1811: implement the AJAX client driver
Were the changes to tty.screen.js and tty.socket.js deliberately removed from 0206a? Greg Shah
10:14 AM Feature #1811: implement the AJAX client driver
1. The WAIT_TO_DIE javadoc is inaccurate.
Done.
2. Please rename the sartWatchdog() to startWatchdog().
Do...
Marius Gligor
12:08 PM Feature #2240 (Closed): implement proper color support in the Swing ChUI and AJAX ChUI clients
Greg Shah

02/05/2014

03:04 PM Feature #1811: implement the AJAX client driver
Code Review 0205a
1. The WAIT_TO_DIE javadoc is inaccurate.
2. Please rename the sartWatchdog() to startWatchdo...
Greg Shah
10:29 AM Feature #1811: implement the AJAX client driver
Here are the latest changes. I fixed also the issue related to isatty() when using spawner.
It was a bug on my spawn...
Marius Gligor

02/04/2014

03:12 PM Feature #1811: implement the AJAX client driver
Indeed. The watchdog timer has been designed to terminate the process when the user close the browser.
Even more whe...
Marius Gligor
02:47 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> 3. As Constantin noted above, it is a common case for these clients to be left running for a very...
Constantin Asofiei
01:26 PM Feature #1811: implement the AJAX client driver
Code Review 0204a
Overall, this is very good.
1. In ChuiWebSimulator, please synchonize any access or assignmen...
Greg Shah
09:40 AM Feature #1811: implement the AJAX client driver
Here is the implementation of text attributes (color)
I found the following attributes defined (see ColorAttribute)....
Marius Gligor
08:17 PM Feature #1811: implement the AJAX client driver
> - the untrusted connection issue will be annoying for "live" usage; for testing is OK, but having to go through thi... Greg Shah
08:11 PM Feature #1811: implement the AJAX client driver
Code Review 0203b
I am fine with this change.
Greg Shah
03:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> Field-group creation is seemed straightforward except @UP@ direction.
OK, I understand now. M...
Constantin Asofiei
08:49 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> Greg: Vadim I think is talking about a way to identify a field-group without using the h...
Vadim Gindin

02/03/2014

03:16 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Greg: Vadim I think is talking about a way to identify a field-group without using the handle ID in 4GL code, not in ... Constantin Asofiei
03:05 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The NAME can still be interrogated from converted 4GL code, right? That means there could be code that relies upon t... Greg Shah
01:58 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I found that I can use the @NAME@ attribute for that purpose (mark the field-group). This attribute has unknown value... Vadim Gindin
12:31 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I tried to find out what algorithm is used to generate new field-groups and to reuse existed. The case 3 in my previo... Vadim Gindin
08:13 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I assume it is possible to access the PRIVATE-DATA for a FIELD-GROUP widget in 4GL code, which means using that attri... Greg Shah
12:18 PM Feature #1811: implement the AJAX client driver
In regard to the libffi issue, please see note 74 in #1634. Greg Shah
12:05 PM Feature #1811: implement the AJAX client driver
During the weekend I tried to do some tests on Windows OS and I found two important issues:
1. The File.renameTo(F...
Marius Gligor
10:31 AM Feature #1811: implement the AJAX client driver
In regard to 0203a, I have some minor concerns with the ClientDriver changes, but please go ahead and commit/distribu... Greg Shah
09:52 AM Feature #1811: implement the AJAX client driver
The changes look good to me. If Greg has no objections, you can release them. Constantin Asofiei
09:45 AM Feature #1811: implement the AJAX client driver
Here are the package that I used today on the regression tests.
Passed the regression tests.
Marius Gligor

02/01/2014

08:42 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> There are an array of predefined FIELD-GROUP ids and we are calculating actual index (fgidx) i...
Constantin Asofiei
06:09 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
There are possible several principally different cases:
1. Simple case: All DOWN calls have equal steps size. As it ...
Vadim Gindin

01/31/2014

02:35 PM Feature #1811: implement the AJAX client driver
Marius, about 0131c.zip:
* please make an update without the JS changes in the .html files, and get it conversion te...
Constantin Asofiei
11:31 AM Feature #1811: implement the AJAX client driver
1. The user Refresh action could not be detected. Is the same like closing the browser.
When the user reload the ...
Marius Gligor
08:28 AM Feature #1811: implement the AJAX client driver
I added the ClientDriver log file redirection implementation. Marius Gligor
08:11 AM Feature #1811: implement the AJAX client driver
1. The redirection to a log file is not possible from ProcessBuilder because we redirect the stderr for spawner not f... Marius Gligor
07:40 AM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 1. Put screen color message statement isn't implemented on the web client. I have to check ho...
Constantin Asofiei
06:45 AM Feature #1811: implement the AJAX client driver
A better way to prevent back navigation by editing history.
Marius Gligor
06:01 AM Feature #1811: implement the AJAX client driver
1. Put screen color message statement isn't implemented on the web client. I have to check how to do that. Could you ... Marius Gligor
05:33 AM Feature #1811: implement the AJAX client driver
Marius, 0131a.zip solves the login problem (I'll let Greg do a full review), but there are some other issues in MAJIC... Constantin Asofiei
03:07 AM Feature #1811: implement the AJAX client driver
I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web...
Marius Gligor
01:12 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Marasmus... there is no shift. It's my mistake. It because of wrong order of operations: displaying the value, execut... Vadim Gindin
11:28 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> The field-groups are used to group widgets together (as their names say). It is a lot ea...
Vadim Gindin
08:57 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I just don't understand the logic of field-groups. Why authors decided to use spare field-grou...
Constantin Asofiei
03:09 AM Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
Correct post location is Feature #1811. Please delete my posts. Marius Gligor
03:05 AM Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web...
Marius Gligor

01/30/2014

06:16 PM Feature #1811: implement the AJAX client driver
> 1. The browser context menu can be controlled from JS on all major web browsers IE, Firefox and Chrome:
Go ahead...
Greg Shah
01:56 PM Feature #1811: implement the AJAX client driver
OK Constatin thanks. Tomorrow I will try to fix this issue.
Are you did tests with the web client? How it's works?
Marius Gligor
01:52 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I think that using the temporary accounts implementation is OK to authenticate for server key...
Constantin Asofiei
01:43 PM Feature #1811: implement the AJAX client driver
OK. In this case I have to do some changes on the ClientCore and potentially on other places.
I think that using the...
Marius Gligor
01:36 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> At this moment what I understood is as follow:
> 1. Use the temporary account to connect to ...
Constantin Asofiei
01:33 PM Feature #1811: implement the AJAX client driver
OK. I have to think to this issue.
At this moment what I understood is as follow:
1. Use the temporary account...
Marius Gligor
12:57 PM Feature #1811: implement the AJAX client driver
Marius, I think there is a problem with the temporary accounts. If I understood properly, the process of authenticat... Constantin Asofiei
12:20 PM Feature #1811: implement the AJAX client driver
The changes inside the mag_upd20140129a.zip archive has been committed to bzr revision 10457 Marius Gligor
11:33 AM Feature #1811: implement the AJAX client driver
Please check in and distribute the 0129a update. Make sure to post the bzr revision number here. Greg Shah
11:24 AM Feature #1811: implement the AJAX client driver
Regarding browser session and JS code.
The web browser are designed to navigate over the Internet and for security ...
Marius Gligor
11:08 AM Feature #1811: implement the AJAX client driver
After three executions of CTRL-C part regression tests I obtained the same results (see attachments).
The main part ...
Marius Gligor
08:11 AM Feature #1811: implement the AJAX client driver
> To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
No, it is...
Greg Shah
07:49 AM Feature #1811: implement the AJAX client driver
To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
We could add ...
Marius Gligor
07:44 AM Feature #1811: implement the AJAX client driver
> The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifes... Greg Shah
07:43 AM Feature #1811: implement the AJAX client driver
> Maybe for safety it's a good idea to design and implements something like a "watchdog" timer used to force an exit ... Greg Shah
06:40 AM Feature #1811: implement the AJAX client driver
When the page having the JS code running is loaded a WebSocket connection is open.
If the user close the browser the...
Marius Gligor
02:28 AM Feature #1811: implement the AJAX client driver
The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifest ... Marius Gligor
02:16 AM Feature #2238 (WIP): investigate and resolve issues related to browser "session management"
Marius Gligor

01/29/2014

06:14 PM Feature #1788: implement define rectangle and rectangle widget support
For now this will only be implemented in ChUI mode.
Start by writing 4GL testcases to show the features of the rec...
Greg Shah
05:29 PM Feature #1811: implement the AJAX client driver
For #2238: the following are some potential issues that we need to consider/research. Document your thoughts and fin... Greg Shah
05:18 PM Feature #1811: implement the AJAX client driver
Code Review 0129a
There are no concerns. Please note that I don't plan to check in the Dojo build, into bzr. I a...
Greg Shah
02:05 PM Feature #1811: implement the AJAX client driver
Here is the package that I tested today. The package contains the new jetty 9.1 build.
Due to it size the Dojo zip f...
Marius Gligor
05:20 PM Feature #2238: investigate and resolve issues related to browser "session management"
Please put all history into the parent task, #1811. Greg Shah
05:20 PM Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
Greg Shah
11:33 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I just don't understand the logic of field-groups. Why authors decided to use spare field-group?! I just don't see an... Vadim Gindin

01/28/2014

02:30 PM Feature #1811: implement the AJAX client driver
Code Review 0128c
The code looks good.
> but just for safety is OK.
Exactly.
> 1. We are not use Dojo at ...
Greg Shah
01:47 PM Feature #1811: implement the AJAX client driver
I did the changes. Normally no concurrency should occur on this class but just for safety is OK.
I have two other ...
Marius Gligor
01:28 PM Feature #1811: implement the AJAX client driver
> Sorry, but I don't find any place in this class to use synchronization.
> The open and close methods are synchroni...
Greg Shah
01:13 PM Feature #1811: implement the AJAX client driver
Sorry, I changed the date of last changes on the ClientBuilderOptions class header. Marius Gligor
01:08 PM Feature #1811: implement the AJAX client driver
1. Done. ChuiWebSimulator.onConnect allow us to set the session idle time out which in turn override the default valu... Marius Gligor
12:52 PM Feature #1811: implement the AJAX client driver
> The ConcurrentHashMap is fully thread safe by design and is internally synchronized.
> The Java concurrent package...
Greg Shah
11:44 AM Feature #1811: implement the AJAX client driver
I added the missing Result class.
The ConcurrentHashMap is fully thread safe by design and is internally synchronize...
Marius Gligor
11:33 AM Feature #1811: implement the AJAX client driver
Code Review 0128a
1. In ChuiWebSimulator, I would like to shift to an idle timeout (maxIdleTime) that is set progr...
Greg Shah
10:46 AM Feature #1811: implement the AJAX client driver
Here is the implementation for CTRL-C issue and some remarks.
1. A Result object is used instead a boolean value.
...
Marius Gligor
05:46 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Greg Shah wrote:
> I prefer an approach where multiuple virtual widgets on the server resolve to the correct widget ...
Constantin Asofiei
05:32 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
We need be careful when using conditional down (@DOWN WITH FRAME f1@, without an expression) and explicit down (i.e. ... Constantin Asofiei

01/27/2014

06:29 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As we are getting close to the time for implementation, I want to mention something.
I would like to consider an i...
Greg Shah
06:12 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I suppose I can formulate some rule, interpreting the rules, that Progress uses to fill fields with values.
We have ...
Vadim Gindin
05:43 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> > The only unclear moment is the algorithm of Fill-in filling with values for me.
> I'm...
Vadim Gindin
04:06 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> The only unclear moment is the algorithm of Fill-in filling with values for me.
I'm not sure what you are refering...
Constantin Asofiei
03:58 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've committed all test procedures I had.
The result of stream test _(streams.p)_ is in file _2162_ext_frame_stre...
Vadim Gindin
10:35 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Please commmit the tests for note 36/37 to bzr.
> About cyclic order of field groups I confirm it. All tests show i...
Constantin Asofiei
09:51 AM Feature #1811: implement the AJAX client driver
Code Review 0127a
I am fine with the code. It looks very good.
My only request is for tty.keyboard.js, tty.key...
Greg Shah
09:40 AM Feature #1811: implement the AJAX client driver
> B. Another solution is to use the existing RemoteObject to get a new account and do a re-logon. This scenario shoul... Greg Shah
08:30 AM Feature #1811: implement the AJAX client driver
1. Today I did a code review over the JS code. The changes are attached.
2. Also I started to investigate the CTRL...
Marius Gligor

01/25/2014

04:57 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
About cyclic order of field groups I confirm it. All tests show it. About Fill-in fields - they have equal IDs at all... Vadim Gindin
07:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are next tests.
1. Test: _frame_line.p_
Description: The goal is to find out is the FRAME-LINE function and ...
Vadim Gindin
10:45 AM Feature #1811: implement the AJAX client driver
It is good, thanks. Greg Shah
10:43 AM Feature #1811: implement the AJAX client driver
Sorry, was my fault. Marius Gligor
10:38 AM Feature #1811: implement the AJAX client driver
Code Review 0125c
I like it. The only thing I don't understand is why the tty.keymap.js is missing.
Greg Shah
10:26 AM Feature #1811: implement the AJAX client driver
Done. Marius Gligor
10:00 AM Feature #1811: implement the AJAX client driver
Code Review 0125b
I like this version better from the perspective of how you made the code better separated.
Bu...
Greg Shah
09:55 AM Feature #1811: implement the AJAX client driver
Code Review 0125a
I don't want to remove all the server-side Dojo support that you already provided. Put that wor...
Greg Shah
09:46 AM Feature #1811: implement the AJAX client driver
The keyboard listeners are bind on canvas instead document.
The canvas should have the focus in order to receive key...
Marius Gligor
06:31 AM Feature #1811: implement the AJAX client driver
Looking for a solution to fix the cross browser keystrokes handle issues I found:
Supported Key Combinations:
The...
Marius Gligor
09:29 AM Feature #2037 (Closed): runtime support for frame options
Greg Shah
09:29 AM Feature #1801: add some frame options
Attached is the actual version that is the merged code that was checked in as 10451. Greg Shah

01/24/2014

06:40 PM Feature #2037 (Review): runtime support for frame options
Hynek Cihlar
06:38 PM Feature #1801: add some frame options
hc_upd20140123b.zip passed regression testing and was checked-in to bazaar repository as revision 10451. Hynek Cihlar
04:06 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What do you mean when you are saying "the frame starts with only one field-group (for the firs...
Constantin Asofiei
03:53 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> Why it is needed to have downBody array with only the first row real?
The problems are in th...
Constantin Asofiei
01:56 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
What do you mean when you are saying "the frame starts with only one field-group (for the first row). When advancing ... Vadim Gindin
01:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As I can understand this, it sounds reasonable. I just have several questions about details. See below.
Constantin...
Vadim Gindin
03:19 PM Feature #1811: implement the AJAX client driver
> I saw that when a pop-up window is created we can eliminate menu bars and toll bars.
> Do you believe that could b...
Greg Shah
02:27 PM Feature #1811: implement the AJAX client driver
Starting from IE 9 preventDefault() is supported. We are interested on IE 10 and IE 11 because IE 9 does not support ... Marius Gligor
02:20 PM Feature #1811: implement the AJAX client driver
Code Review 0124c
My only thought here is that we probably need to always preventDefault() and stopImmediatePropag...
Greg Shah
02:17 PM Feature #1811: implement the AJAX client driver
To disable default behavior you may have to do 2 things:
1. Prevent the default behavior. In browsers that suppor...
Greg Shah
01:48 PM Feature #1811: implement the AJAX client driver
Some small changes to fix ESC key in IE.
I did more tests on Windows using IE 11 and Chrome 31.
Unfortunately on ...
Marius Gligor
12:02 PM Feature #1811: implement the AJAX client driver
It's works in IE but I have to fix a small issue. Event preventDefault() does not work properly with IE.
I tested bo...
Marius Gligor
11:33 AM Feature #1811: implement the AJAX client driver
1. We have to solve the CTRL-C issue to initialize the converted application without a new server authentication if p... Marius Gligor
10:58 AM Feature #1811: implement the AJAX client driver
Can you please post a list of what is left to do on #2212? Greg Shah
10:51 AM Feature #1811: implement the AJAX client driver
Code Review 0124a
All the changes look good. I like the more modular approach.
Code Review 0124b
I prefer t...
Greg Shah
10:40 AM Feature #1811: implement the AJAX client driver
I did some small improvements and bug fixing. Basically I eliminated the dojo/keys module dependencies.
With this ch...
Marius Gligor
11:53 AM Feature #1787: implement batch mode support
This was committed as bzr revision 10449. Greg Shah
10:20 AM Feature #1787: implement batch mode support
The testing results are in:
@10446_f202309_20140124_evl.zip@
Taking into account all sessions the testing has been ...
Eugenie Lyzenko
09:53 AM Feature #1787: implement batch mode support
Code Review 0124a
All the merges look good. Considering that the only tricky merging was in the build scripts, I ...
Greg Shah
09:29 AM Feature #1787: implement batch mode support
The code merge with the 10447. Looks like there are no regressions found.
Do I need to commit and distribute?
Eugenie Lyzenko

01/23/2014

06:02 PM Feature #1801: add some frame options
It looks good. Go ahead with testing. Greg Shah
05:47 PM Feature #1801: add some frame options
Yes, the application will work ok without the color-map.xml file on the classpath. Just an info log entry will be out... Hynek Cihlar
05:28 PM Feature #1801: add some frame options
Code Review 0123a
I am fine with the version, except that the color-map.xml should not be checked into the P2J pro...
Greg Shah
04:56 PM Feature #1801: add some frame options
The attached file includes runtime support of the DCOLOR and PFCOLOR attributes. Hynek Cihlar
04:34 PM Feature #1801: add some frame options
The implementation is finished. I am doing basic functional tests and will be uploading for review in about half an h... Hynek Cihlar
04:13 PM Feature #1801: add some frame options
How soon can you upload a candidate for review? I will get it reviewed quickly and hopefully it will be ready for re... Greg Shah
03:58 PM Feature #1801: add some frame options
Here are the findings.
@DCOLOR@ and @PFCOLOR@ exist only in the form of attributes of INTEGER type. For the chara...
Hynek Cihlar
05:13 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, good findings, but you are misinterpreting something. When you are printing the frame's children in @no-loop-i... Constantin Asofiei
02:08 PM Feature #1787: implement batch mode support
Looks like the main part is OK. Continue testing with CTRL-C one. Eugenie Lyzenko
01:50 PM Feature #1811: implement the AJAX client driver
Code Review 0123a
This is really, really good! I'm glad that you were able to work out an approach that is much m...
Greg Shah
12:01 PM Feature #1811: implement the AJAX client driver
1. The DOM level 3 events specifications are implemented total or partial on all major web browser but sligtly differ... Marius Gligor

01/22/2014

06:52 PM Feature #1801: add some frame options
I don't fully know the answer. I think you will have to do some testing in the real 4GL.
I do know how we have co...
Greg Shah
06:15 PM Feature #1801: add some frame options
A question about DCOLOR and PFCOLOR. Is the following sample the correct way to set the protermcap color?... Hynek Cihlar
06:30 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm repeating that i:handle peculiarities are the same in iterating and non-iterating tests. All tests I have are com... Vadim Gindin
06:27 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
2. _external_scoped_frame_ihandle.p_ This test checks behavior of the CURRENT-ITERATION in repeat loop in case when t... Vadim Gindin
06:14 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are tests and those results.
1. _no_loop_ihandle.p_. Try to check CURRENT-ITERATION behavior in the case when...
Vadim Gindin
11:38 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What else can I do to find when a widget row is created?
Check your findings with cases when ...
Constantin Asofiei
11:28 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> Vadim, using the test at note 15, check how the body of a down frame evolves in the case...
Vadim Gindin
11:27 AM Feature #1787: implement batch mode support
Code Review 0122a
It looks good. Get it regression tested.
Greg Shah
10:49 AM Feature #1787: implement batch mode support
The update clears the notes for previous code review and merges with the recent codebase from bzr. Eugenie Lyzenko
09:14 AM Feature #1787: implement batch mode support
> 2. I'm surprised that we don't have to link with additional libraries for pthreads on Linux or the event semaphore ... Eugenie Lyzenko
08:41 AM Feature #1787: implement batch mode support
Code Review 0121a
1. After you use throwException() in native code, please don't use @exit(-1)@. Just use @return...
Greg Shah
09:09 AM Feature #1811: implement the AJAX client driver
OK, these are good findings.
Please review the DOM level 3 events specification: http://www.w3.org/TR/DOM-Level-3-...
Greg Shah
07:51 AM Feature #1811: implement the AJAX client driver
I did some small changes and improvements.
Also I tested a version using native JS instead Dojo. The results are the...
Marius Gligor
04:54 AM Feature #1811: implement the AJAX client driver
I Tested your code and here are my conclusions:
1. The code does not work at all on IE (Windows) web browser.
...
Marius Gligor

01/21/2014

05:58 PM Feature #1787: implement batch mode support
This is the release candidate for review. Works for 64-bit Windows. Need to check with 32-bit, later today. Eugenie Lyzenko
04:52 PM Feature #1787: implement batch mode support
OK, it makes sense. Change all the names to be @signals*@ instead of @signal*@. Greg Shah
04:20 PM Feature #1787: implement batch mode support
Almost all is ready. One point to discuss:
We can not use @signal.h@ as local header file for our library call. It c...
Eugenie Lyzenko
08:48 AM Feature #1787: implement batch mode support
I am fine with the use of a semaphore to block waiting for the signal. As noted above, this can be implemented the s... Greg Shah
08:47 AM Feature #1787: implement batch mode support
> The folowing code works fine in standalone application but does not work in library(like libp2j):
I have not che...
Greg Shah
08:45 AM Feature #1787: implement batch mode support
Code Review 0120b
1. We don't need calls to the ClientCore.loadNativeP2JLibrary() from many different files. We o...
Greg Shah
08:15 PM Feature #1787: implement batch mode support
This update adds the Windows implementation for @SIGINT@ handler. Works in Windows 7 64-bit in virtual machine. Conti... Eugenie Lyzenko
04:11 PM Feature #1811: implement the AJAX client driver
By the way, you re-uploaded mag_upd20140117b.zip when I think you intended to upload mag_upd20140121b.zip. Greg Shah
04:09 PM Feature #1811: implement the AJAX client driver
I have not gotten to look at your latest code yet.
However, I think you have come to the wrong conclusion in regar...
Greg Shah
02:13 PM Feature #1811: implement the AJAX client driver
Here is an improved version for keyboard management. Seems to be closed to the final solution.
Nevertheless I will d...
Marius Gligor
10:31 AM Feature #1811: implement the AJAX client driver
1. Today I did the appropriate changes inside the JS code in order to manage the keyboard events.
So far all my t...
Marius Gligor
09:39 AM Feature #1811: implement the AJAX client driver
Please document the differences between Java/Swing key processing and the Javascript equivalent. It was my understand... Greg Shah
03:02 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, using the test at note 15, check how the body of a down frame evolves in the cases I've mentioned at note 22. ... Constantin Asofiei
01:25 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
It does seem that this code can only be used from an interactive UI. That is not something that the server project r... Greg Shah
01:23 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin notes:
Considering that CURRENT-ITERATION is used in the server project only in the adm2/smart.p and th...
Greg Shah
04:07 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBo...
Constantin Asofiei
02:33 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBox@ the @CURRENT-ITERATI... Vadim Gindin
02:11 PM Feature #1801: add some frame options
> Any other widget types to test or all the widget types?
FILL-IN and BUTTON.
Greg Shah
02:03 PM Feature #1801: add some frame options
Greg Shah wrote:
> > Unless I am missing a usecase here, the code changes are in-line with your points.
>
> OK, I...
Hynek Cihlar
01:18 PM Feature #1801: add some frame options
> Unless I am missing a usecase here, the code changes are in-line with your points.
OK, I was misunderstanding th...
Greg Shah
01:46 PM Feature #2144: add minimum runtime support for methods (server)
Implement runtime support for DESELECT-ROWS() and MOVE-BEFORE-TAB-ITEM(). Please put all history entries in the pare... Greg Shah
11:06 AM Feature #2016 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
ChUI and batch support is complete, which is sufficient for M7. GUI support will be implemented in #2229. Greg Shah
11:05 AM Feature #2018 (Closed): runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
Greg Shah
11:03 AM Feature #2229 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles...
Greg Shah

01/20/2014

05:28 PM Feature #1787: implement batch mode support
Finding. The folowing code works fine in standalone application but does not work in library(like libp2j):... Eugenie Lyzenko
03:44 PM Feature #1787: implement batch mode support
This is implementation candidate for Linux @SIGINT@ interceptor.
The Java part consist of the new class @SigintWai...
Eugenie Lyzenko
09:40 AM Feature #1787: implement batch mode support
I haven't gotten to the code review yet. But your approach for Windows is good. Greg Shah
05:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Review for 0121a.zip (btw, updates should be named using the day of work's date, not calendaristic):
# you are missi...
Constantin Asofiei
04:45 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here it is. An archive with recommended by you changes. The questions.
1) Do I correctly implenented @handle.unwrapI...
Vadim Gindin
01:54 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrame...
Constantin Asofiei
01:29 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrameFrame.currentIteration(... Vadim Gindin
03:14 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
vig_upd20140116a.zip passed regression testing. Committed as rev #10443. Vadim Gindin
01:33 PM Feature #1801: add some frame options
Another argument for splitting the color from attribute I forgot to mention is the @Color@ class itself. It also keep... Hynek Cihlar
01:24 PM Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0119a
>
> 1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in Cons...
Hynek Cihlar
01:21 PM Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0117a
> 1. Is the color-map.xml an example of the customer-specific (custom) color m...
Hynek Cihlar
09:08 AM Feature #1801: add some frame options
Code Review 0119a
1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in ConsolePrimitives?
2. Ple...
Greg Shah
08:56 AM Feature #1801: add some frame options
Code Review 0117a
I was disconnected most of the weekend and didn't see your update until now. I'll check the 011...
Greg Shah
12:13 PM Feature #1811: implement the AJAX client driver
1. I did more investigations regarding the Google Chrome web browser.
Both Google Chrome and jetty teams works cu...
Marius Gligor

01/19/2014

05:44 PM Feature #1787: implement batch mode support
> 4. What about Windows?
In Windows we do not have @sigwait()@. So another approach might be acceptable:
1. Ins...
Eugenie Lyzenko
05:09 PM Feature #1801: add some frame options
The attached hc_upd20140119a.zip contains in-code documentation, file headers plus some cosmetic code changes. The co... Hynek Cihlar

01/18/2014

04:24 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The work to determine the rules when the auxiliary field-group is created and how the field-group rows are made visib... Constantin Asofiei
04:03 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I extended your test to output the content of each field group on every iteration and other useful information. Here ... Vadim Gindin
12:43 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Great, you can release 0116a.zip after it passes testing. Constantin Asofiei
12:16 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
There is no changes since last update vig_upd20140116a.zip Vadim Gindin
11:59 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
OK, place the final update here for review, before releasing it. Constantin Asofiei
07:20 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
So I tested it again. It works. I'm going to run regression testing. Vadim Gindin
07:26 PM Feature #1787: implement batch mode support
> But let's just call it init_ in all cases to keep the filenames shorter.
OK. This is the prepared base for appro...
Eugenie Lyzenko

01/17/2014

06:15 PM Feature #1787: implement batch mode support
iniitalize_ would be fine. But let's just call it init_ in all cases to keep the filenames shorter. Greg Shah
05:32 PM Feature #1787: implement batch mode support
Greg,
Is it OK to name the native and OS dependent init modules as @initialize.(c|h)@ and @initialize_(linux|win)....
Eugenie Lyzenko
01:17 PM Feature #1787: implement batch mode support
> Eugenie: please work toward having this work done (and regression tested and checked in) by end of day next Friday ... Eugenie Lyzenko
10:09 AM Feature #1787: implement batch mode support
> we should consider releasing an intermediate update (withtout the @KILL -INT@ fix)
Agreed.
Eugenie: please wo...
Greg Shah
09:47 AM Feature #1787: implement batch mode support
Greg, a note: if there is a chance all the @kill -INT@ behaviour will not be ready until next friday, we should consi... Constantin Asofiei
08:40 AM Feature #1787: implement batch mode support
> Another things to discuss is about the signal processing init code for all required signals to special process. We ... Greg Shah
06:58 AM Feature #1787: implement batch mode support
> Yes. The sigaction() usage needs to be executed every time the client starts (instead of only when a child process ... Eugenie Lyzenko
08:17 PM Feature #1787: implement batch mode support
We can't use the Sun signal handling support otherwise this would limit our customer's usage of alternative JVMs.
...
Greg Shah
05:46 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
As Vadim N. noted on #1655 note 63: the problem we have with @WIDTH@ and @WIDTH-CHARS@ can be found with @HEIGHT@ and... Constantin Asofiei
03:21 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Sorry, my bad. The test was missing a no-error clause for the last @this-procedure:current-window = h.@ assignment; s... Constantin Asofiei
02:24 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin,
I've committed tests I have for this task. I already have similar tests. Could you comment, why do you...
Vadim Gindin
04:06 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Yes I did test it but my tests did not allow me to find this issue. It probably need to test i...
Constantin Asofiei
03:25 PM Feature #1801: add some frame options
I am attaching changes with the protermcap color support for an early review. The code was functionally tested and is... Hynek Cihlar
02:08 PM Feature #1811: implement the AJAX client driver
Code Review 0116b
The code looks good. Does ChuiWebSimulator really need to call super.quit()?
Greg Shah
01:29 PM Feature #1811: implement the AJAX client driver
System.exit(code) works fine.
Marius Gligor
01:07 PM Feature #1811: implement the AJAX client driver
Code Review 0117a
The changes look fine except for the END-ERROR approach already discussed above.
The use of S...
Greg Shah
12:58 PM Feature #1811: implement the AJAX client driver
I checked in the TerminalMenu class and we have this code for the Exit menu item:... Greg Shah
12:16 PM Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 1. I found another way to terminate the client process on connection close. Just simple put an...
Constantin Asofiei
12:10 PM Feature #1811: implement the AJAX client driver
1. I found another way to terminate the client process on connection close. Just simple put an END-ERROR key (code 30... Marius Gligor
08:34 PM Feature #1811: implement the AJAX client driver
> Using monospaced font results in an ugly screen so in JS I changed the monospaced with monospace font (see monospac... Greg Shah
08:24 PM Feature #1811: implement the AJAX client driver
Code Review 0116a
Generally, I'm OK with the code. My only concern: the use of @Runtime.getRuntime().halt(statusC...
Greg Shah

01/16/2014

06:59 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin Asofiei wrote:
> * @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using th...
Vadim Gindin
03:37 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
* @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using the NO-ERROR clause too? Becaus... Constantin Asofiei
06:52 PM Feature #1787: implement batch mode support
> Before you tested, did you fix this issue I previously mentioned?
>
> > The sigaction() calls that used to be in...
Eugenie Lyzenko
06:24 PM Feature #1787: implement batch mode support
Before you tested, did you fix this issue I previously mentioned?
> The sigaction() calls that used to be in the i...
Greg Shah
06:14 PM Feature #1787: implement batch mode support
> OK, that means we have a problem to fix.
>
> Try this: temporarily re-enable the KeyReader thread and re-test. D...
Eugenie Lyzenko
10:41 AM Feature #1787: implement batch mode support
> I have tested the our P2J client implementation for UI console mode. And kill behaves not the same as manual CTRL-C... Greg Shah
10:36 AM Feature #1787: implement batch mode support
> I'm not sure I understand what you've tested - your test was in P2J or 4GL?
OK. I have tested the our P2J client...
Eugenie Lyzenko
10:25 AM Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> I have tested the simple app with one fill-in in UI mode. The result is the same - kill -IN...
Constantin Asofiei
09:10 AM Feature #1787: implement batch mode support
The drop fixes the today notes. Eugenie Lyzenko
09:05 AM Feature #1787: implement batch mode support
> Eugenie, two notes:
>
> check how kill -INT is treated for normal start in 4GL (non-batch). Double-check this be...
Eugenie Lyzenko
06:37 AM Feature #1787: implement batch mode support
Code Review 0115b
1. Please put this comment in BatchDriver.init() ...
Greg Shah
04:01 AM Feature #1787: implement batch mode support
About the update:
* the appserver connection is working properly.
* @ThinClient.isBatchInBackground@ - there is a...
Constantin Asofiei
03:18 AM Feature #1787: implement batch mode support
Eugenie, two notes:
# check how @kill -INT@ is treated for normal start in 4GL (non-batch). Double-check this behavi...
Constantin Asofiei
05:48 PM Feature #1801: add some frame options
I believe this was intended as the mechanism by which the server-side code would configure custom colors and have the... Greg Shah
05:42 PM Feature #1801: add some frame options
In the original code, @ColorSpec@ contains the method @addMapping(String, Color)@ allowing dynamically add color mapp... Hynek Cihlar
03:56 PM Feature #1811: implement the AJAX client driver
On Chrome seems to be a bug when secured connection (WSS) with self signed certificate is used.
https://code.google....
Marius Gligor
01:36 PM Feature #1811: implement the AJAX client driver
1. Today I converted the keys.p application and I implemented the keyboard codes conversion for p4g.
I observed that...
Marius Gligor
03:02 PM Feature #2037: runtime support for frame options
The testcases can be found here: #2227 Eugenie Lyzenko
 

Also available in: Atom