Activity
From 05/22/2014 to 06/20/2014
06/20/2014
- 07:54 PM Feature #1789: implement the toggle-box widget
- The update for review uses @preRealizeCheck()@ to verify widget realization ability and @QuitConditionException@ to q...
- 07:08 PM Feature #1789: implement the toggle-box widget
- > This sounds like a QUIT (QuitConditionException). Check this before you make any other changes.
Yes, looks like ... - 05:28 PM Feature #1789: implement the toggle-box widget
- > The remaining issue is in P2J we have additional message "Press space bar to continue." while in 4GL the only messa...
- 05:20 PM Feature #1789: implement the toggle-box widget
- Code Review 0619a
1. We can't reuse valid() because this is there for other reasons (to provide support for the HA...
06/19/2014
- 03:03 PM Feature #1789: implement the toggle-box widget
- > The only thing needed is to properly sort the methods in AbstractButton and ToggleBox (public then protected then p...
- 09:21 PM Feature #1789: implement the toggle-box widget
- Code Review 0618a
The changes look good. The only thing needed is to properly sort the methods in AbstractButton ... - 09:09 PM Feature #1789: implement the toggle-box widget
- This update for review includes refactoring for @Button@ and @ToggleBox@ common code. The idea is to use new base cla...
06/18/2014
- 02:45 PM Feature #1789: implement the toggle-box widget
- > So I think this is not ToggleBox specific and we can postpone this subtask if you do not mind. Let me know if any n...
- 02:39 PM Feature #1789: implement the toggle-box widget
- > > Also may be as one more thing to do is to refactor the Button and ToggleBox implementation to merge possible comm...
- 02:04 PM Feature #1789: implement the toggle-box widget
- > Also may be as one mo thing to do is to refactor the Button and ToggleBox implementation to merge possible common c...
- 09:56 AM Feature #1789: implement the toggle-box widget
- Also may be as one more thing to do is to refactor the @Button@ and @ToggleBox@ implementation to merge possible comm...
- 09:52 AM Feature #1789: implement the toggle-box widget
- > 2. The javadoc for @ToggleBoxImpl.forceCursorOnFocus()@ should explain that the return value is always false.
OK... - 08:42 AM Feature #1789: implement the toggle-box widget
- Code Review 0617a
1. In the javadoc for these changes, "cusror" should be "cursor".
2. The javadoc for @ToggleB... - 09:44 PM Feature #1789: implement the toggle-box widget
- This update fixes UI artifact using new @Widget@ interface method implementation. Also the @ToggleBox@ class has been...
06/17/2014
- 05:39 PM Feature #1789: implement the toggle-box widget
- > > The problematic area is marked in red. I think this is something like phantom cursor. It is blinking and disappea...
- 04:15 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> For example, most buttons will only ever have a small number of possible labels (often only 1). W... - 04:11 PM Feature #2252: implement GUI client support
- I had not planned to require P2J to be running on a Windows OS in order to run the converted system. It would be a r...
- 03:53 PM Feature #2252: implement GUI client support
- I have some bad news... width for TEXT/FILL-IN widgets is computed via the avg-font-width, but for BUTTON, is compute...
- 10:50 AM Feature #2252: implement GUI client support
- +More Findings+
11. MESSAGE statement window targeting:
For both a regular MESSAGE statement and the MESSAGE VI... - 09:12 AM Feature #2252: implement GUI client support
- The Progress documentation suggests the following precedence order for window targeting (please note that I have alre...
- 10:52 AM Feature #2229: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles for GUI
- Please put all history into #2252. This task is just for time tracking.
- 02:34 AM Feature #1805: add missing UI method support
- Vadim, please use this version, the headers in Frame.java and GenericFrame.java are fixed now.
06/16/2014
- 05:13 PM Feature #2252: implement GUI client support
- For #2229, I have started a set of testcases to explore the behavior and features of the GUI multi-window environment...
- 04:45 PM Feature #1789: implement the toggle-box widget
- I have added a note to #1791 to describe the problem and to reference note 30 in this task. You don't need to do any...
- 03:54 PM Feature #1789: implement the toggle-box widget
- > What does the 4GL do here? I believe that this can't be done in the 4GL either. It probably raises an error. We sho...
- 02:02 PM Feature #1789: implement the toggle-box widget
- Code Review 0613b
The changes look fine.
> the message will display for all such widgets, not for the first enc... - 04:44 PM Feature #1791: implement dynamic UI support
- One issue that needs to be addressed is how the order of attribute assignment (in the CREATE widget statement) can af...
- 02:55 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I'm moving this to the GUI milestone as we have done more than enough for the needs of M11.
Vadim: we will pick th... - 01:24 PM Feature #1805: add missing UI method support
- Code Review 0613a
The changes look fine. Please get this runtime regression tested.
06/14/2014
- 01:18 PM Feature #2252: implement GUI client support
- > To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, ...
- 09:35 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Could Windows (or the 4GL) be mapping this as a "generic" sans-serif font that is actually differ...
06/13/2014
- 07:41 PM Feature #1789: implement the toggle-box widget
- Another screen artifact has been found working with @toggle-box@ widget. Take a look at @toggle_box13.jpg@. The probl...
- 02:17 PM Feature #1789: implement the toggle-box widget
- This new update fixes the note for previous one and has cleaned widget drawing code. Looks like no additional changes...
- 10:38 AM Feature #1789: implement the toggle-box widget
- Code Review 0613a
The changes look good. The only thing to change is to save off the screen-buffer changes into t... - 07:17 AM Feature #1789: implement the toggle-box widget
- The support for @VALUE-CHANGED@ event has been added to the @ToggleBox@. The testcase to verify - @toggle_box10.p@. T...
- 02:06 AM Feature #1805: add missing UI method support
- I prepared the next update that contains last corrections corresponding to your last notes. I did not add new header ...
06/12/2014
- 10:31 AM Feature #2252: implement GUI client support
- To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, w...
- 10:25 AM Feature #2252: implement GUI client support
- > Greg Shah wrote:
> > Include any information needed for the FONT-TABLE to be configured as well (e.g. font to font ... - 10:18 AM Feature #2252: implement GUI client support
- I've added these files to the testcases repo:
# @uast/fonts/system-metrics/font-list.txt@ - list of fonts standard f... - 09:05 AM Feature #1789: implement the toggle-box widget
- Code Review 0611b
The changes look fine. - 10:24 PM Feature #1789: implement the toggle-box widget
- With this update correct handling for @ASSIGN@, screen value and variable value differences added. Also for now I hav...
- 06:24 AM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Questions.
> 1) Am I using the right IDs?
Yes, the IDs are right.
> 3) May be we should del...
06/11/2014
- 05:18 PM Feature #1789: implement the toggle-box widget
- > 1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.drawCheckBox()@.
OK. Sorry this was just syntax... - 04:53 PM Feature #1789: implement the toggle-box widget
- Code Review 0611a
This is a very good start.
1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.d... - 04:14 PM Feature #1789: implement the toggle-box widget
- This update adds base skeleton for @ToggleBox@ runtime implementation. This is very early version just for review the...
- 04:30 PM Feature #2252: implement GUI client support
- OK. Automate the generation as much as is reasonable. Include any information needed for the FONT-TABLE to be confi...
- 03:58 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Please write a program that can inspect and dump these values from a legacy system. Is it suffici... - 02:32 PM Feature #2252: implement GUI client support
- The results are unfortunate but understandable.
> the metrics are not even the same across JRE implementations: Op... - 01:57 PM Feature #2252: implement GUI client support
- About fond rendering: no useful info found in Java FX or a way to switch the font rasterizer. More, the metrics are ...
06/10/2014
- 11:20 AM Feature #1789: implement the toggle-box widget
- Code Review 0610a
It looks good. - 11:17 AM Feature #1789: implement the toggle-box widget
- Implemented error message and clearing other questions.
Start planning to implement runtime processing. - 10:30 AM Feature #1789: implement the toggle-box widget
- Code Review 0609b
1. The GenericWidget.isChecked()/setChecked() methods should simply execute: @throw new RuntimeE...
06/09/2014
- 07:02 PM Feature #1789: implement the toggle-box widget
- Added stubs for compiling the converted code. The message for @UNKNOWN@ set value is not added yet.
The question:
... - 05:54 PM Feature #1789: implement the toggle-box widget
- > Please test how unknown value works for the CHECKED attribute and implement it in ToggleBoxWidget.setChecked(logica...
- 04:41 PM Feature #1789: implement the toggle-box widget
- Code Review 0609a
Please test how unknown value works for the CHECKED attribute and implement it in @ToggleBoxWidg... - 04:40 PM Feature #1789: implement the toggle-box widget
- > 1. To define isChecked() to the CommonWidget interface
Yes, you certainly need to add stubbed support for the CH... - 04:30 PM Feature #1789: implement the toggle-box widget
- Yes, partially the conversion has already been implemented. Except handling of the @R/W@ attribute @CHECKED@. I have ...
- 03:04 PM Feature #1789: implement the toggle-box widget
- > CHUI does not make the extra space. I think in theory it is possible to simulate [ ] label layout in CHUI by defini...
- 12:01 PM Feature #2252: implement GUI client support
- Related to fonts: I've managed to find the formula used by 4GL to compute the @pixels-per-row@ and @pixels-per-column...
06/07/2014
- 07:44 AM Feature #1805: add missing UI method support
- Haste makes waste - It's about me in this case. I'm sorry.
I'm working on your notes. I'm really forgot about fie...
06/06/2014
- 07:57 PM Feature #1790: implement menu support
- For now, we can only do the ChUI version but it should be designed to add GUI later. There will be work on both conv...
- 07:53 PM Feature #1789: implement the toggle-box widget
- Testcases have been committed in bzr as 1146.
- 07:39 PM Feature #1789: implement the toggle-box widget
- The attached screens are to illustrate point #1 and #2 above. The @ATTR-SPACE@ does not affect the @TOGGLE-BOX@ looki...
- 01:28 PM Feature #1789: implement the toggle-box widget
- ATTR-SPACE can be put into the frame phrase:...
- 12:37 PM Feature #1789: implement the toggle-box widget
- > 1. Check if @ATTR-SPACE@ or other options can have an impact on the label positioning. All the labels in your examp...
- 10:20 AM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> The update passed regression testing and have committed to bzr. Rev #10545
Some issues about ... - 09:47 AM Feature #1805: add missing UI method support
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2146 (Closed): add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- 09:49 AM Feature #2146: add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2144 (Closed): add minimum runtime support for methods (server)
06/05/2014
- 09:55 AM Feature #1789: implement the toggle-box widget
- Please add tests for the following cases:
1. Check if ATTR-SPACE or other options can have an impact on the label ... - 07:03 AM Feature #1789: implement the toggle-box widget
- After analyzing of the @ABL Reference@ book the testcases to demonstrate the behavior in all possible options accordi...
06/03/2014
- 02:33 AM Feature #1805: add missing UI method support
- PS: make sure to merge your update with the latest bzr version.
- 02:31 AM Feature #1805: add missing UI method support
- Review for 0602a:
# when we have APIs exposed via network servers (i.e. ClientExports), is best to avoid (de)seriali...
06/02/2014
- 05:20 PM Feature #2252: implement GUI client support
- Code Review 0602a
The code looks good. There are a few files that are missing the standard headers and so forth, ... - 03:20 AM Feature #2252: implement GUI client support
- Merged with the latest P2J updates (rules files).
- 05:02 PM Feature #1805: add missing UI method support
- I corrected implementation corresponding to the last notes. Please take a look.
- 09:32 AM Feature #1806 (Closed): implement UNLESS-HIDDEN
- 09:20 AM Feature #1806: implement UNLESS-HIDDEN
- The regression tasting has been passed. The update @...0530a@ has been committed in bzr as 10540.
- 09:15 AM Feature #1806: implement UNLESS-HIDDEN
- The CTRL-C testing has been completed. There are no regressions found. Had to run 3-way tests in a separate session t...
05/31/2014
- 08:37 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0530a
I agree, the changes are safe. No additional testing is needed.
05/30/2014
- 07:38 PM Feature #1806: implement UNLESS-HIDDEN
- This update merges @UNLESS-HIDDEN@ changed with the recent code base. I think the tasks are pretty independent and me...
- 03:49 PM Feature #1806: implement UNLESS-HIDDEN
- The main part has been completed without regressions in two rounds. Continue with the CTRL-C part.
- 08:06 AM Feature #1789: implement the toggle-box widget
- For now, we don't have GUI support yet in the rest of the client. So you can only implement ChUI right now. Later o...
05/29/2014
- 05:54 PM Feature #1806: implement UNLESS-HIDDEN
- The conversion testing has been completed without any differences in converted Java code. Started the regression test...
- 04:26 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0529a
The changes look good. Please get them regression tested. - 01:09 PM Feature #1806: implement UNLESS-HIDDEN
- Finally I have got all local tests passed. The new changes in update for review includes:
1. Removing @LabelImpl@ cl... - 05:52 PM Feature #1789: implement the toggle-box widget
- > Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Do we need to cover only ... - 01:11 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Constantin, thank you for the good test. It really will be useful.
>
> Here are the problem... - 07:26 AM Feature #1805: add missing UI method support
- Constantin, thank you for the good test. It really will be useful.
Here are the problems I can formulate at this mom...
05/28/2014
- 04:21 PM Feature #1806: implement UNLESS-HIDDEN
- > If everything is working in your local tests, then you can go into regression testing (both conversion and runtime)...
- 03:37 PM Feature #1806: implement UNLESS-HIDDEN
- > The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ instead of being com...
- 03:29 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528b
The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ i... - 02:59 PM Feature #1806: implement UNLESS-HIDDEN
- > Yes, please do explicitly cast it. Otherwise it is confusing to future readers/maintainers of the code.
OK. The ... - 01:49 PM Feature #1806: implement UNLESS-HIDDEN
- > If not add hidden() to LabeledWidget - we will need explicit casting fin to some class that have hidden() inside th...
- 01:42 PM Feature #1806: implement UNLESS-HIDDEN
- > 1. The hidden() method of LabeledWidget is already present in the Widget interface. LabeledDataContainer extends Fi...
- 12:49 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528a
I like the approach. My only questions:
1. The @hidden()@ method of @LabeledWidget@ is alrea... - 10:35 AM Feature #1806: implement UNLESS-HIDDEN
- The fix for hidden widgets has been added to the update.
The goal is to suppress label text drawing for hidden wid... - 03:54 PM Feature #1789: implement the toggle-box widget
- Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Then add conversion support... - 12:58 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Actually I found that FrameWidget has the frame property, that can be used for that case. I on...
05/27/2014
- 04:34 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0523a
The changes look good.
> So this is the general bug in DISPLAY statement handling and if ther... - 04:15 PM Feature #1805: add missing UI method support
- First of all I actualized testcases. See folders MOVE_BEFORE_TAB_ITEM and first_tab_item.
Constantin Asofiei wrote... - 01:35 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Here is the first working variant. It works for simple cases (without nested frames and with o...
05/26/2014
- 04:25 PM Feature #1805: add missing UI method support
- Here is the first working variant. It works for simple cases (without nested frames and with only one field-group). F...
05/23/2014
- 04:32 PM Feature #1806: implement UNLESS-HIDDEN
- Updated testcases for @DISPLAY@ statement. Looks like the problem with @DISPLAY UNLESS-HIDDEN@ is not related to @UNL...
- 03:07 PM Feature #1806: implement UNLESS-HIDDEN
- Update for review with adding minimum level of safety checking. The modified widget list will be passed to the usual ...
- 07:34 AM Feature #2252: implement GUI client support
- The package contains the changes and new classes used to implements CREATE WINDOW statement. So far the following iss...
05/22/2014
- 07:05 PM Feature #1806: implement UNLESS-HIDDEN
- Reattached the srceen shot for issue.
- 07:01 PM Feature #1806: implement UNLESS-HIDDEN
- > Make sure to implement this too if we don't already support it.
OK. The second drop for today contains runtime m... - 02:59 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0522a
The changes look good.
> Also the statement ENABLE ALL WITH FRAME... sets the HIDDEN flag to ... - 01:13 PM Feature #1806: implement UNLESS-HIDDEN
- This fix for your review is conversion rule change that allow the @UNLESS-HIDDEN@ option to be properly converted for...
- 12:00 PM Feature #1806: implement UNLESS-HIDDEN
- Currently only @DISPLAY@ and @ENABLE@ are supported with @UNLESS-HIDDEN@ option on the conversion level. For other st...
- 10:16 AM Feature #1806: implement UNLESS-HIDDEN
- The testcases executed in 4GL under Linux and screenshots uploaded. Yes, you are right, the @HIDDEN@ flag as @TRUE@ e...
- 10:07 AM Feature #2252: implement GUI client support
- Code Review 0522b
It looks good.
> 2. Could you please offer more details? What means "implement the WindowGuiI... - 09:59 AM Feature #2252: implement GUI client support
- For ChUI interface the status and message area are implemented as widgets (StatusLine instances)
To keep the compati... - 03:55 AM Feature #2252: implement GUI client support
- 1. The GuiScreen interface extends ScreenDriver interface.
2. Could you please offer more details? What means "imp... - 08:25 AM Feature #2308: remote client launch
- Doesn't the 4GL appserver implementation have some features in this regard? We should at least document their basic ...
- 02:57 AM Feature #2308: remote client launch
- The P2J Server should have no configuration/restriction on how many P2J clients act as remote launchers and the machi...
- 02:15 AM Feature #1805: add missing UI method support
- Greg Shah wrote:
> > I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled wid...
Also available in: Atom