Activity
From 06/04/2014 to 07/03/2014
07/03/2014
- 07:03 PM Feature #1791: implement dynamic UI support
- I think the following methods are involved in widget-frame ID relationship in more or less degree:...
- 11:33 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Constantin: please do a code review. I will make any final changes based on your feedback and th... - 08:09 AM Feature #2252: implement GUI client support
- Also please note that the 0627a is up to date with bzr revision 10560 (the p2j tips as of this writing).
- 08:08 AM Feature #2252: implement GUI client support
- Conversion regression testing for MAJIC has passed. There are some expected modifications (a copyright notice and th...
- 08:18 AM Feature #1811: implement the AJAX client driver
- I haven't gotten the chance to do a code review yet. But I think we need to be using the new HTML5 clipboard API (as ...
- 08:16 AM Feature #1811: implement the AJAX client driver
- 1. I found and I fixed the issue related to Dojo modules loading. The problem was a race condition in DojoToolkitHand...
- 06:13 AM Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> 2. For selection menu I used Dojo toolkit the latest release 1.10.0 (I tested also the previo...
07/02/2014
- 12:05 PM Feature #1811: implement the AJAX client driver
- Here is a first solution for issue #2306 implements copy/paste for web client
1. The system clipboard cannot be ac... - 10:09 AM Feature #1794: implement font support
- Code Review 0702d
The code looks good.
> The only unknown at this time related to conversion is: FONT, LABEL-FO... - 09:23 AM Feature #1794: implement font support
- Some other notes. A new window can use the fonts from a dynamic environment, activated via the LOAD/USE statements. ...
- 07:01 AM Feature #1794: implement font support
- I've cleaned up the code. This update is related to conversion support and stubbed runtime for FONT, LABEL-FONT, COL...
- 06:37 AM Feature #1794: implement font support
- > On server-side, the font-table is kept in the directory, and can be specified per P2J account or per P2J server. W...
- 06:12 AM Feature #1794: implement font support
- 0630a.zip was committed to bzr rev 10558
- 07:01 AM Feature #1791: implement dynamic UI support
- > The good place to assign the correct widget id for dynamic widget is the moment when we assign the FRAME attribute ...
- 05:03 AM Feature #1791: implement dynamic UI support
- Additional investigations show the 4GL still has limitation for usage attribute setting and corrected @FRAME@ attribu...
07/01/2014
- 09:01 AM Feature #1791: implement dynamic UI support
- Some general considerations.
The first issue discovered for dynamic widgets is related to the proper attribute set... - 05:43 AM Feature #1794: implement font support
- 0630a.zip passed conversion testing - no errors/differences after MAJIC conversion.
06/30/2014
- 01:52 PM Feature #2306 (WIP): add copy/paste support to the web client
- 09:40 AM Feature #1794: implement font support
- Attached update fixes a problem in the expression compiler: the bytecode builder was using @ldc@, which can refer 1-b...
06/27/2014
- 03:03 PM Feature #2252: implement GUI client support
- This is a cleaned up/enhanced version of the mag_upd20140602a.zip. It includes the following:
1. Everything has h...
06/25/2014
- 05:37 PM Feature #2252: implement GUI client support
- > Do you have rev 1159? I know rev 1158 of this file was missing the images, rev 1159 looks OK on my side.
Yes, I ... - 04:19 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> If I understand things correctly, a dependency we will have will be that the fonts on which an ap... - 03:58 PM Feature #2252: implement GUI client support
- I read the @uast/fonts/font_details.odt@. Clearly there are still some tricky parts to figure out.
If I understan... - 03:20 PM Feature #2252: implement GUI client support
- The @uast/fonts/font_details.odt@ contains details about how the widget metrics are computed; the main notes are:
* ... - 03:51 PM Feature #1794: implement font support
- We won't know if we need FONT-TABLE support (or not) until we see the cut-down customer GUI code. The full customer G...
- 03:50 PM Feature #1794: implement font support
- Do we need support for the @FONT-TABLE@ handle? Note that this handle allows to:
* adjust the size of the actual FO... - 10:20 AM Feature #1789 (Closed): implement the toggle-box widget
- 10:00 AM Feature #1789: implement the toggle-box widget
- The update 0624a has been committed in bzr as 10552.
- 09:28 AM Feature #1789: implement the toggle-box widget
- Go ahead with the check-in and distribution.
- 09:23 AM Feature #1789: implement the toggle-box widget
- The CTRL-C part has been completed without regressions. Hopefully 2-way and 3-way in a single session. The results ha...
- 08:23 AM Feature #1789: implement the toggle-box widget
- The main regression part completed without regression. Continue with CTRL-C part.
06/24/2014
- 11:04 AM Feature #1789: implement the toggle-box widget
- > Please check in your testcases to testcases/uast/toggle_box/.
Done. The revision is 1157.
- 10:15 AM Feature #1789: implement the toggle-box widget
- Code Review 0624a
The changes look good. - 09:44 AM Feature #1789: implement the toggle-box widget
- The runtime regression has been found for @Button@ related code for GSO 195 - help string is not updated correctly fo...
- 11:51 PM Feature #1789: implement the toggle-box widget
- Please check in your testcases to testcases/uast/toggle_box/.
- 02:56 AM Feature #1805: add missing UI method support
- Committed vig_upd20140617a.zip. Rev #10550
- 12:55 AM Feature #1805: add missing UI method support
- Yes, please commit it and distribute it to the team.
- 12:35 AM Feature #1805: add missing UI method support
- The latest update passed regression testing. Can I commit it?
- 12:48 AM Feature #2252: implement GUI client support
- #2323 is a task to implement support for GUI coordinate processing. Currently the implementation is hard coded to Ch...
- 12:15 AM Feature #2323: refactor coordinate system and implement GUI coordinate support
- This task is just for time tracking. All history should be placed in the parent task #2252.
- 12:14 AM Feature #2323 (Closed): refactor coordinate system and implement GUI coordinate support
06/23/2014
- 04:17 PM Feature #1789: implement the toggle-box widget
- The conversion part has been finished. The converted code is binary equal. Continue with runtime testing.
- 09:50 AM Feature #1789: implement the toggle-box widget
- Code Review 0622a
I'm fine with the changes. Please get it regression tested (both conversion and runtime).
06/22/2014
- 06:19 PM Feature #1789: implement the toggle-box widget
- New update for review uploaded. The @StopConditionException@ has been raised to interrupt execution. The pause insert...
- 05:24 PM Feature #1789: implement the toggle-box widget
- > Then you can tell if the code generates an error or not. You can also try ON END-KEY, ON STOP and ON QUIT instead o...
06/21/2014
- 05:07 AM Feature #1791: implement dynamic UI support
- The window-related features will be implemented in a different task. For #2028, focus on the general dynamic widget ...
- 04:44 AM Feature #1789: implement the toggle-box widget
- Code Review 0620a
The code looks good, especially the refactoring of common code into @buildWidgetSpectificMessage... - 04:41 AM Feature #1789: implement the toggle-box widget
- > Yes, looks like you are right. This is the usual exit for CHUI client session in 4GL for application finish.
> ......
06/20/2014
- 07:54 PM Feature #1789: implement the toggle-box widget
- The update for review uses @preRealizeCheck()@ to verify widget realization ability and @QuitConditionException@ to q...
- 07:08 PM Feature #1789: implement the toggle-box widget
- > This sounds like a QUIT (QuitConditionException). Check this before you make any other changes.
Yes, looks like ... - 05:28 PM Feature #1789: implement the toggle-box widget
- > The remaining issue is in P2J we have additional message "Press space bar to continue." while in 4GL the only messa...
- 05:20 PM Feature #1789: implement the toggle-box widget
- Code Review 0619a
1. We can't reuse valid() because this is there for other reasons (to provide support for the HA...
06/19/2014
- 03:03 PM Feature #1789: implement the toggle-box widget
- > The only thing needed is to properly sort the methods in AbstractButton and ToggleBox (public then protected then p...
- 09:21 PM Feature #1789: implement the toggle-box widget
- Code Review 0618a
The changes look good. The only thing needed is to properly sort the methods in AbstractButton ... - 09:09 PM Feature #1789: implement the toggle-box widget
- This update for review includes refactoring for @Button@ and @ToggleBox@ common code. The idea is to use new base cla...
06/18/2014
- 02:45 PM Feature #1789: implement the toggle-box widget
- > So I think this is not ToggleBox specific and we can postpone this subtask if you do not mind. Let me know if any n...
- 02:39 PM Feature #1789: implement the toggle-box widget
- > > Also may be as one more thing to do is to refactor the Button and ToggleBox implementation to merge possible comm...
- 02:04 PM Feature #1789: implement the toggle-box widget
- > Also may be as one mo thing to do is to refactor the Button and ToggleBox implementation to merge possible common c...
- 09:56 AM Feature #1789: implement the toggle-box widget
- Also may be as one more thing to do is to refactor the @Button@ and @ToggleBox@ implementation to merge possible comm...
- 09:52 AM Feature #1789: implement the toggle-box widget
- > 2. The javadoc for @ToggleBoxImpl.forceCursorOnFocus()@ should explain that the return value is always false.
OK... - 08:42 AM Feature #1789: implement the toggle-box widget
- Code Review 0617a
1. In the javadoc for these changes, "cusror" should be "cursor".
2. The javadoc for @ToggleB... - 09:44 PM Feature #1789: implement the toggle-box widget
- This update fixes UI artifact using new @Widget@ interface method implementation. Also the @ToggleBox@ class has been...
06/17/2014
- 05:39 PM Feature #1789: implement the toggle-box widget
- > > The problematic area is marked in red. I think this is something like phantom cursor. It is blinking and disappea...
- 04:15 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> For example, most buttons will only ever have a small number of possible labels (often only 1). W... - 04:11 PM Feature #2252: implement GUI client support
- I had not planned to require P2J to be running on a Windows OS in order to run the converted system. It would be a r...
- 03:53 PM Feature #2252: implement GUI client support
- I have some bad news... width for TEXT/FILL-IN widgets is computed via the avg-font-width, but for BUTTON, is compute...
- 10:50 AM Feature #2252: implement GUI client support
- +More Findings+
11. MESSAGE statement window targeting:
For both a regular MESSAGE statement and the MESSAGE VI... - 09:12 AM Feature #2252: implement GUI client support
- The Progress documentation suggests the following precedence order for window targeting (please note that I have alre...
- 10:52 AM Feature #2229: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles for GUI
- Please put all history into #2252. This task is just for time tracking.
- 02:34 AM Feature #1805: add missing UI method support
- Vadim, please use this version, the headers in Frame.java and GenericFrame.java are fixed now.
06/16/2014
- 05:13 PM Feature #2252: implement GUI client support
- For #2229, I have started a set of testcases to explore the behavior and features of the GUI multi-window environment...
- 04:45 PM Feature #1789: implement the toggle-box widget
- I have added a note to #1791 to describe the problem and to reference note 30 in this task. You don't need to do any...
- 03:54 PM Feature #1789: implement the toggle-box widget
- > What does the 4GL do here? I believe that this can't be done in the 4GL either. It probably raises an error. We sho...
- 02:02 PM Feature #1789: implement the toggle-box widget
- Code Review 0613b
The changes look fine.
> the message will display for all such widgets, not for the first enc... - 04:44 PM Feature #1791: implement dynamic UI support
- One issue that needs to be addressed is how the order of attribute assignment (in the CREATE widget statement) can af...
- 02:55 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I'm moving this to the GUI milestone as we have done more than enough for the needs of M11.
Vadim: we will pick th... - 01:24 PM Feature #1805: add missing UI method support
- Code Review 0613a
The changes look fine. Please get this runtime regression tested.
06/14/2014
- 01:18 PM Feature #2252: implement GUI client support
- > To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, ...
- 09:35 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Could Windows (or the 4GL) be mapping this as a "generic" sans-serif font that is actually differ...
06/13/2014
- 07:41 PM Feature #1789: implement the toggle-box widget
- Another screen artifact has been found working with @toggle-box@ widget. Take a look at @toggle_box13.jpg@. The probl...
- 02:17 PM Feature #1789: implement the toggle-box widget
- This new update fixes the note for previous one and has cleaned widget drawing code. Looks like no additional changes...
- 10:38 AM Feature #1789: implement the toggle-box widget
- Code Review 0613a
The changes look good. The only thing to change is to save off the screen-buffer changes into t... - 07:17 AM Feature #1789: implement the toggle-box widget
- The support for @VALUE-CHANGED@ event has been added to the @ToggleBox@. The testcase to verify - @toggle_box10.p@. T...
- 02:06 AM Feature #1805: add missing UI method support
- I prepared the next update that contains last corrections corresponding to your last notes. I did not add new header ...
06/12/2014
- 10:31 AM Feature #2252: implement GUI client support
- To be clear, I don't plan to provide any support that the 4GL doesn't already provide. For compatibility purposes, w...
- 10:25 AM Feature #2252: implement GUI client support
- > Greg Shah wrote:
> > Include any information needed for the FONT-TABLE to be configured as well (e.g. font to font ... - 10:18 AM Feature #2252: implement GUI client support
- I've added these files to the testcases repo:
# @uast/fonts/system-metrics/font-list.txt@ - list of fonts standard f... - 09:05 AM Feature #1789: implement the toggle-box widget
- Code Review 0611b
The changes look fine. - 10:24 PM Feature #1789: implement the toggle-box widget
- With this update correct handling for @ASSIGN@, screen value and variable value differences added. Also for now I hav...
- 06:24 AM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Questions.
> 1) Am I using the right IDs?
Yes, the IDs are right.
> 3) May be we should del...
06/11/2014
- 05:18 PM Feature #1789: implement the toggle-box widget
- > 1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.drawCheckBox()@.
OK. Sorry this was just syntax... - 04:53 PM Feature #1789: implement the toggle-box widget
- Code Review 0611a
This is a very good start.
1. Please rename @ToggleBoxImpl.drawChekBox()@ to @ToggleBoxImpl.d... - 04:14 PM Feature #1789: implement the toggle-box widget
- This update adds base skeleton for @ToggleBox@ runtime implementation. This is very early version just for review the...
- 04:30 PM Feature #2252: implement GUI client support
- OK. Automate the generation as much as is reasonable. Include any information needed for the FONT-TABLE to be confi...
- 03:58 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Please write a program that can inspect and dump these values from a legacy system. Is it suffici... - 02:32 PM Feature #2252: implement GUI client support
- The results are unfortunate but understandable.
> the metrics are not even the same across JRE implementations: Op... - 01:57 PM Feature #2252: implement GUI client support
- About fond rendering: no useful info found in Java FX or a way to switch the font rasterizer. More, the metrics are ...
06/10/2014
- 11:20 AM Feature #1789: implement the toggle-box widget
- Code Review 0610a
It looks good. - 11:17 AM Feature #1789: implement the toggle-box widget
- Implemented error message and clearing other questions.
Start planning to implement runtime processing. - 10:30 AM Feature #1789: implement the toggle-box widget
- Code Review 0609b
1. The GenericWidget.isChecked()/setChecked() methods should simply execute: @throw new RuntimeE...
06/09/2014
- 07:02 PM Feature #1789: implement the toggle-box widget
- Added stubs for compiling the converted code. The message for @UNKNOWN@ set value is not added yet.
The question:
... - 05:54 PM Feature #1789: implement the toggle-box widget
- > Please test how unknown value works for the CHECKED attribute and implement it in ToggleBoxWidget.setChecked(logica...
- 04:41 PM Feature #1789: implement the toggle-box widget
- Code Review 0609a
Please test how unknown value works for the CHECKED attribute and implement it in @ToggleBoxWidg... - 04:40 PM Feature #1789: implement the toggle-box widget
- > 1. To define isChecked() to the CommonWidget interface
Yes, you certainly need to add stubbed support for the CH... - 04:30 PM Feature #1789: implement the toggle-box widget
- Yes, partially the conversion has already been implemented. Except handling of the @R/W@ attribute @CHECKED@. I have ...
- 03:04 PM Feature #1789: implement the toggle-box widget
- > CHUI does not make the extra space. I think in theory it is possible to simulate [ ] label layout in CHUI by defini...
- 12:01 PM Feature #2252: implement GUI client support
- Related to fonts: I've managed to find the formula used by 4GL to compute the @pixels-per-row@ and @pixels-per-column...
06/07/2014
- 07:44 AM Feature #1805: add missing UI method support
- Haste makes waste - It's about me in this case. I'm sorry.
I'm working on your notes. I'm really forgot about fie...
06/06/2014
- 07:57 PM Feature #1790: implement menu support
- For now, we can only do the ChUI version but it should be designed to add GUI later. There will be work on both conv...
- 07:53 PM Feature #1789: implement the toggle-box widget
- Testcases have been committed in bzr as 1146.
- 07:39 PM Feature #1789: implement the toggle-box widget
- The attached screens are to illustrate point #1 and #2 above. The @ATTR-SPACE@ does not affect the @TOGGLE-BOX@ looki...
- 01:28 PM Feature #1789: implement the toggle-box widget
- ATTR-SPACE can be put into the frame phrase:...
- 12:37 PM Feature #1789: implement the toggle-box widget
- > 1. Check if @ATTR-SPACE@ or other options can have an impact on the label positioning. All the labels in your examp...
- 10:20 AM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> The update passed regression testing and have committed to bzr. Rev #10545
Some issues about ... - 09:47 AM Feature #1805: add missing UI method support
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2146 (Closed): add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- 09:49 AM Feature #2146: add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2144 (Closed): add minimum runtime support for methods (server)
06/05/2014
- 09:55 AM Feature #1789: implement the toggle-box widget
- Please add tests for the following cases:
1. Check if ATTR-SPACE or other options can have an impact on the label ... - 07:03 AM Feature #1789: implement the toggle-box widget
- After analyzing of the @ABL Reference@ book the testcases to demonstrate the behavior in all possible options accordi...
Also available in: Atom