Activity

From 01/19/2015 to 02/17/2015

02/17/2015

04:28 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see. May I make a suggestion?
> > First of all I think that it is ... Hynek Cihlar
04:12 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... Hynek Cihlar
04:07 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> I see. May I make a suggestion?
> First of all I think that it is important for the scroll... Greg Shah
02:29 PM Feature #2498: implement ADD-LAST() method: I see. May I make a suggestion?
First of all I think that it is important for the scroll to be well-defined and idemp... Igor Skornyakov
02:03 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... Greg Shah
12:59 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Please provide more specifics about what needs to be different.
Well, first of all the whole... Igor Skornyakov
12:42 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Generally, no it is not OK.
>
> I do see that @RadioButtonImpl.drawButton()@ does not honor th... Igor Skornyakov
12:40 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4... Greg Shah
12:34 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suita... Greg Shah
12:33 PM Feature #2498: implement ADD-LAST() method: In regard to the NPE, I don't understand why we would be pushing screen definitions to the client during the processi... Greg Shah
11:57 AM Feature #2498: implement ADD-LAST() method: Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4GL the focused item is hig... Igor Skornyakov
11:34 AM Feature #2498: implement ADD-LAST() method: It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suitable for at least a @RadioS... Igor Skornyakov
11:29 AM Feature #2498: implement ADD-LAST() method: The sample code is a result of my test evolution - I've added more code while investigating the widget behavior. Plea... Igor Skornyakov
10:02 AM Feature #2498: implement ADD-LAST() method: The code seems very complicated, with many more frames than I would have expected to be used or needed. Did you get ... Greg Shah
04:13 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> 3. About the NPE in @LogicalTerminal.pushScreenDefinition()@, can you show the 4GL code that can ... Igor Skornyakov
10:44 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150216a.zip
1. The @RadioSetInterface@ header should be above the import and package statemen... Greg Shah
08:55 AM Feature #2412: Implement widget browser: Code Review hc_upd20150217b.zip
It looks good. Please check it in. Greg Shah
04:54 AM Feature #2412: Implement widget browser: Missing history entry added and converted tabs to spaces in the whole PropertyTable.java. build.xml removed as this s... Hynek Cihlar
10:48 PM Feature #2412: Implement widget browser: Code Review hc_upd20150217a.zip
1. @PropertyTable@ needs a history entry. It also needs all of its hard-tab chars... Greg Shah
08:15 PM Feature #2412: Implement widget browser: The attached update extends Widget browser with the possibility to copy widget properties to clipboard. This is usefu... Hynek Cihlar
02:06 AM Feature #2422: add features to BROWSE: > > But I can handle browsing part because BrowseColumnWidget.setDColor(Color) does the job.
>
> I don't understan... Stanislav Lomany
10:31 PM Feature #2422: add features to BROWSE: > while BrowseColumnWidget.setDColor(NumberType) doesn't actually set a color because ColorSpec.convert() always retu... Greg Shah

02/16/2015

03:49 PM Feature #2498: implement ADD-LAST() method: Added support for the HORIZONTAL and EXPAND attributes. Still need to fix scrolling behavior. Igor Skornyakov
03:32 PM Feature #2422: add features to BROWSE: FYI, Majic alters browse column "colors" in two places. E.g.:... Stanislav Lomany
09:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Committed in bzr as 10757. Eugenie Lyzenko
09:38 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Check it in. Greg Shah
08:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The runtime testing completed without regressions(separate run for CTRL-C 3 way tests). The results are in @10754_5c9... Eugenie Lyzenko

02/13/2015

12:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Greg Shah wrote:
> Code Review evl_upd20150212b.zip
>
> It looks good, get it both conversion and runtime regress... Eugenie Lyzenko
09:22 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150212b.zip
It looks good, get it both conversion and runtime regression tested. Greg Shah
10:53 AM Feature #1790: implement menu support: Code Review vig_upd20150210a.zip
This is very close.
1. There is a build directory included in your update zip ... Greg Shah
09:55 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150212a.zip
It is very good. Some minor things:
1. Add @RadioSetInterface@ to @HandleComm... Greg Shah

02/12/2015

04:42 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: OK. This update for review changes row/column offsets to double and adjust client side to use new double data. Eugenie Lyzenko
04:10 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that ... Greg Shah
12:02 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that distinguishes between @But... Eugenie Lyzenko
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >Is there anything left to do for this task?
>
> The following options need to be implem... Greg Shah
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150212a.zip
1. All row/col values need to be decimal/double as well. I should have seen thi... Greg Shah
07:17 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >2. Although it is probably OK, I find it confusing that the image phrase generates differe... Greg Shah
07:00 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >2. Although it is probably OK, I find it confusing that the image phrase generates different setters for the same op... Eugenie Lyzenko
05:13 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Is there anything left to do for this task?
The following options need to be implemented:
CONVERT-3D-COLORS
STR... Eugenie Lyzenko
07:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150211b.zip
This is really good.
1. I suspect the @IMAGE-SIZE@/@IMAGE-SIZE-CHARS@ should b... Greg Shah
03:58 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: That is probably the issue. Try it from the command line. Greg Shah
03:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Done. I've uploaded @vig_server_client.zip@ to @/home/vig@
I use Java configuration in Eclipse. Vadim Gindin
02:51 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Please archive your testcases/simple/server, testcases/simple/client folders and upload them to devsrv01.
How do y... Constantin Asofiei
02:48 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Thanks. I tried it and got the error:
> > [...]
> Are you usi... Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: @display "This"@ behaves as the first test: window 1x1 in the left top corner. Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Thanks. I tried it and got the error:
> [...]
Are you using the latest P2J rev? Note that t... Constantin Asofiei
01:42 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Thanks. I tried it and got the error:... Vadim Gindin
08:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> I didn't find any peculiarities. Here is the test:
>
> [...]
Have you added basic runtime ... Constantin Asofiei
06:58 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I faced with the following difficulty: running application window (GUI) has the size 1x1 and position in the first pi... Vadim Gindin
03:19 PM Feature #2498: implement ADD-LAST() method: 1. fixed the issues you've mentioned by Greg.
2. Added server-side support for HORIZONTAL and EXPAND attributes. Cli... Igor Skornyakov
08:20 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150211b.zip
1. This code in @CommonWidget@ is incorrect:... Greg Shah

02/11/2015

04:40 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The second update for today has small fixes for image widget bugs/regressions. I guess now if there are no objections... Eugenie Lyzenko
01:15 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The update for review includes candidate for image phrase handling for button widget. Need the tests to not getting r... Eugenie Lyzenko
07:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This drop includes merging with the recent code base and fix for handling case when requested image size is bigger th... Eugenie Lyzenko
04:05 PM Feature #2498: implement ADD-LAST() method: 1. The converted code with horizontal RADIO-SET behaves very different from the 4GL. In particular the EXPAND flag is... Igor Skornyakov
07:14 AM Feature #2498: implement ADD-LAST() method: Finished refactoring and adding new attributes/methods support. Now I should check the behavior of RADIO-SET runtime ... Igor Skornyakov
12:41 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I didn't find any peculiarities. Here is the test:... Vadim Gindin

02/10/2015

06:20 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150209a.zip
Looks good so far. Greg Shah
06:18 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: > I planed to add in the LogicalTerminal new methods for read/save files.
That is OK. These should call down to a... Greg Shah
05:59 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Just want to clarify:
I planed to add in the @LogicalTerminal@ new methods for read/save files. Also I need to add s... Evgeny Kiselev
12:22 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Added conversion support for SAVE-FILE method Evgeny Kiselev
02:58 PM Feature #2498: implement ADD-LAST() method: > The converted code runs w/o any complains
The 4GL docs state that @LIST-ITEM-PAIRS@ is valid for combo-box, sele... Greg Shah
02:56 PM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Igor, as you are using a dynamic RADIO-SET and not a static RADIO-SET (created via the... Igor Skornyakov
02:49 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation?
It will com... Igor Skornyakov
02:46 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Greg Shah wrote:
> > This you can fix. Please post a simplified testcase (in @[...]@ tags... Constantin Asofiei
02:42 PM Feature #2498: implement ADD-LAST() method: > which is illegal for 4GL
Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation? Greg Shah
02:36 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> This you can fix. Please post a simplified testcase (in @[...]@ tags) so that I can see what you... Igor Skornyakov
02:27 PM Feature #2498: implement ADD-LAST() method: > I have the following in mind. As you know I've moved some methods from CommonWdget/GenericWidget to a separate inte... Greg Shah
02:23 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> We don't want to support any case where the code can never be valid or where we are mis-convertin... Igor Skornyakov
02:09 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> One more question.
> I've noticed that in some cases an invalid attribute result in 4GL co... Greg Shah
02:08 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dyn... Greg Shah
12:49 PM Feature #2498: implement ADD-LAST() method: One more question.
I've noticed that in some cases an invalid attribute result in 4GL compilation failure while in o... Igor Skornyakov
12:31 PM Feature #2498: implement ADD-LAST() method: The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dynamic COMBO-BOX and SELECTI... Igor Skornyakov
02:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Not exactly. What I meant is that I would like to see some specific findings about the drawing and event processing ... Greg Shah
02:12 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: About my implementation plan. I just think that I'll firstly implement drawing and after that I'll be implementing ev... Vadim Gindin
09:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: This widget is supported for ChUI runtime usage today. It's conversion should be pretty complete, but I haven't chec... Greg Shah
09:19 AM Feature #2513 (Closed): implement GUI runtime support for TOGGLE-BOX: Greg Shah
03:16 AM Feature #1790: implement menu support: Here is the current update.
It adds to following changes to previous:
* An implementation of find* methods,
* Se... Vadim Gindin

02/09/2015

04:00 PM Feature #2498: implement ADD-LAST() method: Extracted list widgets-specific methods to a separate interface @com.goldencode.p2j.ui.CommonListWidget@ Igor Skornyakov
03:23 PM Feature #2498: implement ADD-LAST() method: > Should I remove these methods from CommonWidget/GenericWidget?
Yes.
> Please note that in this case these met... Greg Shah
03:16 PM Feature #2498: implement ADD-LAST() method: I've extracted methods which are defines for lists widgets only to a separate interface. Should I remove these method... Igor Skornyakov
12:21 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> This is easy to do, but it has the unwanted result of making the generated code much more verbose... Igor Skornyakov
12:10 PM Feature #2498: implement ADD-LAST() method: > Don't you think that it is more practical to change the code generation? I mean that the code generator can validat... Greg Shah
11:47 AM Feature #2498: implement ADD-LAST() method: > Just by marking the method as "Widget" in @methods_attributes.rules@ would work. It is not how we want it to work,... Igor Skornyakov
11:46 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Are you saying that you cannot write code like this: @my-widget:add-last(my-char-var, "Some Text"... Igor Skornyakov
11:03 AM Feature #2498: implement ADD-LAST() method: Perhaps that interface would be called @ListManagement@.
>> 2. Don't we still need addLast(character, String)?
> ... Greg Shah
11:00 AM Feature #2498: implement ADD-LAST() method: > > 3. The change in @handle@ is incorrect. @ControlEntity@ is not an interface and MUST NOT be an unwrap target. A... Greg Shah
10:56 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> 1. Coding standard issues that remain:
>
> * @for(@ should be @for (@ - @ComboBoxModel@, @Radi... Igor Skornyakov
09:23 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150209a.zip
1. Coding standard issues that remain:
* @for(@ should be @for (@ - @ComboBoxM... Greg Shah
08:43 AM Feature #2498: implement ADD-LAST() method: 1. Formatting issues are fixed (I hope)
2. The list widgets' behaviour updated according to recent findings.
Igor Skornyakov
07:32 AM Feature #2498: implement ADD-LAST() method: > Please note however that if one tries to delete an item with label which doesn't exists in a case-sensitive way but... Greg Shah
07:21 AM Feature #2498: implement ADD-LAST() method: A more thorough analysis revealed the following details about the list widgets' behaviour:
1. For COMBO-BOX: the @DE... Igor Skornyakov
11:22 AM Feature #2422: add features to BROWSE: Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to GUI only. Reproduction:
@down to 8... Stanislav Lomany
11:07 AM Feature #2422: add features to BROWSE: It turns out that for ChUI behavior of Page Down differs for preselect and adaptive queries. For example the followin... Stanislav Lomany

02/06/2015

03:48 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for review presents the approach for image-phrase implementation candidate. Needs to check and debug but ... Eugenie Lyzenko
02:20 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Will you also insist on using of @PaintEvent@? If yes could you help me to understand how it s... Constantin Asofiei
12:28 PM Feature #1790: implement menu support: How to properly test static menus deletion? Vadim Gindin
02:13 PM Feature #2498: implement ADD-LAST() method: >
> > 6. The item ID generator should not be in the @ControlSetConfig@ class. We are trying to eliminate all logi... Greg Shah
01:46 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> 2. Is there any way to introduce problems in @ComboBoxModel.calcSelection()@ by relying upon the ... Igor Skornyakov
01:14 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150205a.zip
I really like your nicely factored @ControlSetEntity@ @add*()@ implementation. I... Greg Shah
12:27 PM Feature #2498: implement ADD-LAST() method: Got it. Thank you. Igor Skornyakov
12:24 PM Feature #2498: implement ADD-LAST() method: > I've also notices that all handle.unwrapXXX() methods work with interfaces while ControlEntity is a class. I don't ... Greg Shah
12:04 PM Feature #2498: implement ADD-LAST() method: Got it. Actually I've already stated to look at the conversion details.
I've added @unwrapConrolEntity()@ method to ... Igor Skornyakov
11:52 AM Feature #2498: implement ADD-LAST() method: I will do the code review next. Sorry that I have been slow to respond. I've just been very busy.
In regard to t... Greg Shah
10:26 AM Feature #2498: implement ADD-LAST() method: Regression test performed twice.
The following steps failed identically in both runs:
4 ctrlc_11_session1 CTRL... Igor Skornyakov

02/05/2015

04:15 PM Feature #2478: button image support: The update @evl_upd20150204a.zip@ has been committed in bzr as 10744. Eugenie Lyzenko
04:08 PM Feature #2478: button image support: The testing completed. Results: @10742_5c96d7c_20150205_evl.zip@. No regressions confirmed.
I've stopped the serve... Eugenie Lyzenko
10:53 AM Feature #2478: button image support: I appreciate that you are taking extra care. Thanks. Greg Shah
10:36 AM Feature #2478: button image support: The runtime testing almost completed. The only issue is the @GSO 269@ test. It failed with two main cycles but passed... Eugenie Lyzenko
03:06 PM Feature #2498: implement ADD-LAST() method: Just a notice. It seems that there are some problems with conversion.
1. Conversion of the attached @radio2.p@ progr... Igor Skornyakov
01:58 PM Feature #2498: implement ADD-LAST() method: All done and is ready for the code review. I'm not sure however that frame overflow detection at @RadioSetWidget.addL... Igor Skornyakov
08:19 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update adds missing in previous update @ImageConfig@ class. Also it resolves the offset-size phrase issues found... Eugenie Lyzenko

02/04/2015

05:09 PM Feature #2478: button image support: The conversion testing completed. The generated code is identical. Continue with runtime testing. Eugenie Lyzenko
02:20 PM Feature #2478: button image support: > Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in.
... Eugenie Lyzenko
01:46 PM Feature #2478: button image support: Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in. Greg Shah
11:16 AM Feature #2478: button image support: Merged with 10741 code base. Eugenie Lyzenko
01:03 PM Feature #2498: implement ADD-LAST() method: Fixed @SelectionListBody@ to correctly restore selection after list modification Igor Skornyakov
10:54 AM Feature #2498: implement ADD-LAST() method: Just noticed that ListSelectionModel implementation should be revised - currently it behaves incorrectly after ADD-FI... Igor Skornyakov
10:43 AM Feature #2498: implement ADD-LAST() method: SELECTION-LIST behaviour fixed to be compatible with 4GL (both in SINGLE and MULTIPLE selection modes).
RADIO-SET ... Igor Skornyakov
08:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for review includes suggest for runtime implementation for image phrase for image widget. In general it w... Eugenie Lyzenko

02/03/2015

03:22 PM Feature #2498: implement ADD-LAST() method: Implemented @ADD-LAST()@ and fixed @ADD-FIRST()@ for RADIO-SET. Igor Skornyakov
01:07 PM Feature #2498: implement ADD-LAST() method: Yes, please fix it. Greg Shah
12:40 PM Feature #2498: implement ADD-LAST() method: ADD-FIRST/ADD-LAST/DELETE functionality for SELECTION-LIST look OK.
However I've noticed that Java runtime doesn't a... Igor Skornyakov
09:27 AM Feature #2498: implement ADD-LAST() method: An id field is added to ControlSetItem. Now the behaviour of COMBO-BOX widget after ADD-FIRST/ADD-LAST/DELETE operati... Igor Skornyakov
02:14 PM Feature #1790: implement menu support: Could you help me with initial focus setting. I'm trying to set focus on a first menu-item in a shown pop-up menu i.e... Vadim Gindin

02/02/2015

03:55 PM Feature #2422: add features to BROWSE: Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to ChUI and GUI. If the number of rows... Stanislav Lomany
02:50 PM Feature #2498: implement ADD-LAST() method: Most of the above is implemented (for COMBO-BOX). However the issue with the value shown in the box after @ADD-FIRST@... Igor Skornyakov
10:25 AM Feature #2478: button image support: The @evl_upd20150202a.zip@ also merged with 10739. Eugenie Lyzenko
09:15 AM Feature #2478: button image support: Update merged with 10738 code base. Eugenie Lyzenko

02/01/2015

03:52 PM Feature #2478: button image support: Update merged with the 10736 code base. Eugenie Lyzenko
11:02 PM Feature #2478: button image support: Sorry, there are 2 updates in front of you right now. Hynek's is first and then Constantin has one. Thanks for your... Greg Shah
11:50 AM Feature #2498: implement ADD-LAST() method: Good work in finding these issues.
> Should I start working on the issues mentioned above?
Yes, please do. Greg Shah
11:15 AM Feature #2498: implement ADD-LAST() method: It is easy to implement section 2 (e.g by adding @realValue@ field to @ControlSetItem@ in addition to @value@ - for @... Igor Skornyakov

01/31/2015

05:36 PM Feature #2478: button image support: Merged with recent code base. Is it time to start new round or there will be more updates? Eugenie Lyzenko
02:38 PM Feature #1790: implement menu support: I didn't find a way to get it work with posting @PaintEvent@. But I've fixed the bug adding @menu.requestSync()@ call... Vadim Gindin

01/30/2015

05:01 PM Feature #2478: button image support: > Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have... Eugenie Lyzenko
04:57 PM Feature #2478: button image support: Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have @... Greg Shah
11:43 AM Feature #2478: button image support: The @CTRL-C@ part completed without regression. 3-way tests was started in a separate session. The results file on sh... Eugenie Lyzenko
07:56 AM Feature #2478: button image support: Finally I have got the main part completed without regression. Starting the @CTRL-C@ tests. Eugenie Lyzenko
04:51 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for your review includes conversion support implementation candidate for @size-phrase@ and @image-phrase@... Eugenie Lyzenko
05:35 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Yes, please implement this. Greg Shah
05:25 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Question. Do we need th support for @FROM {X n Y n} | {ROW n COLUMN n}@ clause of the @image phrase@?
This sets th... Eugenie Lyzenko
03:31 PM Feature #1790: implement menu support: I did as you advised. I used @menu.setVisible(true)@ that calls @repaint()@ method, that in turn call @EventManager.p... Vadim Gindin
11:22 AM Feature #1790: implement menu support: Greg Shah wrote:
> 1. I think your drawing issues are related to how you are directly calling @menu.draw()@ in @Thi... Constantin Asofiei
08:44 AM Feature #1790: implement menu support: > but still got mbar.getSelf().readOnlyError("popup-only");.
You have to add the attribute into the writable attri... Greg Shah
08:06 AM Feature #1790: implement menu support: # I've added POPUP-ONLY to @load_descriptiors@ function along with other menu related attributes, created @MenuInterf... Vadim Gindin
03:27 PM Feature #2498: implement ADD-LAST() method: Additional details about COMBO-BOX widget behaviour in presence of duplicated/"unknown" labels/values:
1. empty labe... Igor Skornyakov
08:41 AM Feature #2498: implement ADD-LAST() method: > May be it makes sense to fix the implementation of ADD-FIRST as well (the current implementation also doesn't show ... Greg Shah
07:48 AM Feature #2498: implement ADD-LAST() method: If "unknown value is specified for @ADD-LAST(items)@ method it is accepted but on the screen a blank line is shown (i... Igor Skornyakov
08:16 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: LE: the trigger in note 22 was changed to be for the frame, not widget. Constantin Asofiei
08:12 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: I'm noting this here, but is a bug, not a regression; the following case doesn't work in P2J:... Constantin Asofiei
06:56 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: The changes are doing well in regression testing. I got timeout failures in tc_item_master_006, tc_item_master_104 a... Greg Shah

01/29/2015

06:20 PM Feature #1790: implement menu support: Code Review vig_upd20150130a.zip
I think it is moving in the right direction.
1. I think your drawing issues ar... Greg Shah
03:54 PM Feature #1790: implement menu support: The next update, containing the following changes.
# The first working (in testing mode) variant with popup-menu.
#... Vadim Gindin
08:29 AM Feature #1790: implement menu support: OK. Keep this in mind when you are working on getting the event processing to work properly. Greg Shah
05:38 AM Feature #1790: implement menu support: Greg Shah wrote:

> Can you create a trigger on this event and use no-apply? Something like this:
>
> [...]
>... Vadim Gindin
05:31 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20150129b.zip
>
> My review of ZCL is not very very deep. But overall, I'm ... Hynek Cihlar
05:07 PM Feature #2252: implement GUI client support: Code Review hc_upd20150129b.zip
My review of ZCL is not very very deep. But overall, I'm fine with the update. O... Greg Shah
10:51 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
>
> After re-enabling this code for the case oldLbl is null, the NPE is no longer there.... Hynek Cihlar
05:43 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> > > An update, the NPE is caused by my changes. I have changed the side-label management sligh... Constantin Asofiei
05:06 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek Cihlar wrote:
> > > > Const... Hynek Cihlar
04:52 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin, this also touches some o... Constantin Asofiei
04:18 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, this also touches some of your side-label changes, ... Hynek Cihlar
03:24 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin, this also touches some of your side-label changes, please have a look too. Also no... Constantin Asofiei
02:44 AM Feature #2252: implement GUI client support: Replacement for ca_upd20150123a.zip, side-labels in shared frames.
Passed runtime testing, released to rev 10725. Constantin Asofiei
08:51 PM Feature #2252: implement GUI client support: The attached update adds support for moving frame widgets by setting col/row/x/y attributes from application code. Th... Hynek Cihlar
04:37 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: This attribute is available on selection list, combo-box and browse column. Please write use cases to test it, inclu... Greg Shah
04:33 PM Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...: Greg Shah
04:11 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: > there are the testcases/uast/*focus*.p tests.
Good idea. I'll see if they can be used to test this out. Greg Shah
04:09 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Greg Shah wrote:
> I wonder if it is worth testing my second approach with MAJIC.
Yes, I think this one is OK to te... Constantin Asofiei
03:57 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: I've tried the following idea:... Greg Shah
03:54 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Greg Shah wrote:
> That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave proce... Constantin Asofiei
03:37 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave processing must be respon... Greg Shah
03:26 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: @refocusTarget@ might have been used to solve a case like this:... Constantin Asofiei
02:43 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: The change to add @refocusTarget()@ came in rev 9907 (H649 on 20101015 by SIY). There is no indication of why this w... Greg Shah
02:26 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: I stepped over that @refocusTarget()@ call because I knew the target widget was already in focus.
I don't fully un... Greg Shah
01:25 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Greg Shah wrote:
> Part of the problem is that the screen refreshes are deferred so I can't see when the cursor move... Constantin Asofiei
01:02 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: This update fixes the trigger recursion but the cursor is still always forced back to the first char position. I hav... Greg Shah
07:11 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Actually, we do have generic protection logic for trigger recursion. It is located in @LogicalTerminal.trigger()@:
... Greg Shah
02:36 PM Feature #2494 (Closed): DELETE() method runtime implementation: Greg Shah
02:34 PM Feature #2494: DELETE() method runtime implementation: Passed runtime regression testing and checked in as bzr rev 10727. Igor Skornyakov
02:05 PM Feature #2494: DELETE() method runtime implementation: You can check in the update and send the associated notification email.
Please make sure you have no other changes... Greg Shah
01:48 PM Feature #2494: DELETE() method runtime implementation: Igor Skornyakov wrote:
> Actually the is one test which failed in exactly the same way in both runs:
>
> failure ... Constantin Asofiei
01:44 PM Feature #2494: DELETE() method runtime implementation: Actually the is one test which failed in exactly the same way in both runs:
failure in step 40: 'Unexpected EOF in... Igor Skornyakov
01:05 PM Feature #2494: DELETE() method runtime implementation: Are there any specific tests that failed in both runs (even though the failure was at a different point)? The only w... Greg Shah
12:41 PM Feature #2494: DELETE() method runtime implementation: Second run of the regression test failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gs... Igor Skornyakov
08:34 AM Feature #2494: DELETE() method runtime implementation: Merged with recent changes Igor Skornyakov
01:05 PM Feature #2498: implement ADD-LAST() method: Yes and yes. Greg Shah
12:28 PM Feature #2498: implement ADD-LAST() method: I have a question.
As far as I understand there is no "null" value in ABL - it has "unknown" (literal ?) instead. If... Igor Skornyakov
07:02 PM Feature #2478: button image support: Conversion testing completed. The codes are identical. Starting the runtime testing. Eugenie Lyzenko

01/28/2015

05:21 PM Feature #2494: DELETE() method runtime implementation: 1 tests failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gso_tests 2314.617 ... Igor Skornyakov
11:16 AM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
>
> I'm OK with the ch... Igor Skornyakov
11:09 AM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
I'm OK with the changes. Please get them ... Greg Shah
11:08 AM Feature #2494: DELETE() method runtime implementation: Sorry, I wasn't looking carefully enough. I see that you defined your own interface to match the concept of the @Fun... Greg Shah
11:07 AM Feature #2494: DELETE() method runtime implementation: Also, please don't upload modified updates as the same update zip file name. The update in note 80 is your second up... Greg Shah
11:05 AM Feature #2494: DELETE() method runtime implementation: I don't understand. Isn't @Function@ a Java 8 thing or a Guava thing? Neither should be used in our code. Where in... Greg Shah
10:24 AM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> 1. We do not yet support Java 8. We want to do so, but it takes some real planning because it re... Igor Skornyakov
09:55 AM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150128a.zip
1. We do not yet support Java 8. We want to do so, but it takes some real planni... Greg Shah
06:27 AM Feature #2494: DELETE() method runtime implementation: Java code updated: use value instead of label in the @DELETE(list-items)@ for COMBO-BOX and SELECTION-LIST widgets.
Igor Skornyakov
05:11 PM Feature #2498: implement ADD-LAST() method: Do you have testcases for the errors and edge cases?
Please collect all of your testcases and check them into the ... Greg Shah
04:57 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Please check how this works with parameters that are unknown value and empty string.
>
> Pleas... Igor Skornyakov
04:48 PM Feature #2498: implement ADD-LAST() method: Please check how this works with parameters that are unknown value and empty string.
Please also check how it work... Greg Shah
03:36 PM Feature #2498: implement ADD-LAST() method: Greg,
1. Can I start Java runtime implementation?
2. Should I try to implement the described "strange" behaviour if... Igor Skornyakov
03:16 PM Feature #2498: implement ADD-LAST() method: Sample 4GL programs Igor Skornyakov
01:55 PM Feature #2498: implement ADD-LAST() method: The RADIO-SET widget has only @ADD-LAST(label, value)@ method.
It just adds the new label/value to the widget.
If AUT... Igor Skornyakov
10:42 AM Feature #2498: implement ADD-LAST() method: For COMBO-BOX and SELECTION-LIST:
1. If LIST-ITEM-PAIRS is set then @ADD-LAST(items)@ is rejected with two warnings (... Igor Skornyakov
05:06 PM Feature #1790: implement menu support: > Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to call this menu ... Greg Shah
04:37 PM Feature #1790: implement menu support: I also want to add, that I faced with conversion bug for frames during conversion of @chui_menu_2_purpose.p@. Extra f... Vadim Gindin
04:31 PM Feature #1790: implement menu support: I need an advice. Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to... Vadim Gindin
03:02 PM Feature #1790: implement menu support: I'm working on showing POPUP-MENU for widgets. I'd like to add this too.
About @MenuElementConfig@. There is some ... Vadim Gindin
12:56 PM Feature #1790: implement menu support: I'd like to see this next set of functionality stabilized and put into testing. What is left to do? Greg Shah
12:55 PM Feature #1790: implement menu support: Code Review vig_upd20150128a.zip
Overall, this is MUCH better than the previous approach. Well done.
1. Menus n... Greg Shah
04:03 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: This update (which does make ANY-PRINTABLE more widely functional), can also cause problems. This code that applies ... Greg Shah
03:01 PM Feature #2478: button image support: >It looks good. Please do get it tested.
OK. Starting the conversion testing stage(we have the rule changed). Eugenie Lyzenko
02:56 PM Feature #2478: button image support: Code Review evl_upd20150128a.zip
It looks good. Please do get it tested. Greg Shah
02:50 PM Feature #2478: button image support: Reworked image loading support.
- New interfaces added, reworked conversion rule for methods.
- bit change for imag... Eugenie Lyzenko
12:56 PM Feature #2478: button image support: > So we can run testing now or postpone to the time the interface rework is ready. What do you think?
Do the rewor... Greg Shah
12:25 PM Feature #2478: button image support: >This update seems pretty close to something that can go into regression testing. Is there anything else needed excep... Eugenie Lyzenko
12:13 PM Feature #2478 (WIP): button image support: > Is it answering to your question?
Yes.
This update seems pretty close to something that can go into regressio... Greg Shah
11:24 AM Feature #2478: button image support: >1. There are no real changes in ButtonWidget, just a history entry. I think that can be removed safely. :)
OK. Done... Eugenie Lyzenko
11:01 AM Feature #2478: button image support: Code Review evl_upd20150127a.zip
I like it.
1. There are no real changes in @ButtonWidget@, just a history entr... Greg Shah
08:27 PM Feature #2478: button image support: Small update to add method interfaces to support dynamic button/image widgets. Eugenie Lyzenko

01/27/2015

03:46 PM Feature #2494: DELETE() method runtime implementation: It appears that my understanding of the DELETE() method semantics was incorrect -the @DELETE(list-items)@ for COMBO-B... Igor Skornyakov
08:47 AM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150127a.zip
The changes look good.
I agree that the testing failures are most likely not d... Greg Shah
06:00 AM Feature #2494: DELETE() method runtime implementation: Some regression tests failed:
1. 1. failure in step 13: 'timeout before the specific screen buffer became available ... Igor Skornyakov
02:31 PM Feature #1790: implement menu support: 1) I've prepared the next update with separate menu description class. Does it preferable than previous updates with ... Vadim Gindin
04:26 AM Bug #2495: APPLY event TO handle does not work: ca_upd20150127a.zip passed conversion testing and was released to bzr rev 10723 Constantin Asofiei
04:26 AM Bug #2495: APPLY event TO handle does not work: Fixed some conversion issues related to APPLY TO handle.
Anything which has a frame-id needs to convert as a Gener... Constantin Asofiei
08:29 PM Feature #2478: button image support: Had to modify @CommonWidget/GenericWidget@ classes to add @loadImage*()@ methods support to handle dynamically alloca... Eugenie Lyzenko

01/26/2015

02:44 PM Feature #2494: DELETE() method runtime implementation: Thank you. Igor Skornyakov
02:24 PM Feature #2494: DELETE() method runtime implementation: Igor Skornyakov wrote:
> I tried to run regression test, but it failed (runtime-regression).
The problem is with y... Constantin Asofiei
02:22 PM Feature #2494: DELETE() method runtime implementation: Got it. Thank you for your patience. I've configured Eclipse to avoid specific explicit imports. BTW: what about stat... Igor Skornyakov
01:37 PM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150124d.zip
Almost there. 5 small problems are remaining. Sorry that we are so specific in o... Greg Shah
06:51 AM Feature #2494: DELETE() method runtime implementation: I'm very sorry, but I've dropped the entire content of the repo by a stupid mistake. How this can be repaired?
Igor Skornyakov
06:08 AM Feature #2494: DELETE() method runtime implementation: Something is wrong with your repo, see this like:... Constantin Asofiei
06:03 AM Feature #2494: DELETE() method runtime implementation: I've tried to run regression testing but the compilation failed. Please find the build logs attached. As I can see th... Igor Skornyakov

01/24/2015

02:53 PM Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...: Passed regression testing and checked in as bzr rev 10720. Greg Shah
07:56 PM Feature #2478: button image support: This updates has code merged with recent code base.
One interesting thing I've found. If the method @LOAD-IMAGE()@... Eugenie Lyzenko

01/23/2015

06:00 PM Feature #1790: implement menu support: I've fixed this bug. It was some sort of serialization bug. I also fixed a drawing of menu-item labels for menubar. H... Vadim Gindin
12:06 PM Feature #1790: implement menu support: Hopefully you are continuing to debug. I have no idea what is causing the problem. Greg Shah
10:02 AM Feature #1790: implement menu support: I did it and nevertheless the constructor of @SilentUnwindException@ is called from client-side with the error @com.g... Vadim Gindin
09:31 AM Feature #1790: implement menu support: I can't tell anything useful from the logs. You'll have to set breakpoints in the @SilentUnwindException@ constructo... Greg Shah
09:27 AM Feature #1790: implement menu support: In the future, when posting something that isn't large, please post it in-line here. Don't attach a file for such th... Greg Shah
09:23 AM Feature #1790: implement menu support: I need some advice. I got an error, that happen right in the moment of client call. I've filled @ScreenDefinition@ wi... Vadim Gindin
04:24 PM Feature #2494: DELETE() method runtime implementation: Done. I did it with meld - it appears to be almost as good as Araxis Merge I used before. Igor Skornyakov
04:14 PM Feature #2494: DELETE() method runtime implementation: The class definition itself has been changed:... Greg Shah
03:56 PM Feature #2494: DELETE() method runtime implementation: I see tow issues.
1. Invalid braces in constructor (fixed)
2. Reformatted comments/Javadocs.
I can revert my chang... Igor Skornyakov
03:39 PM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150123c.zip
> I'm sorry.
No worries. Learning the coding standards is part of the ramp-up... Greg Shah
03:07 PM Feature #2494: DELETE() method runtime implementation: Oh, I'm sorry. It appears that one have to set this in two places in Eclipse now. Igor Skornyakov
02:44 PM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150123b.zip
Actually, this update is very hard to compare with the first for @ComboBoxWidget@... Greg Shah
02:27 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> FYI, we prefer to minimize the linkages because there can be unintended consequences. For exampl... Igor Skornyakov
02:06 PM Feature #2494: DELETE() method runtime implementation: FYI, we prefer to minimize the linkages because there can be unintended consequences. For example, some of our code ... Greg Shah
02:05 PM Feature #2494: DELETE() method runtime implementation: Sadly, I see that it has also sneaked its way into @LogicalTerminal@ and @ChuiWebPageHandler@. We'll need to clean t... Greg Shah
02:00 PM Feature #2494: DELETE() method runtime implementation: Igor Skornyakov wrote:
> Got it.
> Regarding 3rd party dependencies. I used Google Guava classes only because the c... Constantin Asofiei
01:53 PM Feature #2494: DELETE() method runtime implementation: Got it.
Regarding 3rd party dependencies. I used Google Guava classes only because the corresponding jar is already ... Igor Skornyakov
01:14 PM Feature #2494: DELETE() method runtime implementation: Code Review ias_upd20150123.zip
Functionally, it is quite good. Most of the feedback relates to coding standards.... Greg Shah
12:54 PM Feature #2494: DELETE() method runtime implementation: Please find updated classes attached. Igor Skornyakov
12:27 PM Feature #2494: DELETE() method runtime implementation: That should not be needed.
OK, so you should do the following:
1. Upload the update zip file here so that we ca... Greg Shah
12:19 PM Feature #2494: DELETE() method runtime implementation: Thank you - it works. I've finished testing in ChUI mode. Shall I test on Windows as well? Igor Skornyakov
11:59 AM Feature #2494: DELETE() method runtime implementation: It's not the best way, but for now you can use this: @frame.getName(this)@ from within a widget. This corresponds to... Greg Shah
10:55 AM Feature #2494: DELETE() method runtime implementation: I've started testing in ChUI mode. Basically all works, but there is one minor(?) issues:
The type() return not th... Igor Skornyakov
09:44 AM Feature #2494: DELETE() method runtime implementation: It's OK - I understand. Thank you, Igor Skornyakov
09:43 AM Feature #2494: DELETE() method runtime implementation: Good. Sorry for the old docs. We are busy and haven't gotten them updated. And those docs reference an internal bz... Greg Shah
09:35 AM Feature #2494: DELETE() method runtime implementation: Yes, it works, thank you. Igor Skornyakov
09:23 AM Feature #2494: DELETE() method runtime implementation: The documentation is out of date. The @ServerDriver@ itself has no understanding of a @-z@ parameter. The @server.s... Greg Shah
09:12 AM Feature #2494: DELETE() method runtime implementation: I got the command from /books/conversion_handbook/p2j_conversion_handbook.pdf page 221 Igor Skornyakov
09:03 AM Feature #2494: DELETE() method runtime implementation: I don't fully understand what you are saying you did or what the problem is.
When I run a server for my converted ... Greg Shah
06:43 AM Feature #2494: DELETE() method runtime implementation: I've tried to launch the P2J Server as described in the "P2J Conversion Handbook", but got an error @"Too many config... Igor Skornyakov
03:46 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: No, here it is. Greg Shah
03:45 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Good catch. Here is the version with javadoc. Greg Shah
03:03 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Greg Shah wrote:
> Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing... Constantin Asofiei
01:45 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing. Greg Shah
01:34 PM Bug #2495 (Closed): APPLY event TO handle does not work: Greg Shah
01:29 PM Bug #2495 (Review): APPLY event TO handle does not work: Greg Shah wrote:
> Please check it in.
Released to rev 10719. Constantin Asofiei
08:28 AM Bug #2495: APPLY event TO handle does not work: Please check it in. Greg Shah
07:13 AM Bug #2495: APPLY event TO handle does not work: Greg Shah wrote:
> Code Review ca_upd20150122c.zip
>
> It looks good.
0122c.zip passed runtime/conversion testing. Constantin Asofiei
12:31 PM Feature #2498: implement ADD-LAST() method: This method is available on selection list, combo-box, radio-set and browse column. Follow the same approach as for ... Greg Shah
12:30 PM Feature #2498 (Closed): implement ADD-LAST() method: Greg Shah
10:05 AM Feature #2478: button image support: This update for review adds @DEFINE IMAGE@ handling for deferred data loading for image widget.
Continue working. Eugenie Lyzenko
09:18 AM Feature #2252: implement GUI client support: Code Review ca_upd20150123a.zip
The changes look good. The result is cleaner too from a design perspective, so it... Greg Shah
07:48 AM Feature #2252: implement GUI client support: Fix for side-label in shared frames. Built on top of #2495 ca_upd20150122c.zip Constantin Asofiei

01/22/2015

06:15 PM Feature #2478: button image support: This update for review contains prototype for deferred image loading in button widget. Some notes:
1. There is only ... Eugenie Lyzenko
05:55 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: The testcase is checked in as @testcases/uast/any_printable_event.p@. Greg Shah
05:53 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: This is the fix. It ensures that ANY-PRINTABLE and ANY-KEY are searched on each pass through (specific-widget, frame... Greg Shah
05:49 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere: The following testcase illustrates this problem:... Greg Shah
05:48 PM Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...: Greg Shah
02:20 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> For this task I think you can ignore the browse column aspects.
OK. Thank you.
Igor Skornyakov
02:17 PM Feature #2494: DELETE() method runtime implementation: > If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO... Greg Shah
02:11 PM Feature #2494: DELETE() method runtime implementation: Here it is Igor Skornyakov
02:09 PM Feature #2494: DELETE() method runtime implementation: > If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO... Greg Shah
01:43 PM Feature #2494: DELETE() method runtime implementation: Please note the generated code for the BROWSE widget contains nothing related to a combo-box column except @addWidget... Igor Skornyakov
01:22 PM Feature #2494: DELETE() method runtime implementation: Indeed - after commenting out p2j_test namespace the browse2.p converted OK (even with @f0+cb@)
Thanks a lot! Igor Skornyakov
01:20 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> The "b" reference in the define frame is being matched with a field in the book table of p2j_test... Eric Faulhaber
01:15 PM Feature #2494: DELETE() method runtime implementation: I guess that P2J is having a problem with @DEFINE FRAME f b.@ from line 10 of @r-browse2.p@, if that is the same prog... Greg Shah
12:55 PM Feature #2494: DELETE() method runtime implementation: Well, the conversion passed for combo, radio and select. I had to use @f2+m0+cb@ as @f0+cb@ disn't work (at some stag... Igor Skornyakov
12:39 PM Feature #2494: DELETE() method runtime implementation: Thank you very much.
Now the conversion started. However there are other problems at the later steps. I'll try to un... Igor Skornyakov
11:37 AM Feature #2494: DELETE() method runtime implementation: I believe that the current @testcases/uast/@ environment was broken at some point by some kind of metadata -nonsense-... Greg Shah
11:28 AM Feature #2494: DELETE() method runtime implementation: Greg,
I cannot perform the conversion:
Exception in thread "main" java.lang.ExceptionInInitializerError
Caused by:... Igor Skornyakov
09:57 AM Feature #2494: DELETE() method runtime implementation: > I understand that now I have to convert my 4GL sample programs and test. Is that correct?
Exactly right. Greg Shah
09:25 AM Feature #2494: DELETE() method runtime implementation: I see. Thank you.
I've implemented @DELETE()@ for RADIO-SET, SELECTION-LIST and COMBO-BOX. I understand that now I... Igor Skornyakov
08:44 AM Feature #2494: DELETE() method runtime implementation: Each resource type has a TYPE attribute. It comes from the @CommonHandle@ interface and is implemented for widgets a... Greg Shah
07:30 AM Feature #2494: DELETE() method runtime implementation: I have a question.
In 4GL warning contains a name of the widget - e.g. "The DELETE attribute on the SELECTION-LIST ... Igor Skornyakov
01:37 PM Bug #2495: APPLY event TO handle does not work: Code Review ca_upd20150122c.zip
It looks good. Greg Shah
01:19 PM Bug #2495: APPLY event TO handle does not work: Attached fixes the issues in notes 3 and 5. Testing is under way. Constantin Asofiei
12:52 PM Bug #2495: APPLY event TO handle does not work: > Should I continue fixing this?
Yes, if it can be done in a reasonable amount of time. I think it is time to get... Greg Shah
12:37 PM Bug #2495: APPLY event TO handle does not work: There is this case also:... Constantin Asofiei
10:24 AM Bug #2495: APPLY event TO handle does not work: Greg Shah wrote:
> 3. In @LogicalTerminal.apply(WrappedResource res, double eventCode)@, could a non-widget/non-fram... Constantin Asofiei
09:56 AM Bug #2495: APPLY event TO handle does not work: Code Review ca_upd20150122a.zip
This is really good. I like how you solved the ID lookup problem by using a diffe... Greg Shah
09:00 AM Bug #2495: APPLY event TO handle does not work: -------- Forwarded Message --------
Subject: Re: common idiom which we don't handle properly
Date: Thu, 22 Jan 2015... Greg Shah
08:59 AM Bug #2495: APPLY event TO handle does not work: I have found a common idiom which we don't handle properly. Here is an example:... Greg Shah
08:56 AM Bug #2495 (Closed): APPLY event TO handle does not work: Greg Shah

01/21/2015

06:17 PM Feature #2476: window icon support improvements: Committed in bzr as 10716. Eugenie Lyzenko
06:03 PM Feature #2476: window icon support improvements: Yes, go ahead. Greg Shah
05:47 PM Feature #2476: window icon support improvements: The @CTRL-C@ part completed without regressions. Had to start 3-way tests separately. The results file is on the shar... Eugenie Lyzenko
09:31 AM Feature #2476: window icon support improvements: The main part of the regression testing has been completed without regressions, starting the @CTRL-C@ tests. Eugenie Lyzenko
06:06 PM Feature #2478: button image support: OK, please take this into account in your design.
1. I think that the loadImage() methods should still be used by ... Greg Shah
05:32 PM Feature #2478: button image support: >Eugenie: please determine the answer to this question.
The answer is the moment when button is realized is the po... Eugenie Lyzenko
01:57 PM Feature #2478: button image support: > But if the image is loaded only when the frame (or button?) is realised, unless I've missed some discussion on the... Greg Shah
01:26 PM Feature #2478: button image support: >> Postpone the image loading to the moment when the button widget is created on the client side. This will requir... Eugenie Lyzenko
01:25 PM Feature #2478: button image support: Greg Shah wrote:
> > Postpone the image loading to the moment when the button widget is created on the client side. ... Constantin Asofiei
01:15 PM Feature #2478: button image support: > Postpone the image loading to the moment when the button widget is created on the client side. This will require ad... Greg Shah
12:56 PM Feature #2478: button image support: The button widget image processing note. There are two places when we need to set/load image integration into button ... Eugenie Lyzenko
01:29 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> I have not yet gotten the time to finish the code review on those changes (and on the other fix... Igor Skornyakov
01:06 PM Feature #2494: DELETE() method runtime implementation: > So, it seems that I can start coding now. Is that correct?\
Yes.
> Albeit these changes do not affect the cla... Greg Shah
01:01 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> Just change the @delete(int)@ to be @delete(long)@
Got it. So, it seems that I can start codin... Igor Skornyakov
12:51 PM Feature #2494: DELETE() method runtime implementation: > I see. However at this moment we have @delete(int)@ method in the @ControlSetEntity@ (and even in @GenericWidget@).... Greg Shah
12:22 PM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> > But I see entry(int) and entry(int64) in ControlSetEntity, but there is no entry(long)
>
> I... Igor Skornyakov
12:08 PM Feature #2494: DELETE() method runtime implementation: Constantin Asofiei wrote:
> To determine what is the message shown by the DELETE method (in this case), usually I ch... Igor Skornyakov
11:08 AM Feature #2494: DELETE() method runtime implementation: Constantin Asofiei wrote:
> On a side note, how do you use the @r-radio.p@ test? I've tried switching focus to the f... Igor Skornyakov
10:41 AM Feature #2494: DELETE() method runtime implementation: Greg Shah wrote:
> Constantin/Stanislav: can you think of other ways we code these warning cases in the P2J runtime?... Constantin Asofiei
10:21 AM Feature #2494: DELETE() method runtime implementation: > Does it just mean that there is no need to add delete(decimal idx) method?
Yes. Although how we would handle a ... Greg Shah
09:30 AM Feature #2494: DELETE() method runtime implementation: > This means we need some extra investigation. Some warnings are just formatted messages displayed in the message ... Igor Skornyakov
08:52 AM Feature #2494: DELETE() method runtime implementation: > method generates warning if
This means we need some extra investigation. Some warnings are just formatted mess... Greg Shah
07:29 AM Feature #2494: DELETE() method runtime implementation: Questions.
1. I understand that we should not care about thread safety of widgets' methods as they are supposed to b... Igor Skornyakov
07:09 AM Feature #2494: DELETE() method runtime implementation: Runtime support.
1. Server side.
a. Implement @delete(int idx)@, @delete(int64 idx)@, @delete(String item)@ and @de... Igor Skornyakov
06:04 AM Feature #2494: DELETE() method runtime implementation: 1. The statement about raising error is not correct. Actually the @DELETE(list-index)@ method generates warning if ar... Igor Skornyakov
08:57 AM Feature #2422: add features to BROWSE: About this particular feature:
>If the previous page is fully deleted, you have to press Page Up twice in order to m... Stanislav Lomany
08:14 AM Feature #2422: add features to BROWSE: You'll be working on GUI soon, so do make sure that your approach can be easily adapted for those cases. Greg Shah

01/20/2015

05:59 PM Feature #2422: add features to BROWSE: Some differences in handling of Page Up/Down in ChUI and UI versions.
# About Page Down key (in ChUI it's not actu... Stanislav Lomany
04:31 PM Feature #2494: DELETE() method runtime implementation: Good results.
Please make sure you have tested the following:
* For @DELETE(list-index)@: @INTEGER@ inputs of 0... Greg Shah
02:59 PM Feature #2494: DELETE() method runtime implementation: 1. The @DELETE()@ method exists for COMBO-BOX, RADIO-SET, SELECTION-LIST and BROWSE column widgets. Its semantics and... Igor Skornyakov
11:16 AM Feature #2494: DELETE() method runtime implementation: You can edit it manually like a normal cell. I'm not sure if drop-down list can actually appear in browse in ChUI. Po... Stanislav Lomany
07:45 AM Feature #2494: DELETE() method runtime implementation: Stanislav: in the 4GL, how does one get the ChUI browse cell for a combo-box into editing mode? Greg Shah
07:42 AM Feature #2494: DELETE() method runtime implementation: I failed to activate editing in Linux character mode. In Windows GUI mode the corresponding cell had standard clickab... Igor Skornyakov
07:38 AM Feature #2494: DELETE() method runtime implementation: FYI, LIST-ITEMS support in P2J may be partial (I think it is missing at least for browse columns).
When running th... Greg Shah
03:40 PM Feature #2476: window icon support improvements: The conversion testing completed. Generated codes are identical. Starting the runtime testing.
And I have committe... Eugenie Lyzenko
10:59 AM Feature #2476: window icon support improvements: > I suggest to run regression and commit icon related changes to have some intermediate work stage to shift the next... Greg Shah
10:59 AM Feature #2476: window icon support improvements: It is not a bad idea to load resources from a specific part of the jar, but I am OK with the current implementation a... Greg Shah
10:56 AM Feature #2476: window icon support improvements: Eugenie Lyzenko wrote:
> Regarding icon loading. Everything looks OK except one point I need to clarify:
> 1. Assum... Constantin Asofiei
10:42 AM Feature #2476: window icon support improvements: Regarding icon loading. Everything looks OK except one point I need to clarify:
1. Assume we start the server from @... Eugenie Lyzenko
08:02 PM Feature #2476: window icon support improvements: > I'm good with this.
>
> Does this pass all of your 4GL testcases?
>
> If so, please put it into conversion an... Eugenie Lyzenko
07:11 PM Feature #2476: window icon support improvements: Code Review evl_upd20150119c.zip
I'm good with this.
Does this pass all of your 4GL testcases?
If so, please... Greg Shah

01/19/2015

06:53 PM Feature #2476: window icon support improvements: Greg Shah wrote:
>
> The only thing I see is that @FileSystemOps.searchPath()@ should not be called from the clien... Eugenie Lyzenko
06:15 PM Feature #2476: window icon support improvements: Code Review evl_upd20150119b.zip
This is really good!
The only thing I see is that @FileSystemOps.searchPath(... Greg Shah
05:43 PM Feature #2476: window icon support improvements: Small change to eliminate point #4 from the notes. Eugenie Lyzenko
02:28 PM Feature #2476: window icon support improvements: The new update for review. The fixes for notes to the previous one. Also the @gclogo.ico@ default icon has been moved... Eugenie Lyzenko
11:44 AM Feature #2476: window icon support improvements: > Does it mean the @FileSystemOps.searchPath()@ must be called on client side?
Not exactly. Instead, the client ... Greg Shah
11:35 AM Feature #2476: window icon support improvements: One question.
>...If the app jar load fails, then it calls the client with a filename. It is the ThinClient.set*(S... Eugenie Lyzenko
03:33 PM Feature #2494: DELETE() method runtime implementation: > How the COMBO-BOX widget for the BROWSE column can be activated in the Linux character mode?
This is close, but... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

02/17/2015

02/16/2015

02/13/2015

02/12/2015

02/11/2015

02/10/2015

02/09/2015

02/06/2015

02/05/2015

02/04/2015

02/03/2015

02/02/2015

02/01/2015

01/31/2015

01/30/2015

01/29/2015

01/28/2015

01/27/2015

01/26/2015

01/24/2015

01/23/2015

01/22/2015

01/21/2015

01/20/2015

01/19/2015