Project

General

Profile

Activity

From 01/29/2015 to 02/27/2015

02/27/2015

05:18 PM Feature #2480: add support for button and image attributes and options
The update contains conversion support and runtime start point starting point for @NO-FOCUS@ and @FLAT-BUTTON@ option... Eugenie Lyzenko
02:21 PM Feature #2498: implement ADD-LAST() method
No, let it finish. Greg Shah
01:41 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Igor: do you have any other problems to solve or is this it?
No. I do not have any new problem...
Igor Skornyakov
01:37 PM Feature #2498: implement ADD-LAST() method
Igor: do you have any other problems to solve or is this it?
Constantin, Hynek, Eric and I all have quite a few ch...
Greg Shah
01:11 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that ha...
Constantin Asofiei
01:03 PM Feature #2498: implement ADD-LAST() method
Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that has broken RFQ? Greg Shah
11:45 AM Feature #2498: implement ADD-LAST() method
Both gsO301 and gso_308 failed at the same screen. As far as I understand the code for this screen is in @syman/so/se... Igor Skornyakov
07:18 AM Feature #2498: implement ADD-LAST() method
After fixes only the following tests failed in two runs:
3 gso_301: failure in step 6: 'timeout before the spec...
Igor Skornyakov
07:41 AM Feature #2525: Runtime support of frame positional attributes
The objective of this issue is to implement support of missing parts of frame positional attributes. Also to make sur... Hynek Cihlar
07:23 AM Feature #2525 (New): Runtime support of frame positional attributes
Hynek Cihlar

02/26/2015

04:07 PM Feature #2479 (Closed): DEFINE IMAGE and image phrase support for both button and image
Greg Shah
03:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The update @evl_upd20150225b.zip@ has been committed in bzr as 10780. Eugenie Lyzenko
03:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Yes, please check it in. Greg Shah
03:14 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Testing completed. The results file: @10778_5c96d7c_20150226_evl.zip@.
So the update is ready to be committed and ...
Eugenie Lyzenko
11:47 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The main part of the regression tests completed OK. Waiting for CTRL-C to be done. Eugenie Lyzenko
07:48 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The conversion testing completed. Codes are identical, no regression. Continue with the runtime testing. Eugenie Lyzenko
12:25 PM Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> After my recent minor changes RFQ tests started to fail. I'm looking into that.
I would...
Eric Faulhaber
12:15 PM Feature #2422: add features to BROWSE
After my recent minor changes RFQ tests started to fail. I'm looking into that. Stanislav Lomany
12:09 PM Feature #2422: add features to BROWSE
The persistence changes in 0225a look OK to me. Eric Faulhaber
09:38 AM Feature #2422: add features to BROWSE
Code Review svl_upd20150225a.zip
I'm fine with the changes. I looked at everything pretty carefully, except @Brow...
Greg Shah
10:18 AM Feature #1790: implement menu support
Yes, that was the reason.. Sorry for trouble. Vadim Gindin
10:03 AM Feature #1790: implement menu support
Mistake..
Here is the place in @ThinClient.waitFor@ where immedExit is set to true:...
Vadim Gindin
09:59 AM Feature #1790: implement menu support
I found that during processing of @ThinClient.waitFor@ the flag @immedExit@ is set to true. It probably a reason.. It... Vadim Gindin
09:51 AM Feature #1790: implement menu support
I'm stuck... I can't make menu events working. I don't fully understand how events queue works. Here are the followin... Vadim Gindin
06:30 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Code Review ias_upd20150225a.zip
1. The update should only contain files that were modified for this task. As far...
Greg Shah

02/25/2015

03:58 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
> Eugenie: please confirm that it is not needed. If so, please remove it. Then go ahead with both conversion and ru... Eugenie Lyzenko
03:52 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
> the call to @setPhysicalLocation@ in @IGI.initialize@ should be unnecessary as you already set the physical locatio... Greg Shah
03:36 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Greg Shah wrote:
> Code Review evl_upd20150225a.zip
>
> I'm fine with the changes.
>
> Hynek: please look at t...
Hynek Cihlar
02:11 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150225a.zip
I'm fine with the changes.
Hynek: please look at the @BaseConfig@ change and c...
Greg Shah
12:07 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for review has general fix for dynamic widget location issue. All processing shifted to @BaseConfig.apply... Eugenie Lyzenko
09:33 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Greg Shah wrote:
> Code Review evl_upd20150224a.zip
>
> Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ real...
Hynek Cihlar
09:17 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> One more possible TODO change is rework for image phrase setters for button related images ...
Greg Shah
09:16 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
One more possible TODO change is rework for image phrase setters for button related images we have discussed previous... Eugenie Lyzenko
09:05 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150224a.zip
Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ really the proper locations ...
Greg Shah
08:53 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets...
Greg Shah
08:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets. Currently button has @NO... Eugenie Lyzenko
03:09 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Finished adding DELIMITER attribute support and fixing LIST-ITEMS and LIST-ITEM-PAIRS logic. Testing is still require... Igor Skornyakov
02:32 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Greg Shah wrote:
> Progress is full of these insane "quirks". In these cases we try to leave careful comments and j...
Igor Skornyakov
02:19 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Progress is full of these insane "quirks". In these cases we try to leave careful comments and javadoc to explain th... Greg Shah
02:15 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Greg Shah wrote:
> Are you saying that the 4GL reacts differently in these two situations?
Yes, it does.
> If so...
Igor Skornyakov
02:02 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Are you saying that the 4GL reacts differently in these two situations?
Unknown literal:...
Greg Shah
12:47 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
I've discovered a strange behavior: for the COMBO-BOX and SELECTION-LIST @ADD-LAST(..., ?)@ is rejected but the code
...
Igor Skornyakov
01:58 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge yo...
Igor Skornyakov
11:58 AM Feature #2498: implement ADD-LAST() method
OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge your code up to newer ... Greg Shah
11:35 AM Feature #2498: implement ADD-LAST() method
Adding separate height/width fields doesn't help. Starting a detailed investigation. In particular I can see the the ... Igor Skornyakov
09:08 AM Feature #2478 (Closed): button image support
Greg Shah
09:07 AM Feature #2476 (Closed): window icon support improvements
Greg Shah
08:55 AM Feature #2480: add support for button and image attributes and options
The following attributes/options are left to b implemented/verified as working if already implemented:
+Button opt...
Eugenie Lyzenko
05:53 AM Feature #2422: add features to BROWSE
Major browse update for review. Changed caching logic in order to match 4GL. Stanislav Lomany

02/24/2015

06:33 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for review merges the recent code base plus fixes the location issue for dynamic images and buttons. The ... Eugenie Lyzenko

02/23/2015

03:08 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
The version on lindev01 is 10.2B and has not been changed since it was installed in early 2013. I access it via /usr... Greg Shah
02:34 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
RADIO-BUTTONS attribute for the RADIO-SET widget behaves like LIST-ITEM-PAIRS for the SELECTION-LIST.
Conclusion:
...
Igor Skornyakov
10:38 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
1. We need to add support for the DELIMITER attribute
2. DELIMITER attribute value cannot be "unknown", but can be "...
Igor Skornyakov
02:41 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Although it seems unlikely that the problems are caused by your update, it is very unusual for th...
Igor Skornyakov
11:30 AM Feature #2498: implement ADD-LAST() method
Although it seems unlikely that the problems are caused by your update, it is very unusual for the same list of tests... Greg Shah
09:14 AM Feature #2498: implement ADD-LAST() method
Greg,
Can I commit my changes?
Thank you.
Igor Skornyakov
01:29 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
> Normally, I would ask you to get these tested, but Igor has overlapping changes being tested in #2498 and he has ha... Eugenie Lyzenko
01:07 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150223a.zip
The changes look good.
Normally, I would ask you to get these tested, but Igor...
Greg Shah
12:39 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Sorry the update @0223a@ was inconsistent(has not final versions). Please see the new drop. Eugenie Lyzenko
12:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for review adds boolean attributes setters/getters outside of the @DEFINE IMAGE@ or @DEFINE BUTTON@ state... Eugenie Lyzenko
07:19 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The remaining thing I'm going to implement is having getters/setters for all attributes in image and button widgets t... Eugenie Lyzenko
12:02 PM Feature #1790: implement menu support
>> At this point are ChUI menus fully functional?
>
> No. I can't finish client-side part because of event-processi...
Greg Shah
10:07 AM Feature #1790: implement menu support
You're right. Some of noted points are not implemented. See below
Greg Shah wrote:
> At this point are ChUI menus...
Vadim Gindin

02/22/2015

04:05 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Greg Shah wrote:
> Yes, go ahead and commit it.
Committed in bzr as 10771.
Eugenie Lyzenko
03:32 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Yes, go ahead and commit it. Greg Shah
02:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The conversion testing completed, generated codes are identical. No regressions.
So the update is ready to be comm...
Eugenie Lyzenko
07:03 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The update fixes the size/location regression for images used to draw the buttons. Plus slightly enhanced icon detect... Eugenie Lyzenko
08:01 AM Feature #2498: implement ADD-LAST() method
Attached detailed reports for failed tests. Igor Skornyakov
05:44 AM Feature #2498: implement ADD-LAST() method
There where 3 runs of the regression test.
The following test failed in in all 3 runs:
gso_tests
57 gso_187: fa...
Igor Skornyakov

02/20/2015

06:10 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is the next update containing basic GUI implementation.
Questions:
1. When I'm going between checkboxes I've...
Vadim Gindin
05:25 PM Feature #2523: implement GUI radio-set widget
The core widget implementation for GUI must be created including drawing and event processing. Mouse support must wo... Greg Shah
05:23 PM Feature #2523 (Closed): implement GUI radio-set widget
Greg Shah
05:22 PM Feature #2522: add attribute/method support for radio-set
Implement conversion and runtime support for the following:
+Attributes+
NUM-BUTTONS
+Methods+
DISABLE()
...
Greg Shah
05:21 PM Feature #2522 (Closed): add attribute/method support for radio-set
Greg Shah
05:21 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>Please do fix both of these issues (character unit mismatches and the regression for IMAGE-SIZE options) as part of ... Eugenie Lyzenko
05:00 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> >Have you run your testcases in both windev01 and in P2J? Does our implementation match exa...
Greg Shah
04:59 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
> I've changed the rule file and want to make sure there will be no regression her. Is it OK?
Good point. Yes, c...
Greg Shah
04:57 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
Yes, I'm comparin...
Eugenie Lyzenko
04:41 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the server-... Eugenie Lyzenko
04:34 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly? Greg Shah
04:32 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the serve... Greg Shah
04:06 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>1. In Convert3DColorsFilter, are the input colors to be converted really hard coded in the 4GL?
I think so, from ...
Eugenie Lyzenko
03:52 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150220a.zip
1. In @Convert3DColorsFilter@, are the input colors to be converted really hard c...
Greg Shah
03:40 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This updates for review includes runtime implementation of the @CONVERT-3D-COLORS@ option for image and button widget... Eugenie Lyzenko
02:22 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150219a.zip
It is good.
Greg Shah
08:01 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update adds conversion rule change to support @RETAIN-SHAPE@ sub-option and runtime implementation for @STRETCH-... Eugenie Lyzenko
05:20 PM Feature #2521 (Closed): enhance/implement radio-set for GUI
Greg Shah
02:31 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
Yes, I think you are right. Please test and fix any issues related to those.
Another thing: please test these bot...
Greg Shah
02:26 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
I understand the LIST-ITEM-PAIRS and RADIO-BUTTONS attributes are in the scope of this task as well. Is that correct?
Igor Skornyakov
02:16 PM Feature #1790: implement menu support
At this point are ChUI menus fully functional?
Is there any error handling, event or other missing functionality? ...
Greg Shah
01:56 PM Feature #1790: implement menu support
Javadoc fix.
Remaining features needing to be implemented is empty at this moment. Probably some features will be ...
Vadim Gindin
01:22 PM Feature #1790: implement menu support
Please post a list of the remaining features needing to be implemented, enhanced and/or bugs needing fixing. You can... Greg Shah
01:21 PM Feature #1790: implement menu support
In your next update, please resolve these:... Greg Shah
01:02 PM Feature #1790: implement menu support
Current update has passed full testing and committed to rev #10766. Vadim Gindin
12:26 PM Feature #1790: implement menu support
OK, you can commit vig_upd20150220a.zip. Greg Shah
12:12 PM Feature #1790: implement menu support
Here is merged current update with the latest revision. Vadim Gindin
12:06 PM Feature #1790: implement menu support
> I suspect that this error is not related with my update. Don't you know why it happens?
We don't know for sure. ...
Greg Shah
11:02 AM Feature #1790: implement menu support
I've ran regression testing 3rd time. And the test @tc_codes_employees_20@ has passed. So, we can assume that update ... Vadim Gindin
03:28 AM Feature #1790: implement menu support
Current update has passed conversion testing. I ran regression testing twice. Only one test has failed during both ru... Vadim Gindin
02:00 PM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150220c.zip
It looks good.
Greg Shah
01:50 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr ...
Igor Skornyakov
12:47 PM Feature #2498: implement ADD-LAST() method
There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr revision and put tha... Greg Shah
12:42 PM Feature #2498: implement ADD-LAST() method
The following tests failed in both runs:
57 gso_187 GSO 187 - Initial selection on Contact Master returns to main...
Igor Skornyakov
12:00 PM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150220a.zip
The @ScrollDirection@ constructor still needs Javadoc. Obviously, this doesn't i...
Greg Shah
11:57 AM Feature #2498: implement ADD-LAST() method
> The ChuiOutputManager sets the value of the cursorInvalid in the at method and doesn't reset it in the append(Strin... Greg Shah
03:57 AM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Igor: in regard to the scrolling problems, I'd like for you to finish the current task without ad...
Igor Skornyakov
03:41 AM Feature #2498: implement ADD-LAST() method
Constantin Asofiei wrote:
> Please add Keyboard.SE_NEXT_FRAME and Keyboard.SE_PREV_FRAME cases to AbstractWidget.ign...
Igor Skornyakov
03:39 AM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Code Review ias_upd20150219a.zip
>
> 1. In @RadioButtonImpl.draw()@, why iterate through chara...
Igor Skornyakov
02:34 AM Feature #2498: implement ADD-LAST() method
About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be deleted) by bo... Constantin Asofiei
02:20 AM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> 3. After some recent changes (as far as I understand - introducing @manageSystemActions()@ ...
Constantin Asofiei
07:39 PM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150219a.zip
1. In @RadioButtonImpl.draw()@, why iterate through character by character instea...
Greg Shah
07:08 PM Feature #2498: implement ADD-LAST() method
Igor: in regard to the scrolling problems, I'd like for you to finish the current task without adding more work to it... Greg Shah
07:03 PM Feature #2498: implement ADD-LAST() method
Constantin: please comment on note 72 and item 3 in note 85. Greg Shah
01:47 PM Bug #2520: Dynamic list controls are not visible
Greg Shah wrote:
> Is this still a problem on bzr rev 10766?
Yes, it is.
Igor Skornyakov
01:38 PM Bug #2520: Dynamic list controls are not visible
Is this still a problem on bzr rev 10766? Greg Shah
01:37 PM Bug #2520: Dynamic list controls are not visible
The dynamic RADIO-SET and COMBO-BOX are not visible, but are "working" - one can make a "blind" selection with the RA... Greg Shah
07:47 AM Bug #2520 (Closed): Dynamic list controls are not visible
Igor Skornyakov
01:40 PM Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
From CA:
About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be del...
Greg Shah
01:40 PM Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets
The attached sample after conversion throws NPE on exit:
[02/17/2015 19:25:51 MSK] (StandardServer.invoke:SEVERE) ...
Greg Shah
07:41 AM Bug #2518 (New): NPE on exit from testcase with mixed usage of static and dynamic widgets
Igor Skornyakov
01:39 PM Bug #2519: suspicious looking scrolling code
1. The @ScrollBar.scroll()@ method looks to contain a typo: in line 253 @limit.x@ seems to be instead of @limit.y@
2...
Greg Shah
07:43 AM Bug #2519 (New): suspicious looking scrolling code
Igor Skornyakov
01:36 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Code Review evk_upd20150218a.zip
It is a good step.
1. @EditorWidget.read/saveFile(character)@ need @null@ and ...
Greg Shah
08:02 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Added runtime support. I'm not finished testing at the moment, but common functionality is working. Evgeny Kiselev
11:25 AM Feature #2422: add features to BROWSE
Technically that's not a browse problem, but because of record retrieval logic browse uses, an editable browse easily... Stanislav Lomany

02/19/2015

11:18 AM Feature #2498: implement ADD-LAST() method
I've finished with scrolling changes. My changes do not affect the @ComboBox@ behavior as this widget doesn't rely on... Igor Skornyakov
09:45 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150218a.zip
It looks good.
Greg Shah

02/18/2015

06:06 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for your review adds transparency runtime implementation for image widget. Also it prepares other boolean... Eugenie Lyzenko
05:49 PM Feature #1790: implement menu support
Code Review vig_upd20150219a.zip
I ma OK with the changes. Please get this update conversion and runtime regressi...
Greg Shah
05:37 PM Feature #1790: implement menu support
The next update, containing remarks corrections and overrides bug fix Vadim Gindin
04:01 PM Feature #1790: implement menu support
> Don't you remember where that conversion logic?
See the @process_frame@ function in @annotations/frame_scoping.r...
Greg Shah
03:46 PM Feature #1790: implement menu support
Greg Shah wrote:
> > Wait a minute. It seems that it is a frames naming (class naming) problem.
>
> This makes se...
Vadim Gindin
02:52 PM Feature #1790: implement menu support
> Wait a minute. It seems that it is a frames naming (class naming) problem.
This makes sense. Please put some pr...
Greg Shah
02:36 PM Feature #1790: implement menu support
Greg Shah wrote:
> In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default...
Vadim Gindin
02:21 PM Feature #1790: implement menu support
In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default "unnamed" frame. S... Greg Shah
02:00 PM Feature #1790: implement menu support
I'm debugging difficult bug:... Vadim Gindin
05:41 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Is there a bug in our implementation of the 4GL built-in function @SEARCH()@ that makes it work differently with file... Greg Shah
05:38 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Greg Shah wrote:
> I don't think you need to do anything like that. The client-side code would call @FileSystemDaem...
Evgeny Kiselev
05:34 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
I don't think you need to do anything like that. The client-side code would call @FileSystemDaemon.searchPath()@, wh... Greg Shah
05:31 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Can you suggest what is common "looking" directories in 4gl ? at least common work dir I can take from @Configuration... Evgeny Kiselev
07:07 AM Feature #2498: implement ADD-LAST() method
Hynek Cihlar wrote:
> I think it won't hurt if you start fixing the immediate pains - the unclear model of scroll ...
Igor Skornyakov
07:04 AM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> I'm not sure that I understand this completely. However it seems that it means that a widge...
Hynek Cihlar
05:03 AM Feature #2498: implement ADD-LAST() method
Hynek Cihlar wrote:
> Personally I would rather see the scroll event initiated by the widget receiving focus itsel...
Igor Skornyakov

02/17/2015

04:28 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see. May I make a suggestion?
> > First of all I think that it is ...
Hynek Cihlar
04:12 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
...
Hynek Cihlar
04:07 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> I see. May I make a suggestion?
> First of all I think that it is important for the scroll...
Greg Shah
02:29 PM Feature #2498: implement ADD-LAST() method
I see. May I make a suggestion?
First of all I think that it is important for the scroll to be well-defined and idemp...
Igor Skornyakov
02:03 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
...
Greg Shah
12:59 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Please provide more specifics about what needs to be different.
Well, first of all the whole...
Igor Skornyakov
12:42 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Generally, no it is not OK.
>
> I do see that @RadioButtonImpl.drawButton()@ does not honor th...
Igor Skornyakov
12:40 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4...
Greg Shah
12:34 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suita...
Greg Shah
12:33 PM Feature #2498: implement ADD-LAST() method
In regard to the NPE, I don't understand why we would be pushing screen definitions to the client during the processi... Greg Shah
11:57 AM Feature #2498: implement ADD-LAST() method
Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4GL the focused item is hig... Igor Skornyakov
11:34 AM Feature #2498: implement ADD-LAST() method
It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suitable for at least a @RadioS... Igor Skornyakov
11:29 AM Feature #2498: implement ADD-LAST() method
The sample code is a result of my test evolution - I've added more code while investigating the widget behavior. Plea... Igor Skornyakov
10:02 AM Feature #2498: implement ADD-LAST() method
The code seems very complicated, with many more frames than I would have expected to be used or needed. Did you get ... Greg Shah
04:13 AM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> 3. About the NPE in @LogicalTerminal.pushScreenDefinition()@, can you show the 4GL code that can ...
Igor Skornyakov
10:44 PM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150216a.zip
1. The @RadioSetInterface@ header should be above the import and package statemen...
Greg Shah
08:55 AM Feature #2412: Implement widget browser
Code Review hc_upd20150217b.zip
It looks good. Please check it in.
Greg Shah
04:54 AM Feature #2412: Implement widget browser
Missing history entry added and converted tabs to spaces in the whole PropertyTable.java. build.xml removed as this s... Hynek Cihlar
10:48 PM Feature #2412: Implement widget browser
Code Review hc_upd20150217a.zip
1. @PropertyTable@ needs a history entry. It also needs all of its hard-tab chars...
Greg Shah
08:15 PM Feature #2412: Implement widget browser
The attached update extends Widget browser with the possibility to copy widget properties to clipboard. This is usefu... Hynek Cihlar
02:06 AM Feature #2422: add features to BROWSE
> > But I can handle browsing part because BrowseColumnWidget.setDColor(Color) does the job.
>
> I don't understan...
Stanislav Lomany
10:31 PM Feature #2422: add features to BROWSE
> while BrowseColumnWidget.setDColor(NumberType) doesn't actually set a color because ColorSpec.convert() always retu... Greg Shah

02/16/2015

03:49 PM Feature #2498: implement ADD-LAST() method
Added support for the HORIZONTAL and EXPAND attributes. Still need to fix scrolling behavior. Igor Skornyakov
03:32 PM Feature #2422: add features to BROWSE
FYI, Majic alters browse column "colors" in two places. E.g.:... Stanislav Lomany
09:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Committed in bzr as 10757. Eugenie Lyzenko
09:38 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Check it in. Greg Shah
08:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The runtime testing completed without regressions(separate run for CTRL-C 3 way tests). The results are in @10754_5c9... Eugenie Lyzenko

02/13/2015

12:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Greg Shah wrote:
> Code Review evl_upd20150212b.zip
>
> It looks good, get it both conversion and runtime regress...
Eugenie Lyzenko
09:22 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150212b.zip
It looks good, get it both conversion and runtime regression tested.
Greg Shah
10:53 AM Feature #1790: implement menu support
Code Review vig_upd20150210a.zip
This is very close.
1. There is a build directory included in your update zip ...
Greg Shah
09:55 AM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150212a.zip
It is very good. Some minor things:
1. Add @RadioSetInterface@ to @HandleComm...
Greg Shah

02/12/2015

04:42 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
OK. This update for review changes row/column offsets to double and adjust client side to use new double data. Eugenie Lyzenko
04:10 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that ...
Greg Shah
12:02 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>Instead of having 3 sets of setters, you could have 1 set and generate an enum value that distinguishes between @But... Eugenie Lyzenko
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> >Is there anything left to do for this task?
>
> The following options need to be implem...
Greg Shah
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150212a.zip
1. All row/col values need to be decimal/double as well. I should have seen thi...
Greg Shah
07:17 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Eugenie Lyzenko wrote:
> >2. Although it is probably OK, I find it confusing that the image phrase generates differe...
Greg Shah
07:00 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>2. Although it is probably OK, I find it confusing that the image phrase generates different setters for the same op... Eugenie Lyzenko
05:13 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
>Is there anything left to do for this task?
The following options need to be implemented:
CONVERT-3D-COLORS
STR...
Eugenie Lyzenko
07:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Code Review evl_upd20150211b.zip
This is really good.
1. I suspect the @IMAGE-SIZE@/@IMAGE-SIZE-CHARS@ should b...
Greg Shah
03:58 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
That is probably the issue. Try it from the command line. Greg Shah
03:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Done. I've uploaded @vig_server_client.zip@ to @/home/vig@
I use Java configuration in Eclipse.
Vadim Gindin
02:51 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please archive your testcases/simple/server, testcases/simple/client folders and upload them to devsrv01.
How do y...
Constantin Asofiei
02:48 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Thanks. I tried it and got the error:
> > [...]
> Are you usi...
Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
@display "This"@ behaves as the first test: window 1x1 in the left top corner. Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Thanks. I tried it and got the error:
> [...]
Are you using the latest P2J rev? Note that t...
Constantin Asofiei
01:42 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Thanks. I tried it and got the error:... Vadim Gindin
08:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I didn't find any peculiarities. Here is the test:
>
> [...]
Have you added basic runtime ...
Constantin Asofiei
06:58 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I faced with the following difficulty: running application window (GUI) has the size 1x1 and position in the first pi... Vadim Gindin
03:19 PM Feature #2498: implement ADD-LAST() method
1. fixed the issues you've mentioned by Greg.
2. Added server-side support for HORIZONTAL and EXPAND attributes. Cli...
Igor Skornyakov
08:20 AM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150211b.zip
1. This code in @CommonWidget@ is incorrect:...
Greg Shah

02/11/2015

04:40 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The second update for today has small fixes for image widget bugs/regressions. I guess now if there are no objections... Eugenie Lyzenko
01:15 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
The update for review includes candidate for image phrase handling for button widget. Need the tests to not getting r... Eugenie Lyzenko
07:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This drop includes merging with the recent code base and fix for handling case when requested image size is bigger th... Eugenie Lyzenko
04:05 PM Feature #2498: implement ADD-LAST() method
1. The converted code with horizontal RADIO-SET behaves very different from the 4GL. In particular the EXPAND flag is... Igor Skornyakov
07:14 AM Feature #2498: implement ADD-LAST() method
Finished refactoring and adding new attributes/methods support. Now I should check the behavior of RADIO-SET runtime ... Igor Skornyakov
12:41 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I didn't find any peculiarities. Here is the test:... Vadim Gindin

02/10/2015

06:20 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Code Review evk_upd20150209a.zip
Looks good so far.
Greg Shah
06:18 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
> I planed to add in the LogicalTerminal new methods for read/save files.
That is OK. These should call down to a...
Greg Shah
05:59 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Just want to clarify:
I planed to add in the @LogicalTerminal@ new methods for read/save files. Also I need to add s...
Evgeny Kiselev
12:22 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
Added conversion support for SAVE-FILE method Evgeny Kiselev
02:58 PM Feature #2498: implement ADD-LAST() method
> The converted code runs w/o any complains
The 4GL docs state that @LIST-ITEM-PAIRS@ is valid for combo-box, sele...
Greg Shah
02:56 PM Feature #2498: implement ADD-LAST() method
Constantin Asofiei wrote:
> Igor, as you are using a dynamic RADIO-SET and not a static RADIO-SET (created via the...
Igor Skornyakov
02:49 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation?
It will com...
Igor Skornyakov
02:46 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> Greg Shah wrote:
> > This you can fix. Please post a simplified testcase (in @[...]@ tags...
Constantin Asofiei
02:42 PM Feature #2498: implement ADD-LAST() method
> which is illegal for 4GL
Do you mean that the code will not EXECUTE in the 4GL? It fails at compilation?
Greg Shah
02:36 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> This you can fix. Please post a simplified testcase (in @[...]@ tags) so that I can see what you...
Igor Skornyakov
02:27 PM Feature #2498: implement ADD-LAST() method
> I have the following in mind. As you know I've moved some methods from CommonWdget/GenericWidget to a separate inte... Greg Shah
02:23 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> We don't want to support any case where the code can never be valid or where we are mis-convertin...
Igor Skornyakov
02:09 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> One more question.
> I've noticed that in some cases an invalid attribute result in 4GL co...
Greg Shah
02:08 PM Feature #2498: implement ADD-LAST() method
Igor Skornyakov wrote:
> The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dyn...
Greg Shah
12:49 PM Feature #2498: implement ADD-LAST() method
One more question.
I've noticed that in some cases an invalid attribute result in 4GL compilation failure while in o...
Igor Skornyakov
12:31 PM Feature #2498: implement ADD-LAST() method
The situation with invisible dynamic RADIO-SET widget is still unclear. It appears that dynamic COMBO-BOX and SELECTI... Igor Skornyakov
02:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Not exactly. What I meant is that I would like to see some specific findings about the drawing and event processing ... Greg Shah
02:12 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
About my implementation plan. I just think that I'll firstly implement drawing and after that I'll be implementing ev... Vadim Gindin
09:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
This widget is supported for ChUI runtime usage today. It's conversion should be pretty complete, but I haven't chec... Greg Shah
09:19 AM Feature #2513 (Closed): implement GUI runtime support for TOGGLE-BOX
Greg Shah
03:16 AM Feature #1790: implement menu support
Here is the current update.
It adds to following changes to previous:
* An implementation of find* methods,
* Se...
Vadim Gindin

02/09/2015

04:00 PM Feature #2498: implement ADD-LAST() method
Extracted list widgets-specific methods to a separate interface @com.goldencode.p2j.ui.CommonListWidget@ Igor Skornyakov
03:23 PM Feature #2498: implement ADD-LAST() method
> Should I remove these methods from CommonWidget/GenericWidget?
Yes.
> Please note that in this case these met...
Greg Shah
03:16 PM Feature #2498: implement ADD-LAST() method
I've extracted methods which are defines for lists widgets only to a separate interface. Should I remove these method... Igor Skornyakov
12:21 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> This is easy to do, but it has the unwanted result of making the generated code much more verbose...
Igor Skornyakov
12:10 PM Feature #2498: implement ADD-LAST() method
> Don't you think that it is more practical to change the code generation? I mean that the code generator can validat... Greg Shah
11:47 AM Feature #2498: implement ADD-LAST() method
> Just by marking the method as "Widget" in @methods_attributes.rules@ would work. It is not how we want it to work,... Igor Skornyakov
11:46 AM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> Are you saying that you cannot write code like this: @my-widget:add-last(my-char-var, "Some Text"...
Igor Skornyakov
11:03 AM Feature #2498: implement ADD-LAST() method
Perhaps that interface would be called @ListManagement@.
>> 2. Don't we still need addLast(character, String)?
> ...
Greg Shah
11:00 AM Feature #2498: implement ADD-LAST() method
> > 3. The change in @handle@ is incorrect. @ControlEntity@ is not an interface and MUST NOT be an unwrap target. A... Greg Shah
10:56 AM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> 1. Coding standard issues that remain:
>
> * @for(@ should be @for (@ - @ComboBoxModel@, @Radi...
Igor Skornyakov
09:23 AM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150209a.zip
1. Coding standard issues that remain:
* @for(@ should be @for (@ - @ComboBoxM...
Greg Shah
08:43 AM Feature #2498: implement ADD-LAST() method
1. Formatting issues are fixed (I hope)
2. The list widgets' behaviour updated according to recent findings.
Igor Skornyakov
07:32 AM Feature #2498: implement ADD-LAST() method
> Please note however that if one tries to delete an item with label which doesn't exists in a case-sensitive way but... Greg Shah
07:21 AM Feature #2498: implement ADD-LAST() method
A more thorough analysis revealed the following details about the list widgets' behaviour:
1. For COMBO-BOX: the @DE...
Igor Skornyakov
11:22 AM Feature #2422: add features to BROWSE
Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to GUI only. Reproduction:
@down to 8...
Stanislav Lomany
11:07 AM Feature #2422: add features to BROWSE
It turns out that for ChUI behavior of Page Down differs for preselect and adaptive queries. For example the followin... Stanislav Lomany

02/06/2015

03:48 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for review presents the approach for image-phrase implementation candidate. Needs to check and debug but ... Eugenie Lyzenko
02:20 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Will you also insist on using of @PaintEvent@? If yes could you help me to understand how it s...
Constantin Asofiei
12:28 PM Feature #1790: implement menu support
How to properly test static menus deletion? Vadim Gindin
02:13 PM Feature #2498: implement ADD-LAST() method
>
> > 6. The item ID generator should not be in the @ControlSetConfig@ class. We are trying to eliminate all logi...
Greg Shah
01:46 PM Feature #2498: implement ADD-LAST() method
Greg Shah wrote:
> 2. Is there any way to introduce problems in @ComboBoxModel.calcSelection()@ by relying upon the ...
Igor Skornyakov
01:14 PM Feature #2498: implement ADD-LAST() method
Code Review ias_upd20150205a.zip
I really like your nicely factored @ControlSetEntity@ @add*()@ implementation. I...
Greg Shah
12:27 PM Feature #2498: implement ADD-LAST() method
Got it. Thank you. Igor Skornyakov
12:24 PM Feature #2498: implement ADD-LAST() method
> I've also notices that all handle.unwrapXXX() methods work with interfaces while ControlEntity is a class. I don't ... Greg Shah
12:04 PM Feature #2498: implement ADD-LAST() method
Got it. Actually I've already stated to look at the conversion details.
I've added @unwrapConrolEntity()@ method to ...
Igor Skornyakov
11:52 AM Feature #2498: implement ADD-LAST() method
I will do the code review next. Sorry that I have been slow to respond. I've just been very busy.
In regard to t...
Greg Shah
10:26 AM Feature #2498: implement ADD-LAST() method
Regression test performed twice.
The following steps failed identically in both runs:
4 ctrlc_11_session1 CTRL...
Igor Skornyakov

02/05/2015

04:15 PM Feature #2478: button image support
The update @evl_upd20150204a.zip@ has been committed in bzr as 10744. Eugenie Lyzenko
04:08 PM Feature #2478: button image support
The testing completed. Results: @10742_5c96d7c_20150205_evl.zip@. No regressions confirmed.
I've stopped the serve...
Eugenie Lyzenko
10:53 AM Feature #2478: button image support
I appreciate that you are taking extra care. Thanks. Greg Shah
10:36 AM Feature #2478: button image support
The runtime testing almost completed. The only issue is the @GSO 269@ test. It failed with two main cycles but passed... Eugenie Lyzenko
03:06 PM Feature #2498: implement ADD-LAST() method
Just a notice. It seems that there are some problems with conversion.
1. Conversion of the attached @radio2.p@ progr...
Igor Skornyakov
01:58 PM Feature #2498: implement ADD-LAST() method
All done and is ready for the code review. I'm not sure however that frame overflow detection at @RadioSetWidget.addL... Igor Skornyakov
08:19 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update adds missing in previous update @ImageConfig@ class. Also it resolves the offset-size phrase issues found... Eugenie Lyzenko

02/04/2015

05:09 PM Feature #2478: button image support
The conversion testing completed. The generated code is identical. Continue with runtime testing. Eugenie Lyzenko
02:20 PM Feature #2478: button image support
> Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in.
...
Eugenie Lyzenko
01:46 PM Feature #2478: button image support
Please go ahead and do one more round of testing, using evl_upd20150204a.zip. If it passes, you can check it in. Greg Shah
11:16 AM Feature #2478: button image support
Merged with 10741 code base. Eugenie Lyzenko
01:03 PM Feature #2498: implement ADD-LAST() method
Fixed @SelectionListBody@ to correctly restore selection after list modification Igor Skornyakov
10:54 AM Feature #2498: implement ADD-LAST() method
Just noticed that ListSelectionModel implementation should be revised - currently it behaves incorrectly after ADD-FI... Igor Skornyakov
10:43 AM Feature #2498: implement ADD-LAST() method
SELECTION-LIST behaviour fixed to be compatible with 4GL (both in SINGLE and MULTIPLE selection modes).
RADIO-SET ...
Igor Skornyakov
08:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for review includes suggest for runtime implementation for image phrase for image widget. In general it w... Eugenie Lyzenko

02/03/2015

03:22 PM Feature #2498: implement ADD-LAST() method
Implemented @ADD-LAST()@ and fixed @ADD-FIRST()@ for RADIO-SET. Igor Skornyakov
01:07 PM Feature #2498: implement ADD-LAST() method
Yes, please fix it. Greg Shah
12:40 PM Feature #2498: implement ADD-LAST() method
ADD-FIRST/ADD-LAST/DELETE functionality for SELECTION-LIST look OK.
However I've noticed that Java runtime doesn't a...
Igor Skornyakov
09:27 AM Feature #2498: implement ADD-LAST() method
An id field is added to ControlSetItem. Now the behaviour of COMBO-BOX widget after ADD-FIRST/ADD-LAST/DELETE operati... Igor Skornyakov
02:14 PM Feature #1790: implement menu support
Could you help me with initial focus setting. I'm trying to set focus on a first menu-item in a shown pop-up menu i.e... Vadim Gindin

02/02/2015

03:55 PM Feature #2422: add features to BROWSE
Addition to note 63. Another 4GL bug which I'm not going to reproduce. Applies to ChUI and GUI. If the number of rows... Stanislav Lomany
02:50 PM Feature #2498: implement ADD-LAST() method
Most of the above is implemented (for COMBO-BOX). However the issue with the value shown in the box after @ADD-FIRST@... Igor Skornyakov
10:25 AM Feature #2478: button image support
The @evl_upd20150202a.zip@ also merged with 10739. Eugenie Lyzenko
09:15 AM Feature #2478: button image support
Update merged with 10738 code base. Eugenie Lyzenko

02/01/2015

03:52 PM Feature #2478: button image support
Update merged with the 10736 code base. Eugenie Lyzenko
11:02 PM Feature #2478: button image support
Sorry, there are 2 updates in front of you right now. Hynek's is first and then Constantin has one. Thanks for your... Greg Shah
11:50 AM Feature #2498: implement ADD-LAST() method
Good work in finding these issues.
> Should I start working on the issues mentioned above?
Yes, please do.
Greg Shah
11:15 AM Feature #2498: implement ADD-LAST() method
It is easy to implement section 2 (e.g by adding @realValue@ field to @ControlSetItem@ in addition to @value@ - for @... Igor Skornyakov

01/31/2015

05:36 PM Feature #2478: button image support
Merged with recent code base. Is it time to start new round or there will be more updates? Eugenie Lyzenko
02:38 PM Feature #1790: implement menu support
I didn't find a way to get it work with posting @PaintEvent@. But I've fixed the bug adding @menu.requestSync()@ call... Vadim Gindin

01/30/2015

05:01 PM Feature #2478: button image support
> Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have... Eugenie Lyzenko
04:57 PM Feature #2478: button image support
Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have @... Greg Shah
11:43 AM Feature #2478: button image support
The @CTRL-C@ part completed without regression. 3-way tests was started in a separate session. The results file on sh... Eugenie Lyzenko
07:56 AM Feature #2478: button image support
Finally I have got the main part completed without regression. Starting the @CTRL-C@ tests. Eugenie Lyzenko
04:51 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
This update for your review includes conversion support implementation candidate for @size-phrase@ and @image-phrase@... Eugenie Lyzenko
05:35 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Yes, please implement this. Greg Shah
05:25 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image
Question. Do we need th support for @FROM {X n Y n} | {ROW n COLUMN n}@ clause of the @image phrase@?
This sets th...
Eugenie Lyzenko
03:31 PM Feature #1790: implement menu support
I did as you advised. I used @menu.setVisible(true)@ that calls @repaint()@ method, that in turn call @EventManager.p... Vadim Gindin
11:22 AM Feature #1790: implement menu support
Greg Shah wrote:
> 1. I think your drawing issues are related to how you are directly calling @menu.draw()@ in @Thi...
Constantin Asofiei
08:44 AM Feature #1790: implement menu support
> but still got mbar.getSelf().readOnlyError("popup-only");.
You have to add the attribute into the writable attri...
Greg Shah
08:06 AM Feature #1790: implement menu support
# I've added POPUP-ONLY to @load_descriptiors@ function along with other menu related attributes, created @MenuInterf... Vadim Gindin
03:27 PM Feature #2498: implement ADD-LAST() method
Additional details about COMBO-BOX widget behaviour in presence of duplicated/"unknown" labels/values:
1. empty labe...
Igor Skornyakov
08:41 AM Feature #2498: implement ADD-LAST() method
> May be it makes sense to fix the implementation of ADD-FIRST as well (the current implementation also doesn't show ... Greg Shah
07:48 AM Feature #2498: implement ADD-LAST() method
If "unknown value is specified for @ADD-LAST(items)@ method it is accepted but on the screen a blank line is shown (i... Igor Skornyakov
08:16 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
LE: the trigger in note 22 was changed to be for the frame, not widget. Constantin Asofiei
08:12 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
I'm noting this here, but is a bug, not a regression; the following case doesn't work in P2J:... Constantin Asofiei
06:56 AM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
The changes are doing well in regression testing. I got timeout failures in tc_item_master_006, tc_item_master_104 a... Greg Shah

01/29/2015

06:20 PM Feature #1790: implement menu support
Code Review vig_upd20150130a.zip
I think it is moving in the right direction.
1. I think your drawing issues ar...
Greg Shah
03:54 PM Feature #1790: implement menu support
The next update, containing the following changes.
# The first working (in testing mode) variant with popup-menu.
#...
Vadim Gindin
08:29 AM Feature #1790: implement menu support
OK. Keep this in mind when you are working on getting the event processing to work properly. Greg Shah
05:38 AM Feature #1790: implement menu support
Greg Shah wrote:

> Can you create a trigger on this event and use no-apply? Something like this:
>
> [...]
>...
Vadim Gindin
05:31 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20150129b.zip
>
> My review of ZCL is not very very deep. But overall, I'm ...
Hynek Cihlar
05:07 PM Feature #2252: implement GUI client support
Code Review hc_upd20150129b.zip
My review of ZCL is not very very deep. But overall, I'm fine with the update. O...
Greg Shah
10:51 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
>
> After re-enabling this code for the case oldLbl is null, the NPE is no longer there....
Hynek Cihlar
05:43 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> > > An update, the NPE is caused by my changes. I have changed the side-label management sligh...
Constantin Asofiei
05:06 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek Cihlar wrote:
> > > > Const...
Hynek Cihlar
04:52 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin, this also touches some o...
Constantin Asofiei
04:18 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, this also touches some of your side-label changes, ...
Hynek Cihlar
03:24 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin, this also touches some of your side-label changes, please have a look too. Also no...
Constantin Asofiei
02:44 AM Feature #2252: implement GUI client support
Replacement for ca_upd20150123a.zip, side-labels in shared frames.
Passed runtime testing, released to rev 10725.
Constantin Asofiei
04:37 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
This attribute is available on selection list, combo-box and browse column. Please write use cases to test it, inclu... Greg Shah
04:33 PM Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...
Greg Shah
04:11 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
> there are the testcases/uast/*focus*.p tests.
Good idea. I'll see if they can be used to test this out.
Greg Shah
04:09 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
Greg Shah wrote:
> I wonder if it is worth testing my second approach with MAJIC.
Yes, I think this one is OK to te...
Constantin Asofiei
03:57 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
I've tried the following idea:... Greg Shah
03:54 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
Greg Shah wrote:
> That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave proce...
Constantin Asofiei
03:37 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave processing must be respon... Greg Shah
03:26 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
@refocusTarget@ might have been used to solve a case like this:... Constantin Asofiei
02:43 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
The change to add @refocusTarget()@ came in rev 9907 (H649 on 20101015 by SIY). There is no indication of why this w... Greg Shah
02:26 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
I stepped over that @refocusTarget()@ call because I knew the target widget was already in focus.
I don't fully un...
Greg Shah
01:25 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
Greg Shah wrote:
> Part of the problem is that the screen refreshes are deferred so I can't see when the cursor move...
Constantin Asofiei
01:02 PM Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
This update fixes the trigger recursion but the cursor is still always forced back to the first char position. I hav... Greg Shah
02:36 PM Feature #2494 (Closed): DELETE() method runtime implementation
Greg Shah
02:34 PM Feature #2494: DELETE() method runtime implementation
Passed runtime regression testing and checked in as bzr rev 10727. Igor Skornyakov
02:05 PM Feature #2494: DELETE() method runtime implementation
You can check in the update and send the associated notification email.
Please make sure you have no other changes...
Greg Shah
01:48 PM Feature #2494: DELETE() method runtime implementation
Igor Skornyakov wrote:
> Actually the is one test which failed in exactly the same way in both runs:
>
> failure ...
Constantin Asofiei
01:44 PM Feature #2494: DELETE() method runtime implementation
Actually the is one test which failed in exactly the same way in both runs:
failure in step 40: 'Unexpected EOF in...
Igor Skornyakov
01:05 PM Feature #2494: DELETE() method runtime implementation
Are there any specific tests that failed in both runs (even though the failure was at a different point)? The only w... Greg Shah
12:41 PM Feature #2494: DELETE() method runtime implementation
Second run of the regression test failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gs...
Igor Skornyakov
08:34 AM Feature #2494: DELETE() method runtime implementation
Merged with recent changes Igor Skornyakov
01:05 PM Feature #2498: implement ADD-LAST() method
Yes and yes. Greg Shah
12:28 PM Feature #2498: implement ADD-LAST() method
I have a question.
As far as I understand there is no "null" value in ABL - it has "unknown" (literal ?) instead. If...
Igor Skornyakov
 

Also available in: Atom