Activity

From 02/11/2015 to 03/12/2015

03/13/2015

08:21 PM Feature #2480: add support for button and image attributes and options: This updates is merged with the recent code base. Also it adds conversion/runtime support for standalone set/get @DEF... Eugenie Lyzenko

03/12/2015

04:01 PM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> Igor, I think the update is safe now. But please rename @pairsSetWhenRealized@ to @item... Igor Skornyakov
03:39 PM Feature #2522: add attribute/method support for radio-set: Igor, I think the update is safe now. But please rename @pairsSetWhenRealized@ to @itemsSetWhenRealized@ - this flag... Constantin Asofiei
01:16 PM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> Igor, I'm still trying to understand why the @pairsSetWhenRealized@ flag is needed - ple... Igor Skornyakov
12:51 PM Feature #2522: add attribute/method support for radio-set: Igor, I'm still trying to understand why the @pairsSetWhenRealized@ flag is needed - please post a simple, minimum te... Constantin Asofiei
12:37 PM Feature #2522: add attribute/method support for radio-set: Code Review ias_upd20150312b.zip
I'm OK with the changes. Greg Shah
12:18 PM Feature #2522: add attribute/method support for radio-set: Actually Constantin is right: I've not tested all cases. Please find the update attached.
Thank you Constantin. Igor Skornyakov
11:26 AM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> About ias_upd20150312a.zip:
> * @ControlSetEntity.pairs@ - the javadoc for @return@ is ... Igor Skornyakov
10:56 AM Feature #2522: add attribute/method support for radio-set: About ias_upd20150312a.zip:
* @ControlSetEntity.pairs@ - the javadoc for @return@ is not formatted properly.
* @Con... Constantin Asofiei
09:07 AM Feature #2522: add attribute/method support for radio-set: Code Review ias_upd20150312a.zip
I'm fine with the changes.
Constantin: please review. Greg Shah
07:44 AM Feature #2522: add attribute/method support for radio-set: Done. The regression test started. The attached archive also contains minor fixed for #2508 and #2520 Igor Skornyakov
09:22 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150311a.zip
I'm good with the changes. Greg Shah

03/11/2015

06:47 PM Feature #2480: add support for button and image attributes and options: The update for review presents suggested approach in base for implementation of the default button feature. The frame... Eugenie Lyzenko
08:37 AM Feature #2480: add support for button and image attributes and options: My only concern here is that the logic for this should not be in the window widget, but in the frame widget. Doesn't... Greg Shah
09:23 PM Feature #2480: add support for button and image attributes and options: Looking for best implementation for button @DEFAULT@ attribute handling I see the following opportunity:
1. Pressing... Eugenie Lyzenko
12:35 PM Bug #2520: Dynamic list controls are not visible: This looks reasonable. Please add this to the changes for #2522 to reduce testing effort. Also, it will give Consta... Greg Shah
11:55 AM Bug #2520: Dynamic list controls are not visible: With the following update in Frame... Igor Skornyakov
10:06 AM Feature #2422: add features to BROWSE: Update merged with the latest sources. Committed to bzr rev 10804. Stanislav Lomany
08:16 AM Feature #1790: implement menu support: Vadim, some notes about the vig_20150309a.zip update you've sent me:
* Rectangle: the instances of this class need t... Constantin Asofiei

03/10/2015

07:17 PM Feature #1790: implement menu support: > I don't fully understand this statement. MENUBAR draws it's items (menu-items and sub-menus) within its area. Dropp... Greg Shah
06:58 PM Feature #1790: implement menu support: Greg Shah wrote:
> Some thoughts:
>
> 1. Menus are different from our normal containers like Frames. With menus,... Vadim Gindin
06:38 PM Feature #1790: implement menu support: Some thoughts:
1. Menus are different from our normal containers like Frames. With menus, the contained widgets c... Greg Shah
06:21 PM Feature #1790: implement menu support: 1. I have simple MENUBAR with sub-menu and menu. It is drawn succesfully. At starting moment sub-menu has focus. When... Vadim Gindin
06:06 PM Feature #1790: implement menu support: If you are stuck, please post specific questions or post more details of the problem so that we can help. Greg Shah
05:45 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Perhaps it makes sense to integrate these changes with your work in #2522 to reduce the amount ... Igor Skornyakov
05:43 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: > And because there will be a separate commit by Constantin I understand a new history entry for the ControlSetEntity... Greg Shah
05:31 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Code Review ias_upd20150310a.zip
>
> I'm fine with the proposed changes, except that the @Cont... Igor Skornyakov
05:29 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150310a.zip
I'm fine with the proposed changes, except that the @ControlSetConfig.java@ needs... Greg Shah
05:24 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Igor Skornyakov wrote:
> Shall I start the regression testing right now?
No, don't put this into testing since Co... Greg Shah
05:21 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Shall I start the regression testing right now? Igor Skornyakov
05:05 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Please take a look at the augmented version of the Constantin's changes (I've the support for the above mentioned sub... Igor Skornyakov
03:27 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Well, it seems that the situation is the following:
If LIST-ITEMS is assigned before the frame containing the widget... Igor Skornyakov
03:12 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: The situation looks strange. If one puts assignments in Constantin's sample not within "on" block (just two consecuti... Igor Skornyakov
02:51 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Constantin,
I agree with your changes. However I've noticed another non-compatibility with 4GL:
With your sample ru... Igor Skornyakov
02:11 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Igor, please review and test this update with your standalone tests. It fixes problems in this code:... Constantin Asofiei
11:03 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: The updated zip is attached. Greg Shah
10:51 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: setListItems() method fixed.
Has passed conversion regression testing and is committed as bzr rev. 10802.
Igor Skornyakov
10:36 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> What is the status of this? Also, please post the updated zip.
Regression test just passed (i... Igor Skornyakov
10:05 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: What is the status of this? Also, please post the updated zip. Greg Shah
05:10 PM Bug #2520: Dynamic list controls are not visible: The updating of @savedWidgets@ doesn't work. Continue the investigation. Igor Skornyakov
06:26 AM Bug #2520: Dynamic list controls are not visible: I see. Thank you Constantin. Igor Skornyakov
06:21 AM Bug #2520: Dynamic list controls are not visible: Igor, see this test:... Constantin Asofiei
05:56 AM Bug #2520: Dynamic list controls are not visible: Constantin,
If I correctly understand your scenario my change retains the 4GL compatibility: after the frame is enab... Igor Skornyakov
05:05 PM Feature #2480: add support for button and image attributes and options: The investigation shows the default button feature works only in GUI mode. The character mode just ignores this attri... Eugenie Lyzenko
11:20 AM Feature #2422: add features to BROWSE: The @QueryWrapper@ changes in 0310a look OK to me. Eric Faulhaber
09:59 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150310a.zip
I'm fine with the changes.
Eric: please review the @QueryWrapper@ change.
B... Greg Shah
05:53 AM Feature #2422: add features to BROWSE: Update for review. Relatively to the previous version of the update (0305a) only @QueryWrapper@ has changed. Stanislav Lomany
05:50 AM Feature #2422: add features to BROWSE: About the recet bug. Here is the code that repositions browse to an invalid id:... Stanislav Lomany

03/09/2015

07:24 PM Feature #2480: add support for button and image attributes and options: @evl_upd20150307a.zip@ has been committed as 10800. Eugenie Lyzenko
06:28 PM Feature #2480: add support for button and image attributes and options: OK, please commit it. Greg Shah
06:13 PM Feature #2480: add support for button and image attributes and options: Conversion testing completed. No difference in generated code. So the update @evl_upd20150307a.zip@ is ready to be co... Eugenie Lyzenko
03:23 PM Feature #2480: add support for button and image attributes and options: The new runtime test results: @10797_5c96d7c_20150309_evl.zip@ for update based on 10797. No regression found.
Sta... Eugenie Lyzenko
06:53 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Please note this text from the Progress docs for @EDITOR Phrase@:... Greg Shah
04:43 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.... Igor Skornyakov
03:33 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> The urgency now is to determine if your Frame.addWidget change does not break any existin... Igor Skornyakov
03:30 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > Yes, don't complicate things for now. Just confirm the ... Constantin Asofiei
03:21 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Yes, don't complicate things for now. Just confirm the implications of your change an... Igor Skornyakov
03:14 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > In any case, this is not currently supported by P2J. Th... Constantin Asofiei
03:10 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> In any case, this is not currently supported by P2J. The APIs are a no-op now.
I s... Igor Skornyakov
02:57 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > As I see from dvref.pdf, AUTO-RESIZE is for GUI only.
>... Constantin Asofiei
02:48 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> As I see from dvref.pdf, AUTO-RESIZE is for GUI only.
I know. However in my tests t... Igor Skornyakov
02:44 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, I think this is part of a larger defect in P2J, relate... Constantin Asofiei
02:39 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.... Igor Skornyakov
02:25 PM Bug #2520: Dynamic list controls are not visible: Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.
Something I think shoul... Constantin Asofiei
10:52 AM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> So, Igor: what issue were you trying to solve? Do you have a standalone test for it?
... Igor Skornyakov
10:35 AM Bug #2520: Dynamic list controls are not visible: Greg Shah wrote:
> Constantin: please review the change (bzr rev 10797). Is the modification safe?
It's hard to tel... Constantin Asofiei
09:12 AM Bug #2520: Dynamic list controls are not visible: Greg Shah wrote:
> Igor: in the future, please do not check anything in before you are explicitly approved to do so.... Igor Skornyakov
09:08 AM Bug #2520: Dynamic list controls are not visible: Igor: in the future, please do not check anything in before you are explicitly approved to do so. Such approval is a... Greg Shah
09:47 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150309a.zip
The change is good. Please add a history entry, post the updated 0309b zip and g... Greg Shah
09:19 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Fixed regression reported by Constantin (see #2408 notes 135/136/137). Restarted regression test Igor Skornyakov
08:54 AM Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...: Greg Shah
09:11 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Have you tested both attributes with both widgets?
The method is the same for both widg... Igor Skornyakov
08:22 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PA... Constantin Asofiei
07:55 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PAIRS are set via the widget a... Igor Skornyakov
07:25 AM Feature #2498: implement ADD-LAST() method: Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PAIRS are set via the widget attribute, as in:... Constantin Asofiei

03/08/2015

05:20 AM Bug #2520: Dynamic list controls are not visible: Has passed conversion regression testing and is committed as bzr rev. 10797. Igor Skornyakov
07:40 PM Feature #2480: add support for button and image attributes and options: The testing completed, no regressions. The results: @10794_5c96d7c_20150307_evl.zip@.
Looks like I have to re-run ... Eugenie Lyzenko

03/07/2015

01:51 PM Feature #2480: add support for button and image attributes and options: Merge with 10796 code base. Eugenie Lyzenko
08:46 PM Feature #2480: add support for button and image attributes and options: The conversion testing completed. Generated codes are identical, no regressions. Starting runtime testing. Eugenie Lyzenko
03:51 AM Bug #2520: Dynamic list controls are not visible: Fixed. Started regression test Igor Skornyakov
03:36 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Passed runtime regression testing and checked in as bzr rev 10796. Igor Skornyakov

03/06/2015

04:46 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can y... Hynek Cihlar
04:15 PM Feature #2480: add support for button and image attributes and options: >I have no objections to this.
OK. I'm starting the conversion and runtime testing. Eugenie Lyzenko
04:01 PM Feature #2480: add support for button and image attributes and options: >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can you trace it down? Also, is... Eugenie Lyzenko
02:20 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> > One consideration about clipping. The feature is now working for button widget but I think it h... Hynek Cihlar
02:05 PM Feature #2480: add support for button and image attributes and options: > One consideration about clipping. The feature is now working for button widget but I think it has an issue. If usin... Greg Shah
02:04 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150306a.zip
I'm fine with the changes. Greg Shah
12:32 PM Feature #2480: add support for button and image attributes and options: This update for review has completed runtime implementation for @NO-FOCUS@/@FLAT-BUTTON@ client part plus fixed newly... Eugenie Lyzenko
03:45 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: After 3 runs the following 2 tests failed (in addition to the expected tc_job_002):... Igor Skornyakov
03:00 PM Feature #1790: implement menu support: Code Review vig_upd20150306a.zip
This is a good step forward.
1. It seems like there should be shared code betw... Greg Shah
02:16 PM Feature #1790: implement menu support: > When I'm pressing '->' in MENUBAR first menu-item (sub-menu) is blended when loosing focus. There are several calls... Greg Shah
10:37 AM Feature #1790: implement menu support: It seems I will not make working version until today. Here is my current update with the following changes.
* Focus ... Vadim Gindin
02:40 PM Feature #2422: add features to BROWSE: One regression test has failed: @P2JQuery.bufferHandle()@ returns invalid handle. Looking into it. Stanislav Lomany
08:46 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150305a.zip
I'm OK with the changes.
Eric: please review the @QueryWrapper@ change. Greg Shah
02:59 AM Feature #2422: add features to BROWSE: Update for review. Fixes minor issues. Stanislav Lomany
11:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LINES runtime setter attribute unknown behavior shoul... Greg Shah
09:38 AM Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah
08:46 AM Bug #2520: Dynamic list controls are not visible: It seems that I've resolved the issue (with one-line fix). Will start regression testing after the one for #2508 will... Igor Skornyakov

03/05/2015

03:50 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150305a.zip
I'm good with the changes. Greg Shah
03:30 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: NPE was a result of my bug. To fix the cursor issue it was sufficient to hide cursor on SELECTION-LIST focus gain (an... Igor Skornyakov
09:02 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: OK, please do fix these as part of this task. Greg Shah
09:00 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Are these bugs specific to your change or are they already existing in P2J?
These bugs are not... Igor Skornyakov
08:57 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Are these bugs specific to your change or are they already existing in P2J? Greg Shah
08:56 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Found at least two bugs.
1. When there are several widgets in a frame the cursor position doesn't change when switch... Igor Skornyakov

03/04/2015

04:26 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: > 1) take big file (much more then limit). And time to load this file will be much bigger then time to read file just... Greg Shah
04:24 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150301a.zip
1. Please name @LogicalTerminal.writeFile()@ as @LogicalTerminal.saveFile()@ to b... Greg Shah
03:58 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: > Also I need to set modified flag. But didn't find good place to do it. Where I can have access to this flag ?
Se... Greg Shah
08:08 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: 1) Added error handling and file stream close
4GL writes data into file till IO error. But for read operation 4gl re... Evgeny Kiselev
03:17 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Merged with revno 10793. Tested. The selection list behavior on gain/loose focus has to be fixed. Igor Skornyakov
11:43 AM Feature #2498 (Closed): implement ADD-LAST() method: Greg Shah
11:08 AM Feature #2498: implement ADD-LAST() method: Passed runtime regression testing and checked in as bzr rev 10793. Igor Skornyakov
11:08 AM Feature #2498: implement ADD-LAST() method: After updating majic_baseline @tc_po_item_003@ and @tc_po_item_004@. Majic rebuild passed OK.
Igor Skornyakov
08:49 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Don't worry about the ctrl-c tests. The 3-way tests are known to fail and so long as all of them... Igor Skornyakov
08:41 AM Feature #2498: implement ADD-LAST() method: Don't worry about the ctrl-c tests. The 3-way tests are known to fail and so long as all of them don't fail on all r... Greg Shah
05:24 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> With rev 10787 there were baseline changes. You should reconfigure your setup or do a ... Igor Skornyakov
05:17 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> @gso_ctrlc_3way_tests@ restarted. I've extracted @tc_po_item_003@ and @tc_po_item_004@ and ... Constantin Asofiei
05:08 AM Feature #2498: implement ADD-LAST() method: In a third run all @gso_ctrlc_3way_tests@ failed. @tc_job_clock_004@ passed. I've also noticed that the following te... Igor Skornyakov
09:33 PM Feature #2480: add support for button and image attributes and options: This update for review contains runtime implementation for @NO-FOCUS@/@FLAT-BUTTON@. It is required to do more testin... Eugenie Lyzenko

03/03/2015

05:18 PM Feature #2498: implement ADD-LAST() method: The following tests failed identically in two runs:... Igor Skornyakov
09:43 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> I think @unwrapControlEntity()@ should be removed from @handle@. Rebuilding MAJIC will confirm... Igor Skornyakov
09:37 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150303c.zip
I think @unwrapControlEntity()@ should be removed from @handle@. Rebuilding MAJI... Greg Shah
07:30 AM Feature #2498: implement ADD-LAST() method: The problem was with @ScrollConatiner.ensureVisibility()@: I've reimplemented it to achieve the correct behavior for ... Igor Skornyakov
02:50 PM Feature #2422: add features to BROWSE: svl_upd20150302a was committed to bzr revision 10792. Stanislav Lomany
02:25 PM Feature #2422: add features to BROWSE: OK, my bad. I misread your post. The last record to the top of the browse IS CORRECT. In this case my update works pr... Stanislav Lomany
01:28 PM Feature #2422: add features to BROWSE: Correct or not, it's what Progress 9.1 did with the AOG Browse screen. It was quite strange. I've never recreated it ... Eric Faulhaber
01:23 PM Feature #2422: add features to BROWSE: Eric, are you sure that scrolling to the last row (and making it the scroll row) is not a correct behavior? Stanislav Lomany
09:50 AM Feature #2422: add features to BROWSE: AOG Browse fails. Reverting the code in AdaptiveQuery doesn't fix the issue. I'll look into that. Stanislav Lomany
09:31 AM Feature #2422: add features to BROWSE: @Cursor@:297 looks a little different to me. Have you confirmed the described behavior with the AOG Browse has not be... Eric Faulhaber
03:47 AM Feature #2422: add features to BROWSE: Eric, in this file there is also updated history entry which says ... Stanislav Lomany
09:29 PM Feature #2422: add features to BROWSE: Greg Shah wrote:
> Code Review svl_upd20150302a.zip
>
> I'm OK with the changes.
>
> Eric: please review the @... Eric Faulhaber

03/02/2015

05:11 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150302a.zip
I'm OK with the changes.
Eric: please review the @AdaptiveQuery@ change. Greg Shah
05:05 PM Feature #2422: add features to BROWSE: Passed regression testing, so I can check it in just after review. Stanislav Lomany
03:47 PM Feature #2422: add features to BROWSE: Update for review with fixes for RFQ tests. Regression testing is running. Stanislav Lomany
04:44 PM Feature #2498: implement ADD-LAST() method: Just a note. If the screen size is ~ 132x43 then the failing screen with and without my changes look identical (manua... Igor Skornyakov
11:21 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Remove your update and manually test again to determine if it is your update that causes this. I... Igor Skornyakov
11:15 AM Feature #2498: implement ADD-LAST() method: Remove your update and manually test again to determine if it is your update that causes this. I guess it is so, unl... Greg Shah
11:14 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Igor, is your terminal set to 80 cols by 24 rows? MAJIC layout will not be correct if th... Igor Skornyakov
11:08 AM Feature #2498: implement ADD-LAST() method: Igor, is your terminal set to 80 cols by 24 rows? MAJIC layout will not be correct if the terminal is not set like this. Constantin Asofiei
11:07 AM Feature #2498: implement ADD-LAST() method: Hynek Cihlar wrote:
> Igor if haven't already, try to run the test manually. That is, start the client, login, and f... Igor Skornyakov
08:34 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> I've added a delay to gso_301 (more presisely, to @common/find_rfq_so_8000356.xml@), but th... Hynek Cihlar
08:27 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Greg Shah wrote:
> > Has anyone seen this kind of failure in the RFQ tests? Could we h... Igor Skornyakov
02:24 PM Feature #2334 (Closed): implement the GUI message line widget: Greg Shah
11:30 AM Bug #2528: finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE: This task is meant to complete the implementation of the INPUT, SCREEN-VALUE and INPUT-VALUE.
Some initial finding... Constantin Asofiei
11:22 AM Bug #2528 (New): finish investigation and implemention of INPUT, SCREEN-VALUE and INPUT-VALUE: Constantin Asofiei
09:20 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Interesting. These sound pretty easy for us to implement.
> maximum stored data depends on @INNER-CHARS@ paramete... Greg Shah
07:11 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: 1) If some IO error while reading/writing, then it read or wrote data can be used, but status of operation will be "n... Evgeny Kiselev

02/27/2015

05:18 PM Feature #2480: add support for button and image attributes and options: The update contains conversion support and runtime start point starting point for @NO-FOCUS@ and @FLAT-BUTTON@ option... Eugenie Lyzenko
02:21 PM Feature #2498: implement ADD-LAST() method: No, let it finish. Greg Shah
01:41 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Igor: do you have any other problems to solve or is this it?
No. I do not have any new problem... Igor Skornyakov
01:37 PM Feature #2498: implement ADD-LAST() method: Igor: do you have any other problems to solve or is this it?
Constantin, Hynek, Eric and I all have quite a few ch... Greg Shah
01:11 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that ha... Constantin Asofiei
01:03 PM Feature #2498: implement ADD-LAST() method: Has anyone seen this kind of failure in the RFQ tests? Could we have checked something in that has broken RFQ? Greg Shah
11:45 AM Feature #2498: implement ADD-LAST() method: Both gsO301 and gso_308 failed at the same screen. As far as I understand the code for this screen is in @syman/so/se... Igor Skornyakov
07:18 AM Feature #2498: implement ADD-LAST() method: After fixes only the following tests failed in two runs:
3 gso_301: failure in step 6: 'timeout before the spec... Igor Skornyakov
07:41 AM Feature #2525: Runtime support of frame positional attributes: The objective of this issue is to implement support of missing parts of frame positional attributes. Also to make sur... Hynek Cihlar
07:23 AM Feature #2525 (New): Runtime support of frame positional attributes: Hynek Cihlar

02/26/2015

04:07 PM Feature #2479 (Closed): DEFINE IMAGE and image phrase support for both button and image: Greg Shah
03:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The update @evl_upd20150225b.zip@ has been committed in bzr as 10780. Eugenie Lyzenko
03:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Yes, please check it in. Greg Shah
03:14 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Testing completed. The results file: @10778_5c96d7c_20150226_evl.zip@.
So the update is ready to be committed and ... Eugenie Lyzenko
11:47 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The main part of the regression tests completed OK. Waiting for CTRL-C to be done. Eugenie Lyzenko
07:48 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The conversion testing completed. Codes are identical, no regression. Continue with the runtime testing. Eugenie Lyzenko
12:25 PM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> After my recent minor changes RFQ tests started to fail. I'm looking into that.
I would... Eric Faulhaber
12:15 PM Feature #2422: add features to BROWSE: After my recent minor changes RFQ tests started to fail. I'm looking into that. Stanislav Lomany
12:09 PM Feature #2422: add features to BROWSE: The persistence changes in 0225a look OK to me. Eric Faulhaber
09:38 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150225a.zip
I'm fine with the changes. I looked at everything pretty carefully, except @Brow... Greg Shah
10:18 AM Feature #1790: implement menu support: Yes, that was the reason.. Sorry for trouble. Vadim Gindin
10:03 AM Feature #1790: implement menu support: Mistake..
Here is the place in @ThinClient.waitFor@ where immedExit is set to true:... Vadim Gindin
09:59 AM Feature #1790: implement menu support: I found that during processing of @ThinClient.waitFor@ the flag @immedExit@ is set to true. It probably a reason.. It... Vadim Gindin
09:51 AM Feature #1790: implement menu support: I'm stuck... I can't make menu events working. I don't fully understand how events queue works. Here are the followin... Vadim Gindin
06:30 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150225a.zip
1. The update should only contain files that were modified for this task. As far... Greg Shah

02/25/2015

03:58 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: > Eugenie: please confirm that it is not needed. If so, please remove it. Then go ahead with both conversion and ru... Eugenie Lyzenko
03:52 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: > the call to @setPhysicalLocation@ in @IGI.initialize@ should be unnecessary as you already set the physical locatio... Greg Shah
03:36 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Greg Shah wrote:
> Code Review evl_upd20150225a.zip
>
> I'm fine with the changes.
>
> Hynek: please look at t... Hynek Cihlar
02:11 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150225a.zip
I'm fine with the changes.
Hynek: please look at the @BaseConfig@ change and c... Greg Shah
12:07 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for review has general fix for dynamic widget location issue. All processing shifted to @BaseConfig.apply... Eugenie Lyzenko
09:33 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Greg Shah wrote:
> Code Review evl_upd20150224a.zip
>
> Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ real... Hynek Cihlar
09:17 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> One more possible TODO change is rework for image phrase setters for button related images ... Greg Shah
09:16 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: One more possible TODO change is rework for image phrase setters for button related images we have discussed previous... Eugenie Lyzenko
09:05 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150224a.zip
Are @ButtonGuiImpl.draw()@ and @ImageGuiImpl.draw()@ really the proper locations ... Greg Shah
08:53 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets... Greg Shah
08:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The only thing I see is to unify @CONVERT-3D-COLORS@ attribute for button and image widgets. Currently button has @NO... Eugenie Lyzenko
03:09 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Finished adding DELIMITER attribute support and fixing LIST-ITEMS and LIST-ITEM-PAIRS logic. Testing is still require... Igor Skornyakov
02:32 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Progress is full of these insane "quirks". In these cases we try to leave careful comments and j... Igor Skornyakov
02:19 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Progress is full of these insane "quirks". In these cases we try to leave careful comments and javadoc to explain th... Greg Shah
02:15 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Are you saying that the 4GL reacts differently in these two situations?
Yes, it does.
> If so... Igor Skornyakov
02:02 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Are you saying that the 4GL reacts differently in these two situations?
Unknown literal:... Greg Shah
12:47 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: I've discovered a strange behavior: for the COMBO-BOX and SELECTION-LIST @ADD-LAST(..., ?)@ is rejected but the code
... Igor Skornyakov
01:58 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge yo... Igor Skornyakov
11:58 AM Feature #2498: implement ADD-LAST() method: OK, this makes sense. As you move forward, do keep in mind that you will likely need to merge your code up to newer ... Greg Shah
11:35 AM Feature #2498: implement ADD-LAST() method: Adding separate height/width fields doesn't help. Starting a detailed investigation. In particular I can see the the ... Igor Skornyakov
09:08 AM Feature #2478 (Closed): button image support: Greg Shah
09:07 AM Feature #2476 (Closed): window icon support improvements: Greg Shah
08:55 AM Feature #2480: add support for button and image attributes and options: The following attributes/options are left to b implemented/verified as working if already implemented:
+Button opt... Eugenie Lyzenko
05:53 AM Feature #2422: add features to BROWSE: Major browse update for review. Changed caching logic in order to match 4GL. Stanislav Lomany

02/24/2015

06:33 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for review merges the recent code base plus fixes the location issue for dynamic images and buttons. The ... Eugenie Lyzenko

02/23/2015

03:08 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: The version on lindev01 is 10.2B and has not been changed since it was installed in early 2013. I access it via /usr... Greg Shah
02:34 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: RADIO-BUTTONS attribute for the RADIO-SET widget behaves like LIST-ITEM-PAIRS for the SELECTION-LIST.
Conclusion:
... Igor Skornyakov
10:38 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: 1. We need to add support for the DELIMITER attribute
2. DELIMITER attribute value cannot be "unknown", but can be "... Igor Skornyakov
02:41 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Although it seems unlikely that the problems are caused by your update, it is very unusual for th... Igor Skornyakov
11:30 AM Feature #2498: implement ADD-LAST() method: Although it seems unlikely that the problems are caused by your update, it is very unusual for the same list of tests... Greg Shah
09:14 AM Feature #2498: implement ADD-LAST() method: Greg,
Can I commit my changes?
Thank you. Igor Skornyakov
01:29 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: > Normally, I would ask you to get these tested, but Igor has overlapping changes being tested in #2498 and he has ha... Eugenie Lyzenko
01:07 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150223a.zip
The changes look good.
Normally, I would ask you to get these tested, but Igor... Greg Shah
12:39 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Sorry the update @0223a@ was inconsistent(has not final versions). Please see the new drop. Eugenie Lyzenko
12:20 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for review adds boolean attributes setters/getters outside of the @DEFINE IMAGE@ or @DEFINE BUTTON@ state... Eugenie Lyzenko
07:19 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The remaining thing I'm going to implement is having getters/setters for all attributes in image and button widgets t... Eugenie Lyzenko
12:02 PM Feature #1790: implement menu support: >> At this point are ChUI menus fully functional?
>
> No. I can't finish client-side part because of event-processi... Greg Shah
10:07 AM Feature #1790: implement menu support: You're right. Some of noted points are not implemented. See below
Greg Shah wrote:
> At this point are ChUI menus... Vadim Gindin

02/22/2015

04:05 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Greg Shah wrote:
> Yes, go ahead and commit it.
Committed in bzr as 10771. Eugenie Lyzenko
03:32 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Yes, go ahead and commit it. Greg Shah
02:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The conversion testing completed, generated codes are identical. No regressions.
So the update is ready to be comm... Eugenie Lyzenko
07:03 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The update fixes the size/location regression for images used to draw the buttons. Plus slightly enhanced icon detect... Eugenie Lyzenko
08:01 AM Feature #2498: implement ADD-LAST() method: Attached detailed reports for failed tests. Igor Skornyakov
05:44 AM Feature #2498: implement ADD-LAST() method: There where 3 runs of the regression test.
The following test failed in in all 3 runs:
gso_tests
57 gso_187: fa... Igor Skornyakov

02/20/2015

06:10 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Here is the next update containing basic GUI implementation.
Questions:
1. When I'm going between checkboxes I've... Vadim Gindin
05:25 PM Feature #2523: implement GUI radio-set widget: The core widget implementation for GUI must be created including drawing and event processing. Mouse support must wo... Greg Shah
05:23 PM Feature #2523 (Closed): implement GUI radio-set widget: Greg Shah
05:22 PM Feature #2522: add attribute/method support for radio-set: Implement conversion and runtime support for the following:
+Attributes+
NUM-BUTTONS
+Methods+
DISABLE()
... Greg Shah
05:21 PM Feature #2522 (Closed): add attribute/method support for radio-set: Greg Shah
05:21 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Please do fix both of these issues (character unit mismatches and the regression for IMAGE-SIZE options) as part of ... Eugenie Lyzenko
05:00 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >Have you run your testcases in both windev01 and in P2J? Does our implementation match exa... Greg Shah
04:59 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: > I've changed the rule file and want to make sure there will be no regression her. Is it OK?
Good point. Yes, c... Greg Shah
04:57 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly?
Yes, I'm comparin... Eugenie Lyzenko
04:41 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the server-... Eugenie Lyzenko
04:34 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Have you run your testcases in both windev01 and in P2J? Does our implementation match exactly? Greg Shah
04:32 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: OK. I don't think this needs full runtime testing. The GUI stuff won't get loaded in MAJIC testing. Even the serve... Greg Shah
04:06 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >1. In Convert3DColorsFilter, are the input colors to be converted really hard coded in the 4GL?
I think so, from ... Eugenie Lyzenko
03:52 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150220a.zip
1. In @Convert3DColorsFilter@, are the input colors to be converted really hard c... Greg Shah
03:40 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This updates for review includes runtime implementation of the @CONVERT-3D-COLORS@ option for image and button widget... Eugenie Lyzenko
02:22 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150219a.zip
It is good. Greg Shah
08:01 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update adds conversion rule change to support @RETAIN-SHAPE@ sub-option and runtime implementation for @STRETCH-... Eugenie Lyzenko
05:20 PM Feature #2521 (Closed): enhance/implement radio-set for GUI: Greg Shah
02:31 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Yes, I think you are right. Please test and fix any issues related to those.
Another thing: please test these bot... Greg Shah
02:26 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: I understand the LIST-ITEM-PAIRS and RADIO-BUTTONS attributes are in the scope of this task as well. Is that correct?
Igor Skornyakov
02:16 PM Feature #1790: implement menu support: At this point are ChUI menus fully functional?
Is there any error handling, event or other missing functionality? ... Greg Shah
01:56 PM Feature #1790: implement menu support: Javadoc fix.
Remaining features needing to be implemented is empty at this moment. Probably some features will be ... Vadim Gindin
01:22 PM Feature #1790: implement menu support: Please post a list of the remaining features needing to be implemented, enhanced and/or bugs needing fixing. You can... Greg Shah
01:21 PM Feature #1790: implement menu support: In your next update, please resolve these:... Greg Shah
01:02 PM Feature #1790: implement menu support: Current update has passed full testing and committed to rev #10766. Vadim Gindin
12:26 PM Feature #1790: implement menu support: OK, you can commit vig_upd20150220a.zip. Greg Shah
12:12 PM Feature #1790: implement menu support: Here is merged current update with the latest revision. Vadim Gindin
12:06 PM Feature #1790: implement menu support: > I suspect that this error is not related with my update. Don't you know why it happens?
We don't know for sure. ... Greg Shah
11:02 AM Feature #1790: implement menu support: I've ran regression testing 3rd time. And the test @tc_codes_employees_20@ has passed. So, we can assume that update ... Vadim Gindin
03:28 AM Feature #1790: implement menu support: Current update has passed conversion testing. I ran regression testing twice. Only one test has failed during both ru... Vadim Gindin
02:00 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150220c.zip
It looks good. Greg Shah
01:50 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr ... Igor Skornyakov
12:47 PM Feature #2498: implement ADD-LAST() method: There is about to be a check in from #1790. When that occurs, please merge up to the latest bzr revision and put tha... Greg Shah
12:42 PM Feature #2498: implement ADD-LAST() method: The following tests failed in both runs:
57 gso_187 GSO 187 - Initial selection on Contact Master returns to main... Igor Skornyakov
12:00 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150220a.zip
The @ScrollDirection@ constructor still needs Javadoc. Obviously, this doesn't i... Greg Shah
11:57 AM Feature #2498: implement ADD-LAST() method: > The ChuiOutputManager sets the value of the cursorInvalid in the at method and doesn't reset it in the append(Strin... Greg Shah
03:57 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Igor: in regard to the scrolling problems, I'd like for you to finish the current task without ad... Igor Skornyakov
03:41 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Please add Keyboard.SE_NEXT_FRAME and Keyboard.SE_PREV_FRAME cases to AbstractWidget.ign... Igor Skornyakov
03:39 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Code Review ias_upd20150219a.zip
>
> 1. In @RadioButtonImpl.draw()@, why iterate through chara... Igor Skornyakov
02:34 AM Feature #2498: implement ADD-LAST() method: About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be deleted) by bo... Constantin Asofiei
02:20 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> 3. After some recent changes (as far as I understand - introducing @manageSystemActions()@ ... Constantin Asofiei
07:39 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150219a.zip
1. In @RadioButtonImpl.draw()@, why iterate through character by character instea... Greg Shah
07:08 PM Feature #2498: implement ADD-LAST() method: Igor: in regard to the scrolling problems, I'd like for you to finish the current task without adding more work to it... Greg Shah
07:03 PM Feature #2498: implement ADD-LAST() method: Constantin: please comment on note 72 and item 3 in note 85. Greg Shah
01:47 PM Bug #2520: Dynamic list controls are not visible: Greg Shah wrote:
> Is this still a problem on bzr rev 10766?
Yes, it is.
Igor Skornyakov
01:38 PM Bug #2520: Dynamic list controls are not visible: Is this still a problem on bzr rev 10766? Greg Shah
01:37 PM Bug #2520: Dynamic list controls are not visible: The dynamic RADIO-SET and COMBO-BOX are not visible, but are "working" - one can make a "blind" selection with the RA... Greg Shah
07:47 AM Bug #2520 (Closed): Dynamic list controls are not visible: Igor Skornyakov
01:40 PM Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets: From CA:
About the NPE in note 73 and the w3.p test. A widget can be determine as no longer alive (thus can be del... Greg Shah
01:40 PM Bug #2518: NPE on exit from testcase with mixed usage of static and dynamic widgets: The attached sample after conversion throws NPE on exit:
[02/17/2015 19:25:51 MSK] (StandardServer.invoke:SEVERE) ... Greg Shah
07:41 AM Bug #2518 (New): NPE on exit from testcase with mixed usage of static and dynamic widgets: Igor Skornyakov
01:39 PM Bug #2519: suspicious looking scrolling code: 1. The @ScrollBar.scroll()@ method looks to contain a typo: in line 253 @limit.x@ seems to be instead of @limit.y@
2... Greg Shah
07:43 AM Bug #2519 (New): suspicious looking scrolling code: Igor Skornyakov
01:36 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150218a.zip
It is a good step.
1. @EditorWidget.read/saveFile(character)@ need @null@ and ... Greg Shah
08:02 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Added runtime support. I'm not finished testing at the moment, but common functionality is working. Evgeny Kiselev
11:25 AM Feature #2422: add features to BROWSE: Technically that's not a browse problem, but because of record retrieval logic browse uses, an editable browse easily... Stanislav Lomany

02/19/2015

11:18 AM Feature #2498: implement ADD-LAST() method: I've finished with scrolling changes. My changes do not affect the @ComboBox@ behavior as this widget doesn't rely on... Igor Skornyakov
09:45 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150218a.zip
It looks good. Greg Shah

02/18/2015

06:06 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: This update for your review adds transparency runtime implementation for image widget. Also it prepares other boolean... Eugenie Lyzenko
05:49 PM Feature #1790: implement menu support: Code Review vig_upd20150219a.zip
I ma OK with the changes. Please get this update conversion and runtime regressi... Greg Shah
05:37 PM Feature #1790: implement menu support: The next update, containing remarks corrections and overrides bug fix Vadim Gindin
04:01 PM Feature #1790: implement menu support: > Don't you remember where that conversion logic?
See the @process_frame@ function in @annotations/frame_scoping.r... Greg Shah
03:46 PM Feature #1790: implement menu support: Greg Shah wrote:
> > Wait a minute. It seems that it is a frames naming (class naming) problem.
>
> This makes se... Vadim Gindin
02:52 PM Feature #1790: implement menu support: > Wait a minute. It seems that it is a frames naming (class naming) problem.
This makes sense. Please put some pr... Greg Shah
02:36 PM Feature #1790: implement menu support: Greg Shah wrote:
> In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default... Vadim Gindin
02:21 PM Feature #1790: implement menu support: In the 4GL I suspect that your @DISPLAY@ statements in the triggers are targeting the the default "unnamed" frame. S... Greg Shah
02:00 PM Feature #1790: implement menu support: I'm debugging difficult bug:... Vadim Gindin
05:41 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Is there a bug in our implementation of the 4GL built-in function @SEARCH()@ that makes it work differently with file... Greg Shah
05:38 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Greg Shah wrote:
> I don't think you need to do anything like that. The client-side code would call @FileSystemDaem... Evgeny Kiselev
05:34 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: I don't think you need to do anything like that. The client-side code would call @FileSystemDaemon.searchPath()@, wh... Greg Shah
05:31 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Can you suggest what is common "looking" directories in 4gl ? at least common work dir I can take from @Configuration... Evgeny Kiselev
07:07 AM Feature #2498: implement ADD-LAST() method: Hynek Cihlar wrote:
> I think it won't hurt if you start fixing the immediate pains - the unclear model of scroll ... Igor Skornyakov
07:04 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> I'm not sure that I understand this completely. However it seems that it means that a widge... Hynek Cihlar
05:03 AM Feature #2498: implement ADD-LAST() method: Hynek Cihlar wrote:
> Personally I would rather see the scroll event initiated by the widget receiving focus itsel... Igor Skornyakov

02/17/2015

04:28 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see. May I make a suggestion?
> > First of all I think that it is ... Hynek Cihlar
04:12 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... Hynek Cihlar
04:07 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> I see. May I make a suggestion?
> First of all I think that it is important for the scroll... Greg Shah
02:29 PM Feature #2498: implement ADD-LAST() method: I see. May I make a suggestion?
First of all I think that it is important for the scroll to be well-defined and idemp... Igor Skornyakov
02:03 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Please provide more specifics about what needs to be different.
... Greg Shah
12:59 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Please provide more specifics about what needs to be different.
Well, first of all the whole... Igor Skornyakov
12:42 PM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> Generally, no it is not OK.
>
> I do see that @RadioButtonImpl.drawButton()@ does not honor th... Igor Skornyakov
12:40 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4... Greg Shah
12:34 PM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suita... Greg Shah
12:33 PM Feature #2498: implement ADD-LAST() method: In regard to the NPE, I don't understand why we would be pushing screen definitions to the client during the processi... Greg Shah
11:57 AM Feature #2498: implement ADD-LAST() method: Another note. The look of the RadioSet widget at runtime is different in 4GL and Java: in 4GL the focused item is hig... Igor Skornyakov
11:34 AM Feature #2498: implement ADD-LAST() method: It seems that the @ScrollContainer.ensureVisibility()@ method's implementation is not suitable for at least a @RadioS... Igor Skornyakov
11:29 AM Feature #2498: implement ADD-LAST() method: The sample code is a result of my test evolution - I've added more code while investigating the widget behavior. Plea... Igor Skornyakov
10:02 AM Feature #2498: implement ADD-LAST() method: The code seems very complicated, with many more frames than I would have expected to be used or needed. Did you get ... Greg Shah
04:13 AM Feature #2498: implement ADD-LAST() method: Greg Shah wrote:
> 3. About the NPE in @LogicalTerminal.pushScreenDefinition()@, can you show the 4GL code that can ... Igor Skornyakov
10:44 PM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150216a.zip
1. The @RadioSetInterface@ header should be above the import and package statemen... Greg Shah
08:55 AM Feature #2412: Implement widget browser: Code Review hc_upd20150217b.zip
It looks good. Please check it in. Greg Shah
04:54 AM Feature #2412: Implement widget browser: Missing history entry added and converted tabs to spaces in the whole PropertyTable.java. build.xml removed as this s... Hynek Cihlar
10:48 PM Feature #2412: Implement widget browser: Code Review hc_upd20150217a.zip
1. @PropertyTable@ needs a history entry. It also needs all of its hard-tab chars... Greg Shah
08:15 PM Feature #2412: Implement widget browser: The attached update extends Widget browser with the possibility to copy widget properties to clipboard. This is usefu... Hynek Cihlar
02:06 AM Feature #2422: add features to BROWSE: > > But I can handle browsing part because BrowseColumnWidget.setDColor(Color) does the job.
>
> I don't understan... Stanislav Lomany
10:31 PM Feature #2422: add features to BROWSE: > while BrowseColumnWidget.setDColor(NumberType) doesn't actually set a color because ColorSpec.convert() always retu... Greg Shah

02/16/2015

03:49 PM Feature #2498: implement ADD-LAST() method: Added support for the HORIZONTAL and EXPAND attributes. Still need to fix scrolling behavior. Igor Skornyakov
03:32 PM Feature #2422: add features to BROWSE: FYI, Majic alters browse column "colors" in two places. E.g.:... Stanislav Lomany
09:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Committed in bzr as 10757. Eugenie Lyzenko
09:38 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Check it in. Greg Shah
08:51 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The runtime testing completed without regressions(separate run for CTRL-C 3 way tests). The results are in @10754_5c9... Eugenie Lyzenko

02/13/2015

12:38 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Greg Shah wrote:
> Code Review evl_upd20150212b.zip
>
> It looks good, get it both conversion and runtime regress... Eugenie Lyzenko
09:22 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150212b.zip
It looks good, get it both conversion and runtime regression tested. Greg Shah
10:53 AM Feature #1790: implement menu support: Code Review vig_upd20150210a.zip
This is very close.
1. There is a build directory included in your update zip ... Greg Shah
09:55 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150212a.zip
It is very good. Some minor things:
1. Add @RadioSetInterface@ to @HandleComm... Greg Shah

02/12/2015

04:42 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: OK. This update for review changes row/column offsets to double and adjust client side to use new double data. Eugenie Lyzenko
04:10 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that ... Greg Shah
12:02 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Instead of having 3 sets of setters, you could have 1 set and generate an enum value that distinguishes between @But... Eugenie Lyzenko
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >Is there anything left to do for this task?
>
> The following options need to be implem... Greg Shah
07:24 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150212a.zip
1. All row/col values need to be decimal/double as well. I should have seen thi... Greg Shah
07:17 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Eugenie Lyzenko wrote:
> >2. Although it is probably OK, I find it confusing that the image phrase generates differe... Greg Shah
07:00 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >2. Although it is probably OK, I find it confusing that the image phrase generates different setters for the same op... Eugenie Lyzenko
05:13 AM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: >Is there anything left to do for this task?
The following options need to be implemented:
CONVERT-3D-COLORS
STR... Eugenie Lyzenko
07:53 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: Code Review evl_upd20150211b.zip
This is really good.
1. I suspect the @IMAGE-SIZE@/@IMAGE-SIZE-CHARS@ should b... Greg Shah
03:58 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: That is probably the issue. Try it from the command line. Greg Shah
03:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Done. I've uploaded @vig_server_client.zip@ to @/home/vig@
I use Java configuration in Eclipse. Vadim Gindin
02:51 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Please archive your testcases/simple/server, testcases/simple/client folders and upload them to devsrv01.
How do y... Constantin Asofiei
02:48 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Thanks. I tried it and got the error:
> > [...]
> Are you usi... Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: @display "This"@ behaves as the first test: window 1x1 in the left top corner. Vadim Gindin
02:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Thanks. I tried it and got the error:
> [...]
Are you using the latest P2J rev? Note that t... Constantin Asofiei
01:42 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Thanks. I tried it and got the error:... Vadim Gindin
08:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> I didn't find any peculiarities. Here is the test:
>
> [...]
Have you added basic runtime ... Constantin Asofiei
06:58 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I faced with the following difficulty: running application window (GUI) has the size 1x1 and position in the first pi... Vadim Gindin
03:19 PM Feature #2498: implement ADD-LAST() method: 1. fixed the issues you've mentioned by Greg.
2. Added server-side support for HORIZONTAL and EXPAND attributes. Cli... Igor Skornyakov
08:20 AM Feature #2498: implement ADD-LAST() method: Code Review ias_upd20150211b.zip
1. This code in @CommonWidget@ is incorrect:... Greg Shah

02/11/2015

04:40 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The second update for today has small fixes for image widget bugs/regressions. I guess now if there are no objections... Eugenie Lyzenko
01:15 PM Feature #2479: DEFINE IMAGE and image phrase support for both button and image: The update for review includes candidate for image phrase handling for button widget. Need the tests to not getting r... Eugenie Lyzenko
04:05 PM Feature #2498: implement ADD-LAST() method: 1. The converted code with horizontal RADIO-SET behaves very different from the 4GL. In particular the EXPAND flag is... Igor Skornyakov
07:14 AM Feature #2498: implement ADD-LAST() method: Finished refactoring and adding new attributes/methods support. Now I should check the behavior of RADIO-SET runtime ... Igor Skornyakov
12:41 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I didn't find any peculiarities. Here is the test:... Vadim Gindin

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

03/13/2015

03/12/2015

03/11/2015

03/10/2015

03/09/2015

03/08/2015

03/07/2015

03/06/2015

03/05/2015

03/04/2015

03/03/2015

03/02/2015

02/27/2015

02/26/2015

02/25/2015

02/24/2015

02/23/2015

02/22/2015

02/20/2015

02/19/2015

02/18/2015

02/17/2015

02/16/2015

02/13/2015

02/12/2015

02/11/2015