Activity

From 03/05/2015 to 04/03/2015

04/03/2015

04:50 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150403a.zip
The changes to @TC.processProgressEvent()@ seem reasonable.
I'm still concerne... Greg Shah
02:52 PM Feature #2480: add support for button and image attributes and options: This update for review has fix for mouse related triggers/exit events. The idea is:
1. In @TC.waitForEvent()@ we lea... Eugenie Lyzenko
11:21 AM Feature #2480: add support for button and image attributes and options: >I think you have found some important things here, but the approach is not correct.
>
>The triggers won't fire bec... Eugenie Lyzenko
08:48 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150402a.zip
I think you have found some important things here, but the approach is not correc... Greg Shah
09:50 PM Feature #2480: add support for button and image attributes and options: The update is the next step fixing client side key loop by 4GL mouse event unlocking. Now the mouse press/click trigg... Eugenie Lyzenko
12:55 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150403a.zip
I'm good with the changes. Greg Shah
10:29 AM Feature #2422: add features to BROWSE: Update for review. DELETE-* functions has been optimized, refresh after deletion of multiple rows has been implemente... Stanislav Lomany

04/02/2015

01:57 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> I think you need to split the sub-menu and its body into separate widgets. Check how the... Vadim Gindin
11:40 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Hiding sub-menu body doesn't mean hiding sub-menu itself. Sub-menu body is not a separate widg... Constantin Asofiei
11:26 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > *The question about sub-menu width.*
> > Constantin, you wrot... Vadim Gindin
11:12 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > *Strange behavior for MENU-DROP event.*
> > This event is sent... Vadim Gindin
06:06 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> *The question about sub-menu width.*
> Constantin, you wrote, that I should set dimension fi... Constantin Asofiei
06:00 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> *Strange behavior for MENU-DROP event.*
> This event is sent when sub-menu (or pop-up menu) i... Constantin Asofiei
03:42 AM Feature #1790: implement menu support: *The question about sub-menu width.*
Constantin, you wrote, that I should set dimension field @AbstractContainer.si... Vadim Gindin
03:12 AM Feature #1790: implement menu support: *Strange behavior for MENU-DROP event.*
This event is sent when sub-menu (or pop-up menu) is dropped down. I've wrot... Vadim Gindin
09:53 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150401a.zip
This is a substantial improvement!
Fix the remaining event processing and I th... Greg Shah
08:07 AM Feature #2480: add support for button and image attributes and options: Constantin Asofiei wrote:
> I'm good with the changes. Are the tests in note 86 now working properly?
No, the fi... Eugenie Lyzenko
06:45 AM Feature #2480: add support for button and image attributes and options: I'm good with the changes. Are the tests in note 86 now working properly? Constantin Asofiei
05:57 AM Feature #2422: add features to BROWSE: Greg Shah wrote:
> Constantin: please review the use of @ThinClient.invokeTriggers()@ in @Browse@ in this update.
I... Constantin Asofiei

04/01/2015

06:46 PM Feature #2480: add support for button and image attributes and options: This update for review present new approach for @GO@/@CHOOSE@ issue resolution. The idea is to include mouse clicks i... Eugenie Lyzenko
02:07 PM Feature #2422: add features to BROWSE: Greg Shah wrote:
> Eric: please review the query changes.
The query changes look fine. Eric Faulhaber
11:28 AM Feature #2422: add features to BROWSE: > 1. @BrowseWidget.deleteSelectedRow(integer)@ and @BrowseWidget.deleteCurrentRow()@ may need to be optimized to only... Stanislav Lomany
10:21 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150401a.zip
Constantin: please review the use of @ThinClient.invokeTriggers()@ in @Browse@ in... Greg Shah
09:09 AM Bug #2477: button remains pressed when it should not: Code Review evl_upd20150331a.zip
I'm good with the solution. Please include it in your next update for #2480. Greg Shah
08:09 PM Bug #2477: button remains pressed when it should not: The root cause I think is the fact when drag event occurs on GUI button the button itself does not get the mouse exit... Eugenie Lyzenko
08:27 AM Bug #2452: Button label resize fails with error 4054: Eugenie, I'm bit delayed. I am expecting the work to be finished sometime at the end of the week. Hynek Cihlar

03/31/2015

07:46 PM Feature #2422: add features to BROWSE: Update for review. Added DELETE-* functions, SCREEN-VALUE for browse columns and ROW-LEAVE triggers. Stanislav Lomany
05:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150331a.zip
The code looks good. The only (minor) issue is see is that @Editor.setCursorChar... Greg Shah
05:02 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @INNER-LINES runtime setter attribute unknown behavior should be implemented editor
BOX attribute conversion support... Igor Skornyakov

03/30/2015

02:53 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Greg,
> I suggest to leave setCursor* as now - this will be more efficient then to send th... Greg Shah
02:26 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg,
I suggest to leave setCursor* as now - this will be more efficient then to send the entire config. In addition... Igor Skornyakov
02:18 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: >
> I believe that the @config.*@ values are already being edited for every content change.
>
> Those changes au... Igor Skornyakov
02:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > Both getCursor* (except getLine) and setCursor* methods' implementation depends on the content - this is why I deci... Greg Shah
01:40 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Code Review ias_upd20150327a.zip
>
> 1. Please change @BoxedWidget@ to @BoxInterface@. Please... Igor Skornyakov
01:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150327a.zip
1. Please change @BoxedWidget@ to @BoxInterface@. Please also change @is/setBoxe... Greg Shah
12:40 PM Feature #1790: implement menu support: If you are using the testcase from note 243, then I wonder if a @CHOOSE@ event is (accidentally?) being raised for @m... Greg Shah

03/29/2015

12:55 PM Feature #1790: implement menu support: I'm working on unexpected end error:
Constantin Asofiei wrote:
..
> > 2. During menu-items traversal at some mom... Vadim Gindin

03/28/2015

12:33 PM Feature #2487 (Closed): implement READ-FILE() and SAVE-FILE() methods in the editor widget: Greg Shah
08:45 PM Feature #2480: add support for button and image attributes and options: >What about this: let the TC.pause and TC.readkey call TC.waitForEvent with some parameter to wait only for key event... Eugenie Lyzenko

03/27/2015

04:55 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> I think we need to make mouse events(at least press/release) to be returned from @TypeAhead... Constantin Asofiei
09:44 AM Feature #2480: add support for button and image attributes and options: > Or for property reasons we can not use images from commercial 4GL product and have to create our own versions?
... Eugenie Lyzenko
09:43 AM Feature #2480: add support for button and image attributes and options: There is one thing I've recently found related to button widget. In Windows 4GL there are 4 prepackaged images to be ... Eugenie Lyzenko
10:46 PM Feature #2480: add support for button and image attributes and options: >This is another reason why I think is better to try to find a generic solution for this BUTTON/CHOOSE/GO problem now... Eugenie Lyzenko
04:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @DELETE-LINE return false compatibility testing and fixes as needed@
Looks OK
@MAX-CHARS runtime - docs say this... Igor Skornyakov
01:36 PM Bug #2452: Button label resize fails with error 4054: Eugenie Lyzenko wrote:
> > Eugenie, I suggest you wait with this until I finish my in-progress changes. I am modif... Hynek Cihlar
01:18 PM Bug #2452: Button label resize fails with error 4054: Hynek Cihlar wrote:
> Indeed, the original description doesn't seem to be correct. Still there are differences betwe... Eugenie Lyzenko
12:48 PM Bug #2452: Button label resize fails with error 4054: Indeed, the original description doesn't seem to be correct. Still there are differences between 4GL and P2J - 4GL gi... Hynek Cihlar
12:09 PM Bug #2452: Button label resize fails with error 4054: Hynek, I need your comments.... Eugenie Lyzenko

03/26/2015

05:34 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> The reason is the same - we are in @TC.waitForEvent@ waiting for the real key pressing from... Constantin Asofiei
04:51 PM Feature #2480: add support for button and image attributes and options: >Please post a test which shows this difference. And I mean difference in ChUI/GUI behavior in 4GL, not P2J, because ... Eugenie Lyzenko
03:41 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> We need to:
> 1. Preserve natural 4GL event sequence. We can not postpone some events beca... Constantin Asofiei
01:56 PM Feature #2480: add support for button and image attributes and options: >What I think we need is a way to capture this additional event (the CHOOSE event for BUTTON, correct?), and let it p... Eugenie Lyzenko
01:22 PM Feature #2480: add support for button and image attributes and options: >Eugenie, about the EventManager.postOSEvent and when mouse is used to click the button. From what I can tell, past t... Eugenie Lyzenko
12:55 PM Feature #2480: add support for button and image attributes and options: >2. Does that focus shift cause LEAVE and ENTRY events to occur?
Yes, @LEAVE@ for button loosing focus and @ENTRY@ f... Eugenie Lyzenko
12:28 PM Feature #2480: add support for button and image attributes and options: Eugenie, about the @EventManager.postOSEvent@ and when mouse is used to click the button. From what I can tell, past... Constantin Asofiei
10:36 AM Feature #2480: add support for button and image attributes and options: >1. Does clicking on a mouse button in the 4GL shift focus to that button?
Yes if button's @NO-FOCUS@ is false.
>... Eugenie Lyzenko
10:21 AM Feature #2480: add support for button and image attributes and options: >Shouldn't clicking on a button cause that button to receive focus? That focus change should probably occur before an... Eugenie Lyzenko
09:51 AM Feature #2480: add support for button and image attributes and options: These are some good points.
> The significant event we need to react can came from widget currently not having the... Greg Shah
09:42 AM Feature #2480: add support for button and image attributes and options: >This is significantly better than before. But it still uses the OSEvent mechanism for something that it wasn't origi... Eugenie Lyzenko
09:17 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150326a.zip
This is significantly better than before. But it still uses the OSEvent mechanis... Greg Shah
09:06 AM Feature #2480: add support for button and image attributes and options: This update for review fixes the previous notes.
- @applyWorker()@ in @waitForWorker()@ is now free from condition.
... Eugenie Lyzenko
03:59 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Now I'm working on the next focus error. In sub-menu "Submenu" focus is drawn incorrectly: whe... Constantin Asofiei
03:33 PM Feature #1790: implement menu support: My current update Vadim Gindin
12:54 PM Feature #1790: implement menu support: Constantin, thank you for help!
Yesterday I fixed nested sub-menu drawing. Now It is shown, but also with an error... Vadim Gindin
09:43 AM Feature #2422: add features to BROWSE: A bug not related to browse which affect reproduction of the "... There are no selected rows" quirk.
Testcase:
<pre... Stanislav Lomany
09:22 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150326a.zip
I'm OK with the merge. Please check it in and distribute it. Greg Shah
09:06 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: merged with latest revision Evgeny Kiselev

03/25/2015

05:56 PM Feature #2480: add support for button and image attributes and options: >...I don't like using the @EventManager$WorkArea.osEvent@ queue with other non-mouse or non-window events. This queu... Eugenie Lyzenko
05:45 PM Feature #2480: add support for button and image attributes and options: >1. This code needs to be merged with the latest bzr level.
It was synced yesterday with 10821.
>2. Why did you a... Eugenie Lyzenko
05:40 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Constantin: please review.
Eugenie, beside what Greg noted, I don't like using the @EventManager... Constantin Asofiei
05:03 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150325a.zip
1. This code needs to be merged with the latest bzr level.
2. Why did you add ... Greg Shah
04:34 PM Feature #2480: add support for button and image attributes and options: This update for review has fix for wait-for loop "exit" button without endkey option issue. The idea is to propagate ... Eugenie Lyzenko
02:42 PM Feature #2480: add support for button and image attributes and options: Investigation results for case when both @AUTO-ENDKEY@ and @AUTO-GO@ options are true for same button:
1. define b... Eugenie Lyzenko
08:35 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150324a.zip
I'm OK with this approach.
> The loop is releasing only after pressing any key... Greg Shah
09:34 PM Feature #2480: add support for button and image attributes and options: This update for review has different approach for @GO@ issue fix. Now mouse click causes @CHOOSE@ event to be generat... Eugenie Lyzenko
02:12 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> This variant also don't work. @WidgetBrowserAspect.onWidgetDrawn@ is not called at all. I didn... Constantin Asofiei
02:11 PM Feature #1790: implement menu support: This variant also don't work. @WidgetBrowserAspect.onWidgetDrawn@ is not called at all. I didn't find something about... Vadim Gindin
01:19 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> I've tried to add JVM option "-Dwidgetbrowser", but @WidgetBrowser@ wasn't show. I suspect tha... Constantin Asofiei
01:06 PM Feature #1790: implement menu support: I've tried to add JVM option "-Dwidgetbrowser", but @WidgetBrowser@ wasn't show. I suspect that @WidgetBrowserAspect@... Vadim Gindin
11:57 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Actually, you will have to merge up to the 10821 level. Just do the merge and then upload the zip file. I will revi... Greg Shah
08:27 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Great! Please commit it and distribute. Greg Shah
08:16 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: update evk_upd20150317 has been passed regression and conversion testing. Evgeny Kiselev

03/24/2015

03:21 PM Feature #2252: implement GUI client support: Hynek, about your 0323a.zip: you have some ambiguities with the @config()@ method, one defined at Widget and the othe... Constantin Asofiei
02:17 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review ca_upd20150324a.zip
>
> I good with it. Please check it in.
Committed revision ... Constantin Asofiei
02:07 PM Feature #2252: implement GUI client support: Code Review ca_upd20150324a.zip
I good with it. Please check it in. Greg Shah
01:48 PM Feature #2252: implement GUI client support: This is replacement of 0323b.zip - it has passed conversion and runtime testing.
> Does this change the scoping lo... Constantin Asofiei
12:14 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> If this is just rounding and there... Hynek Cihlar
10:33 AM Feature #2252: implement GUI client support: > Yes, FORM needs to let the frame's scope expand. See this example where the frame is scoped to the REPEAT:
Does ... Greg Shah
10:32 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, about your 0318a.zip changes: can you think of a way to ... Constantin Asofiei
10:18 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review ca_upd20150323b.zip
>
> 1. Does your @frame_scoping.rules@ change cause a frame's ... Constantin Asofiei
06:21 AM Feature #2252: implement GUI client support: Btw., what was the motivation behind the @BaseConfig@ dynamic getters/setters? Were these introduced only to provide ... Hynek Cihlar
09:09 PM Feature #2252: implement GUI client support: Constantin, here is an update to 0318a.zip. I have added the config processing to server-side widgets as well. For th... Hynek Cihlar
02:06 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> *So my problem with z-order is stayed unsolved. Could you advice me something?*
Please use th... Constantin Asofiei
10:49 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> - draw: why are you raising a PaintEvent there? When draw() is called, is too late to ca... Vadim Gindin
11:18 PM Feature #2480: add support for button and image attributes and options: I've tested to use another event to unlock the update statement(CHOOSE from GUI button). It works but causes another ... Eugenie Lyzenko

03/23/2015

07:39 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek, about your 0318a.zip changes: can you think of a way to get rid of the setters/ge... Hynek Cihlar
07:25 PM Feature #2252: implement GUI client support: Code Review ca_upd20150323b.zip
1. Does your @frame_scoping.rules@ change cause a frame's scope to expand or other... Greg Shah
05:59 PM Feature #2252: implement GUI client support: Greg, this is for the TEXT/FILL-IN drawing in GUI (#2451): it fixes the widget height/width and also adds a first pas... Constantin Asofiei
05:57 PM Feature #2252: implement GUI client support: Hynek, about your 0318a.zip changes: can you think of a way to get rid of the setters/getters from the WidgetConfig h... Constantin Asofiei
03:37 PM Feature #2480: add support for button and image attributes and options: > Key doubling is still here(if source is keyboard, not mouse). This needs additional investigation because it is out... Greg Shah
03:33 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Code Review evl_upd20150320b.zip
>
> 1. @getAuto*Key()@ should be @isAuto*Key()@.
>
OK. D... Eugenie Lyzenko
12:21 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150320b.zip
1. @getAuto*Key()@ should be @isAuto*Key()@.
2. In @ThinClient.waitForEvent()@... Greg Shah
02:46 PM Feature #1790: implement menu support: Vadim, about your update:
SubMenuChuiImpl
- draw: why are you raising a PaintEvent there? When draw() is called, is... Constantin Asofiei
01:17 PM Feature #1790: implement menu support: The current update Vadim Gindin
09:46 AM Feature #1790: implement menu support: I have z-order difficulty and need your advice. I have 2 nested sub-menus:... Vadim Gindin
09:05 AM Feature #2422: add features to BROWSE: We can't just let all these quirks wait until later. Both issues (in 108 and 109) seem like somewhat normal behavior... Greg Shah

03/22/2015

03:59 PM Feature #2422: add features to BROWSE: Addition to the previous note. For multiple selection (ChUI and GUI) the message ("... There are no selected rows") i... Stanislav Lomany

03/20/2015

06:46 PM Feature #2422: add features to BROWSE: There is a quirk specific to single-selection browse in ChUI: if the current row cannot be fetched, it cannot be dele... Stanislav Lomany
05:26 PM Feature #2480: add support for button and image attributes and options: Merge with recent code base. Eugenie Lyzenko
02:59 PM Feature #2480: add support for button and image attributes and options: This update for review contains the fix for @GO@ event issue. Finally I have found the solution. The idea is any @GO@... Eugenie Lyzenko
01:15 PM Feature #2480: add support for button and image attributes and options: > I thought during the update statement we have TC.waitForEvent() and processEventsWorker() both active for incoming ... Greg Shah
12:33 PM Feature #2480: add support for button and image attributes and options: >I don't understand what you mean here. There is no 2nd loop. @TC.waitForEvent()@ can only be called by @TC.readKey()... Eugenie Lyzenko
08:34 AM Feature #2480: add support for button and image attributes and options: > Further investigation shows another strange behavior in considered testcases. Pressing @AUTO-GO@ button does not co... Greg Shah
10:00 PM Feature #2480: add support for button and image attributes and options: Further investigation shows another strange behavior in considered testcases. Pressing @AUTO-GO@ button does not comm... Eugenie Lyzenko

03/19/2015

02:01 PM Feature #2480: add support for button and image attributes and options: >I don't understand what you mean by "But the GO event is not explicitly registered for event list".
I mean the tr... Eugenie Lyzenko
01:32 PM Feature #2480: add support for button and image attributes and options: > Moreover the @fill-in@ commit is happening only after @GO@ from second sequence. I suggest the widget validation in... Greg Shah
01:15 PM Feature #2480: add support for button and image attributes and options: >Is this code @EventManager.postEvent(new KeyInput(this, EventType.KEY_TYPED, Key.VK_ENTER));@ responsible for the do... Eugenie Lyzenko
12:50 PM Feature #2480: add support for button and image attributes and options: >> Note for a keyboard source we have 2 set of the same events and it is a bit weird.
>
> Yes, I'm pretty sure its ... Greg Shah
12:13 PM Feature #2480: add support for button and image attributes and options: Looks like the events are:... Eugenie Lyzenko
08:54 AM Feature #2480: add support for button and image attributes and options: Please post the 4GL sequence of events for (chui, enter key), (gui, enter key), (chui, mouse click), (gui, mouse clic... Greg Shah
09:39 PM Feature #2480: add support for button and image attributes and options: Some debugging results:
1. Pressing on button the ENTER key and clicking by mouse gives very different results:
The... Eugenie Lyzenko
08:46 PM Feature #2422: add features to BROWSE: OK, I'm fine with the current proposal. Greg Shah
08:03 PM Feature #2252: implement GUI client support: The attached update is a preview of business logic cleanup from config classes. There are some missing pieces - espec... Hynek Cihlar

03/18/2015

05:59 PM Feature #2422: add features to BROWSE: > Do all of our client-side browse column widgets have a server-side @BrowseColumnWidget@ associated with the same ID... Stanislav Lomany
04:20 PM Feature #2422: add features to BROWSE: > In order to get screen vales I've added the code which adds column values into a screen buffer (@ThinClient.getScre... Greg Shah
10:51 AM Feature #2422: add features to BROWSE: In order to get screen vales I've added the code which adds column values into a screen buffer (@ThinClient.getScreen... Stanislav Lomany
12:03 PM Feature #1790: implement menu support: It looks like the @Iterables.direct|reverseFrom()@ code doesn't implement the "cyclic" nature of looping back around ... Greg Shah
11:50 AM Feature #1790: implement menu support: > I thought that it looks strange. Ok, lets consider, if we can't change focus - just leave it as it was, why should ... Greg Shah
11:45 AM Feature #1790: implement menu support: I've checked simplified @focusWorker@ method and it works (NPE is gone). Is it ok? Vadim Gindin
11:34 AM Feature #1790: implement menu support: Greg Shah wrote:
> Also, I do wonder if the menus should be considered part of the content pane of the window or if ... Constantin Asofiei
11:29 AM Feature #1790: implement menu support: Here it is:... Vadim Gindin
11:20 AM Feature #1790: implement menu support: Please post the test you used to get the NPE. Constantin Asofiei
11:04 AM Feature #1790: implement menu support: Here is my current update. Vadim Gindin
06:36 AM Feature #1790: implement menu support: > I don't understand why it is needed: reset current to null especially for Window. As a result: Window.focusWorker(t... Greg Shah
04:43 AM Feature #1790: implement menu support: I faced with NPE:... Vadim Gindin
10:22 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150317a.zip
It looks good.
Please put it into conversion and runtime regression testing. Greg Shah
09:14 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: fixes from note 21 review Evgeny Kiselev

03/17/2015

06:21 PM Feature #1794: implement font support: Greg Shah wrote:
> Please check it in.
Committed revision 10814. Constantin Asofiei
06:16 PM Feature #1794: implement font support: Please check it in. Greg Shah
06:06 PM Feature #1794: implement font support: Greg Shah wrote:
> Perfect. After you make that one tweek, please do get this regression tested.
Attached version ... Constantin Asofiei
11:28 AM Feature #1794: implement font support: Perfect. After you make that one tweek, please do get this regression tested. Greg Shah
11:26 AM Feature #1794: implement font support: Greg Shah wrote:
> >> 3. Do we need to check with Guy to confirm that the windev01 font setup is the same as the Pro... Constantin Asofiei
11:25 AM Feature #1794: implement font support: >> 3. Do we need to check with Guy to confirm that the windev01 font setup is the same as the Progress default font s... Greg Shah
11:22 AM Feature #1794: implement font support: Greg Shah wrote:
> 1. As far as I can tell, the use of the 4GL is not really needed for what you are doing in @get-... Constantin Asofiei
11:15 AM Feature #1794: implement font support: Code Review ca_upd20150317b.zip
The update looks very good.
1. As far as I can tell, the use of the 4GL is not ... Greg Shah
10:34 AM Feature #1794: implement font support: Added a hard-coded standard font table plus other misc fixes/enhancements related to font management. Constantin Asofiei
04:29 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Great! Commit it.
Committed to rev 10813. Will be distributed shortly. Eugenie Lyzenko
04:02 PM Feature #2480: add support for button and image attributes and options: Great! Commit it. Greg Shah
03:33 PM Feature #2480: add support for button and image attributes and options: The runtime testing completed for @evl_upd20150316a.zip@, CTRL-C 3-way tests was started in separate session. No regr... Eugenie Lyzenko
01:09 PM Feature #2480: add support for button and image attributes and options: > Do we need to investigate/fix this deviation in this task?
Yes, this should be fixed. Greg Shah
11:29 AM Feature #2480: add support for button and image attributes and options: >You've also tested both the GO and ENDKEY triggers and they work properly?
@ENDKEY@ works OK. But I have made one... Eugenie Lyzenko
10:03 AM Feature #2480: add support for button and image attributes and options: You've also tested both the GO and ENDKEY triggers and they work properly?
Is evl_upd20150316b.zip the final update? Greg Shah
10:01 AM Feature #2480: add support for button and image attributes and options: >Yes, it is a good idea to to add an inner loop with a @ON ENDKEY undo, leave@ clause. Make sure that nothing execute... Eugenie Lyzenko
09:04 AM Feature #2480: add support for button and image attributes and options: >Are you using triggers for these tests (e.g. for the ENDKEY case, does your test have a trigger for the ENDKEY event... Eugenie Lyzenko
11:03 PM Feature #2480: add support for button and image attributes and options: > When the ENDKEY capable button is pressed, the test terminates meaning the main loop block is closing. Is this what... Greg Shah
09:14 PM Feature #2480: add support for button and image attributes and options: >Please do test the additional cases like GO/ENDKEY triggers and make sure that in the case of @AUTO-ENDKEY@, that th... Eugenie Lyzenko
09:01 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150316b.zip
I'm good with the changes.
Please do test the additional cases like GO/ENDKEY ... Greg Shah
08:38 PM Feature #2480: add support for button and image attributes and options: Conversion testing for @evl_upd20150316a.zip@ has been completed. Generated codes are identical. Continue with runtim... Eugenie Lyzenko
08:05 PM Feature #2480: add support for button and image attributes and options: The update for review presents conversion support for @AUTO-GO@ and @AUTO-ENDKEY@ attributes. Including dynamic handl... Eugenie Lyzenko

03/16/2015

03:48 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150316a.zip
I'm fine with this. Please get it regression tested. Greg Shah
03:26 PM Feature #2480: add support for button and image attributes and options: This update for review fixes the issue with image based button when @DEFAULT@ attribute is set to true but frame's @D... Eugenie Lyzenko
02:50 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> I see two things that are confusing to me:
>
> 1. Setting @my-button:default-button = true@ do... Eugenie Lyzenko
02:17 PM Feature #2480: add support for button and image attributes and options: I see two things that are confusing to me:
1. Setting @my-button:default-button = true@ does not set that button's... Greg Shah
02:00 PM Feature #2480: add support for button and image attributes and options: >1. Are the changes to @ButtonGuiImpl@ really correct for the full set of your GUI testcases?
Yes.
>2. Do we ne... Eugenie Lyzenko
01:09 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150313a.zip
2 questions:
1. Are the changes to @ButtonGuiImpl@ really correct for the full... Greg Shah
03:17 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150315a.zip
I only have some minor requests:
1. Add a history entry to @Editor.java@.
2... Greg Shah
08:36 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: added error handling and modified state
note 17 requests are added
added limitation logic. There is a good place fo... Evgeny Kiselev
02:53 PM Feature #2422: add features to BROWSE: I'm OK storing the state in the screen buffer but separate from other widgets. But I'm looking for a specific propos... Greg Shah
02:32 PM Feature #2422: add features to BROWSE: Are you planning to transfer browse columns states/values in screen buffers, like for any other widgets (e.g. fill-ins)? Stanislav Lomany
01:15 PM Feature #2422: add features to BROWSE: > Also we can track these changes not involving screen buffer by tracking this changes in Browse/BrowseColumns and th... Greg Shah
01:29 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> After you have done some initial analysis, please organize the work into "sections" which can be ... Igor Skornyakov
01:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: After you have done some initial analysis, please organize the work into "sections" which can be logically separated ... Greg Shah
01:24 PM Feature #1790: implement menu support: > AbstractContainer has a field current that contains a widget having focus, so I think such situation, when a severa... Greg Shah
06:40 AM Feature #1790: implement menu support: Thanks for help!
The next 2 questions.
1. Every opened sub-menu has its own focus. Lets assume we have MENUBAR wi... Vadim Gindin
09:01 AM Feature #2522 (Closed): add attribute/method support for radio-set: Greg Shah
09:00 AM Bug #2520 (Closed): Dynamic list controls are not visible: Greg Shah

03/13/2015

05:24 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> The bottom and right borders of sub-menu is not drawn. I've debugged it and found that it beca... Constantin Asofiei
05:19 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> The bottom and right borders of sub-menu is not drawn. I've debugged it and found that it beca... Constantin Asofiei
05:16 PM Feature #1790: implement menu support: The bottom and right borders of sub-menu is not drawn. I've debugged it and found that it because @ScreenBitmap@ acti... Vadim Gindin
12:26 PM Feature #1790: implement menu support: > I think it will be not suitable to use DropDown and ComboBox classes for menu goals as a common mechanism.
I agr... Greg Shah
11:28 AM Feature #1790: implement menu support: The first question in previous note is solved: wrong implementation of @menu.width()@ Vadim Gindin
09:06 AM Feature #1790: implement menu support: Separate question about events. Lets look at @Button.processEvent()@ method:... Vadim Gindin
08:53 AM Feature #1790: implement menu support: The next buffled difficulty. Here is my menu:... Vadim Gindin
03:22 PM Feature #2480: add support for button and image attributes and options: This update for review(merged with recent code base) is release candidate for @DEFAULT@ button attribute feature. Add... Eugenie Lyzenko
08:21 PM Feature #2480: add support for button and image attributes and options: This updates is merged with the recent code base. Also it adds conversion/runtime support for standalone set/get @DEF... Eugenie Lyzenko
12:34 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Has passed regression testing and is committed as bzr rev. 10811 Igor Skornyakov
12:33 PM Bug #2520: Dynamic list controls are not visible: Final version has passed regression testing and is committed as bzr rev. 10811 Igor Skornyakov
12:32 PM Feature #2522: add attribute/method support for radio-set: Has passed regression testing and is committed as bzr rev. 10811 Igor Skornyakov
12:16 PM Feature #2522: add attribute/method support for radio-set: Yes, you can check it in. Greg Shah
11:29 AM Feature #2522: add attribute/method support for radio-set: Please find the final update attached. Igor Skornyakov
11:01 AM Feature #2522: add attribute/method support for radio-set: Please post the final update here. Greg Shah
04:18 AM Feature #2522: add attribute/method support for radio-set: All regression tests (except tc_job_002) passed. Can I commit mt changes? Igor Skornyakov
12:22 PM Feature #2422: add features to BROWSE: Yes, but we have single cell's widget (there are multiple columns) and only for editable browse.
Also we can track ... Stanislav Lomany
12:06 PM Feature #2422: add features to BROWSE: Treating the browse column as a real widget is going to add quite a bit of complication. It will have to be ignored ... Greg Shah
11:39 AM Feature #2422: add features to BROWSE: Guys, about the @SCREEN-VALUE@ of a browse column. This attribute matches the content of the cell of the specific col... Stanislav Lomany

03/12/2015

04:01 PM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> Igor, I think the update is safe now. But please rename @pairsSetWhenRealized@ to @item... Igor Skornyakov
03:39 PM Feature #2522: add attribute/method support for radio-set: Igor, I think the update is safe now. But please rename @pairsSetWhenRealized@ to @itemsSetWhenRealized@ - this flag... Constantin Asofiei
01:16 PM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> Igor, I'm still trying to understand why the @pairsSetWhenRealized@ flag is needed - ple... Igor Skornyakov
12:51 PM Feature #2522: add attribute/method support for radio-set: Igor, I'm still trying to understand why the @pairsSetWhenRealized@ flag is needed - please post a simple, minimum te... Constantin Asofiei
12:37 PM Feature #2522: add attribute/method support for radio-set: Code Review ias_upd20150312b.zip
I'm OK with the changes. Greg Shah
12:18 PM Feature #2522: add attribute/method support for radio-set: Actually Constantin is right: I've not tested all cases. Please find the update attached.
Thank you Constantin. Igor Skornyakov
11:26 AM Feature #2522: add attribute/method support for radio-set: Constantin Asofiei wrote:
> About ias_upd20150312a.zip:
> * @ControlSetEntity.pairs@ - the javadoc for @return@ is ... Igor Skornyakov
10:56 AM Feature #2522: add attribute/method support for radio-set: About ias_upd20150312a.zip:
* @ControlSetEntity.pairs@ - the javadoc for @return@ is not formatted properly.
* @Con... Constantin Asofiei
09:07 AM Feature #2522: add attribute/method support for radio-set: Code Review ias_upd20150312a.zip
I'm fine with the changes.
Constantin: please review. Greg Shah
07:44 AM Feature #2522: add attribute/method support for radio-set: Done. The regression test started. The attached archive also contains minor fixed for #2508 and #2520 Igor Skornyakov
09:22 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150311a.zip
I'm good with the changes. Greg Shah

03/11/2015

06:47 PM Feature #2480: add support for button and image attributes and options: The update for review presents suggested approach in base for implementation of the default button feature. The frame... Eugenie Lyzenko
08:37 AM Feature #2480: add support for button and image attributes and options: My only concern here is that the logic for this should not be in the window widget, but in the frame widget. Doesn't... Greg Shah
09:23 PM Feature #2480: add support for button and image attributes and options: Looking for best implementation for button @DEFAULT@ attribute handling I see the following opportunity:
1. Pressing... Eugenie Lyzenko
12:35 PM Bug #2520: Dynamic list controls are not visible: This looks reasonable. Please add this to the changes for #2522 to reduce testing effort. Also, it will give Consta... Greg Shah
11:55 AM Bug #2520: Dynamic list controls are not visible: With the following update in Frame... Igor Skornyakov
10:06 AM Feature #2422: add features to BROWSE: Update merged with the latest sources. Committed to bzr rev 10804. Stanislav Lomany
08:16 AM Feature #1790: implement menu support: Vadim, some notes about the vig_20150309a.zip update you've sent me:
* Rectangle: the instances of this class need t... Constantin Asofiei

03/10/2015

07:17 PM Feature #1790: implement menu support: > I don't fully understand this statement. MENUBAR draws it's items (menu-items and sub-menus) within its area. Dropp... Greg Shah
06:58 PM Feature #1790: implement menu support: Greg Shah wrote:
> Some thoughts:
>
> 1. Menus are different from our normal containers like Frames. With menus,... Vadim Gindin
06:38 PM Feature #1790: implement menu support: Some thoughts:
1. Menus are different from our normal containers like Frames. With menus, the contained widgets c... Greg Shah
06:21 PM Feature #1790: implement menu support: 1. I have simple MENUBAR with sub-menu and menu. It is drawn succesfully. At starting moment sub-menu has focus. When... Vadim Gindin
06:06 PM Feature #1790: implement menu support: If you are stuck, please post specific questions or post more details of the problem so that we can help. Greg Shah
05:45 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Perhaps it makes sense to integrate these changes with your work in #2522 to reduce the amount ... Igor Skornyakov
05:43 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: > And because there will be a separate commit by Constantin I understand a new history entry for the ControlSetEntity... Greg Shah
05:31 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Code Review ias_upd20150310a.zip
>
> I'm fine with the proposed changes, except that the @Cont... Igor Skornyakov
05:29 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150310a.zip
I'm fine with the proposed changes, except that the @ControlSetConfig.java@ needs... Greg Shah
05:24 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Igor Skornyakov wrote:
> Shall I start the regression testing right now?
No, don't put this into testing since Co... Greg Shah
05:21 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Shall I start the regression testing right now? Igor Skornyakov
05:05 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Please take a look at the augmented version of the Constantin's changes (I've the support for the above mentioned sub... Igor Skornyakov
03:27 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Well, it seems that the situation is the following:
If LIST-ITEMS is assigned before the frame containing the widget... Igor Skornyakov
03:12 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: The situation looks strange. If one puts assignments in Constantin's sample not within "on" block (just two consecuti... Igor Skornyakov
02:51 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Constantin,
I agree with your changes. However I've noticed another non-compatibility with 4GL:
With your sample ru... Igor Skornyakov
02:11 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Igor, please review and test this update with your standalone tests. It fixes problems in this code:... Constantin Asofiei
11:03 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: The updated zip is attached. Greg Shah
10:51 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: setListItems() method fixed.
Has passed conversion regression testing and is committed as bzr rev. 10802.
Igor Skornyakov
10:36 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> What is the status of this? Also, please post the updated zip.
Regression test just passed (i... Igor Skornyakov
10:05 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: What is the status of this? Also, please post the updated zip. Greg Shah
05:10 PM Bug #2520: Dynamic list controls are not visible: The updating of @savedWidgets@ doesn't work. Continue the investigation. Igor Skornyakov
06:26 AM Bug #2520: Dynamic list controls are not visible: I see. Thank you Constantin. Igor Skornyakov
06:21 AM Bug #2520: Dynamic list controls are not visible: Igor, see this test:... Constantin Asofiei
05:56 AM Bug #2520: Dynamic list controls are not visible: Constantin,
If I correctly understand your scenario my change retains the 4GL compatibility: after the frame is enab... Igor Skornyakov
05:05 PM Feature #2480: add support for button and image attributes and options: The investigation shows the default button feature works only in GUI mode. The character mode just ignores this attri... Eugenie Lyzenko
11:20 AM Feature #2422: add features to BROWSE: The @QueryWrapper@ changes in 0310a look OK to me. Eric Faulhaber
09:59 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150310a.zip
I'm fine with the changes.
Eric: please review the @QueryWrapper@ change.
B... Greg Shah
05:53 AM Feature #2422: add features to BROWSE: Update for review. Relatively to the previous version of the update (0305a) only @QueryWrapper@ has changed. Stanislav Lomany
05:50 AM Feature #2422: add features to BROWSE: About the recet bug. Here is the code that repositions browse to an invalid id:... Stanislav Lomany

03/09/2015

07:24 PM Feature #2480: add support for button and image attributes and options: @evl_upd20150307a.zip@ has been committed as 10800. Eugenie Lyzenko
06:28 PM Feature #2480: add support for button and image attributes and options: OK, please commit it. Greg Shah
06:13 PM Feature #2480: add support for button and image attributes and options: Conversion testing completed. No difference in generated code. So the update @evl_upd20150307a.zip@ is ready to be co... Eugenie Lyzenko
03:23 PM Feature #2480: add support for button and image attributes and options: The new runtime test results: @10797_5c96d7c_20150309_evl.zip@ for update based on 10797. No regression found.
Sta... Eugenie Lyzenko
06:53 PM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Please note this text from the Progress docs for @EDITOR Phrase@:... Greg Shah
04:43 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.... Igor Skornyakov
03:33 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> The urgency now is to determine if your Frame.addWidget change does not break any existin... Igor Skornyakov
03:30 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > Yes, don't complicate things for now. Just confirm the ... Constantin Asofiei
03:21 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Yes, don't complicate things for now. Just confirm the implications of your change an... Igor Skornyakov
03:14 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > In any case, this is not currently supported by P2J. Th... Constantin Asofiei
03:10 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> In any case, this is not currently supported by P2J. The APIs are a no-op now.
I s... Igor Skornyakov
02:57 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > As I see from dvref.pdf, AUTO-RESIZE is for GUI only.
>... Constantin Asofiei
02:48 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> As I see from dvref.pdf, AUTO-RESIZE is for GUI only.
I know. However in my tests t... Igor Skornyakov
02:44 PM Bug #2520: Dynamic list controls are not visible: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, I think this is part of a larger defect in P2J, relate... Constantin Asofiei
02:39 PM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.... Igor Skornyakov
02:25 PM Bug #2520: Dynamic list controls are not visible: Igor, I think this is part of a larger defect in P2J, related to dynamic widgets/frames.
Something I think shoul... Constantin Asofiei
10:52 AM Bug #2520: Dynamic list controls are not visible: Constantin Asofiei wrote:
> So, Igor: what issue were you trying to solve? Do you have a standalone test for it?
... Igor Skornyakov
10:35 AM Bug #2520: Dynamic list controls are not visible: Greg Shah wrote:
> Constantin: please review the change (bzr rev 10797). Is the modification safe?
It's hard to tel... Constantin Asofiei
09:12 AM Bug #2520: Dynamic list controls are not visible: Greg Shah wrote:
> Igor: in the future, please do not check anything in before you are explicitly approved to do so.... Igor Skornyakov
09:08 AM Bug #2520: Dynamic list controls are not visible: Igor: in the future, please do not check anything in before you are explicitly approved to do so. Such approval is a... Greg Shah
09:47 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150309a.zip
The change is good. Please add a history entry, post the updated 0309b zip and g... Greg Shah
09:19 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Fixed regression reported by Constantin (see #2408 notes 135/136/137). Restarted regression test Igor Skornyakov
08:54 AM Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...: Greg Shah
09:11 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Have you tested both attributes with both widgets?
The method is the same for both widg... Igor Skornyakov
08:22 AM Feature #2498: implement ADD-LAST() method: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PA... Constantin Asofiei
07:55 AM Feature #2498: implement ADD-LAST() method: Constantin Asofiei wrote:
> Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PAIRS are set via the widget a... Igor Skornyakov
07:25 AM Feature #2498: implement ADD-LAST() method: Igor, you have a regression when LIST-ITEMS and LIST-ITEM-PAIRS are set via the widget attribute, as in:... Constantin Asofiei

03/08/2015

05:20 AM Bug #2520: Dynamic list controls are not visible: Has passed conversion regression testing and is committed as bzr rev. 10797. Igor Skornyakov
07:40 PM Feature #2480: add support for button and image attributes and options: The testing completed, no regressions. The results: @10794_5c96d7c_20150307_evl.zip@.
Looks like I have to re-run ... Eugenie Lyzenko

03/07/2015

01:51 PM Feature #2480: add support for button and image attributes and options: Merge with 10796 code base. Eugenie Lyzenko
08:46 PM Feature #2480: add support for button and image attributes and options: The conversion testing completed. Generated codes are identical, no regressions. Starting runtime testing. Eugenie Lyzenko
03:51 AM Bug #2520: Dynamic list controls are not visible: Fixed. Started regression test Igor Skornyakov
03:36 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Passed runtime regression testing and checked in as bzr rev 10796. Igor Skornyakov

03/06/2015

04:46 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can y... Hynek Cihlar
04:15 PM Feature #2480: add support for button and image attributes and options: >I have no objections to this.
OK. I'm starting the conversion and runtime testing. Eugenie Lyzenko
04:01 PM Feature #2480: add support for button and image attributes and options: >Eugenie, do you know where the clipping rectangle is first calculated wrong? If not, can you trace it down? Also, is... Eugenie Lyzenko
02:20 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> > One consideration about clipping. The feature is now working for button widget but I think it h... Hynek Cihlar
02:05 PM Feature #2480: add support for button and image attributes and options: > One consideration about clipping. The feature is now working for button widget but I think it has an issue. If usin... Greg Shah
02:04 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150306a.zip
I'm fine with the changes. Greg Shah
12:32 PM Feature #2480: add support for button and image attributes and options: This update for review has completed runtime implementation for @NO-FOCUS@/@FLAT-BUTTON@ client part plus fixed newly... Eugenie Lyzenko
03:45 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: After 3 runs the following 2 tests failed (in addition to the expected tc_job_002):... Igor Skornyakov
03:00 PM Feature #1790: implement menu support: Code Review vig_upd20150306a.zip
This is a good step forward.
1. It seems like there should be shared code betw... Greg Shah
02:16 PM Feature #1790: implement menu support: > When I'm pressing '->' in MENUBAR first menu-item (sub-menu) is blended when loosing focus. There are several calls... Greg Shah
10:37 AM Feature #1790: implement menu support: It seems I will not make working version until today. Here is my current update with the following changes.
* Focus ... Vadim Gindin
02:40 PM Feature #2422: add features to BROWSE: One regression test has failed: @P2JQuery.bufferHandle()@ returns invalid handle. Looking into it. Stanislav Lomany
08:46 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150305a.zip
I'm OK with the changes.
Eric: please review the @QueryWrapper@ change. Greg Shah
02:59 AM Feature #2422: add features to BROWSE: Update for review. Fixes minor issues. Stanislav Lomany
11:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LINES runtime setter attribute unknown behavior shoul... Greg Shah
09:38 AM Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah
08:46 AM Bug #2520: Dynamic list controls are not visible: It seems that I've resolved the issue (with one-line fix). Will start regression testing after the one for #2508 will... Igor Skornyakov

03/05/2015

03:50 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Code Review ias_upd20150305a.zip
I'm good with the changes. Greg Shah
03:30 PM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: NPE was a result of my bug. To fix the cursor issue it was sufficient to hide cursor on SELECTION-LIST focus gain (an... Igor Skornyakov
09:02 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: OK, please do fix these as part of this task. Greg Shah
09:00 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Greg Shah wrote:
> Are these bugs specific to your change or are they already existing in P2J?
These bugs are not... Igor Skornyakov
08:57 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Are these bugs specific to your change or are they already existing in P2J? Greg Shah
08:56 AM Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...: Found at least two bugs.
1. When there are several widgets in a frame the cursor position doesn't change when switch... Igor Skornyakov

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

04/03/2015

04/02/2015

04/01/2015

03/31/2015

03/30/2015

03/29/2015

03/28/2015

03/27/2015

03/26/2015

03/25/2015

03/24/2015

03/23/2015

03/22/2015

03/20/2015

03/19/2015

03/18/2015

03/17/2015

03/16/2015

03/13/2015

03/12/2015

03/11/2015

03/10/2015

03/09/2015

03/08/2015

03/07/2015

03/06/2015

03/05/2015