Project

General

Profile

Activity

From 04/15/2015 to 05/14/2015

05/14/2015

07:11 PM Feature #2546: implement combo-box widget in GUI
The update has fixes for previous notes and creating new class @DropDownImpl@ to handle ChUI specifics. The @ChuiWidg... Eugenie Lyzenko
06:11 PM Feature #2546: implement combo-box widget in GUI
> You mean we need to create new class @DropDownImpl@ to concentrate all ChUI specifics?
Yes.
Greg Shah
06:05 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
>
> 3. Since @DropDown.fixVisibleRows()@ is ChUI specific, it should be in @DropDownImpl@. In th...
Eugenie Lyzenko
05:29 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150514a.zip
I like the code.
1. The @ComboBox.initEventsSet()@ and @ComboBox.addMouseExitE...
Greg Shah
04:47 PM Feature #2546: implement combo-box widget in GUI
This update accumulates recent changes and fixes for combo-box. What's new:
1. The drop-down can now be left either ...
Eugenie Lyzenko
03:58 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150512a.zip
I'm OK with the changes so far. @ScrollableSelectionListGuiImpl@, @DropDownGuiIm...
Greg Shah
04:23 AM Feature #2546: implement combo-box widget in GUI
I noticed drop downs are drawn using the same renderer as the parent @Window@. This means they can never be drawn out... Hynek Cihlar
06:33 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> 1. Is there only 1 issue described in those notes or more than one?
I understand that it is a ...
Igor Skornyakov
06:29 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Greg Shah wrote:
>
> > Is another task is needed for the issue in note 67, 71 - 72 and 8...
Greg Shah
06:16 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Is another task is needed for the issue in note 67, 71 - 72 and 84 - 86?
I do not consider t...
Igor Skornyakov
06:10 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've created a separate task #2572 for work on @realized@.
Is another task is needed for the issue in note 67, 71 ...
Greg Shah
05:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> 2. This call worked only for drop-down list and only for the time it exists. No other class...
Hynek Cihlar
04:58 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> > Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
> >
> > [...]
>
> I...
Eugenie Lyzenko
03:59 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Igor Skornyakov wrote:
> > I've noticed the following issue (see attached sample code). With ...
Greg Shah
11:26 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> I mean, does the frame get realized regardless which widget gets its size read?
I d...
Igor Skornyakov
11:19 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > OK, this is interesting; I think reading width/height at...
Constantin Asofiei
10:09 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> OK, this is interesting; I think reading width/height attributes will make the frame "...
Igor Skornyakov
10:03 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
>
> > Igor: please post your example for the case you are tryi...
Constantin Asofiei
09:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Igor: please post your example for the case you are trying to solve.
Constantin. In...
Igor Skornyakov
09:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> My suggest: the widget become realized when it become the part of some frame. More specifica...
Constantin Asofiei
09:42 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Is it sufficient to set a 'realized' flag in the widget config?
There already is a @Widget...
Constantin Asofiei
09:41 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
My suggest: the widget become realized when it become the part of some frame. More specifically: when it is used in w... Eugenie Lyzenko
09:23 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> From @4GL 9.1 Progress Programming Handbook@, chapter 16-26, page 614:
>
> [...]
Th...
Igor Skornyakov
09:07 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of...
Eugenie Lyzenko
07:34 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
BTW: I would like to repeat the question I've asked earlier. What is the exact semantics of the widget 'realization'?... Igor Skornyakov
03:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
>
> Probably due to the following in @DropDownGuiImpl.setHeightAndPos()@?
>
> [...]
Th...
Igor Skornyakov
03:56 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> I've noticed the following issue (see attached sample code). With native 4GL one can see a ...
Hynek Cihlar
03:37 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Is this something which prevents the 4GL program to run? Basically, our goal is to conve...
Igor Skornyakov
01:26 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Need to add frame validation at the moment of realization to ensure that all widgets fit in...
Constantin Asofiei
06:22 PM Feature #2252: implement GUI client support
Code Review hc_upd20150513b.zip
I'm OK with it.
Constantin?
Greg Shah
07:12 AM Feature #2252: implement GUI client support
The attached update fixes a mismatch in frame size caused by char->pixel conversion. This prevents frame size adjustm... Hynek Cihlar
06:05 PM Bug #2572: improve realized for widgets
The @realized@ flag for widgets needs to be improved to duplicate the 4GL behavior. Unfortunately, this behavior is ... Greg Shah
06:02 PM Bug #2572 (New): improve realized for widgets
Greg Shah
07:27 AM Feature #1811: implement the AJAX client driver
> > After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong ... Anton Breaur
07:06 AM Feature #1811: implement the AJAX client driver
> We are not just limited to using this approach.
To be clear, my preference is to use predefined classes from Jet...
Greg Shah
07:00 AM Feature #1811: implement the AJAX client driver
> Adding another subfolder to res folders as such: com/goldencode/p2j/ui/client/chui/driver/web/res/client and com/go... Greg Shah
06:56 AM Feature #1811: implement the AJAX client driver
> After investigating the web Chui issue, I found that the ChuiWebDriver.getWelcomePageUrl method builds the wrong UR... Greg Shah
06:27 AM Feature #1811: implement the AJAX client driver
Adding another subfolder to res folders as such: @com/goldencode/p2j/ui/client/chui/driver/web/res/client@ and @com/g... Anton Breaur

05/13/2015

06:44 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Need to add frame validation at the moment of realization to ensure that all widgets fit in the frame. At this moment... Igor Skornyakov
01:28 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've noticed the following issue (see attached sample code). With native 4GL one can see a bordered frame w/o scrollb... Igor Skornyakov
12:25 PM Feature #1811: implement the AJAX client driver
After investigating the web Chui issue, I found that the @ChuiWebDriver.getWelcomePageUrl@ method builds the wrong UR... Anton Breaur
07:45 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> I think is related to something I was suspecting it will cause us issues: when pushScree...
Hynek Cihlar
06:03 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, when you have time, please take a look at testcases/uast...
Constantin Asofiei
04:36 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, when you have time, please take a look at testcases/uast/demo/movie-ratings-dynam...
Hynek Cihlar
09:14 PM Feature #2546: implement combo-box widget in GUI
This update for review has several small fixes for UI representation for the drop-down and scroll-bar inside.
1. The...
Eugenie Lyzenko

05/12/2015

05:32 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The additional note: the second config update I've mentioned before is actually a one triggered by a server-side @Syn... Igor Skornyakov
02:08 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Please post your whole update and a small sample I can run. Thanks.
My code is currently in...
Igor Skornyakov
01:38 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please post your whole update and a small sample I can run. Thanks. Hynek Cihlar
01:22 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Well, I've noticed some strange thing - the backup values for 2 field are stale (do not reflect the values before cha... Igor Skornyakov
01:11 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I think they are (see attached file). Please note however that @readExternal@/@writeExternal@ are not invoked (neithe... Igor Skornyakov
01:01 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Are all the fields properly handled in @readExternal@, @writeExternal@ and @applyConfig@? Please post your code changes. Hynek Cihlar
12:51 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Additional observations: @addDirtyConfig@ was invoked for all 3 fields. Igor Skornyakov
12:43 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek,
I've added 3 fields to the @ComboBoxConfig@ :
/** The number of assignments to INNER-LINES since the la...
Igor Skornyakov
12:38 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, which fields are not propagated? Please post a sample code. Hynek Cihlar
12:33 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
It seems that there is a problem with config changes' propagation from client side to the server one. I change 3 fiel... Igor Skornyakov

05/11/2015

11:28 AM Feature #2422: add features to BROWSE
Until SET-REPOSITIONED-ROW is implemented, GET-REPOSITIONED-ROW always returns 1. Stanislav Lomany
01:03 AM Feature #2422: add features to BROWSE
I like the approach. It improves compatibility on the server-side while not requiring an explosion of new widgets (a... Greg Shah
09:44 PM Feature #2422: add features to BROWSE
Greg, about AUTO-ZAP: I think we can create @FillInConfig.zapActive@ variable and update it each time zap state it is... Stanislav Lomany
10:30 AM Feature #2563: implement GUI EDITOR widget
>Please test what happens with the image's WIDTH/HEIGHT-CHARS/PIXELS attributes in these cases (image or size phrase)... Eugenie Lyzenko
02:57 AM Feature #2563: implement GUI EDITOR widget
Attached version was committed to bzr rev 10858 (just a header entry added to ImageGuiImpl, it was missing in 0510d.zip) Constantin Asofiei
02:53 AM Feature #2563: implement GUI EDITOR widget
Eugenie Lyzenko wrote:
> Imagine two situations:
> 1. We have no image and @width@/@height@ == 0.
> 2. We have no ...
Constantin Asofiei
09:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> You can work with Constantin to plan the changes needed. At this point, just put in the minimum ...
Igor Skornyakov
09:51 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
You can work with Constantin to plan the changes needed. At this point, just put in the minimum support that you nee... Greg Shah
08:18 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I think that I understand the root of the problem. The @FrameWidget.frame@ field initially contains the corresponding... Igor Skornyakov
07:46 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> We don't have frame family support yet (that is the last part of #1798). It won't get worked unt...
Igor Skornyakov
07:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
We don't have frame family support yet (that is the last part of #1798). It won't get worked until later this summer... Greg Shah
07:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
It seems that we have a problem with nested frames - all the intermediate frames and inner widget have a @frame@ fiel... Igor Skornyakov
06:52 AM Feature #2252: implement GUI client support
The problem seems to be in mixing the window size vs. the window workspace size. When the frame layouts itself it mus... Hynek Cihlar
05:51 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > See the attached update, now the frame seems to be stable.
> ...
Hynek Cihlar
03:27 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> See the attached update, now the frame seems to be stable.
>
> The problem was in the char...
Constantin Asofiei

05/10/2015

05:27 PM Feature #2563: implement GUI EDITOR widget
>Eugenie, can you review the ImageGuiImpl change in 0510d.zip? I wonder if you had a specific reason to return width/... Eugenie Lyzenko
03:07 PM Feature #2563: implement GUI EDITOR widget
Eugenie, can you review the ImageGuiImpl change in 0510d.zip? I wonder if you had a specific reason to return width/h... Constantin Asofiei
02:28 PM Feature #2563: implement GUI EDITOR widget
ca_upd20150510d.zip has passed runtime testing. But there might be more problematic edge cases (like merging lines o... Constantin Asofiei
10:33 AM Feature #2563: implement GUI EDITOR widget
New version: fixed 2 editor regressions and some other GUI improvements (FILL-IN colors, LABEL font, IMAGE size). Constantin Asofiei
04:09 PM Feature #2252: implement GUI client support
See the attached update, now the frame seems to be stable.
The problem was in the char->pixel->char conversion. T...
Hynek Cihlar
03:12 PM Feature #2252: implement GUI client support
Hynek, when you have time, please take a look at testcases/uast/demo/movie-ratings-dynamic.p - in P2J, when setting c... Constantin Asofiei
09:12 AM Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > The update improves drawing of window caption buttons. They are now ...
Hynek Cihlar
08:28 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The update improves drawing of window caption buttons. They are now more alike those from stan...
Eugenie Lyzenko
08:13 AM Feature #2252: implement GUI client support
The javadoc problem fixed and the update committed to bzr rev 10857. Hynek Cihlar
04:19 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The update improves drawing of window caption buttons. They are now more alike those from stan...
Constantin Asofiei
02:46 AM Feature #2252: implement GUI client support
The update improves drawing of window caption buttons. They are now more alike those from standard Windows theme. Can... Hynek Cihlar
02:41 AM Feature #2252: implement GUI client support
The attached update fixes window scrollable size calculation when window virtual size not set. The change only affect... Hynek Cihlar
04:05 AM Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> Constanin, I change some @FillIn.config.val@ on the client side, then a trigger in invoked...
Constantin Asofiei
02:44 AM Feature #2422: add features to BROWSE
Constanin, I change some @FillIn.config.val@ on the client side, then a trigger in invoked and I get @FillInWidget.co... Stanislav Lomany
02:05 AM Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> > So long as the values in the config are modified, they will be synchronized to the serve...
Constantin Asofiei
01:59 AM Feature #2422: add features to BROWSE
> So long as the values in the config are modified, they will be synchronized to the server automatically the next ti... Stanislav Lomany
02:51 AM Feature #2564: implement GUI BROWSE widget
Another addition: CREATE-ON-ADD. Stanislav Lomany

05/09/2015

03:52 PM Feature #2563 (WIP): implement GUI EDITOR widget
First candidate version for a usable EDITOR in GUI. Basic keys (cursor movement, home/end, delete/backspace, text ed... Constantin Asofiei
07:03 AM Feature #1811: implement the AJAX client driver
Merged with bzr 10855. Greg Shah
12:06 AM Feature #1811: implement the AJAX client driver
Merged with bzr 10853. Greg Shah
04:17 AM Feature #2252: implement GUI client support
Tha attached file replaces hc_upd20150508b.zip. It is merged with trunk, and was committed to bzr rev 10855. Hynek Cihlar
09:48 PM Feature #2546: implement combo-box widget in GUI
The @evl_upd20150508d.zip@ has been committed as @10853@. Will be distributed shortly. Eugenie Lyzenko
09:31 PM Feature #2546: implement combo-box widget in GUI
The regression tests passed, results: @10850_eff7cc1_20150508_evl.zip@. Had to start 3-way @CTRL-C@ tests in separate... Eugenie Lyzenko
08:02 PM Feature #2546: implement combo-box widget in GUI
The main part completed, no regressions found. Waiting for @CTRL-C@ results. Eugenie Lyzenko

05/08/2015

06:15 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Please coordinate with Hynek to determine which of you will check in first. I'm guessing that yo...
Eugenie Lyzenko
06:11 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150508d.zip
Looks good.
Please coordinate with Hynek to determine which of you will check ...
Greg Shah
06:08 PM Feature #2546: implement combo-box widget in GUI
Several cosmetic changes to have the better look for combo-box. Only GUI code changed, so no additional testing is re... Eugenie Lyzenko
05:00 PM Feature #2546: implement combo-box widget in GUI
Update merged with the @10852@. Eugenie Lyzenko
04:28 PM Feature #2546: implement combo-box widget in GUI
Sounds good. Please note that you will need to merge with Vadim's @GuiWidgetFactory@ changes which are about to be c... Greg Shah
04:26 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> If you pass testing on 10850, you can check it in without re-testing.
OK. In this case I'm res...
Eugenie Lyzenko
04:18 PM Feature #2546: implement combo-box widget in GUI
I have finished one main cycle of the runtime testing(and have the good chances to be passed). But need another one t... Eugenie Lyzenko
04:16 PM Feature #2546: implement combo-box widget in GUI
If you pass testing on 10850, you can check it in without re-testing. Greg Shah
04:12 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The question. The update I'm testing has no crossing with @ecf_upd20150508a.zip@ and compat...
Constantin Asofiei
04:08 PM Feature #2546: implement combo-box widget in GUI
The question. The update I'm testing has no crossing with @ecf_upd20150508a.zip@ and compatible on the source level w... Eugenie Lyzenko
12:36 PM Feature #2546: implement combo-box widget in GUI
The missing file. Eugenie Lyzenko
12:30 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The merge with 10850 plus small fixes for opened drop-down. Will be used for regression tes...
Greg Shah
12:27 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Another questions:
> 1. What the widget is required to do to properly position/sizing with...
Constantin Asofiei
11:52 AM Feature #2546: implement combo-box widget in GUI
Another questions:
1. What the widget is required to do to properly position/sizing with layout manager in GUI?
2. ...
Eugenie Lyzenko
11:14 AM Feature #2546: implement combo-box widget in GUI
The merge with 10850 plus small fixes for opened drop-down. Will be used for regression testing. Eugenie Lyzenko
09:38 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Well, you are relying on labelText.length() + 2 to determine the width in character units....
Constantin Asofiei
09:26 AM Feature #2546: implement combo-box widget in GUI
>Well, you are relying on labelText.length() + 2 to determine the width in character units... in GUI, this is no long... Eugenie Lyzenko
09:16 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Can you post an example/screen shot of the distortions you mention?
> See the picture(com...
Constantin Asofiei
09:08 AM Feature #2546: implement combo-box widget in GUI
>Can you post an example/screen shot of the distortions you mention?
See the picture(compare to ..samlpe_04028_2.jpg ...
Eugenie Lyzenko
08:55 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Please merge to rev 10849.
> Merged update is attached.
>
> >Post the merged update an...
Constantin Asofiei
08:51 AM Feature #2546: implement combo-box widget in GUI
>Please merge to rev 10849.
Merged update is attached.
>Post the merged update and get this into regression testi...
Eugenie Lyzenko
08:06 AM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150507c.zip
The changes look good.
Please merge to rev 10849. Post the merged update and ...
Greg Shah
12:17 AM Feature #2546: implement combo-box widget in GUI
This is small protection improvement to the drop-down termination facility. Eugenie Lyzenko
05:08 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached replaces hc_upd20150508a.zip and fixes a compilati...
Hynek Cihlar
02:18 PM Feature #2252: implement GUI client support
Code Review hc_upd20150508b.zip
I'm fine with the code once you have agreed with Constantin on the issue in note 9...
Greg Shah
12:55 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The attached replaces hc_upd20150508a.zip and fixes a compilation error. Constantin, what was ...
Constantin Asofiei
12:02 PM Feature #2252: implement GUI client support
And the file...
Hynek Cihlar wrote:
> The attached replaces hc_upd20150508a.zip and fixes a compilation error. Co...
Hynek Cihlar
12:01 PM Feature #2252: implement GUI client support
The attached replaces hc_upd20150508a.zip and fixes a compilation error. Constantin, what was the purpose of ... Hynek Cihlar
11:52 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached update improves window scrolling support. This is ...
Constantin Asofiei
11:49 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The attached update improves window scrolling support. This is a first phase update focusing o...
Constantin Asofiei
11:43 AM Feature #2252: implement GUI client support
The attached update improves window scrolling support. This is a first phase update focusing on happy code paths. I a... Hynek Cihlar
11:26 AM Feature #2252: implement GUI client support
I just found the following in @ScrollBarGuiImpl@. Does anybody know the reason why mouse clicks are handled this way ... Hynek Cihlar
10:32 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150508b.zip
>
> I'm fine with the changes. Check them in.
Committed re...
Constantin Asofiei
10:29 AM Feature #2252: implement GUI client support
Code Review ca_upd20150508b.zip
I'm fine with the changes. Check them in.
Greg Shah
10:21 AM Feature #2252: implement GUI client support
Fixed a regression in rev 10849/ ca_upd20150508a.zip - window resize via mouse was no longer working properly. Constantin Asofiei
08:10 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> > font scaling switched from using legacy metric scaling to DPI scaling (from 72 to OS DPI)
>
...
Constantin Asofiei
07:51 AM Feature #2252: implement GUI client support
> font scaling switched from using legacy metric scaling to DPI scaling (from 72 to OS DPI)
What are the implicati...
Greg Shah
07:31 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150508a.zip
>
> It's good. Please check it in.
Committed revision 10849.
Constantin Asofiei
07:27 AM Feature #2252: implement GUI client support
Code Review ca_upd20150508a.zip
It's good. Please check it in.
Greg Shah
03:44 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150507a.zip
>
> I'm generally fine with the changes. Unfortunately, your ...
Constantin Asofiei
04:37 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed it and committed to revision 10852. Vadim Gindin
04:26 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150509b.zip
In @ToggleBoxGuiImpl@, please change @CHKBOX_WIDHT@ to @CHKBOX_WIDTH@. Otherwise...
Greg Shah
04:21 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed highlighting and checked ZeroColumnLayout change for CHUI. I've found that CHUI implementation also has bu... Vadim Gindin
03:38 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Greg Shah wrote:
> > Code Review vig_upd20150509a.zip
> >
> > 1. Is your @ZeroColumnLayout...
Constantin Asofiei
03:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Code Review vig_upd20150509a.zip
>
> 1. Is your @ZeroColumnLayout@ change safe for ChUI?
I ...
Vadim Gindin
03:17 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150509a.zip
1. Is your @ZeroColumnLayout@ change safe for ChUI?
2. Please remove the @src/...
Greg Shah
02:42 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I just wanted to fix highlighting for not standard size. Here is my current update. Vadim Gindin
02:36 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
What do you have left to do for this first pass? Greg Shah
02:28 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Thank you. Here are my next 2 current layout bugs:
>
> # After I dynamically reset toggle-b...
Constantin Asofiei
01:08 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Thank you. Here are my next 2 current layout bugs:
>
> # After I dynamically reset toggle-b...
Vadim Gindin
01:05 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Thank you. Here are my next 2 current layout bugs:
# After I dynamically reset toggle-box label to ? 4GL automatic...
Vadim Gindin
10:47 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've tried to set these attributes for the static button, but no visible changes happen.
OK, ...
Constantin Asofiei
10:27 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > I...
Vadim Gindin
08:57 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > I've fixed it. Sorry to trouble.
> ...
Constantin Asofiei
08:43 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've fixed it. Sorry to trouble.
> What was the problem?
>
...
Vadim Gindin
07:32 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've fixed it. Sorry to trouble.
What was the problem?
There is a change in rev 10849 Thin...
Constantin Asofiei
07:30 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've fixed it. Sorry to trouble. Vadim Gindin
06:11 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin, I'm trying to find out the reason of the strange affect. See attached image.
First time the applicatio...
Vadim Gindin
05:07 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Hynek:
I think afterConfigUpdate is in your case called from "apply config" call and afterSetWidthPixels() is exi...
Vadim Gindin
04:23 PM Feature #2422: add features to BROWSE
Code Review svl_upd20150508a.zip
It looks fine.
Please keep building the additional work for this week (2-6) on...
Greg Shah
04:11 PM Feature #2422: add features to BROWSE
Update for review. Contains INSERT-ROW/NEW-ROW basics. There are missing fixes for empty browse and "Cannot insert ro... Stanislav Lomany
01:48 PM Feature #2422: add features to BROWSE
> P2J has pushScreenDefinition() to sync server config with client. Do we have anything that makes similar action in ... Greg Shah
01:04 PM Feature #2422: add features to BROWSE
P2J has @pushScreenDefinition()@ to sync server config with client. Do we have anything that makes similar action in ... Stanislav Lomany
01:00 PM Feature #2422: add features to BROWSE
> Don't we already have a client-side widget for each column?
We have single fill-in which is created and then destr...
Stanislav Lomany
12:19 PM Feature #2422: add features to BROWSE
> Regarding 3, 4, 5 - should I solve fill-in problems? 3 and 4 may potentially turn out to be complicated.
Yes, le...
Greg Shah
12:15 PM Feature #2422: add features to BROWSE
Some planning info from SVL:
Here are the items left:
# INSERT-ROW basics - Will send today
# AUTO-ZAP/CURSOR-OFFSE...
Greg Shah
09:38 AM Feature #2422: add features to BROWSE
> What should it be in this case - set of FillIns and corresponding FillInWidgets on the server side with transparent... Greg Shah
07:24 AM Feature #2422: add features to BROWSE
I have some things about @AUTO-ZAP/CURSOR-OFFSET/CURRENT-ROW-MODIFIED@ to clear:
# How do we expect to implement att...
Stanislav Lomany
02:14 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Please provide some details about the status of this task.
Greg,
I hope to finish the task at...
Igor Skornyakov
01:52 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please provide some details about the status of this task. Greg Shah
10:52 AM Feature #1811: implement the AJAX client driver
Merged with bzr 10850. Greg Shah
10:05 AM Feature #1811: implement the AJAX client driver
Both are fixed with this update. Greg Shah
09:59 AM Feature #1811: implement the AJAX client driver
Another issue: FontDetails.key is never set - it should be set by @FontManager$WorkArea.getFont@. Constantin Asofiei
09:46 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Here is the update merged with bzr 10849.
There is a compilation problem in @WidgetBrowserAspect...
Constantin Asofiei
09:21 AM Feature #1811: implement the AJAX client driver
Here is the update merged with bzr 10849. Greg Shah

05/07/2015

06:54 PM Feature #1811: implement the AJAX client driver
Two other notes about my update:
1. The node "chuiWeb" in the directory needs to be changed to "webClient".
2. ...
Greg Shah
06:48 PM Feature #1811: implement the AJAX client driver
Following up on my note 651, the attached update is the first (partially working) pass at steps 1 - 7.
I have also...
Greg Shah
06:45 PM Feature #2546: implement combo-box widget in GUI
Finally I have found the fix for drop-down disappearing. So the new update for review is attached. Certainly this is ... Eugenie Lyzenko
05:56 PM Feature #2546: implement combo-box widget in GUI
This is the cleaned code for review. The UI drop-down disappearing issue is still here. Working on it. Eugenie Lyzenko
12:02 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin, if you have some short answer please share. Does every mouse movement cause the...
Constantin Asofiei
11:56 AM Feature #2546: implement combo-box widget in GUI
>Shouldn't the WidgetFactoryAdapter.createDropDown() just throw an exception? Under what conditions will it actually ... Eugenie Lyzenko
08:36 AM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150506a.zip
Generally, this looks good.
Shouldn't the @WidgetFactoryAdapter.createDropDown...
Greg Shah
11:51 PM Feature #2546: implement combo-box widget in GUI
This is the next step for review. Finally the scrollbar is working to use sroll-buttons to navigate drop-down.
The...
Eugenie Lyzenko
06:17 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is my current update. I've fixed WIDTH/HEIGHT attributes calculation. Vadim Gindin
01:28 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Thank you! It was a classpath problem. I had "/testcases/uast/font/system.metrics" folder in my classpath and after I... Vadim Gindin
01:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > About matching the label metrics in GUI with the legacy metrics...
Constantin Asofiei
01:11 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> About matching the label metrics in GUI with the legacy metrics as on windev01.
> # Aft...
Vadim Gindin
09:17 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
About matching the label metrics in GUI with the legacy metrics as on windev01.
# After each conversion, there is a ...
Constantin Asofiei
09:13 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
In looking at your screen-shots, is the P2J toggle-box shadow color correct? It seems too dark. Greg Shah
08:53 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> About label width for widgets: @gd.getTextWidth("tbx", gf.font().font)@ has returned 13. Is it...
Constantin Asofiei
08:52 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these ...
Constantin Asofiei
08:50 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> About the window clearing, I don't think this has anything to do with the toggle-box. We will wo...
Vadim Gindin
08:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
About the window clearing, I don't think this has anything to do with the toggle-box. We will work it in another task. Greg Shah
08:34 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean.
I'm post...
Vadim Gindin
08:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these fields in @ToggleBox.in... Vadim Gindin
08:17 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean. Greg Shah
07:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > But 4GL clears the window and P2J - does not. Should I fix it?
>
> Do you mean that the fram...
Vadim Gindin
07:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> But 4GL clears the window and P2J - does not. Should I fix it?
Do you mean that the frame f is still displayed i...
Greg Shah
04:02 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg, thank you! "F2" is mapped on "GO" event in GUI. I've tested GO event. It works for toggle-box. Trigger @on go o... Vadim Gindin
03:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > >
> > > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @...
Vadim Gindin
04:54 PM Feature #2252: implement GUI client support
Code Review ca_upd20150507a.zip
I'm generally fine with the changes. Unfortunately, your nice changes are going t...
Greg Shah
03:57 PM Feature #2252: implement GUI client support
Fixes following issues:
# frame title in GUI - centered vertically and fixed frame height problems. Also, it uses th...
Constantin Asofiei

05/06/2015

07:00 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> So it is not fixed yet.. Should I work on it now anyway?
Actually, yes. Constantin's changes are already checke...
Greg Shah
06:59 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> >
> > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @on go of lll@ will not...
Greg Shah
06:24 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
"2. Make sure ASSIGN and SCREEN-VALUE after WAIT-FOR work."
I've checked. P2J works as 4GL. Here is my test case:
...
Vadim Gindin
05:59 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > I mean that the last message "after .." is not printed, i.e. execution is stopped before this s...
Vadim Gindin
05:56 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> I mean that the last message "after .." is not printed, i.e. execution is stopped before this statement.
The pro...
Greg Shah
05:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to ...
Vadim Gindin
04:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to @ENABLE@ + @WAIT-FOR... Greg Shah
04:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
There is a strange thing with UPDATE statement for toggle-box. Have a look at this procedure:... Vadim Gindin
11:11 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
In regard to the WIDTH/HEIGHT issue, Hynek reported the following:
> I tested your sample. The problem doesn't see...
Greg Shah
10:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150506a.zip
I'm OK with the code so far.
Since MAJIC doesn't use toggle-boxes and your cha...
Greg Shah
10:40 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> This test works fine (P2J like Progress). both toggle-boxes are checked and message area contains the string "yes".... Greg Shah
08:43 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I forgot to add, that at this moment WIDTH/HEIGHT attributes are calculated improperly at this moment. Here is my cur... Vadim Gindin
08:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. Tha...
Vadim Gindin
08:12 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Vadim Gindin wrote:
> > If user presses mouse on checkbox and starts dragging the mouse over it ...
Vadim Gindin
12:08 PM Feature #2422: add features to BROWSE
Implemented REFRESHABLE and ADD-LIKE-COLUMN. Committed to bzr rev 10848. Stanislav Lomany
09:35 AM Feature #2422: add features to BROWSE
> So CREATE-ON-ADD is added to the GUI list.
OK, please add notes to #2564 so that this is not missed.
Also: if...
Greg Shah
09:52 PM Feature #2422: add features to BROWSE
About @CREATE-ON-ADD@. At this point it cannot be implemented because:
1. I do not quite understand what it does. He...
Stanislav Lomany

05/05/2015

05:09 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is...
Greg Shah
05:07 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. That event is probably ... Greg Shah
01:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've checked attributes and events. P2J works as Progress. VALUE-CHANGED event is not working for both Progress and P... Vadim Gindin
10:13 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is colored to some other ... Vadim Gindin
03:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Static case works fine: both P2J and Progress shows toggle-box in one row after the button "exit". Vadim Gindin
03:25 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than...
Constantin Asofiei
03:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than Progress will show tog... Vadim Gindin
02:18 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Just for documenting purpose. This testcase also shows wrong placement of toggle-box. Progress shows toggle-box at th... Vadim Gindin

05/04/2015

02:30 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I'm working on WIDTH/HEIGHT attributes and after the last update this attributes became 0. Don't you know why? And wh... Vadim Gindin
11:01 AM Feature #2422: add features to BROWSE
20150504a looks OK to me from the persistence side. Eric Faulhaber
09:35 AM Feature #2422: add features to BROWSE
Code Review svl_upd20150504a.zip
1. In @ThinClient.queryClosed()@ and @ThinClient.refreshScrollRow()@, the call to...
Greg Shah
03:19 AM Feature #2422: add features to BROWSE
All the flaws fixed. Stanislav Lomany
10:02 AM Feature #2446 (Closed): implement BUTTON and IMAGE GUI widgets (runtime and conversion support)
Greg Shah
10:01 AM Feature #2545 (Closed): add support for specially named button images
Greg Shah
10:00 AM Feature #2545: add support for specially named button images
@evl_upd20150503a.zip@ has been committed as @10847@. Eugenie Lyzenko
09:45 AM Feature #2545: add support for specially named button images
Greg Shah wrote:
> Code Review evl_upd20150503a.zip
>
> It looks good. Check it in when it passes testing.
Th...
Eugenie Lyzenko
09:27 AM Feature #2545: add support for specially named button images
Code Review evl_upd20150503a.zip
It looks good. Check it in when it passes testing.
Greg Shah
10:01 AM Bug #2452 (Closed): Button label resize fails with error 4054
Greg Shah
09:48 AM Bug #2452: Button label resize fails with error 4054
The fix for this issue is included into update for task #2545 for commit and distribute, @evl_upd20150503a.zip@. Pass... Eugenie Lyzenko

05/03/2015

06:31 PM Feature #2545: add support for specially named button images
The code is the merge with @10846@ and small change to label cutting approach. With the recent changes the frame widt... Eugenie Lyzenko
09:40 AM Feature #2545: add support for specially named button images
Please merge to bzr 10846 and get this tested. Greg Shah
01:23 PM Feature #2422: add features to BROWSE
Code Review svl_upd20150503a.zip
Eric: please review.
1. Shouldn't there be a @methods_attributes.rules@ change...
Greg Shah
12:32 PM Feature #2422: add features to BROWSE
Update for review - REFRESHABLE and ADD-LIKE-COLUMN. Stanislav Lomany
03:33 AM Feature #1790: implement menu support
There were 2 failed test that was not being recreated during manual testing. So, I've committed current changes with ... Vadim Gindin

05/02/2015

02:35 PM Feature #1790: implement menu support
> Should I ignore this error?
If I understand correctly, you are saying that your manual testing could not recreat...
Greg Shah
02:54 AM Feature #1790: implement menu support
So, I've checked gso_269. It also is not reproduced as tc_code_employees_261 manually (as tc_code_employees_264 in th... Vadim Gindin
01:39 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim, what update are these results from? Because I can recreate it with your 0430a.zip...
Vadim Gindin
08:50 PM Feature #2546: implement combo-box widget in GUI
This is the next step for review in combo-box GUI widget implementation. So what it can:
1. Complete keyboard suppor...
Eugenie Lyzenko

05/01/2015

04:54 PM Feature #1790: implement menu support
You can check in your code as soon as it passes, unless you have to make some other fix besides the history entry men... Greg Shah
04:15 PM Feature #1790: implement menu support
Code Review vig_upd20150501b.zip
Please just add a history entry to @MenuWidget@. Otherwise it looks good.
Greg Shah
03:52 PM Feature #1790: implement menu support
OK. There was some mess with that. I hope, you right, moreover my update passed successfully regression testing befor... Vadim Gindin
12:44 PM Feature #1790: implement menu support
Vadim, what update are these results from? Because I can recreate it with your 0430a.zip but not with 0430b.zip.
A...
Constantin Asofiei
11:11 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > I've checked gso_17 test, the first ...
Constantin Asofiei
11:09 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've checked gso_17 test, the first failed test and found the f...
Vadim Gindin
04:39 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've checked gso_17 test, the first failed test and found the following. During the test there...
Constantin Asofiei
04:38 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> There are a lot of similar errors where generated files differ from expected. But there are an...
Constantin Asofiei
02:24 AM Feature #1790: implement menu support
There are a lot of similar errors where generated files differ from expected. But there are another errors exist. I'v... Vadim Gindin
02:00 AM Feature #1790: implement menu support
I've checked gso_17 test, the first failed test and found the following. During the test there are gso_17.txt is gene... Vadim Gindin
01:03 AM Feature #1790: implement menu support
This update (after merge) failed regression testing: gso_tests (19) tc_tests (24). I'm working on it. Vadim Gindin
03:34 PM Feature #2545: add support for specially named button images
Code Review evl_upd20150501a.zip
It's good.
> Now the conversion testing is not required because is was already...
Greg Shah
03:25 PM Feature #2545: add support for specially named button images
This is the merge with @10845@. Now the conversion testing is not required because is was already done(as part of the... Eugenie Lyzenko
11:14 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Greg Shah wrote:
> Code Review ca_upd20150501a.zip
>
> It looks good. Check it in when it passes.
Committed rev...
Constantin Asofiei
10:35 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Code Review ca_upd20150501a.zip
It looks good. Check it in when it passes.
Greg Shah
05:44 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Merged version of 0421a.zip with rev 10844. Conversion testing passed, runtime testing is starting (it should pass t... Constantin Asofiei
05:10 AM Feature #2564: implement GUI BROWSE widget
Addition to the list:
MIN-HEIGHT-CHARS
SORT - I think that actually means implementation of drop-down cells
Stanislav Lomany
05:06 AM Feature #2422: add features to BROWSE
> If I understand correctly, then we have the following categories:
>
> 1. features currently being implemented
K...
Stanislav Lomany
05:04 AM Feature #2422: add features to BROWSE
Here is the list of all remaining features:
*GUI-specific*
FIT-LAST-COLUMN/EXPANDABLE
NO-COLUMN-SCROLLING
ROW...
Stanislav Lomany
04:04 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review ca_upd20150429a.zip
>
> This is a really good update. I suspect it is cleaning up...
Constantin Asofiei

04/30/2015

04:53 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review vig_upd20150501a.zip
It is a very good start.
1. In @ToggleBoxGuiImpl.draw()@, the 3 TODOs should b...
Greg Shah
03:23 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> After I set BGCOLOR I saw real area, occupied by widget and when I manually changed width and ...
Constantin Asofiei
03:16 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is the current update merged with the latest revision. Please review shortly. The changes are small. Vadim Gindin
10:28 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
That was my procedure:... Vadim Gindin
10:27 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here are the results. Thank you very much! After I used NO-LABELS dimensions became concurred:
width-chars: 5
width...
Vadim Gindin
04:41 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please add support for the following:
+Options+
WIDGET-ID - all widgets, see #1791 for some prior research, we ...
Greg Shah
03:17 PM Feature #2567 (Closed): add misc widget support part 2: more options, attributes and methods
Greg Shah
04:22 PM Feature #1834: implement direct manipulation (drag and drop)
Implement runtime support for the following attributes:
MOVABLE
RESIZABLE
SELECTABLE
Conversion support for t...
Greg Shah
03:48 PM Feature #1800 (Closed): add some missing widget options
Most of this work got done with the button, rectangle and image widget implementations. The remaining work will be d... Greg Shah
03:48 PM Feature #2032 (Closed): runtime support for widget options
Greg Shah
03:47 PM Feature #2031 (Closed): conversion support for remaining widget options
Greg Shah
03:08 PM Feature #1796 (WIP): implement full GUI layout support
Greg Shah
02:23 PM Feature #2566 (Closed): implement LOAD-MOUSE-POINTER method
Greg Shah
02:22 PM Feature #2565 (Closed): implement runtime support for the SET-WAIT-STATE method
Greg Shah
02:20 PM Feature #2422: add features to BROWSE
I've checked the @GET-BROWSE-COLUMN@ method and although it is implemented, I see that it is supposed to return a @HA... Greg Shah
02:17 PM Feature #2422: add features to BROWSE
I've added the GUI-specific options, attributes and methods to the #2564 task (creation of the GUI BROWSE widget).
...
Greg Shah
02:05 PM Feature #2564: implement GUI BROWSE widget
The following options, attributes and methods were investigated in #2422. They were determined to be GUI-specific. ... Greg Shah
01:56 PM Feature #2564 (Closed): implement GUI BROWSE widget
Greg Shah
01:11 PM Feature #2563: implement GUI EDITOR widget
Please note that @MAX-CHARS@, @RETURN-INSERTED@ and @WORD-WRAP@ are attributes which need to be implemented as part o... Greg Shah
01:07 PM Feature #2563 (Closed): implement GUI EDITOR widget
Greg Shah
12:39 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
1. I hope to finish tomorrow or at the weekend.
2. All features mentioned in the task will be done.
3. I've promise...
Igor Skornyakov
12:30 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please provide a status update with:
1. The expected time when your next update will be ready for review.
2. A su...
Greg Shah
12:29 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor checked in ias_upd20150411a.zip as bzr rev 10833 on April 13, 2015. Greg Shah
12:26 PM Bug #2558: generated frame getter/setter names can conflict with existing CommonFrame APIs
If you have a @COMBO-BOX@ widget named 'x' then in the generated code for the enclosing static frame there will be me... Greg Shah
10:45 AM Feature #1790: implement menu support
Code Review vig_upd20150430b.zip
This is good.
Greg Shah
10:41 AM Feature #1790: implement menu support
Greg Shah wrote:
> Code Review vig_upd20150430a.zip
>
> 1. In @WidgetConfig.applyConfig()@, shouldn't the assignm...
Vadim Gindin
10:27 AM Feature #1790: implement menu support
Code Review vig_upd20150430a.zip
1. In @WidgetConfig.applyConfig()@, shouldn't the assignment be done using @Confi...
Greg Shah
10:31 AM Bug #2452: Button label resize fails with error 4054
Code Review evl_upd20150429e.zip
I like it!
Greg Shah
10:04 AM Feature #2252: implement GUI client support
Code Review ca_upd20150429a.zip
This is a really good update. I suspect it is cleaning up a lot of problems.
1...
Greg Shah

04/29/2015

04:57 PM Feature #2560 (Closed): implement GUI DIALOG-BOX support
Greg Shah
04:56 PM Feature #2559 (Closed): implement ALERT-BOX support
Greg Shah
04:55 PM Feature #1827: implement a replacement for the Windows help viewer
This is no longer needed in M12. Greg Shah
04:22 PM Bug #2452: Button label resize fails with error 4054
>OK, let's go with this as is for now.
Before I've got this message I prepared one more improved version of the sa...
Eugenie Lyzenko
04:03 PM Bug #2452: Button label resize fails with error 4054
OK, let's go with this as is for now.
Pause testing on this until Constantin's changes are checked in. Then merge...
Greg Shah
03:52 PM Bug #2452: Button label resize fails with error 4054
Greg Shah wrote:
> Code Review evl_upd20150429d.zip
>
> It is good.
>
> Hynek: any concerns?
I think it is ...
Hynek Cihlar
03:37 PM Bug #2452: Button label resize fails with error 4054
@GenericWidget.setLabel()@ is becoming a little overblown. It should be split into several parts - label validation, ... Hynek Cihlar
03:36 PM Bug #2452: Button label resize fails with error 4054
Code Review evl_upd20150429d.zip
It is good.
Hynek: any concerns?
Greg Shah
03:17 PM Bug #2452: Button label resize fails with error 4054
>Greg Shah wrote:
> Please add a TODO in that method to explain this so that we can "remember" it easily.
Adding ...
Eugenie Lyzenko
03:01 PM Bug #2452: Button label resize fails with error 4054
Code Review evl_upd20150429c.zip
I like your original idea of avoiding more type checking in @GenericWidget.setLab...
Greg Shah
02:39 PM Bug #2452: Button label resize fails with error 4054
>Does the 4GL remove the & characters from the label before it calculates that the label is too big to fit? See @Gene... Eugenie Lyzenko
02:19 PM Bug #2452: Button label resize fails with error 4054
Code Review evl_upd20150429b.zip
Does the 4GL remove the @&@ characters from the label before it calculates that t...
Greg Shah
02:11 PM Bug #2452: Button label resize fails with error 4054
This update for review has fix for button resizing. I have modified @ButtonWidget@ class adding override for @Generic... Eugenie Lyzenko
12:39 PM Bug #2452: Button label resize fails with error 4054
Yes, it is a good idea to include it in the #2545 update. Greg Shah
12:32 PM Bug #2452: Button label resize fails with error 4054
Greg Shah wrote:
> This task can be worked on now.
OK. Soon I will have the fix. Can I include it into update pen...
Eugenie Lyzenko
09:36 AM Bug #2452: Button label resize fails with error 4054
This task can be worked on now. Greg Shah
03:32 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Here is the following result of WIN32 API calls:
> 8 - COLOR_WINDOWTEXT – the color of the "c...
Constantin Asofiei
03:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is the following result of WIN32 API calls:
8 - COLOR_WINDOWTEXT – the color of the "check" and the color of th...
Vadim Gindin
11:53 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
One other thing to remember: in Windows a toggle-box (or "check-box" in WIN32 terms) is actually a type of WIN32 butt... Greg Shah
10:00 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> It is an instruction how to change system colors using Visual Basic.
The code would be simpler to do it in C and...
Greg Shah
03:19 PM Feature #2252: implement GUI client support
FYI, the issue Vadim was facing was related to project setup. Hynek Cihlar
02:34 PM Feature #2252: implement GUI client support
Attached is replacement of ca_upd20150406c.zip (note 865), frame layout and misc GUI fixes:
* Rectangle(Point, Dimen...
Constantin Asofiei
12:01 PM Feature #2252: implement GUI client support
hc_upd20150429b.zip committed to bzr rev 10843. Hynek Cihlar
11:38 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The attached fixes GUI window positioning. Only GUI code is affected. Please review.
The chan...
Constantin Asofiei
11:35 AM Feature #2252: implement GUI client support
The attached fixes GUI window positioning. Only GUI code is affected. Please review. Hynek Cihlar
11:26 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Please post some details about the issue here, if you haven't solved it yet :).
This ...
Hynek Cihlar
11:11 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin Asofiei wrote:
> > > > H...
Constantin Asofiei
11:09 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek,
> > > Regarding the GU...
Hynek Cihlar
11:07 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek,
> > Regarding the GUI window problems, I think the main...
Constantin Asofiei
10:48 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek,
> Regarding the GUI window problems, I think the main issue is in WindowGuiImpl,...
Hynek Cihlar
09:58 AM Feature #2252: implement GUI client support
Hynek,
Regarding the GUI window problems, I think the main issue is in WindowGuiImpl, where @moveBy@ was using inval...
Constantin Asofiei
02:51 PM Feature #1790: implement menu support
Here is the merged update. I didn't check GSO 269 test by hand because I already updated p2j project from trunk with ... Vadim Gindin
04:07 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> We can assume that current update has passed regression testing. Only 2 tests are failed: gso_...
Constantin Asofiei
04:05 AM Feature #1790: implement menu support
We can assume that current update has passed regression testing. Only 2 tests are failed: gso_269 and tc_job_002. Sho... Vadim Gindin
11:49 AM Bug #2558 (New): generated frame getter/setter names can conflict with existing CommonFrame APIs
Igor Skornyakov
10:10 AM Feature #2422: add features to BROWSE
> I assumed that it should be a dynamic widget. Is that correct?
I doubt it. Unfortunately, the 4GL docs suggest ...
Greg Shah
01:13 AM Feature #2422: add features to BROWSE
I need to create a browse column.
# I assumed that it should be a dynamic widget. Is that correct? I've created it u...
Stanislav Lomany
09:35 AM Feature #2545: add support for specially named button images
Code Review evl_upd20150429a.zip
The merge looks good.
Constantin has an update that will be checked in before ...
Greg Shah
07:34 AM Feature #2545: add support for specially named button images
This is merge with @10842@ code base to be ready to regression testing. Eugenie Lyzenko
08:02 PM Feature #2545: add support for specially named button images
Now I can merge @evl_upd20150422c.zip@ with 10841 and start testing, OK? Eugenie Lyzenko
01:40 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The mouse handling is not yet working. Moreover moving mouse in application workspace close...
Constantin Asofiei
09:41 PM Feature #2546: implement combo-box widget in GUI
This is another in progress update for review to keep you informed about the implementation. I have separated GUI par... Eugenie Lyzenko

04/28/2015

07:13 PM Feature #2252: implement GUI client support
hc_upd20150428b.zip committed to revision 10841. Hynek Cihlar
06:51 PM Feature #2252: implement GUI client support
The attached is a replacement of hc_upd20150428a.zip. It contains a trivial fix and passes Majic regression tests.
S...
Hynek Cihlar
09:08 AM Feature #2252: implement GUI client support
Code Review hc_upd20150428a.zip
It looks fine. If it passes, you can check it in.
Greg Shah
06:02 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> It's good. I have my "fingers crossed" that regression testing goes well.
The test ended with...
Hynek Cihlar
06:47 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> I can't logon to windev01 right now and I don't have easy access to a windows system. But I'm qu...
Vadim Gindin
04:22 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I can't logon to windev01 right now and I don't have easy access to a windows system. But I'm quite sure that you ca... Greg Shah
03:03 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> > How can I change some system color, as you advise?
>
> Isn't there something in the Control ...
Vadim Gindin
02:49 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > ..
> > Vadim Gindin wrote:
> > > 3. I tried to draw objects w...
Constantin Asofiei
02:34 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> How can I change some system color, as you advise?
Isn't there something in the Control Panel that allows you to...
Greg Shah
02:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> ..
> Vadim Gindin wrote:
> > 3. I tried to draw objects with sizes equal to source. Is...
Vadim Gindin
02:17 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> ..
> > 2. How to calculate real colors for checkbox lines? I just try them intuitively.
>
> T...
Vadim Gindin
03:41 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> 1. When I'm going between checkboxes I've faced with view affect (see attached image). Why it ...
Constantin Asofiei
03:56 PM Feature #1790: implement menu support
Code Review vig_upd20150429a.zip
I'm good with this approach.
It is worth running regression testing on this up...
Greg Shah
02:09 PM Feature #1790: implement menu support
I've fixed it, by implementing of @AbstractWidget.syncWithConfig()@ method and also in @AbstractWidget.initialize()@ ... Vadim Gindin
02:27 PM Feature #2546: implement combo-box widget in GUI
> I prefer the ChUI and GUI specifics to be completely separated(of course there can be an exceptions). Is it accept... Greg Shah
02:15 PM Feature #2546: implement combo-box widget in GUI
>I don't really understand what you are saying here. Are you saying that the GUI support will require the ChUI code t... Eugenie Lyzenko
09:10 AM Feature #2546: implement combo-box widget in GUI
I don't really understand what you are saying here. Are you saying that the GUI support will require the ChUI code t... Greg Shah
11:09 PM Feature #2546: implement combo-box widget in GUI
This is the fist step of the drop-down implementation for GUI. But the analysis is complete. Here is the painting way... Eugenie Lyzenko

04/27/2015

07:16 PM Feature #2252: implement GUI client support
Code Review hc_upd20150427b.zip
It's good. I have my "fingers crossed" that regression testing goes well.
Greg Shah
06:28 PM Feature #2252: implement GUI client support
The attached update replaces hc_upd20150424h.zip.
Fixes redraw problem with multi selection lists (and radio buttons...
Hynek Cihlar
03:42 PM Feature #2252: implement GUI client support
Actually you are right, @formatUnchanged@ will always be @true@ when called from @afterConfigUpdate@ as it was @syncW... Hynek Cihlar
03:37 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, what about this case? Are you sure @formatUnchaged@ is computed properly?
> [......
Hynek Cihlar
02:51 PM Feature #2252: implement GUI client support
Hynek, what about this case? Are you sure @formatUnchaged@ is computed properly?... Constantin Asofiei
05:10 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please merge this code with the latest version in bzr. Otherwise the code review is too difficult.
> 1. When I'm ...
Greg Shah
04:50 PM Feature #1790: implement menu support
> but I found that at the moment of initialization config().popupMenuId has no value
I guess that only a dynamic w...
Greg Shah
04:42 PM Feature #1790: implement menu support
Code Review vig_upd20150427a.zip
I'm fine with the changes.
Greg Shah
01:51 PM Feature #1790: implement menu support
Greg Shah wrote:
> Code Review vig_upd20150423a.zip
>
> This is quite good.
>
> 1. In @Menu.java@, what is the...
Vadim Gindin
01:29 PM Feature #1790: implement menu support
Please address my issues 1 and 3 from the code review in note 316. Post that update here. Hopefully it is the final... Greg Shah
01:11 PM Feature #1790: implement menu support
The task #2557 is created. Can I run regression testing for current update? If yes, should I add some menu scenarios ... Vadim Gindin
12:29 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Should I include "message hiding" and "pausing bugs" there or fix it?
Yes, include these two ...
Constantin Asofiei
11:15 AM Feature #1790: implement menu support
Should I include "message hiding" and "pausing bugs" there or fix it? Vadim Gindin
10:43 AM Feature #1790: implement menu support
> My suggestion is to finish the menu's drawing/event/etc first and work on this in a second phase, as some refactori... Greg Shah
04:00 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Some other thoughts about my notes in 325: when attaching/detac...
Constantin Asofiei
01:09 PM Bug #2557: Fix MENUBAR layouting in a window
Current MENUBAR implementation has several layout problems, that should be solved in this task.
# If source proced...
Vadim Gindin
12:43 PM Bug #2557 (New): Fix MENUBAR layouting in a window
Vadim Gindin
05:24 AM Feature #1811: implement the AJAX client driver
>We can send the image data as a byte[] using the web socket. This is simple, clean and has not additional security i... Anton Breaur
03:47 AM Feature #2556: add support for COLOR statement in GUI
There's more than just drawing related to colors. When COLOR ... NORMAL/INPUT/MESSAGES is used, in GUI this affects ... Constantin Asofiei
03:28 AM Feature #2556 (New): add support for COLOR statement in GUI
Constantin Asofiei

04/26/2015

03:50 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Some other thoughts about my notes in 325: when attaching/detaching the menubar, the "wo...
Vadim Gindin
12:48 PM Feature #2252: implement GUI client support
Code Review hc_upd20150424h.zip
@ScrollContainer@ is missing a history entry. Otherwise this update looks very good.
Greg Shah

04/25/2015

09:09 PM Feature #2252: implement GUI client support
The attached is a replacement of hc_upd20150424g.zip and fixes javadoc warnings. Hynek Cihlar
09:01 PM Feature #2252: implement GUI client support
The attached is a replacement of hc_upd20150424f.zip and adds some more javadocs. Hynek Cihlar
08:36 PM Feature #2252: implement GUI client support
Renamed hc_upd20140424f.zip to hc_upd20150424f.zip. Hynek Cihlar
08:34 PM Feature #2252: implement GUI client support
The attached update is a replacement of hc_upd20150421c.zip. It contains changes based on the last review, Majic regr... Hynek Cihlar

04/24/2015

03:23 PM Feature #1790: implement menu support
Some other thoughts about my notes in 325: when attaching/detaching the menubar, the "workspace" area were drawing is... Constantin Asofiei
03:15 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Yes, in P2J. You can use my last update.
I think the cause is that we are pushing the entire ...
Constantin Asofiei
02:42 PM Feature #1790: implement menu support
Yes, in P2J. You can use my last update. Vadim Gindin
02:41 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> My question is not about MENU-DROP now. I use the following procedure:
> [...]
> I found yes...
Constantin Asofiei
02:39 PM Feature #1790: implement menu support
My question is not about MENU-DROP now. I use the following procedure:... Vadim Gindin
02:35 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin, could you advice my why message (that is just before WAIT-FOR) is cleared when men...
Constantin Asofiei
02:32 PM Feature #1790: implement menu support
Constantin, could you advice my why message (that is just before WAIT-FOR) is cleared when menu is drawn? In analogic... Vadim Gindin
02:08 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > ..
> > I think @MENU-DROP@ acts like an OS event, the same way...
Constantin Asofiei
02:02 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> ..
> I think @MENU-DROP@ acts like an OS event, the same way i.e. @WINDOW-CLOSE@ acts. ...
Vadim Gindin

04/23/2015

05:08 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Today I analyzed the case of nested frames and some other corner cases. Hopefully now we have a complete picture.
Le...
Igor Skornyakov
02:57 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> > > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1....
Constantin Asofiei
02:38 PM Feature #1790: implement menu support
Code Review vig_upd20150423a.zip
This is quite good.
1. In @Menu.java@, what is the requirement for import of @...
Greg Shah
02:12 PM Feature #1790: implement menu support
At the first time I met this bug I thought that it is related to MENU-DROP. Now I think it is not related. Vadim Gindin
02:09 PM Feature #1790: implement menu support
Is the pause behavior related to MENU-DROP? Greg Shah
02:08 PM Feature #1790: implement menu support
PAUSE behavior fix is left. The current bug is the following. In Constantin's procedure message "bogus message so tha... Vadim Gindin
01:57 PM Feature #1790: implement menu support
I will look at the code next.
What is left to do to make ChUI menus fully functional?
Greg Shah
01:27 PM Feature #1790: implement menu support
I didn't find another way beside to make hardcode fix for MENU-DROP event case for LAST-EVENT attributes. All attribu... Vadim Gindin
10:01 AM Feature #1790: implement menu support

> > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1. This means you woul...
Vadim Gindin
09:55 AM Feature #1790: implement menu support
Greg Shah wrote:
> > Here is the sample output string for one trigger run:
> >
> > @MENU-DROP -1 PROGRESS 1079...
Vadim Gindin
08:52 AM Feature #1790: implement menu support
> Here is the sample output string for one trigger run:
>
> @MENU-DROP -1 PROGRESS 1079 MENU-DROP PSEUDO-WIDGET...
Greg Shah
08:14 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> There are some interesting information in _langref_ in the definition of ON statement:
> [......
Constantin Asofiei
07:54 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> About "no pause on RETURN" strange, but after I ran your procedure, choose sub-menu "Orwell", ...
Constantin Asofiei
04:07 AM Feature #1790: implement menu support
My MENU-DROP trigger is the following:... Vadim Gindin
03:14 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin, I see the @ScrollableListGuiImpl@ class implemented. Is it the GUI version of t...
Constantin Asofiei
08:30 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150422b.zip
It is a good start.
Greg Shah
08:11 PM Feature #2546: implement combo-box widget in GUI
This is the current update for @combo-box@ implementation in addition to screens from P2J and 4GL. The drop-down butt... Eugenie Lyzenko
08:33 PM Feature #2545: add support for specially named button images
Code Review evl_upd20150422c.zip
It looks good.
Greg Shah
08:31 PM Feature #2545: add support for specially named button images
Greg Shah wrote:
> Code Review evl_upd20150422a.zip
>
> Please move the @public static final@ members above the @...
Eugenie Lyzenko
08:22 PM Feature #2545: add support for specially named button images
Code Review evl_upd20150422a.zip
Please move the @public static final@ members above the @private@ members. And t...
Greg Shah

04/22/2015

07:49 PM Feature #2545: add support for specially named button images
The update has minor @javadoc@ comment fixes and making some constant public to be used in @ComboBoxGuiImpl@ when the... Eugenie Lyzenko
06:50 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> I think this is a good example of the case when, instead of relying on a synchronization mecha...
Hynek Cihlar
06:47 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> So we have two options:
> # identify all cases which need to call super.afterConfigUpda...
Hynek Cihlar
06:20 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> And even if we make these changes, the widget's size does not get update. This is relat...
Constantin Asofiei
05:43 PM Feature #2252: implement GUI client support
Hynek, by any chance, do you have any FORMAT-related issues? Because this test is not working:... Constantin Asofiei
10:12 AM Feature #2252: implement GUI client support
Code Review hc_upd20150421c.zip
Everything looks good. I appreciate the improved comments and javadoc. It is ver...
Greg Shah
05:13 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> You're welcome. But, are you sure you need FRAME:ROW/FRAME:BOX attributes? If the form...
Igor Skornyakov
05:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple...
Constantin Asofiei
04:46 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple:
@<new value>@ = @min(<a...
Igor Skornyakov
12:12 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> You can experiment with boxed or no-boxed frames, other widget/frame positions; if you f...
Igor Skornyakov
11:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, what I think is happening is this:
# the combo's drop box (when drawn) can not exceed beyond the status area. ...
Constantin Asofiei
11:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> The algorithm maybe accounts for the widget border, at least in the case of @N2@?
Well, bot...
Igor Skornyakov
10:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The algorithm maybe accounts for the widget border, at least in the case of @N2@? Hynek Cihlar
10:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Wow, that is not complicated at all. :)
I've added Hynek and Eugenie as watchers. Eugenie is working on @ComboBox...
Greg Shah
12:34 PM Feature #2546: implement combo-box widget in GUI
If the 4GL inherits the color from the container, then we need to do so as well.
If our result is incorrect becaus...
Greg Shah
12:14 PM Feature #2546: implement combo-box widget in GUI
>> I'm asking because currently our colors differs from what we have in 4GL.
>
>Please provide some specifics.
...
Eugenie Lyzenko
10:33 AM Feature #2546: implement combo-box widget in GUI
Good headway. Would you please also attach the Windows 4GL version of this same procedure?
> The plan is to attac...
Greg Shah
09:58 PM Feature #2546: implement combo-box widget in GUI
The attached sample is the current state of the GUI implementations. The plan is to attach drop-down button based on ... Eugenie Lyzenko
12:28 PM Feature #1790: implement menu support
> Are there some artificial events like MENU-DROP, that also have no key?
Yes, everything in @Keyboard.evNames1@. ...
Greg Shah
12:24 PM Feature #1790: implement menu support
I've tried do not use I/O operations in MENU-DROP trigger and accumulate strings in a global array and got the same r... Vadim Gindin
11:55 AM Feature #1790: implement menu support
Greg Shah wrote:
> > @keycode("MENU-DROP")@ is -1. Why?
>
> I assume you are describing the 4GL here? I guess th...
Vadim Gindin
10:55 AM Feature #1790: implement menu support
> @keycode("MENU-DROP")@ is -1. Why?
I assume you are describing the 4GL here? I guess the reason is simply that ...
Greg Shah
11:07 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Code Review ca_upd20150421a.zip
I'm good with the changes.
Greg Shah
02:54 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
This version passed runtime testing (fixes problems in TC.setScreenBuffer).
Will retest/release after HC's config ...
Constantin Asofiei
09:55 AM Feature #2422: add features to BROWSE
> Because this is not a browse problem and I cannot fix it quickly, I'll return to it after all other browse work is ... Greg Shah
07:25 AM Feature #2422: add features to BROWSE
Conversion bug - two temp-tables with different labels / column labels are converted to the same @TempRecord@ class. ... Stanislav Lomany

04/21/2015

04:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Contrary to the 4GL docs the INNER-LINES attribute for the COMBO-BOX does have meaning in ChUI - it affects the heigh... Igor Skornyakov
04:03 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> I have Majic changes for review, should I post them here?
No, create a new task in the Majic ...
Constantin Asofiei
04:02 PM Feature #2252: implement GUI client support
I have Majic changes for review, should I post them here? Hynek Cihlar
03:08 PM Feature #2252: implement GUI client support
The attached replaces hc_upd20150420g.zip and contains changes based on the review, Majic regression fixes and improv... Hynek Cihlar
10:45 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review hc_upd20150420g.zip
>
> This is a really great step forward. Some comments and qu...
Hynek Cihlar
10:01 AM Feature #2252: implement GUI client support
Code Review hc_upd20150420g.zip
This is a really great step forward. Some comments and questions:
1. I don't u...
Greg Shah
09:16 PM Feature #2252: implement GUI client support
Attached is an update to the config refactoring work. The changes from last review are: worked-in comments, Majic reg... Hynek Cihlar
03:27 PM Feature #1790: implement menu support
There are some interesting information in _langref_ in the definition of ON statement:... Vadim Gindin
03:02 PM Feature #1790: implement menu support
A couple of questions about MENU-DROP event.
# @keycode("MENU-DROP")@ is -1. Why?
# @last-event:code@ is 1079. Wh...
Vadim Gindin
02:54 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Questions.
> > # How to duplicate double call of trigger?
> I...
Vadim Gindin
01:45 PM Feature #1811: implement the AJAX client driver
+Research Item+
*What is the best approach to provide web GUI client support for images as provided in the 4GL?*
...
Greg Shah
11:12 AM Feature #1811: implement the AJAX client driver
The following are the next development steps to implement the GUI web client:
# Much of the web-specific code for ...
Greg Shah

04/20/2015

02:59 PM Feature #2545: add support for specially named button images
> The only I can say was "stolen" is the size of the images (16x16) and how it looks.
This isn't stealing. Such ...
Greg Shah
02:58 PM Feature #2545: add support for specially named button images
Code Review evl_upd20150420a.zip
It is good.
Greg Shah
02:38 PM Feature #2545: add support for specially named button images
>1. In ButtonWidget change the import com.goldencode.p2j.ui.client.*; into import com.goldencode.p2j.ui.client.ImageH... Eugenie Lyzenko
02:03 PM Feature #2545: add support for specially named button images
Code Review evl_upd20150417a.zip
1. In @ButtonWidget@ change the @import com.goldencode.p2j.ui.client.*;@ into @im...
Greg Shah
01:41 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Questions.
> # How to duplicate double call of trigger?
I think you need to explicitly treat...
Constantin Asofiei
01:22 PM Feature #1790: implement menu support
I'm working on the last founded bug with pause. I've simplified testing procedure as it was possible:... Vadim Gindin

04/18/2015

04:33 PM Feature #2545: add support for specially named button images
All my button tests work fine with this update. So waiting for Hynek to checking in. Or may be there are the notes fr... Eugenie Lyzenko
08:28 PM Feature #2545: add support for specially named button images
This update for review is merged with the recent code base full support for prepackaged button images. 4 more icons h... Eugenie Lyzenko

04/17/2015

04:45 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> About 0417a.zip:
> * Please check the header for LogicalTerminal, is not merged properl...
Vadim Gindin
01:46 PM Feature #1790: implement menu support
About 0417a.zip:
* Please check the header for LogicalTerminal, is not merged properly.
* MenuItemWidget - don't ad...
Constantin Asofiei
12:46 PM Feature #1790: implement menu support
Here it is:... Vadim Gindin
11:42 AM Feature #1790: implement menu support
Here is my current update. Vadim Gindin
09:44 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during t...
Constantin Asofiei
09:33 AM Feature #1790: implement menu support
> P.S. I've change base classes of MenuItemWidget and MenuItemConfig to BaseEntity/BaseEntityConfig. But I can't do t... Greg Shah
03:57 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
Replacement of 0416c.zip. Fixed a regression and some other issues. Constantin Asofiei
02:50 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
> I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still... Greg Shah
02:39 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still u... Constantin Asofiei
02:14 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
Greg Shah wrote:
> Code Review ca_upd20150416c.zip
>
> It looks good. It may make sense to not check this in unt...
Constantin Asofiei
11:00 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Code Review ca_upd20150416c.zip
It looks good. It may make sense to not check this in until after Hynek checks in...
Greg Shah
03:15 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Very well, I implemented this for X attribute as well as it fol...
Hynek Cihlar
11:07 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Very well, I implemented this for X attribute as well as it follows the same logic.
Please up...
Constantin Asofiei
09:37 AM Feature #2422: add features to BROWSE
> I suggest to NOT implement the "weird" mode (1-7).
Agreed.
Greg Shah
03:56 AM Feature #2422: add features to BROWSE
Implemented SELECT-NEXT/PREV-ROW, MAX-DATA-GUESS and ROW-MARKERS. Committed to bzr rev 10839. Stanislav Lomany
08:18 PM Feature #2422: add features to BROWSE
The set or rules for REFRESHABLE. By the "repositioned row" I mean the last row the query was repositioned to.
h3. R...
Stanislav Lomany
09:40 PM Feature #2545: add support for specially named button images
The next step for review in prepackaged images support:
- the DEFINE BUTTON rule has been changes to add missing @SI...
Eugenie Lyzenko

04/16/2015

03:18 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
This update adds server-side support for FIRST/LAST-CHILD and finishes server-side support for PARENT.
Also, NEXT/PR...
Constantin Asofiei
05:58 AM Feature #1798 (WIP): implement full frame family support (parent-child relationships between frames)
> Window family support is needed as well. We can split that off into another task if that is worthwhile. Window fa... Constantin Asofiei
02:43 PM Feature #2451 (Closed): implement FILL-IN widget in GUI client
Greg Shah
11:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi...
Constantin Asofiei
10:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi...
Igor Skornyakov
10:33 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> I was looking for the annotated setter/getter
That annotation does look like it is missing in @CommonWidget.setF...
Greg Shah
10:17 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> @GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @Control...
Igor Skornyakov
10:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
@GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @ControlSetConfig.format@. Greg Shah
09:56 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> @ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that ...
Igor Skornyakov
10:14 AM Feature #2252: implement GUI client support
Very well, I implemented this for X attribute as well as it follows the same logic. Hynek Cihlar
09:50 AM Feature #2252: implement GUI client support
OK, this is not dead code. The problem the code was trying to fix was related to side-labels and changing the side-l... Constantin Asofiei
09:30 AM Feature #2252: implement GUI client support
This case brings you to a literal, although in P2J first-child doesn't yet work. I think that is really dead code, a... Constantin Asofiei
09:19 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @co...
Hynek Cihlar
09:11 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALI...
Constantin Asofiei
09:02 AM Feature #2252: implement GUI client support
Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALIGN_RIGHT@ condition. I ... Hynek Cihlar
08:34 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Greg Shah wrote:
> > > Alternatively I can introduce new method next to Widget.getId(), Widge...
Greg Shah
05:58 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229.
Correct. I've added notes ...
Constantin Asofiei
04:57 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> > Alternatively I can introduce new method next to Widget.getId(), Widget.getIdInt() maybe?
>
...
Hynek Cihlar
09:07 AM Feature #1790: implement menu support
I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during today's testing.
# The ...
Vadim Gindin
08:43 PM Feature #2545: add support for specially named button images
The update has basic implementation for prepackaged button images support. Several notes for what is ready:
- in 4GL...
Eugenie Lyzenko
08:34 PM Feature #2422: add features to BROWSE
The plan is fine. How long do you need for the implementation? Greg Shah

04/15/2015

07:59 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
@ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that not sufficient? Greg Shah
06:45 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
As far as I understand the SET-SELECTION method (and its companion SELECTION-TEXT attribute) for COMBO-BOX depends on... Igor Skornyakov
06:56 PM Feature #2422: add features to BROWSE
About REFRESHABLE. Typical use case of it is the following:
# Set it OFF.
# Make some repositions/re-open query, i....
Stanislav Lomany
12:31 PM Feature #2422: add features to BROWSE
Eric Faulhaber wrote:
> Stanislav Lomany wrote:
> > 3. Potentially there may be cases that fill-in state may differ...
Greg Shah
12:21 PM Feature #2422: add features to BROWSE
Code Review svl_upd20150415a.zip
I'm good with the changes. Please get them regression tested.
Greg Shah
07:32 AM Feature #2422: add features to BROWSE
I'll put here rules which are applied to MAX-DATA-GUESS:
* Its default value is 100.
* For preselect queries it equ...
Stanislav Lomany
06:25 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> And about the overhead: try to determine the CPU time/invocation count for your new aspe...
Hynek Cihlar
04:58 PM Feature #2252: implement GUI client support
BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229. Greg Shah
04:57 PM Feature #2252: implement GUI client support
Code Review ca_upd201504315c.zip
This is a really good update. The subject matter is tricky but you have implemen...
Greg Shah
03:42 PM Feature #2252: implement GUI client support
This is for the #2229, WINDOW:PARENT attribute. It adds runtime support for window families: for the WINDOW-MINIMIZE... Constantin Asofiei
12:23 PM Feature #2545: add support for specially named button images
OK, then the only thing I want you to change in the plan is to bypass app jar and local client filesystem searches wi... Greg Shah
11:24 AM Feature #2545: add support for specially named button images
>What is missing?
Loading an image(not default icon for main window) from @p2j.jar@ file.
Eugenie Lyzenko
11:02 AM Feature #2545: add support for specially named button images
> - store the arrow images on the client side p2j.jar file.
Yes.
> - use the current tools to load button image...
Greg Shah
10:58 AM Feature #2545: add support for specially named button images
>In the 4GL, does one specify the special image name as a quoted string ("btn-up-arrow") or as unquoted text btn-up-a... Eugenie Lyzenko
10:28 AM Feature #2545: add support for specially named button images
In the 4GL, does one specify the special image name as a quoted string (@"btn-up-arrow"@) or as unquoted text @btn-up... Greg Shah
 

Also available in: Atom