Activity
From 07/19/2015 to 08/17/2015
08/17/2015
- 06:00 PM Feature #2252: implement GUI client support
- Created branch 2451d from trunk rev 10923. Branch rev 10924/10925 is meant to fix some issues related to positioning...
- 05:33 PM Feature #2252: implement GUI client support
- Created branch 2563c from trunk rev 10923 with a fix for the editor drawing issue: @EditorGuiImpl.refresh@ must call ...
- 05:20 PM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> I'm reviewing the current z-order implementation in the GUI client. Some thoughts:
>
> 1. @Gu... - 04:09 PM Feature #1811: implement the AJAX client driver
- I'm reviewing the current z-order implementation in the GUI client. Some thoughts:
1. @GuiDriver.isOnTop()@ is no... - 02:22 PM Feature #1811: implement the AJAX client driver
- > Yes. Consider that we may have to add stroke styles in the future. And it is possible that we will have to use st...
- 10:40 AM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811q Revision 10925
The changes look good.
1. I think the call to @getFontHeight()@ in... - 10:27 AM Feature #1811: implement the AJAX client driver
- > Do you want to implement supports of this 4 style to draw rectangles shapes? We are using only rectangle shapes wit...
- 10:22 AM Feature #1811: implement the AJAX client driver
- Greg, please could clarify line stroke task. We can't use canvas native strokes because of lines and rectangles shape...
- 08:12 AM Feature #1811: implement the AJAX client driver
- The changes for paragraph layout/drawing are in rev 10925.
- 08:04 AM Feature #1811: implement the AJAX client driver
- You can commit it now.
- 07:37 AM Feature #1811: implement the AJAX client driver
- Greg, I've integrated the JS code from note 884 into p2j.screen.js and p2j.socket.js - let me know when I can commit it.
- 04:58 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Short question: I need to draw mnemonics using underlined font. I set @FontStyle.UNDERLINE@ fo... - 04:46 PM Feature #1790: implement menu support
- I'll fix these remarks these days. Short question: I need to draw mnemonics using underlined font. I set @FontStyle.U...
- 10:18 AM Feature #1790: implement menu support
- Code Review Task Branch 1790e Revision 10922
1. The @methods_attributes.rules@ change should be in the @load_descr... - 09:51 AM Feature #1790: implement menu support
- > By the way there is another one conversion bug: ';' remained in converted code for "ACCELERATOR" attribute.
Ple... - 04:17 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added NPE rethrow as per Constantin's suggestion.
Committed to the branch 2567a, revno 10952.
Regression test ... - 09:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor, please change the TC.processEventsWorker:14596 so that the NPE is re-thrown, not c... - 08:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, please change the TC.processEventsWorker:14596 so that the NPE is re-thrown, not consumed. After this, re-star...
- 02:33 PM Feature #1801: add some frame options
- All references to IDE-PARENT-HWND and IDE-WINDOW-TYPE have been removed from the current project. Do NOT implement s...
- 01:34 PM Feature #2546: implement combo-box widget in GUI
- >
> BTW, I assume that the tests I've posted in note 241 and 130 are OK now, correct?
Yes, the widget size in pi... - 01:22 PM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546c@ for review updated to revision @10926@.
>
> This is the final cleanu... - 11:13 AM Feature #2546: implement combo-box widget in GUI
- Task branch @2546c@ for review updated to revision @10926@.
This is the final cleanup/adjustment candidate. Please... - 11:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
- Please add @SCROLL-TO-ITEM()@ method support as part of this task.
- 10:18 AM Bug #2641: ENABLE ALL should be able to display an empty frame
- Testcase:...
- 10:12 AM Bug #2641 (New): ENABLE ALL should be able to display an empty frame
- 09:34 AM Bug #2640: NPE in registerPersistentTrigger
- Testcase:...
- 09:33 AM Bug #2640 (New): NPE in registerPersistentTrigger
- 06:56 AM Feature #1794: implement font support
- Rebased branch 1794c from trunk rev 10923 (new branch rev 10925).
08/16/2015
- 07:50 PM Feature #1791: implement dynamic UI support
- Rebased task branch 2026b from P2J trunk revision 10923.
- 09:29 AM Feature #1790: implement menu support
- Greg, thank you, I fixed it at the day before yesterday. By the way there is another one conversion bug: ';' remained...
- 03:22 AM Feature #2252: implement GUI client support
- Rebased task branch 2424c from P2J trunk revision 10923 (branch revision 10930).
08/15/2015
- 05:14 PM Feature #1811: implement the AJAX client driver
- This is a demo for the paragraph drawing - it follows the same rules as the Swing implementation.
- 01:12 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Have you seen it before testing branch 2567b? Because looks like a regression related t... - 12:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Were there some tests failed with this issue? Is it from the... - 12:37 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Were there some tests failed with this issue? Is it from the CTRL-C part? Because I don'... - 12:33 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > Please find the log attached
... - 09:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Please find the log attached
> And where did you see this? ... - 07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Please find the log attached
And where did you see this? In MAJIC testing or somewhere else? - 06:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > I've noticed that NPE is frequently happens in the @FillIn@ ... - 06:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> I've noticed that NPE is frequently happens in the @FillIn@ line 1211:
>
> [...]
>
> ... - 05:26 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10923 (new branch revision 10951).
Ready to merge, however the u... - 05:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- ctrl-c tests passed. Can I commit 2567a and updated tests?
Thank you. - 03:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- I've noticed that NPE is frequently happens in the @FillIn@ line 1211:...
- 03:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- After last changes in tests' parameters all main tests (except @tc_job_002@) passed OK. However in @gso_ctrlc_3way_te...
- 07:01 AM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546c@ from P2J trunk revision @10923@, new branch revision is @10925@.
- 08:49 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546c@ for review updated to revision @10923@.
This is the candidate. The entry field now also uses t...
08/14/2015
- 04:57 PM Feature #1811: implement the AJAX client driver
- > 1. Why is @import org.eclipse.jetty.websocket.api.annotations.WebSocket;@ needed in @GuiWebSocket@?
GuiWebSocket ex... - 03:34 PM Feature #1811: implement the AJAX client driver
- Code Review Task Brnach 1811q Revision 10923
The custom font support looks good. - 03:29 PM Feature #1811: implement the AJAX client driver
- Code Review Task Brnach 1811q Revision 10922
The cursor style changes look good. I only have these minor question... - 02:50 PM Feature #1811: implement the AJAX client driver
- Revision 10923 contains the changes for custom fonts in the web client. It contains the @@font-face@ approach with t...
- 02:45 PM Feature #1811: implement the AJAX client driver
- Constantin Asofiei wrote:
> Greg, I have some changes in p2j.fonts.js and p2j.socket.js related to custom font def -... - 02:42 PM Feature #1811: implement the AJAX client driver
- Greg, I have some changes in p2j.fonts.js and p2j.socket.js related to custom font def - may I commit them?
- 02:39 PM Feature #1811: implement the AJAX client driver
- The attached example shows that only the resize operation requires us to redraw bits that were already drawn to the c...
- 08:41 AM Feature #1811: implement the AJAX client driver
- Committed to 1811q, cursor style changes, rev 10922.
- 07:21 AM Feature #1811: implement the AJAX client driver
- MAJIC regression testing has passed for task branch 1811o. Manual Swing GUI testing and manual ChUI web testing did ...
- 04:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > I suggest to reduce the minimum value to 20. I will do it now and restart tests. If this will help the tests in th...
- 03:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Well, in this run there are no miracles. The tests which failed before failed again. However with the new version of ...
- 10:14 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10921 (new branch revision 10949).
Regression tests restarted - 10:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Before you run testing again, perhaps it is a good time to rebase? I think if the next run goes ... - 09:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Before you run testing again, perhaps it is a good time to rebase? I think if the next run goes well (and doesn't ov...
- 09:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- This is really strange but after (I'm not sure that because of) the harness test change (#2639) the results of the re...
- 08:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Agreed.
>
> Please create a new task in the Harness project. Post this information, create a ... - 08:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Agreed.
Please create a new task in the Harness project. Post this information, create a task branch and get this... - 05:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- It seems that there is a misprint in the @com.goldencode.harness.test.SendKey@. The format specification @SPEC3@ is:
... - 10:05 AM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546c@ from P2J trunk revision @10921@, new branch revision is @10922@.
- 04:16 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546c@ for review updated to revision @10921@.
The approach looks good - this... - 09:20 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546c@ for review updated to revision @10921@.
The idea behind is as I know the base for size measure... - 03:35 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, about @SwingEmulatedWindow.layoutParagraphWorker@ (we need an equivalent for the ...
08/13/2015
- 07:48 PM Feature #1811: implement the AJAX client driver
- Main regression testing has passed on the 2nd run (only GSO 237 failed, which passed on the 1st run, so this is consi...
- 04:54 PM Feature #1811: implement the AJAX client driver
- Sergey: your next task is to implement line stroke support. To review our current implementation, please search on @...
- 04:37 PM Feature #1811: implement the AJAX client driver
- Greg, please review my cursor local changes.
- 04:28 PM Feature #1811: implement the AJAX client driver
- Please do NOT commit any changes to 1811o. If it passes regression testing, I am going to merge revision 10962 to tr...
- 04:22 PM Feature #1811: implement the AJAX client driver
- Greg, would you mind if I committed the cursor changes in 1811o?
- 03:35 PM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> > but I haven't considered something: this duplicates the font definition both in the browser's p... - 03:27 PM Feature #1811: implement the AJAX client driver
- Constantin Asofiei wrote:
> Greg, this is a demo how to use @font-face@ to dynamically define a font. @base64@ works... - 03:11 PM Feature #1811: implement the AJAX client driver
- The first main regression testing run has completed. The only failures are tc_dc_slot_025, tc_job_clock_002 and tc_p...
- 01:41 PM Feature #1811: implement the AJAX client driver
- Greg
> > Thus I excluded menu/simple_sm.p because the conversion for it is failed.
>
> We don't have any conversi... - 01:27 PM Feature #1811: implement the AJAX client driver
- Constantin
> > For all other tests if it gets another key instead of SPACE the test becomes frozen (may be deadlock)
... - 01:15 PM Feature #1811: implement the AJAX client driver
- > Thus I excluded menu/simple_sm.p because the conversion for it is failed.
We don't have any conversion changes i... - 01:09 PM Feature #1811: implement the AJAX client driver
- Greg, this is a demo how to use @font-face@ to dynamically define a font. @base64@ works, but I haven't considered so...
- 01:07 PM Feature #1811: implement the AJAX client driver
- Thus I excluded menu/simple_sm.p because the conversion for it is failed. Please see above the attached log.
- 12:51 PM Feature #1811: implement the AJAX client driver
- Constantin, I need to retest because using old version of the testcase project, now my testcase project is up to date...
- 12:39 PM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> are failed to start for 1811o:
this is a conversion issue, @three-d@ attribute doesn't ... - 12:22 PM Feature #1811: implement the AJAX client driver
- These tests menu/popup_ext.p
window_sizing/create_empty_window.p
window_sizing/default_empty_window.p
window_sizin... - 12:12 PM Feature #1811: implement the AJAX client driver
- Greg, all found issues are already in trunk:
movie-ratings-dynamic.p
movie-ratings-static.p
- same as clipboard_... - 11:36 AM Feature #1811: implement the AJAX client driver
- simple_sm.p
- 11:26 AM Feature #1811: implement the AJAX client driver
- Nevermind, I just noticed the @testcases/uast/clipboard/clipboard_basic.p@ has different content...
- 11:24 AM Feature #1811: implement the AJAX client driver
- Greg, I can't convert this test, I get this:...
- 11:00 AM Feature #1811: implement the AJAX client driver
- Constantin, Greg I found a strange behaviour (1811o) of a editor field from my clipboard_basic.p but haven't compared...
- 10:52 AM Feature #1811: implement the AJAX client driver
- OK. I fixed the missing javadoc, added some comments and made some other code formatting cleanups in revision 10962....
- 10:17 AM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> Please do a quick code review. If the two of you don't see anything of concern, then I will run ... - 09:46 AM Feature #1811: implement the AJAX client driver
- Rebased task branch 1811o from P2J trunk revision 10920. The latest revision is now 10961. This does include some h...
- 02:34 AM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> We have two messages types related to a cursor, MSG_CURSOR_STATUS to hide it (chui mode) ... - 02:01 AM Feature #1811: implement the AJAX client driver
- From https://developer.mozilla.org/en-US/docs/Web/CSS/cursor the modern browsers support all interesting types of pre...
- 03:43 PM Feature #2252: implement GUI client support
- Hynek, about @SwingEmulatedWindow.layoutParagraphWorker@ (we need an equivalent for the web client) - this is suppose...
- 08:32 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> It looks like if accelerator is specified = than converted Java-code will contain empty line w... - 07:00 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > W... - 06:11 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > W... - 04:36 AM Feature #1790: implement menu support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > Why @ThinClient.pause()@ cleans the ... - 01:37 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Why @ThinClient.pause()@ cleans the message area and status lin... - 08:16 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Eugenie Lyzenko wrote:
> Try to run single @GSO 307@ test after DB restore. What is the result?
>
> In general if... - 07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Try to run single @GSO 307@ test after DB restore. What is the result?
In general if we are not sure the test does... - 06:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Something strange is going on with the test @gso_307@
With branch 2567a tt consistently fails on step 40 with messag... - 05:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10920 (new branch revision 10948).
- 07:40 AM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546c@ from P2J trunk revision @10920@, new branch revision is @10920@.
08/12/2015
- 07:12 PM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546c@ from P2J trunk revision @10919@, new branch revision is @10919@.
- 06:02 PM Feature #1790: implement menu support
- It looks like if accelerator is specified = than converted Java-code will contain empty line with the only ';' symbol...
- 05:45 PM Feature #1790: implement menu support
- Greg Shah wrote:
> I think that the KW_ACCEL attribute support still needs to be added to @methods_attributes.rules@... - 04:17 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Why @ThinClient.pause()@ cleans the message area and status line only for CHUI (isChui()==true... - 04:16 PM Feature #1790: implement menu support
- Ok, I'll fix it.
Why @ThinClient.pause()@ cleans the message area and status line only for CHUI (isChui()==true)? ... - 02:56 PM Feature #1790: implement menu support
- I think that the KW_ACCEL attribute support still needs to be added to @methods_attributes.rules@.
- 03:12 PM Feature #1811: implement the AJAX client driver
- Sergey: your next task is to investigate cursor management support for the GUI web client. This would be the backing...
- 03:06 PM Feature #1811: implement the AJAX client driver
- Tested web chui client to MAJIC server running on devsrv01 using branch 1811o rev 10950, menus and clipboard selectio...
- 02:08 PM Feature #1811: implement the AJAX client driver
- > I'm inclined in using the font-face tag to register the new font with a base64 encoded of the font bytes passed at...
- 01:50 PM Feature #1811: implement the AJAX client driver
- Revision 10953 contains js-side support for font/text metrics and text drawing; a new @p2j.fonts@ module was added, w...
- 01:47 PM Feature #1811: implement the AJAX client driver
- The following are some very useful articles on CSS z-order and positioning:
http://vanseodesign.com/css/css-positi... - 01:38 PM Feature #1811: implement the AJAX client driver
- And the example...
- 01:37 PM Feature #1811: implement the AJAX client driver
- I just checked in revision 10952 which finishes the first pass at window resize. Some factors about resize can be se...
- 01:32 PM Feature #1811: implement the AJAX client driver
- Greg, I have a second pass at the web font work (js-side). May I commit it?
- 01:31 PM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811o Revision 10951
It looks good. - 12:40 PM Feature #1811: implement the AJAX client driver
- Cleanup the code rev 10951.
- 10:13 AM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811o Revision 10950
The approach is good. My only concerns are related to coding standar... - 09:42 AM Feature #1811: implement the AJAX client driver
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > * @AbstractGuiDriver.setWindowLocation()@. This will cause all pending o... - 07:41 AM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> * @AbstractGuiDriver.setWindowLocation()@. This will cause all pending ops to be drawn and flushe... - 01:54 PM Feature #1791: implement dynamic UI support
- Rebased task branch 2026b from P2J trunk revision 10919.
- 09:26 AM Feature #1794: implement font support
- Rebased branch 1794c from trunk rev 10919 (new branch rev 10921).
08/11/2015
- 06:33 PM Feature #1791: implement dynamic UI support
- Plus issue:
9. Error on ctrl-c processing. - 09:31 PM Feature #1791: implement dynamic UI support
- Stanislav Lomany wrote:
> I'm making changes only to static query case:
> # OPEN QUERY without DEFINE QUERY - no co... - 06:18 PM Feature #1811: implement the AJAX client driver
- > currently the web client's drawing is asynchronous. What I'm worried is that, if we give control back to the java s...
- 06:16 PM Feature #1811: implement the AJAX client driver
- > > I did a modified version of @setOwnPropertiesTo()@
Yes, it works properly.
Greg, please review my changes (comm... - 06:10 PM Feature #1811: implement the AJAX client driver
- The following are the locations of calls to @EmulatedWindowState.repaint()@:
* @GuiPrimitivesImpl.sync()@ as overr... - 05:49 PM Feature #1811: implement the AJAX client driver
- > I did a modified version of @setOwnPropertiesTo()@
This is checked in as revision 10948. - 05:48 PM Feature #1811: implement the AJAX client driver
- > please review the fix
Overall, I'm fine with the fixes.
> it follows that style property returns a typed obje... - 10:53 AM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> I am trying to finish work on resizing (as implemented by @SwingEmulatedWindow.resizeScreenBuffer... - 10:29 AM Feature #1811: implement the AJAX client driver
- Greg, please review the fix. From https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style it follows that ...
- 08:54 AM Feature #1811: implement the AJAX client driver
- > But the clipboard selection in web chui client is broken now, if you are agree I will try to fix it.
Please do. - 08:11 AM Feature #1811: implement the AJAX client driver
- Greg, these two units src/com/goldencode/p2j/ui/client/chui/driver/web/res/p2j.clipboard_helpers.js
and src/com/gold... - 03:55 AM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> 1. In the Swing client @SwingEmulatedWindow.resizeScreenBuffers()@ locks all other threads out an... - 05:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10919 (new branch revision 10947).
- 02:39 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10918 (new branch revision 10946).
- 07:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Regarding @gso_307@
In the template screen the bottom line is @Press any key for corrections or ENTER to print@
In ... - 06:01 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- @gso_289@ failed in the same way as @gso_281@ but manual run passed OK.
- 05:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- After several runs of the regression tests some tests are still failing. I'm analyzing them now and at least some fai...
- 02:47 PM Feature #1790: implement menu support
- Created task branch 1790e from P2J trunk revision 10919.
- 02:26 PM Feature #1790: implement menu support
- The branch 1790d has been merged and committed into the trunk as bzr revision 10919.
- 02:17 PM Feature #1790: implement menu support
- 1790d is rebased with the latest revision. Current branch revision is 10948.
- 01:28 PM Feature #1790: implement menu support
- I'm good with the changes. Once you've rebased with 10918 (there will be no conflicts), you can merge to trunk.
D... - 12:20 PM Feature #1790: implement menu support
- Please rebase from trunk rev 10918 first, I'll finish the review shortly.
- 10:45 AM Feature #1790: implement menu support
- tc_codes_employees_21, tc_codes_employees_24 are also passed testing. Yes, 1790d is ready for review.
- 10:27 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> First, I rerun full regression testing. Failed test are the following (intersected with previo... - 09:38 AM Feature #1790: implement menu support
- First, I rerun full regression testing. Failed test are the following (intersected with previous run): gso_269, tc_co...
- 04:29 AM Feature #1790: implement menu support
- One more thing: to avoid checking the tests by hand, you can add the failed tests to @majic_baseline/majic_single.xml...
- 04:26 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> GSO_206. Strange, but in the test current screen is the different from expected:
This is bec... - 03:49 AM Feature #1790: implement menu support
- Please check the test(s) manually (step-by-step) and confirm the error is still there. There might be timeouts somet...
- 03:37 AM Feature #1790: implement menu support
- GSO_206. Strange, but in the test current screen is the different from expected: ...
- 03:09 AM Feature #1790: implement menu support
- Regression testing is finished. There are several failed tests: gso_245, gso_206, gso_238, gso_269, tc_codes_employee...
- 03:09 AM Feature #1790: implement menu support
- Greg Shah wrote:
> > It looks like menubar is visible before WAIT-FOR - just right after menubar assignment.
>
> ... - 12:15 PM Feature #1794: implement font support
- Rebased branch 1794c from trunk rev 10918 (new branch rev 10920).
08/10/2015
- 06:23 PM Feature #1811: implement the AJAX client driver
- > please review the changes. Committed revision 10944.
This is significantly better. I like it quite a bit. Ple... - 06:10 PM Feature #1811: implement the AJAX client driver
- I am trying to finish work on resizing (as implemented by @SwingEmulatedWindow.resizeScreenBuffers()@ and on @repaint...
- 05:01 PM Feature #1811: implement the AJAX client driver
- Greg, please review the changes. Committed revision 10944. Found conflicts:
Text conflict in src/com/goldencode/p2... - 04:18 PM Feature #1811: implement the AJAX client driver
- > If you approve to split this part than I will update my local branch and commit into 1811o.
You can commit now. - 04:03 PM Feature #1811: implement the AJAX client driver
- > Reference counting is a good strategy. Do we do that on the Java side? Then only when we remove an image on the J...
- 03:51 PM Feature #1811: implement the AJAX client driver
- > Greg, could you correct me, because I don't understand clearly if it is required to implement or not.
We do need... - 03:29 PM Feature #1811: implement the AJAX client driver
- >3
and
>6. I'd like to hear your ideas on how and when to remove images from the cache. This is both a Java and Jav... - 02:38 PM Feature #1811: implement the AJAX client driver
- Greg, I've added to branch 1811o rev 10943 java-side support for SET_FONT, SET_FONT_STYLE, DRAW_STRING, DRAW_STRING_S...
- 12:18 PM Feature #1811: implement the AJAX client driver
- > how is the web socket supposed to receive data from the JS side, when, for example, the native width for a text is ...
- 11:44 AM Feature #1811: implement the AJAX client driver
- Greg, another question: how is the web socket supposed to receive data from the JS side, when, for example, the nativ...
- 11:08 AM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> Constantin, I am planning to move an image drawing from SwingEmulatedWindow to concrete im... - 11:03 AM Feature #1811: implement the AJAX client driver
- Constantin, I am planning to move an image drawing from SwingEmulatedWindow to concrete implementation of new interfa...
- 10:51 AM Feature #1811: implement the AJAX client driver
- Greg, to reduce the resolution of font and text metrics, I'm adding caches at the @AbstractGuiDriver@ class - this wi...
- 07:24 AM Feature #1811: implement the AJAX client driver
- >1. Some of that logic duplicates code in >SwingEmulatedWindow. And you are missing much of the rendering logic in ho...
- 06:14 PM Feature #1790: implement menu support
- > It looks like menubar is visible before WAIT-FOR - just right after menubar assignment.
The @visible@ attribute ... - 04:03 PM Feature #1790: implement menu support
- I've checked it just now. Here the procedure...
- 03:54 PM Feature #1790: implement menu support
- > So I'll have to change the place of warning processing from ThinClient.waitForWorker() to some other place.
I do... - 03:52 PM Feature #1790: implement menu support
- After last rebase there is a new bug: warning is shown (when no enabled frames are defined). message area is not clea...
- 12:18 PM Feature #1790: implement menu support
- Committed with rev 10947.
- 12:03 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> I've fixed all remarks, but didn't commit it yet. Can I do it while regression testing is runn... - 12:02 PM Feature #1790: implement menu support
- Conversion testing is passed. Generated sources are identical. I've fixed all remarks, but didn't commit it yet. Can ...
- 05:45 PM Feature #1791: implement dynamic UI support
- Plus issue:
8. Error on browse re-creation. - 01:55 PM Feature #1791: implement dynamic UI support
- Stanislav Lomany wrote:
> There is a problem related to @DynamicWidgetFactory.pushScreen(Un)lock@.
> # Conversion a... - 01:48 PM Feature #1791: implement dynamic UI support
- There is a problem related to @DynamicWidgetFactory.pushScreen(Un)lock@.
# Conversion assumes that ... - 07:13 AM Feature #1791: implement dynamic UI support
- I'm making changes only to static query case:
# OPEN QUERY without DEFINE QUERY - no conversion changes.
# OPEN QUE... - 08:45 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, if you are not rebasing at this time, I want to commit... - 08:26 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor, if you are not rebasing at this time, I want to commit some cleanups/pushScreenDef... - 07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, if you are not rebasing at this time, I want to commit some cleanups/pushScreenDefinition changes I've made to ...
- 07:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Status line update is performed in the processing of FOCUS_G... - 07:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Status line update is performed in the processing of FOCUS_GAINED/FOCUS_LOST events. These ... - 07:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Status line update is performed in the processing of FOCUS_GAINED/FOCUS_LOST events. These event are not fired in the...
- 04:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor, please post the 4GL test which required the changes in @FocusManager@
Constanti... - 04:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, please post the 4GL test which required the changes in @FocusManager@
- 04:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor, just a heads up: the antivirus scanner was in progress (I've killed it now) and wh...
08/09/2015
- 04:59 PM Feature #1794: implement font support
- > I'm good with the changes, except I think the @ds.unbind()@ in @FontTable.readFontAliases()@ should be in a @finall...
- 01:01 PM Feature #1794: implement font support
- Code Review Task Branch 1794c Revision 10918
I'm good with the changes, except I think the @ds.unbind()@ in @FontT... - 04:45 PM Feature #1790: implement menu support
- Vadim, please focus on finishing cleaning up the code - do not work on 1790e issues yet, we want to release 1790d fir...
- 08:17 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> ...
> * @Menu@
> - @setVisible:144@
> [...]
> Have you tested this? Is this the expe... - 08:16 AM Feature #1790: implement menu support
- I've rebased 1790d branch. Current revision is 10945. Have a look please. Can I run conversion/regression testing?
- 08:13 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> ...
> * @Menu@
> - @setVisible:144@
> [...]
> Have you tested this? Is this the expected ... - 01:22 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, just a heads up: the antivirus scanner was in progress (I've killed it now) and when this runs (sundays) this s...
- 07:44 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- It appears the the failure of at least one test (gso_195) is is caused by a new "protection logic". Another workaroun...
- 12:18 PM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811o Revision 10940
This is a very good start. I have some feedback. Much of the feedba...
08/08/2015
- 10:57 AM Feature #1794: implement font support
- Please review branch 1794c rev 10918.
I've added support for a new per-user node, @font-aliases@. In this conta... - 10:52 AM Feature #1794: implement font support
- Created task branch 1794c from trunk rev 10917.
- 09:26 AM Feature #1790: implement menu support
- Review for branch 1790d, revision 10944; most issues are just cleanup for code, comments, etc. Please address all i...
- 08:26 AM Feature #1790: implement menu support
- Vadim: please rebase from trunk revision 10917.
Constantin is going to do a code review. Make any needed changes ... - 08:39 AM Feature #1811: implement the AJAX client driver
- > Don't know it can be any encoding supported by a web client. For example, for drawing dynamic screens Hextile is us...
- 08:24 AM Feature #1811: implement the AJAX client driver
- Constantin: To see the history of the font work we have done so far, please review notes 687, 695, 705 - 718. Not mu...
- 08:26 AM Bug #2622 (Closed): width-pixel/height-pixels can't be assigned during create frame
- 08:10 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
- Branch 2622a was merged to trunk rev 10917 and archived.
08/07/2015
- 05:53 PM Feature #1791: implement dynamic UI support
- Unless you change the behavior of @QueryWrapper.addComponent@, though, it will break their use (and possibly other AP...
- 05:30 PM Feature #1791: implement dynamic UI support
- It allows @NUM-BUFFERS@ and @BUFFER-HANDLE@ to work before the query was opened.
- 05:22 PM Feature #1791: implement dynamic UI support
- Stanislav Lomany wrote:
> Eric, I suggest to emit @addBuffer(.., true)@ at @DEFINE QUERY@ node's place.
This will d... - 05:11 PM Feature #1791: implement dynamic UI support
- Eric, I found no explicit way to set a dynamic query @SCROLLING@/@NON-SCROLLING@. As testing shows, it is scrolling. ...
- 09:13 AM Feature #1791: implement dynamic UI support
- Created task branch 2026b from P2J trunk revision 10916.
- 08:58 AM Feature #1791: implement dynamic UI support
- Plus issue:
7. Browse with dynamic query hangs on the last record. - 07:41 AM Feature #1791: implement dynamic UI support
- > 2. In P2J ADD-LIKE-COLUMN cannot be called for a static query until it is opened. Requires conversion changes
Er... - 04:52 PM Feature #1811: implement the AJAX client driver
- Greg, committed into 1811o, revision 10940, please review my changes. GuiWebDriver has method public NativeRectangle ...
- 03:16 PM Feature #1811: implement the AJAX client driver
- > 1. Is there a need to send a hash of the image? Why not a simple 32-bit integer as an ID? The images are not bein...
- 12:38 PM Feature #1811: implement the AJAX client driver
- > do you permit to commit my changes in 1811o
Yes, go ahead.
Some other thoughts:
1. Is there a need to send... - 12:20 PM Feature #1811: implement the AJAX client driver
- Now it is implemented only 32 bits per a pixel RGB format, thus pixel_format isnot used in DRAW_IMAGE message:
DRAW_... - 04:50 PM Feature #1790: implement menu support
- Here is the list of todos:
# drawing for keyboard menu navigation mode.
# API for working with accelerators dependi... - 04:45 PM Feature #1790: implement menu support
- There are the bug. When I click on some menu-item in sub-menu body - body is closed but under the menu-item there is ...
- 04:42 PM Feature #1790: implement menu support
- I've rebase my branch 1790d please review. I've committed fix for warning on no enabled widgets. Current branch is 1...
- 02:30 PM Feature #1790: implement menu support
- It is only available on the server side for now.
Please just an @UnimplementedFeature.todo()@ in the code that gen... - 02:03 PM Feature #1790: implement menu support
- Could somebody recall me, how to get procedure name and more important: line number?
- 04:47 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> ... but for CHUI I was running tests in lindev01 instead of proposed method. Is that matter?
... - 04:44 AM Feature #1790: implement menu support
- Thank you. You or Greg already told me about that some time before. I'm running tests on windev01 using that way, but...
- 04:38 AM Feature #1790: implement menu support
- And why you need to do this: because the 4GL procedure editor is a 4GL program itself, and the behaviour is altered b...
- 04:35 AM Feature #1790: implement menu support
- Vadim, I should have checked this earlier: if you are not doing it already, please test all your menu-related tests (...
- 02:47 PM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
- Rev 10917 passed runtime testing.
- 08:53 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
- Code Review Task Branch 2622a Rev 10917
I'm fine with the changes. - 05:37 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
- Please review branch 2622a rev 10917.
This is in runtime testing now. - 04:41 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
- Created branch 2622a from trunk rev 10916.
- 12:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> From the main part the following tests failed in the same way in all 4 runs:
>
> gso_195... - 12:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- There where 4 runs of the regression tests (3 on devsrv01 and 1 on my local machine).
The following tests failed i... - 09:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> I don't understand this statement. The @apply@ is not executed on a separate thread. On the ser... - 09:02 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > In fact this is understandable as apply is processed in a separate thread, but at this moment I do not see how to f...
- 04:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor, the wait-for tests (and generally all tests which require testing of focus/event p... - 04:03 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, the wait-for tests (and generally all tests which require testing of focus/event processing) need to be ran fro...
- 04:45 AM Feature #2635: multi-window focus management
- When there are multiple windows and each one with multiple enabled widgets, the focus management is not properly hand...
- 04:43 AM Feature #2635 (New): multi-window focus management
08/06/2015
- 05:33 PM Feature #1811: implement the AJAX client driver
- Updated the test example, removed dependencies from rfb of vncj project. Needs to do pixel format serialization.
- 04:12 PM Feature #1811: implement the AJAX client driver
- This is a draft format for DRAW_IMAGE sub-message based on RFB specification document(https://www.realvnc.com/docs/rf...
- 09:21 AM Feature #1811: implement the AJAX client driver
- Rebased task branch 1811o from P2J trunk revision 10916. The current revision in 1811o is now 10939.
- 04:09 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- It looks that the problem is due to the race condition. If there is a breakpoint on the second line of
@
apply "en... - 10:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> I know you're working on the focus issue. Did you finish testing all of the focus testcases?
... - 10:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Code Review Task Branch 2567a Revision 10941
The changes look fine. At some point we will need to move the privat... - 09:46 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Started regression testing of the branch 2567a
- 09:37 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10916 (new branch revision 10941).
- 08:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Sounds good, thanks.
- 08:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> If you are close to a resolution, then go ahead and fix it now. If not, please open a new task a... - 08:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- If you are close to a resolution, then go ahead and fix it now. If not, please open a new task and make it related t...
- 08:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- The problem is that @locate().client.getFocus()@ returns -1. Test @wait-for_restore_focus1.p@ line 39.
- 07:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> When you said "previous version of FocusManager", did you mean that that problem already exists i... - 07:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- When you said "previous version of FocusManager", did you mean that that problem already exists in the trunk of P2J?
- 07:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Please create a new task, make it related to this one and put enough details in to allow us to re... - 07:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > Exactly the same error with the previous version of the FocusManager.focusChange()
OK, you don't need to fix thi... - 07:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> No, we will work those problems in #2558. Please just modify the 4GL source code to bypass the i... - 07:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> There are several errors in compilation of the converted testcases like this:
> @
> [... - 07:14 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Exactly the same error with the previous version of the @FocusManager.focusChange()@
Continue investigation. - 07:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Some tests in @wait-for_focus_run.p@ fail:
@
Invalid handle. Not initialized or points to a deleted object. (313... - 05:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- There are several errors in compilation of the converted testcases like this:
@
[javac] /home/ias/p2j/testcases... - 03:47 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Code Review Task Branch 2567a Revision 10932
>
> I made a few minor additions or removals of w... - 04:00 PM Feature #1791: implement dynamic UI support
- > Depending on assignment order, there may be various 4GL error messages like "Unable to set ROW-MARKERS because the ...
- 03:33 PM Feature #1791: implement dynamic UI support
- I found also:
4. Browse does not receive focus when created in a trigger.
5. Error on WIDGET DELETE.
6. Depending ... - 01:17 PM Feature #1791: implement dynamic UI support
- Please resolve all 3 issues. When do you think you have have the changes ready?
Other than those 3 problems, ther... - 01:02 PM Feature #1791: implement dynamic UI support
- Stanislav Lomany wrote:
> 3. QUERY-PREPARE doesn't work. Is it something with my configuration or do you see the iss... - 12:55 PM Feature #1791: implement dynamic UI support
- Here is the set of problems so far:
1. Error if VISIBLE/HIDDEN is set prior to SENSITIVE. Doesn't affect the custo... - 12:14 PM Feature #1791: implement dynamic UI support
- Now that you have had 2-3 days to review the runtime support needed for CREATE BROWSE, please provide an estimate of ...
- 12:03 PM Feature #1790: implement menu support
- Please post a list of all the remaining issues/todos/work for this task.
- 11:53 AM Feature #1790: implement menu support
- > Is it a good place
Although this method is only called from the @waitForWorker()@, it is not guaranteed to only ...
08/05/2015
- 06:26 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Code Review Task Branch 2567a Revision 10932
I made a few minor additions or removals of whitespace in some files.... - 05:02 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Got rid of @Trigger.INFO@.
Committed to the branch 2567a, revno 10932. - 04:27 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Fixed all issues from the Constantin's code review except the one regarding the @Trigger.INFO@. The @getWidhetId()@ r...
- 03:07 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Thank you gentlemen. I understand the point. Although in this particular case using of a ThreadLocal is just a shortc...
- 02:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Another point: it is not required that all sessions use the conversation model (where a dedicated thread executes the...
- 02:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:s in alphabetical order
> > # Trigger.INFO
> > - in P2J we do no... - 01:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:s in alphabetical order
> # Trigger.INFO
> - in P2J we do not use @ThreadLocal@ variables,... - 12:21 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Thank you Constatin.
I will change the code as you advised. - 12:12 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Review branch 2567a revision 10930:
# methods_attributes.rules:
- line 376: you've changed the name of the getter; ... - 10:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10909 (new branch revision 10930).
- 10:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor, please rebase to trunk rev 10909, your branch is built on top of trunk rev 10906.
- 09:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Do you believe this is the full solution to the focus issues? (Is it ready for final review?)
... - 09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Do you believe this is the full solution to the focus issues? (Is it ready for final review?)
- 05:59 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- The side effect of the temporary focus change where the events posted in the @AbstractWidget.requestFocus()@ method. ...
- 05:31 PM Bug #2620 (Closed): problems when editable size of a field is smaller than the format length
- 04:41 PM Bug #2620: problems when editable size of a field is smaller than the format length
- Branch 2620a was merged to trunk rev 10912 and archived.
- 04:26 PM Bug #2620: problems when editable size of a field is smaller than the format length
- Rebased branch 2620a from trunk rev 10911 (new branch rev 10913).
- 12:49 PM Bug #2620: problems when editable size of a field is smaller than the format length
- Rebased branch 2620a from trunk rev 10910 (new branch rev 10912).
- 12:44 PM Bug #2620 (WIP): problems when editable size of a field is smaller than the format length
- All failures in 2620a runtime testing look like false negatives, another round is in progress - I expect to set it as...
- 09:05 AM Bug #2620: problems when editable size of a field is smaller than the format length
- Code Review Task Branch 2620a Revision 10911
I'm good with the changes. - 05:18 AM Bug #2620 (Review): problems when editable size of a field is smaller than the format length
- Please review branch 2620a rev 10911 - it contains fixes for FILL-IN cursor problems when editable width is smaller t...
- 03:44 PM Feature #1791: implement dynamic UI support
- 2026a was merged to trunk rev 10911.
- 03:23 PM Feature #1791: implement dynamic UI support
- Stanislav Lomany wrote:
> It is not expected to be used in loops. Should I change the code to
>
> [...]
>
> an... - 03:14 PM Feature #1791: implement dynamic UI support
- It is not expected to be used in loops. Should I change the code to...
- 02:59 PM Feature #1791: implement dynamic UI support
- Having written that, I don't know what the converted code that uses this will look like. I don't expect that this cod...
- 02:56 PM Feature #1791: implement dynamic UI support
- I looked a bit deeper, and something concerns me. From @BrowseWidget@:...
- 02:46 PM Feature #1791: implement dynamic UI support
- Should I distribute the update?
- 02:37 PM Feature #1791: implement dynamic UI support
- Yes, that is the point.
- 02:28 PM Feature #1791: implement dynamic UI support
- Code review 2026a/10914:
What is the purpose of the new variant @setQueryAsHandle(QueryWrapper)@, which is defined... - 02:09 PM Feature #1791: implement dynamic UI support
- As soon as he approves it, you can merge to trunk. He will have it done shortly.
- 01:51 PM Feature #1791: implement dynamic UI support
- Rebased task branch 2026a from P2J trunk revision 10910.
Conversion regression passed.
I guess, waiting for Eric t... - 12:41 PM Feature #1791: implement dynamic UI support
- Code Review Task Branch 2026a Revision 10914
The changes look good.
> Am I right that I shouldn't run runtime r... - 11:54 AM Feature #1791: implement dynamic UI support
- Committed @triggers_phrase_rewrite.rules@.
Am I right that I shouldn't run runtime regression testing? - 08:58 AM Feature #1791: implement dynamic UI support
- Code Review Task Branch 2026a Revision 10913
I'm OK with the changes.
> Should I rename the file (say, to creat... - 07:58 AM Feature #1791: implement dynamic UI support
- Please review task branch 2026a revision 10913.
- 07:57 AM Feature #1791: implement dynamic UI support
- Rebased task branch 2026a from P2J trunk revision 10909.
- 02:31 PM Feature #1811: implement the AJAX client driver
- > how to test images using P2J, 4Gl function button.load-image()?
Until the GUI web client is further along, we ca... - 12:54 PM Feature #1811: implement the AJAX client driver
- Fixed the test (canvas resizing, pixel format issue) and added ./red256x256.jpg, ./green256x256.jpg, ./blue256x256.jp...
- 01:01 PM Bug #2621 (Closed): wait-for only works for current-window
- 12:41 PM Bug #2621 (Review): wait-for only works for current-window
- Branch 2621a was merged to trunk rev 10910 and archived.
- 12:36 PM Bug #2621: wait-for only works for current-window
- Please merge to trunk now.
- 03:24 AM Bug #2621: wait-for only works for current-window
- Rebased branch 2621a, from trunk rev 10909 (new branch rev 10911)
Also, it has passed runtime testing.
08/04/2015
- 06:29 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Fixed issues 5 mentioned in the code review.
I've tested several scenarios: no widget for the new focus, NO-APPLY i... - 08:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > CHARVA is mentioned in many places in this class. Should I remove them all?
Yes, please do. - 06:03 PM Feature #1811: implement the AJAX client driver
- This very vague test (test.zip) yields several issues to be resolved. The fist one it needs to make an agreement betw...
- 05:59 PM Feature #1790: implement menu support
- Have a look please at @FocusManager.undefImplicit()@:...
- 03:09 PM Feature #1790: implement menu support
- > NO-ERROR is not supported for WAIT-FOR, so I can't check it.
Good point. That means it cannot be supported sinc... - 12:33 PM Feature #1790: implement menu support
- Greg Shah wrote:
> You should also check these:
>
> * Does it matter if there are frames present, but they are NO... - 12:06 PM Feature #1790: implement menu support
- > If a frame with enabled widgets persist in a window - than that error will not appear. Other cases (sub-menus/trig...
- 11:59 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Short question. I'm confused a little.
> >
> > When I move ... - 11:31 AM Feature #1790: implement menu support
- Greg Shah wrote:
> Vadim Gindin wrote:
> > I'm working on the following error. If the source procedure contains the... - 09:04 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> I'm working on the following error. If the source procedure contains the statement WAIT-FOR wi... - 03:50 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Short question. I'm confused a little.
>
> When I move mouse pointer outside from the widg... - 03:31 AM Feature #1790: implement menu support
- Short question. I'm confused a little.
When I move mouse pointer outside from the widget (menu-item for example) ... - 04:15 PM Bug #2620 (WIP): problems when editable size of a field is smaller than the format length
- Created task branch 2620a from trunk rev 10908.
- 03:40 PM Feature #1791: implement dynamic UI support
- There is file @embedded_attribute_assign_rewrite.rules@ which rewrites CREATE...ASSIGN. I've added rewrite for CREATE...
- 03:08 PM Bug #2623 (Closed): mouse cursor icons for the window edges sometimes don't change back to the st...
- 01:35 PM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Branch 2623a was merged to trunk rev 10908 and archived.
- 09:49 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Greg Shah wrote:
> Did you @bzr push@ your rebased changes back to the devsrv01 task branch master? I don't see the... - 09:47 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Did you @bzr push@ your rebased changes back to the devsrv01 task branch master? I don't see the latest rebase chang...
- 03:55 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Rebased branch 2623a, from trunk rev 10907 (new branch rev 10908)
- 01:34 PM Bug #2621: wait-for only works for current-window
- Rebased branch 2621a, from trunk rev 10908 (new branch rev 10910)
- 09:42 AM Bug #2621: wait-for only works for current-window
- Code Review Task Branch 2621a Revision 10909
It looks good. I think this can go into testing unless there is anyt... - 03:54 AM Bug #2621: wait-for only works for current-window
- Rebased branch 2621a, from trunk rev 10907 (new branch rev 10909)
- 08:39 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Hynek: Are you planning to include fixes for @at_grows_frame.p/half_fixed_position.p@ and @frame-... - 08:37 AM Feature #2252: implement GUI client support
- Hynek: Are you planning to include fixes for @at_grows_frame.p/half_fixed_position.p@ and @frame-scrolling-size.p@ in...
- 08:24 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review Task Branch 2424b Revision 10921
>
> I'm good with the changes.
>
> > the code... - 02:35 AM Feature #2252: implement GUI client support
- Created task branch 2424c. This will hold some generic scrolling fixes and potential changes related to frame scrolling.
- 02:28 AM Feature #2252: implement GUI client support
- Branch 2424b has passed conversion and runtime regression tests, was merged to trunk rev 10907, and archived.
- 10:57 PM Feature #2252: implement GUI client support
- Code Review Task Branch 2424b Revision 10921
I'm good with the changes.
> the code still needs cleanup and is ...
08/03/2015
- 04:03 PM Feature #2252: implement GUI client support
- Please review task branch 2424b, revision 10921. This among others resolves the comments from the review of revision ...
- 11:10 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > @frame-scrolling-size.p@ abends for ... - 10:56 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > @frame-scrolling-size.p@ abends for me, I didn't investigate fu... - 10:40 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> @frame-scrolling-size.p@ abends for me, I didn't investigate further:
Something has regressed... - 05:45 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr... - 05:27 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr... - 05:12 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review Task Branch 2424b Revision 10916
Greg, the code still needs cleanup and is missing... - 05:04 AM Feature #2252: implement GUI client support
- Code Review Task Branch 2424b Revision 10916
Overall, the update is quite good. I assume you are planning to add ... - 03:04 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Fixed issues 1,2,3,6 mentioned in the code review. Committed to the branch 2567a, revno 10925.
Regarding the issue... - 02:42 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Code Review Task Branch 2567a Revision 10924
>
> This is quite good. Most issues are minor, b... - 02:06 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Code Review Task Branch 2567a Revision 10924
This is quite good. Most issues are minor, but issue 4 is a more ser... - 02:26 PM Feature #1811: implement the AJAX client driver
- > 1)Draw an image on the server side in a memory (GuiWebEmulatedWindow,SwingEmulatedWindow)
> 2)Transfer binaries vi... - 12:39 PM Feature #1811: implement the AJAX client driver
- > Then please review the @PaintPrimitives.DRAW_IMAGE@ implementation in our GUI client. The easiest way is to search...
- 10:44 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Rebased branch 2623a, from trunk rev 10906 (new branch rev 10907)
- 10:43 AM Bug #2621: wait-for only works for current-window
- Rebased branch 2621a, from trunk rev 10906 (new branch rev 10907)
- 08:01 AM Feature #1790: implement menu support
- I'm working on the following error. If the source procedure contains the statement WAIT-FOR with the event of some me...
08/02/2015
- 12:03 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added Javadocs. Committed to the branch 2567a, revno 10924.
Ready for the code review
08/01/2015
- 06:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10906 (new branch revision 10923).
- 06:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> That is great!
>
> Now may be a good time to rebase. Do you need any more changes/cleanup bef... - 06:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- That is great!
Now may be a good time to rebase. Do you need any more changes/cleanup before code review? - 05:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Fixed the bug with the @ON LEAVE@ trigger activation (note #50). Committed to the branch 2567a, revno 10918.
- 08:05 PM Feature #2546: implement combo-box widget in GUI
- After some investigations especially for widgets without explicit width/height set I have found the character based v...
07/31/2015
- 07:24 PM Feature #2252: implement GUI client support
- Rebased task branch 2424b from P2J trunk revision 10906 (branch revision 10916).
- 06:30 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, sorry for the delay about this one:
> > I am not sure how the Windows font scali... - 04:23 PM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546c@ from P2J trunk revision @10906@, new branch revision is @10906@.
- 08:06 AM Feature #2546: implement combo-box widget in GUI
- Eugenie, in case you need to determine if the widget's dimension was set explicitly, there are the @fixedWidth@ and @...
- 05:56 AM Feature #2546: implement combo-box widget in GUI
- Created task branch @2546c@ from P2J trunk revision @10905@.
- 05:49 AM Feature #2546: implement combo-box widget in GUI
- The branch @2546b@ has been merged and committed to trunk as revision @10905@. Archived.
- 05:36 AM Feature #2546: implement combo-box widget in GUI
- @2546b@ passed the regression testing. The results - @2546b_10916_16cd2a2_20150731_evl.zip@. Starting to merge into m...
- 03:48 PM Feature #1811: implement the AJAX client driver
- Rebased task branch 1811o from P2J trunk revision 10906.
- 03:19 PM Feature #1811: implement the AJAX client driver
- That is fine. 1811p branch is merged to the trunc with revno: 10906.
- 03:08 PM Feature #1811: implement the AJAX client driver
- The rebase looks fine.
> do want to see in the trunc all history from 1811p
When you commit the change in the t... - 03:06 PM Feature #1811: implement the AJAX client driver
- Now 1811p is branched from rev 10905 of trunc.
- 02:58 PM Feature #1811: implement the AJAX client driver
- > Let me know what questions you have.
Greg, now 1811p has been rebased to the trunc 10905, do want to see in the tru... - 02:21 PM Feature #1811: implement the AJAX client driver
- Next task: I would like you to help me add image support to the GUI web client. You will be making changes in task b...
- 02:12 PM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811p Revision 10905
It looks good.
Please rebase the update to the latest trunk revisi... - 01:54 PM Feature #1811: implement the AJAX client driver
- > Code Review Task Branch 1811p Revision 10904
All done accordingly
> 3. I see your changes in @p2j.clipboard_helpe... - 12:48 PM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811p Revision 10904
1. I still have not seen any testing results with my original idea of... - 10:04 AM Feature #1811: implement the AJAX client driver
- > Please document the results of your "use strict" testing here.
There are no possibilities to define "use strict" in... - 09:51 AM Feature #1811: implement the AJAX client driver
- Please document the results of your "use strict" testing here.
- 08:29 AM Feature #1811: implement the AJAX client driver
- Added all changes from rev 10901 trunc to rev 10904 of branch 1811p.
- 08:21 AM Feature #1811: implement the AJAX client driver
- Greg, please review final changes for 1811p branch rev. 10904.
- 03:14 PM Bug #2621: wait-for only works for current-window
- > but this will mean that the current EmulatedWindowState needs to be interrogated each time draw() is called to get ...
- 03:04 PM Bug #2621: wait-for only works for current-window
- Greg Shah wrote:
> Code Review Task Branch 2621a Revision 10906
>
> I like the changes.
>
> My only question: ... - 02:54 PM Bug #2621: wait-for only works for current-window
- Code Review Task Branch 2621a Revision 10906
I like the changes.
My only question: Should the @gd.selectWindow(... - 06:19 AM Bug #2621: wait-for only works for current-window
- Rebased branch 2621a, from trunk rev 10905 (new branch rev 10906)
- 03:00 PM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
- Code Review Task Branch 2623a Revision 10906
I'm good with the changes. - 07:46 AM Bug #2623 (Review): mouse cursor icons for the window edges sometimes don't change back to the st...
- Please review branch 2623a rev 10906.
- 06:30 AM Bug #2623 (WIP): mouse cursor icons for the window edges sometimes don't change back to the stand...
- Created task branch 2623a from trunk rev 10905.
- 12:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> > Well, suggest to take the route 2. If this will not be done today and at the weekend, then reve... - 12:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > Well, suggest to take the route 2. If this will not be done today and at the weekend, then revert to the route 1.
... - 12:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> OK, good. Then we have 3 options on moving forward:
>
> 1. Review and regression test the cur... - 12:31 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- OK, good. Then we have 3 options on moving forward:
1. Review and regression test the current 2567a branch. Then... - 12:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Other than the bug in note 50, am I correct that only the GUI related features are left?
>
> T... - 12:23 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Other than the bug in note 50, am I correct that only the GUI related features are left?
That would be this list:
... - 11:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Finished implementation of the runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the br...
- 08:08 AM Bug #2622 (WIP): width-pixel/height-pixels can't be assigned during create frame
- Setting the frame's width/height attributes works in P2J only in "batch" mode, with the @CREATE ASSIGN@ statement. W...
07/30/2015
- 05:36 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Partial runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the branch 2567a, revno 10916....
- 01:30 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> I mean when you find something which is related to the core focus or event processing. ... - 01:22 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > When you find incompatibilities like this, please confirm 4G... - 01:21 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> When you find incompatibilities like this, please confirm 4GL test behaves the some, bot... - 01:04 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > Thanks for the heads-up on this. I assume you are working on this as... - 10:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Thanks for the heads-up on this. I assume you are working on this as part of the current task. ... - 09:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> The logic of the @FocusManager.focusChange()@ method should be changed as within the @ON LE... - 09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Thanks for posting the unknown value processing/messages problems (notes 46 and 56). I have created task #2629 for t...
- 07:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> For this task, please change your test to protect against unknown handle usage. So, ins... - 07:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > p2j generates incompatible err... - 07:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > p2j generates incompatible error message when referencing to... - 07:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> p2j generates incompatible error message when referencing to the attributes of the @handle@... - 07:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- p2j generates incompatible error message when referencing to the attributes of the @handle@ which has 'unknown' value...
- 05:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- The logic of the @FocusManager.focusChange()@ method should be changed as within the @ON LEAVE@ trigger it should be ...
- 04:42 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
- > Have you found a use-case which is not working?
No. Sometime in the past I had written down a note to myself t... - 04:03 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
- Greg Shah wrote:
> LAST-EVENT:EVENT-TYPE = "MOUSE" needs to be supported for GUI
This is already added: @KeyReader.... - 04:38 PM Feature #1796 (Closed): implement full GUI layout support
- 04:15 PM Feature #2252: implement GUI client support
- Hynek, sorry for the delay about this one:
> I am not sure how the Windows font scaling affects this equation (it ca... - 01:23 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review Task Branch 1796d Revision 10912
>
> I'm fine with the changes. And we can stick ... - 08:08 AM Feature #2252: implement GUI client support
- Code Review Task Branch 1796d Revision 10912
I'm fine with the changes. And we can stick with the new token appro... - 05:19 AM Feature #2252: implement GUI client support
- Rebased task branch 1796d from P2J trunk revision 10902 (new branch revision 10912).
Testing has already passed for ... - 03:50 PM Bug #2621: wait-for only works for current-window
- Please review branch 2621a, revision 10905. It contains these fixes:
* FramePlacementManager must be window specifi... - 03:46 PM Feature #1811: implement the AJAX client driver
- > If a translation is required without a draw operation then I would create a new method executeTranslated(origin, co...
- 03:32 PM Feature #1811: implement the AJAX client driver
- Also, please put in a comment to explain why @\r@ is being used instead of @\n@.
- 03:31 PM Feature #1811: implement the AJAX client driver
- > it helps me if instead of '\n' web client will send '\r' as EOL that is okay for EditorImpl and it is treated prop...
- 02:13 PM Feature #1811: implement the AJAX client driver
- > I don't understand this one. @Editor.processKeyEvent@ has this code to treat the @KA_RETURN@ and @KA_NEW_LINE@ cas...
- 01:52 PM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> > Overall, adding newlines to the copy function seems like a reasonable way to do this. I... - 12:18 PM Feature #1811: implement the AJAX client driver
- > web client supports browser side clipboard with help of hidden input field
Yes.
> If a user presses CTRL+C a... - 11:50 AM Feature #1811: implement the AJAX client driver
- > Overall, adding newlines to the copy function seems like a reasonable way to do this. I don't know offhand why thes...
- 09:17 AM Feature #1811: implement the AJAX client driver
- > end-lines are lost on the server side, it is unclear if screen.video (2-dim array, p2j.screen.js) should contain e...
- 09:05 AM Feature #1811: implement the AJAX client driver
- > Please look at the committed code 1811p revision 10903 and run it to prove the reason.
I've looked at the code t... - 04:29 AM Feature #1811: implement the AJAX client driver
- 1811#756
> > "use strict" defined in each module's function gives possibility to work with an external non-strict j... - 03:31 PM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546b@ from P2J trunk revision @10904@, new branch revision is @10916@.
- 03:13 PM Feature #2546: implement combo-box widget in GUI
- Looks like I need another rebase from @10904@ and restart testing. Starting.
- 02:50 PM Feature #2546: implement combo-box widget in GUI
- >Eugenie: please rebase 2546b from 10903 in the trunk. Then put that version into regression testing. If it passes te...
- 01:56 PM Feature #2546: implement combo-box widget in GUI
- Eugenie: please rebase 2546b from 10903 in the trunk. Then put that version into regression testing. If it passes t...
- 01:43 PM Feature #2546: implement combo-box widget in GUI
- Eugenie, your scaling approach is still faulty; easiest way to prove is to use an explicit font with a small size and...
- 11:32 AM Feature #2546: implement combo-box widget in GUI
- >We have accepted that the font rendering may be slightly different in our system. But it must be very close, such th...
- 10:36 AM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546b@ from P2J trunk revision @10902@, new branch revision is @10914@.
- 08:47 AM Feature #2546: implement combo-box widget in GUI
- I'll let Constantin answer the note 237.
> Despite of the modern systems WYSIWYG declaration the real life is diff... - 08:16 AM Feature #2546: implement combo-box widget in GUI
- What I do not understand here is the difference between your offering and what we currently have in @10913@? And why ...
- 05:47 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10913@.
What I meant is to remove comp... - 01:58 PM Feature #1790: implement menu support
- > Is that correct?
Yes, exactly right. - 01:55 PM Feature #1790: implement menu support
- Greg Shah wrote:
> > The format of the key-name string depends on the current keyboard layout.
>
> Yes, it is a c... - 12:04 PM Feature #1790: implement menu support
- > The format of the key-name string depends on the current keyboard layout.
Yes, it is a concern. It means that f... - 11:48 AM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > The answer to how, is simple: capture the result of the WIN32 API ... - 08:58 AM Feature #1790: implement menu support
- Greg Shah wrote:
> The answer to how, is simple: capture the result of the WIN32 API call for each key code that we ... - 08:40 AM Feature #1790: implement menu support
- > This function returned exactly "PgDn" for VK_NEXT (0x22=34 in a decimal notation). So I think that is the origin of...
- 07:01 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> I've made these corrections, but it didn't helped. All proposed changes are in the client-side... - 01:32 PM Feature #1791: implement dynamic UI support
- I think this should have been done previously, but it was missed.
We do need TRIGGERS phrase support to be impleme... - 01:29 PM Feature #1791: implement dynamic UI support
- Is CREATE ... TRIGGERS supposed to be converted properly? Is somebody working on that? Currently ...
- 10:41 AM Feature #1791: implement dynamic UI support
- > Did you expect to remove the query attribute from the @methods_attributes.rules@ in revision 10904 of branch 2026a?...
- 08:58 AM Feature #1791: implement dynamic UI support
- Did you expect to remove the query attribute from the @methods_attributes.rules@ in revision 10904 of branch 2026a?
... - 06:22 AM Feature #1791: implement dynamic UI support
- Rebased task branch 2026a from P2J trunk revision 10902.
- 10:46 AM Feature #2422 (Closed): add features to BROWSE
- 09:58 AM Feature #2422: add features to BROWSE
- Stanislav Lomany wrote:
> I cannot remember or see any unimplemented features. The only thing that comes to mind is ... - 09:53 AM Feature #2422: add features to BROWSE
- I cannot remember or see any unimplemented features. The only thing that comes to mind is that saving of new rows is ...
- 07:54 AM Feature #2422: add features to BROWSE
- Please create the related task for non-fill-in column support in browse.
I know we have moved some GUI features to... - 04:33 AM Feature #2422 (Review): add features to BROWSE
- Branch 2422b has been committed to trunk revision 10902 (Implemented BROWSE:MODIFIED and SET-REPOSITIONED-ROW).
- 10:32 AM Feature #2630: Add ability to save new rows in browse.
- Currently we can insert new rows in a browse, but not save them. Saving is combination of INSERT-ROW, ASSIGN and CREA...
- 10:30 AM Feature #2630 (New): Add ability to save new rows in browse.
- 09:52 AM Bug #2629: deviations in handle with unknown value error processing and messages
- There are multiple problems. Please see the testcases and descriptions as posted in #2567 note 46 and note 56.
- 09:52 AM Bug #2629 (New): deviations in handle with unknown value error processing and messages
- 08:37 AM Feature #2628: Non-fill-in column support in browse.
- Browse can contain combo-boxes and toggle-boxes.
- 08:35 AM Feature #2628 (WIP): Non-fill-in column support in browse.
- 08:33 AM Feature #2627: Implement quirky cases of refresh when REFRESHABLE is turned ON
- See commented code section in @Browse.executePendingRefresh@.
- 08:31 AM Feature #2627 (New): Implement quirky cases of refresh when REFRESHABLE is turned ON
07/29/2015
- 07:34 PM Feature #2546: implement combo-box widget in GUI
- >...This will create a text-metrics.xml file which you will need to add to your classpath, when running the programs....
- 03:10 PM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Consider button testcases, one example is the button like "Enable on/off". The button text ... - 02:47 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10913@.
Scaling clean up completed. - 02:26 PM Feature #2546: implement combo-box widget in GUI
- >I don't understand this one: to me, it looks like in this case there is an implicit font and the width is not set ex...
- 02:05 PM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> But the main issue on my guess is wrong calculation(or not enough precision) of the @FontMa... - 01:42 PM Feature #2546: implement combo-box widget in GUI
- >Otherwise, you need to change your scaling approach in ComboBoxGuiImpl so that the dimension is computed using the f...
- 10:15 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10912@.
* ComboBoxGuiImpl:497 - please... - 05:26 PM Feature #1790: implement menu support
- I've made these corrections, but it didn't helped. All proposed changes are in the client-side. Menu config change (v...
- 02:59 PM Feature #1790: implement menu support
- About "PgDn" string origin in accelerator, where "PAGE-DOWN" is specified. Here are the following results:
# VK_NE... - 03:02 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review Task Branch 1796d Revision 10910
>
> My only questions:
>
> 1. Why are the FRAM... - 02:39 PM Feature #2252: implement GUI client support
- Code Review Task Branch 1796d Revision 10910
My only questions:
1. Why are the FRAME_LOCK/FRAME_UNLOCK nodes ne... - 01:54 PM Feature #2252: implement GUI client support
- Please review branch 1796d:
* revisions 10907, 10908, 10909 contain more fixes for drawing a GUI frame (down/title/s... - 12:00 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Once you have the CREATE ASSIGN locking fix, plan to merge up with Stanislav's 2422b update that ... - 02:10 PM Feature #1811: implement the AJAX client driver
- > running this command isn't permitted for sbi@devsrv01 user:
Good point. I have made some modifications to devsr... - 05:51 AM Feature #1811: implement the AJAX client driver
- > 3. Ensure that the spawner is installed into that directory:
>
> @cd ~/testing/majic/p2j/@
> @ant jar native -Dpos... - 05:41 AM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> I don't understand the need for the 2nd @translate()@ and it will cause me some problems with t...
07/28/2015
- 05:56 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10901 (new branch revision 10915).
- 05:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Partial runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the branch 2567a, revno 10914.
- 12:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- It seems that there is a bug in p2j. When running the attached program in 4GL all four triggers are invoked pairwise,...
- 05:45 PM Feature #1811: implement the AJAX client driver
- > But if there is no selection, then Ctrl + C terminates the client's session and the client is redirected to login p...
- 05:41 PM Feature #1811: implement the AJAX client driver
- For rev 10866 the selection is working as expected the selection rectangle highlights the target text. And if there i...
- 05:24 PM Feature #1811: implement the AJAX client driver
- > How the selection should work? Usually, we can use a mouse or a keyboard to select a text. But in revision 10866 mo...
- 04:24 PM Feature #1811: implement the AJAX client driver
- > I believe that the current ChUI Web client (in the P2J trunk) may have its clipboard support in a broken state. Th...
- 03:32 PM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> This case has an extra @translate()@ in the middle. And I'm not clear why it is there. If I und... - 03:23 PM Feature #1811: implement the AJAX client driver
- In the Javascript canvas, the management of clipping and translation is limited. It provides those features, but it ...
- 02:23 PM Feature #1811: implement the AJAX client driver
- It was my fault that I used the template gso_20090909_1_14_4a_master and didn't setup a personal MAJIC database on de...
- 12:58 PM Feature #1811: implement the AJAX client driver
- Eric Faulhaber wrote:
> Constantin, since it looks like the master was used against a live system, it is no longer p... - 12:49 PM Feature #1811: implement the AJAX client driver
- The problem is that there is no working database, only templates:...
- 12:31 PM Feature #1811: implement the AJAX client driver
- Sergey, how did you start the server on devsrv01? via @server.sh@ or via @run_regression.sh@? p2jpl.jar should be au...
- 12:29 PM Feature #1811: implement the AJAX client driver
- Ah, I thought this was a local installation of the database. Still, there's something wrong with the built-in functio...
- 12:04 PM Feature #1811: implement the AJAX client driver
- He is using a devsrv01 database instance. We shouldn't need to build pljava from scratch there.
- 11:44 AM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> _[07/28/2015 18:09:24 MSK] (org.hibernate.engine.jdbc.spi.SqlExceptionHelper:ERROR) ERROR... - 11:35 AM Feature #1811: implement the AJAX client driver
- > "use strict" defined in each module's function gives possibility to work with an external non-strict jscript code i...
- 11:33 AM Feature #1811: implement the AJAX client driver
- > failed to load aero.timco.oasis.remote.p2j.OasisServerHookRegistrar
This is not a cause of the problem. This is... - 11:19 AM Feature #1811: implement the AJAX client driver
- > Hmmm. This should not be an error that is due to the javascript changes, since it is about database record retriev...
- 11:06 AM Feature #1811: implement the AJAX client driver
- > Code Review Task Branch 1811p Revision 10902
> My only question: wouldn't it be better to implement the "use stric... - 10:53 AM Feature #1811: implement the AJAX client driver
- Sergey: In addition to the "use strict" changes you are working on, I'd like you to look into the following problem.
... - 10:40 AM Feature #1811: implement the AJAX client driver
- > but if select Service Order Entry, then the target screen isn't displayed and the server logs
>
> [07/28/2015 16... - 10:38 AM Feature #1811: implement the AJAX client driver
- Code Review Task Branch 1811p Revision 10902
My only question: wouldn't it be better to implement the "use strict"... - 09:50 AM Feature #1811: implement the AJAX client driver
- > I don't see any changes checked into task branch 1811p. I realize you have posted a diffs file, but it is better t...
- 04:02 PM Feature #2252: implement GUI client support
- Code Review Task Branch 1796d Revision 10906
@FillInGuiImpl@, @FrameGuiImpl@, @LabelGuiImpl@, @ScrollPaneGuiImpl@,... - 09:39 AM Feature #2252: implement GUI client support
- Rebased task branch 1796d from P2J trunk revision 10901 (branch revision 10905).
- 01:26 PM Feature #1791: implement dynamic UI support
- Rebased task branch 2026a from P2J trunk revision 10901.
- 07:40 AM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10912@.
The error message tool for @ComboBoxWidget@ is changed... - 08:15 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10911@.
This changes for the following note:
>please test wha... - 07:04 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> I probably wasn't clear. Synchronizing @server->client@ works. I already have @MenuContainerWi... - 06:38 AM Feature #1790: implement menu support
- I probably wasn't clear. Synchronizing @server->client@ works. I already have @MenuContainerWidget.pushMenuDefinition...
- 06:01 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Constantin,
>
> I wanted to answer about your changes after fixing of the bug I'm currently wo... - 05:26 AM Feature #1790: implement menu support
- Constantin,
I wanted to answer about your changes after fixing of the bug I'm currently working on. I need an advi...
07/27/2015
- 06:19 PM Feature #2252: implement GUI client support
- Rebased task branch 2424b from P2J trunk revision 10901 (branch revision 10910).
- 06:06 PM Feature #1811: implement the AJAX client driver
- > Greg, please review "use strict" changes.
I don't see any changes checked into task branch 1811p. I realize yo... - 05:35 PM Feature #1811: implement the AJAX client driver
- Fixed a bug in @rawLine()@ and added polygon support. All of these changes are now integrated back into the 1811o br...
- 10:30 AM Feature #1811: implement the AJAX client driver
- Greg, please review "use strict" changes. The changes are tested for a web chui client of the installed MAJIC with re...
- 05:55 PM Feature #2422: add features to BROWSE
- Just started it.
- 05:53 PM Feature #2422: add features to BROWSE
- Code Review Task Branch 2422b Revision 10912
It looks fine. What is the status of regression testing? - 05:06 PM Feature #2422: add features to BROWSE
- Rebased task branch 2422b from P2J trunk revision 10901.
- 09:28 AM Feature #2422: add features to BROWSE
- Code Review Task Branch 2422b Revision 10908
I'm fine with the changes. - 03:43 PM Feature #2546: implement combo-box widget in GUI
- Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> Please commit the CheckMetricsCb.java file.
Done.
- 01:28 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10910@.
Some cleanup, code unifying and testing performed. I g... - 12:09 PM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546b@ from P2J trunk revision @10901@, new branch revision is @10909@.
- 11:26 AM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10908@.
This is the @TAB@ key processing fix. Preparing to reb... - 12:52 PM Feature #1790: implement menu support
- Vadim, see revision 10919 - the drawing is almost good now. I've added comments where I've made changes - if somethi...
- 07:04 AM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Constantin,
>
> Have a look at @SubMenuGuiImple.draw()@ method and at the second @gd.draw(...
07/26/2015
- 04:34 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause... - 01:50 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause@ removes any existing messag... - 01:42 PM Feature #2252: implement GUI client support
- Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause@ removes any existing messages from the window mess...
- 02:09 PM Feature #1790: implement menu support
- Constantin,
Have a look at @SubMenuGuiImple.draw()@ method and at the second @gd.draw()@ call in it which draws t... - 01:53 PM Feature #2422: add features to BROWSE
- Please review task branch 2422b, revision 10908. Not yet merged with the latest baseline. I've changed approach of ha...
- 01:49 PM Bug #2621: wait-for only works for current-window
- The @wait-for window-close of h or close of h@ where @h@ is a window seems to work, but there some issues:
* solved -... - 01:14 PM Bug #2621 (WIP): wait-for only works for current-window
- Created branch 2621a from trunk rev 10900.
07/25/2015
- 04:17 PM Feature #2252: implement GUI client support
- Please review branch 1796d, rev 10901 - it includes FRAME- attribute support for all cases of frames: it was simple, ...
- 03:28 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> If is enough to just let @BaseEntity.canSetPixelPositionInChui@ return true by default... - 03:24 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, do you have a testcases for this error, when setting the... - 03:22 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, do you have a testcases for this error, when setting the X or Y attribute in ChU... - 03:13 PM Feature #2252: implement GUI client support
- Hynek, do you have a testcases for this error, when setting the X or Y attribute in ChUI:...
- 02:19 PM Feature #2252: implement GUI client support
- Rebased task branch 2424b from P2J trunk revision 10900 (branch revision 10907).
- 09:24 AM Bug #2624: window clear at procedure end
- See #2513 note 62.
If the window doesn't have any explicit pause, instead of terminating, it shows "Procedure comp... - 09:23 AM Bug #2624 (New): window clear at procedure end
- 09:21 AM Bug #2623 (Closed): mouse cursor icons for the window edges sometimes don't change back to the st...
- 09:21 AM Bug #2622 (Closed): width-pixel/height-pixels can't be assigned during create frame
- 09:20 AM Bug #2621: wait-for only works for current-window
- WAIT-FOR needs to be fully generalized to any window handle.
- 09:20 AM Bug #2621 (Closed): wait-for only works for current-window
- 09:19 AM Bug #2620: problems when editable size of a field is smaller than the format length
- If the editable part doesn't fit in the widget, the cursor goes crazy. Both for ChUI and GUI. There may be addition...
- 09:18 AM Bug #2620 (Closed): problems when editable size of a field is smaller than the format length
- 08:55 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
- LAST-EVENT:EVENT-TYPE = "MOUSE" needs to be supported for GUI
- 08:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> I should have been more clear earlier: please implement KEEP-FRAME-Z-ORDER for the window widget ... - 08:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- I should have been more clear earlier: please implement KEEP-FRAME-Z-ORDER for the window widget so that your MOVE-TO...
- 08:14 AM Feature #1801: add some frame options
- The following is the remaining work for this task. These need to be implemented for conversion and runtime for FRAME...
- 07:48 AM Feature #2039 (Rejected): more runtime support for frame options
- 09:01 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10907@.
The update has fix for unable to edit new selected ite...
07/24/2015
- 06:31 PM Feature #1811: implement the AJAX client driver
- I've tried a variety of compositing approaches and other means, to disable or bypass the anti-aliasing.
In the end... - 10:01 AM Feature #1811: implement the AJAX client driver
- I added major tick marks every 10 pixels and minor tick marks every 2 pixels. Attached is a close-up of the results....
- 08:19 AM Feature #1811: implement the AJAX client driver
- Yes, I noticed that. But I am guessing that is something unique to the Java2D implementation and is not needed for a...
- 04:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added conversion support for the WINDOW, WIDGET-ENTER, and WIDGET-LEAVE attributes.
Rebased task branch 2567a from... - 02:58 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- There is a minor incompatibility between p2j and 4GL. If @h@ is a handle with the 'unknown' value then the statement ...
- 08:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> Please go ahead with the GUI implementation of all of these features as part of this task. Of co... - 08:23 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> I was unable to figure any noticeable semantics of the MANUAL-HIGHLIGHT attribute in the Ch... - 07:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Constantin Asofiei wrote:
> I'll take both the runtime and conversion support for these. So please don't spend time... - 06:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Igor Skornyakov wrote:
> 2. As per Constantin the fixes which are required for the FRAME-COL, FRAME-ROW, FRAME-X, an... - 04:08 PM Feature #2546: implement combo-box widget in GUI
- Rebased task branch @2546b@ from P2J trunk revision @10900@ (new branch revision @10906@).
- 03:09 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10903@.
The small fix in scrollbar location for border-less pa... - 01:57 PM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, about @combo_box10.p@, there are some issues:
> > ... - 01:45 PM Feature #2546: implement combo-box widget in GUI
- Constantin Asofiei wrote:
> Eugenie, about @combo_box10.p@, there are some issues:
> * @TAB@ pressing in the combo'... - 01:35 PM Feature #2546: implement combo-box widget in GUI
- Constantin Asofiei wrote:
> * I can't find a way to press the EXIT button via mouse - is this working in rev 10898?
... - 01:34 PM Feature #2546: implement combo-box widget in GUI
- Eugenie, about @combo_box10.p@, there are some issues:
* @TAB@ pressing in the combo's fill-in is not switching focu... - 11:44 AM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10902@.
The fix for @fill-in@ disabled color regression. - 03:07 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10901@.
Some issues:
# the change in ... - 02:04 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Also the standalone program for scaling approach gives OK result with fixed difference that... - 03:01 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> If I'll split sub-menu rectangle by 2 rectangles for a title and for a body, body rectangle wi... - 02:36 PM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Review for branch 1790d, revis... - 02:15 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Review for branch 1790d, revision 10909:
> > * about mnemonic:... - 01:20 PM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Review for branch 1790d, revision 10909:
> * about mnemonic: what happens if there is m... - 07:25 AM Feature #1790: implement menu support
- Review for branch 1790d, revision 10909:
* about mnemonic: what happens if there is more than a @&@ char?
* @Menu.g... - 02:43 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Go ahead and merge to trunk.
Branch 1796c was merged to trunk rev 10900 and archived. Created br... - 02:29 PM Feature #2252: implement GUI client support
- Code Review Task Branch 1796c Revision 10901
I am fine with the changes.
Go ahead and merge to trunk. - 02:22 PM Feature #2252: implement GUI client support
- Please review branch 1796c rev 10900 and 10901:
* 10900: it fixes the TODO in Frame.postprocess (from note 1063)
* ... - 01:16 PM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> Constantin,
>
> The trunk @10899@ after merging @1796b@ introduces significant regression i... - 12:35 PM Feature #2252: implement GUI client support
- Constantin,
The trunk @10899@ after merging @1796b@ introduces significant regression in all my GUI combo-box test... - 08:44 AM Feature #2252: implement GUI client support
- Created branch 1796c from trunk revision 10899.
- 08:32 AM Feature #2252: implement GUI client support
- Branch 1796b revision 10927 was merged to trunk revision 10899. Branch 1796b was archived.
- 08:19 AM Feature #1791: implement dynamic UI support
- Stanislav, if you are adding support for DOWN, please make sure that FRAME:DOWN is supported too.
- 08:13 AM Feature #1791: implement dynamic UI support
- In @methods_attributes.rules@, please add the new attributes (down and query) to the @load_descriptors@ function inst...
- 06:39 AM Feature #1791: implement dynamic UI support
- For CREATE BROWSE created task branch 2026a from P2J trunk revision 10898.
07/23/2015
- 06:43 PM Feature #1811: implement the AJAX client driver
- Btw. the black-filled rounded Java2D rectangles in canvas_drawing_output_comparison_20150723.jpg don't seem to be sym...
- 06:15 PM Feature #1811: implement the AJAX client driver
- Yes, anti-aliasing is probably a more accurate description than color interpolation.
- 06:14 PM Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> ...color interpolation (or compositing, I'm not sure)...
anti-aliasing? - 06:09 PM Feature #1811: implement the AJAX client driver
- I forgot the latest version of the Java2D samples.
- 06:08 PM Feature #1811: implement the AJAX client driver
- Yesterday and today, I have worked on adding color support and 3D rectangle drawing. As part of that I also resolved...
- 03:35 PM Feature #1811: implement the AJAX client driver
- 1811p task branch is created. Branched 10898 revisions
- 02:54 PM Feature #1811 (WIP): implement the AJAX client driver
- > 1811p task branch is created
Please note which trunk revision the branch was created from.
> Greg, what are tests... - 02:26 PM Feature #1811: implement the AJAX client driver
- 1811p task branch is created on devsrv01 with help of create_task_branch.sh
Greg, what are tests we should perform i... - 12:55 PM Feature #1811: implement the AJAX client driver
- The incomplete description of web client and simple server architecture is presented here in order to save time of de...
- 12:40 PM Feature #1811: implement the AJAX client driver
- This article "JavaScript’s Strict Mode and Why You Should Use It" http://cjihrig.com/blog/javascripts-strict-mode-and...
- 08:08 AM Feature #1811: implement the AJAX client driver
- Sergey Ivanovskiy wrote:
> To "use strict"; directive in p2j.js module requires to declare p2j variable explicitly b... - 06:27 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10901@.
The update has several minor GUI fixes including clipp... - 05:16 PM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in ca... - 05:14 PM Feature #2546: implement combo-box widget in GUI
- Constantin Asofiei wrote:
> Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in case of combo-box show a gray ... - 04:30 PM Feature #2546: implement combo-box widget in GUI
- Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in case of combo-box show a gray foreground when disabled? Bec...
- 05:55 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Some suggestions:
>
> 1. What is the "base" unit in GUI mode?
The base unit in GUI is t... - 04:37 AM Feature #2546: implement combo-box widget in GUI
- Some suggestions:
1. What is the "base" unit in GUI mode? Correct me if I'm wrong but looks like it is still @char... - 03:51 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> >Have you proved the formula using the captured metrics?
>
> Constantin, let's clarify t... - 05:44 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- I was unable to figure any noticeable semantics of the MANUAL-HIGHLIGHT attribute in the ChUI.
About the remaining... - 04:06 PM Feature #1790: implement menu support
- Please review the code. Current revision is 10909.
- 03:50 PM Feature #1791: implement dynamic UI support
- Please change the branch name to 2026a. That way we can match up your specific changes with the child task.
- 03:39 PM Feature #1791: implement dynamic UI support
- For CREATE BROWSE created task branch 1791a from P2J trunk revision 10898.
- 03:20 PM Feature #2252: implement GUI client support
- Code Review Task Branch 1796b Revision 10926
1. Should @GenericWidget.finishConfigProcessing()@ be @protected@ ins... - 02:55 PM Feature #2252: implement GUI client support
- I'm OK with the update. There is a regression in 2422b and, besides, there is conflicting change in DOWN processing, ...
- 01:36 PM Feature #2252: implement GUI client support
- Please review branch 1796b revision 10926. It adds support for drawing down frames in GUI, fixes note 1068 and some ...
- 12:33 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> For a future improvement: should we implement an empty @finishConfigProcessing()@ in @GenericWidg... - 11:28 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Are the issues documented in #2567 notes 12 (CA - #1796) and 19 (CA - #1796) already addressed in... - 11:23 AM Feature #2252: implement GUI client support
- Are the issues documented in #2567 notes 12 (CA - #1796) and 19 (CA - #1796) already addressed in 1796b?
Hynek: Ar... - 11:16 AM Feature #2252: implement GUI client support
- In regard to the #1796 remaining items: anything left for later should have its own task created and linked here as a...
- 10:57 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr... - 10:01 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Constantin: what work is left for #1796?
The next issues I have on the list are these (in order if... - 09:15 AM Feature #2252: implement GUI client support
- Code Review Task Branch 1796b Revision 10923
Interesting, I didn't realize that the @num + date@ form of the @+@ o... - 08:17 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Rebased task branch 1796b from P2J trunk revision 10898 (branch revision 10923).
>
> ... - 01:25 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
- This task is for full implementation of the GUI widget implementation for RADIO-SET. Both static and dynamic usage is...
- 01:08 PM Feature #2614 (Closed): implement GUI runtime support for RADIO-SET widget
- 01:09 PM Bug #2613: improve performance of ScreenBitmap.canDraw (and of its callers)
- In GUI, @ScreenBitmap.canDraw@ (and its callers, @getVerticalFragments@ and @getHorizontalFragments@) are used intens...
- 01:04 PM Bug #2613 (New): improve performance of ScreenBitmap.canDraw (and of its callers)
- 12:25 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- This task is for full implementation of the GUI widget implementation for SLIDER. Both static and dynamic usage is ne...
- 12:19 PM Feature #2612 (Closed): implement GUI conversion and runtime support for the SLIDER widget
- 08:03 AM Feature #2422: add features to BROWSE
- Code Review Task Branch 2422b Revision 10907
Everything looks good. If this passes testing, please check it in an...
07/22/2015
- 06:33 PM Feature #2546: implement combo-box widget in GUI
- >Have you proved the formula using the captured metrics?
Constantin, let's clarify this point. Is there the approa... - 05:00 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10900@.
Fixed the @WIDTH-PIXELS@ attribute getting issue.
>... - 03:37 PM Feature #2546: implement combo-box widget in GUI
- Eugenie, please check the @uast/demo/movie-ratings-static.p@ - the combo does not behave OK, the drop-down list is no...
- 09:20 AM Feature #2546: implement combo-box widget in GUI
- >No, other widgets work fine. The problem is with the combo-box implementation.
Yes, you are right. And this is stra... - 04:23 AM Feature #2546: implement combo-box widget in GUI
- Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10899@.
>
> This is the alternative ... - 05:34 PM Feature #2422: add features to BROWSE
- Greg Shah wrote:
> Code Review Task Branch 2422b Revision 10906
>
> Eric: please review the query-related changes... - 05:12 PM Feature #2422: add features to BROWSE
- You should start regression testing with the 10906 revision. We will continue discussing the browse-column support o...
- 02:05 PM Feature #2422: add features to BROWSE
- The 11.x documentation clearly states otherwise:...
- 01:34 PM Feature #2422: add features to BROWSE
- I'm not sure how to enable COMBO-BOX in browse. Even for GUI. ...
- 12:40 PM Feature #2422: add features to BROWSE
- Did you test with COMBO-BOX as a browse column? The error message may have only been formatted that way because the ...
- 12:35 PM Feature #2422: add features to BROWSE
- As far as I tested, they match. Error message for browse column "Unable to assign UNKNOWN value to attribute MODIFIED...
- 12:30 PM Feature #2422: add features to BROWSE
- Code Review Task Branch 2422b Revision 10906
Eric: please review the query-related changes.
My only question: Does ... - 11:44 AM Feature #2422: add features to BROWSE
- Rebased task branch 2422b from P2J trunk revision 10898.
Please review task branch 2422b, revision 10906. - 03:42 PM Bug #2611: problems in UNDERLINE support for ChUI - stream/redirected mode
- For a start, see the @uast/frame_layout/redirected_underline.p@ test - the UNDERLINE (when it proceeds a DISPLAY, DOW...
- 03:38 PM Bug #2611 (New): problems in UNDERLINE support for ChUI - stream/redirected mode
- 02:45 PM Feature #2252: implement GUI client support
- Rebased task branch 1796b from P2J trunk revision 10898 (branch revision 10923).
Please review branch 1796b, revis... - 01:20 PM Feature #1811: implement the AJAX client driver
- To "use strict"; directive in p2j.js module requires to declare p2j variable explicitly by
var p2j = (function()...) - 12:10 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> As far as I understand it, using this option should cause the widget to draw without a highlight.... - 12:07 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- As far as I understand it, using this option should cause the widget to draw without a highlight. The programmer wou...
- 11:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg,
I've implemented the conversion and setters/getters for the MANUAL-HIGHLIGHT attribute, but the only thing I'v...
07/21/2015
- 06:31 PM Feature #2546: implement combo-box widget in GUI
- The picture...
- 06:30 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10899@.
This is the alternative scaling implementation for com... - 06:20 PM Feature #1811: implement the AJAX client driver
- Attached are some samples I am using to get the drawing operations in Javascript to match the Java2D operations that ...
- 06:15 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Rebased task branch 2567a from P2J trunk revision 10898 (new branch revision 10909).
- 02:29 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added INDEX and MANUAL-HIGHLIGHT conversion support. Commited to branch 2567a. New revno 10907
- 10:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added TAB-STOP attribute runtime support. Commited to branch 2567a. New revno 10906.
This took some time because t... - 10:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- I've noticed an incompatilityy between 2GK and p2j. When running the attached program with 4GL all 3 widgets (@a@, @f...
- 05:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- test please ignore
07/20/2015
- 06:05 PM Feature #2252: implement GUI client support
- Rebased task branch 2424b from P2J trunk revision 10897 (branch revision 10898).
- 05:13 PM Feature #2252: implement GUI client support
- Rebased task branch 1796b from P2J trunk revision 10897 (branch revision 10916).
- 05:49 PM Feature #2546: implement combo-box widget in GUI
- Task branch @2546b@ for review updated to revision @10898@.
The fixes including:
1. Fix for wrong initial selecti... - 10:41 AM Feature #2546: implement combo-box widget in GUI
- Created task branch @2546b@ from P2J trunk revision @10897@.
- 10:41 AM Feature #2546: implement combo-box widget in GUI
- The branch @2546a@ has been merged and committed to trunk as revision @10897@. Archived.
- 10:28 AM Feature #2546: implement combo-box widget in GUI
- >Also, somethign else: P2J automatically selects first element in this test, while 4GL does not...
For this issue,... - 08:14 AM Feature #2546: implement combo-box widget in GUI
- Please merge task branch 2546a to trunk, commit and send the notification email.
- 05:17 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- About the FRAME-COL/ROW/X/Y coordinate attributes: the current BaseConfig.column/row/x/y fields are actually for the ...
- 03:02 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Greg Shah wrote:
> > Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this t... - 03:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- > Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this task?
Yes. - 01:34 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added NO-TAB-STOP option and TAB-STOP attribute conversion support. Commited to branch 2567a. New revno 10905.
Gre... - 11:45 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added CONTEXT-HELP-ID conversion and runtime support. Commited to branch 2567a. New revno 10904
- 11:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added DEBLANK conversion and runtime support. Commited to branch 2567a. New revno 10903
- 07:23 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added BLANK conversion and runtime support. Commited to branch 2567a. New revno 10902
- 05:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added PASSWORD-FIELD runtime support. Commited to branch 2567a. New revno 10901
- 03:45 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> 1. What about the case of letters? Note, that "PgDn" is shown in the specified testcase, but D... - 03:29 PM Feature #1790: implement menu support
- Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Here it is
> >
> > [...]
> >
> > Have a look how the menu... - 03:09 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> Here it is
>
> [...]
>
> Have a look how the menu-item "Mi1 item" looks. It's accelerato... - 02:32 PM Feature #1790: implement menu support
- Here it is...
- 02:16 PM Feature #1790: implement menu support
- Greg Shah wrote:
> Greg Shah wrote:
> > > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labe... - 10:11 AM Feature #1790: implement menu support
- Greg Shah wrote:
> > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN... - 10:04 AM Feature #1790: implement menu support
- > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN", "NEXT-PAGE", "NEX...
- 10:22 AM Feature #2422: add features to BROWSE
- It is OK to base your work on the unoptimized/current approach, but please:
1. Add a comment to the @ConfigManager... - 10:19 AM Feature #2422: add features to BROWSE
- That is interesting:...
- 09:54 AM Feature #2422: add features to BROWSE
- > # Widget re-creation resets its backup configuration. Backup configuration should match the previous state sent to ...
- 09:19 AM Feature #2422: add features to BROWSE
- Rebased task branch 2422b from P2J trunk revision 10896.
- 05:24 AM Feature #2422: add features to BROWSE
- Greg, for editing cells we have a single @FillInWidget@ for each column. Its configuration is send to the client and ...
07/19/2015
- 06:03 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
- Added PASSWORD-FIELD conversion support. Commited to branch 2567a. New revno 10900
- 03:15 PM Feature #1790: implement menu support
- It seems, that GUI menu widgets use only system colors. Documentation says that it is possible to set bgcolor and fgc...
Also available in: Atom