FWD » Core Development » User Interface

09/15/2017

04:24 PM Feature #3281: implement some frame options

Greg,
You are right. I updated the code accordingly. Committed as r11241. Ovidiu Maxiniuc

03:10 PM Feature #3281: implement some frame options

Ovidiu Maxiniuc wrote:
> Why should have it been dropped?
I meant FWD previously dropped it, not that it should.
Constantin Asofiei

02:57 PM Feature #3281: implement some frame options

Code Review Task branch 3330a Revision 11240
This is very close.
1. I think the unconditional use of @(String) ... Greg Shah

02:40 PM Feature #3281: implement some frame options

Constantin Asofiei wrote:
> Ovidiu, while you are at it, there is another case where I think the condition is droppe... Ovidiu Maxiniuc

02:16 PM Feature #3281: implement some frame options

Ovidiu, while you are at it, there is another case where I think the condition is dropped: if the @VALEXP "not CAN-FI... Constantin Asofiei

02:05 PM Feature #3281: implement some frame options

I moved the code into Progress parser. In fact I used the already existing code from @resolveLvalueCoreType@.
Suppo... Ovidiu Maxiniuc

03:14 PM Feature #3284: implement more window widget support

Hynek, review for 3284b rev 11174:
# have you tested how @window-delayed-minimize@ and @ALWAYS-ON-TOP@ work with par... Constantin Asofiei

01:41 PM Feature #3275: improve browse support

Somehow I didn't notice that the failing step was now 41 not 40. I guess that came with your MAJIC update. Greg Shah

12:03 PM Feature #3275: improve browse support

Greg Shah wrote:
> Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_00... Constantin Asofiei

11:25 AM Feature #3275: improve browse support

Greg Shah wrote:
> Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_00... Ovidiu Maxiniuc

10:40 AM Feature #3275: improve browse support

3275b was merged into 3330a as revision 11238. Stanislav Lomany

09:07 AM Feature #3275: improve browse support

> Should I check 3275b into trunk?
We are trying to get 3330a and 3222a into the trunk as priorities. However, th... Greg Shah

09:05 AM Feature #3275: improve browse support

Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_002 now gets past step... Greg Shah

04:20 AM Feature #3275: improve browse support

Regression testing for 3275b passed. The only thing is that IIRC @tc_job_002@ was failing with ... Stanislav Lomany

09/14/2017

05:21 PM Feature #3281: implement some frame options

I understand. I will adjust the code as Greg suggested. Ovidiu Maxiniuc

05:19 PM Feature #3281: implement some frame options

Greg Shah wrote:
> Code Review Task Branch 3330a Revision 11237
>
> Eric: please review and comment.
Greg, I agr... Eric Faulhaber

05:18 PM Feature #3281: implement some frame options

To be clear about this, I am proposing that all the processing for this be removed from @SchemaDictionary@ (and @Symb... Greg Shah

05:02 PM Feature #3281: implement some frame options

Code Review Task Branch 3330a Revision 11237
Eric: please review and comment.
1. My sense is that this is encod... Greg Shah

04:42 PM Feature #3281: implement some frame options

Committed as revision 11237. Ovidiu Maxiniuc

04:33 PM Feature #3281: implement some frame options

Yes, please do. Greg Shah

04:31 PM Feature #3281: implement some frame options

Greg, I have a fix for this issue. It works fine for my testcases. Shall I commit it to 3330a for review? Ovidiu Maxiniuc

02:18 PM Feature #3281: implement some frame options

> Doesn't such a match need to consider and handle abbreviations?
Yes. It should handle abbreviations and case-in... Greg Shah

01:33 PM Feature #3281: implement some frame options

Maybe I'm missing something, but it seems like it is more complicated than that. Doesn't such a match need to conside... Eric Faulhaber

12:30 PM Feature #3281: implement some frame options

I think the method could be something like @boolean SchemaDictionary.specificFieldMatch(String candidate, String sche... Greg Shah

12:18 PM Feature #3281: implement some frame options

Greg Shah wrote:
> How about if the @SchemaDictionary@ provided a worker method to compare the candidate field name ... Eric Faulhaber

12:11 PM Feature #3281: implement some frame options

Eric: Do you have any guidance here? Greg Shah

12:10 PM Feature #3281: implement some frame options

> use a ProgresParser member field to store the field when attaching schema validators. It should contain the name of... Greg Shah

11:56 AM Feature #3281: implement some frame options

Greg Shah wrote:
> Ovidiu: Are you working this one?
Yes, I am using the testcase to go step-by-step and try to f... Ovidiu Maxiniuc

11:45 AM Feature #3281: implement some frame options

Ovidiu: Are you working this one? Greg Shah

11:44 AM Feature #3281: implement some frame options

> We need to introduce some exception when computing the parent table of an unqualified field in the case of the vali... Greg Shah

04:17 PM Feature #3284: implement more window widget support

Hynek Cihlar wrote:
> In Web GUI when overlay window is opened (combo box dropdown) and an action is performed that ... Hynek Cihlar

08:26 AM Feature #3284: implement more window widget support

3284b revision 11173 passed ChUI regression testing and GUI regression testing with one condition. In Web GUI when ov... Hynek Cihlar

09/13/2017

04:03 PM Feature #3275: improve browse support

I just realized that validation statements for browse are not properly converted when it comes to the validated varia... Stanislav Lomany

06:22 AM Feature #3275: improve browse support

There are multiple browse issues that has been found during testing:
# Scroll by mouse wheel doesn't work if the poi... Stanislav Lomany

11:00 AM Feature #3260: auto-conversion and enablement for the embedded web client

Constantin Asofiei wrote:
> > @beforeConfigValueSet@ or @afterApplyConfig@ should be called, too. Otherwise @afterCo... Hynek Cihlar

10:53 AM Feature #3260: auto-conversion and enablement for the embedded web client

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Are the methods @beforeConfigValueSe... Constantin Asofiei

10:33 AM Feature #3260: auto-conversion and enablement for the embedded web client

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Are the methods @beforeConfigValueSet()@ and @afterApplyConfig(... Hynek Cihlar

10:26 AM Feature #3260: auto-conversion and enablement for the embedded web client

Hynek Cihlar wrote:
> Are the methods @beforeConfigValueSet()@ and @afterApplyConfig()@ in @SyncConfigChangesAspect@... Constantin Asofiei

10:14 AM Feature #3260: auto-conversion and enablement for the embedded web client

Constantin Asofiei wrote:
> I was expecting that @ConfigManager.applyConfigUpdates@ called on server-side by @Logica... Hynek Cihlar

09:46 AM Feature #3260: auto-conversion and enablement for the embedded web client

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, quick question: is it me or @afterConfigUpdate@ is never... Constantin Asofiei

09:36 AM Feature #3260: auto-conversion and enablement for the embedded web client

Constantin Asofiei wrote:
> Hynek, quick question: is it me or @afterConfigUpdate@ is never called on server-side?
... Hynek Cihlar

09:22 AM Feature #3260: auto-conversion and enablement for the embedded web client

Hynek, quick question: is it me or @afterConfigUpdate@ is never called on server-side? Constantin Asofiei

09/12/2017

01:51 PM Feature #3284: implement more window widget support

FYI, I had to revert the changes from trunk revision 11145 in Swing GUI driver related to window activation. The revi... Hynek Cihlar

09/11/2017

02:34 PM Feature #3275: improve browse support

For now we will leave combo-box support for #2628. Greg Shah

01:35 PM Feature #3275: improve browse support

> 5. What is your estimate of the effort needed to implement @COMBO-BOX@?
I think conversion + runtime will take a... Stanislav Lomany

02:32 PM Feature #2628: Non-fill-in column support in browse.

@TOGGLE-BOX@ support has been implemented in #3275 (branch 3275b). Stanislav estimates 1 week to implement conversio... Greg Shah

02:16 PM Feature #3281: implement some frame options

I've done some investigations related to the issue from note 20. The decision where the unqualified field belongs to ... Ovidiu Maxiniuc

12:19 PM Feature #3284: implement more window widget support

Greg Shah wrote:
> I assume you can match the behavior exactly in the web client virtual desktop mode. Correct? We... Hynek Cihlar

11:47 AM Feature #3284: implement more window widget support

> This makes it impossible to fully support the runtime behavior of WINDOW:TOP-ONLY and WINDOW:ALWAYS-ON-TOP attribut... Greg Shah

10:03 AM Feature #3284: implement more window widget support

With trunk revision 11145 (among the other benefits) we lost the flexibility of arbitrary stacking top-level windows ... Hynek Cihlar

09:43 AM Feature #3284: implement more window widget support

Hynek,
OK. Please report this in 3284.
This branch will merge to trunk after 3330a and 3222a.
Thanks,
Gre... Hynek Cihlar

09/08/2017

04:08 PM Feature #3281: implement some frame options

While working on #3330 I identified a conversion issue: if normally in a CAN-FIND (or other query) an field without w... Ovidiu Maxiniuc

08:57 AM Feature #3284: implement more window widget support

> A potential issue may be Swing and its window positioning limitations - the native 4GL behavior cannot be expressed... Greg Shah

08:51 AM Feature #3284: implement more window widget support

Greg Shah wrote:
> Please provide some details of the issues related to @ALWAYS-ON-TOP@.
There are not really any... Hynek Cihlar

08:43 AM Feature #3284: implement more window widget support

Please provide some details of the issues related to @ALWAYS-ON-TOP@. Greg Shah

09/06/2017

12:07 PM Feature #3275: improve browse support

Code Review Task Branch 3275b Revision 11169
The changes look good.
1. @Browse.getCellTextNoError()@ should be ... Greg Shah

09:27 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> Code Review Task Branch 1834b Revision 11186
>
> I'm fine with the changes.
>
> We are tryi... Eugenie Lyzenko

08:07 AM Feature #1834: implement direct manipulation (drag and drop)

Code Review Task Branch 1834b Revision 11186
I'm fine with the changes.
We are trying to get 3330a and 3222a in... Greg Shah

10:39 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11186@.
This is the note 4 resolution. All intern... Eugenie Lyzenko

09:09 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

I prefer having a single worker that is unfinished instead of multiple independent locations that are not done. I ag... Greg Shah

02:36 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: Please review 3330a revision 11189 for the initial runtime s... Hynek Cihlar

08:33 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

Greg Shah wrote:
> Eugenie: Please review 3330a revision 11189 for the initial runtime stubs that were needed. Also... Eugenie Lyzenko

09/05/2017

05:46 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> Code Review Task Branch 1834b Revision 11184
>
> I've checked in some fixes for typos and codi... Eugenie Lyzenko

12:38 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> 3. Please change EVL to SBI for those files where the changes were written by Sergey. Otherwise ... Eugenie Lyzenko

12:25 PM Feature #1834: implement direct manipulation (drag and drop)

Code Review Task Branch 1834b Revision 11184
I've checked in some fixes for typos and coding standards.
1. The ... Greg Shah

11:24 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> Since the ESC behavior doesn't exist in the 4GL, we will avoid it for now.
OK.

> Please do... Eugenie Lyzenko

10:30 AM Feature #1834: implement direct manipulation (drag and drop)

Since the ESC behavior doesn't exist in the 4GL, we will avoid it for now.
Please do the cleanup. Greg Shah

10:19 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > I think Sergey is done with his part of the work (the JS file upload)... Eugenie Lyzenko

10:03 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> I think Sergey is done with his part of the work (the JS file upload).
>
> Eugenie: is there a... Eugenie Lyzenko

09:42 AM Feature #1834: implement direct manipulation (drag and drop)

I think Sergey is done with his part of the work (the JS file upload).
Eugenie: is there anything more to do on th... Greg Shah

09:41 AM Feature #1834: implement direct manipulation (drag and drop)

> Greg: do you want to do this in a different task? Because I would like to see how triggers and maybe other UI stuff... Greg Shah

09:38 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> Constantin,
>
> Look at @Editor@, line 954:
> [...]
>
> The method @Keyboard.isPrint... Constantin Asofiei

09:32 AM Feature #1834: implement direct manipulation (drag and drop)

Constantin,
Look at @Editor@, line 954:... Eugenie Lyzenko

08:50 AM Feature #1834: implement direct manipulation (drag and drop)

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > The idea. Instead of looping through every char in substring... Eugenie Lyzenko

08:43 AM Feature #1834: implement direct manipulation (drag and drop)

Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > The idea. Instead of looping through every char in substring... Eugenie Lyzenko

07:52 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> The idea. Instead of looping through every char in substring we can compute full substring ... Constantin Asofiei

09:05 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Please review committed revision 11182 that changed @p2j.socket.js@ to send a packet of p... Eugenie Lyzenko

12:36 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

Eugenie: Please review 3330a revision 11189 for the initial runtime stubs that were needed. Also, please review 3332... Greg Shah

12:30 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

3332a revision 11164 implements full conversion support for the missing @LOAD-IMAGE*@ overloads. It also adds initial... Hynek Cihlar

12:21 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...

FWD is missing conversion and runtime support for the following methods @IMAGE:LOAD-IMAGE()@, @BUTTON:LOAD-IMAGE()@, ... Hynek Cihlar

11:15 AM Feature #3332 (Closed): Add support for load offset and load size parameters of LOAD-IMAGE* metho...

Hynek Cihlar

09/03/2017

06:40 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Eugenie, I don't understand, please explain why @sendDropFileNotify@ should arrive before... Eugenie Lyzenko

03:12 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, I don't understand, please explain why @sendDropFileNotify@ should arrive before @uploadFileToJava@ message ... Sergey Ivanovskiy

12:14 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> The canvas image can be broken if its window is moved during the file uploading.
> !Msgs... Eugenie Lyzenko

11:25 AM Feature #1834: implement direct manipulation (drag and drop)

Please review committed revision 11182 that changed @p2j.socket.js@ to send a packet of partial messages without recu... Sergey Ivanovskiy

10:34 AM Feature #1834: implement direct manipulation (drag and drop)

The canvas image can be broken if its window is moved during the file uploading.
!MsgsInterleaving.png! Sergey Ivanovskiy

09/02/2017

08:09 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11181@.
Fix for array invalid index issue in @Edi... Eugenie Lyzenko

09/01/2017

06:18 PM Feature #1834: implement direct manipulation (drag and drop)

Committed revision 11180 changed(added new methods) DragDropHelper, ClientProtocolHooks to use file channels for file... Sergey Ivanovskiy

05:20 PM Feature #1834: implement direct manipulation (drag and drop)

Prepared the fix for Unicode chars.
The idea. Instead of looping through every char in substring we can compute fu... Eugenie Lyzenko

01:30 PM Feature #1834: implement direct manipulation (drag and drop)

> I guess this issue is not one of our priority and adding Cyrillic support can be postponed.
Actually, I think th... Greg Shah

01:18 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> What is about the issue in the note 214?
The investigation:
1. The font width array w... Eugenie Lyzenko

12:28 PM Feature #1834: implement direct manipulation (drag and drop)

Ok, understand now. There is the design issue that @WebClientProtocol.AppendMessageTask@ saves the whole message into... Sergey Ivanovskiy

12:16 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Another question related to this implementation is that we have a message type MSG_FILE_U... Eugenie Lyzenko

12:11 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > The task branch @1834b@ has been updated for review to revisi... Eugenie Lyzenko

11:59 AM Feature #1834: implement direct manipulation (drag and drop)

Another question related to this implementation is that we have a message type MSG_FILE_UPLOADING with its 32-bit fie... Sergey Ivanovskiy

11:45 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> The task branch @1834b@ has been updated for review to revision @11179@.
>
> This is min... Sergey Ivanovskiy

10:48 AM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11179@.
This is minor code cleanup(@DragDropHelpe... Eugenie Lyzenko

09:10 AM Feature #1834: implement direct manipulation (drag and drop)

I will take this part to implement MSG_FILE_UPLOADING from file channels on the java client side too if there are no ... Sergey Ivanovskiy

08:19 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, please review the changes in 11178, 11177. We need to implement uploading files from file channels, but now ... Sergey Ivanovskiy

08:04 AM Feature #1834: implement direct manipulation (drag and drop)

May be this extra 16 bytes are related to the protocol format that must carry the payload data. https://tools.ietf.or... Sergey Ivanovskiy

07:31 AM Feature #1834: implement direct manipulation (drag and drop)

Ok, don't understand this extra 16 bytes that was added to the wss message? Please update src/com/goldencode/p2j/ui/c... Sergey Ivanovskiy

06:51 AM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Eugenie, you added MSG_SET_UPLOAD_FILE_SIZE_LIMITS message type. It is useful if this lim... Eugenie Lyzenko

05:00 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, you added MSG_SET_UPLOAD_FILE_SIZE_LIMITS message type. It is useful if this limit is changed during the app... Sergey Ivanovskiy

10:17 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11175@.
This update adds ability to configure fil... Eugenie Lyzenko

03:19 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...

> Maybe we can let our driver inform the client of the current window's menu?
Yes, I think that makes good sense. Greg Shah

03:10 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...

Greg Shah wrote:
> Constantin: I don't see a need for anything at conversion. It seems like we can do it all at run... Constantin Asofiei

02:54 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...

This is an extension of the idea in #3260-3. The key here is that instead of doing this at conversion time, we shoul... Greg Shah

02:48 PM Feature #3331 (Closed): translate 4GL menu widget processing into a standardized embedded web cli...

Greg Shah

01:37 PM Feature #3283: add 4GL extension to obtain the mouse pointer location

> Do we have any place (a wiki page) where we document the 4GL language extensions?
There are entries in this loca... Greg Shah

01:32 PM Feature #3282: create a 4GL language extension to control screen refresh

Can this task be closed? Greg Shah

08:31 AM Feature #3275: improve browse support

When you have time, please review task branch 3275b rev 11169. Stanislav Lomany

03:21 AM Feature #3275: improve browse support

Rebased task branch 3275b from P2J trunk revision 11163. Stanislav Lomany

08/31/2017

02:23 PM Feature #1834: implement direct manipulation (drag and drop)

I think we should use streams here. Sergey Ivanovskiy

02:06 PM Feature #1834: implement direct manipulation (drag and drop)

Ok, thank you. It seems that we need to do some changes in @WebClientProtocol.AppendMessageTask@ because the file con... Sergey Ivanovskiy

02:00 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Eugenie, please help what 4GL examples should I use for tests with large files? There are... Eugenie Lyzenko

01:56 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> It seems that the uploading files without slicing are done except these configurable para... Eugenie Lyzenko

01:48 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, please help what 4GL examples should I use for tests with large files? There are uast/drag_n_drop? Sergey Ivanovskiy

01:41 PM Feature #1834: implement direct manipulation (drag and drop)

It seems that the uploading files without slicing are done except these configurable parameters in the directory, cor... Sergey Ivanovskiy

01:34 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Eugenie, Greg, should I take this JS part to upload files that exceed 1Gb?
Yes. If th... Greg Shah

01:12 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, Greg, should I take this JS part to upload files that exceed 1Gb? Sergey Ivanovskiy

12:21 PM Feature #1834: implement direct manipulation (drag and drop)

I just found that https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/length the a... Sergey Ivanovskiy

11:56 AM Feature #1834: implement direct manipulation (drag and drop)

Another argument can be that the available memory that can be used to allocate the binary array on the client to hold... Sergey Ivanovskiy

11:41 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
>
> > What file size is a criteria to start splitting it into slices?
>
> I imagine it may va... Sergey Ivanovskiy

10:51 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> It may be best for Sergey to take the JS file uploading part. What do you think?
I have no ob... Eugenie Lyzenko

10:30 AM Feature #1834: implement direct manipulation (drag and drop)

It may be best for Sergey to take the JS file uploading part. What do you think? Greg Shah

10:28 AM Feature #1834: implement direct manipulation (drag and drop)

> Probably we need a way to override this defaults within directory.
Yes.
> The question about large file. Do w... Greg Shah

10:26 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11174@.
The update implements file synchronizatio... Eugenie Lyzenko

08/30/2017

10:17 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> > 4. When processing of the dropped files completes and the method END-FILE-DROP() is calling the... Eugenie Lyzenko

08/29/2017

11:34 AM Feature #2368: allow widget output to stream in GUI mode

Interesting finding about @stream-io@, it overrides all view-as clauses and forced them to a text widget type. This w... Greg Shah

10:28 AM Feature #3275: improve browse support

In #3330 we found there is an undocumented usage of NUM-ENTRIES as a browse attribute. 3330a has conversion support ... Greg Shah

08:48 AM Feature #1834: implement direct manipulation (drag and drop)

> 4. When processing of the dropped files completes and the method END-FILE-DROP() is calling the FWD on the Java sid... Greg Shah

08:52 PM Feature #1834: implement direct manipulation (drag and drop)

Taking into account the parallel processing environments, file size issues and runtime resource limitations the imple... Eugenie Lyzenko

08/28/2017

04:42 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> > So I would suggest to postpone actual file uploading up to moment it become really required to ... Eugenie Lyzenko

04:23 PM Feature #1834: implement direct manipulation (drag and drop)

> So I would suggest to postpone actual file uploading up to moment it become really required to open/load. Then we c... Greg Shah

12:50 PM Feature #1834: implement direct manipulation (drag and drop)

The point to discuss for file uploading approach.
1. Yes, for the cases when web client and Java client part are r... Eugenie Lyzenko

04:37 AM Feature #1834: implement direct manipulation (drag and drop)

Eugenie, do you need my help to work with @FileReader@ and @Blob@. I am worried because @Blob.slice@ method has diffe... Sergey Ivanovskiy

10:43 AM Feature #3275: improve browse support

Stanislav Lomany wrote:
> Toggle-box values of calc columns are NOT displayed in Progress 10.2, definitely it is a p... Greg Shah

10:35 AM Feature #3275: improve browse support

Toggle-box values of calc columns are NOT displayed in Progress 10.2, definitely it is a progress bug. Works as expec... Stanislav Lomany

08/25/2017

05:56 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been rebased with trunk @11163@. New revision is @11172@. Eugenie Lyzenko

04:45 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11171@.
Some minor clean up and fix for drop targ... Eugenie Lyzenko

03:56 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Although for very large files we should think more. Please look at https://www.codeprojec... Greg Shah

03:54 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been rebased with trunk @11162@. New revision is @11170@. Eugenie Lyzenko

03:41 PM Feature #1834: implement direct manipulation (drag and drop)

Although for very large files we should think more. Please look at https://www.codeproject.com/Articles/830704/Gigabi... Sergey Ivanovskiy

03:00 PM Feature #1834: implement direct manipulation (drag and drop)

Constantin Asofiei wrote:
> > # Long way is to make this upload in FWD, opening file for reading and sending conte... Sergey Ivanovskiy

02:51 PM Feature #1834: implement direct manipulation (drag and drop)

My understanding is that file content can be read using the browser's File API, there are several usages of this API ... Sergey Ivanovskiy

02:50 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> Now we need to have a way to copy the content of the file from browser JS code to some @tmp... Constantin Asofiei

02:47 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> It seems that the drag and drop is used exactly in this case when you are dragging the OS... Eugenie Lyzenko

02:37 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> One note here. We implementing operation on files dragged from OS file system, meaning outs... Sergey Ivanovskiy

02:26 PM Feature #1834: implement direct manipulation (drag and drop)

Sergey Ivanovskiy wrote:
> Ok. There is also the Firefox resource with the concrete examples how to drag and drop fi... Eugenie Lyzenko

02:09 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> > You can see the path-less files as I noted before.
>
> I don't think this is a problem so lo... Sergey Ivanovskiy

01:31 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been rebased with trunk @11161@. New revision is @11169@. Eugenie Lyzenko

12:51 PM Feature #1834: implement direct manipulation (drag and drop)

> You can see the path-less files as I noted before.
I don't think this is a problem so long as we can automatical... Greg Shah

12:46 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> > Dropped file names are getting without path. Need to find a way to get the path to match 4gl be... Eugenie Lyzenko

12:44 PM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> The @drop-target@ attribute is not marked correctly in gap marking. The conversion should be mar... Eugenie Lyzenko

12:44 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11168@.
This introduce first working web client i... Eugenie Lyzenko

12:05 PM Feature #1834: implement direct manipulation (drag and drop)

The @drop-target@ attribute is not marked correctly in gap marking. The conversion should be marked as full in the t... Greg Shah

08:35 AM Feature #1834: implement direct manipulation (drag and drop)

> Dropped file names are getting without path. Need to find a way to get the path to match 4gl behavior.
Consider ... Greg Shah

10:31 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11167@.
First steps to get web client drop target... Eugenie Lyzenko

05:52 PM Feature #3284: implement more window widget support

Rebased 3284b against trunk 11163. Hynek Cihlar

05:42 PM Feature #3284: implement more window widget support

3284a merged to trunk as revision 11163 and archived. Hynek Cihlar

05:25 PM Feature #3284: implement more window widget support

Great! Please merge to trunk. Greg Shah

05:24 PM Feature #3284: implement more window widget support

3284a conversion test passed. Hynek Cihlar

05:23 PM Feature #3284: implement more window widget support

Greg Shah wrote:
> Code Review Task branch 3284a Revision 11185
>
> I'm fine with the changes.
>
> One questio... Hynek Cihlar

05:19 PM Feature #3284: implement more window widget support

Hynek Cihlar wrote:
> Removed all cumulative runtime changes from 3284a and kept only conversion changes. The remove... Hynek Cihlar

05:11 PM Feature #3284: implement more window widget support

Code Review Task branch 3284a Revision 11185
I'm fine with the changes.
One question: Shouldn't the gap marking... Greg Shah

04:57 PM Feature #3284: implement more window widget support

Greg Shah wrote:
> I think there is a problem with the branch. It has quite a bit of mess from the rebase.
Sorry... Hynek Cihlar

04:48 PM Feature #3284: implement more window widget support

I think there is a problem with the branch. It has quite a bit of mess from the rebase. Greg Shah

04:42 PM Feature #3284: implement more window widget support

Removed all cumulative runtime changes from 3284a and kept only conversion changes. The removed changes will go to 32... Hynek Cihlar

02:57 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg Shah wrote:
> OK, then you can merge to trunk after that is backed out. It is the only thing that is "dangerou... Constantin Asofiei

02:25 PM Feature #3260: auto-conversion and enablement for the embedded web client

OK, then you can merge to trunk after that is backed out. It is the only thing that is "dangerous" in your update, a... Greg Shah

02:17 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg, I need to backout the virtual session deadlock fix - I think is causing problems when connecting. I'll save the... Constantin Asofiei

12:17 PM Feature #3260: auto-conversion and enablement for the embedded web client

Code Review Task Branch 3260a Revision 11174
I'm good with the changes. The result is quite good. Greg Shah

12:07 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg, I've rebased 3260a with trunk 11161 and 3260a rev 11174 contains latest changes. The final approach is for the... Constantin Asofiei

10:55 AM Feature #3260: auto-conversion and enablement for the embedded web client

Code Review Task branch 3260a Revision 11172
I think the @PatternEngine@ should probably have @clearNewProgramFile... Greg Shah

01:42 PM Feature #3275: improve browse support

The browse option @validate@ needs to be added to gap analysis marking. Greg Shah

11:44 AM Feature #1818 (Closed): implement a timer service to replace the PSTimer OCX

Greg Shah

11:38 AM Feature #1818: implement a timer service to replace the PSTimer OCX

Branch 1818a was merged to trunk as revision 11161. Notification was sent to team. Test result an task branch were ar... Ovidiu Maxiniuc

08/24/2017

12:01 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11166@.
This has reworked approach to get drop ta... Eugenie Lyzenko

11:11 AM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been rebased with trunk @11160@. New revision is @11165@. Eugenie Lyzenko

11:01 AM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11164@.
This is working drag-and-drop implementat... Eugenie Lyzenko

10:54 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11163@.
Adding @Widget.java@ change missed in pre... Eugenie Lyzenko

10:32 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been rebased with trunk @11159@. New revision is @11162@. Eugenie Lyzenko

10:12 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11161@.
This is the partial implementation for co... Eugenie Lyzenko

11:36 AM Feature #1818: implement a timer service to replace the PSTimer OCX

Code Review Task branch 1818a Revision 11189
The changes look good. Please put this through testing. If this pas... Greg Shah

10:46 AM Feature #1818: implement a timer service to replace the PSTimer OCX

It was rather late last night to start the investigation on the COM_PARAMETER issue.
After rebasing the two new revi... Ovidiu Maxiniuc

10:19 AM Feature #3284: implement more window widget support

3284a rebased against trunk revision 11160. Hynek Cihlar

08:34 AM Feature #3284: implement more window widget support

> I will start regression testing of 3284a without the open items above and deal with them in a new branch.
Yes, ... Greg Shah

08:29 AM Feature #3284: implement more window widget support

Code Review Task Branch 3284a Revision 11175
I like the use of default in the window hierarchy. The window state ... Greg Shah

09:29 PM Feature #3284: implement more window widget support

3284a revision 11175 resolves most of this issue except:
* runtime support of ALWAYS-ON-TOP
* when window is minimi... Hynek Cihlar

08/23/2017

05:30 PM Feature #3275: improve browse support

Created task branch 3275b from trunk revision 11159. Stanislav Lomany

03:44 PM Feature #3275: improve browse support

I'll update gap analysis and merge now. Stanislav Lomany

10:47 AM Feature #3275: improve browse support

The gap analysis rules need to be updated for the latest changes. ChUI conversion regression test will be sufficient... Greg Shah

10:16 AM Feature #3275: improve browse support

Did both conversion and runtime ChUI regression testing pass for rev 11194/11196?
I don't think that ChUI regressi... Greg Shah

10:13 AM Feature #3275: improve browse support

Code Review Task Branch 2892a Revision 11191
I'm fine with the changes. Greg Shah

05:10 PM Feature #3260: auto-conversion and enablement for the embedded web client

> I think this can be done as a distinct phase just at the beginning of ConversionDriver.back, conditionally via a ad... Greg Shah

05:09 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg Shah wrote:
> Are you referring to the helper methods in @ConversionDriver@? That would be OK.
OK, I'll cle... Constantin Asofiei

05:01 PM Feature #3260: auto-conversion and enablement for the embedded web client

Are you referring to the helper methods in @ConversionDriver@? That would be OK.
I guess you don't need the new... Greg Shah

04:59 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg, do you want me to keep the conversion changes related to add new, generated, ASTs to the source list? I don't t... Constantin Asofiei

04:38 PM Feature #2892 (Closed): Implement browse scrolling with mouse wheel

Greg Shah

04:28 PM Feature #2892: Implement browse scrolling with mouse wheel

2892a has been merged into the trunk as bzr revision 11159.
Stanislav Lomany

04:37 PM Feature #1818: implement a timer service to replace the PSTimer OCX

Code Review Task Branch 1818a Revision 11186
I'm fine with the changes except for the retention of the COM_PARAMET... Greg Shah

04:06 PM Feature #1818: implement a timer service to replace the PSTimer OCX

I did. The changes are more extensive. Please see the revision 11186. There are a couple of other fixes (in @comments... Ovidiu Maxiniuc

02:28 PM Feature #1818: implement a timer service to replace the PSTimer OCX

> 1. Do you have an example AST for DISABLE TRIGGERS which has a SYMBOL as the table reference?
> ...
> The AST... Greg Shah

02:10 PM Feature #1818: implement a timer service to replace the PSTimer OCX

Greg Shah wrote:
> Code Review Task Branch 1818a Revision 11184
>
> 1. Do you have an example AST for DISABLE TRI... Ovidiu Maxiniuc

11:39 AM Feature #1818: implement a timer service to replace the PSTimer OCX

Code Review Task Branch 1818a Revision 11184
1. Do you have an example AST for DISABLE TRIGGERS which has a SYMBOL... Greg Shah

09:53 AM Feature #1834: implement direct manipulation (drag and drop)

Greg Shah wrote:
> > The key point for file list handling is to install custom TransferHandler for JFrame or JDialog... Eugenie Lyzenko

09:15 AM Feature #1834: implement direct manipulation (drag and drop)

> The key point for file list handling is to install custom TransferHandler for JFrame or JDialog. These two java cla... Greg Shah

10:06 PM Feature #1834: implement direct manipulation (drag and drop)

The investigation performed to make implementation plan:
# The good news is we can use embedded Java functionality... Eugenie Lyzenko

08/22/2017

04:31 PM Feature #2892: Implement browse scrolling with mouse wheel

Branch 2892a revision 11196 passed regression testing, can be merged after your review. Stanislav Lomany

01:34 AM Feature #2892: Implement browse scrolling with mouse wheel

Greg, please review 2892a revision 11194 (not the last one), it has passed regression testing. Stanislav Lomany

04:14 PM Feature #3284: implement more window widget support

Greg Shah wrote:
> In the method implementation, why not return @integer[]@ instead of @BDT[]@?
No good reason ... Hynek Cihlar

04:04 PM Feature #3284: implement more window widget support

>> 3. Why is GET-MOUSE-POINTER defined as METH_POLY in SignatureHelper?
>
> What type to use? The method returns Ba... Greg Shah

03:56 PM Feature #3284: implement more window widget support

Greg Shah wrote:
> Code Review Task Branch 3284a Revision 11189
>
> 1. In @methods_attributes.rules@, I don't thi... Hynek Cihlar

03:40 PM Feature #3284: implement more window widget support

Code Review Task Branch 3284a Revision 11189
1. In @methods_attributes.rules@, I don't think you need to use @ and... Greg Shah

08:59 AM Feature #2676: implement the equivalent to configurable support for a windows theme

The following is some useful information from Ovidiu about how he created the themes. @windev01@ and @windev02@ are ... Greg Shah

07:24 AM Feature #3275: improve browse support

How can I check out how win8 theme should look? Stanislav Lomany

07:19 AM Feature #3275: improve browse support

*2892a revision 11194 contains:*
CURRENT-COLUMN
INDEX
COLUMN-READ-ONLY
ROW-HEIGHT-PIXELS
BUFFER-FIELD
Metho... Stanislav Lomany

07:18 AM Feature #3275: improve browse support

Stanislav Lomany wrote:
> If a toggle-box is fit into a column with insufficient width, Progress 11.6 (win10 theme) ... Greg Shah

08/21/2017

07:54 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11160@.
This update finishes the frame widget dir... Eugenie Lyzenko

05:49 PM Feature #3275: improve browse support

If a toggle-box is fit into a column with insufficient width, Progress 11.6 (win10 theme) scales toggle-box reducing ... Stanislav Lomany

10:18 AM Feature #3275: improve browse support

In a browse using toggle-boxes there is only one real toggle-box control. Others are images.
!toggle-box.png! Stanislav Lomany

12:07 PM Feature #3260: auto-conversion and enablement for the embedded web client

Greg, with the embedded part I'm testing an approach which switches the approach from code generation: instead of gen... Constantin Asofiei

08/20/2017

09:22 AM Feature #2892: Implement browse scrolling with mouse wheel

Rebased task branch 2892a from P2J trunk revision 11158. Stanislav Lomany

08/19/2017

02:28 PM Feature #3283: add 4GL extension to obtain the mouse pointer location

The issue fully resolved in task branch 3284a revision 11172. Added 4GL-extension method GET-MOUSE-POSITION. Please r... Hynek Cihlar

08:14 PM Feature #1834: implement direct manipulation (drag and drop)

The task branch @1834b@ has been updated for review to revision @11159@.
This adds frame widget moving direct mani... Eugenie Lyzenko

08/18/2017

05:31 PM Feature #1818: implement a timer service to replace the PSTimer OCX

Task branch 1818a was updated. Some issues were identified while testing with customer's code. They were fixed.
Comm... Ovidiu Maxiniuc

05:29 PM Feature #1834: implement direct manipulation (drag and drop)

Eugenie Lyzenko wrote:
> OK. I think here there is a way the Windows signals for opened application the systems colo... Ovidiu Maxiniuc

05:13 PM Feature #1834: implement direct manipulation (drag and drop)

Ovidiu Maxiniuc wrote:
> > Any special reason to change default color?
> For Classic Theme, I tried to keep the exi... Eugenie Lyzenko

01:32 PM Feature #1834: implement direct manipulation (drag and drop)

> Any special reason to change default color?
For Classic Theme, I tried to keep the existing colors, to avoid regre... Ovidiu Maxiniuc

12:47 PM Feature #1834: implement direct manipulation (drag and drop)

I need some clarification from one who implemented theme management.
Why do we use:... Eugenie Lyzenko

12:05 PM Feature #1834: implement direct manipulation (drag and drop)

4GL classic theme:
!set_box_on_darkgray_4gl_classic.jpg!
Background: @0x848285@, selection: @0x7b7d7a@, this is... Eugenie Lyzenko