Project

General

Profile

Activity

From 09/13/2017 to 10/12/2017

10/12/2017

05:21 PM Feature #3281: implement some frame options
If it passes testing you can merge to trunk. Greg Shah
05:21 PM Feature #3281: implement some frame options
> rev 11189 fixes the SymbolResolver.convertSeparator for Windows OS, I'll release it with this branch if you don't w... Greg Shah
05:20 PM Feature #3281: implement some frame options
Code Review Task Branch 3281a Revision 11189
I'm fine with the changes. They are much easier to understand now.
Greg Shah
05:06 PM Feature #3281: implement some frame options
Greg, I think I have a fix for the BROWSE issues - please see 3281a rev 11188. rev 11189 fixes the @SymbolResolver.c... Constantin Asofiei
04:03 PM Feature #3287: local web client installation
We should check the following scenario for the embedded web application. A user loads an embedded js application clie... Sergey Ivanovskiy
10:22 AM Feature #3287: local web client installation
Thank you, planning to use this manual. Sergey Ivanovskiy
10:08 AM Feature #3287: local web client installation
I don't have one that is already created. Perhaps Constantin has something.
If not, you should use "Spawner":/pro...
Greg Shah
09:44 AM Feature #3287: local web client installation
I would like to test what are remote launchers and what are brokers or application agents in order to evaluate workin... Sergey Ivanovskiy
09:34 AM Feature #3287: local web client installation
I don't understand how to launch the web client on the different host. How to setup this configuration? For an exampl... Sergey Ivanovskiy
09:26 AM Feature #3287: local web client installation
> This remote P2J web client is executed as a separate process (spawned process) on the P2J server host, correct?
...
Greg Shah
09:23 AM Feature #3287: local web client installation
Greg Shah wrote:
> > I don't understand how it can work for virtual desktop mode. Greg, could you clarify your visio...
Sergey Ivanovskiy
08:36 AM Feature #3287: local web client installation
Sergey Ivanovskiy wrote:
> Did you mean to configure a broker client ("Remote Launchers":/projects/p2j/wiki/Remote_L...
Greg Shah
08:30 AM Feature #3287: local web client installation
> I don't understand how it can work for virtual desktop mode. Greg, could you clarify your vision.
Whether it is ...
Greg Shah
08:23 AM Feature #3287: local web client installation
Sergey Ivanovskiy wrote:
> Greg, please clarify the user environment. We have one server on which P2J server and Emb...
Greg Shah
08:23 AM Feature #3287: local web client installation
Sergey Ivanovskiy wrote:
> We already implemented the proxy server support when client requests to https://proxyserv...
Greg Shah
08:19 AM Feature #3287: local web client installation
Sergey Ivanovskiy wrote:
> Does it make sense to add a support for this parameter @client:cmd-line-option:startup-pr...
Greg Shah
08:17 AM Feature #3287: local web client installation
Did you mean to configure a broker client ("Remote Launchers":/projects/p2j/wiki/Remote_Launchers) on each user's hos... Sergey Ivanovskiy
07:23 AM Feature #3287: local web client installation
Greg Shah wrote:
>
> We know that customers can run the swing client locally and we could support these use cases ...
Sergey Ivanovskiy
06:38 AM Feature #3287: local web client installation
Greg, please clarify the user environment. We have one server on which P2J server and Embedded Web application are ex... Sergey Ivanovskiy
04:56 AM Feature #3287: local web client installation
We already implemented the proxy server support when client requests to https://proxyserver are redirected to https:/... Sergey Ivanovskiy
03:53 AM Feature #3287: local web client installation
Created new task branch 3287a. Sergey Ivanovskiy

10/11/2017

10:35 AM Feature #3281: implement some frame options
You cannot do that for a static browse in 4GL ("cannot change READ-ONLY ... if ENABLE phrase is not specified"). But ... Stanislav Lomany
10:23 AM Feature #3281: implement some frame options
Stanislav Lomany wrote:
> > Do you have a simple 4GL snippet?
> Attached.
So a column for a static browse can't ch...
Constantin Asofiei
10:13 AM Feature #3281: implement some frame options
> Do you have a simple 4GL snippet?
Attached.
Stanislav Lomany
10:07 AM Feature #3281: implement some frame options
Stanislav Lomany wrote:
> > is there a way to enable a browse column at runtime,
> Yes.
> 1. Set @READ-ONLY@ attri...
Constantin Asofiei
10:04 AM Feature #3281: implement some frame options
> is there a way to enable a browse column at runtime,
Yes.
1. Set @READ-ONLY@ attribute to @FALSE@ for the browse....
Stanislav Lomany
09:56 AM Feature #3281: implement some frame options
> Shouldn't there be one FORMAT_PHRASE AST for each field which has its valexp/help pulled from the schema?
Yes, d...
Greg Shah
09:53 AM Feature #3281: implement some frame options
There is still something else wrong in @attachSchemaValidation@ and how is used, especially in @BROWSE@ case:
# @AST...
Constantin Asofiei
09:22 AM Feature #3281: implement some frame options
Stanislav, a quick question please: is there a way to enable a browse column at runtime, via something similar to @SE... Constantin Asofiei
10:23 AM Feature #3275: improve browse support
> What would the map key strings represent, the DMO property name, or the legacy field name?
DMO property name.
Stanislav Lomany
10:03 AM Feature #3275: improve browse support
Stanislav Lomany wrote:
> I suggest to create in @RecordBuffer@ maps like @Map<String, String>validateExpressions@ w...
Eric Faulhaber
06:51 AM Feature #3275: improve browse support
In @BufferFieldImpl@ following functions:... Stanislav Lomany

10/10/2017

05:27 PM Feature #3281: implement some frame options
Code Review Task Branch 3281a Revision 11185
I'm fine with the changes. If it passes testing you can merge to trunk.
Greg Shah
04:43 PM Feature #3281: implement some frame options
Greg Shah wrote:
> Were you going to change @ui_statements.rules@ to use @progressToJavaString()@ instead of @remove...
Constantin Asofiei
04:31 PM Feature #3281: implement some frame options
Code Review Task Branch 3281a Revision 11184
It looks good.
Were you going to change @ui_statements.rules@ to ...
Greg Shah
04:23 PM Feature #3281: implement some frame options
Greg, please review 3281a 11184 - it solves the last found regression. Constantin Asofiei
03:51 PM Feature #3281: implement some frame options
There is still one regression at least related to ENABLE ALL... I've fixed one issue (@SymbolResolver.addFrameFields@... Constantin Asofiei
03:30 PM Feature #3281: implement some frame options
Greg Shah wrote:
> Code Review Task Branch 3281a Revision 11182
>
> The change does not look correct. Won't @fra...
Constantin Asofiei
03:18 PM Feature #3281: implement some frame options
Code Review Task Branch 3281a Revision 11182
The change does not look correct. Won't @frameNode@ be @null@ if the...
Greg Shah
10:43 AM Feature #3281: implement some frame options
Greg Shah wrote:
> My only question: in @ui_statements.rules@ should @removeQuotes()@ be used or should it be @progr...
Constantin Asofiei
10:41 AM Feature #3281: implement some frame options
Code Review Task Branch 3281a Revision 11181
I think I see the beginnings of the work for "GUI and ChUI can run at...
Greg Shah
08:41 AM Feature #3281: implement some frame options
I fixed last issues related to schema VALEXP/HELP and USE-DICT-EXPS; and also I've checked the color abbreviations, t... Constantin Asofiei
02:33 PM Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox
Please look at #3110-710 Sergey Ivanovskiy
02:29 PM Bug #3348 (Closed): The opened dropdown influences on the choice for the next tab widget for its ...
Sergey Ivanovskiy
01:22 PM Feature #3287: local web client installation
Does it make sense to add a support for this parameter @client:cmd-line-option:startup-procedure@ within this task? F... Sergey Ivanovskiy
08:11 AM Feature #3275: improve browse support
Yes. If possible, use the same technique already used for the queries. Greg Shah
07:13 AM Feature #3275: improve browse support
Should cache for validation statements be aged? Stanislav Lomany

10/09/2017

05:59 PM Feature #3281: implement some frame options
A status what's left:
# @ENABLE ALL@ must not pull schema @HELP@ for a field referenced by @EXCEPT@ (VALEXP works, j...
Constantin Asofiei
03:54 PM Feature #3281: implement some frame options
I suspect the direct manipulation of the @#a@ node as the root node is the problem. Do we really need to manipulate ... Greg Shah
03:13 PM Feature #3281: implement some frame options
Greg Shah wrote:
> If the @EXCEPT@ list is destroyed by the addition of schema validations, it should be fixed. Do ...
Constantin Asofiei
03:09 PM Feature #3281: implement some frame options
If the @EXCEPT@ list is destroyed by the addition of schema validations, it should be fixed. Do we honor it properly? Greg Shah
02:08 PM Feature #3281: implement some frame options
Greg Shah wrote:
> I also remember that the different sets of fields would get schema validation depending on where ...
Constantin Asofiei
02:00 PM Feature #3281: implement some frame options
> Greg, do you recall why we didn't do that initially? Was there some TRPL processing that had to happen pretty earl... Greg Shah
01:32 PM Feature #3281: implement some frame options
Eric Faulhaber wrote:
> Do we need to move the AST augmentation we're doing for schema validation and help expressio...
Constantin Asofiei
01:29 PM Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Are there any existing tests for VALEXP and ENABLE ALL?
Not very sophisticated ones; I ...
Eric Faulhaber
12:13 PM Feature #3281: implement some frame options
Eric Faulhaber wrote:
> Constantin, I wrote the original code to append the schema validation nodes, but it looks li...
Constantin Asofiei
12:00 PM Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Greg, I need some help; the regression related to HELP is about ENABLE ALL: @enable_stmt...
Eric Faulhaber
07:38 AM Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Greg, I need some help; the regression related to HELP is about ENABLE ALL: @enable_stmt...
Constantin Asofiei
07:37 AM Feature #3281: implement some frame options
Greg Shah wrote:
> In regard to the color names, I assume you are talking about the following (from Progress docs):
...
Constantin Asofiei
07:35 AM Feature #3281: implement some frame options
In regard to the color names, I assume you are talking about the following (from Progress docs):
* Black, Bla, Blk...
Greg Shah
05:37 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Greg Shah wrote:
> ... then you can merge to trunk so long as you've done a quick test to ensure item 2 (the gap ana...
Constantin Asofiei
05:27 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
> as there is a return executed after the apply(), in all cases
Good point, I missed that.
Greg Shah
05:22 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Greg Shah wrote:
> Code Review Task Branch 3331a Revision 11176
>
> 1. @LogicalTerminal.apply()@ has changes that...
Constantin Asofiei
05:09 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
If item 1 (the possible double apply processing) is OK, then you can merge to trunk so long as you've done a quick te... Greg Shah
05:08 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Code Review Task Branch 3331a Revision 11176
1. @LogicalTerminal.apply()@ has changes that now allow multiple path...
Greg Shah
03:57 PM Feature #3275: improve browse support
> 1. Do we need to implement VALIDATION-EXPRESSION attribute? Even is it is only support for VALIDATION-EXPRESSION = ... Greg Shah
03:41 PM Feature #3275: improve browse support
Some questions for you:
1. Do we need to implement @VALIDATION-EXPRESSION@ attribute? Even is it is only support for...
Stanislav Lomany
07:55 AM Feature #3275: improve browse support
Eric Faulhaber wrote:
> Ovidiu, I'm going back over #2488 and the caching code in @DynamicQueryHelper@, and the impl...
Ovidiu Maxiniuc

10/06/2017

07:20 PM Feature #3281: implement some frame options
Greg, I need some help; the regression related to HELP is about ENABLE ALL: @enable_stmt@ rule wants to iterate all f... Constantin Asofiei
06:12 PM Feature #3281: implement some frame options
So, when @COLOR@ statement uses color names in GUI, there is no RGB or other stuff like this computed... each color n... Constantin Asofiei
04:51 PM Feature #3281: implement some frame options
3281a rev 11175 should fix the issue with the HELP and USE-DICT-EXPS; running testing now. Constantin Asofiei
04:28 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
3331a passed testing and can be merged to trunk. Constantin Asofiei
11:35 AM Feature #3331 (WIP): translate 4GL menu widget processing into a standardized embedded web client...
3331a rev 11176 adds standard menu via dijit, for embedded mode. All changes are done, what is left is review and ru... Constantin Asofiei
08:38 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
The most common use of @SYSTEM-DIALOG PRINTER-SETUP@ is:... Greg Shah
07:33 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
OK, then just return @0xFFFFFFFF@ for it. -1 is an invalid HDC in Windows and it will be enough to satisfy the displ... Greg Shah
07:16 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> Can you please look at the reports/application code to see what is exactly being done there. If ...
Hynek Cihlar
07:47 AM Feature #3283: add 4GL extension to obtain the mouse pointer location
Please add the 4GL example code that would be replaced by this. Also, use some text like the final text in the scree... Greg Shah
04:20 AM Feature #3283: add 4GL extension to obtain the mouse pointer location
I documented the feature in "Mouse Position Location":https://proj.goldencode.com/projects/p2j/wiki/Mouse_Position_Lo... Hynek Cihlar
07:28 AM Feature #3282 (Closed): create a 4GL language extension to control screen refresh
I made some minor edits and I think it is good to go. Greg Shah
07:09 AM Feature #3282: create a 4GL language extension to control screen refresh
Greg Shah wrote:
>
> By showing these cases, the reader can understand how they are use this feature to eliminate ...
Hynek Cihlar

10/05/2017

07:14 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
OK, understand, any advances can help here. The tested pdf report has 3661 pages and takes approximately 648 Mb of th... Sergey Ivanovskiy
06:11 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Sergey Ivanovskiy wrote:
> Can your code load approximately 3000 pages of the pdf report produced by P2J web admin.
...
Hynek Cihlar
06:01 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > PDF rendering is done with PDFBox. An...
Sergey Ivanovskiy
05:48 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > PDF rendering is done with PDFBox. And I am not sure what I did ...
Hynek Cihlar
05:46 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Hynek Cihlar wrote:
> PDF rendering is done with PDFBox. And I am not sure what I did "wrong" but I didn't encounter...
Sergey Ivanovskiy
05:27 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
How far do we want to go when replicating the system printer dialog? With PDF file output as the only print output su... Hynek Cihlar
05:02 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
1795b contains a very basic implementation of GUI printer stream that actually works with some hard coded assumptions... Hynek Cihlar
11:38 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> Considering the memory problems with PDFBox, does it make sense to look at the jPod library inste...
Hynek Cihlar
10:05 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Considering the memory problems with PDFBox, does it make sense to look at the jPod library instead? Greg Shah
10:08 AM Feature #3281: implement some frame options
I think "blu/brown" and "White/blu" were dropped out of the code when we removed from files as out of scope.
> In ...
Greg Shah

10/04/2017

06:01 PM Feature #3281: implement some frame options
Greg Shah wrote:
> COLOR PHRASE (the app uses "blu/brown", "White/blu", @col-norm@ and @col-input@)
In the code I s...
Constantin Asofiei
05:17 PM Feature #3275: improve browse support
Greg Shah wrote:
> > Also, I see 2-level aging cache for dynamic queries. What kind of caching should be used for va...
Eric Faulhaber
04:12 PM Feature #3275: improve browse support
> I think that means we have to pass buffers to a validation function.
Yes.
> Also, I see 2-level aging cache ...
Greg Shah
07:30 AM Feature #3275: improve browse support
> 3. other buffers known to the query cannot be referenced on practice (but one of the error messages suggests that t... Stanislav Lomany
04:44 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
3331a rev 11174 contains the FWD changes without the complete @p2j.menu.js@ code which is supposed to create the menu... Constantin Asofiei
11:39 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Constantin Asofiei wrote:
> ... if you have an alternative, let me know, otherwise I will try something in SVG, [......
Eric Faulhaber
04:43 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> > So in order to make printing in GUI work we have to first make sure output redirection works in...
Hynek Cihlar
04:17 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
> So in order to make printing in GUI work we have to first make sure output redirection works in GUI, too. Is my ass... Greg Shah
07:28 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
SESSION:PRINTER-HDC returns the Win32 device context of the selected printer device. It can be used to render content... Hynek Cihlar
06:16 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Hynek Cihlar wrote:
> In regards to the runtime support. @OUTPUT TO PRINTER@ seems to behave the same as the other r...
Hynek Cihlar
06:13 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
In regards to the runtime support. @OUTPUT TO PRINTER@ seems to behave the same as the other redirected outputs (file... Hynek Cihlar
04:26 PM Feature #3282: create a 4GL language extension to control screen refresh
Please add a couple of examples of the 4GL code that is replaced by this approach. The first two items in #3257-59 s... Greg Shah
04:18 PM Feature #3282: create a 4GL language extension to control screen refresh
Wiki updated at "Screen Refresh Control":https://proj.goldencode.com/projects/p2j/wiki/Screen_Refresh_Control. Hynek Cihlar
04:09 PM Feature #3260: auto-conversion and enablement for the embedded web client
3260b was merged to trunk rev 11173 and archived.
hotel_gui_3260b was promoted to hotel_gui (rev 147).
Constantin Asofiei
03:55 PM Feature #3260: auto-conversion and enablement for the embedded web client
You can merge to 3260b trunk. Greg Shah
08:14 AM Feature #3260: auto-conversion and enablement for the embedded web client
3260b rev 11177 passed runtime testing. Constantin Asofiei

10/03/2017

05:30 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Constantin Asofiei wrote:
> Eric, a question: can Claro CSS co-exist with Bootstrap CSS? Because I have the JS to bu...
Constantin Asofiei
05:11 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Eric, a question: can Claro CSS co-exist with Bootstrap CSS? Because I have the JS to build a menubar, but there is s... Constantin Asofiei
04:00 PM Feature #3275: improve browse support
For now, there is no good reason to process with the buffer. Use the variable approach.
> 2. other fields of the ...
Greg Shah
03:55 PM Feature #3275: improve browse support
Question is if we want to pass buffers to the validated function:
1. validated value definitely can be referenced an...
Stanislav Lomany
03:11 PM Feature #3275: improve browse support
I can convert something like... Stanislav Lomany
02:16 PM Feature #3275: improve browse support
Greg Shah wrote:
> The interpreter already knows how to process a WHERE clause, which is just a @logical@ expression...
Eric Faulhaber
02:16 PM Feature #3275: improve browse support
Interesting enough, in validation statements for a dynamic browse you cannot access fields of the validated buffer, e... Stanislav Lomany

10/02/2017

04:36 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
OK, I think this is a good idea. Getting something working that is decent is important. Later, we may need to do so... Greg Shah
04:19 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Greg, there is this which seems easy to use: https://dojotoolkit.org/reference-guide/1.10/dijit/MenuBar.html
I wa...
Constantin Asofiei
03:46 PM Feature #3275: improve browse support
> Well, I thought to wrap a validation statement in a function or procedure like this:
I think this is unnecessary...
Greg Shah
03:28 PM Feature #3275: improve browse support
Stanislav Lomany wrote:
> Should I work on AST in order to make it convertible by the current runtime set in @core_c...
Constantin Asofiei
03:24 PM Feature #3275: improve browse support
> Do you have any open questions on this?
Well, I thought to wrap a validation statement in a function or procedur...
Stanislav Lomany
10:37 AM Feature #3275: improve browse support
Then it seems to me that the @DynamicQueryHelper@ is already quite close to supporting this feature. We will need to... Greg Shah
10:25 AM Feature #3275: improve browse support
> There is no way to reference anything (including variables) in the business logic?
Right.
> In regard to brow...
Stanislav Lomany
07:44 AM Feature #3275: improve browse support
In regard to @browse-handle:VALIDATE-EXPRESSION = "".@ did you check what this does? Greg Shah
07:42 AM Feature #3275: improve browse support
> According to the error message it can be constants and buffer/field references to buffers known to the query. Accor... Greg Shah
08:45 AM Feature #3284 (Closed): implement more window widget support
Greg Shah
08:17 AM Feature #3284: implement more window widget support
3284b merged to trunk as revision 11172 and archived. Hynek Cihlar
08:07 AM Feature #3284: implement more window widget support
Please merge 3284b to trunk. Greg Shah
07:47 AM Feature #3284: implement more window widget support
Hynek Cihlar wrote:
> 3284b passed ChUI regression tests. Please review.
I'm OK with the changes in 3284b rev 11187.
Constantin Asofiei
08:32 AM Feature #3282: create a 4GL language extension to control screen refresh
Greg Shah wrote:
> Can this task be closed?
I'm planning yet do update the wiki documentation, after that I will ...
Hynek Cihlar
08:30 AM Feature #3282: create a 4GL language extension to control screen refresh
Code changes with the @DISABLE-REDRAW@ implementation were delivered in task branch 3284b and merged to trunk as revi... Hynek Cihlar
08:29 AM Feature #3283: add 4GL extension to obtain the mouse pointer location
Code changes for the @GET-MOUSE-POSITION@ were delivered in task branch 3284b and merged to trunk as revision 11172. Hynek Cihlar

10/01/2017

07:18 PM Feature #3284: implement more window widget support
3284b passed ChUI regression tests. Please review. Hynek Cihlar
05:38 PM Feature #3275: improve browse support
> Can you statically determine (at conversion time) which tables are referenced from a dynamic browse?
No, an arbi...
Stanislav Lomany
09:13 AM Feature #3275: improve browse support
>> Converting them in advance would be a workable solution.
>
> So, are you suggesting to add some validator classe...
Greg Shah
09:04 AM Feature #3275: improve browse support
Stanislav Lomany wrote:
> > What about the schema-validation expressions? Do dynamic browses honor them?
> Yes, but...
Greg Shah

09/30/2017

04:59 PM Feature #3275: improve browse support
> Converting them in advance would be a workable solution.
So, are you suggesting to add some validator classes wi...
Stanislav Lomany
02:54 PM Feature #3284: implement more window widget support
The last regression test run finished with some negative failures. I started a new run. Hynek Cihlar

09/29/2017

06:53 PM Feature #3284: implement more window widget support
3284b revision 11186 fixes a sort of regression that influences how the client interacts with test harness. The probl... Hynek Cihlar
04:11 AM Feature #3284: implement more window widget support
The last ChUI regression test round finished with failures, I am not yet sure whether these were caused by the change... Hynek Cihlar
04:18 PM Feature #3275: improve browse support
> What about the schema-validation expressions? Do dynamic browses honor them?
Yes, but the expressions have limitat...
Stanislav Lomany
02:32 PM Feature #3275: improve browse support
Eric Faulhaber wrote:
> Stanislav Lomany wrote:
> > BTW, do we need to implement @VALIDATE-EXPRESSION@?
> In the c...
Greg Shah
01:58 PM Feature #3275: improve browse support
Stanislav Lomany wrote:
> BTW, do we need to implement @VALIDATE-EXPRESSION@?
In the current project, there are two...
Eric Faulhaber
01:51 PM Feature #3275: improve browse support
> convert the expressions *in advance* at conversion time and just provide the necessary variable references as param... Stanislav Lomany
12:23 PM Feature #3275: improve browse support
Sorry, I missed the most important part of your message (the @DynamicQueryHelper.parse()@ part).
Constantin's poin...
Greg Shah
12:15 PM Feature #3275: improve browse support
Stanislav Lomany wrote:
> Guys, when I try to convert a procedure using the code from @DynamicQueryHelper.parse@, ex...
Constantin Asofiei
12:12 PM Feature #3275: improve browse support
I can't reproduce your results with trunk.
This program (@testcases/uast/simple_message.p@):...
Greg Shah
11:52 AM Feature #3275: improve browse support
Guys, when I try to convert a procedure using the code from @DynamicQueryHelper.parse@, expressions lose their first ... Stanislav Lomany
12:25 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
> the menus will be part of i.e. p2j.embedded.js (FWD runtime)
Yes, it should be part of FWD. Later, if applicat...
Greg Shah
12:22 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Greg Shah wrote:
> It depends on how much time it will take.
The FWD changes should not take more than a couple o...
Constantin Asofiei
12:10 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
It depends on how much time it will take. 3260b is nearly ready to merge to trunk, right?
You make the call.
Greg Shah
12:07 PM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Should I work this in 3260b? Constantin Asofiei
08:48 AM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Sounds good. Greg Shah
06:47 AM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
Greg, I need two menu-related values from FWD:
# the mnemonic index
# the preprocessed label (because of the @&@ ch...
Constantin Asofiei

09/28/2017

03:12 PM Feature #3288: support > 1 browser tabs for a single FWD java client instance
Please see #3287-2 through #3287-12 for details on this multiple web socket task. Greg Shah
01:47 PM Feature #3288: support > 1 browser tabs for a single FWD java client instance
Greg, please explain what is the target of this task? The web client handles only one thin client that can be called ... Sergey Ivanovskiy
03:11 PM Feature #3287: local web client installation
This task is designed for implementing the locally installed "listening client" mode (this must work for multiple use... Greg Shah
03:10 PM Feature #3287: local web client installation
Yes, multiple web sockets can allow multiple browser/tabs. Another issue to think about: what happens when a tab (sa... Greg Shah
03:09 PM Feature #3287: local web client installation
> By 'same origin' you mean same host and port, right? This could help so we will have a direct JS access between the... Greg Shah
03:09 PM Feature #3287: local web client installation
From Constantin:
> By 'same origin' you mean same host and port, right? This could help so we will have a direct J...
Greg Shah
03:08 PM Feature #3287: local web client installation
> A mode where one or more windows are active and each one assigned a dedicated iframe could work, but adding concurr... Greg Shah
03:08 PM Feature #3287: local web client installation
From Constantin:
> The first thing that comes to mind is how we will handle the business logic: if a single client...
Greg Shah
03:07 PM Feature #3287: local web client installation
> I think the 2nd option is the way to go; we will need a way to mark certain users that they will use an explicit cl... Greg Shah
03:05 PM Feature #3287: local web client installation
> Did you consider a use case to update the P2J client from a server with new version?
No, I didn't consider this....
Greg Shah
03:03 PM Feature #3287: local web client installation
From Sergey:
> Did you consider a use case to update the P2J client from a server with new version? Please explain...
Greg Shah
03:02 PM Feature #3287: local web client installation
From Constantin:
> I think the 2nd option is the way to go; we will need a way to mark certain users that they wil...
Greg Shah
03:02 PM Feature #3287: local web client installation
Every 4GL GUI application we have ever seen contains some number of native platform dependencies. Since these applic... Greg Shah
01:39 PM Feature #3287: local web client installation
Greg, please clarify the web client installation task. Does it include the spawn installation? What is an environment... Sergey Ivanovskiy
02:19 PM Feature #2368: allow widget output to stream in GUI mode
A very high-level description of what needs to be done:
# GUI-ChUI driver switching; this is tricky, as we need to h...
Constantin Asofiei
01:50 PM Feature #2368: allow widget output to stream in GUI mode
> Do you know how many references of STREAM-IO are in the project?
5,514 :(
Greg Shah
01:23 PM Feature #2368: allow widget output to stream in GUI mode
Greg Shah wrote:
> > A question: can we defer the GUI behaviour for STREAM-IO, if is not in use (and all usage is to...
Constantin Asofiei
12:58 PM Feature #2368: allow widget output to stream in GUI mode
> A question: can we defer the GUI behaviour for STREAM-IO, if is not in use (and all usage is to stream)?
Yes, it...
Greg Shah
12:55 PM Feature #2368: allow widget output to stream in GUI mode
Greg Shah wrote:
> Possibly. But I wonder if there are layout differences that can only be seen at runtime. For ex...
Constantin Asofiei
08:22 AM Feature #2368: allow widget output to stream in GUI mode
Possibly. But I wonder if there are layout differences that can only be seen at runtime. For example, I think the F... Greg Shah
12:36 PM Feature #3260: auto-conversion and enablement for the embedded web client
3260b rev 11175 and hotel_gui_3260b rev 147 has latest compatible changes.
There is a bug, don't know why, but t...
Constantin Asofiei
09:03 AM Feature #3260: auto-conversion and enablement for the embedded web client
I've created a temporary copy of Hotel GUI as @~/secure/code/p2j_repo/samples/hotel_gui_3260b@ Use that and when the... Greg Shah
11:57 AM Feature #3284: implement more window widget support
I think he means the customer GUI app in which we had 10 documented scenarios that can be used for testing. Greg Shah
11:40 AM Feature #3284: implement more window widget support
Constantin Asofiei wrote:
> Can you please do some tests with the large GUI app?
Yes, I am currently testing Hote...
Hynek Cihlar
11:32 AM Feature #3284: implement more window widget support
Hynek, I'm OK with the change in 3284b revision 11184. Can you please do some tests with the large GUI app? Constantin Asofiei

09/27/2017

07:37 PM Feature #2368: allow widget output to stream in GUI mode
Greg Shah wrote:
> This work should include support for the frame option @STREAM-IO@ (runtime is needed).
Isn't @ST...
Constantin Asofiei
07:31 PM Feature #3260: auto-conversion and enablement for the embedded web client
Greg, I have some Hotel GUI changes which are dependent on 3260b - where should I commit them for review? Constantin Asofiei
06:12 PM Feature #3284: implement more window widget support
3284b revision 11184 resolves all the points from the last review, resolves the layout and draw of window small close... Hynek Cihlar
10:28 AM Feature #1834 (Closed): implement direct manipulation (drag and drop)
Greg Shah
08:48 AM Feature #1834: implement direct manipulation (drag and drop)
Greg Shah wrote:
> Please merge to trunk.
Done.
Branch @1834b@ was merged to trunk as revno @11170@ then it wa...
Eugenie Lyzenko
08:35 AM Feature #1834: implement direct manipulation (drag and drop)
Please merge to trunk. Greg Shah
07:51 AM Feature #1834: implement direct manipulation (drag and drop)
Testing completed. No regressions found. Had to run 3-way tests in standalone session. The results:
@1834b_11197_ee1...
Eugenie Lyzenko
06:44 AM Feature #1834: implement direct manipulation (drag and drop)
The main regression cycle has passed. Waiting for @CTRL-C@ results. Eugenie Lyzenko

09/26/2017

03:50 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834b@ has been updated to revision is @11197@.
Ironically I have missed the round rectangle fix....
Eugenie Lyzenko
02:44 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834b@ has been rebased with trunk @11169@. New revision is @11196@.
The regression testing is re...
Eugenie Lyzenko
10:39 AM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834b@ has been updated, rebased with trunk @11168@. New revision is @11195@.
This is round recta...
Eugenie Lyzenko
08:11 AM Feature #1834: implement direct manipulation (drag and drop)
> Do you mean these?:
Yes.
Greg Shah
08:00 AM Feature #1834: implement direct manipulation (drag and drop)
Greg Shah wrote:
> I've noticed quite a few javadoc problems with the OracleJDK, even in trunk. If you can resolve ...
Eugenie Lyzenko
07:53 AM Feature #1834: implement direct manipulation (drag and drop)
> Should I include this fix into 1834b branch?
Yes.
> There are also 23 new javadoc errors introduced in yester...
Greg Shah
07:22 AM Feature #1834: implement direct manipulation (drag and drop)
There are also 23 new javadoc errors introduced in yesterday trunk(@11166@) from branch @3222a@. I can also fix them ... Eugenie Lyzenko
06:50 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > GUI standalone tests has no regressions. But I see the issue pr...
Eugenie Lyzenko
06:20 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > GUI standalone tests has no regressions. But I see the issue pr...
Eugenie Lyzenko
05:59 AM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> GUI standalone tests has no regressions. But I see the issue presented in trunk as well. Th...
Ovidiu Maxiniuc
05:23 AM Feature #1834: implement direct manipulation (drag and drop)
Sergey Ivanovskiy wrote:
> Eugenie, committed revision 11191, 11192 added comments for these files WebClientProtocol...
Eugenie Lyzenko
01:15 AM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > 3. Please change EVL to SBI for those files where the changes were wr...
Sergey Ivanovskiy
10:05 PM Feature #1834: implement direct manipulation (drag and drop)
GUI standalone tests has no regressions. But I see the issue presented in trunk as well. The rounded rectangle has in... Eugenie Lyzenko

09/25/2017

05:29 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834b@ has been rebased with trunk @11166@. New revision is @11190@.
I'm going to start regressio...
Eugenie Lyzenko

09/22/2017

03:29 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834b@ has been rebased with trunk @11165@. New revision is @11189@. Eugenie Lyzenko

09/21/2017

05:51 PM Feature #1834: implement direct manipulation (drag and drop)
As preparation step the task branch @1834b@ has been rebased with trunk @11164@. New revision is @11188@(I saw the br... Eugenie Lyzenko
08:05 AM Bug #3335: buggy no-validate in browse widget
Sorry, patch fixes the problem. Stanislav Lomany
07:08 AM Bug #3335: buggy no-validate in browse widget
Stanislav Lomany wrote:
> Constantin, @frame.getName(this)@ cannot be replaced with @widgetName()@ for usages inside...
Constantin Asofiei
05:36 AM Bug #3335: buggy no-validate in browse widget
Constantin, @frame.getName(this)@ cannot be replaced with @widgetName()@ for usages inside @FrameWidget@, because the... Stanislav Lomany

09/20/2017

05:37 PM Bug #3335: buggy no-validate in browse widget
Looks like the @BROWSE:NAME@ attribute is reported properly. Stanislav, I think the issues are:
# as you mentioned ...
Constantin Asofiei
05:24 PM Bug #3335: buggy no-validate in browse widget
Constantin,... Stanislav Lomany
05:18 PM Bug #3335: buggy no-validate in browse widget
Actually, sorry, that was only for FRAME:NAME.
Stanislav/Ovidiu: is the converted code for the frame definition ...
Constantin Asofiei
05:15 PM Bug #3335: buggy no-validate in browse widget
Greg Shah wrote:
> Constantin: What do you think?
I have this code in 3260b which I think it should fix the issue:
...
Constantin Asofiei
05:12 PM Bug #3335: buggy no-validate in browse widget
The current implementation of @GenericWidget.widgetName()@ is using @GenericFrame.getName(GenericWidget<?> widget)@ t... Greg Shah
04:05 PM Bug #3335: buggy no-validate in browse widget
> Also, the message should contain the legacy widget name (br_table), not the javaname (brTable).
Error message uses...
Stanislav Lomany
06:12 AM Feature #3275: improve browse support
Created task branch 3275c from P2J trunk revision 11164. Stanislav Lomany

09/19/2017

03:36 PM Bug #3335: buggy no-validate in browse widget
Stanislav Lomany wrote:
> Greg, @setNoValidate@ should behave differently depending if it is a frame construction st...
Greg Shah
03:23 PM Bug #3335 (WIP): buggy no-validate in browse widget
Greg, @setNoValidate@ should behave differently depending if it is a frame construction stage (@NO-VALIDATE@ option) ... Stanislav Lomany
10:10 AM Bug #3335: buggy no-validate in browse widget
I was testing #3330 with a large customer GUI application and I got an message that was not expected according to doc... Ovidiu Maxiniuc
10:08 AM Bug #3335 (Closed): buggy no-validate in browse widget
Ovidiu Maxiniuc

09/18/2017

06:56 PM Feature #3260: auto-conversion and enablement for the embedded web client
Greg, what I want to finish at this time is an improvement for the JS code, to allow unique JS files for each window ... Constantin Asofiei
06:54 PM Feature #3260: auto-conversion and enablement for the embedded web client
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > > @beforeConfigValueSet@ or @afterApplyConfig@ should be called...
Constantin Asofiei
05:21 AM Feature #3284: implement more window widget support
Constantin Asofiei wrote:
> Hynek, review for 3284b rev 11174:
> # have you tested how @window-delayed-minimize@ an...
Hynek Cihlar

09/15/2017

04:24 PM Feature #3281: implement some frame options
Greg,
You are right. I updated the code accordingly. Committed as r11241.
Ovidiu Maxiniuc
03:10 PM Feature #3281: implement some frame options
Ovidiu Maxiniuc wrote:
> Why should have it been dropped?
I meant FWD previously dropped it, not that it should.
Constantin Asofiei
02:57 PM Feature #3281: implement some frame options
Code Review Task branch 3330a Revision 11240
This is very close.
1. I think the unconditional use of @(String) ...
Greg Shah
02:40 PM Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Ovidiu, while you are at it, there is another case where I think the condition is droppe...
Ovidiu Maxiniuc
02:16 PM Feature #3281: implement some frame options
Ovidiu, while you are at it, there is another case where I think the condition is dropped: if the @VALEXP "not CAN-FI... Constantin Asofiei
02:05 PM Feature #3281: implement some frame options
I moved the code into Progress parser. In fact I used the already existing code from @resolveLvalueCoreType@.
Suppo...
Ovidiu Maxiniuc
03:14 PM Feature #3284: implement more window widget support
Hynek, review for 3284b rev 11174:
# have you tested how @window-delayed-minimize@ and @ALWAYS-ON-TOP@ work with par...
Constantin Asofiei
01:41 PM Feature #3275: improve browse support
Somehow I didn't notice that the failing step was now 41 not 40. I guess that came with your MAJIC update. Greg Shah
12:03 PM Feature #3275: improve browse support
Greg Shah wrote:
> Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_00...
Constantin Asofiei
11:25 AM Feature #3275: improve browse support
Greg Shah wrote:
> Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_00...
Ovidiu Maxiniuc
10:40 AM Feature #3275: improve browse support
3275b was merged into 3330a as revision 11238. Stanislav Lomany
09:07 AM Feature #3275: improve browse support
> Should I check 3275b into trunk?
We are trying to get 3330a and 3222a into the trunk as priorities. However, th...
Greg Shah
09:05 AM Feature #3275: improve browse support
Constantin/Eugenie/Ovidiu: Please see #3275-100. Does anyone have a reason for why the tc_job_002 now gets past step... Greg Shah
04:20 AM Feature #3275: improve browse support
Regression testing for 3275b passed. The only thing is that IIRC @tc_job_002@ was failing with ... Stanislav Lomany

09/14/2017

05:21 PM Feature #3281: implement some frame options
I understand. I will adjust the code as Greg suggested. Ovidiu Maxiniuc
05:19 PM Feature #3281: implement some frame options
Greg Shah wrote:
> Code Review Task Branch 3330a Revision 11237
>
> Eric: please review and comment.
Greg, I agr...
Eric Faulhaber
05:18 PM Feature #3281: implement some frame options
To be clear about this, I am proposing that all the processing for this be removed from @SchemaDictionary@ (and @Symb... Greg Shah
05:02 PM Feature #3281: implement some frame options
Code Review Task Branch 3330a Revision 11237
Eric: please review and comment.
1. My sense is that this is encod...
Greg Shah
04:42 PM Feature #3281: implement some frame options
Committed as revision 11237. Ovidiu Maxiniuc
04:33 PM Feature #3281: implement some frame options
Yes, please do. Greg Shah
04:31 PM Feature #3281: implement some frame options
Greg, I have a fix for this issue. It works fine for my testcases. Shall I commit it to 3330a for review? Ovidiu Maxiniuc
02:18 PM Feature #3281: implement some frame options
> Doesn't such a match need to consider and handle abbreviations?
Yes. It should handle abbreviations and case-in...
Greg Shah
01:33 PM Feature #3281: implement some frame options
Maybe I'm missing something, but it seems like it is more complicated than that. Doesn't such a match need to conside... Eric Faulhaber
12:30 PM Feature #3281: implement some frame options
I think the method could be something like @boolean SchemaDictionary.specificFieldMatch(String candidate, String sche... Greg Shah
12:18 PM Feature #3281: implement some frame options
Greg Shah wrote:
> How about if the @SchemaDictionary@ provided a worker method to compare the candidate field name ...
Eric Faulhaber
12:11 PM Feature #3281: implement some frame options
Eric: Do you have any guidance here? Greg Shah
12:10 PM Feature #3281: implement some frame options
> use a ProgresParser member field to store the field when attaching schema validators. It should contain the name of... Greg Shah
11:56 AM Feature #3281: implement some frame options
Greg Shah wrote:
> Ovidiu: Are you working this one?
Yes, I am using the testcase to go step-by-step and try to f...
Ovidiu Maxiniuc
11:45 AM Feature #3281: implement some frame options
Ovidiu: Are you working this one? Greg Shah
11:44 AM Feature #3281: implement some frame options
> We need to introduce some exception when computing the parent table of an unqualified field in the case of the vali... Greg Shah
04:17 PM Feature #3284: implement more window widget support
Hynek Cihlar wrote:
> In Web GUI when overlay window is opened (combo box dropdown) and an action is performed that ...
Hynek Cihlar
08:26 AM Feature #3284: implement more window widget support
3284b revision 11173 passed ChUI regression testing and GUI regression testing with one condition. In Web GUI when ov... Hynek Cihlar

09/13/2017

04:03 PM Feature #3275: improve browse support
I just realized that validation statements for browse are not properly converted when it comes to the validated varia... Stanislav Lomany
06:22 AM Feature #3275: improve browse support
There are multiple browse issues that has been found during testing:
# Scroll by mouse wheel doesn't work if the poi...
Stanislav Lomany
11:00 AM Feature #3260: auto-conversion and enablement for the embedded web client
Constantin Asofiei wrote:
> > @beforeConfigValueSet@ or @afterApplyConfig@ should be called, too. Otherwise @afterCo...
Hynek Cihlar
10:53 AM Feature #3260: auto-conversion and enablement for the embedded web client
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Are the methods @beforeConfigValueSe...
Constantin Asofiei
10:33 AM Feature #3260: auto-conversion and enablement for the embedded web client
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Are the methods @beforeConfigValueSet()@ and @afterApplyConfig(...
Hynek Cihlar
10:26 AM Feature #3260: auto-conversion and enablement for the embedded web client
Hynek Cihlar wrote:
> Are the methods @beforeConfigValueSet()@ and @afterApplyConfig()@ in @SyncConfigChangesAspect@...
Constantin Asofiei
10:14 AM Feature #3260: auto-conversion and enablement for the embedded web client
Constantin Asofiei wrote:
> I was expecting that @ConfigManager.applyConfigUpdates@ called on server-side by @Logica...
Hynek Cihlar
09:46 AM Feature #3260: auto-conversion and enablement for the embedded web client
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, quick question: is it me or @afterConfigUpdate@ is never...
Constantin Asofiei
09:36 AM Feature #3260: auto-conversion and enablement for the embedded web client
Constantin Asofiei wrote:
> Hynek, quick question: is it me or @afterConfigUpdate@ is never called on server-side?
...
Hynek Cihlar
09:22 AM Feature #3260: auto-conversion and enablement for the embedded web client
Hynek, quick question: is it me or @afterConfigUpdate@ is never called on server-side? Constantin Asofiei
 

Also available in: Atom