Activity

From 03/26/2018 to 04/24/2018

04/24/2018

06:56 AM Bug #3532 (Closed): Failed to instantiate menu definition class: Greg Shah
03:10 AM Bug #3532: Failed to instantiate menu definition class: The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
06:56 AM Bug #3508 (Closed): 1st level popup menu won't close when menu item selected: Greg Shah
03:09 AM Bug #3508: 1st level popup menu won't close when menu item selected: The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
03:07 AM Bug #3487: Sub-menu graphical issues: 3487a rebased and merged to trunk as revision 11251. The branch was archived. Hynek Cihlar
02:36 AM Bug #3487: Sub-menu graphical issues: 3487a passed ChUI test harness. I am merging to trunk. Hynek Cihlar

04/23/2018

12:48 PM Bug #3487: Sub-menu graphical issues: When it passes testing, merge to trunk. Greg Shah
11:44 AM Bug #3487: Sub-menu graphical issues: Greg Shah wrote:
> The existing revision of 3487a is a significant improvement over trunk, right?
Yes, it fixes... Hynek Cihlar
11:44 AM Bug #3487: Sub-menu graphical issues: ChUI regression test harness finished with some failures which are most likely negative failures. I restarted the tests. Hynek Cihlar
09:57 AM Bug #3487: Sub-menu graphical issues: Code Review Task branch 3487a Revision 11258
I'm good with the changes. Greg Shah
07:29 AM Bug #3487: Sub-menu graphical issues: The existing revision of 3487a is a significant improvement over trunk, right? Unless there are regressions, I would... Greg Shah
07:04 AM Bug #3487: Sub-menu graphical issues: While regression testing 3487a I see client abends which prevent me to run all the required cases. These errors alrea... Hynek Cihlar

04/22/2018

06:19 PM Bug #3487: Sub-menu graphical issues: 3487a revision 11258 resolves the points from the last review. It passed GUI regression tests (a large customer's GUI... Hynek Cihlar

04/20/2018

12:49 PM Bug #3487: Sub-menu graphical issues: Code Review Task Branch 3487a Revision 11256
These changes are really good. I see no functional issues.
One mi... Greg Shah
08:56 AM Bug #3487: Sub-menu graphical issues: 3487a revision 11256 fixes this issue plus #3462, #3508, #3532.
Regression testing is in progress. Please review. Hynek Cihlar
08:53 AM Bug #3487: Sub-menu graphical issues: 3487a rebased against trunk 11249. Hynek Cihlar

04/19/2018

05:05 AM Bug #3487: Sub-menu graphical issues: 3487a rebased against trunk 11248. Hynek Cihlar

04/18/2018

02:53 PM Bug #3487: Sub-menu graphical issues: Checked in revision 11247 to 3487a.
This resolves all the issues mentioned in this issue plus:
* popup menu not s... Hynek Cihlar
10:32 AM Bug #3550: Window restore from maximized state GUI mode issue: Greg Shah wrote:
> Eugenie confirmed this is not an issue in Swing.
To be clear. The Swing portion of the issue i... Eugenie Lyzenko
10:28 AM Bug #3550: Window restore from maximized state GUI mode issue: Eugenie confirmed this is not an issue in Swing. Greg Shah
09:41 AM Bug #3550: Window restore from maximized state GUI mode issue: This can be recreated in trunk revision 11248 (and before). It is not related to the changes from #3548, but was jus... Greg Shah
09:39 AM Bug #3550: Window restore from maximized state GUI mode issue: Found issue in trunk for hotel GUI. When window is restoring from maximized state by restore title bar button the win... Eugenie Lyzenko
09:33 AM Bug #3550 (New): Window restore from maximized state GUI mode issue: Eugenie Lyzenko
10:29 AM Bug #3548 (Closed): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Greg Shah
10:22 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Greg Shah wrote:
> Did you test Hotel GUI in both Swing and Web?
Yes. The Swing difference is in new issue that f... Eugenie Lyzenko
09:56 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Did you test Hotel GUI in both Swing and Web? Greg Shah
09:32 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Branch @3548a@ was merged to trunk as revno @11248@ then it was archived. Eugenie Lyzenko
08:25 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Please merge 3548a to trunk.
> But found issue in trunk for hotel GUI. When window is restoring from maximized sta... Greg Shah
08:01 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Not found the regressions in hotel @GUI@.
But found issue in trunk for hotel GUI. When window is restoring from ma... Eugenie Lyzenko
07:35 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Greg Shah wrote:
> Have you already tested Hotel GUI?
In progress now. Need to check one option comparing with tr... Eugenie Lyzenko
07:26 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Have you already tested Hotel GUI? Greg Shah
07:25 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Greg Shah wrote:
> What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Ho... Eugenie Lyzenko
07:09 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Hotel usage cases? Greg Shah
02:40 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Code review 3548a revision 11253.
The changes are OK. I don't register any more open points for the branch. Hynek Cihlar

04/17/2018

05:36 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Hynek Cihlar wrote:
>
> The test case is as follows. Show a window, hide it, assign menu-bar, read the @FULL-@ att... Eugenie Lyzenko
05:19 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Eugenie Lyzenko wrote:
> >Consider the case when the window layout is changed (for example menu-bar assigned) while ... Hynek Cihlar
05:13 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Hynek Cihlar wrote:
> Code review 3548a revision 11252.
>
> The code changes are OK except the @!config().dynamic... Eugenie Lyzenko
04:56 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Code review 3548a revision 11251.
> >
> > The changes are good.... Hynek Cihlar
07:10 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Hynek Cihlar wrote:
> Code review 3548a revision 11251.
>
> The changes are good. But note that the value of the ... Eugenie Lyzenko
04:48 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Code review 3548a revision 11251.
The changes are good. But note that the value of the @FULL-*@ attribute changes ... Hynek Cihlar
11:03 AM Feature #3469: final improvements and polish for the embedded mode web client: See #3498-21 for a list of some ADM2 reference materials. Greg Shah
04:41 AM Feature #3469: final improvements and polish for the embedded mode web client: Eric, if you want to be sure, convert with this patch applied to trunk, then with the patch applied to your branch an... Constantin Asofiei
02:19 AM Feature #3469: final improvements and polish for the embedded mode web client: Eric Faulhaber wrote:
> Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/a... Constantin Asofiei
01:00 AM Feature #3469: final improvements and polish for the embedded mode web client: Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/adm_windows.xml@. I see th... Eric Faulhaber

04/16/2018

01:33 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Task branch @3548a@ has been updated for review to revision @11251@.
This is reworked code with changed location t... Eugenie Lyzenko
01:30 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Code review task branch 3548a revision 11250.
@WindowGuiImpl.fullSizeAttributesUpdated@ is redundant. Just move th... Hynek Cihlar
07:02 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Task branch @3548a@ has been updated for review to revision @11250@.
This is the small typo fixes for file headers... Eugenie Lyzenko
09:35 AM Bug #3286 (Closed): fix features that can be relied upon to implement a limited form of dynamic r...: The work for this was done in #3434. The fixes in branch 3434a were merged into trunk as revision 11246. Greg Shah
10:29 PM Feature #3474 (Closed): OPEN-MIME-RESOURCE: Eric Faulhaber

04/14/2018

09:43 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Task branch @3548a@ has been updated for review to revision @11249@.
Two more changes here:
1. I've accidentall... Eugenie Lyzenko

04/13/2018

12:57 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Task branch @3548a@ has been rebased with recent trunk and updated for review to revision @11248@.
This is the bas... Eugenie Lyzenko

04/12/2018

07:35 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Currently I see two deviation for @FWD@ comparing to @4GL@:
1. The default window attribute values are @unknown (?... Eugenie Lyzenko
06:15 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Created task branch @3548a@ from trunk revision @11246@. Eugenie Lyzenko
05:52 PM Bug #3548 (WIP): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Greg Shah
04:34 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Hynek Cihlar wrote:
>
> It seems the lifetime of the @FULL-WIDTH-CHARS@ value is a bit more complex. I did a few s... Eugenie Lyzenko
04:33 PM Bug #3548 (Closed): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization: Eugenie Lyzenko
06:34 PM Feature #3474: OPEN-MIME-RESOURCE: 3474a has been merged into the trunk as bzr revision 11247 and archived. Sergey Ivanovskiy
06:23 PM Feature #3474: OPEN-MIME-RESOURCE: Yes, please do. Greg Shah
06:19 PM Feature #3474: OPEN-MIME-RESOURCE: Planning to merge rev 11269. Sergey Ivanovskiy
06:09 PM Feature #3474: OPEN-MIME-RESOURCE: Rev 11268 was rebased over current trunc rev 11246. Committed revision 11269 fixed related to this branch javadoc war... Sergey Ivanovskiy
05:02 PM Feature #3474: OPEN-MIME-RESOURCE: Please wait for task branch 3434a to be merged to trunk, then rebase and merge 3474a to trunk. Please confirm that 34... Eric Faulhaber
04:55 PM Feature #3474: OPEN-MIME-RESOURCE: These 2 failed tests passed in 2 single runs. Sergey Ivanovskiy
04:01 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> The first round of main-regression tests passed with 3 failed tests. The second round is ... Sergey Ivanovskiy
03:31 PM Feature #3474: OPEN-MIME-RESOURCE: Code review 3474a revision 11267.
The change is OK. Hynek Cihlar
02:11 PM Feature #3474: OPEN-MIME-RESOURCE: The first round of main-regression tests passed with 3 failed tests. The second round is running now. Sergey Ivanovskiy
02:01 PM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11267 that added @UTF-8@ charset to @open-resource.html@ in order @OPEN-MIME-RESOURC... Sergey Ivanovskiy
06:40 AM Feature #3474: OPEN-MIME-RESOURCE: Greg Shah wrote:
> Sergey: You can start ChUI regression testing on devsrv01.
3474a passed conversion regression te... Sergey Ivanovskiy
06:37 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11266.
>
> The changes look good. I have no more objections.
> ... Sergey Ivanovskiy
06:56 AM Bug #3487: Sub-menu graphical issues: Created task branch 3487a. Hynek Cihlar

04/11/2018

03:58 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey: You can start ChUI regression testing on devsrv01. Greg Shah
03:09 PM Feature #3474: OPEN-MIME-RESOURCE: Code review 3474a revision 11266.
The changes look good. I have no more objections.
Sergey, also please test th... Hynek Cihlar
12:23 PM Feature #3474: OPEN-MIME-RESOURCE: 3474a rev 11266 is rebased over the current trunc rev 11245. Sergey Ivanovskiy
10:48 AM Feature #3474: OPEN-MIME-RESOURCE: Code Review Task Branch 3474a Revision 11265
I'm good with the changes.
Hynek? Greg Shah
10:36 AM Feature #3474: OPEN-MIME-RESOURCE: Please review the committed revision 11265. Sergey Ivanovskiy
10:27 AM Feature #3474: OPEN-MIME-RESOURCE: Yes, understand now. Committed revision 11265 fixed this issue. Sergey Ivanovskiy
10:20 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code review 3474a revision 11263
> >
> > @SwingGuiDriver.open... Hynek Cihlar
10:13 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11263
>
> @SwingGuiDriver.openMimeResource()@
> The method will... Sergey Ivanovskiy
09:39 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11263
>
> @SwingGuiDriver.openMimeResource()@
> The method will... Sergey Ivanovskiy
09:22 AM Feature #3474: OPEN-MIME-RESOURCE: Code review 3474a revision 11263
@SwingGuiDriver.openMimeResource()@
The method will throw an unexpected exceptio... Hynek Cihlar
09:03 AM Feature #3474: OPEN-MIME-RESOURCE: Code Review Task Branch 3474a Revision 11263
I'm good with the changes.
Hynek: Do you have any objections? Greg Shah
08:04 AM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11263. Sergey Ivanovskiy
08:02 AM Feature #3474: OPEN-MIME-RESOURCE: Greg Shah wrote:
> > If Desktop class helps to open Open Office documents, then this implementation will have diffe... Sergey Ivanovskiy
08:00 AM Feature #3474: OPEN-MIME-RESOURCE: I see you already fixed it. Thank you. Sergey Ivanovskiy
07:58 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek, please note that your changes in this code... Sergey Ivanovskiy
04:52 AM Feature #3474: OPEN-MIME-RESOURCE: OK, it is 3rd variant. Sergey Ivanovskiy
03:43 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > Anyway, @buildOpenResourceUrl@ always... Hynek Cihlar
12:10 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Anyway, @buildOpenResourceUrl@ always prepends the url with the webRo... Sergey Ivanovskiy

04/10/2018

04:56 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Anyway, @buildOpenResourceUrl@ always prepends the url with the webRoot as already mentioned. ... Hynek Cihlar
04:54 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > >MSG_OPEN_MIME_RESOURCE message ... Hynek Cihlar
04:51 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Also I think @path@ in @url += "/open/resource/?path=" + path;@ in @buildOpenResourceUrl@ shou... Sergey Ivanovskiy
04:48 PM Feature #3474: OPEN-MIME-RESOURCE: Also I think @path@ in @url += "/open/resource/?path=" + path;@ in @buildOpenResourceUrl@ should be url encoded. Hynek Cihlar
04:47 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > >MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't... Sergey Ivanovskiy
04:43 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> >MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't handle absolute urls,
>... Hynek Cihlar
04:18 PM Feature #3474: OPEN-MIME-RESOURCE: >MSG_OPEN_MIME_RESOURCE message handler in p2j.socket.js doesn't handle absolute urls,
>buildOpenResourceUrl always ... Sergey Ivanovskiy
03:45 PM Feature #3474: OPEN-MIME-RESOURCE: > If Desktop class helps to open Open Office documents, then this implementation will have different functionality. ... Greg Shah
02:59 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> > Plus I renamed @ReportOutputFormat@ to @MediaType@ and moved it in @com.goldencode.p2j.... Hynek Cihlar
02:58 PM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> I don't understand why it requires @finalizer@ because the @try with resource@ constructi... Hynek Cihlar
02:57 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11260.
>
> Plus I renamed @ReportOutputFormat@ to @MediaType@ an... Sergey Ivanovskiy
02:52 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11260.
> @SwingGuiDriver.openMimeResource()@
> There is a standar... Sergey Ivanovskiy
02:46 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> @GuiWebDriver.openMimeResource()@
> The opened input stream should be closed in a finalizer. ... Sergey Ivanovskiy
02:32 PM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Code review 3474a revision 11260.
>
> @open-resource.html@:
> @"https://" + window.locatio... Sergey Ivanovskiy
01:46 PM Feature #3474: OPEN-MIME-RESOURCE: Code review 3474a revision 11260.
@open-resource.html@:
@"https://" + window.location.host + "${webRoot}/${docume... Hynek Cihlar
08:50 AM Feature #3474: OPEN-MIME-RESOURCE: Code Review Task Branch 3474a Revision 11259
I'm good with the changes. I did check in some minor formatting and ... Greg Shah
06:09 AM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11259 (missed changes) that removed @ScreenDriver.this.openURL@ since @openURL@ was ... Sergey Ivanovskiy
05:52 AM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11258 that fixed #3474-62. Sergey Ivanovskiy

04/09/2018

10:31 AM Feature #3474: OPEN-MIME-RESOURCE: > I didn't implement a special code because this command should open a browser with a file resource.
It could be ... Greg Shah
09:36 AM Feature #3474: OPEN-MIME-RESOURCE: Greg Shah wrote:
> Code Review Task Branch 3474a Revision 11256
Thank you, planning to fix all these issues.
>... Sergey Ivanovskiy
07:12 AM Feature #3474: OPEN-MIME-RESOURCE: Code Review Task Branch 3474a Revision 11256
This is really good. I think it is almost finished.
1. Please cha... Greg Shah

04/07/2018

10:38 AM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11256 that fixed #3474-55 and #3474-56. Sergey Ivanovskiy

04/06/2018

10:19 AM Feature #3474: OPEN-MIME-RESOURCE: > If resources are external, then only urls will be sent to the client side. Does it need to have a feedback in this ... Greg Shah
08:30 AM Feature #3474: OPEN-MIME-RESOURCE: We don't specify the case if this command is failed. What should be done in this case? Now if resources are failed to... Sergey Ivanovskiy
07:57 AM Feature #3474: OPEN-MIME-RESOURCE: > There are server's resources and client's resources.
As far as I know, at this point all the resources we need t... Greg Shah
07:52 AM Feature #3474: OPEN-MIME-RESOURCE: > Only resources that are already on the FWD systems should be streamed. Any directly accessible URLS should be sent... Sergey Ivanovskiy
07:12 AM Feature #3474: OPEN-MIME-RESOURCE: Please remove this comment and code:... Greg Shah
07:06 AM Feature #3474: OPEN-MIME-RESOURCE: > Yes, now it is possible to load documents by their URLs. it depends on requirements for OPEN-MIME-RESOURCE.
I sh... Greg Shah
06:42 AM Feature #3474: OPEN-MIME-RESOURCE: > Hynek Cihlar wrote:
> > When you supply an absolute URL with a domain, the @openStream()@ and the @ByteStreams.cop... Sergey Ivanovskiy
06:04 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> When you supply an absolute URL with a domain, the @openStream()@ and the @ByteStreams.copy()@... Hynek Cihlar
05:55 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Currently all the url targets are first copied to the machine th... Hynek Cihlar
05:11 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Currently all the url targets are first copied to the machine that runs the FWD client and the... Sergey Ivanovskiy
04:37 AM Feature #3474: OPEN-MIME-RESOURCE: Currently all the url targets are first copied to the machine that runs the FWD client and then streamed to the end-u... Hynek Cihlar
01:38 AM Feature #3474 (Review): OPEN-MIME-RESOURCE: Sergey Ivanovskiy
01:19 AM Feature #3474: OPEN-MIME-RESOURCE: Greg, please review committed revision 11255. Sergey Ivanovskiy

04/05/2018

09:58 AM Feature #3474: OPEN-MIME-RESOURCE: OK, planning to add this optional parameter. Committed revision 11254 changed @SwingGuiDriver.this.deliverPrintOutput... Sergey Ivanovskiy
07:18 AM Feature #3474: OPEN-MIME-RESOURCE: > We should probably make this configurable. Greg, what do you think?
Yes, this makes sense. We can embed by defa... Greg Shah
04:43 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> The implemented method to wrap documents with help of @open-resource.html@ template (embe... Hynek Cihlar
02:45 AM Feature #3474: OPEN-MIME-RESOURCE: It seems that now url string should be with its protocol, for an example "file:./a.txt". Sergey Ivanovskiy
02:43 AM Feature #3474: OPEN-MIME-RESOURCE: I checked that plain string parameters can be used too. Committed rev 11252 added missed java docs. Sergey Ivanovskiy
02:23 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Finally, this construction works properly
> [...]
Does this allow you to have something... Constantin Asofiei
01:32 AM Feature #3474: OPEN-MIME-RESOURCE: The implemented method to wrap documents with help of @open-resource.html@ template (embed) doesn't work for binary c... Sergey Ivanovskiy

04/04/2018

09:05 AM Feature #3474: OPEN-MIME-RESOURCE: It needs to reuse the code that is responsible to fill html templates @HtmlResourceHandler@. Otherwise these function... Sergey Ivanovskiy

04/03/2018

03:12 PM Feature #3469: final improvements and polish for the embedded mode web client: Greg Shah wrote:
> Perhaps the hamburger menu is better located to the right of the application's logo? It seems aw... Eric Faulhaber
03:06 PM Feature #3469: final improvements and polish for the embedded mode web client: Perhaps the hamburger menu is better located to the right of the application's logo? It seems awkward to the left of... Greg Shah
03:01 PM Feature #3469: final improvements and polish for the embedded mode web client: Eric wrote:
> But as before, we probably want to blend the iframe background with the browser client background.
Ye... Constantin Asofiei
02:57 PM Feature #3469: final improvements and polish for the embedded mode web client: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, for the menubar, beside https://jqueryui.com/menu/ I ca... Constantin Asofiei
02:35 PM Feature #3469: final improvements and polish for the embedded mode web client: Constantin Asofiei wrote:
> Eric, for the menubar, beside https://jqueryui.com/menu/ I can't find anything suitable ... Eric Faulhaber
10:07 AM Feature #3469: final improvements and polish for the embedded mode web client: Eric, for the menubar, beside https://jqueryui.com/menu/ I can't find anything suitable (and out-of-the-box, to some ... Constantin Asofiei
09:26 AM Feature #3469: final improvements and polish for the embedded mode web client: > Is the licence OK? https://github.com/Templarian/MaterialDesign-Webfont/blob/master/license.md
Yes, it is OK. I... Greg Shah
08:30 AM Feature #3469: final improvements and polish for the embedded mode web client: I'm using this project to get the material-design-icons webfonts: https://github.com/Templarian/MaterialDesign-Webfon... Constantin Asofiei
02:57 PM Feature #3474: OPEN-MIME-RESOURCE: > I didn't implement it for Swing clients.
It would be useful to launch a browser (we already support that) and th... Greg Shah
02:01 PM Feature #3474: OPEN-MIME-RESOURCE: Please review committed revision 11248. Now this construction is supported by web clients. ... Sergey Ivanovskiy
10:59 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that file resources available from Swing client should ... Sergey Ivanovskiy
10:58 AM Feature #3474: OPEN-MIME-RESOURCE: Committed revision 11247 fixed issues with pdf and added new MSG_OPEN_MIME_RESOURCE. Working to implement file resour... Sergey Ivanovskiy
08:55 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> It seems that file resources available from Swing client should be available via web clie... Hynek Cihlar
08:32 AM Feature #3474: OPEN-MIME-RESOURCE: It seems that file resources available from Swing client should be available via web clients. Thus, @FileResourceHand... Sergey Ivanovskiy
07:26 AM Feature #3474: OPEN-MIME-RESOURCE: Yes, it works for me too. The problem was "Content-disposition" value: @attachment@ or @inline@. If @attachment@ is s... Sergey Ivanovskiy
06:27 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Another questions follow. We have @ReportOutputFormat@ and @GuiDriver.this.deliverPrintOu... Hynek Cihlar
06:20 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I mean https output stream. For ... Hynek Cihlar
06:10 AM Feature #3474: OPEN-MIME-RESOURCE: Another questions follow. We have @ReportOutputFormat@ and @GuiDriver.this.deliverPrintOutput(Consumer<OutputStream> ... Sergey Ivanovskiy
05:33 AM Feature #3474: OPEN-MIME-RESOURCE: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I mean https output stream. For an example, this code works prop... Sergey Ivanovskiy
04:54 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> I mean https output stream. For an example, this code works properly
> [...]
> The next... Hynek Cihlar
04:52 AM Feature #3474: OPEN-MIME-RESOURCE: Yes, agree. About embed tag I can test this http://mozilla.github.io/pdf.js/getting_started/ with our own view pdf te... Sergey Ivanovskiy
04:49 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> I mean https output stream. For an example, this code works properly
> [...]
The prob... Hynek Cihlar
04:40 AM Feature #3474: OPEN-MIME-RESOURCE: In my test the requested wrapped document has this url @https://localhost:7449/open/resource/?path=8fd81ccd-2f4c-4668... Sergey Ivanovskiy
04:28 AM Feature #3474: OPEN-MIME-RESOURCE: I mean https output stream. For an example, this code works properly... Sergey Ivanovskiy
04:10 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> It seems the idea applied in @PDFPrintOutputHandler@ to use direct output on @document.sa... Hynek Cihlar
03:59 AM Feature #3474: OPEN-MIME-RESOURCE: It seems the idea applied in @PDFPrintOutputHandler@ to use direct output on @document.save(output)@ should not work ... Sergey Ivanovskiy

04/02/2018

04:17 PM Feature #3474: OPEN-MIME-RESOURCE: Committed revision 11245.(3474a). Sergey Ivanovskiy
04:16 PM Feature #3474: OPEN-MIME-RESOURCE: I tested PDFPrintOutputHandler and encountered this exception... Sergey Ivanovskiy
11:58 AM Feature #3474: OPEN-MIME-RESOURCE: Yes, it seems we can use relative path if there are no missed design features.
It seems that web socket requires abs... Sergey Ivanovskiy
11:42 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> According to our web client design we have @webRoot@ path as a root for all available web... Hynek Cihlar
10:47 AM Feature #3474: OPEN-MIME-RESOURCE: Working on @OpenMimeResourceHandler@ that should handle print requests from js web clients by loading html document w... Sergey Ivanovskiy
05:29 AM Feature #3474: OPEN-MIME-RESOURCE: Finally, this construction works properly... Sergey Ivanovskiy
02:01 AM Feature #3474: OPEN-MIME-RESOURCE: Actually, there is a helpful example how to state 2 or 3 parameters... Sergey Ivanovskiy
01:51 AM Feature #3474: OPEN-MIME-RESOURCE: Working on @OPEN-MIME-RESOURCE@. According to @P2J-OPEN-URL@... Sergey Ivanovskiy
12:02 AM Feature #3474 (WIP): OPEN-MIME-RESOURCE: Eric Faulhaber
04:09 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav Lomany wrote:
> Guys, who is proficient in fonts? How can I display a text in FWD using an arbitrary font ... Constantin Asofiei
03:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Guys, who is proficient in fonts? How can I display a text in FWD using an arbitrary font which doesn't exist in a fo... Stanislav Lomany
10:55 AM Feature #3469: final improvements and polish for the embedded mode web client: Greg Shah wrote:
> 1. What is the idea being @TC.processRepaints()@ overriding the @disableRedraw@ flag (and not set... Constantin Asofiei
07:28 AM Feature #3469: final improvements and polish for the embedded mode web client: Summary of open items (from Constantin):
1. Finish the JS for the new embedded widgets (toolbar, menubar, module t... Greg Shah
02:22 AM Feature #3469: final improvements and polish for the embedded mode web client: 3469a was rebased from trunk 11243. Rev 11253 fixes the review notes. Constantin Asofiei

03/30/2018

05:24 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > I think we can identify columns by the referenced buffer field. For calc columns we can use parameters used at crea... Greg Shah
04:15 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Side note. In order to save information about enhanced column options, column positions and widths, we should identif... Stanislav Lomany
04:09 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: >> make text inside all cells of the hyperlinked columns blue (?) and underlined (?);
>
> I don't know if the idea ... Greg Shah
03:03 PM Feature #3474: OPEN-MIME-RESOURCE: Thank you. I will follow this design. Sergey Ivanovskiy
01:40 PM Feature #3474: OPEN-MIME-RESOURCE: > What are operands of this OPEN-MIME-RESOURCE? Is it the same as for P2J-OPEN-URL?
It is not the same.
1. MIME... Greg Shah
01:34 PM Feature #3474: OPEN-MIME-RESOURCE: OK. I will try @embed@. What are operands of this OPEN-MIME-RESOURCE? Is it the same as for P2J-OPEN-URL? Sergey Ivanovskiy
11:05 AM Feature #3474: OPEN-MIME-RESOURCE: Sergey Ivanovskiy wrote:
> It seems that a servlet that implements OPEN-MIME-RESOURCE should only send a document wi... Hynek Cihlar
10:43 AM Feature #3474: OPEN-MIME-RESOURCE: It seems that a servlet that implements OPEN-MIME-RESOURCE should only send a document with its correct mime type, th... Sergey Ivanovskiy
10:10 AM Feature #3474: OPEN-MIME-RESOURCE: Found that pdf.js supports only these browsers https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#what... Sergey Ivanovskiy
09:25 AM Feature #3474: OPEN-MIME-RESOURCE: There are many ways for converted 4GL code to generate some kind of output. Once that output is created, it needs to... Greg Shah
09:05 AM Feature #3474: OPEN-MIME-RESOURCE: Please clarify that OPEN-MIME-RESOURCE should be used in OUTPUT TO PRINTER statement as well as for the enhanced brow... Sergey Ivanovskiy

03/29/2018

02:45 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > Yes, I think we have to change both column width and row height if the font size changes. Is this specific to the e... Stanislav Lomany
10:38 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav Lomany wrote:
> > About enhanced browse font adjustment: should column width be adjusted accordingly when ... Eric Faulhaber
10:12 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: > About enhanced browse font adjustment: should column width be adjusted accordingly when we increase or decrease fon... Stanislav Lomany
01:43 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: 3537a has been merged into the trunc as bzr rev 11242. Sergey Ivanovskiy
01:29 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: I tested GUI web with rev 11242 for desktop. This bug isn't reproduced with 3537a. Planning to merge into the trunc. Sergey Ivanovskiy
11:45 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Since this is a javascript-only change, it doesn't need to go through ChUI testing. Please create a 3537a branch with... Eric Faulhaber
11:13 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: No, I have no WIP branch. Sergey Ivanovskiy
10:36 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Sergey Ivanovskiy wrote:
> OK, in this blog there is a solution to the problem how to prevent browsers from zooming ... Constantin Asofiei
07:10 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: OK, in this blog there is a solution to the problem how to prevent browsers from zooming web pages https://stackoverf... Sergey Ivanovskiy
05:08 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Sergey, thanks for the details, but don't spend any more time on this; just add a comment and we are done with this i... Constantin Asofiei
12:54 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: No, it can't help because we can't be sure that physical screens use whole number factor 1, 2, 3 and ... Sergey Ivanovskiy
12:43 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: It seems that for desktop browsers this value @Math.round(w1*ratio)@ is constant. For my monitor it always produces @... Sergey Ivanovskiy
10:10 AM Feature #3474: OPEN-MIME-RESOURCE: Created 3474a for this task. Sergey Ivanovskiy

03/28/2018

01:04 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: Stanislav Lomany wrote:
These are my thoughts, but I'd like Greg's input before you implement...
> About hyperlin... Eric Faulhaber
12:44 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: About enhanced browse font adjustment: should column width be adjusted accordingly when we increase or decrease font ... Stanislav Lomany
08:07 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...: About hyperlinking: do we want to implement the following?
# add column option @HYPERLINK "event-name"@;
# make tex... Stanislav Lomany
01:03 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> >
> > Is there another way to determine the applied zoom in... Constantin Asofiei
12:56 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Constantin Asofiei wrote:
>
> Is there another way to determine the applied zoom in the browser, beside @devicePixe... Sergey Ivanovskiy
10:26 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Eric Faulhaber wrote:
> Seems reasonable. Constantin?
Sergey: please check on all browsers - I've checked on chro... Constantin Asofiei
07:10 AM Bug #3538: The next focus widget for menu widget is not defined: If the current focus is in the menu bar, then pressing ESC must move the focus input to the window root frame. The cu... Sergey Ivanovskiy
07:07 AM Bug #3538 (Closed): The next focus widget for menu widget is not defined: Sergey Ivanovskiy

03/27/2018

06:49 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: Seems reasonable. Constantin? Eric Faulhaber
02:21 PM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: This bug is related to @deriveFont@ js function. This diff can fix this issue.... Sergey Ivanovskiy

03/26/2018

04:36 AM Bug #3537: web client fonts don't display well when browser zoom is not 100% at login: To recreate:
# set the browser zoom to more than 100% (I tested with FF)
# log into a web client program which dr... Eric Faulhaber
04:33 AM Bug #3537 (Closed): web client fonts don't display well when browser zoom is not 100% at login: Eric Faulhaber
04:22 AM Bug #3531 (Closed): Windows ChUI mode issue for CTRL-BREAK and CTRL-C pressing: Task branch 3488a was merged to trunk revision 11239. Eric Faulhaber

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

04/24/2018

04/23/2018

04/22/2018

04/20/2018

04/19/2018

04/18/2018

04/17/2018

04/16/2018

04/14/2018

04/13/2018

04/12/2018

04/11/2018

04/10/2018

04/09/2018

04/07/2018

04/06/2018

04/05/2018

04/04/2018

04/03/2018

04/02/2018

03/30/2018

03/29/2018

03/28/2018

03/27/2018

03/26/2018