Project

General

Profile

Activity

From 04/06/2019 to 05/05/2019

05/03/2019

04:49 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Please review 3908a rev 11312, especially the changes for standalone combos. Stanislav Lomany

05/01/2019

05:37 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Rebased task branch 3908a from P2J trunk revision 11306. Stanislav Lomany
01:25 PM Support #4062: getChanges() performance improvements
From Eric (see #3992-162):
> In @LT.getChanges()@, we iterate the entire @frameRegistry@ map on each call, which i...
Greg Shah
01:24 PM Support #4062 (New): getChanges() performance improvements
Greg Shah
11:25 AM Support #4059: UI performance improvements (master task)
This task is a master index of planned/proposed UI performance work:
* #4912 move UI portions of the web client to...
Greg Shah
11:18 AM Support #4059 (New): UI performance improvements (master task)
Greg Shah
11:13 AM Feature #3684 (Closed): implement a web theme inspired by material design
Greg Shah
10:17 AM Bug #2921 (Closed): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Branch 3811a was merged to trunk as revision 11303. Greg Shah

04/23/2019

06:35 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Side issue: a regular combo in FWD with decimals should round decimals according to the format prescision before cmpa... Stanislav Lomany
09:57 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> It is interesting than for integer columns
For decimal columns too.
Stanislav Lomany
09:54 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
It is interesting than for integer columns spaces are taken into cosideration for comparision. So... Stanislav Lomany
03:53 PM Feature #3876: add support for "direct font control" at the widget level
This issue is resolved with revision 11306 in 3767a. Please review. Hynek Cihlar
07:34 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
> I added it to a Possenet zip file which later on became the initial revision of the repository.
Ahh. That expla...
Greg Shah
02:39 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> Hynek Cihlar wrote:
> > The attached file is the modified @_osprint.p@ with the native code remo...
Hynek Cihlar

04/22/2019

06:32 PM Feature #4049: implement mouse wheel for combo-boxes
It affects drop-down mode. But in the attached testcase I can observe scrolling issues in simple mode, but the scroll... Stanislav Lomany
06:13 PM Feature #4049: implement mouse wheel for combo-boxes
Stanislav: Is this for the drop down mode or simple mode or both? Greg Shah
06:12 PM Feature #4049 (New): implement mouse wheel for combo-boxes
Greg Shah
06:09 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Correction: 4GL behaves correctly for non-character columns regarding cell rendering and item selection when a cell g... Stanislav Lomany
01:12 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
BTW scrolling with mouse wheel is not implemented for regular combo-boxes. Stanislav Lomany
09:32 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> The issue described in #3908-10 is questionable. Personally, I would like to implement a normal behavior. Because s... Greg Shah
08:31 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> Can we do something simple to allow non-character fields to be functional without breaking compatibility?
Charac...
Stanislav Lomany
07:37 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Stanislav Lomany wrote:
> > If there is no corresponding value in combo box-list, it displays the last used combo-bo...
Greg Shah
04:28 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> If there is no corresponding value in combo box-list, it displays the last used combo-box value for this column. So... Stanislav Lomany
01:07 PM Feature #3281: implement some frame options
Greg Shah wrote:
> The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):
>
>...
Constantin Asofiei
10:21 AM Feature #3281: implement some frame options
The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):... Greg Shah
11:42 AM Bug #3686 (Closed): PSTimer threads must be cleaned up when the client session terminates
Branch 3750b was merged to trunk as revision 11302. Greg Shah
10:24 AM Bug #3686: PSTimer threads must be cleaned up when the client session terminates
Greg Shah wrote:
> Did branch 3750b resolve this issue?
Yes.
Constantin Asofiei
10:12 AM Bug #3686: PSTimer threads must be cleaned up when the client session terminates
Did branch 3750b resolve this issue? Greg Shah

04/19/2019

05:59 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Addition: 10. We may also want to test @EACH, FIRST/LAST/UNIQUE@ cases. Really not sure about cases where @FIRST/LAST... Stanislav Lomany
09:14 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
> Testcases should be for all FWD query types: PreselectQuery, AdaptiveQuery, CompoundQuery etc. (we need to provide ... Greg Shah
07:57 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
> What aspects of the problem still need testcases? We will have external resources write these.
Testcases for @Q...
Stanislav Lomany
01:51 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Hynek Cihlar wrote:
> The attached file is the modified @_osprint.p@ with the native code removed using the implemen...
Greg Shah

04/18/2019

04:02 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Strange, but only @character@ combo columns display the item description instead of the item value in a cell. However... Stanislav Lomany
09:29 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> I assume that @value@ means the raw data in the backing lvalue (variable or database field). Correct?
Yes.

>...
Stanislav Lomany
09:01 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
I'm trying to understand your syntax in the last note.
I assume that @value@ means the raw data in the backing lva...
Greg Shah

04/17/2019

07:58 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Currently browse cells are rendered at the server side: @value --srv--> screen-value@. Combo columns add a new layer ... Stanislav Lomany
03:46 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> I'm trying to imagine the insane code inside the 4GL that causes this. It makes no sense at all.
I guess that's...
Stanislav Lomany
08:04 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> So, from a user's perspective if a cell has no corresponding value in the combo-box, a random value will be display... Greg Shah

04/16/2019

04:27 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
FYI. When a combo-box cell gains focus, it displays the value which corresponds the cell value. If there is no corres... Stanislav Lomany
10:24 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
> Please summarize status here.
I'm working on rendering/screen-value part. Because combo-box cells behavior diffe...
Stanislav Lomany
08:49 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Please summarize status here.
When will this be complete and stable?
Greg Shah
09:08 AM Feature #3811 (Pending): more misc UI features
The rest of the implementation work is deferred until the @MANUAL-HIGHLIGHT@ 4GL testcases are ready. Greg Shah
09:07 AM Feature #3811: more misc UI features
Greg Shah wrote:
> Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL t...
Eugenie Lyzenko
08:44 AM Feature #3811: more misc UI features
For the @MANUAL-HIGHLIGHT@ 4GL testcases:
* We understand that some widgets do not honor @MANUAL-HIGHLIGHT@. The ...
Greg Shah
08:38 AM Feature #3811: more misc UI features
Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL testcases. Greg Shah
07:31 AM Feature #3811: more misc UI features
Branch @3811a@ was merged to trunk as revno @11303@ then it was archived. Eugenie Lyzenko
07:14 AM Feature #3811: more misc UI features
Greg Shah wrote:
> Yes, go ahead.
Testing completed. The results: @3811a_11326_32748a0_20190416_evl.zip@.
No r...
Eugenie Lyzenko
06:49 AM Feature #3811: more misc UI features
Yes, go ahead. Greg Shah
03:38 AM Feature #3811: more misc UI features
The main regression part completed without regressions. Waiting for @CTRL-C@ to be done.
Can I merge @3811a@ into ...
Eugenie Lyzenko
08:46 AM Feature #3762 (Closed): misc UI features
Branch 3811a was merged to trunk as revision 11303. This finishes the work in this task. Greg Shah

04/15/2019

12:11 PM Feature #3811: more misc UI features
Conversion testing completed. The generated sources are identical.
Starting the runtime tests for @3811a@.
Eugenie Lyzenko
08:14 AM Feature #3811: more misc UI features
Greg Shah wrote:
> Yes, go ahead.
OK. The conversion test has been started. Then runtime.
Eugenie Lyzenko
07:56 AM Feature #3811: more misc UI features
Yes, go ahead. Greg Shah
07:59 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Rebased task branch 3908a from P2J trunk revision 11302. Stanislav Lomany

04/14/2019

03:52 PM Feature #3811: more misc UI features
Task branch @3811a@ has been rebased with trunk @11302@, new revision is @11326@.
Can I retest and if no regressio...
Eugenie Lyzenko

04/10/2019

03:11 PM Feature #3811: more misc UI features
Hynek Cihlar wrote:
> Code review @MIN-HEIGHT-CHARS@ and @MAX-HEIGHT-CHARS@ changes in 3811a.
>
> * Reference to ...
Eugenie Lyzenko
02:20 PM Feature #3811: more misc UI features
Code review @MIN-HEIGHT-CHARS@ and @MAX-HEIGHT-CHARS@ changes in 3811a.
* Reference to @MAX-WIDTH-CHARS@ in the ja...
Hynek Cihlar
12:39 PM Feature #3811: more misc UI features
Code Review Task Branch 3811a Revision 11324
I'm good with the changes.
Constantin: Are you OK with the vertica...
Greg Shah
08:00 PM Feature #3811 (Test): more misc UI features
Task branch @3811a@ rev @11324@ passed the regression testing. So looks ready for planned rebase/merge in future. Eugenie Lyzenko

04/09/2019

07:57 PM Bug #2921 (Test): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
As part of the @3811a@ the changes passed regression testing. So it is in good shape for further rebase/commit when n... Eugenie Lyzenko
01:33 PM Feature #3811: more misc UI features
Eugenie Lyzenko wrote:
> Task branch @3811a@ has been updated for review to revision @11324@.
>
> Changed return ...
Constantin Asofiei
01:25 PM Feature #3811: more misc UI features
Constantin Asofiei wrote:
> In 3811a rev 11323, I see no reason for the new @ClientExports@ APIs to return a @Boolea...
Eugenie Lyzenko
08:52 AM Feature #3811: more misc UI features
In 3811a rev 11323, I see no reason for the new @ClientExports@ APIs to return a @Boolean@ instance instead of a @boo... Constantin Asofiei

04/08/2019

06:59 PM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Greg Shah wrote:
> Code Review Task Branch 3811a Revision 11320
>
> The changes look quite good. Some feedback:
...
Eugenie Lyzenko
05:40 PM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Greg Shah wrote:
> Code Review Task Branch 3811a Revision 11320
>
> The changes look quite good. Some feedback:
...
Eugenie Lyzenko
05:02 PM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Greg Shah wrote:
> Code Review Task Branch 3811a Revision 11320
>
> The changes look quite good. Some feedback:
...
Eugenie Lyzenko
03:46 PM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Code Review Task Branch 3811a Revision 11320
The changes look quite good. Some feedback:
1. I would like commo...
Greg Shah
10:40 AM Bug #2921 (Review): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Looks completed, need review and probably more screen to check the consistency. Eugenie Lyzenko
10:39 AM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Task branch @3811a@ has been updated for review to revision @11320@.
This is the fix for GUI Web driver text verti...
Eugenie Lyzenko
06:58 PM Feature #3811: more misc UI features
Task branch @3811a@ has been updated for review to revision @11323@.
Notes resolution. @EDIT-*@ related widget imp...
Eugenie Lyzenko
03:48 PM Feature #3811: more misc UI features
See #2921-15 for the code review. Greg Shah
10:11 AM Feature #3811: more misc UI features
Stanislav Lomany wrote:
> > but for getBufferForTable it is used inside the method.
>
> It is always the browse q...
Eugenie Lyzenko
10:06 AM Feature #3811: more misc UI features
> but for getBufferForTable it is used inside the method.
It is always the browse query. Why pass it as a parameter?
Stanislav Lomany
09:58 AM Feature #3811: more misc UI features
Stanislav Lomany wrote:
> Code review branch 3811a rev 11309, 11311, 11316 regarding @ADD-COLUMNS-FROM@ I have only ...
Eugenie Lyzenko
08:40 AM Feature #3811: more misc UI features
Code review branch 3811a rev 11309, 11311, 11316 regarding @ADD-COLUMNS-FROM@ I have only code style notes:
# @query...
Stanislav Lomany
02:37 PM Feature #3908: implement browse column VIEW-AS COMBO-BOX
Created task branch 3908a from P2J trunk revision 11301. Stanislav Lomany
11:36 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
You can create a new 3908a or you can use 3811a if you think it will make merging easier. Greg Shah
11:32 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
What branch should I use for this task? Stanislav Lomany
01:53 AM Feature #4029: implement more widget rendering knowledge within the client drivers
We already push some of the "widget knowledge" to the drivers, like input-sensitive widget areas to the drivers (espe... Hynek Cihlar
 

Also available in: Atom