Project

General

Profile

Activity

From 12/09/2019 to 01/07/2020

01/08/2020

07:10 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Looking at the more enhanced updates to @convert/frame_generator.xml@ where we want to use @firstref@, @lastref@, and... Roger Borrello

01/07/2020

04:32 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> What does this have to do with the regression in #4488-22?
Just a different approach. With #44...
Roger Borrello
04:15 PM Bug #4488: Wrong frame used after display includes widgets from other frame
What does this have to do with the regression in #4488-22? Greg Shah
04:06 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> That does seem wrong. But I thought that you said the @input mychar@ code did emit in Java with f...
Roger Borrello
03:58 PM Bug #4488: Wrong frame used after display includes widgets from other frame
That does seem wrong. But I thought that you said the @input mychar@ code did emit in Java with frame f2. Greg Shah
03:43 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> > and we should now be scoped to f2 frame for the getMychar() getter, due to the repeat with fram...
Roger Borrello
03:25 PM Bug #4488: Wrong frame used after display includes widgets from other frame
> The mychar value ("myval") should be displayed in the frame sf1's fieldx widget.
Yes.
> The code (without rev...
Greg Shah
02:36 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> Yes. That is the entire point of an at-base field. It IS a widget in the frame.
Taking this ...
Roger Borrello
01:51 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Yes. That is the entire point of an at-base field. It IS a widget in the frame. Greg Shah
01:37 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Should this testcase:... Roger Borrello
12:14 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> Updates to:
> +rules/annotations/frame_scoping.rules+
> @add_widget@ was modified to inclu...
Roger Borrello
12:11 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Updates to:
+rules/annotations/frame_scoping.rules+
@add_widget@ was modified to include another condition under wh...
Roger Borrello
01:18 PM Feature #4174: implement calendar control/dtpicker OCX replacement
In Hotel GUI, you can see this usage as follows. You will see a button widget in some screen or dialog which as a tr... Greg Shah
01:07 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> There is @C:\Windows\SysWOW64\mscomct2.ocx@ OCX library that exposes @IDTPicker@ (called ...
Greg Shah
12:54 PM Feature #4174: implement calendar control/dtpicker OCX replacement
There is @C:\Windows\SysWOW64\mscomct2.ocx@ OCX library that exposes @IDTPicker@ (called Microsoft Date and Time Pick... Sergey Ivanovskiy
12:06 PM Feature #4174 (WIP): implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy
11:43 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Hynek Cihlar wrote:
> Greg Shah wrote:
> > * Does this problem only exist after 3856b? If so, is it caused by the ...
Marius Gligor
11:09 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Greg Shah wrote:
> * Does this problem only exist after 3856b? If so, is it caused by the improvements in COM/OCX c...
Hynek Cihlar
10:20 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
During conversion regression testing with a large customer application, Marius found a regression that converts witho... Greg Shah

01/06/2020

02:22 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> @fieldx@ still needs all those annotations because it is a real widget reference. Either your ch...
Roger Borrello
10:49 AM Bug #4488: Wrong frame used after display includes widgets from other frame
@fieldx@ still needs all those annotations because it is a real widget reference. Either your changes are in the wro... Greg Shah
10:42 AM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> Greg Shah wrote:
> > Yes, that is what I was referencing in #4488-11. To solve it we need ...
Roger Borrello
10:57 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
I made some additional edits. Also, please note that the FWD implementation details are now also out of date. Greg Shah
09:22 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Greg, please review these changes https://proj.goldencode.com/projects/p2j/wiki/OPEN-MIME-RESOURCE#section-3. Sergey Ivanovskiy
08:30 AM Feature #4077 (Test): add option to OPEN-MIME-RESOURCE to delete the original source file when th...
Sergey: Please update the documentation to fully explain the new syntax. You MUST leave the old syntax there as well... Greg Shah
09:30 AM Feature #4170 (WIP): add drag and drop support to treeview widget
The drag and drop support is used in the customer application being converted in #4069. If you can easily implement ... Greg Shah

01/03/2020

06:06 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> Yes, that is what I was referencing in #4488-11. To solve it we need to know when this is an @&#...
Roger Borrello
05:30 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Yes, that is what I was referencing in #4488-11. To solve it we need to know when this is an @@ base-field@ refe... Greg Shah
05:13 PM Bug #4488: Wrong frame used after display includes widgets from other frame
It looks to me like the next-to-last @add_widget@ is the problem:... Roger Borrello
04:45 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> The @jName@ values being @expr...@ is a little unexpected, as that is what was added to the ...
Roger Borrello
04:03 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> > The comment before adding the widget is "the variables used in @ base clauses in format_phrase ...
Roger Borrello
03:35 PM Bug #4488: Wrong frame used after display includes widgets from other frame
> The comment before adding the widget is "the variables used in @ base clauses in format_phrase are also part of the... Greg Shah
03:26 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Greg Shah wrote:
> In both the shared and non-shared cases, the use of @@ base-field@ syntax *does NOT create a ...
Roger Borrello
02:45 PM Bug #4488: Wrong frame used after display includes widgets from other frame
In both the shared and non-shared cases, the use of @@ base-field@ syntax *does NOT create a new widget* in the 4... Greg Shah
01:38 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Creating a standalone NON-SHARED testcase:... Roger Borrello
11:25 AM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> I am struggling to understand what exactly I should expect that code to do:
> @display mych...
Roger Borrello
11:23 AM Bug #4488: Wrong frame used after display includes widgets from other frame
I am struggling to understand what exactly I should expect that code to do:
@display mychar @@@ fieldx with frame sf...
Roger Borrello

01/02/2020

05:56 PM Bug #4488: Wrong frame used after display includes widgets from other frame
When the @display mychar @@@ fieldx with frame sf1@ is used with a non-shared sf1, the code @SharedFrameMixupSf1@ cla... Roger Borrello
04:31 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> Roger Borrello wrote:
> > ...
>
> Hold on... there's a typo in the testcase I need to co...
Roger Borrello
04:18 PM Bug #4488: Wrong frame used after display includes widgets from other frame
Roger Borrello wrote:
> ...
Hold on... there's a typo in the testcase I need to correct.
Roger Borrello
04:17 PM Bug #4488: Wrong frame used after display includes widgets from other frame
h1. Testcase
*Updates are in 4207a-11372.*
The below has been checked in as @uast/sharedframes/shared_frame_mix...
Roger Borrello
03:34 PM Bug #4488 (Closed): Wrong frame used after display includes widgets from other frame
Roger Borrello

12/24/2019

06:55 AM Support #2674: list of HTML5, CSS and Javascript features in use in the web client (both ChUI and...
It needs to check new versions of IE - Edge browser if it supports ORTC, @navigator.MediaDevices.getUserMedia@ and @P... Sergey Ivanovskiy

12/23/2019

08:55 AM Support #2674: list of HTML5, CSS and Javascript features in use in the web client (both ChUI and...
Browser market share, as of November 2019:
* "StatCounter":https://gs.statcounter.com/browser-market-share
** All...
Greg Shah
05:38 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Code review 3856b rev 11358, 11359 and 11360.
The changes are good. Please note that I removed added white spaces ...
Hynek Cihlar

12/20/2019

06:43 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Hynek Cihlar wrote:
> Code review 3856b revision 11357. These are the merged changes for @TAB-SET@ widget from 3767b...
Marius Gligor
03:31 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)

On 12/20/19 9:23 AM, Marius Gligor wrote:
> Hynek,
>
> OK i'll do that and let you know when I'm finished and re...
Hynek Cihlar

12/19/2019

01:45 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Code review 3856b revision 11357. These are the merged changes for @TAB-SET@ widget from 3767b.
@TabSetWidget.show...
Hynek Cihlar

12/18/2019

04:13 PM Feature #4438: parsing and conversion of .wrx files
The appbuilder code (see possenet in the @src/adeuib/@ directory) itself uses an OCX control for the "Property Editor... Greg Shah
04:04 PM Feature #4438: parsing and conversion of .wrx files
Greg Shah wrote:
> > Why Value property is not available for change at design time? What is criteria used by Applica...
Vladimir Tsichevski
03:48 PM Feature #4438: parsing and conversion of .wrx files
> Why Value property is not available for change at design time? What is criteria used by Application Builder to deci... Greg Shah

12/17/2019

06:30 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
I've confirmed with Hynek that he is good with all the final changes in 3856b. The next step is to get it tested so ... Greg Shah
06:07 PM Bug #4485: Bug in FWD scrollbar: inconsistent highlighting
> If the Material theme designer agrees,
I thought that was you. :)
> I would go for a lighter blue colour for...
Greg Shah
05:42 PM Bug #4485: Bug in FWD scrollbar: inconsistent highlighting
The solution is to analyse more in depth the mouse gestures when handing the scrollbars. There are 3 states (and prob... Ovidiu Maxiniuc
05:10 PM Bug #4485: Bug in FWD scrollbar: inconsistent highlighting
It's good to know 1. what themes are affected 2. is web/gui affected 3. "normal"/browse scrollbars. Stanislav Lomany
04:59 PM Bug #4485: Bug in FWD scrollbar: inconsistent highlighting
It is a requirement that we must be compatible with the Windows scrollbar behavior.
It sounds like you are descr...
Greg Shah
03:23 PM Bug #4485: Bug in FWD scrollbar: inconsistent highlighting
A minor bug in FWD scrollbar implementation:
# move the mouse pointer to the scrollbar area; the scrollbar is high...
Vladimir Tsichevski
03:21 PM Bug #4485 (New): Bug in FWD scrollbar: inconsistent highlighting
Vladimir Tsichevski
11:16 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Code review 3856b revisions 11353, 11354, 11355 and 11356. The changes look good. Hynek Cihlar
09:41 AM Feature #4438: parsing and conversion of .wrx files
1. Doing a decoding only on a simple OCX like PSTimer is not enough to conclude about .wrx file binary content forma... Marius Gligor

12/16/2019

09:59 AM Feature #4438: parsing and conversion of .wrx files
> Using Apache POI (https://poi.apache.org/) we can do that in just a few lines of code. Apache POI is an open source... Greg Shah
02:42 AM Feature #4438: parsing and conversion of .wrx files
Greg Shah wrote:
> [...]
>
> Anyway, it seems like you already have enough information to parse the parts of the ...
Marius Gligor

12/14/2019

02:02 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek, it seems that @instanceof...
Hynek Cihlar
02:23 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, it seems that @instanceof@ can be used for checking this ...
Sergey Ivanovskiy

12/13/2019

04:18 PM Bug #4437 (Test): copy, paste and cut functionality don't work as expected
Resolved in 3809e rev 11444. Greg Shah
08:07 AM Bug #4437 (WIP): copy, paste and cut functionality don't work as expected
Hynek Cihlar
07:56 AM Bug #4437: copy, paste and cut functionality don't work as expected
Hynek, please do take a look. Greg Shah
07:31 AM Bug #4437: copy, paste and cut functionality don't work as expected
Now the web client is locked if we are using editor popup menu for COPY and PASTE. If we use keyboard, then nothing h... Sergey Ivanovskiy
07:25 AM Bug #4437: copy, paste and cut functionality don't work as expected
#3080 issue has this attached file @CopyUseCase.pdf@ that explains the correct workflow for COPY/CUT. Sergey Ivanovskiy
07:16 AM Bug #4437: copy, paste and cut functionality don't work as expected
Hynek Cihlar wrote:
> Sergey, since it seems to be linked to my changes, do you want me to look at it?
I am not s...
Sergey Ivanovskiy
05:02 AM Bug #4437: copy, paste and cut functionality don't work as expected
Sergey, since it seems to be linked to my changes, do you want me to look at it? Hynek Cihlar
04:00 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
The changes in rev 11444 (3809e) are good. The found issue #4437 was fixed. Sergey Ivanovskiy
03:37 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
This is fixed in 3809e revision 11444. Sergey, please review the change. Hynek Cihlar
03:26 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
OK, thank you. Sergey Ivanovskiy
03:08 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> It seems all usages are correct now. The java doc states that length is "Location in the ...
Hynek Cihlar
03:06 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Instead of @length@ we can substitute @end@. So the final diff can be this one... Sergey Ivanovskiy
03:03 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
It seems all usages are correct now. The java doc states that length is "Location in the message where the text ends.... Sergey Ivanovskiy
02:43 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> I think that this function @readMessageText@ worked correctly before you changed it. This...
Hynek Cihlar
02:28 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
I think that this function @readMessageText@ worked correctly before you changed it. This diff rolled it back and fix... Sergey Ivanovskiy
09:12 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek, I checked that this change causes copy, paste issue. Sergey Ivanovskiy
08:57 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
It is used by ... Sergey Ivanovskiy
08:50 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
I found that this change is not clear for me... Sergey Ivanovskiy
08:41 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Yes, correct and the upload dialog shouldn't cause it too. Sergey Ivanovskiy
08:33 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> Hynek, it seems that @instanceof@ can be used for checking this condition @data.construct...
Hynek Cihlar
08:23 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek, it seems that @instanceof@ can be used for checking this condition @data.constructor !== "Uint8Array"@ because... Sergey Ivanovskiy
11:17 AM Feature #4438: parsing and conversion of .wrx files
This is very good work!
Your point about the Appbuilder made me think about the fact that the original Appbuilder ...
Greg Shah
10:19 AM Feature #4438: parsing and conversion of .wrx files
1. I started to do a decoding on .wrx file content.
Using Application Builder and PSTimer OCX which is a very simple...
Marius Gligor
05:46 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> Hynek Cihlar wrote:
> > Marius Gligor wrote:
> > > @OLE-X@ and @OLE-Y@ are @DECIMAL@ not @I...
Marius Gligor

12/12/2019

03:07 PM Bug #4473 (Test): Chrome update issues
> It looks quite stupid but with this 79 version of Chrome the offscreen canvas can be HTML5 canvas but with Chromium... Greg Shah
05:46 AM Bug #4473 (Review): Chrome update issues
Please review the committed revision 11438 (3809e). It fixed this issue. Sergey Ivanovskiy
05:28 AM Bug #4473: Chrome update issues
It looks quite stupid but with this 79 version of Chrome the offscreen canvas can be HTML5 canvas but with Chromium 7... Sergey Ivanovskiy
04:24 AM Bug #4473: Chrome update issues
We are using low-level pixel drawing operations with alpha channel control. I am afraid that the browser optimization... Sergey Ivanovskiy
04:09 AM Bug #4473: Chrome update issues
The first label on the first added desktop icon was displayed, but the next labels were absent. For reproducing it ne... Sergey Ivanovskiy
03:30 AM Bug #4473: Chrome update issues
I added #4334 as a related issue although its root cause was different. Labels are still displayed now with desktop i... Sergey Ivanovskiy
02:17 AM Bug #4473 (WIP): Chrome update issues
Sergey Ivanovskiy
02:16 AM Bug #4473: Chrome update issues
On 12/11/19 2:57 PM, Eugenie V. Lyzenko wrote:
> Guys,
>
> I have just updated chrome browser to 79.0.3945.79 revi...
Sergey Ivanovskiy
02:16 AM Bug #4473 (Closed): Chrome update issues
Sergey Ivanovskiy
02:55 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
#4437-10 Sergey Ivanovskiy
02:50 PM Bug #4437: copy, paste and cut functionality don't work as expected
The results of my check:
0) with rev 11390 copy, paste and cut works properly
1) rev 11391 can't be compiled
2) re...
Sergey Ivanovskiy
02:33 PM Bug #4437: copy, paste and cut functionality don't work as expected
Sergey Ivanovskiy wrote:
> I checked that rev 11400 (3809e) added this issue. With rev 11399 (3809e) this issue is n...
Sergey Ivanovskiy
10:25 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> Vladimir Tsichevski wrote:
> > # You can install a VisualStudio 2017 community edition 30-da...
Vladimir Tsichevski
10:12 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Vladimir Tsichevski wrote:
> # You can install a VisualStudio 2017 community edition 30-day trial.
I installed Vi...
Marius Gligor
09:05 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> Vladimir Tsichevski wrote:
> > # Got NPE in @ImageGuiImpl#draw()@, and has to add a check fo...
Vladimir Tsichevski
08:53 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Marius Gligor wrote:
> > @OLE-X@ and @OLE-Y@ are @DECIMAL@ not @INTEGER@ values.
>
> Pleas...
Marius Gligor
05:54 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Vladimir Tsichevski wrote:
> # Got NPE in @ImageGuiImpl#draw()@, and has to add a check for null (this note is not a...
Marius Gligor

12/11/2019

04:04 PM Feature #4472: Allow pause for a fraction of a second
This is not hard to implement in FWD.
The @PAUSE@ statement, @READKEY@ and the @WAIT-FOR@ statement all have this ...
Greg Shah
02:59 PM Feature #4472: Allow pause for a fraction of a second
Presumably since OpenEdge 11.3.0, "the PAUSE statement was enhanced for a whole or a fractional time-out interval in ... Vladimir Tsichevski
02:55 PM Feature #4472 (Closed): Allow pause for a fraction of a second
Vladimir Tsichevski
02:43 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
I've made a code review, and I have compared the FWD Progress bar behavior with that of the original Microsoft OCX.
...
Vladimir Tsichevski
02:06 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> @OLE-X@ and @OLE-Y@ are @DECIMAL@ not @INTEGER@ values.
Please update the javadocs to incl...
Hynek Cihlar
10:04 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Code review 3856b. I only have a few minor points.
>
> @ocx_conversion.rules@
> * The alia...
Marius Gligor

12/10/2019

09:00 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Marius Gligor wrote:
> > which means the procedure is not drooped, instead the original body ...
Marius Gligor
08:47 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> which means the procedure is not drooped, instead the original body is replaced by an empty b...
Hynek Cihlar
07:54 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> * Regarding dropping the init procedure. It would be safer to drop the procedure body, than th...
Marius Gligor
 

Also available in: Atom