Project

General

Profile

Activity

From 01/14/2020 to 02/12/2020

02/12/2020

04:15 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Roger Borrello wrote:
> The value of _filename_ is the same as what was passed in upon return, regardless of success...
Hynek Cihlar
10:41 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Roger Borrello wrote:
> > Right now they are looking to UPDATE _logical-value_ for an indicat...
Roger Borrello
03:58 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Roger Borrello wrote:
> Right now they are looking to UPDATE _logical-value_ for an indication of whether or not a f...
Hynek Cihlar

02/11/2020

02:14 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
I'm helping a customer utilize @SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER@ with respect to validating the outcome of the ... Roger Borrello
09:54 AM Feature #4113 (Closed): enable upload of files from the browser (in the web clients) using SYSTEM...
Greg Shah
09:49 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Greg Shah wrote:
> Hynek: I've reviewed the document and made some additional edits. I restructured some things and...
Hynek Cihlar
09:16 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek: I've reviewed the document and made some additional edits. I restructured some things and also added the @FIL... Greg Shah
07:54 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
:-) it is more clear now. Jurjen Dijkstra
07:36 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Jurjen Dijkstra wrote:
> Thanks!
>
> I am confused... without UPLOAD, the mycharactervariable will be assigned to...
Hynek Cihlar
06:28 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Thanks!
I am confused... without UPLOAD, the mycharactervariable will be assigned to the file name of the selected...
Jurjen Dijkstra
05:50 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Jurjen Dijkstra wrote:
> > Please review [[p2j:SYSTEM-DIALOG_GET-FILE_AT-WEB-BROWSER_UPLOAD]].
>
> In case MULTIP...
Hynek Cihlar
04:58 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
> Please review [[p2j:SYSTEM-DIALOG_GET-FILE_AT-WEB-BROWSER_UPLOAD]].
In case MULTIPLE is used I would like to kno...
Jurjen Dijkstra
04:21 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
> Please review [[p2j:SYSTEM-DIALOG_GET-FILE_AT-WEB-BROWSER_UPLOAD]].
In case MULTIPLE is used I would like to kno...
Jurjen Dijkstra
03:52 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: Please write up the documentation in "SYSTEM-DIALOG GET-FILE AT-W...
Hynek Cihlar
03:51 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Roger Borrello wrote:
> Is the @AT-WEB-BROWSER <filename>@ in trunk? I am getting @unexpected token: <filename>@ on ...
Hynek Cihlar
10:51 AM Feature #4472 (Test): Allow pause for a fraction of a second
Code Review Task Branch 4335a Revision 11412
The changes are good.
The next time we have this requirement (to c...
Greg Shah
06:54 AM Feature #4472: Allow pause for a fraction of a second
Jurjen Dijkstra wrote:
> I find it peculiar that the fractional part performs on the server and the millis on the cl...
Constantin Asofiei
06:22 AM Feature #4472: Allow pause for a fraction of a second
It is probably none of my business but I wonder why it is so complicated. PAUSE 1 is 1000 milliseconds, PAUSE 1.0 is... Jurjen Dijkstra
05:21 AM Feature #4472 (Review): Allow pause for a fraction of a second
This is fixed in 4335a rev 11412. Please review. Constantin Asofiei
10:44 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Committed revision 11353 added calendar popup but it is not styled yet and some logic are not implemented. It uses si... Sergey Ivanovskiy
10:25 AM Feature #4174: implement calendar control/dtpicker OCX replacement
It seems that it doesn't help because if the work flow goes down into @ButtonGuiImpl.handleBasicEvents(KeyInput event... Sergey Ivanovskiy
09:59 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> It is a bug because two @ActionEvent@ events are generated for one system event KeyInput:...
Hynek Cihlar
09:50 AM Feature #4174: implement calendar control/dtpicker OCX replacement
This code of @AbstractWidget@ delegates to @ancestor.processKeyEvent((KeyInput) evt)@ and this ancestor is the same @... Sergey Ivanovskiy
09:33 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I found that for a one button's click it was generated two @Acti...
Sergey Ivanovskiy
08:41 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> I found that for a one button's click it was generated two @ActionEvent@. Is it desired b...
Hynek Cihlar
08:21 AM Feature #4174: implement calendar control/dtpicker OCX replacement
I found that for a one button's click it was generated two @ActionEvent@. Is it desired behaviour? Sergey Ivanovskiy

02/10/2020

06:28 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Is the @AT-WEB-BROWSER <filename>@ in trunk? I am getting @unexpected token: <filename>@ on my conversion. Roger Borrello
05:00 PM Feature #4472: Allow pause for a fraction of a second
Greg Shah wrote:
> > You mean from p2j.cfg.xml?
>
> No, this is runtime only. I was thinking of @EnvironmentOps....
Constantin Asofiei
04:58 PM Feature #4472: Allow pause for a fraction of a second
> You mean from p2j.cfg.xml?
No, this is runtime only. I was thinking of @EnvironmentOps.getVersion()@, which can...
Greg Shah
04:57 PM Feature #4472: Allow pause for a fraction of a second
@CHOOSE ... PAUSE n@ also uses fractional seconds as millis. Constantin Asofiei
04:36 PM Feature #4472: Allow pause for a fraction of a second
Greg Shah wrote:
> I prefer to check the Progress version number and automatically implement this if @11.3@ or later...
Constantin Asofiei
04:33 PM Feature #4472: Allow pause for a fraction of a second
>>>> Greg Shah wrote:
>>>> * This use of @PAUSE <milliseconds>@ is not currently supported. See #4472. The changes...
Greg Shah
04:31 PM Feature #4472 (WIP): Allow pause for a fraction of a second
I plan to use a @legacy-system/wait-millis=true@ flag (in the directory.xml) to determine if READKEY and PAUSE will u... Constantin Asofiei
04:23 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
There are no conversion aspects to this task.
The WIN32 development environment would be the same one we use for a...
Greg Shah
04:14 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
What is the development environment to use on Windows? Roger Borrello
03:17 PM Feature #4182 (Test): KERNEL32:SLEEP() emulation
Greg Shah
03:04 PM Feature #4182 (WIP): KERNEL32:SLEEP() emulation
Roger Borrello
03:04 PM Feature #4182: KERNEL32:SLEEP() emulation
Committed in 4207a-11394.
// TODO: It is not clear that os-sleep can be interrupted. With 4GL the ...
Roger Borrello
11:26 AM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> Run the program from outside of the procedure editor (just a command line with the @-p <programna...
Roger Borrello
11:21 AM Feature #4182: KERNEL32:SLEEP() emulation
> If I mask off the lower 32, I should have an unsigned,
OK.
Greg Shah
11:21 AM Feature #4182: KERNEL32:SLEEP() emulation
Run the program from outside of the procedure editor (just a command line with the @-p <programname>@. The procedure... Greg Shah
10:03 AM Feature #4182: KERNEL32:SLEEP() emulation
With respect to sending a signal to the running procedure, I believe that it is a child of the 4GL process, and prote... Roger Borrello
10:01 AM Feature #4182: KERNEL32:SLEEP() emulation
I think that I've achieved some basic understanding... If I mask off the lower 32, I should have an unsigned, and not... Roger Borrello
09:26 AM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> In Java. @int64@ is the BDT class that will be passed instead of a @long@.
If we want to be c...
Roger Borrello
04:53 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Committed rev 11350(4174a). It added new UI but not ready for review. Working on the calendar popup, code and documen... Sergey Ivanovskiy

02/08/2020

04:06 PM Bug #4529: Mouse hovering problem: missing events
The situation:
# I have a window and a mouse hovering over it;
# Using Alt-Tab, I change the order of windows on ...
Vladimir Tsichevski
04:04 PM Bug #4529 (New): Mouse hovering problem: missing events
Vladimir Tsichevski

02/07/2020

05:30 PM Feature #4182: KERNEL32:SLEEP() emulation
Roger Borrello wrote:
> Greg Shah wrote:
> > > I have this testcase, and we don't end up leaving early in 4GL. Afte...
Greg Shah
05:29 PM Feature #4182: KERNEL32:SLEEP() emulation
In Java. @int64@ is the BDT class that will be passed instead of a @long@. Greg Shah
05:28 PM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
>
> > which is a long
>
> Use @int64@.
In the 4GL or Java?
Roger Borrello
05:24 PM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> > I have this testcase, and we don't end up leaving early in 4GL. After we return from the 10 sec...
Roger Borrello
04:58 PM Feature #4182: KERNEL32:SLEEP() emulation
> I have this testcase, and we don't end up leaving early in 4GL. After we return from the 10 seconds sleep, the prog... Greg Shah
04:51 PM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> * I suspect that in the 4GL, if there is an interruption it may be translated into a 4GL @STOP@ c...
Roger Borrello
03:44 PM Feature #4182: KERNEL32:SLEEP() emulation
Yes, that is the idea. Except there are additional things to consider:
* The parameter type rec'd will be one of ...
Greg Shah
02:39 PM Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> Conversion is automatic (see @rules/annotations/native_api.rules@ and @rules/convert/native_api.r...
Roger Borrello
02:27 PM Feature #4182: KERNEL32:SLEEP() emulation
Conversion is automatic (see @rules/annotations/native_api.rules@ and @rules/convert/native_api.rules@). The convers... Greg Shah
02:20 PM Feature #4182: KERNEL32:SLEEP() emulation
Yes... the java is quite trivial. But I want to make sure to integrate properly.
I've updated @NativeAPIEmulation...
Roger Borrello

02/06/2020

09:58 AM Feature #4170: add drag and drop support to treeview widget
The implementation of OLE Drag&Drop for TreeView is done and ready for a first code review.
1. What I did:
I provi...
Marius Gligor

02/05/2020

02:51 PM Feature #4170: add drag and drop support to treeview widget
From Marius:
> The @TreeView@ is complex and uses @handle@ instead of @com-handle@ for nodes and node widgets. Thi...
Greg Shah
09:04 AM Feature #4170: add drag and drop support to treeview widget
Marius Gligor wrote:
> I fixed that as follow:
> [...]
The call to @getWorkspaceScreenLocation@ was removed. The...
Hynek Cihlar
08:52 AM Feature #4170: add drag and drop support to treeview widget
I tried to use @NativeApiEmulation@ in the following procedure extracted from the project. ... Marius Gligor
11:20 AM Feature #4174: implement calendar control/dtpicker OCX replacement
OK Greg Shah
11:19 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Now I am trying to extend UI of the date picker widget using a subclass of @AbstractContainer@ with @BorderLayout@ an... Sergey Ivanovskiy

02/04/2020

01:34 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> There is @SENSITIVE@ attribute for 4GL widgets. @ENABLED@ uses this rule
> [...]
> and...
Hynek Cihlar
01:03 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Please remove the duplicate legacy at...
Sergey Ivanovskiy
12:19 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code review 4174a against latest trunk. > Please remove the inte...
Hynek Cihlar
12:14 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Hynek Cihlar wrote:
> Code review 4174a against latest trunk. > Please remove the interface @IFontDisp@. We already ...
Sergey Ivanovskiy
12:06 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Please remove the duplicate legacy attributes with the "OCX" pre...
Hynek Cihlar
11:58 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Hynek Cihlar wrote:
> Please remove the duplicate legacy attributes with the "OCX" prefix, like @OCX-ENABLED@ and @O...
Sergey Ivanovskiy
11:29 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Code review 4174a against latest trunk. I'm not sure if this review isn't too early, given the number of TODOs and mi... Hynek Cihlar
07:40 AM Feature #4174: implement calendar control/dtpicker OCX replacement
There is no special requirement. Reuse of the button is acceptable.
Hynek: Please review.
Greg Shah
07:14 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Please review rev 11348 (4174a). The rest components to do are the date picker viewport and popup, drop down and updo... Sergey Ivanovskiy
10:41 AM Feature #4170: add drag and drop support to treeview widget
Marius Gligor wrote:
> 1. In the ABL code in one of our projects which use TreeView OCX and OLE Drag&Drop I found st...
Hynek Cihlar
10:29 AM Feature #4170: add drag and drop support to treeview widget
1. In the ABL code in one of our projects which use TreeView OCX and OLE Drag&Drop I found statements like:... Marius Gligor
09:32 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> I'm going through the progress bar implementation merged to trunk and I think we should remove...
Vladimir Tsichevski
09:09 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
> AFAIK ProgressBar widget should be a normal legacy widget.
Yes, I agree that we want the legacy widget case to b...
Greg Shah
08:57 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
I'm going through the progress bar implementation merged to trunk and I think we should remove any OCX references in ... Hynek Cihlar

02/02/2020

04:17 PM Feature #4174: implement calendar control/dtpicker OCX replacement
The original MS Date and Time Picker can parse values given as a string in the ISO-8601 calendar system and as a stri... Sergey Ivanovskiy
08:11 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Rebased 4174a over the current trunc rev 11342. Committed 11345 (4174a) with the fix for @GuiDriver.drawStringWithinB... Sergey Ivanovskiy

01/31/2020

01:33 PM Feature #4077 (Closed): add option to OPEN-MIME-RESOURCE to delete the original source file when ...
Greg Shah
11:54 AM Feature #4170: add drag and drop support to treeview widget
@GetCursorPos@ and @ScreenToClient@ are already implemented as "native API emulation":/projects/p2j/wiki/Native_API_E... Greg Shah
11:21 AM Feature #4170: add drag and drop support to treeview widget
Here is another one: @PROCEDURE ScreenToClient EXTERNAL "user32":@
Marius Gligor
11:18 AM Feature #4170: add drag and drop support to treeview widget
Greg Shah wrote:
> > In manual OLE Drag&Drop the ABL code call HitTest on treeview. This method is not yet implemen...
Marius Gligor
11:07 AM Feature #4170: add drag and drop support to treeview widget
> In manual OLE Drag&Drop the ABL code call HitTest on treeview. This method is not yet implemented in treeview, sho... Greg Shah

01/30/2020

11:40 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Added the test case program. Sergey Ivanovskiy
11:35 AM Feature #4174: implement calendar control/dtpicker OCX replacement
The branch 4174a has been branched from the trunc. The committed rev 11342 added the conversion support for the date ... Sergey Ivanovskiy
10:36 AM Feature #4170: add drag and drop support to treeview widget
For this task I created a new branch @4170b@ from current @trunk@ and I did a cherry-pick merge from branch @4170a@ w... Marius Gligor
10:29 AM Feature #4170: add drag and drop support to treeview widget
@OLE Drag&Drop@ define 2 modes to operate, @Manual@ and @Automatic@. When @OLEDropMode@ is set to @OleDropManual@ the... Marius Gligor

01/29/2020

05:34 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Branch 3856b was dead archived. Greg Shah
05:30 PM Feature #3856 (Closed): implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 com...
Task branch 3856c was merged to trunk as revision 11341. 3856c was then archived. Greg Shah
05:33 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Branch 3858b was dead archived. Greg Shah
05:30 PM Feature #3858 (Closed): implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 co...
Task branch 3856c was merged to trunk as revision 11341. Greg Shah
08:01 AM Bug #4074 (Test): Mismatching ROW-ENTRY/LEAVE events
Greg Shah

01/28/2020

03:28 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Correct. Greg Shah
03:27 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Yes. The date and time picker extends @AbstractWidget@, even it is similar to @ComboBoxGuiImpl@, but it has another p... Sergey Ivanovskiy
03:11 PM Feature #4174: implement calendar control/dtpicker OCX replacement
It will be consistent with the rest of the application. You aren't writing a javascript widget, right? You are writ... Greg Shah
02:34 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Can this case confuse users if the today date will be different from the current jscript client date?
Sergey Ivanovskiy
02:16 PM Feature #4174: implement calendar control/dtpicker OCX replacement
For the near future, all date/time processing will be done in the Java code. We are currently ignoring the JS locale... Greg Shah
01:57 PM Feature #4174: implement calendar control/dtpicker OCX replacement
The date and time control should display its data using the current locale settings. For the web client it is the cur... Sergey Ivanovskiy
10:18 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Following this plan:
1) Conversion support for these features:
@chCtrlFrame-4:DTPicker:VISIBLE@
@chCtrlFrame-4...
Sergey Ivanovskiy

01/27/2020

05:18 PM Feature #4181: GetComputerNameA emulation
In #4121, a number of winsock native API emulation methods were added. This led to the implementation of @LogicalTer... Greg Shah
08:52 AM Bug #4521: Broken mouse tracking when dragging in Web client
Can be reproduced with current trunk in Web client. Run a test case with an active frame scroll bar. Grab the scroll ... Hynek Cihlar
08:50 AM Bug #4521 (New): Broken mouse tracking when dragging in Web client
Hynek Cihlar

01/23/2020

05:33 PM Feature #4517: optionally back the 4GL features for Registry access with the user-specific offlin...
In #4286, an offline storage facility was created that allows persistent storage/retrieval of key/value pairs in the ... Greg Shah
05:20 PM Feature #4517 (Closed): optionally back the 4GL features for Registry access with the user-specif...
Greg Shah
04:36 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
No, 3856b has been merged into 3856c instead of rebasing. 3856c is now the branch for this task. Marius is regressi... Greg Shah
03:49 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Marius Gligor wrote:
> I created a new task branch @3856c@ from current @trunk@, then I merged changes from @3856b@ ...
Sergey Ivanovskiy
04:15 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Now I reused the conversion rules of @ocx_conversion.rules@ (version 3856b rev 11371) to convert @chCtrlFrame-4:DTPic... Sergey Ivanovskiy

01/22/2020

12:56 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
> Another aspect: due to #4074-30, is seems that the new implementation will be committed in 4335a anyway, so no hope... Greg Shah
07:27 AM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
I have recently re-based 4231b where there is a revision regarding #4074-23. I converted AW recently and it seems lik... Adrian Lungu
10:05 AM Feature #4170: add drag and drop support to treeview widget
An useful link to a description of VSFlexGrid Control: http://helpcentral.componentone.com/docs/vsflexgrid8/vsflexgri... Marius Gligor
09:49 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
I created a new task branch @3856c@ from current @trunk@, then I merged changes from @3856b@ onto @3856c rev. 11341@ Marius Gligor

01/21/2020

02:29 PM Bug #4074 (WIP): Mismatching ROW-ENTRY/LEAVE events
> Should I implement it?
Yes. The change can be put into 4335a.
Greg Shah
02:13 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Closing seems to be premature. I didn't implement Hynek's idea (I got confirmation only now). Should I implement it? Stanislav Lomany
01:44 PM Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events
Greg Shah
01:39 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Greg Shah wrote:
> Hynek: Does this satisfy your notes in #4074-24?
Yes I'm sure Stanislav tested the mentioned u...
Hynek Cihlar
10:48 AM Bug #4512: New inserted row has incorrect initial cell values
New inserted rows should be blank. In order to reproduce please run @browse-entry.p@ and press 'i' to insert new row.... Sergey Ivanovskiy
10:41 AM Bug #4512 (New): New inserted row has incorrect initial cell values
Sergey Ivanovskiy
10:08 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Greg Shah wrote:
> 3809e was merged to trunk as revision 11340. If I understand correctly, the truncation of the fi...
Hynek Cihlar
09:29 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
3809e was merged to trunk as revision 11340. If I understand correctly, the truncation of the filename is now fixed ... Greg Shah
09:42 AM Bug #4473 (Closed): Chrome update issues
Branch 3809e was merged to trunk as revision 11340. Greg Shah
09:24 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
3809e was merged to trunk as revision 11340.
Sergey: Please update the FWD implementation details in the OPEN-MIME...
Greg Shah
09:13 AM Feature #3908: implement browse column VIEW-AS COMBO-BOX
3809e was merged to trunk as revision 11340. Greg Shah
07:26 AM Feature #3880: enhanced browse 3rd phase of improvements
> What is the purpose of this flag?
OK, I think I don't actually don't need this flag. The issue I want to address...
Stanislav Lomany
06:56 AM Feature #3880: enhanced browse 3rd phase of improvements
> The only issue here is that I'll think I'll add a flag that indicates if the "layout part" of the enhanced configur... Greg Shah
06:04 AM Feature #3880: enhanced browse 3rd phase of improvements
Regarding storage of the "report title" parameter. I think I'll add it to the enhanced browse configuration. The only... Stanislav Lomany
04:00 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Another issue can be observed with this expression @chCtrlFrame-4:DTPicker:VISIBLE@ and @...
Sergey Ivanovskiy

01/20/2020

04:55 PM Feature #3880: enhanced browse 3rd phase of improvements
> Do we want to have "user-specific" and "all users" settings as with enhanced browse configurations?
Yes, but as ...
Greg Shah
03:41 PM Feature #3880: enhanced browse 3rd phase of improvements
> Let's focus on allowing the user to customize it. That really resolves the issue. What can be done for this?
I...
Stanislav Lomany
01:33 PM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Guys, I need to get user id (logged in) on the client side. I'm planning to get it from th...
Greg Shah
01:18 PM Feature #3880: enhanced browse 3rd phase of improvements
For now, I think it is enough for the user to be able to clear their own customizations. I think this corresponds to... Greg Shah
01:14 PM Feature #3880: enhanced browse 3rd phase of improvements
> Implement proper "reset to default state" for the new security paradigm.
Every user (including admins) has three...
Stanislav Lomany
01:14 PM Feature #3880: enhanced browse 3rd phase of improvements
Please check in your changes to 4335a. Greg Shah
12:55 PM Feature #3880: enhanced browse 3rd phase of improvements
Default report title, in order of preference:
# User-specified custom title.
# If the browse has a title, use it....
Greg Shah
12:04 PM Feature #3880: enhanced browse 3rd phase of improvements
> ## Output a better title for browse exports. The current code uses "Browse Report", which means it has nothing to ... Stanislav Lomany
09:39 AM Feature #3880: enhanced browse 3rd phase of improvements
Guys, I need to get user id (logged in) on the client side. I'm planning to get it from the server, but I wonder when... Stanislav Lomany
04:31 PM Bug #4498: Embedded assignment of extent in shared frame fails
The changes are good.
> Why am I not calling the main constructor directly with:
Because then you would create ...
Greg Shah
03:04 PM Bug #4498: Embedded assignment of extent in shared frame fails
Greg Shah wrote:
> Code Review Task Branch 4207a Revision 11381
>
> 1. In @database_references.rules@, I don't se...
Roger Borrello
02:20 PM Bug #4498: Embedded assignment of extent in shared frame fails
Code Review Task Branch 4207a Revision 11381
1. In @database_references.rules@, I don't see any protection for the...
Greg Shah
03:20 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Another issue can be observed with this expression @chCtrlFrame-4:DTPicker:VISIBLE@ and @chCtrlFrame-4:DTPicker:ENABL... Sergey Ivanovskiy
02:33 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Yes, I would like to convert @FONT@ to @ActiveXFont@, @FONT:NAME@ to @ActiveXFont:ActiveXFontName@, @FONT:SIZE@ to @A... Sergey Ivanovskiy
02:13 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey, the problem is that you have the following item in map @<action>map6.put("font" , "ActiveXFont")</a... Marius Gligor
01:52 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Marius Gligor wrote:
> Sergey Ivanovskiy wrote:
> > Marius, thanks, I updated 4174a over 3856a and got this AST nod...
Sergey Ivanovskiy
01:44 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Marius, thanks, I updated 4174a over 3856a and got this AST node for @chCtrlFrame-4:DTPic...
Marius Gligor
01:40 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Marius, thanks, I updated 4174b over 3856a and got this AST node for @chCtrlFrame-4:DTPicker:FONT:SIZE@ expression
...
Sergey Ivanovskiy
09:24 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> I tried to add conversion rules for @FONT:NAME@ and @FONT:SIZE@ legacy attributes of Acti...
Marius Gligor
09:22 AM Feature #4174: implement calendar control/dtpicker OCX replacement
I tried to add conversion rules for @FONT:NAME@ and @FONT:SIZE@ legacy attributes of ActiveX control using these rule... Sergey Ivanovskiy
06:48 AM Feature #4174: implement calendar control/dtpicker OCX replacement
It seems that @IFontDisp@ should be added but there exists the similar interface @CustomFont@. The @CustomFont@ uses ... Sergey Ivanovskiy
07:25 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Marius: Please rebase 3856b from the latest trunk. My plan is for 3856b to be the next branch to merge to trunk. Th... Greg Shah
02:41 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Code review @3856b@ revisions 11365-11371. The changes look good. Hynek Cihlar

01/19/2020

03:41 PM Bug #4498: Embedded assignment of extent in shared frame fails
Code ready for review:
modified *rules/convert/database_references.rules*
modified *src/com/goldencode/p2j/persist/...
Roger Borrello

01/17/2020

12:18 PM Bug #4498: Embedded assignment of extent in shared frame fails
Looking into what the ramifications of passing @uppercase@ as *false* when constructing the @FieldReference@ for bulk... Roger Borrello
10:30 AM Bug #4498: Embedded assignment of extent in shared frame fails
Greg Shah wrote:
> > Does it matter what is passed for uppercase?
>
> This would not be used to match your new co...
Roger Borrello
08:59 AM Bug #4498: Embedded assignment of extent in shared frame fails
> Does it matter what is passed for uppercase?
This would not be used to match your new constructors. But it migh...
Greg Shah
02:37 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
It seems that this parameter name @length@ came from the web socket api. This web socket connection listener can conf... Sergey Ivanovskiy
02:30 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
3809e revision 11472 has good changes. Sergey Ivanovskiy
02:14 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> this change is incorrect. Please look at all its usages and fix the new incorrect usages ...
Hynek Cihlar
01:54 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > I found the cause and fixed it. The change is attached.
> >
>
> ...
Sergey Ivanovskiy

01/16/2020

05:20 PM Bug #4498: Embedded assignment of extent in shared frame fails
Roger Borrello wrote:
> Greg Shah wrote:
> > Roger Borrello wrote:
> > > A question to our database "gurus" with r...
Roger Borrello
04:29 PM Bug #4498: Embedded assignment of extent in shared frame fails
> why int versus NumberType for the index?
Because sometimes the 4GL code has a subscript which is a @NUM_LITERAL@...
Greg Shah
04:06 PM Bug #4498: Embedded assignment of extent in shared frame fails
Greg Shah wrote:
> Roger Borrello wrote:
> > A question to our database "gurus" with respect to how the "bulk" opti...
Roger Borrello
03:32 PM Bug #4498: Embedded assignment of extent in shared frame fails
*FieldReference* has two very similar constructors:
* @FieldReference(DataModelObject dmo, String property, int inde...
Roger Borrello
11:56 AM Bug #4498: Embedded assignment of extent in shared frame fails
Roger Borrello wrote:
> A question to our database "gurus" with respect to how the "bulk" option is used in @FieldRe...
Greg Shah
11:29 AM Bug #4498: Embedded assignment of extent in shared frame fails
A question to our database "gurus" with respect to how the "bulk" option is used in @FieldReference.java@...
Why c...
Roger Borrello
05:14 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> I found the cause and fixed it. The change is attached.
>
Checked in to 3809e revision 11...
Hynek Cihlar
04:59 PM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Sergey Ivanovskiy wrote:
> It is incorrect change.
Can you provide more details?
Hynek Cihlar
11:18 AM Feature #4174: implement calendar control/dtpicker OCX replacement
This resource https://wutils.com/com-dll/constants/constants-MSComCtl2.htm defines related @IDTPicker@ constants from... Sergey Ivanovskiy
08:47 AM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
I've fixed regression test errors as follow:
- remove @UIB_S = chCtrlFrame:LoadControls( OCXFile, "CtrlFrame":U)@ in...
Marius Gligor

01/15/2020

05:19 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Hynek: Does this satisfy your notes in #4074-24? Greg Shah
11:57 AM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
> Please also test the case when you click in a browse, without focus, directly in an editable cell. If I interpret y... Stanislav Lomany
09:29 AM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Code review 4231b review 11472.
Please also test the case when you click in a browse, without focus, directly in a...
Hynek Cihlar
05:48 AM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Fix for double ROW-ENTRY events is committed into 4231b rev 11472. Please review. Stanislav Lomany
02:48 PM Bug #4498: Embedded assignment of extent in shared frame fails
@com.goldencode.p2j.pattern.CommonAstSupport$Library.upPath(String)@
That's just a convenience function for TRPL. ...
Eric Faulhaber
02:04 PM Bug #4498: Embedded assignment of extent in shared frame fails
Greg Shah wrote:
> No. Read @CommonAstSupport@ for @upPath()@ to understand why.
I don't see that method in http...
Roger Borrello
10:57 AM Bug #4498: Embedded assignment of extent in shared frame fails
Greg Shah wrote:
> That is not a regression. It is more correct. We WANT the @FieldReference@ to be emitted.
Th...
Roger Borrello
10:16 AM Bug #4498: Embedded assignment of extent in shared frame fails
That is not a regression. It is more correct. We WANT the @FieldReference@ to be emitted. Greg Shah
10:04 AM Bug #4498: Embedded assignment of extent in shared frame fails
There is a regression found where this code line:... Roger Borrello
08:11 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
It is incorrect change. Sergey Ivanovskiy
08:07 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Jurjen Dijkstra wrote:
> > >
> > > any reaction?
> >
> > Sorry,...
Sergey Ivanovskiy
08:03 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Yes, go ahead. Greg Shah
07:36 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Hynek Cihlar wrote:
> Jurjen Dijkstra wrote:
> >
> > any reaction?
>
> Sorry, I was busy with other tasks. I w...
Hynek Cihlar
04:18 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
ok I was just worried that the mail was lost Jurjen Dijkstra
04:13 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Jurjen Dijkstra wrote:
>
> any reaction?
Sorry, I was busy with other tasks. I will check the sources where the...
Hynek Cihlar
04:10 AM Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG G...
Jurjen Dijkstra wrote:
> I see what the problem is: the string is cut at 64 characters.
>
> The upload directory ...
Jurjen Dijkstra

01/14/2020

04:17 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
The problem here is that @handle@ has no strong typing information that can always be known at parsing time. Sometim... Greg Shah
03:59 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Sergey Ivanovskiy wrote:
> Marius, could you explain why @ENABLED@ and @VALUE@ progress bar properties were named as...
Sergey Ivanovskiy
02:47 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
There are existing 4GL attributes of the same names, so the @PB-@ prefix was needed to differentiate these from the "... Greg Shah
02:31 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
Marius, could you explain why @ENABLED@ and @VALUE@ progress bar properties were named as @PB-ENABLED@ and @PB-VALUE@... Sergey Ivanovskiy
04:02 PM Bug #4498 (WIP): Embedded assignment of extent in shared frame fails
Roger Borrello
04:01 PM Bug #4498: Embedded assignment of extent in shared frame fails
Committed @rules/convert/database_references.rules@ in *4207a-11377* to use field reference for the lvalue of an embe... Roger Borrello
01:11 PM Bug #4498: Embedded assignment of extent in shared frame fails
No. Read @CommonAstSupport@ for @upPath()@ to understand why. Greg Shah
12:25 PM Bug #4498: Embedded assignment of extent in shared frame fails
With respect to updates to @convert/database_references.rules@ for emitting a field reference...
Wouldn't converti...
Roger Borrello
10:54 AM Bug #4498: Embedded assignment of extent in shared frame fails
Updates for un-subscripted variables in an embedded assignment are committed in 4207a-11376:... Roger Borrello
09:49 AM Bug #4498: Embedded assignment of extent in shared frame fails
Constantin Asofiei wrote:
> Hmm... isn't @tt.getMyx7()@ returning a copy of the array?
Yes, I didn't look at that...
Greg Shah
09:26 AM Bug #4498: Embedded assignment of extent in shared frame fails
Hmm... isn't @tt.getMyx7()@ returning a copy of the array? Constantin Asofiei
09:23 AM Bug #4498: Embedded assignment of extent in shared frame fails
> The last will get us past conversion, but runtime will still need some work.
Not exactly. The last will get us ...
Greg Shah
09:17 AM Bug #4498: Embedded assignment of extent in shared frame fails
Constantin Asofiei wrote:
> I think we need to change the constructor for @EmbeddedAssignment@ to receive a lambda e...
Roger Borrello
03:38 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
Yes, 4231b is fine. Greg Shah
03:36 PM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
> Please put your changes in 4335a.
I was going to put them into 4231b as they seem to be more risky. Is it OK?
Stanislav Lomany
10:50 AM Bug #4074: Mismatching ROW-ENTRY/LEAVE events
4103a is in trunk. Please put your changes in 4335a. Greg Shah
11:15 AM Feature #4170: add drag and drop support to treeview widget
I created a new branch 4170a from current trunk and rebased with 3856b Marius Gligor
02:26 AM Feature #4170: add drag and drop support to treeview widget
Greg Shah wrote:
> Good summary.
>
> What happens if the drop event occurs outside of the tree control?
If the d...
Marius Gligor
10:46 AM Feature #3880 (WIP): enhanced browse 3rd phase of improvements
Greg Shah
 

Also available in: Atom