Project

General

Profile

Activity

From 09/30/2020 to 10/29/2020

10/29/2020

01:21 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek, could you add an option to the directory to enable webgl rendering?
Will do. If... Hynek Cihlar
11:27 AM Support #4955: web client/javascript drawing - fast vs crisp
I have a question why in this code we try to clip drawings two times. It should be enough to clip one time: @cutLine@... Sergey Ivanovskiy
10:52 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I found an issue with @cutTriangleLine@ that is it can change the order of points. It nee... Sergey Ivanovskiy
10:38 AM Support #4955: web client/javascript drawing - fast vs crisp
I found an issue with @cutTriangleLine@ that is it can change the order of points. It needs to save the order of vert... Sergey Ivanovskiy
09:38 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek, could you add an option to the directory to enable webgl rendering? Sergey Ivanovskiy
07:37 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, the algorithm is quite simple. Each triangle is intersected with disjoint clipping rectangles and thus it can pr... Sergey Ivanovskiy
05:28 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Please look at this fixed versio... Hynek Cihlar
05:26 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Sadly, this modern multi line string impacts the Eclipse outline view so it doesn't show ... Hynek Cihlar
02:49 AM Support #4955: web client/javascript drawing - fast vs crisp
Sadly, this modern multi line string impacts the Eclipse outline view so it doesn't show all renderer's methods. Does... Sergey Ivanovskiy
02:28 AM Support #4955: web client/javascript drawing - fast vs crisp
The Precision Test is just drawings of clipped rectangles (not filled) but the actual rectangle drawing misses its ri... Sergey Ivanovskiy
02:08 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please look at this fixed version, the committed revision 11766 ... Sergey Ivanovskiy
10:13 PM Support #4955: web client/javascript drawing - fast vs crisp
> The WebGL prototype is nearly ready. See below a screenshot of the demo_widget.p test case rendered in WebGL.
Ve... Greg Shah
08:24 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Please look at this fixed version, the committed revision 11766 (3821c).
Sergey, it st... Hynek Cihlar
08:22 PM Support #4955: web client/javascript drawing - fast vs crisp
The WebGL prototype is nearly ready. See below a screenshot of the @demo_widget.p@ test case rendered in WebGL.
!S... Hynek Cihlar

10/28/2020

06:42 PM Support #4955: web client/javascript drawing - fast vs crisp
Please look at this fixed version, the committed revision 11766 (3821c). Sergey Ivanovskiy
05:24 PM Support #4955: web client/javascript drawing - fast vs crisp
Thanks, it has a gap that I didn't observe. Working on the fix. Sergey Ivanovskiy
04:59 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Please review this version committed revision 11763 (3821c). I am using @cutLine@, but it... Hynek Cihlar
04:12 PM Support #4955: web client/javascript drawing - fast vs crisp
Please review this version committed revision 11763 (3821c). I am using @cutLine@, but it can be used an analog @cutT... Sergey Ivanovskiy
03:12 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I will commit sooner, sorry for this delay.
OK, no problem. Hynek Cihlar
03:09 PM Support #4955: web client/javascript drawing - fast vs crisp
I will commit sooner, sorry for this delay. Sergey Ivanovskiy
01:21 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that we need to clip rectangles and then to build trian... Hynek Cihlar
01:16 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> It seems that we need to clip rectangles and then to build triangles from them.
Yes. ... Hynek Cihlar
01:00 PM Support #4955: web client/javascript drawing - fast vs crisp
It seems that we need to clip rectangles and then to build triangles from them. I suppose that line drawing primitive... Sergey Ivanovskiy
12:42 PM Support #4955: web client/javascript drawing - fast vs crisp
Yes, I am working on this issue. Do we need to clip triangles in our main js thread if we are planning to use https:/... Sergey Ivanovskiy
10:50 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey I need your help with implementing clipping. This is a real time priority as it blocks the prototype.
In th... Hynek Cihlar
08:45 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Eugenie, this renderer defined by @p2j.canvas_renderer_webgl.js@ is not used by the js cl... Eugenie Lyzenko
07:25 AM Support #4955: web client/javascript drawing - fast vs crisp
Please review @DotsPathRenderer.strokeLine@ and @DefaultPathRenderer.strokeLine@ in the committed rev. 11758 (3821c). Sergey Ivanovskiy
04:59 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> You planned to integrate this renderer into the js client. For webgl testing I am using a... Hynek Cihlar
04:56 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > but what is the performance cost... Hynek Cihlar
03:32 AM Support #4955: web client/javascript drawing - fast vs crisp
You planned to integrate this renderer into the js client. For webgl testing I am using a standalone test page with @... Sergey Ivanovskiy
03:02 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Another question is about @this.screenTexture@? Did you test som... Sergey Ivanovskiy
02:31 AM Support #4955: web client/javascript drawing - fast vs crisp
Eugenie, this renderer defined by @p2j.canvas_renderer_webgl.js@ is not used by the js client. It is not ready. Sergey Ivanovskiy
09:34 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey, Hynek,
Can you please tell if the new @WebGL@ approach is active now? Or to use it I need to configure som... Eugenie Lyzenko

10/27/2020

07:13 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Another question is about @this.screenTexture@? Did you test somehow this code with the w... Hynek Cihlar
06:56 PM Support #4955: web client/javascript drawing - fast vs crisp
Another question is about @this.screenTexture@? Did you test somehow this code with the webgl texture? The idea is re... Sergey Ivanovskiy
06:42 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> It seems that with your changes this code
> returns 13 elements but these code expect th... Hynek Cihlar
06:24 PM Support #4955: web client/javascript drawing - fast vs crisp
It seems that with your changes this code... Sergey Ivanovskiy
05:43 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I am confused now what you are planning to change and waiting for your commit.
See 382... Hynek Cihlar
04:33 PM Support #4955: web client/javascript drawing - fast vs crisp
For me using rectangles looks reasonable. Any case this code should be consistent with the rectangles format... Sergey Ivanovskiy
04:19 PM Support #4955: web client/javascript drawing - fast vs crisp
OK. Are you planning to commit these changes? Did you test drawing images with textures?... Sergey Ivanovskiy
03:20 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey, @WebGLCanvasRenderer.rectangles@ must hold triangles, but currently it is assumed it contains rectangles in @... Hynek Cihlar
10:27 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Sergey, in order to have the working ... Hynek Cihlar
10:26 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey, in order to have the working prototype one of us should ... Hynek Cihlar
10:24 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey, in order to have the working prototype one of us should focus on integrating what we a... Sergey Ivanovskiy
10:05 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey, in order to have the working prototype one of us should focus on integrating what we already have and make it... Hynek Cihlar

10/26/2020

06:55 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> The committed rev 11751 (3821c) cleaned the previous changes.
11749 up to 11751 look g... Hynek Cihlar
06:20 PM Support #4955: web client/javascript drawing - fast vs crisp
The committed rev 11751 (3821c) cleaned the previous changes. Sergey Ivanovskiy
05:56 PM Support #4955: web client/javascript drawing - fast vs crisp
Please review these changes revision 11749 (3821c).
Sergey Ivanovskiy
04:43 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> If it is OK, then I will apply it to p2j.canvas_renderer_webgl.js.
Yes, this has been ... Hynek Cihlar
04:36 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek, please look at the rev 11746 (3821c) where a vertex and its color are packed into one buffer... Sergey Ivanovskiy
03:14 PM Support #4955: web client/javascript drawing - fast vs crisp
It seems that we need to pack data in the buffer similarly to https://developer.mozilla.org/en-US/docs/Web/API/WebGLR... Sergey Ivanovskiy
12:34 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Yes, uniform variables are used for batch of drawing operations. In this case the vertex ... Hynek Cihlar
11:16 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, uniform variables are used for batch of drawing operations. In this case the vertex color should be passed in as... Sergey Ivanovskiy
09:52 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I would like to add translations... Hynek Cihlar
09:48 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I would like to add translations to the vertex shader according ... Sergey Ivanovskiy
08:42 AM Support #4955: web client/javascript drawing - fast vs crisp
I checked in WebGL version of a strokes manager in 3821c, mostly empty at this time. Hynek Cihlar
08:39 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I would like to add translations to the vertex shader according to https://webglfundament... Hynek Cihlar
08:21 AM Support #4955: web client/javascript drawing - fast vs crisp
I would like to add translations to the vertex shader according to https://webglfundamentals.org/webgl/lessons/webgl-... Sergey Ivanovskiy
04:07 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I would like that the vertex sha... Sergey Ivanovskiy

10/25/2020

01:25 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I would like that the vertex shader converts the original vertex... Sergey Ivanovskiy
03:37 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, sadly. This WebGL @gl.enable(cap);@ doesn't support @GL_PROGRAM_POINT_SIZE@ that is defined with OpenGL. I could... Sergey Ivanovskiy

10/23/2020

04:32 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Another way to use the vertex shader is to change the point size for the styled line via ... Hynek Cihlar
04:28 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Can this operation substitute a clipping rectangle? https://developer.mozilla.org/en-US/d... Hynek Cihlar
04:25 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I would like that the vertex shader converts the original vertex coordinates to its clipp... Hynek Cihlar
03:21 PM Support #4955: web client/javascript drawing - fast vs crisp
Another way to use the vertex shader is to change the point size for the styled line via @gl_PointSize@. Please look ... Sergey Ivanovskiy
03:16 PM Support #4955: web client/javascript drawing - fast vs crisp
Can this operation substitute a clipping rectangle? https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingCo... Sergey Ivanovskiy
03:09 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> > Are you planning to use Interface Blocks to communicate data between shaders? This is an exa... Sergey Ivanovskiy
11:49 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I don't know how to implement @x... Hynek Cihlar
11:31 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I don't know how to implement @xor@ operations for images and to... Sergey Ivanovskiy

10/22/2020

05:18 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> I don't know how to implement @xor@ operations for images and to draw styled lines.
Fo... Hynek Cihlar
04:05 PM Support #4955: web client/javascript drawing - fast vs crisp
OK. It would be helpful to list demos or docs from public webgl resources which solved one of these tasks. For an exa... Sergey Ivanovskiy
03:14 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey I checked in WebGL canvas renderer (@p2j.canvas_renderer_webgl.js@) in 3821c revision 11737. I added TODOs in ... Hynek Cihlar
12:43 PM Support #4955: web client/javascript drawing - fast vs crisp
I tested rev.11735 (3821c) webgl test page within Hotel_GUI on Mac mini (OS Catalina v 10.15.6, Safari 14.0). If 2d c... Sergey Ivanovskiy
04:10 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek, I don't know at this moment how to implement clipping functionality with WebGL. Sh... Hynek Cihlar

10/21/2020

04:37 PM Support #4955: web client/javascript drawing - fast vs crisp
Translations can be done at the vertex shader as it is shown https://webglfundamentals.org/webgl/lessons/webgl-2d-tra... Sergey Ivanovskiy
02:23 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek, I don't know at this moment how to implement clipping functionality with WebGL. Should it be implemented at th... Sergey Ivanovskiy
01:07 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey, I think I have acquired enough of implementation changes for the line drawing support.... Sergey Ivanovskiy
01:06 PM Support #4955: web client/javascript drawing - fast vs crisp
Please review WebGL tests results and compare them with the current FWD 2D (committed rev 11732 (3281c)). On my comp... Sergey Ivanovskiy
11:59 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey, I think I have acquired enough of implementation changes for the line drawing support. I'd like to start to i... Hynek Cihlar
07:10 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> I wasn't sure how to draw all the UI elements with images in one draw pass in WebGL. Perhaps t... Greg Shah
06:26 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the idea with two canvases that one of them has we... Sergey Ivanovskiy
05:29 AM Support #4955: web client/javascript drawing - fast vs crisp
I wasn't sure how to draw all the UI elements with images in one draw pass in WebGL. Perhaps the following scheme cou... Hynek Cihlar
03:57 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> It seems that the idea with two canvases that one of them has webgl context and the other... Hynek Cihlar

10/20/2020

02:19 PM Support #4955: web client/javascript drawing - fast vs crisp
It seems that the idea with two canvases that one of them has webgl context and the other has 2d context shouldn't wo... Sergey Ivanovskiy

10/19/2020

09:26 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Greg Shah wrote:
> > It is preferred for us to build these changes in a manner that allows th... Sergey Ivanovskiy
09:00 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Finally, Eric mentioned (to me) a good point yesterday. He pointed out that we have some cases w... Hynek Cihlar
08:52 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> It is preferred for us to build these changes in a manner that allows them to be checked in to 38... Hynek Cihlar
08:46 AM Support #4955: web client/javascript drawing - fast vs crisp
It is preferred for us to build these changes in a manner that allows them to be checked in to 3821c. You can disabl... Greg Shah
04:41 AM Support #4955: web client/javascript drawing - fast vs crisp
Here are some interesting results running @index.html@ above on my Pixel 1 mobile phone. The times are in ms.
<pre... Hynek Cihlar
04:27 AM Support #4955: web client/javascript drawing - fast vs crisp
Attached is the cleaned up version of the test html used for producing the test results above. I merged the javascrip... Hynek Cihlar

10/18/2020

02:17 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Sorry, it is not webgl. It is a offscreen canvas.
>
> Yes, in... Hynek Cihlar
02:16 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Sorry, it is not webgl. It is a offscreen canvas.
Yes, in @createOffscreenCanvas@ unco... Hynek Cihlar
02:05 PM Support #4955: web client/javascript drawing - fast vs crisp
Sorry, it is not webgl. It is a offscreen canvas. Sergey Ivanovskiy
02:03 PM Support #4955: web client/javascript drawing - fast vs crisp
Thank you! I tested your test application with Firefox and Google Chrome. Google Chrome works properly, but Firefox t... Sergey Ivanovskiy
01:48 PM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Great results! The solution is clear: implement raw webgl support. This is the top priority for... Hynek Cihlar
01:45 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> I'm reuploading webgl.js.
And in an archive. Hynek Cihlar
01:43 PM Support #4955: web client/javascript drawing - fast vs crisp
I'm reuploading webgl.js. Hynek Cihlar
12:46 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, could you share the code for your performance presentatio... Sergey Ivanovskiy
11:04 AM Support #4955: web client/javascript drawing - fast vs crisp
Great results! The solution is clear: implement raw webgl support. This is the top priority for the both of you (Hy... Greg Shah
10:44 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek, could you share the code for your performance presentations? Could we insert these... Hynek Cihlar
10:31 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek, could you share the code for your performance presentations? Could we insert these... Hynek Cihlar
10:30 AM Support #4955: web client/javascript drawing - fast vs crisp
The reported antialiasing issue in WebGL seems to be just an interpolation between canvas resolution and physical scr... Hynek Cihlar
05:46 AM Support #4955: web client/javascript drawing - fast vs crisp
Committed revision 11724 (3821c) fixed "copy logs to the clipboard" functionality. Sergey Ivanovskiy
05:26 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek, could you share the code for your performance presentations? Could we insert these charts into @p2j.perf_tests... Sergey Ivanovskiy

10/17/2020

12:23 PM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> One idea: test @Two.js@, @Phaser.js@... webgl frameworks to see if they have the ability to fully... Hynek Cihlar
10:34 AM Support #4955: web client/javascript drawing - fast vs crisp
OK, this confirms what we suspected. The webgl approach is a game changer. So the key question: can we eliminate th... Greg Shah

10/16/2020

06:15 PM Support #4955: web client/javascript drawing - fast vs crisp
Here are some results of line drawing with WebGL, 2D canvas with @lineTo@ and 2D canvas using our pixel manipulation.... Hynek Cihlar
04:06 PM Support #4955: web client/javascript drawing - fast vs crisp
It seems that anti-aliasing really should be able to be turned off. Right now it seems to be partially implemented w... Greg Shah
02:31 PM Support #4955: web client/javascript drawing - fast vs crisp
I added @p2j.perf_tests.js@ in the committed rev 11721 (3821c). The context menu is opened for the virtual task bar o... Sergey Ivanovskiy
01:19 PM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > HTMLCanvasElement.getContext accepts an antialiasing option, but this doesn't fully work, see b... Hynek Cihlar
01:13 PM Support #4955: web client/javascript drawing - fast vs crisp
> HTMLCanvasElement.getContext accepts an antialiasing option, but this doesn't fully work, see below.
You've set ... Greg Shah
10:57 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Please post a patch so that we can more easily review the exact changes.
>
The suggested cha... Eugenie Lyzenko
10:40 AM Support #4955: web client/javascript drawing - fast vs crisp
Sadly, the WebGL outputs are heavily antialiased and I don't think there is a way to turn it completely off. HTMLCanv... Hynek Cihlar
09:18 AM Support #4955: web client/javascript drawing - fast vs crisp
Please post a patch so that we can more easily review the exact changes.
> Moreover we do not even need to create ... Greg Shah
08:33 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > As you can see there is no loop inside line painter. Only single array fill call. I tested on m... Eugenie Lyzenko
08:19 AM Support #4955: web client/javascript drawing - fast vs crisp
> As you can see there is no loop inside line painter. Only single array fill call. I tested on my system and this ce... Greg Shah
07:17 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Yes, agree. Thus, we should be a... Hynek Cihlar
06:51 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Unless you are already working on it, I can prepare one of the w... Sergey Ivanovskiy
06:49 AM Support #4955: web client/javascript drawing - fast vs crisp
> Greg, do you agree?
Yes Greg Shah
04:18 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Yes, agree. Thus, we should be able to test 2d with pixels manip... Sergey Ivanovskiy
11:09 PM Support #4955: web client/javascript drawing - fast vs crisp
Guys,
Thinking about Web driver line painting speed up I've got the idea for how to improve current bitmap based a... Eugenie Lyzenko

10/15/2020

04:21 PM Support #4955: web client/javascript drawing - fast vs crisp
> I suggest we create two WebGL versions for the performance line drawing page. One in raw WebGL and another using Tw... Greg Shah
04:05 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Yes, agree. Thus, we should be able to test 2d with pixels manipulation and two variants ... Hynek Cihlar
03:07 PM Support #4955: web client/javascript drawing - fast vs crisp
Yes, agree. Thus, we should be able to test 2d with pixels manipulation and two variants of webgl. Correct? Sergey Ivanovskiy
02:55 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Please explain more thoroughly. ... Hynek Cihlar
02:48 PM Support #4955: web client/javascript drawing - fast vs crisp
I did some reading on WebGL and some related technologies. Here are some unsorted notes I made.
* it is very low l... Hynek Cihlar
02:42 PM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please explain more thoroughly. There are two canvases: one of t... Sergey Ivanovskiy
12:28 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Please explain more thoroughly. There are two canvases: one of them is 2d and the other i... Hynek Cihlar
10:41 AM Support #4955: web client/javascript drawing - fast vs crisp
> There are two canvases: one of them is 2d and the other is webgl.
Yes.
> Which one of them is transparent?
... Greg Shah
10:20 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > The one area where there will be some effort is ... Sergey Ivanovskiy
10:04 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Another potential issue is that the vertex shaders use a so called clip space coordinates that... Hynek Cihlar
09:52 AM Support #4955: web client/javascript drawing - fast vs crisp
Hynek Cihlar wrote:
> Greg Shah wrote:
> > The one area where there will be some effort is text drawing. I think w... Greg Shah
09:37 AM Support #4955: web client/javascript drawing - fast vs crisp
Another potential issue is that the vertex shaders use a so called clip space coordinates that go from -1 to 1 in eac... Hynek Cihlar
09:06 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> The one area where there will be some effort is text drawing. I think we will need to use the "2... Hynek Cihlar
07:01 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Sergey: What is your timing on the test application? I had thought it would be something pretty ... Sergey Ivanovskiy
06:56 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, you are correct. It is not hard to implement. I am using dojo menu widget for the virtual task bar. Sergey Ivanovskiy
06:27 AM Support #4955: web client/javascript drawing - fast vs crisp
When I am suggesting a popup menu, I don't mean for this to be in the 4GL. I am expecting a simple HTML5/JS based me... Greg Shah
05:40 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey: What is your timing on the test application? I had thought it would be something pretty quick.
Once that ... Greg Shah
06:08 AM Bug #4826: HTTP 413 error with Web Client
From Sergey:
> I would like to notify about this issue that today I observed the first time today when testing Hot... Greg Shah

10/14/2020

05:06 PM Support #4955: web client/javascript drawing - fast vs crisp
If you provide a popup menu for the virtual desktop background for the performance test page, we should also add a "V... Greg Shah
05:04 PM Support #4955: web client/javascript drawing - fast vs crisp
> Please review this patch for @p2j.logger.js@ to enable its functionality to the virtual desktop. Can I commit these... Greg Shah
04:28 PM Support #4955: web client/javascript drawing - fast vs crisp
Please review this patch for @p2j.logger.js@ to enable its functionality to the virtual desktop. Can I commit these c... Sergey Ivanovskiy
03:01 PM Support #4955: web client/javascript drawing - fast vs crisp
Most rectangles are drawn with 4 lines instead of the rectangle primitive. There are quite a few non-black lines dra... Greg Shah
02:42 PM Support #4955: web client/javascript drawing - fast vs crisp
Constantin Asofiei wrote:
> On Chrome, when opening a widget-heavy customer screen, the @this.offscreenCtx.putImageD... Eugenie Lyzenko
11:47 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Sergey Ivanovskiy wrote:
> > > @putImageData@ doesn't take into ac... Sergey Ivanovskiy
10:59 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, that is OK. Greg Shah
09:14 AM Support #4955: web client/javascript drawing - fast vs crisp
Ok. Following this way I need to add new js module @p2j.perf_tests.js@ to @index.html@ page... Sergey Ivanovskiy
08:37 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Yes, I am using p2j.canvas_renderer.js and p2j.strokes.js and p2j.js. Why does it requir... Constantin Asofiei
08:04 AM Support #4955: web client/javascript drawing - fast vs crisp
In regard to concurrency, I want to avoid it for now. Web workers come with other issues and certainly add complexit... Greg Shah
07:36 AM Support #4955: web client/javascript drawing - fast vs crisp
> This idea has been already proposed by Sergey, see #4785-831 and related notes. But I'm not sure how far he went wi... Greg Shah
05:19 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > @putImageData@ doesn't take into account clipping regions. Thus, if... Sergey Ivanovskiy
05:17 AM Support #4955: web client/javascript drawing - fast vs crisp
Yes, I am using p2j.canvas_renderer.js and p2j.strokes.js and p2j.js. Why does it require to run this html page with... Sergey Ivanovskiy
04:41 AM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > > what would you like to measure for our js web client. It can degr... Constantin Asofiei
04:30 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > what would you like to measure for our js web client. It can degrade performance if we add perf... Sergey Ivanovskiy
04:25 AM Support #4955: web client/javascript drawing - fast vs crisp
I didn't go farther because these changes @screenImageWorkingCanvasDrawImageRevertedChanges.patch@ added regressions ... Sergey Ivanovskiy
03:39 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > If I understand properly your idea this is a kind of "double buffering" concept. We have two bi... Hynek Cihlar
03:31 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > If I understand properly your idea this is a kind of "double buffering" concept. We have two bi... Sergey Ivanovskiy
12:05 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> Crazy idea number 2: use "WebGL":https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Tutor... Eugenie Lyzenko
11:18 AM Feature #4029: implement more widget rendering knowledge within the client drivers
I really like the idea of pushing the text editing down to the JS side. All of our text editing is very slow, I agre... Greg Shah
10:08 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Hynek Cihlar wrote:
> Ovidiu Maxiniuc wrote:
> > BTW, yesterday, because of an incremental compile issue, I had a d... Hynek Cihlar
10:06 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Ovidiu Maxiniuc wrote:
> BTW, yesterday, because of an incremental compile issue, I had a debug session with mouse e... Hynek Cihlar
10:05 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Ovidiu Maxiniuc wrote:
> We live in the era of intensive streaming. Not only Hollywood productions but games also. T... Hynek Cihlar
09:59 AM Feature #4029: implement more widget rendering knowledge within the client drivers
BTW, yesterday, because of an incremental compile issue, I had a debug session with mouse events. I had a hard time t... Ovidiu Maxiniuc
09:48 AM Feature #4029: implement more widget rendering knowledge within the client drivers
We live in the era of intensive streaming. Not only Hollywood productions but games also. This year https://www.nvidi... Ovidiu Maxiniuc
09:30 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Greg Shah wrote:
> Are there some "quick wins" we can achieve immediately using either the higher level primitives o... Hynek Cihlar
08:28 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Are there some "quick wins" we can achieve immediately using either the higher level primitives or the recording appr... Greg Shah
08:26 AM Feature #4029: implement more widget rendering knowledge within the client drivers
The transpiling is a reasonable way to handle the code duplication issue, IF we don't have to edit the result. Any h... Greg Shah
06:51 AM Feature #4029: implement more widget rendering knowledge within the client drivers
I gave all the known options more thought and I still think that some kind of transcompiling the existing widget impl... Hynek Cihlar

10/13/2020

06:54 PM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > Every line need separate putImageData.
>
> Why is this needed?
>
This is a kind of opti... Eugenie Lyzenko
06:53 PM Support #4955: web client/javascript drawing - fast vs crisp
> If I understand properly your idea this is a kind of "double buffering" concept. We have two bitmaps one that is cu... Greg Shah
06:52 PM Support #4955: web client/javascript drawing - fast vs crisp
Crazy idea number 2: use "WebGL":https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Tutorial/Getting_started_... Greg Shah
06:43 PM Support #4955: web client/javascript drawing - fast vs crisp
Greg Shah wrote:
> > We use putImageData for each and every line draw, and this includes drawing rectangles. If we c... Eugenie Lyzenko
06:35 PM Support #4955: web client/javascript drawing - fast vs crisp
> Every line need separate putImageData.
Why is this needed?
> If we get full image covered by rectangle to dra... Greg Shah
06:22 PM Support #4955: web client/javascript drawing - fast vs crisp
Constantin Asofiei wrote:
> On Chrome, when opening a widget-heavy customer screen, the @this.offscreenCtx.putImageD... Eugenie Lyzenko
06:10 PM Support #4955: web client/javascript drawing - fast vs crisp
> We use putImageData for each and every line draw, and this includes drawing rectangles. If we could use a single pu... Greg Shah
01:52 PM Support #4955: web client/javascript drawing - fast vs crisp
On Chrome, when opening a widget-heavy customer screen, the @this.offscreenCtx.putImageData(imageData, x, y);@ line i... Constantin Asofiei
12:21 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> @putImageData@ doesn't take into account clipping regions. Thus, if @disablePixelManipula... Greg Shah
12:21 PM Support #4955: web client/javascript drawing - fast vs crisp
> what would you like to measure for our js web client. It can degrade performance if we add performance counters for... Greg Shah
12:00 PM Support #4955: web client/javascript drawing - fast vs crisp
@putImageData@ doesn't take into account clipping regions. Thus, if @disablePixelManipulation=true@, then some of the... Sergey Ivanovskiy
11:49 AM Support #4955: web client/javascript drawing - fast vs crisp
>It needs to fix incorrect lines when using drawings on the canvas. I tried to check clipping regions and empty lines... Sergey Ivanovskiy
11:25 AM Support #4955: web client/javascript drawing - fast vs crisp
Greg, what would you like to measure for our js web client. It can degrade performance if we add performance counters... Sergey Ivanovskiy
11:23 AM Support #4955: web client/javascript drawing - fast vs crisp
I think the point here is how fast the @BitBlt@ or line primitives work in graphics driver. Another word what is bett... Eugenie Lyzenko
08:29 AM Support #4955: web client/javascript drawing - fast vs crisp
> I agree that these changes don't improve the UI performance that it can be visible on your computer.
I think thi... Greg Shah
08:19 AM Support #4955: web client/javascript drawing - fast vs crisp
Eugenie Lyzenko wrote:
>Disabled pixel manipulation give the following picture with many GUI line artifacts:
Yes, I... Sergey Ivanovskiy
11:17 PM Support #4955: web client/javascript drawing - fast vs crisp
Another note. Can you estimate the performance gain from @disablePixelManipulation@ approach? On my machine I do not ... Eugenie Lyzenko
09:49 PM Support #4955: web client/javascript drawing - fast vs crisp
@<customer_screen_redacted>@ Eugenie Lyzenko
08:40 AM Feature #4029: implement more widget rendering knowledge within the client drivers
> Maybe you already think about this and ruled it out because of code duplication, but what if we push the drawing pr... Greg Shah
07:07 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Maybe you already think about this and ruled it out because of code duplication, but what if we push the drawing prim... Ovidiu Maxiniuc
05:53 AM Feature #4029: implement more widget rendering knowledge within the client drivers
> The drawing primitives are already batched in single socket message. I don't think there will be much of a performa... Greg Shah

10/12/2020

06:44 PM Support #4955: web client/javascript drawing - fast vs crisp
Committed revision 11711 (3821c) changed @drawLineSegment@ so that if this flag, @disablePixelManipulation@, is set i... Sergey Ivanovskiy
05:27 PM Support #4955: web client/javascript drawing - fast vs crisp
Sergey Ivanovskiy wrote:
> Please review this patch. Can I commit these changes for 3821c?
Yes, no objection. Greg Shah
05:21 PM Support #4955: web client/javascript drawing - fast vs crisp
Please review this patch. Can I commit these changes for 3821c? Sergey Ivanovskiy
04:11 PM Support #4955: web client/javascript drawing - fast vs crisp
I encountered the new issue with @OffscreenCanvas@. If pixels manipulations are disabled, then line styles are not ap... Sergey Ivanovskiy
07:52 AM Support #4955: web client/javascript drawing - fast vs crisp
Let's use @disablePixelManipulation@ instead. The default value is @false@, which means that our current pixel manip... Greg Shah
03:29 AM Support #4955: web client/javascript drawing - fast vs crisp
It shouldn't be hard to implement because @p2j_canvas_rendering.js@ uses Canvas API for filling all drawings and only... Sergey Ivanovskiy
10:14 PM Support #4955: web client/javascript drawing - fast vs crisp
My perception is that the browser/javascript drawing performance is very dependent upon the GPU of the system.
F... Greg Shah
10:02 PM Support #4955 (Closed): web client/javascript drawing - fast vs crisp
Greg Shah
01:36 PM Feature #4029: implement more widget rendering knowledge within the client drivers
Greg Shah wrote:
> I think it may be time to consider a more serious implementation of this idea.
>
> One thing I... Hynek Cihlar
02:57 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Hynek Cihlar wrote:
> Has anybody explored the idea of moving the canvas rendering in a separate web worker? This co... Sergey Ivanovskiy
02:44 AM Feature #4029: implement more widget rendering knowledge within the client drivers
Has anybody explored the idea of moving the canvas rendering in a separate web worker? This could free the main threa... Hynek Cihlar
10:25 PM Feature #4029: implement more widget rendering knowledge within the client drivers
I think it may be time to consider a more serious implementation of this idea.
One thing I don't want to lose is t... Greg Shah

10/09/2020

04:27 PM Bug #4954: Extent field alignment
Testcase:... Stanislav Lomany
04:24 PM Bug #4954 (New): Extent field alignment
Stanislav Lomany
03:54 PM Bug #4953: Frame is not displayed when backing buffer is not available
Testcase:... Stanislav Lomany
03:50 PM Bug #4953 (New): Frame is not displayed when backing buffer is not available
Stanislav Lomany

10/07/2020

11:51 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
Adrian Lungu wrote:
> The bug was fixed in 3821c. rev. 11675. @GenericWidget.pushWidgetAttr@ is overridden in sever... Constantin Asofiei
09:12 AM Bug #4942 (Closed): Embbeded web client doesn't work for Hotel GUI
Nice! Greg Shah
08:26 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
Please review only #4942-6 (3821c/11675), as the previous comments are just part of the bug hunting process. Adrian Lungu
08:24 AM Bug #4942 (Review): Embbeded web client doesn't work for Hotel GUI
Adrian Lungu
08:24 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
The bug was fixed in 3821c. rev. 11675. @GenericWidget.pushWidgetAttr@ is overridden in several other widgets (child... Adrian Lungu
08:20 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
Hynek/Constantin: Please review. Greg Shah
06:32 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
The root of the bug is related to FWD's specific @disable-redraw@. Commenting out the @disable-row@ statements from @... Adrian Lungu

10/06/2020

09:17 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
I could restrict the searching scope somewhere around 11600..11608 revisions. The most of the intermediary revisions ... Adrian Lungu
07:28 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
I added the fix from rev. 11619 straight to the 11588 revision and tested. It seems like the embedded web client star... Adrian Lungu
06:09 AM Bug #4942: Embbeded web client doesn't work for Hotel GUI
I checked some older revisions of 3821c in order to find which one triggered the bug. I should note that the latest 3... Adrian Lungu

10/05/2020

06:14 AM Bug #4942 (Closed): Embbeded web client doesn't work for Hotel GUI
Adrian Lungu
 

Also available in: Atom