FWD » Core Development » User Interface

11/18/2020

05:24 PM Support #4955: web client/javascript drawing - fast vs crisp

I tried to fix #4955-263 but didn't succeed yet and tried to use @drawingBufferWidth@ and @drawingBufferHeight@ too. ... Sergey Ivanovskiy

03:21 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > @drawingBufferWidth@ and @drawingBufferHeight@ are actual frame ... Hynek Cihlar

01:01 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> @drawingBufferWidth@ and @drawingBufferHeight@ are actual frame buffer's @width@ and @hei... Hynek Cihlar

10:00 AM Support #4955: web client/javascript drawing - fast vs crisp

For an example, for some versions of Chrome the copy image code should take this difference into account... Sergey Ivanovskiy

09:50 AM Support #4955: web client/javascript drawing - fast vs crisp

@drawingBufferWidth@ and @drawingBufferHeight@ are actual frame buffer's @width@ and @height@, the documentation said... Sergey Ivanovskiy

09:29 AM Support #4955: web client/javascript drawing - fast vs crisp

This issue seems to be related to incorrect image shifts or sizes because dotted lines are absent and minus icons are... Sergey Ivanovskiy

08:42 AM Support #4955: web client/javascript drawing - fast vs crisp

I found a mistake in one pixel line drawings that leads to incorrect bounds of fill-in widgets. Please review the las... Sergey Ivanovskiy

07:13 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, you calculated the rectangular clipping region as
> > [... Hynek Cihlar

11/17/2020

04:49 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Did you observe this issue with Hotel GUI?
Yes, I think I've seen this, but haven't ha... Hynek Cihlar

04:48 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, you calculated the rectangular clipping region as
> [...]
> but the width and h... Hynek Cihlar

04:19 PM Support #4955: web client/javascript drawing - fast vs crisp

Did you observe this issue with Hotel GUI?
!HotelGuiDrawingImageArtifacts.png! Sergey Ivanovskiy

01:29 PM Support #4955: web client/javascript drawing - fast vs crisp

Committed rev 11820 (3821c) fixed drawRoundRect, strokeEllipse and drawPolygon. Sergey Ivanovskiy

08:07 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, you calculated the rectangular clipping region as ... Sergey Ivanovskiy

07:29 AM Support #4955: web client/javascript drawing - fast vs crisp

Image caching fixed in webgl renderer in 3821c revision 11819. Hynek Cihlar

03:28 AM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11818 (3821c) added missed fill polygon with correct clipping, improved line drawings by using 2 t... Sergey Ivanovskiy

11/16/2020

09:45 AM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11815 (3821a) fixed #4955-244 issue. Sergey Ivanovskiy

08:46 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, I observed another issue related to tool tips windows that added their images to the background after they wer... Sergey Ivanovskiy

08:36 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I tested HotelGUI and encountered tha... Sergey Ivanovskiy

04:58 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I tested HotelGUI and encountered that after clicking on the Flo... Hynek Cihlar

03:36 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Hynek Cihlar wrote:
> > > > Sergey, ... Sergey Ivanovskiy

03:36 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I tested HotelGUI and encountered that after clicking on the Floor combobox (Rooms tab) t... Hynek Cihlar

03:35 AM Support #4955: web client/javascript drawing - fast vs crisp

I tested HotelGUI and encountered that after clicking on the Floor combobox (Rooms tab) the following exception was t... Sergey Ivanovskiy

11/15/2020

06:36 PM Support #4955: web client/javascript drawing - fast vs crisp

I just hit the error @Too many active webgl contexts@ in browser console when testing a large GUI app. This was when ... Hynek Cihlar

06:18 PM Support #4955: web client/javascript drawing - fast vs crisp

3821c revision 11813 adds new @webClient@ directory parameter @renderer@ to specify web client renderer. Use the valu... Hynek Cihlar

05:05 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > Sergey, there is an unexpected line s... Hynek Cihlar

04:58 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Sergey, there is an unexpected line shift. See the file attached, thi... Sergey Ivanovskiy

06:52 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey, there is an unexpected line shift. See the file attached, this shows @demo_widgets.p@.... Hynek Cihlar

06:49 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey, there is an unexpected line shift. See the file attached, this shows @demo_widgets.p@. Hynek Cihlar

11/13/2020

03:25 PM Support #4955: web client/javascript drawing - fast vs crisp

Please look at these issues. The last issue is that the left and bottom sides of selected rectangle are not cleared w... Sergey Ivanovskiy

03:06 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Committed revision 11809 implemented JOINT_MITER style. Hynek, please review these change... Hynek Cihlar

03:03 PM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11809 implemented JOINT_MITER style. Hynek, please review these changes and test with Hotel GUI d... Sergey Ivanovskiy

11/12/2020

06:51 PM Support #4955: web client/javascript drawing - fast vs crisp

I am still working on this diff, the vertices in a line segment can change their order by @cutLine@ in @drawLineSegme... Sergey Ivanovskiy

04:01 AM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11807 (3821c) fixed repeated triangles for @strokeEllipse@. Sergey Ivanovskiy

02:52 AM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11806 (3821c) implemented draw3DRect, strokeEllipse, fixed cutTriangleLine and did minor changes f... Sergey Ivanovskiy

11/11/2020

05:27 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Also I added webgl dependencies for @p2j.perf_tests.js@ in @index.html@ and did minor cha... Hynek Cihlar

05:24 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, please evaluate @p2j.strokes.webgl.js@ (the committed revision 11800 (3821c)). Tod... Hynek Cihlar

04:58 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, please evaluate @p2j.strokes.webgl.js@ (the committed revision 11800 (3821c)). Tod... Hynek Cihlar

04:14 AM Support #4955: web client/javascript drawing - fast vs crisp

Also I added webgl dependencies for @p2j.perf_tests.js@ in @index.html@ and did minor changes in @p2j.canvas_renderer... Sergey Ivanovskiy

03:55 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, please evaluate @p2j.strokes.webgl.js@ (the committed revision 11800 (3821c)). Today planning to implement joi... Sergey Ivanovskiy

11/10/2020

02:21 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> We may need to increment the coordinates by 0,5 to get to the right pixel boundary.
To clar... Hynek Cihlar

02:16 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, now our vertical and horizontal lines extended asymmetrically towards the right an... Hynek Cihlar

02:09 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, now our vertical and horizontal lines extended asymmetrically towards the right and bottom sides of the webgl ... Sergey Ivanovskiy

11/09/2020

04:57 PM Feature #4174: implement calendar control/dtpicker OCX replacement

The @uast/calendar/calendar-formats.txt.4gl@ and @uast/calendar/calendar-value-tests.p@ shows that the @VALUE@ attrib... Constantin Asofiei

12:26 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> If draw vertex arrays with @gl.TRIANGLES@, then all rectangular area between its left and... Hynek Cihlar

11:59 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Don't understand what is missed here.
>
> What is the expecte... Sergey Ivanovskiy

11:40 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Don't understand what is missed here.
What is the expected outcome?
Hynek Cihlar

08:55 AM Support #4955: web client/javascript drawing - fast vs crisp

Thank you for the updates. Our objective is to complete this work before next Monday. Greg Shah

08:52 AM Support #4955: web client/javascript drawing - fast vs crisp

I used this vertex shader in the previous example... Sergey Ivanovskiy

08:50 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, I tried to add two another buffers for these two new attributes, relative distance from @0@ to @1@ alone a lin... Sergey Ivanovskiy

11/06/2020

03:29 PM Support #4955: web client/javascript drawing - fast vs crisp

* Planning to evaluate ideas from https://github.com/spite/THREE.MeshLine/blob/master/src/THREE.MeshLine.js
in order... Sergey Ivanovskiy

01:51 PM Support #4955: web client/javascript drawing - fast vs crisp

Greg Shah wrote:
> How much more work is needed to have this be a functional solution which can be provided to a cus... Hynek Cihlar

01:09 PM Support #4955: web client/javascript drawing - fast vs crisp

How much more work is needed to have this be a functional solution which can be provided to a customer for testing? Greg Shah

01:07 PM Support #4955: web client/javascript drawing - fast vs crisp

Probably we need to follow this way https://cesium.com/blog/2013/04/22/robust-polyline-rendering-with-webgl/ Sergey Ivanovskiy

01:05 PM Support #4955: web client/javascript drawing - fast vs crisp

Committed rev 11794 (3821c), sorry for this delayed commit. Sergey Ivanovskiy

10:30 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Please apply this attached diff and test Hotel GUI. I found that Hotel GUI Calendar popup... Hynek Cihlar

09:27 AM Support #4955: web client/javascript drawing - fast vs crisp

https://stackoverflow.com/questions/51384738/draw-a-ellipse-curve-in-fragment-shader (Example https://jsfiddle.net/7r... Sergey Ivanovskiy

09:24 AM Support #4955: web client/javascript drawing - fast vs crisp

Interesting information https://en.wikipedia.org/wiki/ANGLE_(software) that Firefox uses ANGLE as the default WebGL b... Sergey Ivanovskiy

08:30 AM Support #4955: web client/javascript drawing - fast vs crisp

Please apply this attached diff and test Hotel GUI. I found that Hotel GUI Calendar popup didn't clear outlines of th... Sergey Ivanovskiy

07:12 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> OK. I see @glStrokesManager@ now. I just tested Hotel GUI and didn't do special performan... Hynek Cihlar

07:07 AM Support #4955: web client/javascript drawing - fast vs crisp

OK. I see @glStrokesManager@ now. I just tested Hotel GUI and didn't do special performance tests. Sergey Ivanovskiy

06:59 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek, I found that the strokes ... Hynek Cihlar

06:45 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, I found that the strokes manager in your test uses the 2d... Sergey Ivanovskiy

06:41 AM Support #4955: web client/javascript drawing - fast vs crisp

I found this article https://mattdesl.svbtle.com/drawing-lines-is-hard that describes available WebGL methods to supp... Sergey Ivanovskiy

06:16 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, I found that the strokes manager in your test uses the 2d canvas pixels strokes ma... Hynek Cihlar

11/05/2020

02:52 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, I found that the strokes manager in your test uses the 2d canvas pixels strokes manager so I tried to test @p2... Sergey Ivanovskiy

07:54 AM Support #4955: web client/javascript drawing - fast vs crisp

This diff has... Sergey Ivanovskiy

07:15 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, could you share your source files that I can reproduce your results too when text ... Hynek Cihlar

05:08 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, could you share your source files that I can reproduce your results too when text are cleared properly? Sergey Ivanovskiy

01:36 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Constantin, this ocx control had been created without any ... Sergey Ivanovskiy

10:43 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Constantin, this ocx control had been created without any knowledge about 4GL, it should ... Constantin Asofiei

10:37 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Greg Shah wrote:
> > It is not clear to me what is being lost here.
> The OS date form... Sergey Ivanovskiy

10:08 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> It is not clear to me what is being lost here.
The OS date format affects when the @VALUE@ attri... Constantin Asofiei

09:38 AM Feature #4174: implement calendar control/dtpicker OCX replacement

> to emulate the OS date format, we can either configure it in the directory.xml or set the LANG system property befo... Greg Shah

09:32 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Looks like the @VALUE@ attribute for the calendar is using OS DATE format - I don't know about the time portion of th... Constantin Asofiei

11/04/2020

03:41 PM Bug #4995 (Closed): NPE in WindowManager.isDisplayed

Greg Shah

02:48 PM Bug #4995: NPE in WindowManager.isDisplayed

I'm OK with the 3821c/11791 changes. Constantin Asofiei

12:57 PM Bug #4995 (Review): NPE in WindowManager.isDisplayed

I confirm the issue is resolved with 3821c/11791.
Constantin, since you recently have changed the code in this are... Eric Faulhaber

12:18 PM Bug #4995 (WIP): NPE in WindowManager.isDisplayed

This was really regression from recent @RoaringBitmap@ usage optimization. In @ChUI@ it is not expected for drop-down... Eugenie Lyzenko

10:31 AM Bug #4995: NPE in WindowManager.isDisplayed

Recreated with terminal client. Debugging. Eugenie Lyzenko

09:33 AM Bug #4995: NPE in WindowManager.isDisplayed

Recreate:
# log into Hotel ChUI
# Choose "R Rooms" menu option
# (U)pdate from strip menu
# down arrow to see d... Eric Faulhaber

09:30 AM Bug #4995 (Closed): NPE in WindowManager.isDisplayed

Eric Faulhaber

09:51 AM Bug #4993: Overlay prevents input when modal dialog open in embedded mode in Chrome

Constantin Asofiei wrote:
> What's your Chrome version? With Chrome Version 85.0.4183.121 (Official Build) unknown (... Hynek Cihlar

09:14 AM Bug #4993: Overlay prevents input when modal dialog open in embedded mode in Chrome

What's your Chrome version? With Chrome Version 85.0.4183.121 (Official Build) unknown (64-bit) I can open and use th... Constantin Asofiei

09:13 AM Bug #4993: Overlay prevents input when modal dialog open in embedded mode in Chrome

To reproduce: run Hotel GUI in embedded mode, open any modal dialog (Calendar for example). The grey overlay, which i... Hynek Cihlar

09:10 AM Bug #4993 (Closed): Overlay prevents input when modal dialog open in embedded mode in Chrome

Hynek Cihlar

09:40 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I think that the date time picker formats its value according to the locale settings. So I can change locale and its ... Sergey Ivanovskiy

09:22 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin, OK, I will try to write these instructions. It seems that finally it was due to the fact that @VALUE@ is ... Sergey Ivanovskiy

09:17 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> I would like to propose to extend @DATE@, @DATETIME@ and @DATETIME-TZ@ in FWD in order to... Constantin Asofiei

09:15 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I would like to propose to extend @DATE@, @DATETIME@ and @DATETIME-TZ@ in FWD in order to except ISO8601 date and tim... Sergey Ivanovskiy

09:15 AM Feature #4174: implement calendar control/dtpicker OCX replacement

In my use case in #4947, there is no usage of the FORMAT attribute for the calendar. So it uses the default calendar... Constantin Asofiei

09:13 AM Feature #4174: implement calendar control/dtpicker OCX replacement

It seems that @SESSION:DATE-FORMAT@ is applied only (has impacts only) to @DATE@, @DATETIME@ and @DATETIME-TZ@ and it... Sergey Ivanovskiy

09:06 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Sergey, the shown VALUE is not ISO-8601 format; why was this assumption made, that the s... Sergey Ivanovskiy

11/03/2020

04:22 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey, the shown VALUE is not ISO-8601 format; why was this assumption made, that the string read from the VALUE att... Constantin Asofiei

02:45 PM Feature #4174: implement calendar control/dtpicker OCX replacement

I forgot to add... Sergey Ivanovskiy

02:32 PM Feature #4174: implement calendar control/dtpicker OCX replacement

The date time picker should have style format. I recorded this video @vm-date-picker.mkv@ Sergey Ivanovskiy

01:29 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey, I can't make it work. I need your help with a testcase like this (with the original OCX):
* use an 'invisib... Constantin Asofiei

10:37 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Sergey, how can I run test-date-time-picker-1.w in 4GL?
Constantin, please read this ... Sergey Ivanovskiy

08:55 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey, how can I run test-date-time-picker-1.w in 4GL? Constantin Asofiei

03:53 PM Support #4955: web client/javascript drawing - fast vs crisp

@clipTriangles@ should work now but in some cases it needs to test if a clipping rectangle is inside a triangle. Thus... Sergey Ivanovskiy

03:40 PM Support #4955: web client/javascript drawing - fast vs crisp

I have no manual edits and still can't reproduce the correct screen. All drawings are still present at the screen aft... Sergey Ivanovskiy

02:53 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> What is the value for @graphicsCached@ must be? This question is due to @p2j.screen.js@ h... Hynek Cihlar

02:39 PM Support #4955: web client/javascript drawing - fast vs crisp

What is the value for @graphicsCached@ must be? This question is due to @p2j.screen.js@ has this code at the end of t... Sergey Ivanovskiy

02:10 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Yes, @screenTexture@. I enabled @webgl@ and recorded this video @hotel-webgl-enabled.mkv@... Hynek Cihlar

11:07 AM Support #4955: web client/javascript drawing - fast vs crisp

Yes, @screenTexture@. I enabled @webgl@ and recorded this video @hotel-webgl-enabled.mkv@ with @hotel_gui@. Labels an... Sergey Ivanovskiy

09:29 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > It is not clear for me now. Even... Hynek Cihlar

09:23 AM Support #4955: web client/javascript drawing - fast vs crisp

Don't mind this note because it occurs due to @disablePixelManipulation@... Sergey Ivanovskiy

09:18 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It is not clear for me now. Even we can put drawing on the textu... Sergey Ivanovskiy

07:29 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> It is not clear for me now. Even we can put drawing on the texture, how we can clean the ... Hynek Cihlar

06:58 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Sergey Ivanovskiy wrote:
> > > > but... Sergey Ivanovskiy

11/02/2020

07:14 PM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11777-11778 (3821c) fixed @cutLine@ in the case of slopped line given by @(x1, y1)@ and @(x2, y2)@. Sergey Ivanovskiy

11/01/2020

04:06 PM Support #4955: web client/javascript drawing - fast vs crisp

Committed revision 11774-11776 (3821c) fixed @clipTriangles()@ and added @clipTrianglesTest@. Sergey Ivanovskiy

10/30/2020

05:08 PM Support #4955: web client/javascript drawing - fast vs crisp

I am not sure that @clipTriangles@ is important for the general cases but the current implementation has gaps. One of... Sergey Ivanovskiy

10/29/2020

01:21 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, could you add an option to the directory to enable webgl rendering?
Will do. If... Hynek Cihlar

11:27 AM Support #4955: web client/javascript drawing - fast vs crisp

I have a question why in this code we try to clip drawings two times. It should be enough to clip one time: @cutLine@... Sergey Ivanovskiy

10:52 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I found an issue with @cutTriangleLine@ that is it can change the order of points. It nee... Sergey Ivanovskiy

10:38 AM Support #4955: web client/javascript drawing - fast vs crisp

I found an issue with @cutTriangleLine@ that is it can change the order of points. It needs to save the order of vert... Sergey Ivanovskiy

09:38 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, could you add an option to the directory to enable webgl rendering? Sergey Ivanovskiy

07:37 AM Support #4955: web client/javascript drawing - fast vs crisp

Yes, the algorithm is quite simple. Each triangle is intersected with disjoint clipping rectangles and thus it can pr... Sergey Ivanovskiy

05:28 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Please look at this fixed versio... Hynek Cihlar

05:26 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Sadly, this modern multi line string impacts the Eclipse outline view so it doesn't show ... Hynek Cihlar

02:49 AM Support #4955: web client/javascript drawing - fast vs crisp

Sadly, this modern multi line string impacts the Eclipse outline view so it doesn't show all renderer's methods. Does... Sergey Ivanovskiy

02:28 AM Support #4955: web client/javascript drawing - fast vs crisp

The Precision Test is just drawings of clipped rectangles (not filled) but the actual rectangle drawing misses its ri... Sergey Ivanovskiy

02:08 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please look at this fixed version, the committed revision 11766 ... Sergey Ivanovskiy

10:13 PM Support #4955: web client/javascript drawing - fast vs crisp

> The WebGL prototype is nearly ready. See below a screenshot of the demo_widget.p test case rendered in WebGL.
Ve... Greg Shah

08:24 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Please look at this fixed version, the committed revision 11766 (3821c).
Sergey, it st... Hynek Cihlar

08:22 PM Support #4955: web client/javascript drawing - fast vs crisp

The WebGL prototype is nearly ready. See below a screenshot of the @demo_widget.p@ test case rendered in WebGL.
!S... Hynek Cihlar

10/28/2020

06:42 PM Support #4955: web client/javascript drawing - fast vs crisp

Please look at this fixed version, the committed revision 11766 (3821c). Sergey Ivanovskiy

05:24 PM Support #4955: web client/javascript drawing - fast vs crisp

Thanks, it has a gap that I didn't observe. Working on the fix. Sergey Ivanovskiy

04:59 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Please review this version committed revision 11763 (3821c). I am using @cutLine@, but it... Hynek Cihlar

04:12 PM Support #4955: web client/javascript drawing - fast vs crisp

Please review this version committed revision 11763 (3821c). I am using @cutLine@, but it can be used an analog @cutT... Sergey Ivanovskiy

03:12 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I will commit sooner, sorry for this delay.
OK, no problem. Hynek Cihlar

03:09 PM Support #4955: web client/javascript drawing - fast vs crisp

I will commit sooner, sorry for this delay. Sergey Ivanovskiy

01:21 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that we need to clip rectangles and then to build trian... Hynek Cihlar

01:16 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> It seems that we need to clip rectangles and then to build triangles from them.
Yes. ... Hynek Cihlar

01:00 PM Support #4955: web client/javascript drawing - fast vs crisp

It seems that we need to clip rectangles and then to build triangles from them. I suppose that line drawing primitive... Sergey Ivanovskiy

12:42 PM Support #4955: web client/javascript drawing - fast vs crisp

Yes, I am working on this issue. Do we need to clip triangles in our main js thread if we are planning to use https:/... Sergey Ivanovskiy

10:50 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey I need your help with implementing clipping. This is a real time priority as it blocks the prototype.
In th... Hynek Cihlar

08:45 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Eugenie, this renderer defined by @p2j.canvas_renderer_webgl.js@ is not used by the js cl... Eugenie Lyzenko

07:25 AM Support #4955: web client/javascript drawing - fast vs crisp

Please review @DotsPathRenderer.strokeLine@ and @DefaultPathRenderer.strokeLine@ in the committed rev. 11758 (3821c). Sergey Ivanovskiy

04:59 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> You planned to integrate this renderer into the js client. For webgl testing I am using a... Hynek Cihlar

04:56 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > but what is the performance cost... Hynek Cihlar

03:32 AM Support #4955: web client/javascript drawing - fast vs crisp

You planned to integrate this renderer into the js client. For webgl testing I am using a standalone test page with @... Sergey Ivanovskiy

03:02 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Another question is about @this.screenTexture@? Did you test som... Sergey Ivanovskiy

02:31 AM Support #4955: web client/javascript drawing - fast vs crisp

Eugenie, this renderer defined by @p2j.canvas_renderer_webgl.js@ is not used by the js client. It is not ready. Sergey Ivanovskiy

09:34 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey, Hynek,
Can you please tell if the new @WebGL@ approach is active now? Or to use it I need to configure som... Eugenie Lyzenko

10/27/2020

07:13 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Another question is about @this.screenTexture@? Did you test somehow this code with the w... Hynek Cihlar

06:56 PM Support #4955: web client/javascript drawing - fast vs crisp

Another question is about @this.screenTexture@? Did you test somehow this code with the webgl texture? The idea is re... Sergey Ivanovskiy

06:42 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> It seems that with your changes this code
> returns 13 elements but these code expect th... Hynek Cihlar

06:24 PM Support #4955: web client/javascript drawing - fast vs crisp

It seems that with your changes this code... Sergey Ivanovskiy

05:43 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I am confused now what you are planning to change and waiting for your commit.
See 382... Hynek Cihlar

04:33 PM Support #4955: web client/javascript drawing - fast vs crisp

For me using rectangles looks reasonable. Any case this code should be consistent with the rectangles format... Sergey Ivanovskiy

04:19 PM Support #4955: web client/javascript drawing - fast vs crisp

OK. Are you planning to commit these changes? Did you test drawing images with textures?... Sergey Ivanovskiy

03:20 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey, @WebGLCanvasRenderer.rectangles@ must hold triangles, but currently it is assumed it contains rectangles in @... Hynek Cihlar

10:27 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Sergey, in order to have the working ... Hynek Cihlar

10:26 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey, in order to have the working prototype one of us should ... Hynek Cihlar

10:24 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey, in order to have the working prototype one of us should focus on integrating what we a... Sergey Ivanovskiy

10:05 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey, in order to have the working prototype one of us should focus on integrating what we already have and make it... Hynek Cihlar

10/26/2020

06:55 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> The committed rev 11751 (3821c) cleaned the previous changes.
11749 up to 11751 look g... Hynek Cihlar

06:20 PM Support #4955: web client/javascript drawing - fast vs crisp

The committed rev 11751 (3821c) cleaned the previous changes. Sergey Ivanovskiy

05:56 PM Support #4955: web client/javascript drawing - fast vs crisp

Please review these changes revision 11749 (3821c).
Sergey Ivanovskiy

04:43 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> If it is OK, then I will apply it to p2j.canvas_renderer_webgl.js.
Yes, this has been ... Hynek Cihlar

04:36 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, please look at the rev 11746 (3821c) where a vertex and its color are packed into one buffer... Sergey Ivanovskiy

03:14 PM Support #4955: web client/javascript drawing - fast vs crisp

It seems that we need to pack data in the buffer similarly to https://developer.mozilla.org/en-US/docs/Web/API/WebGLR... Sergey Ivanovskiy

12:34 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Yes, uniform variables are used for batch of drawing operations. In this case the vertex ... Hynek Cihlar

11:16 AM Support #4955: web client/javascript drawing - fast vs crisp

Yes, uniform variables are used for batch of drawing operations. In this case the vertex color should be passed in as... Sergey Ivanovskiy

09:52 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I would like to add translations... Hynek Cihlar

09:48 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I would like to add translations to the vertex shader according ... Sergey Ivanovskiy

08:42 AM Support #4955: web client/javascript drawing - fast vs crisp

I checked in WebGL version of a strokes manager in 3821c, mostly empty at this time. Hynek Cihlar

08:39 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I would like to add translations to the vertex shader according to https://webglfundament... Hynek Cihlar

08:21 AM Support #4955: web client/javascript drawing - fast vs crisp

I would like to add translations to the vertex shader according to https://webglfundamentals.org/webgl/lessons/webgl-... Sergey Ivanovskiy

04:07 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I would like that the vertex sha... Sergey Ivanovskiy

10/25/2020

01:25 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I would like that the vertex shader converts the original vertex... Sergey Ivanovskiy

03:37 AM Support #4955: web client/javascript drawing - fast vs crisp

Yes, sadly. This WebGL @gl.enable(cap);@ doesn't support @GL_PROGRAM_POINT_SIZE@ that is defined with OpenGL. I could... Sergey Ivanovskiy

10/23/2020

04:32 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Another way to use the vertex shader is to change the point size for the styled line via ... Hynek Cihlar

04:28 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Can this operation substitute a clipping rectangle? https://developer.mozilla.org/en-US/d... Hynek Cihlar

04:25 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I would like that the vertex shader converts the original vertex coordinates to its clipp... Hynek Cihlar

03:21 PM Support #4955: web client/javascript drawing - fast vs crisp

Another way to use the vertex shader is to change the point size for the styled line via @gl_PointSize@. Please look ... Sergey Ivanovskiy

03:16 PM Support #4955: web client/javascript drawing - fast vs crisp

Can this operation substitute a clipping rectangle? https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingCo... Sergey Ivanovskiy

03:09 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> > Are you planning to use Interface Blocks to communicate data between shaders? This is an exa... Sergey Ivanovskiy

11:49 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I don't know how to implement @x... Hynek Cihlar

11:31 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I don't know how to implement @xor@ operations for images and to... Sergey Ivanovskiy

10/22/2020

05:18 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> I don't know how to implement @xor@ operations for images and to draw styled lines.
Fo... Hynek Cihlar

04:05 PM Support #4955: web client/javascript drawing - fast vs crisp

OK. It would be helpful to list demos or docs from public webgl resources which solved one of these tasks. For an exa... Sergey Ivanovskiy

03:14 PM Support #4955: web client/javascript drawing - fast vs crisp

Sergey I checked in WebGL canvas renderer (@p2j.canvas_renderer_webgl.js@) in 3821c revision 11737. I added TODOs in ... Hynek Cihlar

12:43 PM Support #4955: web client/javascript drawing - fast vs crisp

I tested rev.11735 (3821c) webgl test page within Hotel_GUI on Mac mini (OS Catalina v 10.15.6, Safari 14.0). If 2d c... Sergey Ivanovskiy

04:10 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> Hynek, I don't know at this moment how to implement clipping functionality with WebGL. Sh... Hynek Cihlar

10/21/2020

04:37 PM Support #4955: web client/javascript drawing - fast vs crisp

Translations can be done at the vertex shader as it is shown https://webglfundamentals.org/webgl/lessons/webgl-2d-tra... Sergey Ivanovskiy

02:23 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek, I don't know at this moment how to implement clipping functionality with WebGL. Should it be implemented at th... Sergey Ivanovskiy

01:07 PM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey, I think I have acquired enough of implementation changes for the line drawing support.... Sergey Ivanovskiy

01:06 PM Support #4955: web client/javascript drawing - fast vs crisp

Please review WebGL tests results and compare them with the current FWD 2D (committed rev 11732 (3281c)). On my comp... Sergey Ivanovskiy

11:59 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey, I think I have acquired enough of implementation changes for the line drawing support. I'd like to start to i... Hynek Cihlar

07:10 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> I wasn't sure how to draw all the UI elements with images in one draw pass in WebGL. Perhaps t... Greg Shah

06:26 AM Support #4955: web client/javascript drawing - fast vs crisp

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the idea with two canvases that one of them has we... Sergey Ivanovskiy

05:29 AM Support #4955: web client/javascript drawing - fast vs crisp

I wasn't sure how to draw all the UI elements with images in one draw pass in WebGL. Perhaps the following scheme cou... Hynek Cihlar

03:57 AM Support #4955: web client/javascript drawing - fast vs crisp

Sergey Ivanovskiy wrote:
> It seems that the idea with two canvases that one of them has webgl context and the other... Hynek Cihlar

10/20/2020

02:19 PM Support #4955: web client/javascript drawing - fast vs crisp

It seems that the idea with two canvases that one of them has webgl context and the other has 2d context shouldn't wo... Sergey Ivanovskiy