Project

General

Profile

Activity

From 01/06/2022 to 02/04/2022

02/04/2022

02:34 PM Bug #5118: TREELIST widget issues
Vladimir Tsichevski wrote:
> New issue related to #5118-61.
These and #5118-61 must be fixed in 3821c rev. 13480.
Vladimir Tsichevski
01:00 PM Bug #5118: TREELIST widget issues
New issue related to #5118-61.
Current management of *node colors* is incorrect in @TREELIST@. It must match that ...
Vladimir Tsichevski
01:08 PM Bug #6038: ComboBox setScreenValue improvements
Hynek: Merge this to 3821c if you are OK with the final version.
Marian: Is there anything remaining in this task?
Greg Shah
12:55 PM Bug #6038: ComboBox setScreenValue improvements
Attached the patch with changes as per Hynek's review.
Hynek Cihlar wrote:
> In CBW.validateScreenValue there is ...
Marian Edu
12:34 PM Bug #6038: ComboBox setScreenValue improvements
Marian Edu wrote:
> Hynek Cihlar wrote:
> > Perhaps I'm not interpreting the code directly. This is the flow I see....
Hynek Cihlar
12:29 PM Bug #6038: ComboBox setScreenValue improvements
Hynek Cihlar wrote:

> It is OK to mutate the argument in @validateScreenValue@ I think. My point was not to leak ...
Marian Edu
12:23 PM Bug #6038: ComboBox setScreenValue improvements
Marian Edu wrote:
> Hynek Cihlar wrote:
> > Code review 6038-20220204.patch.
> >And also make sure to always pas...
Hynek Cihlar
12:05 PM Bug #6038: ComboBox setScreenValue improvements
Hynek Cihlar wrote:
> Code review 6038-20220204.patch.
>
> @validateScreenValue@, the method javadoc is a bit mis...
Marian Edu
11:46 AM Bug #6038: ComboBox setScreenValue improvements
Code review 6038-20220204.patch.
@validateScreenValue@, the method javadoc is a bit misleading. It suggests SCREEN...
Hynek Cihlar
07:25 AM Bug #6038: ComboBox setScreenValue improvements
Hynek: Please review.
Marian: Let us know if the ChUI testing shows any issues.
Greg Shah
07:19 AM Bug #6038: ComboBox setScreenValue improvements
Fixes for ComboBox/Radioset that re-uses the basic value validation from base class @ControlSetEntity@ and extend as ... Marian Edu
01:06 PM Bug #6016: Selection list setScreenValue improvements
Or would it be better just to place that condition within @validateScreenValue@, as it was before? Roger Borrello
01:03 PM Bug #6016: Selection list setScreenValue improvements
In @ControlSetEntity.setScreenValue@, we've lost the ability to prevent the error message from being displayed in the... Roger Borrello

02/03/2022

02:40 PM Bug #6042: Nested frame must not be made visible when empty and DISPLAY/ENABLE executed on the pa...
... Hynek Cihlar
02:35 PM Bug #6042 (Closed): Nested frame must not be made visible when empty and DISPLAY/ENABLE executed ...
Hynek Cihlar
06:19 AM Bug #6038 (Feedback): ComboBox setScreenValue improvements
Marian Edu
06:19 AM Bug #6016: Selection list setScreenValue improvements
Igor Skornyakov wrote:
> Please note that the problem described in #5983-15 still exists with this revision.
Yes, t...
Marian Edu
05:14 AM Bug #6016: Selection list setScreenValue improvements
Hynek Cihlar wrote:
> Sounds good. I checked 6016-20220202.patch in 3821c revision 13476.
Please note that the prob...
Igor Skornyakov
04:17 AM Bug #6016: Selection list setScreenValue improvements
Marian Edu wrote:
> This works, no complain at run-time and get screen-value for @SECOND@ returns @S,D@, however whe...
Hynek Cihlar
02:02 AM Bug #6016: Selection list setScreenValue improvements
Hynek Cihlar wrote:
> Marian, does it mean the other affected widgets, BROWSE-COLUMNS, COMBO-BOX and RADIO-SET, can'...
Marian Edu

02/02/2022

10:10 AM Bug #6016: Selection list setScreenValue improvements
Marian Edu wrote:
> Greg Shah wrote:
> > > I've pushed 3821c rev 13469 to xfer.
>
> Thanks, attached the patch t...
Hynek Cihlar
09:47 AM Bug #6016: Selection list setScreenValue improvements
Greg Shah wrote:
> > I've pushed 3821c rev 13469 to xfer.
Thanks, attached the patch to fix the regression on com...
Marian Edu
08:19 AM Bug #6016: Selection list setScreenValue improvements
> I've pushed 3821c rev 13469 to xfer. Greg Shah
08:12 AM Bug #6016: Selection list setScreenValue improvements
Greg Shah wrote:
> A separate task makes sense.
Will do that, however the changes did introduce some regression f...
Marian Edu
07:17 AM Bug #6016 (Closed): Selection list setScreenValue improvements
A separate task makes sense. Greg Shah
07:01 AM Bug #6016: Selection list setScreenValue improvements
Greg Shah wrote:
> I've pushed 3821c rev 13469 to xfer.
>
> What is left open in this task? Please set the % Don...
Marian Edu
06:50 AM Bug #6016: Selection list setScreenValue improvements
I've pushed 3821c rev 13469 to xfer.
What is left open in this task? Please set the % Done.
Greg Shah
04:39 AM Bug #6016: Selection list setScreenValue improvements
Marian Edu wrote:
> Hynek Cihlar wrote:
> > The patch is good. Just one minor thing. When @SLW.setScreenValue@ asse...
Hynek Cihlar
02:06 AM Bug #6016: Selection list setScreenValue improvements
Hynek Cihlar wrote:
> The patch is good. Just one minor thing. When @SLW.setScreenValue@ assembles the new value it ...
Marian Edu

02/01/2022

04:27 PM Bug #6016: Selection list setScreenValue improvements
Marian Edu wrote:
> Attached the patch that fixes some issues we've found when setting the @screen-value@ for select...
Hynek Cihlar
11:29 AM Bug #6016: Selection list setScreenValue improvements
Hynek: Please review the patch and merge it into 3821c if you have no objections. Greg Shah
09:38 AM Bug #6016: Selection list setScreenValue improvements
Attached the patch that fixes some issues we've found when setting the @screen-value@ for selection-list. There are s... Marian Edu
10:21 AM Bug #6028: Define rectangle widget: triggers section is not converted and other issues
Greg Shah wrote:
> BTW, I think if you used regular triggers (@ON event OF rectangle-widget...@) then it would work....
Vladimir Tsichevski

01/31/2022

04:27 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues
We will defer work on this for now. Greg Shah
04:27 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues
BTW, I think if you used regular triggers (@ON event OF rectangle-widget...@) then it would work. Most projects we h... Greg Shah
03:52 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues
Rectangle rendering/positioning issues, demonstrated by the test app:
# In OE there is a *5-pixels wide gap* betwe...
Vladimir Tsichevski
03:44 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues
Main issue: @TRIGGERS:@ section in @DEFINE RECTANGLE@ statement is not converted: no triggers in converted Java progr... Vladimir Tsichevski
03:36 PM Bug #6028 (New): Define rectangle widget: triggers section is not converted and other issues
Vladimir Tsichevski
08:43 AM Bug #6026: line drawing issue in WebGL renderer
This was originally found in #5285. The details are being moved here since it is a generic issue.
The problem can...
Greg Shah
08:41 AM Bug #6026 (New): line drawing issue in WebGL renderer
Greg Shah
03:21 AM Bug #6016: Selection list setScreenValue improvements
Hynek Cihlar wrote:
> The idea is to keep the client a generic and thin presentation logic. All the application logi...
Marian Edu

01/28/2022

11:45 AM Bug #6016: Selection list setScreenValue improvements
Marian Edu wrote:
> Hynek Cihlar wrote:
> > Can't you just read the widget's screen value on the server before new ...
Hynek Cihlar
08:05 AM Bug #6016: Selection list setScreenValue improvements
Hynek Cihlar wrote:
> Can't you just read the widget's screen value on the server before new one is set and merge it...
Marian Edu
07:37 AM Bug #6016: Selection list setScreenValue improvements
Greg Shah wrote:
> From Marian:
>
> Setting @SCREEN-VALUE@ for a selection list was improved by Adrian as part of...
Hynek Cihlar
05:48 AM Bug #6016: Selection list setScreenValue improvements
From Marian:
Setting @SCREEN-VALUE@ for a selection list was improved by Adrian as part of #5992, however validati...
Greg Shah
03:28 AM Bug #6016 (Closed): Selection list setScreenValue improvements
Marian Edu

01/27/2022

11:51 AM Bug #5533: Fix artifacts in COMBO-BOX drop down
Greg Shah wrote:
> Was this only in the WebGL renderer?
Yes.
> Is this the same issue as #5285?
No, that o...
Hynek Cihlar
10:30 AM Bug #5533: Fix artifacts in COMBO-BOX drop down
Was this only in the WebGL renderer?
Is this the same issue as #5285?
Greg Shah

01/24/2022

02:34 PM Bug #6006: JVM process failures while executing the swing client
It is my understanding that these failures have occurred sporadically while running a customer's converted GUI applic... Greg Shah
02:15 PM Bug #6006: JVM process failures while executing the swing client
Added logs for the observed JVM crashes. Sergey Ivanovskiy
02:10 PM Bug #6006 (New): JVM process failures while executing the swing client
Sergey Ivanovskiy

01/20/2022

08:22 AM Bug #5989: MESSAGE SET: empty string is treated as undefined
Greg Shah wrote:
> I don't think that is needed. We already have useful discussion here that is best to stay togeth...
Vladimir Tsichevski
08:01 AM Bug #5989: MESSAGE SET: empty string is treated as undefined
I don't think that is needed. We already have useful discussion here that is best to stay together with the future w... Greg Shah
07:35 AM Bug #5989: MESSAGE SET: empty string is treated as undefined
Greg Shah wrote:
> Code Review 5989-2.diff
>
> We must not make changes to return unknown value from that method....
Vladimir Tsichevski
06:57 AM Bug #5989: MESSAGE SET: empty string is treated as undefined
Code Review 5989-2.diff
We must not make changes to return unknown value from that method. The contract of that m...
Greg Shah
06:49 AM Bug #5989: MESSAGE SET: empty string is treated as undefined
Code Review Task Branch 3821c Revision 13419
We should have an API in @BaseDataType@ to assign the default value w...
Greg Shah

01/19/2022

06:23 PM Bug #5989: MESSAGE SET: empty string is treated as undefined
Vladimir Tsichevski wrote:
> Also: the value visible in the fill-in for @MESSAGE SET@ statement differs from that in...
Vladimir Tsichevski
06:16 PM Bug #5989: MESSAGE SET: empty string is treated as undefined
The original issue fixed in 3821c rev. 13419. Please, review. Vladimir Tsichevski
02:36 PM Bug #5989 (WIP): MESSAGE SET: empty string is treated as undefined
Also: the value visible in the fill-in for @MESSAGE SET@ statement differs from that in FWD for logical and number va... Vladimir Tsichevski

01/18/2022

03:11 PM Bug #5989: MESSAGE SET: empty string is treated as undefined
Run the following code:... Vladimir Tsichevski
03:08 PM Bug #5989 (WIP): MESSAGE SET: empty string is treated as undefined
Vladimir Tsichevski

01/14/2022

06:34 AM Bug #4993: Overlay prevents input when modal dialog open in embedded mode in Chrome
Code Review Task Branch 3821c Revision 13362
No objections.
Hynek/Sergey: Please review.
Greg Shah
06:05 AM Bug #5971: The correct order of ENTRY/LEAVE, ROW-ENTRY/ROW-LEAVE, VALUE-CHANGED generated for INS...
Please see @demo/test-issue-5528-9.p@ in @testcases@ project and #5528-186. Sergey Ivanovskiy
06:01 AM Bug #5971 (New): The correct order of ENTRY/LEAVE, ROW-ENTRY/ROW-LEAVE, VALUE-CHANGED generated f...
Sergey Ivanovskiy

01/13/2022

10:57 AM Bug #5150: killing the web page for the web client should raise the equivalent of a window-close ...
We can make this a limitation of the trigger (in the case that the browser window/tab is forcably killed). I don't t... Greg Shah
10:53 AM Bug #5150: killing the web page for the web client should raise the equivalent of a window-close ...
Constantin noted this issue:
> There is a problem if we try executing the @WINDOW-CLOSE@ after the FWD client is n...
Greg Shah

01/12/2022

01:06 PM Bug #5969: Unacceptable keys shouldn't clear selection in fill-in
If a key is not accepted by the current format (?), it should do nothing in 4GL.... Stanislav Lomany
01:00 PM Bug #5969 (New): Unacceptable keys shouldn't clear selection in fill-in
Stanislav Lomany
12:39 PM Bug #5968: Integer field misalignment
# Second integer field in this simple testcase has left alignment.
# Both field labels have wrong alignment (left).
...
Stanislav Lomany
12:32 PM Bug #5968 (New): Integer field misalignment
Stanislav Lomany

01/10/2022

01:54 PM Bug #4993 (Review): Overlay prevents input when modal dialog open in embedded mode in Chrome
Fixed in 3821c/13362.
Constantin Asofiei
01:36 PM Bug #4993: Overlay prevents input when modal dialog open in embedded mode in Chrome
When a combo box drop-down is open it can't be closed by clicking outside of it, one must select an entry or press Es... Constantin Asofiei
01:34 PM Bug #4993 (WIP): Overlay prevents input when modal dialog open in embedded mode in Chrome
Constantin Asofiei
 

Also available in: Atom