FWD » Core Development » User Interface

02/23/2022

02:47 PM Bug #6104: Desktop is fully repainted when a window is moved with WEB driver

Hynek Cihlar wrote:
> Interesting, I don't see this. Are there any extra steps beside creating a window and dragging... Vladimir Tsichevski

01:14 PM Bug #6104: Desktop is fully repainted when a window is moved with WEB driver

Interesting, I don't see this. Are there any extra steps beside creating a window and dragging it? Hynek Cihlar

12:53 PM Bug #6104: Desktop is fully repainted when a window is moved with WEB driver

A problem with desktop repainting when a window is moved with WEB driver. Part of the window is not erased, when the ... Vladimir Tsichevski

12:49 PM Bug #6104 (New): Desktop is fully repainted when a window is moved with WEB driver

Vladimir Tsichevski

02/22/2022

02:01 PM Bug #6087: SPREADSHEET: cell format dialog ignores custom JVM locale

When custom JVM locale is set for the Web GUI client process it is correctly applied by Keikai for user input (for ex... Hynek Cihlar

01:59 PM Bug #6087 (New): SPREADSHEET: cell format dialog ignores custom JVM locale

Hynek Cihlar

12:39 PM Bug #6074: Movable widget problem

Alexandru Lungu wrote:
> Vladimir Tsichevski wrote:
> > I meant extracting to a variable of the @BaseConfig@ type a... Vladimir Tsichevski

10:25 AM Bug #6074: Movable widget problem

Vladimir Tsichevski wrote:
> I meant extracting to a variable of the @BaseConfig@ type at the beginning of the code:... Alexandru Lungu

10:03 AM Bug #6074: Movable widget problem

Alexandru Lungu wrote:
> Vladimir Tsichevski wrote:
> > I would extract the ((BaseConfig) widgetEff.config() expres... Vladimir Tsichevski

08:41 AM Bug #6074: Movable widget problem

Eugenie Lyzenko wrote:
> If the frame is not *selectable* how it can become *selected*?
This was the same reasoni... Alexandru Lungu

08:21 AM Bug #6074: Movable widget problem

The change I am working on in #6013 seems to fix #6074-12 and #6074-14. Vladimir Tsichevski

02/21/2022

03:41 PM Bug #6074: Movable widget problem

Also, after you drag the frame once, you can drag it by a point outside the frame area: by the point left or below of... Vladimir Tsichevski

03:37 PM Bug #6074: Movable widget problem

Vladimir Tsichevski wrote:
> Got NPE while testing @movable-frame.p@ here:
This happens with WEB only.
Vladimir Tsichevski

03:36 PM Bug #6074: Movable widget problem

Got NPE while testing @movable-frame.p@ here:... Vladimir Tsichevski

02:22 PM Bug #6074: Movable widget problem

Greg Shah wrote:
> Vladimir/Eugenie/Hynek: Please review.
The change looks good, and it fixes the original issue.... Vladimir Tsichevski

01:36 PM Bug #6074: Movable widget problem

Code review for @13549@.
Seems OK. But I have a questions.
If the frame is not *selectable* how it can become *... Eugenie Lyzenko

01:01 PM Bug #6074: Movable widget problem

Vladimir/Eugenie/Hynek: Please review. Greg Shah

12:40 PM Bug #6074 (Review): Movable widget problem

3821c/rev. 13461 had some changes regarding selection. If the user presses anywhere in the window, the selected widge... Alexandru Lungu

02/20/2022

04:16 AM Feature #4438: parsing and conversion of .wrx files

Greg Shah wrote:
> > 2. The sources must be currently built with Visual Studio until it is ported in MinGW.
>
> E... Hynek Cihlar

02/19/2022

10:28 AM Feature #4438: parsing and conversion of .wrx files

> 2. The sources must be currently built with Visual Studio until it is ported in MinGW.
Eugenie can help with thi... Greg Shah

02/18/2022

03:11 PM Feature #4438: parsing and conversion of .wrx files

The initial version of Wrx parser is finished. I can already use it to unblock some of the related issues.
The remai... Hynek Cihlar

02/17/2022

02:25 PM Bug #6077: Movable widget problem, when using both mouse buttons

Run the test example from #6074:
# drag frame with left mouse button, do *not* release the button
# while left bu... Vladimir Tsichevski

02:13 PM Bug #6077 (New): Movable widget problem, when using both mouse buttons

Vladimir Tsichevski

11:41 AM Bug #6074: Movable widget problem

This problem is a regression after the change 13461.
Alexandru, take a look, please.
I've tried your example @m... Vladimir Tsichevski

09:37 AM Bug #6076: Help text is not reset when a widget with no help text gains the focus.

Testcase:... Stanislav Lomany

09:34 AM Bug #6076 (New): Help text is not reset when a widget with no help text gains the focus.

Stanislav Lomany

02/16/2022

02:47 PM Feature #4438: parsing and conversion of .wrx files

Hynek Cihlar wrote:
> Some of the OCXes require a license key otherwise they fail to instantiate. I found out the li... Hynek Cihlar

02:34 PM Feature #4438: parsing and conversion of .wrx files

Some of the OCXes require a license key otherwise they fail to instantiate. I found out the license key is part of th... Hynek Cihlar

02:39 PM Bug #6074 (WIP): Movable widget problem

Vladimir Tsichevski

02:38 PM Bug #6074: Movable widget problem

The following example defines a movable frame. Users can drag this frame with left mouse button withing the window.
... Vladimir Tsichevski

02:37 PM Bug #6074 (Closed): Movable widget problem

Vladimir Tsichevski

12:14 PM Bug #6073: Improve FRAME:SCROLL option support

Currently, only @SCROLL = 1@ is supported. We need to add proper support for @SCROLL > 1 && SCROLL < DOWN@. This shou... Stanislav Lomany

11:46 AM Bug #6073 (New): Improve FRAME:SCROLL option support

Stanislav Lomany

07:03 AM Bug #6057 (WIP): Attributes access causing widget to be realized when not need to.

I agree we need proper tests and need to know the full scope of behavior before implementing the full fix. Go ahead ... Greg Shah

06:23 AM Bug #6057 (Feedback): Attributes access causing widget to be realized when not need to.

Greg,
since we had to revert changes on @realized@/@wasRealized@ - because accessing some of those attributes were... Marian Edu

02/15/2022

10:45 AM Feature #4438: parsing and conversion of .wrx files

It all looks good. Greg Shah

08:44 AM Feature #4438: parsing and conversion of .wrx files

Greg Shah wrote:
> That is huge! It will be a big step ahead since we will be able capture the output for all @.wrx... Hynek Cihlar

07:15 AM Feature #4438: parsing and conversion of .wrx files

That is huge! It will be a big step ahead since we will be able capture the output for all @.wrx@ files up front.
... Greg Shah

06:18 AM Feature #4438: parsing and conversion of .wrx files

I can report a success in parsing OCX properties for PSTimer. I successfully read the Interval and Enabled properties... Hynek Cihlar

02/12/2022

07:28 AM Bug #6057: Attributes access causing widget to be realized when not need to.

Roger Borrello wrote:
> Is this the kind of update you are envisioning? It is successful in my customer's app.
>
... Marian Edu

07:08 PM Bug #6057: Attributes access causing widget to be realized when not need to.

Is this the kind of update you are envisioning? It is successful in my customer's app.... Roger Borrello

02/11/2022

05:51 PM Bug #6057: Attributes access causing widget to be realized when not need to.

Marian Edu wrote:
> The use of the @canAccess@ guard should be reviewed and fix cases where widget realization is no... Roger Borrello

02/10/2022

08:50 AM Bug #6057: Attributes access causing widget to be realized when not need to.

Some widget attributes require the widget to be realized else an error will be thrown (in fact a set of three). The m... Marian Edu

08:44 AM Bug #6057 (WIP): Attributes access causing widget to be realized when not need to.

Marian Edu

08:39 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Which converts to:
> [...]
Good catch, the 4GL snippet is probably not the right one but... Marian Edu

08:20 AM Bug #6038: ComboBox setScreenValue improvements

This is in the constructor of @GenericWidget@:... Roger Borrello

08:18 AM Bug #6038: ComboBox setScreenValue improvements

One more thing to note. I had a breakpoint in @GenericWidget.realize@:... Roger Borrello

02:53 AM Bug #6038: ComboBox setScreenValue improvements

Roger, thanks for debugging this - the fact that setting the widget visibility to true marks it as 'realized' is ok. ... Marian Edu

02/09/2022

03:55 PM Bug #6038: ComboBox setScreenValue improvements

I was able to debug the client, breaking in @AbstractWidget._setVisible@:... Roger Borrello

12:49 PM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Roger Borrello wrote:
> > The error message comes right after I make the menu choice to run... Roger Borrello

12:40 PM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> The error message comes right after I make the menu choice to run the program, and before I ... Roger Borrello

12:32 PM Bug #6038: ComboBox setScreenValue improvements

The error message comes right after I make the menu choice to run the program, and before I hit:... Roger Borrello

12:30 PM Bug #6038: ComboBox setScreenValue improvements

There is this:... Roger Borrello

12:27 PM Bug #6038: ComboBox setScreenValue improvements

Regarding what might be going on with setting the @SCROLLBAR-HORIZONTAL@ attribute of a @SELECTION-LIST@ after the fr... Roger Borrello

11:40 AM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Roger Borrello wrote:
> > Likewise I am getting @** Attribute SCREEN-VALUE for the COMBO-BOX xx... Roger Borrello

10:21 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> I notice the @ComboBoxConfig.format@ is 2 exclamations marks: @!!@. I am not familiar with t... Marian Edu

10:14 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Likewise I am getting @** Attribute SCREEN-VALUE for the COMBO-BOX xxx has an invalid value ... Marian Edu

10:12 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Roger Borrello wrote:
> > Using 13497 on my customer's application, and now receiving 4053 ... Roger Borrello

10:11 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Using 13497 on my customer's application, and now receiving 4053 error: @Unable to set SCROL... Marian Edu

10:09 AM Bug #6038: ComboBox setScreenValue improvements

Roger Borrello wrote:
> Using 13497 on my customer's application, and now receiving 4053 error: @Unable to set SCROL... Roger Borrello

09:40 AM Bug #6038: ComboBox setScreenValue improvements

Using 13497 on my customer's application, and now receiving 4053 error: @Unable to set SCROLLBAR-HORIZONTAL because t... Roger Borrello

09:01 AM Bug #6038: ComboBox setScreenValue improvements

I did a couple of cosmetic changes to 6038-20220209.patch and checked it in 3821c revision 13497. Hynek Cihlar

08:56 AM Bug #6038: ComboBox setScreenValue improvements

Hynek Cihlar wrote:
> Marian Edu wrote:
> > Marian Edu wrote:
> > Attached the patch for combo-box so the trailing... Hynek Cihlar

08:53 AM Bug #6038: ComboBox setScreenValue improvements

Hynek Cihlar wrote:
> In @ComboBoxWidget@ @setLabel@ was called only when value type differed from the combo-box typ... Marian Edu

08:44 AM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Marian Edu wrote:
> Attached the patch for combo-box so the trailing spaces from value are remo... Hynek Cihlar

07:16 AM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Testing this in 4GL only for combo-box the values are trimmed but only at the end, the @list-ite... Marian Edu

02/08/2022

02:34 PM Bug #6038: ComboBox setScreenValue improvements

Testing this in 4GL only for combo-box the values are trimmed but only at the end, the @list-items@/@list-item-pairs@... Marian Edu

02:14 PM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Eugenie Lyzenko wrote:
> > How about this change in @GenericFrame.java@?
> I've started with @... Eugenie Lyzenko

01:51 PM Bug #6038: ComboBox setScreenValue improvements

Eugenie Lyzenko wrote:
> How about this change in @GenericFrame.java@?
I've started with @GenericFrame@ before but ... Marian Edu

01:45 PM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Eugenie Lyzenko wrote:
> > Marian,
> >
> > Please see #5991.
> >
> > We have severe regre... Eugenie Lyzenko

01:26 PM Bug #6038: ComboBox setScreenValue improvements

Eugenie Lyzenko wrote:
> Marian,
>
> Please see #5991.
>
> We have severe regression from recent combo-box cha... Marian Edu

12:22 PM Bug #6038: ComboBox setScreenValue improvements

With respect to #6044, the fixes in 13481 corrected the problem which exist with 13481. However, the fixes in 13481 ... Roger Borrello

12:16 PM Bug #6038: ComboBox setScreenValue improvements

Marian,
Please see #5991.
We have severe regression from recent combo-box changes for @(set/get)ScreenValue@. P... Eugenie Lyzenko

11:46 AM Bug #6038: ComboBox setScreenValue improvements

Greg Shah wrote:
> Marian: We are backing out the latest 3821c in the customer test environment for both #5881 and #... Marian Edu

10:19 AM Bug #6038: ComboBox setScreenValue improvements

Marian: We are backing out the latest 3821c in the customer test environment for both #5881 and #6044. Please let us... Greg Shah

05:09 AM Bug #6038: ComboBox setScreenValue improvements

OK, as per our tests so far it looks like the validation doesn't have anything to do with the fact that the widget's ... Marian Edu

09:05 AM Bug #6053: Widget realisation

Yes, please do. Greg Shah

09:02 AM Bug #6053: Widget realisation

The widget 'realisation' is somehow inconsistent in FWD, there are two attributes in widget configuration with a big ... Marian Edu

08:52 AM Bug #6053 (Review): Widget realisation

Marian Edu

02:27 AM Bug #6042: Nested frame must not be made visible when empty and DISPLAY/ENABLE executed on the pa...

Hynek Cihlar wrote:
> [...]
Hynek, I could have sworn I've saw that happening but running the code in 4GL doesn't... Marian Edu

02/07/2022

09:36 AM Bug #6038: ComboBox setScreenValue improvements

Greg Shah wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > > The changes in 6038-20220204.02.patch are ... Eugenie Lyzenko

09:17 AM Bug #6038: ComboBox setScreenValue improvements

Agreed. Greg Shah

09:11 AM Bug #6038: ComboBox setScreenValue improvements

Greg Shah wrote:
> Marian: Is there anything remaining to do in this task?
I've wrote 4GL tests (static/dynamic... Marian Edu

09:07 AM Bug #6038: ComboBox setScreenValue improvements

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > The changes in 6038-20220204.02.patch are good. Checked them in 38... Greg Shah

09:34 AM Bug #6016: Selection list setScreenValue improvements

Roger Borrello wrote:
> Roger Borrello wrote:
> > In @ControlSetEntity.setScreenValue@, we've lost the ability to p... Roger Borrello

09:03 AM Bug #6016: Selection list setScreenValue improvements

Roger Borrello wrote:
> In @ControlSetEntity.setScreenValue@, we've lost the ability to prevent the error message fr... Roger Borrello

02/06/2022

08:29 AM Bug #6038: ComboBox setScreenValue improvements

Hynek Cihlar wrote:
> The changes in 6038-20220204.02.patch are good. Checked them in 3821c revision 13481.
It ha... Eugenie Lyzenko

02/05/2022

11:32 AM Bug #6038: ComboBox setScreenValue improvements

The changes in 6038-20220204.02.patch are good. Checked them in 3821c revision 13481. Hynek Cihlar

02/04/2022

02:34 PM Bug #5118: TREELIST widget issues

Vladimir Tsichevski wrote:
> New issue related to #5118-61.
These and #5118-61 must be fixed in 3821c rev. 13480.
Vladimir Tsichevski

01:00 PM Bug #5118: TREELIST widget issues

New issue related to #5118-61.
Current management of *node colors* is incorrect in @TREELIST@. It must match that ... Vladimir Tsichevski

01:08 PM Bug #6038: ComboBox setScreenValue improvements

Hynek: Merge this to 3821c if you are OK with the final version.
Marian: Is there anything remaining in this task? Greg Shah

12:55 PM Bug #6038: ComboBox setScreenValue improvements

Attached the patch with changes as per Hynek's review.
Hynek Cihlar wrote:
> In CBW.validateScreenValue there is ... Marian Edu

12:34 PM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Hynek Cihlar wrote:
> > Perhaps I'm not interpreting the code directly. This is the flow I see.... Hynek Cihlar

12:29 PM Bug #6038: ComboBox setScreenValue improvements

Hynek Cihlar wrote:

> It is OK to mutate the argument in @validateScreenValue@ I think. My point was not to leak ... Marian Edu

12:23 PM Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Hynek Cihlar wrote:
> > Code review 6038-20220204.patch.
> >And also make sure to always pas... Hynek Cihlar

12:05 PM Bug #6038: ComboBox setScreenValue improvements

Hynek Cihlar wrote:
> Code review 6038-20220204.patch.
>
> @validateScreenValue@, the method javadoc is a bit mis... Marian Edu

11:46 AM Bug #6038: ComboBox setScreenValue improvements

Code review 6038-20220204.patch.
@validateScreenValue@, the method javadoc is a bit misleading. It suggests SCREEN... Hynek Cihlar

07:25 AM Bug #6038: ComboBox setScreenValue improvements

Hynek: Please review.
Marian: Let us know if the ChUI testing shows any issues. Greg Shah

07:19 AM Bug #6038: ComboBox setScreenValue improvements

Fixes for ComboBox/Radioset that re-uses the basic value validation from base class @ControlSetEntity@ and extend as ... Marian Edu

01:06 PM Bug #6016: Selection list setScreenValue improvements

Or would it be better just to place that condition within @validateScreenValue@, as it was before? Roger Borrello

01:03 PM Bug #6016: Selection list setScreenValue improvements

In @ControlSetEntity.setScreenValue@, we've lost the ability to prevent the error message from being displayed in the... Roger Borrello

02/03/2022

02:40 PM Bug #6042: Nested frame must not be made visible when empty and DISPLAY/ENABLE executed on the pa...

... Hynek Cihlar

02:35 PM Bug #6042 (Closed): Nested frame must not be made visible when empty and DISPLAY/ENABLE executed ...

Hynek Cihlar

06:19 AM Bug #6038 (Feedback): ComboBox setScreenValue improvements

Marian Edu

06:19 AM Bug #6016: Selection list setScreenValue improvements

Igor Skornyakov wrote:
> Please note that the problem described in #5983-15 still exists with this revision.
Yes, t... Marian Edu

05:14 AM Bug #6016: Selection list setScreenValue improvements

Hynek Cihlar wrote:
> Sounds good. I checked 6016-20220202.patch in 3821c revision 13476.
Please note that the prob... Igor Skornyakov

04:17 AM Bug #6016: Selection list setScreenValue improvements

Marian Edu wrote:
> This works, no complain at run-time and get screen-value for @SECOND@ returns @S,D@, however whe... Hynek Cihlar

02:02 AM Bug #6016: Selection list setScreenValue improvements

Hynek Cihlar wrote:
> Marian, does it mean the other affected widgets, BROWSE-COLUMNS, COMBO-BOX and RADIO-SET, can'... Marian Edu

02/02/2022

10:10 AM Bug #6016: Selection list setScreenValue improvements

Marian Edu wrote:
> Greg Shah wrote:
> > > I've pushed 3821c rev 13469 to xfer.
>
> Thanks, attached the patch t... Hynek Cihlar

09:47 AM Bug #6016: Selection list setScreenValue improvements

Greg Shah wrote:
> > I've pushed 3821c rev 13469 to xfer.
Thanks, attached the patch to fix the regression on com... Marian Edu

08:19 AM Bug #6016: Selection list setScreenValue improvements

> I've pushed 3821c rev 13469 to xfer. Greg Shah

08:12 AM Bug #6016: Selection list setScreenValue improvements

Greg Shah wrote:
> A separate task makes sense.
Will do that, however the changes did introduce some regression f... Marian Edu

07:17 AM Bug #6016 (Closed): Selection list setScreenValue improvements

A separate task makes sense. Greg Shah

07:01 AM Bug #6016: Selection list setScreenValue improvements

Greg Shah wrote:
> I've pushed 3821c rev 13469 to xfer.
>
> What is left open in this task? Please set the % Don... Marian Edu

06:50 AM Bug #6016: Selection list setScreenValue improvements

I've pushed 3821c rev 13469 to xfer.
What is left open in this task? Please set the % Done. Greg Shah

04:39 AM Bug #6016: Selection list setScreenValue improvements

Marian Edu wrote:
> Hynek Cihlar wrote:
> > The patch is good. Just one minor thing. When @SLW.setScreenValue@ asse... Hynek Cihlar

02:06 AM Bug #6016: Selection list setScreenValue improvements

Hynek Cihlar wrote:
> The patch is good. Just one minor thing. When @SLW.setScreenValue@ assembles the new value it ... Marian Edu

02/01/2022

04:27 PM Bug #6016: Selection list setScreenValue improvements

Marian Edu wrote:
> Attached the patch that fixes some issues we've found when setting the @screen-value@ for select... Hynek Cihlar

11:29 AM Bug #6016: Selection list setScreenValue improvements

Hynek: Please review the patch and merge it into 3821c if you have no objections. Greg Shah

09:38 AM Bug #6016: Selection list setScreenValue improvements

Attached the patch that fixes some issues we've found when setting the @screen-value@ for selection-list. There are s... Marian Edu

10:21 AM Bug #6028: Define rectangle widget: triggers section is not converted and other issues

Greg Shah wrote:
> BTW, I think if you used regular triggers (@ON event OF rectangle-widget...@) then it would work.... Vladimir Tsichevski

01/31/2022

04:27 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues

We will defer work on this for now. Greg Shah

04:27 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues

BTW, I think if you used regular triggers (@ON event OF rectangle-widget...@) then it would work. Most projects we h... Greg Shah

03:52 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues

Rectangle rendering/positioning issues, demonstrated by the test app:
# In OE there is a *5-pixels wide gap* betwe... Vladimir Tsichevski

03:44 PM Bug #6028: Define rectangle widget: triggers section is not converted and other issues

Main issue: @TRIGGERS:@ section in @DEFINE RECTANGLE@ statement is not converted: no triggers in converted Java progr... Vladimir Tsichevski

03:36 PM Bug #6028 (New): Define rectangle widget: triggers section is not converted and other issues

Vladimir Tsichevski

08:43 AM Bug #6026: line drawing issue in WebGL renderer

This was originally found in #5285. The details are being moved here since it is a generic issue.
The problem can... Greg Shah

08:41 AM Bug #6026 (New): line drawing issue in WebGL renderer

Greg Shah

03:21 AM Bug #6016: Selection list setScreenValue improvements

Hynek Cihlar wrote:
> The idea is to keep the client a generic and thin presentation logic. All the application logi... Marian Edu

01/28/2022

11:45 AM Bug #6016: Selection list setScreenValue improvements

Marian Edu wrote:
> Hynek Cihlar wrote:
> > Can't you just read the widget's screen value on the server before new ... Hynek Cihlar

08:05 AM Bug #6016: Selection list setScreenValue improvements

Hynek Cihlar wrote:
> Can't you just read the widget's screen value on the server before new one is set and merge it... Marian Edu

07:37 AM Bug #6016: Selection list setScreenValue improvements

Greg Shah wrote:
> From Marian:
>
> Setting @SCREEN-VALUE@ for a selection list was improved by Adrian as part of... Hynek Cihlar

05:48 AM Bug #6016: Selection list setScreenValue improvements

From Marian:
Setting @SCREEN-VALUE@ for a selection list was improved by Adrian as part of #5992, however validati... Greg Shah

03:28 AM Bug #6016 (Closed): Selection list setScreenValue improvements

Marian Edu