Activity
From 07/14/2023 to 08/12/2023
08/11/2023
- 10:24 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- Greg Shah wrote:
> Eugenie/Hynek: Please review.
I have no objections. - 09:56 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- Eugenie/Hynek: Please review.
- 09:36 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- Greg Shah wrote:
> Is this task related to an existing customer bug? If so, please link them.
This issue prevent... - 09:27 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- Is this task related to an existing customer bug? If so, please link them.
- 06:46 AM Bug #7674 (Review): FILL-IN for a character variable: cannot delete an unknown value
- Please, review the fix.
- 06:44 AM Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value
- The fix: set the @unknownValueDisplayed@ value in the @StringFormat.CharBuf@ constructor in case an unknown variable ...
- 09:27 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Greg Shah wrote:
> > By #30 do you mean #3931-30?
>
> Nope, #30. This was mentioned by Constant... - 07:46 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> By #30 do you mean #3931-30?
Nope, #30. This was mentioned by Constantin in response to my ema... - 07:44 AM Feature #3931: single sign-on for virtual desktop mode
- By #30 do you mean #3931-30?
- 07:20 AM Feature #3931: single sign-on for virtual desktop mode
- I think #30 can be resolved with #3931. If the customer wants to prevent this type of DOS, they can replace their 4GL...
08/10/2023
- 06:42 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- The boolean @StringFormat:unknownValueDisplayed@ field should handle the situation then no screen buffer is allocated...
- 06:31 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
- @FILL-IN@ for a character variable: if the @screen-value@ is set to an unknown value, the screen value is replaced by...
- 06:28 PM Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value
- 03:45 PM Bug #7673: FILL-IN for a character variable: pressing Shift+Delete inserts a dot
- @FILL-IN@ for a character variable: pressing @Shift+Delete@ inserts a dot character. In OE this key combination perfo...
- 03:43 PM Bug #7673 (New): FILL-IN for a character variable: pressing Shift+Delete inserts a dot
- 08:05 AM Bug #7671: View statement does not work on o not visible frame
- Consider the following scenario, you have a @main-frame@, inside this there is @secondary-frame@ that has @button1@ a...
- 07:54 AM Bug #7671 (New): View statement does not work on o not visible frame
08/09/2023
- 05:47 PM Bug #7515: FILL-IN: editing dates issues
- Yet another issue:
# set @SESSION:DATE-FORMAT = "ymd".@
# create an editor for a date variable with the @9999/99/...
08/08/2023
- 07:35 AM Feature #3931: single sign-on for virtual desktop mode
- OS passwords can't be stored in directory.xml the same way as FWD user passwords. FWD passwords are encrypted with SH...
08/04/2023
- 09:18 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> The fact that you are in a context now and spawn another context is what I am calling "forking". ... - 09:06 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > > That is why we have a complex pipe approach used to deliver the password to the spawner, beca... - 09:02 AM Feature #3931: single sign-on for virtual desktop mode
- > > That is why we have a complex pipe approach used to deliver the password to the spawner, because pipes are privat...
- 09:00 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> The more conditions we add, the more we have to think about how we use it and the more likely a r... - 08:53 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if i... - 08:52 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> That is why we have a complex pipe approach used to deliver the password to the spawner, because ... - 08:48 AM Feature #3931: single sign-on for virtual desktop mode
- In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if it is more obvious th...
- 08:47 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > > The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from a... - 08:43 AM Feature #3931: single sign-on for virtual desktop mode
- > The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ co...
- 08:41 AM Feature #3931: single sign-on for virtual desktop mode
- > > > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface)...
- 05:19 AM Feature #3931: single sign-on for virtual desktop mode
- The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ conf...
- 04:15 AM Feature #3931: single sign-on for virtual desktop mode
- Here are the mockups for the Admin UI: 1. OS users (new page) 2. OS user password update (new dialog), 3. FWD user ed...
- 01:29 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from an ex... - 01:12 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ ne...
08/03/2023
- 04:05 PM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Greg Shah wrote:
> > > > > RPC WebClientLauncher.spawn with SSO
> > What you are proposing is not... - 04:02 PM Feature #3931: single sign-on for virtual desktop mode
- > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface). Ot...
- 03:50 PM Feature #3931: single sign-on for virtual desktop mode
- > 1. @ssopluginoption@ is enough to support a default fwd user.
This is what I suggested previously, so I tend to ... - 10:21 AM Feature #3931: single sign-on for virtual desktop mode
- Can you share client configs for @<security>@ and @<access>@ for a broker running against testcases server?
- 01:43 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > > > RPC WebClientLauncher.spawn with SSO
> What you are proposing is not clear to me. I espec... - 01:38 AM Feature #3931: single sign-on for virtual desktop mode
- I need confirmation that:
1. @ssopluginoption@ is enough to support a default fwd user.
2. @webClient/defaultAccoun... - 12:18 PM Bug #7657: 8-bit character entry problem in ChUI
- As reported by one of our customers:
> I did notice one other thing. It occurs both in the Hotel sample app as wel... - 12:18 PM Bug #7657 (Review): 8-bit character entry problem in ChUI
08/02/2023
- 01:48 PM Feature #3931: single sign-on for virtual desktop mode
- > > > RPC WebClientLauncher.spawn with SSO
> >
> > This still needs to be discussed. We have a customer that orig... - 01:41 PM Feature #3931: single sign-on for virtual desktop mode
- > The @BrokerServerServices@ acl/net config described [[p2j:Remote_Launchers|here]] seems outdated. Does it need to b...
- 09:55 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > RPC WebClientLauncher.spawn with SSO
>
> This still needs to be discussed. We have a custom... - 09:31 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Do we feed the default user explicitly?
Actually my bad, it's already done in the latest revision ... - 09:23 AM Feature #3931: single sign-on for virtual desktop mode
- And here is my conclusion on the other topic:
* @remotelaunchoption@ checks to be executed only for remote spawns (u... - 09:01 AM Feature #3931: single sign-on for virtual desktop mode
- Constantin Asofiei wrote:
> I don't think we should allow FWD to determine a default is required - the SSO authentic... - 08:57 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Greg Shah wrote:
> > I think the answer here is to provide a facility for the authenticator to get... - 08:55 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> I think the answer here is to provide a facility for the authenticator to get some configuration ... - 08:47 AM Feature #3931: single sign-on for virtual desktop mode
- > 1. Do you want a configurable FWD user for when SSO Authenticator (customer) doesn't know what it wants for securit...
- 08:39 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> I would not expect there to be a default os user that is not specified in the directory, but I do... - 08:38 AM Feature #3931: single sign-on for virtual desktop mode
- > @GuestAccess@ has nothing to do with SSO, not a single bit, so let's not get it involved in the discussion. Both au...
- 08:35 AM Feature #3931: single sign-on for virtual desktop mode
- > Do you want a default os user if none is specified in directory?
I would not expect there to be a default os use... - 08:31 AM Feature #3931: single sign-on for virtual desktop mode
- Constantin Asofiei wrote:
> Galya B wrote:
> > Let me just explain it that way: SSO with a default FWD user and a d... - 08:31 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Let me just explain it that way: SSO with a default FWD user and a default OS user is called @Guest... - 08:30 AM Feature #3931: single sign-on for virtual desktop mode
- Let me just explain it that way: SSO with a default FWD user and a default OS user is called @GuestAccess@.
- 08:24 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > Default FWD user for SSO
>
> Are you asking if we still need to support @GuestAccess@ or som... - 08:19 AM Feature #3931: single sign-on for virtual desktop mode
- > RPC WebClientLauncher.spawn with SSO
This still needs to be discussed. We have a customer that originally plann... - 08:15 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> I think this was about securing the entry points (e.g. @client:cmd-line-option:startup-procedure@... - 08:12 AM Feature #3931: single sign-on for virtual desktop mode
- > Since both checks were omitted with VD before, I want to know if it makes sense to enable them for regular VD spawn...
- 08:08 AM Feature #3931: single sign-on for virtual desktop mode
- > > @remotelaunchoption@ I guess is allowing the fwd user to send certain options to the client. Why is it called rem...
- 08:05 AM Feature #3931: single sign-on for virtual desktop mode
- > @trustedspawner@ I guess is allowing the fwd user to spawn a new process without os password.
Correct
> @remo... - 06:06 AM Feature #3931: single sign-on for virtual desktop mode
- Configs for testing:...
- 06:03 AM Feature #3931: single sign-on for virtual desktop mode
- r14659 up, all code review requests addressed.
I'll be waiting for *answers* to my questions and further *code re... - 05:27 AM Feature #3931: single sign-on for virtual desktop mode
- Actually is it possible to determine the fwd user for Virtual Desktop running without SSO? For the connection auth wi...
- 04:55 AM Feature #3931: single sign-on for virtual desktop mode
- SSO Features Support:
|Feature|Planned|
|SSL connection authentication + SSO|❌|
|OS account pools|❌|
|RPC WebCl... - 04:37 AM Feature #3931: single sign-on for virtual desktop mode
- Since both checks were omitted with VD before, I want to know if it makes sense to enable them for regular VD spawn r...
- 04:35 AM Feature #3931: single sign-on for virtual desktop mode
- I have a question about the security checks, that are for the plugins @trustedspawner@ and @remotelaunchoption@: what...
08/01/2023
- 03:28 AM Feature #3931: single sign-on for virtual desktop mode
- I'll soon apply the changes with the latest revision, so when you have time, you can also check the initial refactori...
- 02:28 AM Feature #3931: single sign-on for virtual desktop mode
- Check how @auth-plugins@ works with @GuestAccess@ - something similar can be done for the guest SSO plugin (we should...
- 02:21 AM Feature #3931: single sign-on for virtual desktop mode
- The fwd user attr @<node-attribute name="osuser" value="[os-user]"/>@ can't be replaced by a default. That's how the ...
07/31/2023
- 12:59 PM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> I mean we can still use @bogus@. When I'm done with the work, I'll change it to @bogus@ and will ad... - 12:10 PM Feature #3931: single sign-on for virtual desktop mode
- I mean we can still use @bogus@. When I'm done with the work, I'll change it to @bogus@ and will add @<node-attribute...
- 12:06 PM Feature #3931: single sign-on for virtual desktop mode
- I created the @SsoAuthenticatorSample@ and hardcoded fwd user @newuser@ that can use any os user configured for it.
... - 12:02 PM Feature #3931: single sign-on for virtual desktop mode
- Thanks for the explanation.
Greg, just an idea: it would be helpful for i.e. development mode to have a 'GuestSSOP... - 11:55 AM Feature #3931: single sign-on for virtual desktop mode
- Correct. This will be pure Java and will not have a context.
- 11:52 AM Feature #3931: single sign-on for virtual desktop mode
- Basically we can't have a context before determining the fwd user that is returned by the SSO auth, so it should run ...
- 11:49 AM Feature #3931: single sign-on for virtual desktop mode
- Constantin Asofiei wrote:
> I don't understand; from looking at the code, the default value for @Thread.defaultUncau... - 11:15 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Constantin Asofiei wrote:
> > Review for 3931a rev 14653:
> > * @ClientDriver.main@ - @defaultUnc... - 09:10 AM Feature #3931: single sign-on for virtual desktop mode
- Constantin Asofiei wrote:
> Review for 3931a rev 14653:
> * @ClientDriver.main@ - @defaultUncaughtExceptionHandler@... - 07:13 AM Feature #3931: single sign-on for virtual desktop mode
- Review for 3931a rev 14653:
* @ClientDriver.main@ - @defaultUncaughtExceptionHandler@ can be null
* @SchemaComparat... - 07:20 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents
- Greg Shah wrote:
> Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch... - 07:10 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents
- Greg Shah wrote:
> Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch... - 07:09 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents
- Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch where you are alrea...
- 06:46 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents
- Greg Shah wrote:
> Do we need a task for this? The fix seems trivial.
I think we don't. I can fix this in the tr... - 06:44 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents
- Do we need a task for this? The fix seems trivial.
- 06:28 AM Bug #7646 (WIP): FILL-IN: NPE during the PASTE of non-text clipboard contents
- Scenario:
# there is no *text* contents in system-wide clipboard (for example, the user copied an image to clipboa... - 06:05 AM Bug #7646 (Merge Pending): FILL-IN: NPE during the PASTE of non-text clipboard contents
07/28/2023
- 03:59 PM Bug #7515: FILL-IN: editing dates issues
- Vladimir Tsichevski wrote:
> Yet another issue: normally pressing @?@ (question) should always reset screen value to... - 11:41 AM Bug #7515: FILL-IN: editing dates issues
- **#9855 (FIXED)** Yet another issue:
Test program:... - 02:53 PM Bug #7642: Assigning SESSION:DATE-FORMAT has no effect on existing date instances
- Run this program. Assume the default date format is @mdy@ (as set in @directory.xml@)....
- 02:39 PM Bug #7642 (WIP): Assigning SESSION:DATE-FORMAT has no effect on existing date instances
07/27/2023
- 08:59 AM Bug #7515: FILL-IN: editing dates issues
- **(FIXED)** Yet another issue: normally pressing @?@ (question) should always reset screen value to an empty string.
...
07/25/2023
- 11:21 AM Feature #3931: single sign-on for virtual desktop mode
- Now a question about
> allowed to spawn a new session
The @BrokerServerServices@ acl/net config described [[p2j:R... - 11:11 AM Feature #3931: single sign-on for virtual desktop mode
- The current web flow is:
@WebHandler.spawnWorker@ -> @(Web)ClientSpawner.spawn@ -> [broker for the os user is found]... - 09:45 AM Feature #3931: single sign-on for virtual desktop mode
- By "any authorized context", I mean a context and caller that is allowed to spawn a new session.
- 09:42 AM Feature #3931: single sign-on for virtual desktop mode
- Yes, brokers need to be supported. This is just a spawning mechanism it should not really be core to the concept of ...
- 09:27 AM Feature #3931: single sign-on for virtual desktop mode
- Actually that is not correct. The broker is used just for spawning a separate process, so the connection to the serve...
- 09:12 AM Feature #3931: single sign-on for virtual desktop mode
- Brokers are currently using only certificate authentication before the server and the session is running for the whol...
- 11:13 AM Bug #7515: FILL-IN: editing dates issues
- **ISSUE** Yet another issue: if a just open a date @FILL-IN@, place the cursor at any of the two delimiters and press...
07/24/2023
- 03:31 PM Bug #7515: FILL-IN: editing dates issues
- **ISSUE** Yet another issue:
In OE the @SCREEN-VALUE@ called for an unedited date @FILL-IN@ with unknown variable,... - 09:39 AM Feature #3931: single sign-on for virtual desktop mode
- Just to mention, so that no unexpected surprises are found down the road: "sso hook" is a bit exaggerated for what I'...
- 09:35 AM Feature #3931: single sign-on for virtual desktop mode
- It would be feasible to implement certificate validation + SSO with the customer hook returning the certificate to us...
- 09:22 AM Feature #3931: single sign-on for virtual desktop mode
- With SSO it can't be of type @AUTH_MODE_X509_IDPW@ (except if we don't modify it), because the fwd user is dynamic (c...
- 09:20 AM Feature #3931: single sign-on for virtual desktop mode
- I mean the connection between the FWD client process (with embedded web server) and the FWD server.
- 09:18 AM Feature #3931: single sign-on for virtual desktop mode
- > My question is if it should be an option to enable certificate validation + SSO?
Help me understand how would it... - 02:00 AM Feature #3931: single sign-on for virtual desktop mode
- I didn't notice @AUTH_MODE_X509_IDPW@, @AUTH_MODE_X509_IDPW@ does indeed both validations, but the FWD user is either...
07/21/2023
- 03:07 PM Bug #7633: some trigger issues: PAUSE must not raise a trigger and no PAUSE exists when UPDATE is...
- There is this test:...
- 03:07 PM Bug #7633 (New): some trigger issues: PAUSE must not raise a trigger and no PAUSE exists when UPD...
- 01:00 PM Feature #3931: single sign-on for virtual desktop mode
- > At the moment, as far as I understand the logic, authentication is either certificate check, or fwd users check.
... - 11:06 AM Feature #3931: single sign-on for virtual desktop mode
- What I mean is having certificate should not limit the number of associated fwd users. Isn't it good to have clients ...
- 11:03 AM Feature #3931: single sign-on for virtual desktop mode
- At the moment, as far as I understand the logic, authentication is either certificate check, or fwd users check. If @...
- 10:51 AM Feature #3931: single sign-on for virtual desktop mode
- r14653: @GuestAccess@ reverted. Sso connection authentication is @SecurityManager.authenticateClientWorkerSso@ client...
- 08:55 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> My references above are only discussing web clients. Of course, batch and non-web clients should... - 08:49 AM Feature #3931: single sign-on for virtual desktop mode
- > > > Are we moving all customers using embedded to SSO?
> >
> > Yes.
> Let me verify I understand correctly. C... - 08:46 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> > Are we moving all customers using embedded to SSO?
>
> Yes.
Let me verify I understand co... - 08:46 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> So batch processes will run on that server with SSO? @auth-config/plugin@ defines @GuestAccess@ use... - 08:42 AM Feature #3931: single sign-on for virtual desktop mode
- > Are we moving all customers using embedded to SSO?
Yes. We already have a hacked-up way to do this. With #3770... - 08:40 AM Feature #3931: single sign-on for virtual desktop mode
- So batch processes will run on that server with SSO? @auth-config/plugin@ defines @GuestAccess@ used by batch. Do I r...
- 08:39 AM Feature #3931: single sign-on for virtual desktop mode
- > > * I would expect us to drop usage of @GuestAccess@ in the solution. It is a hack that is not important/is unwant...
- 08:37 AM Feature #3931: single sign-on for virtual desktop mode
- To summarize embedded spawning / launching options:
1. [Old] web request to @/embedded/launch@ runs without knowing ... - 08:30 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> So it is cleaner if we don't have an existing context and instead we should take the passed in ap... - 08:28 AM Feature #3931: single sign-on for virtual desktop mode
- Galya B wrote:
> Actually for rpc calls to @spawn@ thread pool is not used, because security context should be avail... - 08:27 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> It sounds like you are mixing two different authenticator implementations together which may caus... - 08:24 AM Feature #3931: single sign-on for virtual desktop mode
- > Is there any reason why this is not a good solution?
We'll see. I will have to look at the code. It sounds lik... - 08:23 AM Feature #3931: single sign-on for virtual desktop mode
- Actually for rpc calls to @spawn@ thread pool is not used, because security context should be available. The Thread p...
- 08:17 AM Feature #3931: single sign-on for virtual desktop mode
- > That being said, I'm still not sure what security context spawning should be executed under to be able to authenti...
- 08:10 AM Feature #3931: single sign-on for virtual desktop mode
- > > * As noted in #4129, the pooling side of things is not critical right now. [...] For that reason, I'd prefer to k...
- 03:52 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> In regard to unifying the spawning logic and the authentication changes, I'll have to just look a... - 03:50 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> * I would expect us to drop usage of @GuestAccess@ in the solution. It is a hack that is not imp... - 03:45 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> * I would expect us to drop usage of @GuestAccess@ in the solution. It is a hack that is not imp... - 03:31 AM Feature #3931: single sign-on for virtual desktop mode
- That being said, I'm still not sure what security context spawning should be executed under to be able to authentica...
- 03:25 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> * We have one customer that plans a separate web server for their embedded environment and all th... - 03:16 AM Feature #3931: single sign-on for virtual desktop mode
- Greg Shah wrote:
> * As noted in #4129, the pooling side of things is not critical right now. [...] For that reason,...
07/20/2023
- 12:37 PM Bug #7515: FILL-IN: editing dates issues
- *(FIXED)* Another issue found:
In a @character@ or @date@ @FILL-IN@:
# the cursor is in the leftmost position
... - 11:29 AM Feature #3931: single sign-on for virtual desktop mode
- I don't have time to do a full code review.
Some quick feedback:
* As noted in #4129, the pooling side of thing... - 11:14 AM Feature #3931: single sign-on for virtual desktop mode
- > Do we have customers using brokers with web (VD / embedded)?
Not in production today but it should be supported. - 10:38 AM Feature #3931: single sign-on for virtual desktop mode
- Do we have customers using brokers with web (VD / embedded)?
- 10:29 AM Feature #3931: single sign-on for virtual desktop mode
- Early review required on 3931a r14652 based on trunk r14637.
What was done:
* adding @/sso/gui@, @/sso/chui@ and ...
Also available in: Atom