Activity

From 02/10/2013 to 03/11/2013

03/11/2013

07:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Do we really need BDT.castLogical()? Or can we handle this using new logical(BDT)? If we can avoid the castLogical(... Greg Shah
12:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > In these cases where ptypes[i] is null, I think it default to BaseDataType, right?
Are you asking what the type ... Greg Shah
10:50 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > 1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. For example, if ... Constantin Asofiei
10:21 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Code Review:
1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. Fo... Greg Shah
08:36 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The case automatically assigns the lower 32-bits of the long to the int. Since oldtype can never be > 2GB, this is s... Greg Shah
08:05 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bi... Eugenie Lyzenko
06:28 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update contains some fixes in ECW.parameterTypeName and base_structure.xml, plus BUFFER-COPY/COMPARE (from Eric)... Constantin Asofiei
05:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bits... Constantin Asofiei
05:22 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
1.6.X
The long 64 bit ca... Eugenie Lyzenko
04:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01. Constantin Asofiei

03/10/2013

02:36 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > And the update for note 50.
Constantin, how you compiled the update? I put it on top of the current bzr code and... Eugenie Lyzenko
10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: And the update for note 50. Constantin Asofiei
10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Attached update contains:
# ParmType - added needed APIs for the enum
# SignatureHelper - fixed the definition for ... Constantin Asofiei
07:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: I think KW_SET_BUF should have a BDT_VARARGS instead of BDT_ARRAY, because as I see from the docs, it can re... Constantin Asofiei
07:15 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Constantin Asofiei wrote:
> Greg Shah wrote:
> > Actually, after thinking about it some more, is there a need to ev... Constantin Asofiei

03/09/2013

05:20 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: New drop uploaded. The function and methods are separated in two different maps. Eugenie Lyzenko
04:52 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, go with that approach. Greg Shah
04:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
Yes, we can impl... Eugenie Lyzenko
03:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword. Greg Shah
02:54 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie Lyzenko wrote:
> > Eugenie: KW_FILL appears twice in the map.
>
> Yes, one for Built-in function, other f... Constantin Asofiei
02:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: KW_FILL appears twice in the map.
Yes, one for Built-in function, other for method. They both have diff... Eugenie Lyzenko
02:27 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > For KW_REPLACE: I see that you've specified two signatures for it, but according to 10.2B docs, it has 3 mandatory ... Eugenie Lyzenko
12:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg Shah wrote:
> Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAM... Constantin Asofiei
11:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAMIC-FUNCTION? They w... Greg Shah
11:42 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK. But we could handle these cases too.
1. SUPER is especially easy to handle, because we can use the same techn... Greg Shah
11:37 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Actually, I think the ECW already handles KW_SUPER fully. It searches up the tree to find the containing function ... Constantin Asofiei
11:31 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Some thoughts:
> The fact that a function can have multiple signatures troubles us at conversion time, as if we do... Greg Shah
11:02 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another case of the KW_DYN_FUNC: the handle parameter is optional. I think this should also be explicitly treated by ... Constantin Asofiei
09:40 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: There is another case which is not treated properly. When IF ternary operator has an ? on the else or then branch, as... Constantin Asofiei
08:20 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: About KW_DATETIME:
* how can we disambiguate the signature, if the number of mandatory parameter is the same (1) in ... Constantin Asofiei
07:53 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: KW_FILL appears twice in the map. Constantin Asofiei
05:08 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The fact that a function can have multiple signatures troubles us at conversion time, as if we don't offer a choice t... Constantin Asofiei

03/08/2013

05:07 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The first complete drop to review has been uploaded.
PS: Forgot to note. The file SignatureHelper.java contains the ... Eugenie Lyzenko
04:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Undocumented functions?
Yes, these are undocumented.
It is our understanding that LOWER is the same thing as ... Greg Shah
02:59 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg,
I'm preparing the final drop to upload and requesting for ability not to follow the 98 column restriction fo... Eugenie Lyzenko
01:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The remaining questions:
The functions defined in progress.g but not in 4GL reference documentation:... Eugenie Lyzenko
11:18 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Add CLOB (which is really only the CLOB field case) and LARGE_CHAR_OBJECT which is either LONGCHAR or CLOB.
> SET-... Greg Shah
10:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Can you provide an example? A CLOB can only be a field in the database, so I guess the method must take a reference... Eugenie Lyzenko
08:35 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > There are the methods we do not define in progress.g file:
These are from v11 which we don't support yet.
> D... Greg Shah
10:04 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The handle methods has been added. There are the methods we do not define in progress.g file:
ADD-PARENT-ID-RELATION... Eugenie Lyzenko
02:19 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: I'm putting this case here, because is a name collision:... Constantin Asofiei
07:39 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Passed conversion regression testing, committed to bzr revision 10265. Constantin Asofiei
04:40 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: This converts dots in names to "dot" string. I will put this through conversion. Constantin Asofiei

03/07/2013

05:27 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Go ahead with this change.
> A question: are you sure it's safe to "eat" the "-", "_" and "/" character from the n... Greg Shah
05:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: No, CONFIG-NAME is supposed to be an attribute. It is a bug in our parser. I have some other parser changes I'm mak... Greg Shah
05:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Found potential issue in progress.g:
According to Progress doc CONFIG-NAME is an attribute, not a method. But we def... Eugenie Lyzenko
10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > If parameter is widget we need to add something: WID mapping to GenerigWidget?
Yes, that is fine.
> Arrays ar... Greg Shah
09:58 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg,
I'm working on the handle based methods adding. It's avout 300 lines. So I'm expecting to finish today-tomor... Eugenie Lyzenko
09:26 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The update has been uploaded. All built-in functions are there except so called "fake" web-speed ones. No methods for... Eugenie Lyzenko

03/06/2013

04:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK.
The new datatype under questions:
1. If parameter is widget we need to add something: WID mapping to GenerigW... Eugenie Lyzenko
04:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, get as much done tonight as possible. Then create an update zip and upload it here.
Constantin will be able t... Greg Shah
03:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: how much more time do you expect this to take?
It is > 100 items left in functions. I guess this is ~10... Eugenie Lyzenko
03:24 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Constantin: We can certainly go ahead with the infrastructure to use the facility. I planned this to be exposed th... Constantin Asofiei
03:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: how much more time do you expect this to take?
Constantin: We can certainly go ahead with the infrastruct... Greg Shah
03:10 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg: I don't know the order you plan to have this working, but if documenting each signature will take more time, I ... Constantin Asofiei
02:42 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: OK, looks like this addition in NamepConverte's static c'tor:... Constantin Asofiei
02:39 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: This one did turn and bit us, because the server project has files named like "foo.bar.p", which get converted to "Fo... Constantin Asofiei
08:26 AM Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment: Greg Shah
07:13 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Committed to bzr revision 10251. Constantin Asofiei
05:18 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: The server folders had no errors related to comments. Constantin Asofiei

03/05/2013

06:32 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Generally, I like it. This will work for some of the cases, but not all cases. Still, it is good enough to go with ... Greg Shah
06:18 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > How about this approach:
> ...
The approach is working but we need to modify the getter this way for example:
... Eugenie Lyzenko
05:22 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > If we have multiple versions of the same function with different numbers of different kind of parameters how we dec... Greg Shah
05:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Several data type question for this time:
1. If we have multiple versions of the same function with different numbers... Eugenie Lyzenko
03:46 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: This update passes conversion regression testing with comments off (no changes in generated sources), and MAJIC does ... Constantin Asofiei

03/04/2013

02:35 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Didn't the static import statement work? I wasn't sure if it would work with enums or not. If it doesn't work, then... Eugenie Lyzenko
02:31 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > We need to create separate class file for ParmType?
Yes.
> In this case we need to declare ParmType.CHAR ins... Greg Shah
01:35 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Two questions.
1. We need to create separate class file for ParmType? In this case we need to declare ParmType.CHAR ... Eugenie Lyzenko
10:51 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This is a high priority for milestone 4 so that we can make sure to generate compilable code. Please implement this ... Greg Shah

03/01/2013

03:42 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: WOW! That is very cool. Great job! Greg Shah
03:40 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: MAJIC has compiled with comments enabled (and AFAIK this was not possible before this update). Constantin Asofiei
02:48 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Conversion has finished, compiled fully, but there are some regressions in terms of:
# new-lines no longer emitted i... Constantin Asofiei
01:40 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: OK, the server's compilable folders do not seem to report any comment-related errors. I'm putting this through conver... Constantin Asofiei
11:53 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Well done. It looks good. Painful, though. I have to think about this problem a bit to see if there is a way to he... Greg Shah
11:41 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: I'm testing this version with the server files which had comment errors, if everything is good I move to conversion r... Constantin Asofiei
09:24 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: I'm stopping conversion, a server folder has failed with some other comment related issue. I need to get rewrite at l... Constantin Asofiei
09:13 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: I'm running conversion now. Constantin Asofiei
09:12 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: I am fine with the changes. If they pass conversion testing, let's go with it. Greg Shah
07:53 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Replaced getNextSibling with ignore-star version. Constantin Asofiei
06:57 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Made next-child-rules to be ignorant of star-comment nodes, I'm putting this through conversion regression testing. Constantin Asofiei

02/24/2013

09:29 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: OK, for now this is done. I am going to move this to another milestone. The only remaining work is to remove the ha... Greg Shah
08:00 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The only real problem is when converting the 4GL proc name, to make the name compatbile with Java syntax. As we don't... Constantin Asofiei
07:18 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Interesting. I wonder what is going on there. I can duplicate your result as well.
But when I used the testcases... Greg Shah

02/23/2013

03:24 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: I'm not sure what is needed here. The following converts nicely in P2J:... Constantin Asofiei
12:20 PM Feature #2001: reporting v2.5: This improvement to the reports is designed to massively improve performance. This was needed because on large proje... Greg Shah

02/16/2013

07:25 PM Feature #2001 (Closed): reporting v2.5: Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Conversion Tools

Activity

Activity

03/11/2013

03/10/2013

03/09/2013

03/08/2013

03/07/2013

03/06/2013

03/05/2013

03/04/2013

03/01/2013

02/28/2013

02/27/2013

02/25/2013

02/24/2013

02/23/2013

02/16/2013