Activity
From 02/12/2013 to 03/13/2013
03/14/2013
- 09:54 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- This update (hopefully) resolves everything left on this task except for the issue mentioned in note 93. Here is a s...
03/13/2013
- 05:48 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- The suggested fix has been uploaded. It properly converts the sample:...
- 02:06 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- The places to modify:
for frames: rule file annotation/frame_scoping.rules, internal function "process_frame"... - 10:17 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- The strange thing is that I thought we already did some of this kind of disambiguation.
We don't want this to be s... - 10:09 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- Another word we need to decide what are the exact cases when we need special processing for "-" character. For now I ...
- 10:02 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- Another name collision, when vars are used:...
- 07:55 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- If we have a substitution that we want to be the default, then we would always want to encode it in P2J and not in th...
- 04:51 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Constantin: this case:...
- 01:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The complete list is this (logged from where the ECW.expressionType would throw exception otherwise):...
- 01:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > When do you think you will have this available?
The server conversion is in the Base Structure phase, with a few f... - 01:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > What I can do is remove the last fallback checks (the _POLY-related checks ), adjust the ECW to log a message inste...
- 10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- This is the good version, committed to bzr revision 10284.
LE: it passed conversion regression testing. - 10:34 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Yes, you understand correctly. The idea here was this: for the KW_DYN_FUNC node, we don't need to the ControlFlowOps....
- 10:32 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- I guess what is happening is that casttype is really meant to be used for the .class emit on a DYNAMIC-FUNCTION invoc...
- 10:24 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- I don't fully understand the purpose of the "ignorecast" annotation:...
- 10:01 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK, good idea.
- 10:00 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- How about this: if these cases are already known to return logical, then I will emit the logical.class and not wrap ...
- 09:55 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (wh...
- 09:49 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (when...
- 09:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > I think the only issue here is where the new character() wrapper is emitted.
I think you are right.
> If I unders... - 09:10 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Here is the code that is generated by my current implementation:...
- 08:52 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Had a problem, forgot to initialize the @ref@ var in base_structure.xml's @parent.type == prog.kw_run@ run (without t...
- 08:28 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg Shah wrote:
> I think there should be some code like this in the example:
The code should be @h = temp-table t... - 08:23 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- I think there should be some code like this in the example:...
- 07:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- And the update...
- 07:38 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The attached update fixes this:
# wrapping of handle for a @RUN ... IN DYNAMIC-FUNCTION@ call
# varargs signature pro... - 06:17 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg, in the server project there are failures related to the fact that _POLY is used as an operand. The failed opera...
03/12/2013
- 06:43 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- OK. I've found the answer for note #13. The matchlist.xml config file overrides the NameConverter.java internals. The...
- 06:17 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- The question. Why adding replacement:...
- 02:08 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Attached was committed to bzr revision 10282.
- 01:55 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK, please go ahead and check it in. You can leave the assignments.rules there. I will deal with the merge.
> Wh... - 01:49 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- PS: the conversion regression testing has passed. The only changes are related to:...
- 01:44 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is ju...
- 01:28 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is just...
- 12:48 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > That makes sense. Are you going to add that?
No, I don't want to add this now.
> In a related note: my changes... - 12:31 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- That makes sense. Are you going to add that?
In a related note: my changes are ready, but I want to test them wit... - 12:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- I don't recall seeing "attributes set to unknown"-related errors, but I think we should consider handling the attribu...
- 09:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK, I'll fold that into my changes. It will make the result much cleaner.
In regard to your changes, that is grea... - 08:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Yes, we can get rid of castLogical and use new logical() instead.
I have an update for which I still need to make ...
03/11/2013
- 07:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Do we really need BDT.castLogical()? Or can we handle this using new logical(BDT)? If we can avoid the castLogical(...
- 12:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > In these cases where ptypes[i] is null, I think it default to BaseDataType, right?
Are you asking what the type ... - 10:50 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > 1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. For example, if ...
- 10:21 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Code Review:
1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. Fo... - 08:36 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The case automatically assigns the lower 32-bits of the long to the int. Since oldtype can never be > 2GB, this is s...
- 08:05 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bi...
- 06:28 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- This update contains some fixes in ECW.parameterTypeName and base_structure.xml, plus BUFFER-COPY/COMPARE (from Eric)...
- 05:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bits...
- 05:22 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
1.6.X
The long 64 bit ca... - 04:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
03/10/2013
- 02:36 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > And the update for note 50.
Constantin, how you compiled the update? I put it on top of the current bzr code and... - 10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- And the update for note 50.
- 10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Attached update contains:
# ParmType - added needed APIs for the enum
# SignatureHelper - fixed the definition for ... - 07:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Eugenie: I think KW_SET_BUF should have a BDT_VARARGS instead of BDT_ARRAY, because as I see from the docs, it can re...
- 07:15 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Actually, after thinking about it some more, is there a need to ev...
03/09/2013
- 05:20 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- New drop uploaded. The function and methods are separated in two different maps.
- 04:52 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Yes, go with that approach.
- 04:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
Yes, we can impl... - 03:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
- 02:54 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Eugenie Lyzenko wrote:
> > Eugenie: KW_FILL appears twice in the map.
>
> Yes, one for Built-in function, other f... - 02:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Eugenie: KW_FILL appears twice in the map.
Yes, one for Built-in function, other for method. They both have diff... - 02:27 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > For KW_REPLACE: I see that you've specified two signatures for it, but according to 10.2B docs, it has 3 mandatory ...
- 12:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg Shah wrote:
> Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAM... - 11:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAMIC-FUNCTION? They w...
- 11:42 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK. But we could handle these cases too.
1. SUPER is especially easy to handle, because we can use the same techn... - 11:37 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Actually, I think the ECW already handles KW_SUPER fully. It searches up the tree to find the containing function ...
- 11:31 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Some thoughts:
> The fact that a function can have multiple signatures troubles us at conversion time, as if we do... - 11:02 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Another case of the KW_DYN_FUNC: the handle parameter is optional. I think this should also be explicitly treated by ...
- 09:40 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- There is another case which is not treated properly. When IF ternary operator has an ? on the else or then branch, as...
- 08:20 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- About KW_DATETIME:
* how can we disambiguate the signature, if the number of mandatory parameter is the same (1) in ... - 07:53 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Eugenie: KW_FILL appears twice in the map.
- 05:08 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The fact that a function can have multiple signatures troubles us at conversion time, as if we don't offer a choice t...
03/08/2013
- 05:07 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The first complete drop to review has been uploaded.
PS: Forgot to note. The file SignatureHelper.java contains the ... - 04:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Undocumented functions?
Yes, these are undocumented.
It is our understanding that LOWER is the same thing as ... - 02:59 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg,
I'm preparing the final drop to upload and requesting for ability not to follow the 98 column restriction fo... - 01:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The remaining questions:
The functions defined in progress.g but not in 4GL reference documentation:... - 11:18 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Add CLOB (which is really only the CLOB field case) and LARGE_CHAR_OBJECT which is either LONGCHAR or CLOB.
> SET-... - 10:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Can you provide an example? A CLOB can only be a field in the database, so I guess the method must take a reference...
- 08:35 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > There are the methods we do not define in progress.g file:
These are from v11 which we don't support yet.
> D... - 10:04 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The handle methods has been added. There are the methods we do not define in progress.g file:
ADD-PARENT-ID-RELATION... - 02:19 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- I'm putting this case here, because is a name collision:...
- 07:39 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- Passed conversion regression testing, committed to bzr revision 10265.
- 04:40 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- This converts dots in names to "dot" string. I will put this through conversion.
03/07/2013
- 05:27 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- Go ahead with this change.
> A question: are you sure it's safe to "eat" the "-", "_" and "/" character from the n... - 05:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- No, CONFIG-NAME is supposed to be an attribute. It is a bug in our parser. I have some other parser changes I'm mak...
- 05:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Found potential issue in progress.g:
According to Progress doc CONFIG-NAME is an attribute, not a method. But we def... - 10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > If parameter is widget we need to add something: WID mapping to GenerigWidget?
Yes, that is fine.
> Arrays ar... - 09:58 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg,
I'm working on the handle based methods adding. It's avout 300 lines. So I'm expecting to finish today-tomor... - 09:26 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- The update has been uploaded. All built-in functions are there except so called "fake" web-speed ones. No methods for...
03/06/2013
- 04:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK.
The new datatype under questions:
1. If parameter is widget we need to add something: WID mapping to GenerigW... - 04:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- OK, get as much done tonight as possible. Then create an update zip and upload it here.
Constantin will be able t... - 03:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Eugenie: how much more time do you expect this to take?
It is > 100 items left in functions. I guess this is ~10... - 03:24 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Constantin: We can certainly go ahead with the infrastructure to use the facility. I planned this to be exposed th...
- 03:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Eugenie: how much more time do you expect this to take?
Constantin: We can certainly go ahead with the infrastruct... - 03:10 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Greg: I don't know the order you plan to have this working, but if documenting each signature will take more time, I ...
- 02:42 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- OK, looks like this addition in NamepConverte's static c'tor:...
- 02:39 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- This one did turn and bit us, because the server project has files named like "foo.bar.p", which get converted to "Fo...
- 08:26 AM Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment
- 07:13 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Committed to bzr revision 10251.
- 05:18 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- The server folders had no errors related to comments.
03/05/2013
- 06:32 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Generally, I like it. This will work for some of the cases, but not all cases. Still, it is good enough to go with ...
- 06:18 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > How about this approach:
> ...
The approach is working but we need to modify the getter this way for example:
... - 05:22 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > If we have multiple versions of the same function with different numbers of different kind of parameters how we dec...
- 05:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Several data type question for this time:
1. If we have multiple versions of the same function with different numbers... - 03:46 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- This update passes conversion regression testing with comments off (no changes in generated sources), and MAJIC does ...
03/04/2013
- 02:35 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > Didn't the static import statement work? I wasn't sure if it would work with enums or not. If it doesn't work, then...
- 02:31 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- > We need to create separate class file for ParmType?
Yes.
> In this case we need to declare ParmType.CHAR ins... - 01:35 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Two questions.
1. We need to create separate class file for ParmType? In this case we need to declare ParmType.CHAR ... - 10:51 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- This is a high priority for milestone 4 so that we can make sure to generate compilable code. Please implement this ...
03/01/2013
- 03:42 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- WOW! That is very cool. Great job!
- 03:40 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- MAJIC has compiled with comments enabled (and AFAIK this was not possible before this update).
- 02:48 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Conversion has finished, compiled fully, but there are some regressions in terms of:
# new-lines no longer emitted i... - 01:40 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- OK, the server's compilable folders do not seem to report any comment-related errors. I'm putting this through conver...
- 11:53 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Well done. It looks good. Painful, though. I have to think about this problem a bit to see if there is a way to he...
- 11:41 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I'm testing this version with the server files which had comment errors, if everything is good I move to conversion r...
- 09:24 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I'm stopping conversion, a server folder has failed with some other comment related issue. I need to get rewrite at l...
- 09:13 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I'm running conversion now.
- 09:12 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I am fine with the changes. If they pass conversion testing, let's go with it.
- 07:53 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Replaced getNextSibling with ignore-star version.
- 06:57 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Made next-child-rules to be ignorant of star-comment nodes, I'm putting this through conversion regression testing.
02/28/2013
- 04:15 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- The conclusion for today, after trying a scoping approach to solve some nested calls issues is this, in brew phase (a...
- 09:10 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I still have some regressions in it, I'm testing and will re-upload.
- 09:09 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- The code looks fine. And that is some testcase! It made me laugh to read it. Well done.
- 08:41 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- This fixes these cases:...
- 05:12 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I believe this was also addressed in the #1450. Unfortunately it was not finalized.
- 03:01 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- Fix attempt for star comments mixed with children of IF, method arguments, and others. Will test with MAJIC and some ...
- 01:44 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- I suggest to disable comments, run conversion in the good directories and compile again, to uncover non-comment probl...
- 01:21 AM Bug #2066 (WIP): brew adds unnecessary comma in method parameter list after comment
02/27/2013
- 02:06 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment
- On a whim last night, I tried to compile the partially converted customer app project, and quickly hit an "illegal st...
- 01:59 PM Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment
02/25/2013
- 03:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
- Consider these classes:...
- 03:19 PM Feature #2053 (Closed): create a parameter type lookup facility for built-in functions and handle...
02/24/2013
- 09:29 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- OK, for now this is done. I am going to move this to another milestone. The only remaining work is to remove the ha...
- 08:00 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- The only real problem is when converting the 4GL proc name, to make the name compatbile with Java syntax. As we don't...
- 07:18 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- Interesting. I wonder what is going on there. I can duplicate your result as well.
But when I used the testcases...
02/23/2013
- 03:24 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
- I'm not sure what is needed here. The following converts nicely in P2J:...
- 12:20 PM Feature #2001: reporting v2.5
- This improvement to the reports is designed to massively improve performance. This was needed because on large proje...
02/16/2013
Also available in: Atom