Activity

From 03/05/2013 to 04/03/2013

03/29/2013

10:38 AM Feature #2001 (Closed): reporting v2.5: Eric Faulhaber

03/28/2013

03:22 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The updates om_upd20130325a.zip and om_upd20130325b.zip were committed to bzr (rev 10330, and rev. 10332) and distrib... Ovidiu Maxiniuc

03/23/2013

06:40 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The changes in note 161 did cause some regressions in Majic. I have fixed all but one of them. As soon as that one ... Greg Shah
05:17 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: You are correct, the approach you mentioned from functions.rules matches the not-needed cases too.
> I can't really ... Constantin Asofiei
05:07 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Part of the issue with note 155 is the over-aggressive setting of ignorecast in annotations/functions.rules:... Greg Shah
04:44 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The update looks OK, I can't find any obvious flaws in the logic. Constantin Asofiei
04:26 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: About note 157: please see the handle_dyn_func6.p and handle_dyn_func5b.p (the substring issue at note 157 is from he... Constantin Asofiei
04:18 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The extra ';' might be related to the comments changes. For query-prepare (and dynamic-function as parameter in gener... Constantin Asofiei
04:16 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: In regard to note 155, the same testcase is a bit different after my changes in note 161. Here is the output:
<pr... Greg Shah
03:04 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Here is the proposed update to resolve notes 135 and 139. This resolves all known cases of these problems.
I will... Greg Shah
10:04 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: ca_upd20130322i.zip was committed to bzr revision 10320. MAJIC conversion regression testing has passed (with comment... Constantin Asofiei

03/22/2013

04:25 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Ovidiu: please post here all the cases related to LENGTH function which are not converting properly (the cases when t... Constantin Asofiei
02:43 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, I think the case at note 155 here is related to 157. I'll wait for your changes before continuing. Constantin Asofiei
01:39 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > If think for such cases ECW should return null, if the function's return type and the parameter's type are not comp... Greg Shah
11:24 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: There is a problem in ECW/base_structure. For a case like:... Constantin Asofiei
10:07 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: No, I haven't looked at this case. Greg Shah
09:59 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg, have you touched this case:... Constantin Asofiei
09:33 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: ca_upd20130322d.zip committed to bzr revision 10312. Constantin Asofiei
08:20 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: It is good. Check it in and distribute it if it passes testing. Greg Shah
07:23 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I think I found the problem for the BEGINS operator problem @if h:buffer-value begins ch then message "blah".@. In op... Constantin Asofiei
04:22 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: I agree. The approach you have taken is fine for now.
I also agree that we will need to make additional changes t... Greg Shah
04:09 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: This is a quirk for the SWITCH statement comment case. At this time, I think convert/comments.rules might be incomple... Constantin Asofiei

03/21/2013

01:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: While working on #2068 note 187, I encountered the following case:... Ovidiu Maxiniuc
09:48 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Here is the final version of the indeterminate cases. I have done 2 equivalent versions: one using buffer-value and ... Greg Shah

03/20/2013

06:55 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, this testcase is close to being done. It shows the really insane variety of possibilities with the truly dynamic... Greg Shah

03/19/2013

04:22 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: wrong task Constantin Asofiei
04:12 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: wrong task Constantin Asofiei
04:06 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: wrong task Constantin Asofiei

03/18/2013

06:49 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: My changes do not work properly. Interestingly, even Majic has some pretty crazy combinations like this:
def var ... Greg Shah
04:28 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The evl_upd20130318a.zip has been committed in bzr as 10296. As I note before it passed the conversion testing. Eugenie Lyzenko
04:08 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Check it in and distribute it. Greg Shah
02:11 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The update 20130318a has passed the conversion testing, compared directories are /ddl and /src/aero/timco/majic. Eugenie Lyzenko
12:13 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The new update with scoping support has been added for review. The case when we has separate handling for button, rec... Eugenie Lyzenko
11:40 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Yes, frames are scoped too. Greg Shah
10:26 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: I'm testing the implemented approach with dictionary usage. And I have a question. Do we need the same code to be imp... Eugenie Lyzenko

03/17/2013

06:11 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This set of changes resolves the problems in note 135 (literals.rules, ECW) and 139 (common-progress.rules). I also ... Greg Shah
04:07 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Update for note 142 is at #2068, note 133 Constantin Asofiei

03/16/2013

04:40 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: There is a problem when the comment is emitted after the peer:... Constantin Asofiei
02:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: 16a.zip was committed to bzr revision 10292. Constantin Asofiei
02:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Looks good. Check it in and distribute it. Greg Shah
01:40 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update changes the ECW (by moving the ATTR_HANDLE test out of the simpleExpressionType) and the javadocs (I touc... Constantin Asofiei
01:20 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I had the impression that this was fixed:... Constantin Asofiei
10:31 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I will take notes 135 and 139. Greg Shah
10:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Code Review (for all of the updates including 15c):
I am generally fine with the changes. There are some formatti... Greg Shah
11:40 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: This is the reason we use the dictionary. The example in note 33 has 2 scopes. It will result in a parameter for th... Greg Shah

03/15/2013

05:57 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: ... Eugenie Lyzenko
05:07 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Ok, I just lost a comment due to "redmine wants me to login again" so here is the short part. Your approach is too ag... Constantin Asofiei
04:04 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > What troubles you? The fact that the procedure's parameter gets promoted and collides with another proc's parameter... Eugenie Lyzenko
11:25 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > The question is do we need to ignore 4GL case sensitivity?
Please test your case in 4GL environment, and you will... Constantin Asofiei
11:19 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The remaining conversion issue with recent changes is related to the name case sensitivity issue. Consider the follow... Eugenie Lyzenko
03:58 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another case which does not convert properly:... Constantin Asofiei
03:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another update, built on top of 15b:
# fix a NPE during conversion
# fix the MINIMUM/MAXIMUM functions, when used w... Constantin Asofiei
12:25 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Attached update is on top of 15a.zip and adds:
# field assignment, when the field is date/datetime/datetimetz, to al... Constantin Asofiei
11:59 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another case of character c'tor derail:... Constantin Asofiei
10:54 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another weird issue which needs to be handled by the ECW. Following code is valid 4GL:... Constantin Asofiei
10:24 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update fixes:
# HANDLE attribute passed to method/function calls as a parameter (needs to be wrapped in a handl... Constantin Asofiei
02:40 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Also, please do check in your 14b fix if/when it is OK.
Committed to bzr revision 10290, as the server folders conv... Constantin Asofiei
08:13 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I've been looking at the chaining problem. We have a model that is already pretty close. The OO features provide ch... Greg Shah

03/14/2013

04:55 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg Shah wrote:
> In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an A... Constantin Asofiei
04:39 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK. Test your change and check it in if it is OK.
The parser is the best solution for this case. Yes, COLON (and... Greg Shah
04:31 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg Shah wrote:
> 14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
With 1... Constantin Asofiei
04:19 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: 14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
But if we are going to f... Greg Shah
04:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Do you mean 14a or 14b? The taks is #1920. Constantin Asofiei
04:13 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Your recent update also causes this issue:... Greg Shah
04:12 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: PS: sorry, the JAST is the wrong one, I'll update the previous note shortly. Constantin Asofiei
04:10 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The JAST at the time of the move_params is called, for the @h:buffer-field(ch):buffer-value@ part of the note 120's t... Constantin Asofiei
04:03 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I don't see a problem with this, but honestly, I don't really fully understand the code in move_params. If it works,... Greg Shah
03:59 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update fixes case at note 120. I'm putting this back into conversion regression testing and into server folder c... Constantin Asofiei
03:57 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an ATTR_CHAR so there i... Greg Shah
03:48 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Urgh... I should have waited 5 more minutes. My ca_upd20130314a.zip update regresses this test, during conversion (LE... Constantin Asofiei
03:40 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > In regard to your update in note 115, check it in and distribute it.
Committed to bzr revision 10288. Constantin Asofiei
03:36 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The problem is that it wraps all parameters passed to the @concat@ API call, as in concat(new character(*"<", handle.... Constantin Asofiei
03:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: In regard to your update in note 115, check it in and distribute it.
In regard to note 116, I don't see where the ... Greg Shah
03:23 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg,
I've started per-folder conversion of the server project and I got this regression:... Constantin Asofiei
03:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The attached update has passed conversion regression testing. Constantin Asofiei
02:11 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: None at all. To make it generate instance method calls, only a few changes are needed in methods_attributes.rules (to... Constantin Asofiei
01:52 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Remind me again: how much of the inversion problem is due to the fact that we use statics in handle for unwrapping in... Greg Shah
01:51 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The ges_upd20130314d.zip passed conversion testing and checked in as bzr revision 10287. Greg Shah
01:49 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: With this in mind, note 93 looks like an effect of what we've discussed in the last 3 notes. I'll put the fix at note... Constantin Asofiei
01:46 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > And AFAIK createPeerAst sets the peerid for the current processed node (the this node), right?
Yes.
> I think... Greg Shah
01:44 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Hmm... I see now what you mean. Note that in methods_attributes.rules, when we convert a METH_ node, the @this@ in th... Constantin Asofiei
01:33 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The peerid that is added at the STRING node is done after any wrapping would have to take place. I am more concerned... Greg Shah
01:24 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: LE: I see the problem, is related to the fact that when move_params is called by methods_attributes.rules in the seco... Constantin Asofiei
01:08 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: About note 93. See these two ASTs:... Constantin Asofiei
12:56 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This version fixes both the regression in Majic (hopefully in all cases) as well as the super(?, ?, ?) case. It reso... Greg Shah
11:55 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > > 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share the case you ha... Constantin Asofiei
11:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Good feedback.
> 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share... Greg Shah
11:05 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Review results:
1. This comment in base_structure.xml:379... Constantin Asofiei
11:03 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Unless I read the diff wrong, the new way is the way of eliminating the getScreenValue and using the widget getter.... Greg Shah
11:00 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > 1. The new way is more correct?
> 2. The old way may be working (or may not) depending on the format of the var?... Constantin Asofiei
10:53 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Questions:
1. The new way is more correct?
2. The old way may be working (or may not) depending on the format o... Greg Shah
10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > 2. Detection of incompatible types in the comparison operators (which take BDT). A standalone testcase:
> def va... Constantin Asofiei
10:22 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Here is the final version, with some fixes necessary to convert Majic. Please see #2091 for a Majic change that must... Greg Shah
10:01 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Constantin: would you please do a code review of this update?
I'm looking at it now. Constantin Asofiei
07:57 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I have fixed some issues (found in my manual testing) with the update.
The conversion testing didn't ever complete... Greg Shah
09:54 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update (hopefully) resolves everything left on this task except for the issue mentioned in note 93. Here is a s... Greg Shah
04:38 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: OK. I'll investigate the ScopedSymbolDictionary keeping approach. The next drop implements the Map usage and some min... Eugenie Lyzenko
03:52 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > The conversion test is the comparison for MAJIC converted result before and after update. Is it correct?
Yes.
... Greg Shah
03:08 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > There are many diffs in Majic. Please review the following and determine if these are correct or not.
I think be... Eugenie Lyzenko
12:41 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: There are many diffs in Majic. Please review the following and determine if these are correct or not. Greg Shah
10:49 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > Do you want me to conversion test this on devsrv01?
Yes, please run this on devsrv01. Eugenie Lyzenko
10:36 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Do you want me to conversion test this on devsrv01? It is much faster than lightning and will not impact the conversi... Greg Shah
10:31 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: > 1. In both files, please start with namesfx = 2. I think this is more natural for the 2nd instance of that var.
... Eugenie Lyzenko
08:22 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Code Review:
Overall, it is very good. Some minor things:
1. In both files, please start with namesfx = 2. I ... Greg Shah

03/13/2013

05:48 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The suggested fix has been uploaded. It properly converts the sample:... Eugenie Lyzenko
02:06 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The places to modify:
for frames: rule file annotation/frame_scoping.rules, internal function "process_frame"... Eugenie Lyzenko
10:17 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The strange thing is that I thought we already did some of this kind of disambiguation.
We don't want this to be s... Greg Shah
10:09 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Another word we need to decide what are the exact cases when we need special processing for "-" character. For now I ... Eugenie Lyzenko
10:02 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Another name collision, when vars are used:... Constantin Asofiei
07:55 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: If we have a substitution that we want to be the default, then we would always want to encode it in P2J and not in th... Greg Shah
04:51 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Constantin: this case:... Greg Shah
01:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The complete list is this (logged from where the ECW.expressionType would throw exception otherwise):... Constantin Asofiei
01:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > When do you think you will have this available?
The server conversion is in the Base Structure phase, with a few f... Constantin Asofiei
01:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > What I can do is remove the last fallback checks (the _POLY-related checks ), adjust the ECW to log a message inste... Greg Shah
10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This is the good version, committed to bzr revision 10284.
LE: it passed conversion regression testing. Constantin Asofiei
10:34 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, you understand correctly. The idea here was this: for the KW_DYN_FUNC node, we don't need to the ControlFlowOps.... Constantin Asofiei
10:32 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I guess what is happening is that casttype is really meant to be used for the .class emit on a DYNAMIC-FUNCTION invoc... Greg Shah
10:24 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I don't fully understand the purpose of the "ignorecast" annotation:... Greg Shah
10:01 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, good idea. Constantin Asofiei
10:00 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: How about this: if these cases are already known to return logical, then I will emit the logical.class and not wrap ... Greg Shah
09:55 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (wh... Constantin Asofiei
09:49 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (when... Greg Shah
09:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > I think the only issue here is where the new character() wrapper is emitted.
I think you are right.
> If I unders... Constantin Asofiei
09:10 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Here is the code that is generated by my current implementation:... Greg Shah
08:52 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Had a problem, forgot to initialize the @ref@ var in base_structure.xml's @parent.type == prog.kw_run@ run (without t... Constantin Asofiei
08:28 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg Shah wrote:
> I think there should be some code like this in the example:
The code should be @h = temp-table t... Constantin Asofiei
08:23 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I think there should be some code like this in the example:... Greg Shah
07:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: And the update... Constantin Asofiei
07:38 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The attached update fixes this:
# wrapping of handle for a @RUN ... IN DYNAMIC-FUNCTION@ call
# varargs signature pro... Constantin Asofiei
06:17 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg, in the server project there are failures related to the fact that _POLY is used as an operand. The failed opera... Constantin Asofiei

03/12/2013

06:43 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: OK. I've found the answer for note #13. The matchlist.xml config file overrides the NameConverter.java internals. The... Eugenie Lyzenko
06:17 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: The question. Why adding replacement:... Eugenie Lyzenko
02:08 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Attached was committed to bzr revision 10282. Constantin Asofiei
01:55 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, please go ahead and check it in. You can leave the assignments.rules there. I will deal with the merge.
> Wh... Greg Shah
01:49 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: PS: the conversion regression testing has passed. The only changes are related to:... Constantin Asofiei
01:44 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is ju... Constantin Asofiei
01:28 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is just... Greg Shah
12:48 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > That makes sense. Are you going to add that?
No, I don't want to add this now.
> In a related note: my changes... Constantin Asofiei
12:31 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: That makes sense. Are you going to add that?
In a related note: my changes are ready, but I want to test them wit... Greg Shah
12:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: I don't recall seeing "attributes set to unknown"-related errors, but I think we should consider handling the attribu... Constantin Asofiei
09:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, I'll fold that into my changes. It will make the result much cleaner.
In regard to your changes, that is grea... Greg Shah
08:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, we can get rid of castLogical and use new logical() instead.
I have an update for which I still need to make ... Constantin Asofiei

03/11/2013

07:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Do we really need BDT.castLogical()? Or can we handle this using new logical(BDT)? If we can avoid the castLogical(... Greg Shah
12:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > In these cases where ptypes[i] is null, I think it default to BaseDataType, right?
Are you asking what the type ... Greg Shah
10:50 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > 1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. For example, if ... Constantin Asofiei
10:21 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Code Review:
1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. Fo... Greg Shah
08:36 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The case automatically assigns the lower 32-bits of the long to the int. Since oldtype can never be > 2GB, this is s... Greg Shah
08:05 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bi... Eugenie Lyzenko
06:28 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This update contains some fixes in ECW.parameterTypeName and base_structure.xml, plus BUFFER-COPY/COMPARE (from Eric)... Constantin Asofiei
05:25 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bits... Constantin Asofiei
05:22 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
1.6.X
The long 64 bit ca... Eugenie Lyzenko
04:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01. Constantin Asofiei

03/10/2013

02:36 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > And the update for note 50.
Constantin, how you compiled the update? I put it on top of the current bzr code and... Eugenie Lyzenko
10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: And the update for note 50. Constantin Asofiei
10:16 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Attached update contains:
# ParmType - added needed APIs for the enum
# SignatureHelper - fixed the definition for ... Constantin Asofiei
07:30 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: I think KW_SET_BUF should have a BDT_VARARGS instead of BDT_ARRAY, because as I see from the docs, it can re... Constantin Asofiei
07:15 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Constantin Asofiei wrote:
> Greg Shah wrote:
> > Actually, after thinking about it some more, is there a need to ev... Constantin Asofiei

03/09/2013

05:20 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: New drop uploaded. The function and methods are separated in two different maps. Eugenie Lyzenko
04:52 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Yes, go with that approach. Greg Shah
04:30 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
Yes, we can impl... Eugenie Lyzenko
03:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword. Greg Shah
02:54 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie Lyzenko wrote:
> > Eugenie: KW_FILL appears twice in the map.
>
> Yes, one for Built-in function, other f... Constantin Asofiei
02:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: KW_FILL appears twice in the map.
Yes, one for Built-in function, other for method. They both have diff... Eugenie Lyzenko
02:27 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > For KW_REPLACE: I see that you've specified two signatures for it, but according to 10.2B docs, it has 3 mandatory ... Eugenie Lyzenko
12:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg Shah wrote:
> Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAM... Constantin Asofiei
11:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAMIC-FUNCTION? They w... Greg Shah
11:42 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK. But we could handle these cases too.
1. SUPER is especially easy to handle, because we can use the same techn... Greg Shah
11:37 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Actually, I think the ECW already handles KW_SUPER fully. It searches up the tree to find the containing function ... Constantin Asofiei
11:31 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Some thoughts:
> The fact that a function can have multiple signatures troubles us at conversion time, as if we do... Greg Shah
11:02 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Another case of the KW_DYN_FUNC: the handle parameter is optional. I think this should also be explicitly treated by ... Constantin Asofiei
09:40 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: There is another case which is not treated properly. When IF ternary operator has an ? on the else or then branch, as... Constantin Asofiei
08:20 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: About KW_DATETIME:
* how can we disambiguate the signature, if the number of mandatory parameter is the same (1) in ... Constantin Asofiei
07:53 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: KW_FILL appears twice in the map. Constantin Asofiei
05:08 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The fact that a function can have multiple signatures troubles us at conversion time, as if we don't offer a choice t... Constantin Asofiei

03/08/2013

05:07 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The first complete drop to review has been uploaded.
PS: Forgot to note. The file SignatureHelper.java contains the ... Eugenie Lyzenko
04:06 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Undocumented functions?
Yes, these are undocumented.
It is our understanding that LOWER is the same thing as ... Greg Shah
02:59 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg,
I'm preparing the final drop to upload and requesting for ability not to follow the 98 column restriction fo... Eugenie Lyzenko
01:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The remaining questions:
The functions defined in progress.g but not in 4GL reference documentation:... Eugenie Lyzenko
11:18 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Add CLOB (which is really only the CLOB field case) and LARGE_CHAR_OBJECT which is either LONGCHAR or CLOB.
> SET-... Greg Shah
10:39 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Can you provide an example? A CLOB can only be a field in the database, so I guess the method must take a reference... Eugenie Lyzenko
08:35 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > There are the methods we do not define in progress.g file:
These are from v11 which we don't support yet.
> D... Greg Shah
10:04 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The handle methods has been added. There are the methods we do not define in progress.g file:
ADD-PARENT-ID-RELATION... Eugenie Lyzenko
02:19 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: I'm putting this case here, because is a name collision:... Constantin Asofiei
07:39 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Passed conversion regression testing, committed to bzr revision 10265. Constantin Asofiei
04:40 AM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: This converts dots in names to "dot" string. I will put this through conversion. Constantin Asofiei

03/07/2013

05:27 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: Go ahead with this change.
> A question: are you sure it's safe to "eat" the "-", "_" and "/" character from the n... Greg Shah
05:15 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: No, CONFIG-NAME is supposed to be an attribute. It is a bug in our parser. I have some other parser changes I'm mak... Greg Shah
05:01 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Found potential issue in progress.g:
According to Progress doc CONFIG-NAME is an attribute, not a method. But we def... Eugenie Lyzenko
10:44 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > If parameter is widget we need to add something: WID mapping to GenerigWidget?
Yes, that is fine.
> Arrays ar... Greg Shah
09:58 AM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg,
I'm working on the handle based methods adding. It's avout 300 lines. So I'm expecting to finish today-tomor... Eugenie Lyzenko
09:26 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: The update has been uploaded. All built-in functions are there except so called "fake" web-speed ones. No methods for... Eugenie Lyzenko

03/06/2013

04:38 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK.
The new datatype under questions:
1. If parameter is widget we need to add something: WID mapping to GenerigW... Eugenie Lyzenko
04:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: OK, get as much done tonight as possible. Then create an update zip and upload it here.
Constantin will be able t... Greg Shah
03:34 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Eugenie: how much more time do you expect this to take?
It is > 100 items left in functions. I guess this is ~10... Eugenie Lyzenko
03:24 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > Constantin: We can certainly go ahead with the infrastructure to use the facility. I planned this to be exposed th... Constantin Asofiei
03:14 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Eugenie: how much more time do you expect this to take?
Constantin: We can certainly go ahead with the infrastruct... Greg Shah
03:10 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Greg: I don't know the order you plan to have this working, but if documenting each signature will take more time, I ... Constantin Asofiei
02:42 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: OK, looks like this addition in NamepConverte's static c'tor:... Constantin Asofiei
02:39 PM Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...: This one did turn and bit us, because the server project has files named like "foo.bar.p", which get converted to "Fo... Constantin Asofiei
08:26 AM Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment: Greg Shah
07:13 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: Committed to bzr revision 10251. Constantin Asofiei
05:18 AM Bug #2066: brew adds unnecessary comma in method parameter list after comment: The server folders had no errors related to comments. Constantin Asofiei

03/05/2013

06:32 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Generally, I like it. This will work for some of the cases, but not all cases. Still, it is good enough to go with ... Greg Shah
06:18 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > How about this approach:
> ...
The approach is working but we need to modify the getter this way for example:
... Eugenie Lyzenko
05:22 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: > If we have multiple versions of the same function with different numbers of different kind of parameters how we dec... Greg Shah
05:00 PM Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...: Several data type question for this time:
1. If we have multiple versions of the same function with different numbers... Eugenie Lyzenko
03:46 PM Bug #2066: brew adds unnecessary comma in method parameter list after comment: This update passes conversion regression testing with comments off (no changes in generated sources), and MAJIC does ... Constantin Asofiei

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Conversion Tools

Activity

Activity

03/29/2013

03/28/2013

03/27/2013

03/26/2013

03/25/2013

03/24/2013

03/23/2013

03/22/2013

03/21/2013

03/20/2013

03/19/2013

03/18/2013

03/17/2013

03/16/2013

03/15/2013

03/14/2013

03/13/2013

03/12/2013

03/11/2013

03/10/2013

03/09/2013

03/08/2013

03/07/2013

03/06/2013

03/05/2013