FWD » Core Development » Conversion Tools

02/17/2017

08:29 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11163@.
Adding changes in @gap_analysis_marking.xml@ to:
1. E... Eugenie Lyzenko

06:12 AM Feature #1521: implement gap analysis rules or backing database/marker approach

> If the mark has been found on some step -> we can ignore further steps, saving CPU time, like this:
Good idea.
... Greg Shah

07:42 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11162@.
In this update the global variables and built-in funct... Eugenie Lyzenko

02/16/2017

03:47 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11161@.
Preparing candidate for global variables and built-in ... Eugenie Lyzenko

01:09 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> > And I have reviewed the changes in 3209e since this merge. Do you think something is missed?
>... Eugenie Lyzenko

12:21 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> And I have reviewed the changes in 3209e since this merge. Do you think something is missed?
Yes, I think there ... Greg Shah

12:18 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Yes, please go ahead with adding all of these, including the webspeed functions. Treat the websp... Eugenie Lyzenko

05:03 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Yes, please go ahead with adding all of these, including the webspeed functions. Treat the webspeed functions just l... Greg Shah

10:33 PM Feature #1521: implement gap analysis rules or backing database/marker approach

The new candidates for built-in functions to add into @expressions.rules@ map:... Eugenie Lyzenko

09:17 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Please fix @progress.g@ for @_msg@.
OK. Task branch @1521a@ for review updated to revision @11... Eugenie Lyzenko

08:48 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Please fix @progress.g@ for @_msg@. Greg Shah

08:41 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Good catch. I think this:... Greg Shah

07:44 PM Feature #1521: implement gap analysis rules or backing database/marker approach

OK. According to my refresh for variable/built-in functions criteria the @SUPER(kw_super)@ is the function, not varia... Eugenie Lyzenko

02/15/2017

04:57 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11158@.
Fix removing function and system handles from global v... Eugenie Lyzenko

10:58 AM Feature #1521: implement gap analysis rules or backing database/marker approach

If they have FUNC_ types they are not treated as global variables. Greg Shah

10:10 AM Feature #1521: implement gap analysis rules or backing database/marker approach

>Please go back through your list of questions and make sure you only include VAR_ token types that are not system ha... Eugenie Lyzenko

09:59 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Global variables are matched (see @profile.rpt@) using the @builtin_global_variables@ rule from @common-progress.rule... Greg Shah

09:19 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Several questions for handling built-in functions. The conversion support is performing in @convert/builtin_functions... Eugenie Lyzenko

08:03 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11157@.
Added global variables list. Please take a look if som... Eugenie Lyzenko

02/14/2017

10:29 AM Bug #3242 (Test): parser console output written out of order

A fix is committed to 3209e/11208. We do not bypass the thread executor service as proposed above, but we use it with... Eric Faulhaber

08:43 PM Feature #1521: implement gap analysis rules or backing database/marker approach

+Global variables sub-task+
The new variables to add taken from 4GL documentation:... Eugenie Lyzenko

02/13/2017

01:57 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Sure. Please take all the changes to the gap analysis from there. Then remove them from 3209e s... Eugenie Lyzenko

01:15 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Sure. Please take all the changes to the gap analysis from there. Then remove them from 3209e so there are no mergi... Greg Shah

12:50 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Can I add/merge your changes(with @3209e@) I noted working with @poc@ application for @expressions.rules@ into @1521a... Eugenie Lyzenko

12:00 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> The mapping for both already defined in expressions.rules file, all adding/change for mapping must be done in this ... Greg Shah

11:44 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Next, please work on:
>
> * all global variables (these are often called "built-in functions" ... Eugenie Lyzenko

10:52 AM Feature #1521: implement gap analysis rules or backing database/marker approach

The result is good.
Next, please work on:
* all global variables (these are often called "built-in functions" i... Greg Shah

10:43 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> I think we support the widget option @kw_width@ at conversion (it is mapped to @setWidthChars()@ ... Eugenie Lyzenko

10:20 AM Feature #1521: implement gap analysis rules or backing database/marker approach

I think we support the widget option @kw_width@ at conversion (it is mapped to @setWidthChars()@ in @frame_generator.... Greg Shah

12:24 PM Feature #3225: windows vs linux in p2j.cfg.xml

Constantin Asofiei wrote:
> Ovidiu, can you take a look at @searchpath@ in directory.xml, too? From what I see, thi... Ovidiu Maxiniuc

02/11/2017

04:22 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11154@.
Adding missed options after re-check with bigger proje... Eugenie Lyzenko

07:31 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11153@.
The changes:
1. @MENU-ITEM(WID_MENU_ITM)@ removed fro... Eugenie Lyzenko

02/10/2017

05:55 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> > This refers to validate() method, even not the attribute.
>
> No, this is not the validate()... Eugenie Lyzenko

05:51 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> This refers to validate() method, even not the attribute.
No, this is not the validate() method. It is really a... Greg Shah

05:49 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Almost all issues have fixed. One more point where I have some doubts.
The @widget_options@ function considers @KW... Eugenie Lyzenko

12:44 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> Looks like we have the browse widget that considering as option for frame widget. This means it must be moved to th... Greg Shah

11:35 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11152@.
This is the first working release of the widget option... Eugenie Lyzenko

09:31 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> I can see if the support level data are there to check the new rule set is working properly. Correct?
Yes.
> ... Greg Shah

02:07 PM Feature #3247: need for different configuration values for different parts of a conversion project

Starting with revision 11139, FWD configuration file (@fwd.cfg.xml@) is platform independent, meaning that the files ... Ovidiu Maxiniuc

01:56 PM Feature #3247 (New): need for different configuration values for different parts of a conversion ...

Ovidiu Maxiniuc

02/09/2017

05:44 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Please clarify me some points if my understanding is wrong.
1. The control file is @reports/profile.rpt@, current ... Eugenie Lyzenko

02:04 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11151@.
More clean ups for @user_interface.rules@ file. The op... Eugenie Lyzenko

08:54 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11150@.
Fix for UI options list status maps. This is the base ... Eugenie Lyzenko

02/08/2017

11:40 AM Feature #1521: implement gap analysis rules or backing database/marker approach

> But from the other widgets map(where only fill-in is considering) the support is: rw.cvt_lvl_full | rw.rt_lvl_full.... Greg Shah

11:18 AM Feature #1521: implement gap analysis rules or backing database/marker approach

>The Progress docs say that auto-return can also be used for a browse column. If we don't support it fully at runtime... Eugenie Lyzenko

08:52 PM Feature #1521: implement gap analysis rules or backing database/marker approach

I have prepared the new list of the widget's options:... Eugenie Lyzenko

02/07/2017

11:26 AM Bug #3242: parser console output written out of order

The parsing step of the front end conversion phase uses a thread pool managed by an @ExecutorService@ (see @ScanDrive... Eric Faulhaber

11:01 AM Bug #3242 (Closed): parser console output written out of order

Eric Faulhaber

01/31/2017

09:37 AM Feature #1521: implement gap analysis rules or backing database/marker approach

I think there are some problems with how you are going about this task.
1. There still seems to be confusion about... Greg Shah

01/30/2017

05:42 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11149@.
Added options for widgets other than browse and frame.... Eugenie Lyzenko

01/28/2017

09:59 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11148@.
Added options from general format phrase into widget o... Eugenie Lyzenko

01/27/2017

12:23 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> Widget options map should be separated from browse widget map?
Yes.
> Another word we will have 3 types of d... Greg Shah

12:14 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Thinking about widget options map implementation. And some questions I have got:
1. Widget options map should be sep... Eugenie Lyzenko

11:01 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ rebased with trunk @11140@, new version is @11147@. Eugenie Lyzenko

10:21 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ rebased with trunk @11139@, new version is @11146@. Eugenie Lyzenko

09:12 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11145@.
Finished options support status adding into @user_inte... Eugenie Lyzenko

07:26 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> > After rescan 4GL documents found more options to add:
>
> I don't understand. These are all... Eugenie Lyzenko

09:24 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> After rescan 4GL documents found more options to add:
I don't understand. These are all visible in the @progres... Greg Shah

09:22 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> 1. @FRAME@ option of the clause like @FORM something WITH FRAME fr@. In this case will the @FRAME@ be the option of... Greg Shah

12:09 PM Feature #3225: windows vs linux in p2j.cfg.xml

Greg Shah wrote:
> Please update the Conversion Handbook "Project Setup chapter":/projects/p2j/wiki/Chapter_6_Projec... Ovidiu Maxiniuc

08:57 AM Feature #3225: windows vs linux in p2j.cfg.xml

Please update the Conversion Handbook "Project Setup chapter":/projects/p2j/wiki/Chapter_6_Project_Setup#Global-Confi... Greg Shah

08:48 AM Feature #3225: windows vs linux in p2j.cfg.xml

Greg Shah wrote:
> I agree, let's get this into the trunk. Go ahead with the merge.
The changes from branch were m... Ovidiu Maxiniuc

06:59 AM Feature #3225: windows vs linux in p2j.cfg.xml

I agree, let's get this into the trunk. Go ahead with the merge.
1. Did you look at @searchpath@ (CA's question i... Greg Shah

06:02 AM Feature #3225: windows vs linux in p2j.cfg.xml

The conversion of combined project finished without errors, configured with @opsys=win32@.
I ran a combined test (na... Ovidiu Maxiniuc

01/26/2017

06:33 PM Feature #1521: implement gap analysis rules or backing database/marker approach

After rescan 4GL documents found more options to add:
+Frame phrase:+... Eugenie Lyzenko

05:50 PM Feature #1521: implement gap analysis rules or backing database/marker approach

I have found additional options to add to frame options status. It is related to @FRAME phrase@. But I need some clar... Eugenie Lyzenko

04:11 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> > Both are the frame options, not attributes.
>
> @expressions.rules@ is where we document the... Eugenie Lyzenko

12:03 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> Both are the frame options, not attributes.
@expressions.rules@ is where we document the attributes, not the opt... Greg Shah

11:51 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Are you talking about the attributes or the options? Although the 4GL generally implements both ... Eugenie Lyzenko

11:23 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Are you talking about the attributes or the options? Although the 4GL generally implements both with the same backin... Greg Shah

11:16 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Found the attributes @PAGE-BOTTOM@ and @PAGE-TOP@ are both fully supported for conversion and runtime.
Do I need t... Eugenie Lyzenko

09:13 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11143@.
Completed handling of the browse widget options/attrib... Eugenie Lyzenko

01:58 PM Feature #3225: windows vs linux in p2j.cfg.xml

> Since in the combined project they share the same parameter, I've chosen the opsys=win32, mainly because of GUI req... Greg Shah

01:51 PM Feature #3225: windows vs linux in p2j.cfg.xml

Greg Shah wrote:
> How is testing going?
I started the over night conversion for GUI, hoping to have it ready in ... Ovidiu Maxiniuc

01:21 PM Feature #3225: windows vs linux in p2j.cfg.xml

How is testing going? Greg Shah

01/25/2017

11:51 AM Feature #3225: windows vs linux in p2j.cfg.xml

Ovidiu, can you take a look at @searchpath@ in directory.xml, too? From what I see, this is OS-dependent, too... Constantin Asofiei

11:50 AM Feature #3225: windows vs linux in p2j.cfg.xml

> I don't think this will require retesting.
Agreed.
Excellent. After the @WINDOW-SYSTEM@ changes are checked... Greg Shah

11:32 AM Feature #3225: windows vs linux in p2j.cfg.xml

I already rebased the branch to latest trunk (rev 11144). Before rebasing, the branch passed all tests (devsrv01 and ... Ovidiu Maxiniuc

11:21 AM Feature #3225: windows vs linux in p2j.cfg.xml

Code Review Task Branch 3225a Revision 11144
I like the changes.
Other than the @WINDOW-SYSTEM@ defaults, what ... Greg Shah

11:06 AM Feature #3225: windows vs linux in p2j.cfg.xml

I believe that if the original application code is run in @prowin32.exe@, then @WINDOW-SYSTEM@ will return @MS-WIN95@... Greg Shah

10:58 AM Feature #3225: windows vs linux in p2j.cfg.xml

Greg Shah wrote:
> For GUI projects, we should default @WINDOW-SYSTEM@ to @MS-WIN95@ for both:
>
> * @LogicalTerm... Ovidiu Maxiniuc

10:51 AM Feature #3225: windows vs linux in p2j.cfg.xml

For GUI projects, we should default @WINDOW-SYSTEM@ to @MS-WIN95@ for both:
* @LogicalTerminal.getWindowSystem()@ ... Greg Shah

09:44 AM Feature #3225: windows vs linux in p2j.cfg.xml

@SESSION:WINDOW-SYSTEM@ handling is unchanged. It should be @TTY@ as defaulted in @com.goldencode.p2j.preproc.Options... Ovidiu Maxiniuc

09:03 AM Feature #3225: windows vs linux in p2j.cfg.xml

To what value are you defaulting the @WINDOWS-SYSTEM@ preprocessor define? Greg Shah

08:46 AM Feature #3225: windows vs linux in p2j.cfg.xml

Ovidiu, 3225a rev 11143 looks OK - I see that you rely on @OPSYS=WIN32@ to determine if this is a Windows OS. I need... Constantin Asofiei

07:38 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Ask Stanislav if you have any questions about the status of a browse option. Greg Shah

09:45 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11142@.
This is update for browse widget options status. Not a... Eugenie Lyzenko

01/24/2017

05:56 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Both @MIN-HEIGHT-CHARS@ and @CREATE-ON-ADD@ can be marked as @rw.rt_lvl_stub@.
Task branch @15... Eugenie Lyzenko

05:11 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Both @MIN-HEIGHT-CHARS@ and @CREATE-ON-ADD@ can be marked as @rw.rt_lvl_stub@. Greg Shah

04:04 PM Feature #1521: implement gap analysis rules or backing database/marker approach

The attribute @CREATE-ON-ADD@ has limited support even less than @MIN-HEIGHT-CHARS@. It is implemented on the server ... Eugenie Lyzenko

03:48 PM Feature #1521: implement gap analysis rules or backing database/marker approach

The attribute @MIN-HEIGHT-CHARS@ is supported but only by setting @config.minHeightChars@ value. Actually this value ... Eugenie Lyzenko

02:39 PM Feature #1521: implement gap analysis rules or backing database/marker approach

@kw_creat_oa@ is an attribute. We have some support. You'll have to check the details. Greg Shah

02:26 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> Method @kw_mov_col@ is now fully supported too.
OK. I looked inside the task and one point lef... Eugenie Lyzenko

02:19 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Method @kw_mov_col@ is now fully supported too. Greg Shah

02:13 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> Is it normal?
Yes, for the FWD project (and TRPL and Harness).
> Our internals are now visible for everyone?... Greg Shah

01:40 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> I think some updates to the supported attributes are still missing.
>
> Both prog.kw_col_mov a... Eugenie Lyzenko

01:18 PM Feature #1521: implement gap analysis rules or backing database/marker approach

I think some updates to the supported attributes are still missing.
Both prog.kw_col_mov and prog.kw_col_res are n... Greg Shah

09:30 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11139@. Rebased with trunk @11138@, new version is @11140@.
Cr... Eugenie Lyzenko

08:14 AM Feature #3225: windows vs linux in p2j.cfg.xml

Task branch 3225a was updated yesterday. The current revision is 11142. The latest changes expect that all paths in @... Ovidiu Maxiniuc

01/23/2017

05:30 PM Feature #1521: implement gap analysis rules or backing database/marker approach

I guess the answer depends on whether there are child nodes that represent unsupported configurations. For now, just... Greg Shah

03:24 PM Feature #1521: implement gap analysis rules or backing database/marker approach

The question:
If other phrases are the parts of the frame phrase or frame option - should it be also added into @u... Eugenie Lyzenko

04:13 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> In preference to item 5 of note 7, please work on these parts of item 4:
>
> * frame options a... Eugenie Lyzenko

01/21/2017

07:27 AM Feature #1521: implement gap analysis rules or backing database/marker approach

In preference to item 5 of note 7, please work on these parts of item 4:
* frame options and frame phrases
* brow... Greg Shah

01/20/2017

06:06 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Yes. That makes sense. Greg Shah

05:42 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> One tricky thing is that the PatternEngine will require us to pass in an AST when we run it. But... Eugenie Lyzenko

04:56 PM Feature #1521: implement gap analysis rules or backing database/marker approach

One tricky thing is that the PatternEngine will require us to pass in an AST when we run it. But all these rules don... Greg Shah

04:54 PM Feature #1521: implement gap analysis rules or backing database/marker approach

> As far as I understand we need to use the data provided by expression.rules file to generate the textile tables lik... Greg Shah

04:39 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Clarification for the implementation point number 5 in note #1521-7.
As far as I understand we need to use the dat... Eugenie Lyzenko

12:01 PM Feature #1521: implement gap analysis rules or backing database/marker approach

Code Review Task Branch 1521a Revision 11138
The changes are good. Greg Shah

11:03 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Task branch @1521a@ for review updated to revision @11138@.
The @expressions.rules@ updated to change the supporte... Eugenie Lyzenko

10:12 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Greg Shah wrote:
> @<rule>attrs.put(prog.kw_cur_iter, rw.cvt_lvl_full | rw.rt_lvl_partial)</rule>@ seems corre... Eugenie Lyzenko

09:21 AM Feature #1521: implement gap analysis rules or backing database/marker approach

@<rule>attrs.put(prog.kw_cur_iter, rw.cvt_lvl_full | rw.rt_lvl_partial)</rule>@ seems correct. Please put a co... Greg Shah

08:56 AM Feature #1521: implement gap analysis rules or backing database/marker approach

Rebased task branch @1251a@ from P2J trunk revision @11137@. Still no changes since branch creation. Eugenie Lyzenko

01:29 PM Feature #3225: windows vs linux in p2j.cfg.xml

> I will fix the separators definition also.
What do you mean?
I think the @file-separator@ and @path-separato... Greg Shah

01:22 PM Feature #3225: windows vs linux in p2j.cfg.xml

Greg Shah wrote:
> > OTOH, we force in the definition of propath parameters that are dependent on the current machin... Ovidiu Maxiniuc

01:06 PM Feature #3225: windows vs linux in p2j.cfg.xml

> so @file-separator@ and @path-separator@ are used by conversion to know how to parse the legacy strings found in co... Greg Shah

12:58 PM Feature #3225: windows vs linux in p2j.cfg.xml

OK, so @file-separator@ and @path-separator@ are used by conversion to know how to parse the legacy strings found in ... Ovidiu Maxiniuc

11:35 AM Feature #3225: windows vs linux in p2j.cfg.xml

> I might not have understand it fully, but I had the feeling that the propath, file-separator and path-separator fro... Greg Shah

11:30 AM Feature #3225: windows vs linux in p2j.cfg.xml

I might not have understand it fully, but I had the feeling that the @propath@, @file-separator@ and @path-separator@... Ovidiu Maxiniuc

11:15 AM Feature #3225: windows vs linux in p2j.cfg.xml

> please confirm, that these must be the legacy values as found on the OS where the legacy application was run, not w... Greg Shah

10:19 AM Feature #3225: windows vs linux in p2j.cfg.xml

Ovidiu, review for 3225a rev 11141 :
* beside the @basepath@ which must use file-separator specific to the OS where ... Constantin Asofiei