Project

General

Profile

Activity

From 02/13/2025 to 03/14/2025

03/14/2025

10:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Callgraph command on hotel GUI with the following @rootlist.xml@ :... Stefan Vieru
06:28 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I wonder if the call graph was actually being created on prior runs. You'll have to debug through that code unfortun... Greg Shah
05:11 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I tried building the graph again but i am getting am error and can't seem to get past it:... Stefan Vieru

03/13/2025

11:41 AM Support #9703: explore and document the existing OE IDE feature set

Thanks for the suggestions. I've updated the wiki to cover all of your remarks from the previous note besides the...
Florin Eugen Rotaru

03/12/2025

09:47 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
> aside from the fact that it defaults to cvt and it doesn't take the path from p2j.cfg.xml
That will need to be f...
Greg Shah
09:36 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Managed to finish running @callgraph@ without any errors on hotel with the following change:... Stefan Vieru
05:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I have made the suggested changes (rev 15768). About @getConversionFolder()@ it searches for a key in a map and defau... Stefan Vieru
07:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I tried to replace the @SchemaConfig$NsConfig.importFile@ with an Artifact, eventually I ended up noticing that the @... Dănuț Filimon

03/11/2025

04:55 PM Feature #5586 (WIP): move all conversion artifacts/outputs into the cvtdb or into a dedicated dir...
It is good work! Greg Shah
04:53 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Code Review Task Branch 5586a Revision 15767
1. In @getPathToConversionFolder(String filename, String postfix)@ pl...
Greg Shah
08:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Most of my changes revolve around utilizing the function i created which takes the path: @./<basepath>/filename@ and ... Stefan Vieru
08:37 AM Feature #5586 (Review): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...
Greg,
I will move this to Review. Could you take a look at my changes? I will wait for your feedback on them.
Than...
Stefan Vieru
08:29 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I created a branch 5586a and commited my changes at revision 15767. Stefan Vieru

03/10/2025

04:51 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Good. Greg Shah
10:34 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I created this function inside @Configuration@... Stefan Vieru
02:08 PM Support #9703: explore and document the existing OE IDE feature set
1st Pass Review
Overall, it is a good first step. Some more specific thoughts:
1. From the screenshots, it see...
Greg Shah
11:02 AM Support #9703: explore and document the existing OE IDE feature set
I have finished a first draft. Greg, can you take a look and tell me what you think? I think I should also add some c... Florin Eugen Rotaru
09:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Intermediate or output artifacts might have a link to a @SourceArtifact@ that they are created fr...
Dănuț Filimon
06:08 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> My next steps:
> * find more usages of FileList in drivers and replace them with artifacts
...
Dănuț Filimon
05:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/15741*. Initial implementation for replacing *FileList* usage with artifacts in the conversion proce... Dănuț Filimon

03/07/2025

09:30 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Constantin Asofiei wrote:
> Stefan Vieru wrote:
> > After copying @directory.hints@ now conversion is almost the sa...
Stefan Vieru
07:56 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
@.hints@ files are configuration files which are similar to "source" inputs. These should still reside in the source... Greg Shah
06:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan Vieru wrote:
> After copying @directory.hints@ now conversion is almost the same, tested on @hotel_gui@, outs...
Constantin Asofiei
06:02 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
After copying @directory.hints@ now conversion is almost the same, tested on @hotel_gui@, outside 2 differences:
@Fw...
Stefan Vieru
03:49 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan Vieru wrote:
> Greg, please let me know if you have any ideas about where should i look to fix this issue wit...
Stefan Vieru
02:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg, please let me know if you have any ideas about where should i look to fix this issue with the comments. Stefan Vieru
08:49 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
By "qualified", I mean a filename with a path. That path might be relative or absolute, we shouldn't care. Either w... Greg Shah
08:37 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> We want to have the qualified filenames (even for newly created artifacts) to be managed (and eve...
Dănuț Filimon
08:13 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
The idea here is to create a strong separation of concerns which will give us:
* consistency
* a clear implementa...
Greg Shah
08:11 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
We want to have the qualified filenames (even for newly created artifacts) to be managed (and even encapsulated) as m... Greg Shah
05:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Had an issue with the import process on the hotel app, it was looking for a file in @data/hotel.p2o@ in @gatherTarget... Dănuț Filimon
02:57 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> > The Iterator<Artifact> can't be reset., this is the only problem I can see with this idea.
>
...
Dănuț Filimon

03/06/2025

09:47 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
In regard to the @FileListFactory.createBlacklist()@ (and the whitelist processing), perhaps we should remove that su... Greg Shah
09:43 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> I've updated the code to use an ArticatCollection, some things I've remarked that might be of concern:
Understo...
Greg Shah
09:36 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
My objective here in using iterators is to ensure that the callers must go through the abtracted AM API instead of do... Greg Shah
09:35 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> The Iterator<Artifact> can't be reset., this is the only problem I can see with this idea.
Do we ever need to re...
Greg Shah
07:13 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I've updated the code to use an ArticatCollection, some things I've remarked that might be of concern:
* @Conversion...
Dănuț Filimon
02:25 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> > The alternative of the @FileList@ will be a list of @Artifact@ instances, this makes it difficu...
Dănuț Filimon
09:13 AM Feature #9727: enable -? to provide syntax help in the various driver programs
Use branch *7133a* for this work. Roger Borrello

03/05/2025

12:49 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> The alternative of the @FileList@ will be a list of @Artifact@ instances, this makes it difficult to refactor the P... Greg Shah
08:43 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I am making good progress on the hotel conversion, attached to this issue is the current state of the conversion proc... Dănuț Filimon
04:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I've reached a stable version here I can build the 7180a branch, but there are a lot of conversion/import issues whic... Dănuț Filimon
03:40 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Wherever we use a @FileList@ instance, we will need to refactor it to use the AM. For example, t...
Dănuț Filimon
08:35 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Wherever we use a @FileList@ instance, we will need to refactor it to use the AM. For example, the @TransformDriver.... Greg Shah
08:57 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Almost fixed the previous issue, now the code converts and i can start hotel_gui but i still have some comments left ... Stefan Vieru

03/04/2025

02:28 PM Support #9703: explore and document the existing OE IDE feature set
I think we need to target the most recent version in 12.x. Greg Shah
06:55 AM Support #9703: explore and document the existing OE IDE feature set
Florin, please avoid using snapshots from OE IDEs. Please refer to the version textually. Alexandru Lungu
06:35 AM Support #9703 (WIP): explore and document the existing OE IDE feature set
This is the Dev Studio and OE versions I have access to:
Progress Developer Studio 4.3
OpenEdge Release: 11.6.3
...
Florin Eugen Rotaru
10:27 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg, I am afraid I am going too deep into the idea of "using artifacts instead of FileList" so let me ask a question... Dănuț Filimon
06:19 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
It seems my next commit will take a while, currently working my way into the conversion and it's a lot more that I ex... Dănuț Filimon
04:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> I think that the @ArtifactManager@ (AM) should handle the creation and processing of the list, in...
Dănuț Filimon
05:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
After conversion I'm missing these functions:... Stefan Vieru
05:40 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Finalized conversion but now I get some errors when starting the client.
Stefan Vieru
03:22 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
The method referenced in #5586-15 looks like this:... Stefan Vieru
03:18 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I've found inside @frame_generator.xml@ the following function: ... Stefan Vieru

03/03/2025

12:12 PM Feature #9727: enable -? to provide syntax help in the various driver programs
Currently, our @ConversionDriver@/@ProgressTransformDriver@/@ReportDriver@ programs don't provide an easy way to get ... Greg Shah
12:06 PM Feature #9727 (New): enable -? to provide syntax help in the various driver programs
Greg Shah
12:03 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> Looking at the conversion driver I can simply pass the FileList as a parameter to the @ArtifactManager.createArtifa... Greg Shah
11:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> Is there an existent issue for this, or should I create one?
There isn't such a task. We can make the changes h...
Greg Shah
04:29 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Looking at the conversion driver I can simply pass the FileList as a parameter to the @ArtifactManager.createArtifact... Dănuț Filimon
04:00 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Thanks for the input, I plan to start modifying the ConversionDriver first to make use of the artifacts.
Greg Shah...
Dănuț Filimon
09:35 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Found the issue, forgot to put the suffix-adding code inside @com.goldencode.p2j.schema.P2OLookup#loadTemporarySchema... Stefan Vieru
08:50 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Inside @annotations/annotations@ my conversion fails when calling @[java] javaname = p2o.javaPropertyName(getNoteStri... Stefan Vieru
08:27 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Managed to finish middle part of the conversion with the new output directory but I'm facing issues, meaning that tem... Stefan Vieru

02/28/2025

09:43 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> If I want to have the artifacts available before any processing it's done (e.g. conversion, code analytics) as ment... Greg Shah
07:03 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I have more questions:
# If I want to have the artifacts available before any processing it's done (e.g. conversion,...
Dănuț Filimon
06:33 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/15740*. Added artifact classes, added functionalities to ArtifactManager. Dănuț Filimon
02:41 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> > Created @ArtifactHandler@ should extend @org.eclipse.jetty.server.handler.AbstractHandler@, ths...
Dănuț Filimon
01:46 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Understood, will look on how to adjust to @p2j.cfg.xml@.
Stefan Vieru

02/27/2025

12:15 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
In the FWD code, we should not use any properties. So all of the @build.properties@ stuff like @app.4gl.src@ or @cvt... Greg Shah
09:17 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg Shah wrote:
> It is a good test. Please note that while we do default to @cvt/@, we do allow this directory to...
Stefan Vieru
09:15 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Today I've looked through possible implications this kind of change might have. I have reached TransformDriver and wo... Stefan Vieru
09:13 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
It is a good test. Please note that while we do default to @cvt/@, we do allow this directory to be configured in @p... Greg Shah
02:30 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I have found that prefixing inside @com.goldencode.p2j.uast.JavaPatternWorker#generateJavaFilename(java.lang.String)@... Stefan Vieru
12:03 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> ... Greg Shah
11:57 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> Created @ArtifactHandler@ should extend @org.eclipse.jetty.server.handler.AbstractHandler@, thsi will be used to ha... Greg Shah
06:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
During the execution of the @ConversionDriver@, @FileSpecList@ is used to build the conversion list in @TransformDriv... Dănuț Filimon
05:18 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...
Thanks for the feedback Greg, I have a general idea on how I want to get into this now.
At the moment I did the fo...
Dănuț Filimon

02/26/2025

09:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> * The @Artifact@ will represent one of the items from the conversion list (a file for example), while the SourceArt... Greg Shah
07:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I looked over the added classes (@Artifact@, @SourceArtifact@ and @ArtifactManager@) and noted the followind:
* The ...
Dănuț Filimon
06:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/15737*, the branch is now at revision *15739*. Dănuț Filimon
09:30 AM Feature #5586 (WIP): move all conversion artifacts/outputs into the cvtdb or into a dedicated dir...
Started working on this.
Gathered firstly some information about what steps produce what files and where the file na...
Stefan Vieru

02/25/2025

01:57 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
All of my changes are committed into the branch. There is not much there. The core idea was to start separating the... Greg Shah
08:45 AM Support #9703: explore and document the existing OE IDE feature set
From creating/importing projects to editing code and schemata to compiling/building and debugging, please explore the... Greg Shah
08:43 AM Support #9703 (Closed): explore and document the existing OE IDE feature set
Greg Shah

02/24/2025

08:15 AM Feature #1757: update ANTLR to latest version
Here are some notes about potential lexer changes during the upgrade. As mentioned above, ANTLR v4 has a switchable ... Greg Shah
 

Also available in: Atom