Project

General

Profile

Activity

From 03/02/2025 to 03/31/2025

03/31/2025

07:25 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Are you modifying the PROPATH maps in FWD? I don't want to do this, just check at resol...
Eduard Soltan
05:52 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Are you modifying the PROPATH maps in FWD? I don't want to do this, just check at resolution time . Constantin Asofiei
05:34 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Eduard Soltan wrote:
>
> But I was think about something more general.
>
> I have a @src/oo/Foo.cls@ class whic...
Eduard Soltan

03/28/2025

09:50 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> If is included, then yes, go ahead and resolve it from that PROAPTH location. The probl...
Eduard Soltan
09:23 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Eduard Soltan wrote:
> > > This name duplication with 4gl bui...
Constantin Asofiei
09:22 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > This name duplication with 4gl buildin classes, or with custom...
Eduard Soltan
09:07 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Eduard Soltan wrote:
> This name duplication with 4gl buildin classes, or with custom classes (@src1/oo/Foo.cls and ...
Constantin Asofiei
09:03 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Greg Shah wrote:
> > In regard to the change itself, I wonder if we should put an addit...
Eduard Soltan
04:19 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Greg Shah wrote:
> In regard to the change itself, I wonder if we should put an additional protection into this code...
Constantin Asofiei
08:17 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...
Greg Shah wrote:
> 1. What is the purpose for @Artifact.get|setExtName()@? Is that supposed to be the fully qualifi...
Dănuț Filimon

03/27/2025

05:18 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Code Review Task Branch 7255a Revision 15821
The @file-cvt-list.txt@ is nothing something that is built into FWD. ...
Greg Shah
12:01 PM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Greg Shah wrote:
> Danut: Please review this change. I'd like if the approach we take here fits with our long term ...
Dănuț Filimon
11:44 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Danut: Please review this change. I'd like if the approach we take here fits with our long term concepts of #7180 an... Greg Shah
11:35 AM Bug #7255 (Review): FWD resolves a OO file not included in conversion, if it exists on disk and o...
Committed on 7255a, rev. 15821.
Added in @SymbolResolver@ a static set with conversion sources from @file-cvt-list...
Eduard Soltan
03:24 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Code Review Task Branch 7180a Revisions 15826 through 15828
The code is moving along nicely.
1. What is the pur...
Greg Shah
08:47 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...
Rebased *7180a* to latest *trunk/15823*, the branch is now at revision *15828*. Dănuț Filimon
08:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/15742*. I replaced all usages of FileList with ArtifactCollection, and only the ones remaining in th... Dănuț Filimon

03/26/2025

11:25 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Well in @SymbolResolver@ constructor there is a call to @initPossibleClasses@ where the following classes are mapped:... Eduard Soltan
10:56 AM Bug #7255 (WIP): FWD resolves a OO file not included in conversion, if it exists on disk and on P...
Eduard Soltan wrote:
> Should the classes defined in @abl@ folder be mapped in @SymbolResolver.WorkArea.propathClass...
Constantin Asofiei
10:51 AM Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Question:
Should the classes defined in @abl@ folder be mapped in @SymbolResolver.WorkArea.propathClassDicts@, and...
Eduard Soltan
08:59 AM Feature #8786: incremental schema conversion and updates
One customer (see #9288) uses "Liquibase":https://en.wikipedia.org/wiki/Liquibase to implement their incremental sche... Greg Shah

03/25/2025

11:08 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Updated this, ref 15808.
Added some changes that basically checks if:
@basepath@ is at the beginning of the filenam...
Stefan Vieru

03/21/2025

10:43 AM Feature #9822: artifacts that are shared project-wide should be moved into the cvtdb
A fair point.
In the specific case of the @name_map.xml@, we have good reason to eliminate the artifact completely...
Greg Shah
10:17 AM Feature #9822: artifacts that are shared project-wide should be moved into the cvtdb
> Human review and access is made much harder than simple text output in the filesystem. We would need some tools to ... Alexandru Lungu
10:06 AM Feature #9822: artifacts that are shared project-wide should be moved into the cvtdb
This is just one future approach to be considered. Using a database has pros and cons. Roughly:
* pros
** The i...
Greg Shah
10:00 AM Feature #9822: artifacts that are shared project-wide should be moved into the cvtdb
Artifacts that are shared project-wide should be moved into the cvtdb. For example, the @registry.xml@ and @name_map.... Stefan Vieru
09:59 AM Feature #9822 (New): artifacts that are shared project-wide should be moved into the cvtdb
Stefan Vieru
08:23 AM Support #9703 (WIP): explore and document the existing OE IDE feature set
Florin Eugen Rotaru
03:15 AM Support #9703: explore and document the existing OE IDE feature set
I will update my progress here.
✅ - done
❌ - not done
> * For each project type, please create a "hello world" p...
Florin Eugen Rotaru
07:33 AM Feature #5586 (Review): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...
Will put this back into review.
I added the latest commit in 5586a/15807.
Please let me know if there are some cha...
Stefan Vieru
05:23 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Made the following change:... Stefan Vieru
03:50 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Okay, will let this aside then. Will look into dropping @.lexer@ and @.parser@.
I see that those filed are enabled h...
Stefan Vieru

03/20/2025

02:15 PM Support #9703: explore and document the existing OE IDE feature set
> > * For each project type, please create a "hello world" project and gather all the artifacts including any configu... Greg Shah
10:38 AM Support #9703: explore and document the existing OE IDE feature set
Thanks for the review.
Greg Shah wrote:
> * For each project type, please create a "hello world" project and ga...
Florin Eugen Rotaru
10:29 AM Support #9703: explore and document the existing OE IDE feature set
I've reviewed the latest documentation. This is really good.
Next steps:
* For each project type, please creat...
Greg Shah
07:44 AM Support #9703: explore and document the existing OE IDE feature set
Alexandru Lungu wrote:
> Florin, please check Show View > Other section the IDE. It presents several views that can ...
Florin Eugen Rotaru
05:07 AM Support #9703: explore and document the existing OE IDE feature set
Florin, please check Show View > Other section the IDE. It presents several views that can be enabled in the applicat... Alexandru Lungu
12:51 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
> # Artifacts that are shared project-wide should be moved into the cvtdb. For example, the @registry.xml@ and @name... Greg Shah
10:26 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
After looking in @name_map@ i though about the following tables:... Stefan Vieru
04:31 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg Shah wrote:
> # Artifacts that are shared project-wide should be moved into the cvtdb. For example, the @regis...
Stefan Vieru
04:11 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I've modified this in @callgraph_lib.rules@ ... Stefan Vieru
08:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I managed to recover my changes and commit them to *7180a/15471* + the ones I wanted to commit originally (I hope the... Dănuț Filimon
06:49 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I think I can recover this from the .~1~ files that are created on the revert. Dănuț Filimon
06:48 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg, somehow I lost my commit from *7180a/15741* ...... Dănuț Filimon
05:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I managed to refactor a few points to avoid using @removeAll()@ from @ArtifactCollection@. I need to fix another scen... Dănuț Filimon

03/19/2025

11:42 AM Support #9703 (Review): explore and document the existing OE IDE feature set
Greg Shah wrote:
> * Web UI - If I understand correctly, this is just normal web UI development. I don't see why we...
Florin Eugen Rotaru
10:11 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I tried fixing #5586-41 and during debugging I've set the argument for @prepareFilename@ from @""@ to @"./abl/guests-... Stefan Vieru
09:43 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Constantin Asofiei wrote:
> Stefan Vieru wrote:
> > While debugging today I have found that what's failing right no...
Stefan Vieru
08:45 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan Vieru wrote:
> While debugging today I have found that what's failing right now the callgraph is this :
> [....
Constantin Asofiei
08:40 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
While debugging today I have found that what's failing right now the callgraph is this :... Stefan Vieru

03/18/2025

11:31 AM Support #9703: explore and document the existing OE IDE feature set
Constantin, I am trying to fill-in the gaps in this "table":https://proj.goldencode.com/projects/p2j/wiki/OpenEdge_ID... Florin Eugen Rotaru

03/14/2025

10:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Callgraph command on hotel GUI with the following @rootlist.xml@ :... Stefan Vieru
06:28 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I wonder if the call graph was actually being created on prior runs. You'll have to debug through that code unfortun... Greg Shah
05:11 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I tried building the graph again but i am getting am error and can't seem to get past it:... Stefan Vieru

03/13/2025

11:41 AM Support #9703: explore and document the existing OE IDE feature set

Thanks for the suggestions. I've updated the wiki to cover all of your remarks from the previous note besides the...
Florin Eugen Rotaru

03/12/2025

09:47 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
> aside from the fact that it defaults to cvt and it doesn't take the path from p2j.cfg.xml
That will need to be f...
Greg Shah
09:36 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Managed to finish running @callgraph@ without any errors on hotel with the following change:... Stefan Vieru
05:09 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I have made the suggested changes (rev 15768). About @getConversionFolder()@ it searches for a key in a map and defau... Stefan Vieru
07:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I tried to replace the @SchemaConfig$NsConfig.importFile@ with an Artifact, eventually I ended up noticing that the @... Dănuț Filimon

03/11/2025

04:55 PM Feature #5586 (WIP): move all conversion artifacts/outputs into the cvtdb or into a dedicated dir...
It is good work! Greg Shah
04:53 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Code Review Task Branch 5586a Revision 15767
1. In @getPathToConversionFolder(String filename, String postfix)@ pl...
Greg Shah
08:44 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Most of my changes revolve around utilizing the function i created which takes the path: @./<basepath>/filename@ and ... Stefan Vieru
08:37 AM Feature #5586 (Review): move all conversion artifacts/outputs into the cvtdb or into a dedicated ...
Greg,
I will move this to Review. Could you take a look at my changes? I will wait for your feedback on them.
Than...
Stefan Vieru
08:29 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I created a branch 5586a and commited my changes at revision 15767. Stefan Vieru

03/10/2025

04:51 PM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Good. Greg Shah
10:34 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I created this function inside @Configuration@... Stefan Vieru
02:08 PM Support #9703: explore and document the existing OE IDE feature set
1st Pass Review
Overall, it is a good first step. Some more specific thoughts:
1. From the screenshots, it see...
Greg Shah
11:02 AM Support #9703: explore and document the existing OE IDE feature set
I have finished a first draft. Greg, can you take a look and tell me what you think? I think I should also add some c... Florin Eugen Rotaru
09:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Intermediate or output artifacts might have a link to a @SourceArtifact@ that they are created fr...
Dănuț Filimon
06:08 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> My next steps:
> * find more usages of FileList in drivers and replace them with artifacts
...
Dănuț Filimon
05:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/15741*. Initial implementation for replacing *FileList* usage with artifacts in the conversion proce... Dănuț Filimon

03/07/2025

09:30 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Constantin Asofiei wrote:
> Stefan Vieru wrote:
> > After copying @directory.hints@ now conversion is almost the sa...
Stefan Vieru
07:56 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
@.hints@ files are configuration files which are similar to "source" inputs. These should still reside in the source... Greg Shah
06:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan Vieru wrote:
> After copying @directory.hints@ now conversion is almost the same, tested on @hotel_gui@, outs...
Constantin Asofiei
06:02 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
After copying @directory.hints@ now conversion is almost the same, tested on @hotel_gui@, outside 2 differences:
@Fw...
Stefan Vieru
03:49 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Stefan Vieru wrote:
> Greg, please let me know if you have any ideas about where should i look to fix this issue wit...
Stefan Vieru
02:48 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Greg, please let me know if you have any ideas about where should i look to fix this issue with the comments. Stefan Vieru
08:49 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
By "qualified", I mean a filename with a path. That path might be relative or absolute, we shouldn't care. Either w... Greg Shah
08:37 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> We want to have the qualified filenames (even for newly created artifacts) to be managed (and eve...
Dănuț Filimon
08:13 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
The idea here is to create a strong separation of concerns which will give us:
* consistency
* a clear implementa...
Greg Shah
08:11 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
We want to have the qualified filenames (even for newly created artifacts) to be managed (and even encapsulated) as m... Greg Shah
05:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Had an issue with the import process on the hotel app, it was looking for a file in @data/hotel.p2o@ in @gatherTarget... Dănuț Filimon
02:57 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> > The Iterator<Artifact> can't be reset., this is the only problem I can see with this idea.
>
...
Dănuț Filimon

03/06/2025

09:47 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
In regard to the @FileListFactory.createBlacklist()@ (and the whitelist processing), perhaps we should remove that su... Greg Shah
09:43 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> I've updated the code to use an ArticatCollection, some things I've remarked that might be of concern:
Understo...
Greg Shah
09:36 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
My objective here in using iterators is to ensure that the callers must go through the abtracted AM API instead of do... Greg Shah
09:35 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> The Iterator<Artifact> can't be reset., this is the only problem I can see with this idea.
Do we ever need to re...
Greg Shah
07:13 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I've updated the code to use an ArticatCollection, some things I've remarked that might be of concern:
* @Conversion...
Dănuț Filimon
02:25 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> > The alternative of the @FileList@ will be a list of @Artifact@ instances, this makes it difficu...
Dănuț Filimon
09:13 AM Feature #9727: enable -? to provide syntax help in the various driver programs
Use branch *7133a* for this work. Roger Borrello

03/05/2025

12:49 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> The alternative of the @FileList@ will be a list of @Artifact@ instances, this makes it difficult to refactor the P... Greg Shah
08:43 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I am making good progress on the hotel conversion, attached to this issue is the current state of the conversion proc... Dănuț Filimon
04:50 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I've reached a stable version here I can build the 7180a branch, but there are a lot of conversion/import issues whic... Dănuț Filimon
03:40 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Wherever we use a @FileList@ instance, we will need to refactor it to use the AM. For example, t...
Dănuț Filimon
08:35 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Wherever we use a @FileList@ instance, we will need to refactor it to use the AM. For example, the @TransformDriver.... Greg Shah
08:57 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Almost fixed the previous issue, now the code converts and i can start hotel_gui but i still have some comments left ... Stefan Vieru

03/04/2025

02:28 PM Support #9703: explore and document the existing OE IDE feature set
I think we need to target the most recent version in 12.x. Greg Shah
06:55 AM Support #9703: explore and document the existing OE IDE feature set
Florin, please avoid using snapshots from OE IDEs. Please refer to the version textually. Alexandru Lungu
06:35 AM Support #9703 (WIP): explore and document the existing OE IDE feature set
This is the Dev Studio and OE versions I have access to:
Progress Developer Studio 4.3
OpenEdge Release: 11.6.3
...
Florin Eugen Rotaru
10:27 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg, I am afraid I am going too deep into the idea of "using artifacts instead of FileList" so let me ask a question... Dănuț Filimon
06:19 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
It seems my next commit will take a while, currently working my way into the conversion and it's a lot more that I ex... Dănuț Filimon
04:02 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> I think that the @ArtifactManager@ (AM) should handle the creation and processing of the list, in...
Dănuț Filimon
05:52 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
After conversion I'm missing these functions:... Stefan Vieru
05:40 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Finalized conversion but now I get some errors when starting the client.
Stefan Vieru
03:22 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
The method referenced in #5586-15 looks like this:... Stefan Vieru
03:18 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
I've found inside @frame_generator.xml@ the following function: ... Stefan Vieru

03/03/2025

12:12 PM Feature #9727: enable -? to provide syntax help in the various driver programs
Currently, our @ConversionDriver@/@ProgressTransformDriver@/@ReportDriver@ programs don't provide an easy way to get ... Greg Shah
12:06 PM Feature #9727 (New): enable -? to provide syntax help in the various driver programs
Greg Shah
12:03 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> Looking at the conversion driver I can simply pass the FileList as a parameter to the @ArtifactManager.createArtifa... Greg Shah
11:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
> Is there an existent issue for this, or should I create one?
There isn't such a task. We can make the changes h...
Greg Shah
04:29 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Looking at the conversion driver I can simply pass the FileList as a parameter to the @ArtifactManager.createArtifact... Dănuț Filimon
04:00 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Thanks for the input, I plan to start modifying the ConversionDriver first to make use of the artifacts.
Greg Shah...
Dănuț Filimon
09:35 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Found the issue, forgot to put the suffix-adding code inside @com.goldencode.p2j.schema.P2OLookup#loadTemporarySchema... Stefan Vieru
08:50 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Inside @annotations/annotations@ my conversion fails when calling @[java] javaname = p2o.javaPropertyName(getNoteStri... Stefan Vieru
08:27 AM Feature #5586: move all conversion artifacts/outputs into the cvtdb or into a dedicated directory...
Managed to finish middle part of the conversion with the new output directory but I'm facing issues, meaning that tem... Stefan Vieru
 

Also available in: Atom