Activity

From 11/11/2025 to 12/10/2025

12/11/2025

08:04 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: > I looked more closely at the @YEAR_TRASH_MODE@ fragment and I still don’t fully understand why the lookahead is nee... Greg Shah

12/10/2025

02:46 PM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...: Alexandru, I think the first condition needs also to be:... Constantin Asofiei
09:32 AM Bug #10912 (Internal Test): Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" bec...: Created 10912a. Committed patch as rev. 16310.
This fixed the OG issue. Planning to run some tests. Alexandru Lungu
09:54 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Current status:
* #10816- duplicate getOriginalArtifact() call - fixed
* #10613 - testing passed, no issues
* #77... Dănuț Filimon
08:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Things are getting more complicated: ANTLR4 does not allow action blocks inside fragment ru... Paula Păstrăguș
04:35 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I’ll rename @SchemaLexer@ to @ProgressLexer@ (+ I'll keep the same structure of the progress.g grammar lexer into the... Paula Păstrăguș
04:30 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Paula Păstrăguș wrote:
> > * Fragment rules were introduced in ANTLR4. I haven’t yet creat... Paula Păstrăguș
04:17 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Another aspect we need to clarify is the equivalent for ANTLR2’s @LA() lookahead@ function. At the moment, I used @_i... Paula Păstrăguș
04:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: We will need a mechanism to replicate the old ANTLR2 @append()@ behavior and the @!@ operator when migrating to ANTLR... Paula Păstrăguș
04:00 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> * Fragment rules were introduced in ANTLR4. I haven’t yet created any, but they can be used... Paula Păstrăguș
01:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: You're right, this options block did the trick:... Paula Păstrăguș
06:05 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Branch 10919a was merged into trunk as rev. 16308 and archived.
Only a customer and ChUI scripts are left to be up... Dănuț Filimon
05:50 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I am merging 10919a now so that the trunk revision can be referenced. Dănuț Filimon

12/09/2025

09:57 AM Feature #9638: resolve OO dependencies during parsing using annotations in already converted classes: I think the overall idea of how to build up the class data is correct. My concerns with extending the @UsingType@ ar... Greg Shah
09:26 AM Feature #9638: resolve OO dependencies during parsing using annotations in already converted classes: I think the best place where we can introduce this idea is in @SymbolResolver.loadClass(String name, boolean topLevel... Octavian Adrian Gavril
06:39 AM Feature #9638 (WIP): resolve OO dependencies during parsing using annotations in already converte...: Octavian Adrian Gavril
09:46 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: > Kind of, we need that token for both, the parser and the lexer.
You should not define the tokens in the parser,... Greg Shah
09:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: A couple of housekeeping items:
* I would prefer if you are working on the @ProgressLexer@ and just use that direc... Greg Shah
09:18 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Hm, into the @SchemaLexer.tokens@, the value of @HEX_LITERAL@ is @1@, and into the @SchemaParser.tokens@, the value o... Paula Păstrăguș
09:01 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Kind of, we need that token for both, the parser and the lexer. But the int values will be different, depending on ho... Paula Păstrăguș
08:53 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: > in the lexer we reference @HEX_LITERAL@ and other 'artificial' tokens, tokens that do not correspond to any actual ... Greg Shah
08:33 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: As a side note, I feel that rewriting the grammar was actually the easy part, what comes next is where the real compl... Paula Păstrăguș
08:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I'm a bit confused... I initially thought that splitting the grammar would solve this issue. Let me explain the... Paula Păstrăguș
07:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: * The next step is to split the grammar into @SchemaParser.g4@ and @SchemaLexer.g4@. I realize the schema grammar nor... Paula Păstrăguș
04:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Committed the grammar as rev @16006@. Paula Păstrăguș
02:40 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> For the Progress lexer, I'd like to see the standalone @.g4@ file for it. It is hard for me to g... Paula Păstrăguș
09:18 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...: Dănuț Filimon
09:18 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: I plan to make the @getSiblingPath()@ patch after I am clearing up the testing, I already found 3 issues:
* Found a ... Dănuț Filimon
08:47 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: > I'll make it general and call it getSiblingPath() since the purpose of the method is to change a path to another (s... Greg Shah
08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 7180a Revision 16336
>... Dănuț Filimon
08:26 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Dănuț Filimon wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7180a Revision 16336
> >
> > Let's rename @A... Greg Shah
07:30 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...: Committed *7180a/16337-16338*, once for #4867 and once for FileExtensions usage/method renaming.
I plan to test th... Dănuț Filimon
04:42 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Code Review Task Branch 7180a Revision 16336
>
> Let's rename @AM.getPathToProjectFolderPojoFr... Dănuț Filimon
08:49 AM Bug #10569: Semicolon is skipped while preprocessing: I described the testing for all of 6859b. You can document that in #6859 itself. I don't see a reason to do separat... Greg Shah
08:44 AM Bug #10569: Semicolon is skipped while preprocessing: This approach should test only the changes related to this task or it should include all the changes from *6859b*? If... Octavian Adrian Gavril
08:29 AM Bug #10569: Semicolon is skipped while preprocessing: Greg Shah wrote:
> We can take this approach:
>
> # Run the front end on an application. Confirm there are no err... Octavian Adrian Gavril
08:24 AM Bug #10569: Semicolon is skipped while preprocessing: We can take this approach:
# Run the front end on an application. Confirm there are no errors.
# Compare the @.ca... Greg Shah
03:33 AM Bug #10569: Semicolon is skipped while preprocessing: What extra testing is needed for this issue? Should we run conversion of some apps? Octavian Adrian Gavril
08:35 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: Updated the antlr4 version to @4.13.2@ in rev @16005@. Paula Păstrăguș
08:27 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: > Currently we are using ANTLR @4.9.3@. Since #9687 is now merged into trunk, should I also update the ANTLR runtime ... Greg Shah
06:50 AM Feature #10190: Prototype the changes to the build to add ANTLR v4: I tested the build changes and everything appears to be in order. The only missing piece is the @src/com/goldencode/p... Paula Păstrăguș
03:30 AM Bug #10988: Extra quote is not generated during preprocessing when alternative for two quotes/apo...: Another example of what the current preprocessing work does is mentioned in #10569-25. Octavian Adrian Gavril
03:27 AM Bug #10988: Extra quote is not generated during preprocessing when alternative for two quotes/apo...: Take a look at this OE example:... Octavian Adrian Gavril
03:15 AM Bug #10988 (New): Extra quote is not generated during preprocessing when alternative for two quot...: Octavian Adrian Gavril
02:29 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> + Marian/Vladimir
Greg, all I can share about this is that we were only running `ABLUnit` in F... Marian Edu

12/08/2025

06:19 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Code Review Task Branch 7851a REvisions 16299 and 16300
The changes are good. Greg Shah
03:53 AM Feature #7851 (Internal Test): automatically add to conversion list all classes referenced via un...: Thank you Vladimir! I committed *7851a/16300* to address your review. Dănuț Filimon
05:26 PM Bug #10569 (Internal Test): Semicolon is skipped while preprocessing: Code Review Task Branch 6859b Revision 16145
The changes are good.
> Since the preprocessor tests are stable, i... Greg Shah
07:31 AM Bug #10569: Semicolon is skipped while preprocessing: I did some experiments that add an extra @'@ as OE does, but this changed how the lexer process next input. For examp... Octavian Adrian Gavril
03:46 PM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Code Review Task Branch 7180a Revision 16336
Let's rename @AM.getPathToProjectFolderPojoFromDmo()@ to something mo... Greg Shah
09:27 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Rebased *7180a* to latest *trunk/16304*, the branch is now at revision *16336*.
The good news is that the only co... Dănuț Filimon
08:48 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Greg Shah wrote:
> Really good. Minor feedback:
> 2. References to DMOs (e.g. JavaDoc for @pkgRootPath@) and Pojos... Dănuț Filimon
04:31 AM Feature #7180 (WIP): create a centralized manager for the conversion list and per-file/project st...: I am currently addressing the review. Dănuț Filimon
02:36 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: For the Progress lexer, I'd like to see the standalone @.g4@ file for it. It is hard for me to give feedback without... Greg Shah
09:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Today I worked on the lexer rules and tokens, which are the final missing piece of the schema migration puzzle.
Here... Paula Păstrăguș
09:36 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> Greg Shah wrote:
> > What do you mean by "lookahead hooks"? In both ANTLR2 and ANTLR4 we ... Greg Shah
09:29 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> What do you mean by "lookahead hooks"? In both ANTLR2 and ANTLR4 we can use @LT()@ to lookahead ... Paula Păstrăguș
02:31 PM Feature #10190: Prototype the changes to the build to add ANTLR v4: Paula: Please make sure to get the testing going from #10190-23. I'd like to close this out. Greg Shah

12/05/2025

06:13 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: I noticed I was not listed as a reviewer, though I have already completed the review.
7851a rev 16299 code review:... Vladimir Tsichevski
08:27 AM Feature #7851 (Review): automatically add to conversion list all classes referenced via unit test...: I committed *7851a/16299*. Addressed the #7851-12 review, removed the changes from SymbolResolver and added a loadPro... Dănuț Filimon
08:13 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: + Marian/Vladimir Greg Shah
03:19 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: ... Dănuț Filimon
12:18 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: > I have some good news: I’m very close to finishing the rewrite of the schema file. The remaining work is mainly to ... Greg Shah
10:42 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I have some good news: I’m very close to finishing the rewrite of the schema file. The remaining work is mainly to re... Paula Păstrăguș
09:49 AM Bug #6889 (Internal Test): rollback the files as 'unconverted' if (incremental) conversion fails.: Greg Shah wrote:
> Code Review Task Branch 6889a Revision 16269
>
> Literals like @".ast"@, @".p2o"@, @".jast"@, ... Dănuț Filimon
09:10 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: I changed the @% Done@ by mistake. The issue of this task is fixed. And the preprocessor tests have the same status a... Octavian Adrian Gavril
09:04 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing: Greg Shah
09:02 AM Bug #10569: Semicolon is skipped while preprocessing: I started to add new tests in [[p2j:Preprocessor Testcases]] but I found that we already have these cases in @tests/c... Octavian Adrian Gavril
07:57 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: I've committed new changes that completes the initial fix:
* I added an extra check for @LA(3)@ to avoid any excepti... Octavian Adrian Gavril

12/04/2025

08:29 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Code Review Task Branch 6889a Revision 16269
Literals like @".ast"@, @".p2o"@, @".jast"@, @".dict"@ should be @Ast... Greg Shah
08:23 AM Feature #7851 (WIP): automatically add to conversion list all classes referenced via unit test su...: Greg Shah
07:43 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: The TestSuite can specify both the @classes@ and @procedures@, so it's better to handle all of them rather than half.... Dănuț Filimon
08:10 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...: Code Review Task Branch 7180a Revisions 16267 through 16273
Really good. Minor feedback:
1. The @gen_fname@ fu... Greg Shah
08:06 AM Bug #10569: Semicolon is skipped while preprocessing: The cause of failing is this scenario: ... Octavian Adrian Gavril
07:28 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing: Unfortunately, there are 10 extra tests from @alternative_coding_test_set@ which failed with *6859b/16144*. I need to... Octavian Adrian Gavril
06:03 AM Bug #10569: Semicolon is skipped while preprocessing: Radu Apetrii wrote:
> Octavian Adrian Gavril wrote:
> > Radu, can you check if that's happening for your specific f... Radu Apetrii
05:56 AM Bug #10569: Semicolon is skipped while preprocessing: Please make sure that these cases have been added to the [[p2j:Preprocessor Testcases]] (unit tests).
All of the... Greg Shah
03:41 AM Bug #10569: Semicolon is skipped while preprocessing: Octavian Adrian Gavril wrote:
> Radu, can you check if that's happening for your specific file as well?
Yes, I'll w... Radu Apetrii
01:26 AM Bug #10569: Semicolon is skipped while preprocessing: The changes fix the testcase mentioned in #10569-1.
Radu, can you check if that's happening for your specific file... Octavian Adrian Gavril
07:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg Shah wrote:
> 3. We need to discuss the tree building. I think the idea of returning the created subtree from... Paula Păstrăguș

12/03/2025

06:50 PM Bug #10569 (Internal Test): Semicolon is skipped while preprocessing: Code Review Task Branch 6859b Revision 16144
This is really good. Greg Shah
10:09 AM Bug #10569: Semicolon is skipped while preprocessing: Greg, please review the changes. Octavian Adrian Gavril
09:45 AM Bug #10569 (Review): Semicolon is skipped while preprocessing: Apparently, in 4GL you can write two single/double quotes and the compiler will keep only one. 4GL seems to generate ... Octavian Adrian Gavril
06:42 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: Code Review Schema.g4
It is a good start and there is a lot to like about it. Some thoughts:
1. For an early P... Greg Shah
10:02 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I’ve attached the current @Schema.g4@ grammar. There are only a few rules implemented so far, but if you have s... Paula Păstrăguș
05:59 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Good plan. Greg Shah
03:34 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Just a quick note regarding my next steps: I’ll begin modifying the @schema.g@ file to migrate it to ANTLR4. Working ... Paula Păstrăguș
12:44 PM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Code Review Task branch 7851a Revision 16298
1. The string comparisons in @handleReferenceFiles()@ probably need t... Greg Shah
08:41 AM Feature #7851 (Review): automatically add to conversion list all classes referenced via unit test...: Committed *7851a/16298*. Added support for automatically adding procedures/classes referenced using the TestSuite ann... Dănuț Filimon
06:36 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> Dănuț Filimon wrote:
> > Greg, I think we'll need something similar to pre_scan_class in progres... Dănuț Filimon
06:14 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Dănuț Filimon wrote:
> Greg, I think we'll need something similar to pre_scan_class in progress.g, but for procedure... Greg Shah
06:09 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg, I think we'll need something similar to pre_scan_class in progress.g, but for procedures. What do you think? Dănuț Filimon
06:04 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: I managed to implement the fix for TestSuite that specifies classes:... Dănuț Filimon

12/02/2025

09:27 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: In the following code: ... Dănuț Filimon
06:59 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: Greg Shah wrote:
> > [...]. It is possible to extract the text from the STRING and turn it into a filename which can... Dănuț Filimon
07:46 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Committed xfer testcases/1817. Dănuț Filimon
07:39 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Committed *hotel_gui/419*, *hotel/186*. Fixed reports using the wrong location for AST resource.
ETF does not have... Dănuț Filimon
07:12 AM Bug #10919 (Merge Pending): the source/AST view is broken in the Analytics web UI: Go ahead and commit this to our Hotel projects.
Assuming all other customer projects are using an unmodified versi... Greg Shah
04:07 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I tested @ant report_server@, checked call graphs and reports. I found a single issue where the report log was in the... Dănuț Filimon
07:45 AM Bug #10569: Semicolon is skipped while preprocessing: Yes, that would probably be for the best. Greg Shah
07:34 AM Bug #10569: Semicolon is skipped while preprocessing: I think the work should be done in *6859b*, is that right? Octavian Adrian Gavril

12/01/2025

11:11 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: In regard to artificial nodes, it is true that some TRPL code will create them but the majority are created during th... Greg Shah
11:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: The shadow nodes should not be directly attached to the root. Here is an example:... Greg Shah
10:53 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: > [...]. It is possible to extract the text from the STRING and turn it into a filename which can be searched. Then m... Greg Shah
10:29 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Thanks Roger, is there any testing I can do aside from running the report server for Hotel?
... Greg Shah

11/28/2025

12:53 PM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Thanks Roger, is there any testing I can do aside from running the report server for Hotel?
... Roger Borrello
08:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Thank you, Ovidiu. I asked this because we need to create @helper methods@ that allow us to build the AST directly fr... Paula Păstrăguș
05:47 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: During the transpiling from 4GL to Java, FWD parser and TRPL rules will add these additional nodes. The semantic of t... Ovidiu Maxiniuc
04:15 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I have a question regarding artificial nodes. These are the nodes that the grammar creates manually, for example usin... Paula Păstrăguș
03:21 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Regarding the shadow nodes: the @left@ and @right@ IDs are used to locate the nearest AST node for each shadow node, ... Paula Păstrăguș
03:16 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Ovidiu Maxiniuc wrote:
> I do not think we should use @left@ and @right@. The resulting tree is not always binary.
... Paula Păstrăguș

11/27/2025

08:39 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I do not think we should use @left@ and @right@. The resulting tree is not always binary. One node may have multiple ... Ovidiu Maxiniuc
04:51 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Another thing I noticed: I added the shadows nodes to the list after the @left@ and @right@ IDs were populated, which... Paula Păstrăguș
04:24 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: During testing, I realized I forgot to assign the @parent AST@ to the shadow nodes. Right now, they’re orphans:), so ... Paula Păstrăguș
08:25 AM Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...: This @root@ is built in @ProgressParser.oea_annotation(), line 10017@:... Dănuț Filimon
06:36 AM Feature #7851 (WIP): automatically add to conversion list all classes referenced via unit test su...: Dănuț Filimon
05:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules: #6889 only has the changes for incremental conversion, making this available for all conversions is easy as it only r... Dănuț Filimon
02:58 AM Bug #10919 (Internal Test): the source/AST view is broken in the Analytics web UI: Thanks Roger, is there any testing I can do aside from running the report server for Hotel? Dănuț Filimon

11/26/2025

10:08 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Thanks, Greg, I had misunderstood that part. I’ve been working on adapting the @TreeLocal@, the @ShadowNode@, and the... Paula Păstrăguș
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Dănuț Filimon wrote:
> Roger Borrello wrote:
> > So you start the web server as: @./deploy/server/report.sh@?
>
... Roger Borrello
08:46 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Roger Borrello wrote:
> So you start the web server as: @./deploy/server/report.sh@?
No, like this: @~/gcd/branch... Dănuț Filimon
08:44 AM Bug #10919: the source/AST view is broken in the Analytics web UI: So you start the web server as: @./deploy/server/report.sh@? Roger Borrello
07:35 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Roger, this is the final patch:... Dănuț Filimon
07:05 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I'm OK with the idea. Please add comments to make it clear that the @ReportWebServer@ MUST be executed with the proj... Greg Shah
03:49 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I fixed this in the @report.sh@ script:... Dănuț Filimon
03:20 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.: I addressed the review from #6889-11 in *6889a/16269*.
Greg, please review. Dănuț Filimon

11/25/2025

10:11 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Above, I was saying @ReportDriver@ but that was a mistake. I meant @ReportWebServer@.
If the files are being read... Greg Shah
09:09 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Greg Shah wrote:
> > No, it will just remove home from the path. We already have home which is the relative path tha... Dănuț Filimon
08:53 AM Bug #10919: the source/AST view is broken in the Analytics web UI: > No, it will just remove home from the path. We already have home which is the relative path that we need, so I don'... Greg Shah
08:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Greg Shah wrote:
> Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that met... Dănuț Filimon
07:41 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Also, assuming @home@ is always the same value, can't @home = new File(home).getCanonicalPath();@ be calculated at st... Greg Shah
07:40 AM Bug #10919: the source/AST view is broken in the Analytics web UI: Won't this be a problem when we reach the @if (absolute.startsWith(home))@ code later in that method? Why not have t... Greg Shah
04:03 AM Bug #10919: the source/AST view is broken in the Analytics web UI: I've got @./abl/fwd-embedded-driver.p@ which is normalized to @./deploy/server/abl/fwd-embedded-driver.p@. My initial... Dănuț Filimon
07:55 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think you are conflating parse-time processing with TRPL-processing. During TRPL, the AST *must have* the shadow n... Greg Shah
05:54 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I reviewed the @hidden@ field, the @ShadowNode@ structure, and the entire @TreeLocal@ mechanism. The conclusion... Paula Păstrăguș
06:00 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.: Dănuț Filimon
06:00 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Greg Shah wrote:
> Code Review Task Branch 6889a Revisions 16267 and 16268
>
> 1. Shouldn't @cleanSources()@ be c... Dănuț Filimon

11/24/2025

10:34 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Aaand this is the output of a @dumpTree(true)@ for this input: @"1 + 2 * 3 + 4 * 5"@
Related java testing code:
<pr... Paula Păstrăguș
10:31 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I've pushed a new version of @10804a@. You should now be able to see the new classes. I've fully separated the ... Paula Păstrăguș
08:42 AM Bug #10928: Skip some parsing rules from runtime parsing: In #10919, Danut identified some cases where the conversion database was generated at run-time. This was because cert... Alexandru Lungu
08:35 AM Bug #10928 (New): Skip some parsing rules from runtime parsing: Alexandru Lungu
07:23 AM Bug #10919 (WIP): the source/AST view is broken in the Analytics web UI: The solution from #10919-6 is not correct, I tested it a little bit more and I ended up with @/home/ddf/gcd/branches/... Dănuț Filimon
04:10 AM Bug #10919 (Review): the source/AST view is broken in the Analytics web UI: Committed a simple fix to *10919a/16292*. The issue is with normalizeFilename(), the abnormal File is initialized wit... Dănuț Filimon
03:35 AM Bug #10919: the source/AST view is broken in the Analytics web UI: The error is the same one mentioned in #10784-1. Octavian found a workaround for this, but I will see if I can fix it. Dănuț Filimon
02:55 AM Bug #10919 (WIP): the source/AST view is broken in the Analytics web UI: I am investigating. Dănuț Filimon

11/21/2025

03:39 PM Bug #10919: the source/AST view is broken in the Analytics web UI: The @.cache@ and @.p.ast@ files do exist, but they are in @./cvt/@ instead of @./abl/@ which is probably the issue. Greg Shah
03:38 PM Bug #10919: the source/AST view is broken in the Analytics web UI: I suspect this is a bug from our recent #5586 changes.
Running reports in Hotel GUI completes properly. You can l... Greg Shah
03:30 PM Bug #10919 (Test): the source/AST view is broken in the Analytics web UI: Greg Shah
10:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I updated the wiki and pushed the new interface and implementation to 10804a. You should now be able to access ... Paula Păstrăguș
08:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Yes, you’re right! I’ll take care of it. Really appreciate the detailed guidance. Paula Păstrăguș
08:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> My suggestion is to wait until the end of the day, so I can finish covering most of the met... Greg Shah
07:56 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Paula Păstrăguș wrote:
> I think creating a table will help clarify things for both of us. At this point, I’ve gone ... Greg Shah
05:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: My suggestion is to wait until the end of the day, so I can finish covering most of the methods, prepare the comparis... Paula Păstrăguș
04:49 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: I think creating a table will help clarify things for both of us. At this point, I’ve gone through the ascent/descent... Paula Păstrăguș
03:12 AM Feature #10804 (WIP): create replacement AST implementation for use with ANTLR 4: Greg, I attached the ZIP containing the test project. Inside you will find both approaches: the visitor-based impleme... Paula Păstrăguș
10:02 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Code Review Task Branch 6889a Revisions 16267 and 16268
1. Shouldn't @cleanSources()@ be called at the end of @pro... Greg Shah
08:47 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: Committed a null check in *6889a/16268*. Dănuț Filimon
08:36 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: I got a few questions:
* Considering #7318/#7179, should we remove files from conversion even if we are not running ... Dănuț Filimon
05:56 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.: Committed *6889a/16267*. Rollback source files that failed processing during incremental conversion.
Greg, please ... Dănuț Filimon
08:57 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...: Alex, the fix is this:... Constantin Asofiei
06:53 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...: My change seems to be too old to not be included in 7156e, so I suspect it is a later change.... Șerban Bursuc
06:50 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...: ... Alexandru Lungu
06:47 AM Bug #10912 (Test): Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "cal...: Alexandru Lungu
08:13 AM Bug #4867 (Test): Incremental conversion: change detection algorithm ignores .hints and .ext-hint...: Branch 4867a was merged into trunk as rev. 16290 and archived. Dănuț Filimon
07:48 AM Bug #4867 (Merge Pending): Incremental conversion: change detection algorithm ignores .hints and ...: Merge after 10695a. Greg Shah
04:08 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: Tested the customer application, no issues found. *4867a* can be merged. Dănuț Filimon
06:33 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules: Constantin Asofiei wrote:
> Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are eith... Dănuț Filimon
06:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules: Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are either some commented code or abe... Constantin Asofiei

11/20/2025

09:12 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: Customer conversion will be complete tomorrow morning, I'll be able to test incremental then and confirm the fix. Dănuț Filimon

11/19/2025

04:56 PM Feature #10804: create replacement AST implementation for use with ANTLR 4: > I’m not sure how this translates to the Progress grammar for example, since the grafting logic there depends much ... Greg Shah
11:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4: Greg, I’m still a bit unclear on how to properly test these changes. I created a small separate project with a simple... Paula Păstrăguș

11/18/2025

06:22 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: Please test at least one of the large customer GUI applications. As Vladimir notes, the @.ext-hints@ are used there ... Greg Shah
05:26 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: Dănuț Filimon wrote:
> I tested ChUI conversion and incremental and found no issues, are there any other projects th... Vladimir Tsichevski
04:28 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: I tested ChUI conversion and incremental and found no issues, are there any other projects that use hint files? Dănuț Filimon
06:20 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: For the rest of the incremental conversion process, I though of letting the PatternEngine.run() throw and catch error... Dănuț Filimon

11/17/2025

09:40 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files: Committed *4867a/16237* to add a comment. Dănuț Filimon
08:52 AM Bug #4867 (Internal Test): Incremental conversion: change detection algorithm ignores .hints and ...: Code Review Task branch 4867a Revision 16236
The changes are good.
In @mustConvertFile()@, before line 818 (@if... Greg Shah

11/13/2025

03:13 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.: If incremental conversion fails during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ pha... Dănuț Filimon

11/12/2025

08:49 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.: Dănuț Filimon
06:17 AM Bug #10850: getAst() usage from TRPL must be read-only: Greg, the idea here is to mark ASTs returned by @getAst@ as read-only but only if this is a @ProgressAst@ - the other... Constantin Asofiei
05:47 AM Bug #10850: getAst() usage from TRPL must be read-only: There's a scenario where @getAst()@ using the id of a tree, then that ast is modified. The ast can be modified, but t... Dănuț Filimon
05:34 AM Bug #10850 (New): getAst() usage from TRPL must be read-only: Dănuț Filimon

11/11/2025

03:03 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes: Ovidiu Maxiniuc wrote:
> If we 'merge' using a key formed only from @fileId, astId@, this structure will be able to ... Octavian Adrian Gavril

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Conversion Tools

Activity

Activity

12/11/2025

12/10/2025

12/09/2025

12/08/2025

12/05/2025

12/04/2025

12/03/2025

12/02/2025

12/01/2025

11/28/2025

11/27/2025

11/26/2025

11/25/2025

11/24/2025

11/21/2025

11/20/2025

11/19/2025

11/18/2025

11/17/2025

11/13/2025

11/12/2025

11/11/2025