Project

General

Profile

Activity

From 04/18/2025 to 05/17/2025

05/16/2025

10:37 AM Support #6860: lexer tests
OK, that is reasonable. Greg Shah
10:29 AM Support #6860: lexer tests
Slight change committed to *6860a/15891*:
We shall test the keywords in the following way:
instead of
@java...
Florin Eugen Rotaru

05/15/2025

09:31 AM Support #6860 (Review): lexer tests
I have finished adding the features to the @LexerTestDriver@:
1. Added the option to pass a keyword-ignore file (u...
Florin Eugen Rotaru

05/14/2025

07:27 AM Support #6860: lexer tests
Greg Shah wrote:
>Why not just add some logic to check if the token type for the keyword is between @BEGIN_RESERVED@...
Florin Eugen Rotaru
07:17 AM Support #6860: lexer tests
This would require that we run the parser for lexer tests. We can do that, but seems a bit complicated. Why not jus... Greg Shah

05/13/2025

02:57 PM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> * _"While the Harness has decent documentation, we have no documentation, standards or examples for things outside ... Greg Shah
10:46 AM Support #6860: lexer tests
Greg, I looked into testing the reserved/unreserved keyword for FWD by defining variables. I'm thinking of checking t... Florin Eugen Rotaru
06:12 AM Support #6860: lexer tests
> Branch 6860a passed the regression tests on ChUI and Hotel conversions, but I'm thinking we could delay the merge s... Greg Shah

05/09/2025

09:04 AM Support #6860: lexer tests
Branch 6860a passed the regression tests on ChUI and Hotel conversions, but I'm thinking we could delay the merge sin... Florin Eugen Rotaru
06:30 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> I committed to xfer testcases rev 1751 a simple Harness ChUI testcase that was tested and tha...
Tomasz Domin

05/08/2025

06:48 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Greg, I think this concludes #9844-8, besides waiting for other users to test. What I'm looking at doing next from #9... Șerban Bursuc
06:30 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I committed to xfer testcases rev 1751 a simple Harness ChUI testcase that was tested and that works on Linux and Win... Șerban Bursuc

05/07/2025

11:28 AM Support #6860: lexer tests
> Besides making sure it's safe to run many tests in parallel and actually running them with harness test plans, no t... Greg Shah
04:10 AM Support #6860: lexer tests
Marian Edu wrote:
> There are some basic expression 'literals' tests in @tests/expressions/TestLiterals@, quoted v...
Florin Eugen Rotaru
04:01 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a Revision 15888
>
> The code is good.
>
> The changes are pret...
Florin Eugen Rotaru

05/06/2025

10:45 AM Support #6860: lexer tests
Greg Shah wrote:
> > quoted values aren't allowed for dates
>
> There is an exception to this. In OE (and FWD), ...
Marian Edu
10:29 AM Support #6860 (Internal Test): lexer tests
Code Review Task Branch 6860a Revision 15888
The code is good.
The changes are pretty safe. What testing has b...
Greg Shah
10:26 AM Support #6860: lexer tests
> quoted values aren't allowed for dates
There is an exception to this. In OE (and FWD), the @INITIAL@ clause of ...
Greg Shah
10:21 AM Support #6860: lexer tests
Greg Shah wrote:
> Feedback on the tests:
>
> * The date tests are missing a large number of cases that can be fo...
Marian Edu
10:16 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a REvision 15887
>
> Please remove @import com.goldencode.p2j.uast...
Florin Eugen Rotaru
09:57 AM Support #6860: lexer tests
Code Review Task Branch 6860a REvision 15887
Please remove @import com.goldencode.p2j.uast.LexerOptions;@ from @Le...
Greg Shah
09:24 AM Support #6860: lexer tests
Greg Shah wrote:
> Code Review Task Branch 6860a Revisions 15884 through 15886
>
> @LexerTestDriver@:
>
> * us...
Florin Eugen Rotaru
08:43 AM Support #6860: lexer tests
Please rename @LexerTestOptions@ to @LexerOptions@ and move it back to the @uast@ package so that we don't have refer... Greg Shah
08:38 AM Support #6860: lexer tests
Code Review Task Branch 6860a Revisions 15884 through 15886
@LexerTestDriver@:
* use wildcard imports
* add ja...
Greg Shah
08:26 AM Support #6860: lexer tests
Feedback on the tests:
* The date tests are missing a large number of cases that can be found in @date.main()@. W...
Greg Shah
06:48 AM Support #6860: lexer tests
For some reason, the previous commit did not push the files. I did another commit (see #1889-12) and it succeeded.
...
Florin Eugen Rotaru
06:46 AM Feature #1889 (WIP): rework the date.java internal tests as real unit tests
Florin Eugen Rotaru
06:46 AM Feature #1889: rework the date.java internal tests as real unit tests
Greg Shah wrote:
> In addition to moving these tests into ABLUnit, please create lexer tests for each of the literal...
Florin Eugen Rotaru

05/05/2025

10:05 AM Feature #1889: rework the date.java internal tests as real unit tests
I commited to @tests/primitive_type/date/@ the classes @MdyDateTests.cls@, @YmdDateTests.cls@ which contain one Test ... Florin Eugen Rotaru

05/03/2025

01:09 PM Feature #1889: rework the date.java internal tests as real unit tests
Additionally, there are several standard non-4GL JUnit5 test classes within the FWD framework, located in the @test/@... Vladimir Tsichevski
12:54 PM Feature #1889: rework the date.java internal tests as real unit tests
There are also a number of 4GL test classes I wrote for @DATE@ type and date @FILL-IN@-related issues. Some are linke... Vladimir Tsichevski
10:12 AM Feature #1889: rework the date.java internal tests as real unit tests
In addition to moving these tests into ABLUnit, please create lexer tests for each of the literal values AND ensure t... Greg Shah

04/30/2025

05:04 AM Support #6860 (Review): lexer tests
Florin Eugen Rotaru wrote:
> I have pushed all the tests we have so far on @testcases/tests/conversion/lexer@. I wil...
Florin Eugen Rotaru

04/25/2025

02:51 AM Support #6860: lexer tests
I have pushed all the tests we have so far on @testcases/tests/conversion/lexer@. I will write harness test plans for... Florin Eugen Rotaru

04/23/2025

05:28 PM Bug #9338 (Closed): Import JUnit test report back into Harness
Greg Shah
05:25 PM Bug #9338: Import JUnit test report back into Harness
Greg Shah wrote:
> This can be closed, right?
Yes please
Tomasz Domin
01:58 PM Bug #9338: Import JUnit test report back into Harness
This can be closed, right? Greg Shah
09:51 AM Bug #9338 (Internal Test): Import JUnit test report back into Harness
Tomasz Domin
09:50 AM Bug #9338: Import JUnit test report back into Harness
Updated [[Harness:Documentation]] to include @junit-import@ test. Tomasz Domin
10:16 AM Support #6860: lexer tests
I tried writing some tests using a different approach. Bottom up, I took small rules and wrote tests for each of thei... Florin Eugen Rotaru
05:21 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Greg Shah wrote:
> > The problem is there is no option to specify expected screen text file encoding.
>
> We shou...
Tomasz Domin

04/22/2025

11:02 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> The problem is there is no option to specify expected screen text file encoding.
We should add this.
Greg Shah
10:56 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Greg Shah wrote:
> Shouldn't we allow multibyte characters to be matched in screens? Using @?@ isn't a proper test....
Tomasz Domin
10:41 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Shouldn't we allow multibyte characters to be matched in screens? Using @?@ isn't a proper test. Greg Shah
10:38 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> > - terminal encoding - you can set a proper terminal encoding with -encoding command line op...
Tomasz Domin
10:30 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
> - terminal encoding - you can set a proper terminal encoding with -encoding command line option - default is ISO_88... Șerban Bursuc
10:24 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Șerban Bursuc wrote:
> Any idea why Harness doesn't correctly read the terminal screen buffer?
>
> !9844_incorrec...
Tomasz Domin
09:58 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Any idea why Harness doesn't correctly read the terminal screen buffer?
!9844_incorrect_screen_buffer.png!
I th...
Șerban Bursuc
09:38 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I finally found the problem. The @client.cmd@ output is *piped* to a log file in the @hotel_gui@ batch script (note: ... Șerban Bursuc
09:03 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
The Windows @ChUI@ mode was tested in Windows console, not in @PowerShell@. I do not have a experience for using @Pow... Eugenie Lyzenko
08:36 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
But this is not a real fix for @chui_native@, as the Harness needs to use the allocated terminal, so probably will ne... Șerban Bursuc
08:29 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
Eugenie, I don't know whether I missed some FWD configuration but there was indeed a problem in @terminal_win.c@.
...
Șerban Bursuc
05:56 AM Support #9844: finalize approach/techniques/standards for automating ABLUnit interactive UI tests
I debugged the exception and the failing point is somewhere in the native code, the symptom is that the terminal outp... Șerban Bursuc
 

Also available in: Atom