FWD » Bugs

04/03/2016

06:05 PM Bug #2483: Fix issues identified by static code analysis

CTRL-C part passed OK. Igor Skornyakov

05:00 PM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> Igor, assuming the others are OK with the changes and regression testing is successful, plea... Igor Skornyakov

04:58 PM Bug #2483: Fix issues identified by static code analysis

Code review 2483a/10999:
The changes look OK to me.
Greg, Constantin: please confirm the changes to your files ... Eric Faulhaber

04:47 PM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> True, but that's the case for @java.util.Map<K,V>.entrySet()@ as well (after which these API... Igor Skornyakov

04:44 PM Bug #2483: Fix issues identified by static code analysis

True, but that's the case for @java.util.Map<K,V>.entrySet()@ as well (after which these APIs were modelled). Eric Faulhaber

04:37 PM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > What's the point to use @HashSet<Map.Entry<K, V>>@ instead of @H... Igor Skornyakov

04:30 PM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> What's the point to use @HashSet<Map.Entry<K, V>>@ instead of @HashMap<K,V>@?
The API in t... Eric Faulhaber

03:08 PM Bug #2483: Fix issues identified by static code analysis

Fixed a found.
Committed to the task branch 2483a revision 10999.
Restarted regression testing. Igor Skornyakov

02:38 PM Bug #2483: Fix issues identified by static code analysis

Finished with the next round of issues.
Committed to the task branch 2483a revision 10998.
Started regression ... Igor Skornyakov

06:52 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> The Findbugs complains about 3 places in the @ScopedDictionary@ class (statement @foo.addA... Igor Skornyakov

06:37 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Regarding previous note:
> What's the point to use @HashSet<Map.Entry<K, V>>@ instead of ... Igor Skornyakov

06:05 AM Bug #2483: Fix issues identified by static code analysis

Regarding previous note:
What's the point to use @HashSet<Map.Entry<K, V>>@ instead of @HashMap<K,V>@?
Thank you. Igor Skornyakov

05:58 AM Bug #2483: Fix issues identified by static code analysis

The Findbugs complains about 3 places in the @ScopedDictionary@ class (statement @foo.addAll(dictionary.entrySet())@... Igor Skornyakov

04/02/2016

04:24 PM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> If anyone has further contributions on any of the current items under discussion, please exp... Igor Skornyakov

04:20 PM Bug #2483: Fix issues identified by static code analysis

If anyone has further contributions on any of the current items under discussion, please express those ASAP. This inc... Eric Faulhaber

04/01/2016

02:37 PM Bug #2483: Fix issues identified by static code analysis

> > My review for 2483a rev 10995:
> > # @ExpressionConversionWorker.expressionType:1056@ - adding the @stype = expr... Greg Shah

11:58 AM Bug #2483: Fix issues identified by static code analysis

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > # @AclRow.equals@ - non symmetric e.g. when comparing @AclRo... Igor Skornyakov

10:58 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Hynek Cihlar wrote:
>
> > Well, in case the @owner@ is @null@ (which must never happen f... Eugenie Lyzenko

08:54 AM Bug #2483: Fix issues identified by static code analysis

Hynek Cihlar wrote:
> Well, in case the @owner@ is @null@ (which must never happen for overlay windows by the way)... Igor Skornyakov

08:50 AM Bug #2483: Fix issues identified by static code analysis

Constantin Asofiei wrote:
> My review for 2483a rev 10995:
> # @ExpressionConversionWorker.expressionType:1056@ - a... Igor Skornyakov

06:41 AM Bug #2483: Fix issues identified by static code analysis

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > My review for 2483a rev 10995:
> > 4 @ConfigSyncManager@ - thi... Constantin Asofiei

06:35 AM Bug #2483: Fix issues identified by static code analysis

Constantin Asofiei wrote:
> My review for 2483a rev 10995:
> 4 @ConfigSyncManager@ - this class is not only client-... Hynek Cihlar

06:13 AM Bug #2483: Fix issues identified by static code analysis

My review for 2483a rev 10995:
# @ExpressionConversionWorker.expressionType:1056@ - adding the @stype = expressionTy... Constantin Asofiei

05:25 AM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> If you think any are serious, then yes. Based on your earlier assessment of the remaining fi... Igor Skornyakov

04:50 AM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> Code review 2483a/10992:
>
> Lots of good changes. Also lots of format problems. Some com... Igor Skornyakov

12:00 AM Bug #2483: Fix issues identified by static code analysis

Code review 2483a/10992:
Lots of good changes. Also lots of format problems. Some comments on substance:
* I do... Eric Faulhaber

03/31/2016

06:27 PM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Eric,
> Should I continue fixing issues reported by Findbugs/Eclipse static code analysis?... Eric Faulhaber

06:19 PM Bug #2483: Fix issues identified by static code analysis

Eric,
Should I continue fixing issues reported by Findbugs/Eclipse static code analysis?
Thank you. Igor Skornyakov

01:47 PM Bug #2483: Fix issues identified by static code analysis

The task branch 2483a was rebased from the trunk revision 10990. Committed to revision 10992. Igor Skornyakov

12:33 PM Bug #2483: Fix issues identified by static code analysis

Fixed the 'old' issues from this task and some of the 'new' ones. The issues from #3002 have been fixed as well (thos... Igor Skornyakov

10:45 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Well, it doesn't address the NPE issue by itself. However using of the AtomicInteger will m... Eric Faulhaber

10:36 AM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> > May be it better to use AtomicInteger instead of Integer? This will be more efficient. The... Igor Skornyakov

10:27 AM Bug #2483: Fix issues identified by static code analysis

> I mean that we often use == for comparing float point data in our code (e.g. for sizes and coordinates). This looks... Greg Shah

10:22 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > > @GlobalEventManager@ - possible @NPE@ in the @updateEntityRefC... Eric Faulhaber

10:10 AM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> > OK. What about comparing float primitives (coordinates, sizes) for an equality (==)?
> Th... Igor Skornyakov

10:08 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > > @FloatConstant.equals@ - non-transitive. The idea is understan... Eric Faulhaber

07:51 AM Bug #2483: Fix issues identified by static code analysis

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Constantin Asofiei wrote:
> > > > # @AdminLogon@ - non safe... Igor Skornyakov

07:49 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > > # @AdminLogon@ - non safe assignment to @logon@ static fie... Constantin Asofiei

07:42 AM Bug #2483: Fix issues identified by static code analysis

Constantin Asofiei wrote:
> > # @AdminLogon@ - non safe assignment to @logon@ static field; assignment to an argumen... Igor Skornyakov

07:32 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> # @AclRow.equals@ - non symmetric e.g. when comparing @AclRow@ instance with other non @Acl... Constantin Asofiei

07:27 AM Bug #2483: Fix issues identified by static code analysis

Greg Shah wrote:
> > TemporaryAccountPool uses synchronization on the a pool variable which is ConcurrentLinkedQueue... Igor Skornyakov

07:26 AM Bug #2483: Fix issues identified by static code analysis

> TemporaryAccountPool uses synchronization on the a pool variable which is ConcurrentLinkedQueue.
Yes, the synchr... Greg Shah

05:08 AM Bug #2483: Fix issues identified by static code analysis

Eric Faulhaber wrote:
> Don't know. Greg?
> > @RouterSessionManager.deregisterSession@: checks @queue@ variable for... Igor Skornyakov

12:00 AM Bug #2483: Fix issues identified by static code analysis

Igor Skornyakov wrote:
> @TemporaryAccountPool@ uses synchronization on the a @pool@ variable which is @ConcurrentLi... Eric Faulhaber

03/30/2016

06:54 PM Bug #2483: Fix issues identified by static code analysis

I've fixed a number of issues(and some additional ones). Will commit the changes tomorrow morning after adding histor... Igor Skornyakov

10:31 AM Bug #3045: Clean up localedef warnings for en_US@p2j_basic locale

When compiling the current version of the *en_US@p2j_basic* locale the following warnings are generated:... Igor Skornyakov

10:28 AM Bug #3045 (New): Clean up localedef warnings for en_US@p2j_basic locale

Igor Skornyakov

03/24/2016

07:40 AM Bug #2483: Fix issues identified by static code analysis

Created task branch 2483a Igor Skornyakov

11:25 PM Bug #2483: Fix issues identified by static code analysis

Igor, I'm not sure if @ias_upd20150109a.zip@ was ever integrated into P2J. If not, please integrate these changes int... Eric Faulhaber

03/23/2016

05:24 PM Bug #1445 (Closed): browse column name misconversion (an explicit column label should override th...

Greg Shah