Project

General

Profile

Activity

From 11/07/2012 to 12/06/2012

12/06/2012

03:37 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
_*TextOps class*_
I'm attaching an update containing:
- the TextOps class including fields and (static and some uti...
Adrian Lungu
03:22 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
02:54 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
You mean the current conversion "C:\Windows\system;C:\Users\Eugenie\bin;" to "C:Windowssystem;C:Users\033ugenie\bin;"... Eugenie Lyzenko
02:32 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
3. Yes, what I see in 4GL is predefined Progress-specific path. The code to display PROPATH:... Eugenie Lyzenko
02:23 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
1. The conversion of string literals when the target is Windows, should already double up the \ characters, but in th... Greg Shah
02:09 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Make sure your p2j.cfg.xml is properly setup for Windows conversions. This should not be happening.
The p2j.cfg....
Eugenie Lyzenko
10:53 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
02:52 PM Base Language Feature #1611: implement QUOTER utility
Tested for
to see the values from readFile.read() when the logic gets to them...
Costin Savin
12:35 PM Base Language Feature #1611: implement QUOTER utility
available() just tells you if you are going to block or not on a read. If it returns > 0 then you will not block if ... Greg Shah
11:58 AM Base Language Feature #1611: implement QUOTER utility
The case I'm refferring to is when readFile is a BufferedReader pointing to System.in, in case readFile points to a f... Costin Savin
11:29 AM Base Language Feature #1611: implement QUOTER utility
I don't understand how the readFile.read() can help in this case. If readLine() returns null but you are not at EOF,... Greg Shah
11:09 AM Base Language Feature #1611: implement QUOTER utility
Actually this is the problem
readFile.readLine()) can return null if the stream hasn't put anything on yet and in th...
Costin Savin
11:02 AM Base Language Feature #1611: implement QUOTER utility
... Greg Shah
10:30 AM Base Language Feature #1611: implement QUOTER utility
The readFile is a BufferedReader obtained in this way:... Costin Savin
10:10 AM Base Language Feature #1611: implement QUOTER utility
Looking closer at the FileStream sub-class (which is the closest match) I don't think there is an easy way to turn a ... Greg Shah
10:01 AM Base Language Feature #1611: implement QUOTER utility
Which Stream can I use?
Looking at the com.goldencode.p2j.util.Stream implementations:
*FileStream* constructor...
Costin Savin
09:19 AM Base Language Feature #1611: implement QUOTER utility
How about using one of the com.goldencode.p2j.util.Stream sub-classes to read the input? We have already written thi... Greg Shah
09:10 AM Base Language Feature #1611: implement QUOTER utility
1. You are right about the conversion settings I had them for Unix, will add the logic to handle this case.
2. Nor...
Costin Savin
08:19 AM Base Language Feature #1611: implement QUOTER utility
... Greg Shah
10:28 AM Database Feature #1910: add schema conversion support for sequences
Please make this issue your highest priority (including the import of current sequence values). We need to deliver a ... Eric Faulhaber
10:23 AM Database Feature #1910: add schema conversion support for sequences
Taking into consideration that the rules are more or less the same, a couple of hours should be enough to move the so... Ovidiu Maxiniuc
09:53 AM Database Feature #1910: add schema conversion support for sequences
I'm sorry, but in my review of your initial updates, I didn't notice that you were generating the sequence DDL from t... Eric Faulhaber
02:35 AM Database Feature #1910: add schema conversion support for sequences
I observed yesterday that the converted data dictionary file .p2o does not contains any reference to the sequence. Th... Ovidiu Maxiniuc
08:57 AM Database Feature #1580: upgrade Hibernate to latest level
About "Found two representations". After I've inserted the following code right after deletion of the target item the... Stanislav Lomany
02:09 AM Database Feature #1580: upgrade Hibernate to latest level
> Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but ... Stanislav Lomany
08:41 AM Base Language Feature #1920: implement persistent procedures
We have task #1634 which is where we will work on the rest of the native procedure support. I agree with your plan f... Greg Shah
02:39 AM Base Language Feature #1920: implement persistent procedures
My conclusions about native-procedure (PROCEDURE ... EXTERNAL cases) are:
* when a 4GL external procedure has a head...
Constantin Asofiei
08:38 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Please look at #1920-41 and the related prior notes for some very useful information regarding native procedures. Greg Shah

12/05/2012

05:38 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The following features were confirmed as working in native 4GL in Windows:
FILE-INFO:FILE-CREATE-DATE file_system_tr...
Eugenie Lyzenko
05:35 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Several notes for PROPATH get/set functionality
1. The P2J converts, compile and run the PROPATH statement.
2. The ...
Eugenie Lyzenko
03:03 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Yes, we should implement a Windows-specific default (what is it?) in EnvironmentOps. I don't want to have to put so... Eugenie Lyzenko
02:45 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
07:03 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The following calls has testcases to verify conversion result in Windows:... Eugenie Lyzenko
04:20 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I also think it is hard to predict now how will SQLFunction approch affect caching and performance. I hope not very m... Vadim Nebogatov
02:39 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
As far as when to do it, I would say to do a quick and dirty test soon if possible. You want to know now if there is... Greg Shah
02:00 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
AFAIK, we have not done any work to determine the potential performance penalty.
We will have to look at some typi...
Eric Faulhaber
01:28 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Eric: my questions were not related to the potential worry that you have about performance issues. I was fully aware... Greg Shah
03:05 PM Base Language Feature #1611: implement QUOTER utility

@OS-COMMAND "c:\my stupid space \laden path\quoter.exe" -C 45-50 whatever > output.txt@
this kind of call might be...
Costin Savin
01:32 PM Base Language Feature #1611: implement QUOTER utility
... Greg Shah
02:32 PM Base Language Feature #1920: implement persistent procedures
... Greg Shah
01:49 PM Base Language Feature #1920: implement persistent procedures
1 - yes, I refer to PROCEDURE ... EXTERNAL case
2 - I don't have a fully working example (i.e. I don't have a dll ...
Constantin Asofiei
01:23 PM Base Language Feature #1920: implement persistent procedures
Some questions/comments:
1. What do you mean by "native-proc"? Do you mean the invocation of something defined as...
Greg Shah
12:47 PM Base Language Feature #1920: implement persistent procedures
Greg, should I add support for the "h:<read-only-attribute> = value" cases too ? Because 4GL does allow them (shows a... Constantin Asofiei
11:35 AM Base Language Feature #1920: implement persistent procedures
All RUN cases are handled by these rules:
- ControlFlowOps.invoke(String name, Object ... param) will be emitted for...
Constantin Asofiei
02:15 PM Database Feature #1580: upgrade Hibernate to latest level
Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but do... Eric Faulhaber
10:57 AM Database Feature #1580: upgrade Hibernate to latest level
About... Stanislav Lomany
11:51 AM Database Feature #1911: add runtime support for sequences
I spoke with Greg about this and he suggested a much more efficient (and simpler) solution:
Add flags to the direc...
Eric Faulhaber

12/04/2012

06:43 PM Base Language Feature #1611: implement QUOTER utility
Greg: yes, the calls input through, output through and input-output through has the problem in Windows running after ... Eugenie Lyzenko
12:22 PM Base Language Feature #1611: implement QUOTER utility
Are there more possible extensions quoter can have besides .exe, on unix maybe? Using Quoter with a path containing s... Costin Savin
08:48 AM Base Language Feature #1611: implement QUOTER utility
In regards to note 36 (https://projsrv01/redmine/issues/1611#note-36):
Eugenie: please read that note carefully. Y...
Greg Shah
04:27 AM Base Language Feature #1611: implement QUOTER utility
Greg, what Costin saw I think is a difference between how 4GL behaves on Windows and Linux environments. Assuming we ... Constantin Asofiei
06:05 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Investigation SQLFunctions processing in Hibernate&Antlr source code. SqlGenerator invokes SQLFunction.render() metho... Vadim Nebogatov
12:29 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Greg Shah wrote:
> Did I miss this?
Apparently, yes, you missed the post (# 49) where I voiced my concern about p...
Eric Faulhaber
12:14 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Greg Shah wrote:
> I didn't realize that we already had eq and ne. When are they used? I previously thought that w...
Eric Faulhaber
08:23 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Did I miss this? Is there a performance penalty to using the SQLFunction approach?
Also, what is the performance ...
Greg Shah
08:22 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
equals and not_equals seem fine to me.
I didn't realize that we already had eq and ne. When are they used? I pre...
Greg Shah
12:23 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Eric Faulhaber wrote:
> ...or even @eq@ and @neq@?
I just remembered @eq@ and @ne@ already are user defined funct...
Eric Faulhaber
12:13 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
OK, it appears you have determined the SQLFunction approach is feasible. Let's go with it and see how it performs. ... Eric Faulhaber
09:06 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Hold it until we have all the changes ready for the task. Greg Shah
08:49 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
See https://projsrv01/redmine/issues/1611#note-36 for some useful notes. Greg Shah
01:43 AM Database Feature #1911: add runtime support for sequences
The implementation a service thread for handling sequence primitives (current/next/set) like this:
- the current val...
Ovidiu Maxiniuc

12/03/2012

04:54 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Concerning Example 3:
I tested with H2 database: for case f1=true, f2=true expression
(tt.f1 != true and tt.f2...
Vadim Nebogatov
04:29 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Do we need this change to be integrated into current P2J build? I mean regression testing and checking in to bzr? Or ... Eugenie Lyzenko
02:50 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
It looks good. Remove the MacOS support from indexOfNewLine() and go with it. Greg Shah
10:38 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. The suggested helper is the method in Stream class:... Eugenie Lyzenko
09:43 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Although the Stream use of searching for NEWLINE isn't causing a problem right now, I still want it to be fixed. Try... Greg Shah
02:47 PM Base Language Feature #1611: implement QUOTER utility
I don't understand. My recent suggestion to modify ProcessDaemon to transform "quoter" into "java ... com.goldencode... Greg Shah
02:13 PM Base Language Feature #1611: implement QUOTER utility
Would launching the Quoter as a separate process be a solution for this? Costin Savin
10:40 AM Base Language Feature #1611: implement QUOTER utility
Compared p2j implementation results to progress,however there seems to be one problem :
When we use it in p2j the co...
Costin Savin
01:23 PM Database Feature #1580: upgrade Hibernate to latest level
OK, it sounds like caching the Hibernation Configuration objects by schema is no longer a safe thing to do with this ... Eric Faulhaber
01:05 PM Database Feature #1580: upgrade Hibernate to latest level
> What "type" resource was scoped to one SessionFactory that is now being scoped to another? In other words, what re... Stanislav Lomany
12:06 PM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> ...
Eric Faulhaber
09:44 AM Database Feature #1580: upgrade Hibernate to latest level
>The root cause might be because the ConnectionManager.local.cleanup is executed before the Persistence.Context.clean... Stanislav Lomany
08:56 AM Database Feature #1580: upgrade Hibernate to latest level
> 3. "error closing Hibernate session" is caused by fact that the session with a remote database is closed on applica... Constantin Asofiei
05:57 AM Database Feature #1580: upgrade Hibernate to latest level
Warning that appears when multiple servers are executed on the same machine:... Stanislav Lomany
05:53 AM Database Feature #1580: upgrade Hibernate to latest level
1.... Stanislav Lomany

12/02/2012

06:21 AM Database Feature #1580: upgrade Hibernate to latest level
The following issue:... Stanislav Lomany

11/30/2012

06:12 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
All the following calls from the file_system.odt have testcases, converts and run in Windows environment:... Eugenie Lyzenko
06:01 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
I just retested and have the correction. The case 1 can be left untouched. And moreover case 2 can be unchanged too. ... Eugenie Lyzenko
05:10 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Is case 1 really a problem? That is about writing a newline, not searching for one. I think it should write the loc... Greg Shah

11/29/2012

04:24 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
SQLFunctionTemplate does not allow repeating parameters, but direct implementation of SQLFunction interface seems res... Vadim Nebogatov
04:20 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
SQLFunction approach (SQLFunctions are already in Hibernate v3.0.5).
I have added
registerFunction("p2j...
Vadim Nebogatov
03:42 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The investigation results:
Affected code is located in com.goldencode.p2j.util package, classes Stream and FileStrea...
Eugenie Lyzenko
09:29 AM Base Language Feature #1611: implement QUOTER utility
... Greg Shah
09:27 AM Base Language Feature #1611: implement QUOTER utility
Constantin, you raise some good points.
Here are the differences as I know them:
- On Windows, the executable...
Greg Shah
09:19 AM Base Language Feature #1611: implement QUOTER utility
Related to this
Quoter syntax is:
@quoter [options] [input_file] >[output_file]@
In the quoter implementation I...
Costin Savin
03:13 AM Base Language Feature #1611: implement QUOTER utility
I don't think it is that easy to replace "quoter" references from the process-launching command with the "java ..." c... Constantin Asofiei
05:35 AM Database Feature #1580: upgrade Hibernate to latest level
> When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack t... Stanislav Lomany
10:30 PM Database Feature #1580: upgrade Hibernate to latest level
When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack tra... Eric Faulhaber
11:25 PM Database Feature #1582: add conversion and runtime support for sequences
Some additional code review comments for the 1123a drop:
* How is CustomSequence to be used? AFAIK, Progress sequ...
Eric Faulhaber
10:40 PM Database Feature #1911: add runtime support for sequences
If we need transaction processing separate from the current (application-defined) database transaction, it sounds lik... Eric Faulhaber

11/28/2012

03:33 PM Database Feature #1580: upgrade Hibernate to latest level
I looked at the original log carefully and now we have reproduction:
V-C-select RFQ-Enter (RFQ server should be runn...
Stanislav Lomany
10:26 AM Database Feature #1580: upgrade Hibernate to latest level
Stas, my conclusion about this being a threading issue was based on some cursory Internet research. Please dig into ... Eric Faulhaber
06:09 AM Database Feature #1580: upgrade Hibernate to latest level
Stanislav,
From the org.hibernate.Session javadoc (http://docs.jboss.org/hibernate/orm/4.1/javadocs/org/hibernate/Se...
Constantin Asofiei
05:54 AM Database Feature #1580: upgrade Hibernate to latest level
A session CAN be closed in another thread:... Stanislav Lomany
01:27 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. Please propose a fix as part of this task. Greg Shah
12:51 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The testing respective 4GL program in Windows OpenEdge10 discovers the 4GL accepts both Linux and Windows style line ... Eugenie Lyzenko
08:18 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Yes and yes. Correct. Greg Shah
07:17 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Please test the same case in 4GL on Windows. In other words: does the 4GL properly honor the Linux line end the sam... Eugenie Lyzenko
11:06 AM Database Feature #1911: add runtime support for sequences
An issue related to PSQL, but not only:
On a finite, non cycling sequences, calling @nextVal@ will return an error...
Ovidiu Maxiniuc
09:39 AM Base Language Feature #1590 (Closed): implement PROPATH assignment
Greg Shah
09:00 AM Base Language Feature #1590 (Review): implement PROPATH assignment
Costin Savin
08:45 AM Base Language Feature #1611: implement QUOTER utility
Constantin: you make very good points here. Yes, these other cases are problems. And the client-side invocation is ... Greg Shah
08:28 AM Base Language Feature #1611: implement QUOTER utility
Tested @INPUT THROUGH@ and @OUTPUT THROUGH@ stream case and they are viable.
The @INPUT-OUTPUT THROUGH@ stream case ...
Costin Savin
07:10 AM Base Language Feature #1611: implement QUOTER utility
Greg, some thoughts about the QUOTER utility: as this is an external program invoked via the OS-COMMAND and other pro... Constantin Asofiei
04:18 AM Database Feature #1583 (Review): add conversion and runtime support for the INSERT language statement
Ovidiu Maxiniuc
04:18 AM Database Feature #1583 (WIP): add conversion and runtime support for the INSERT language statement
Ovidiu Maxiniuc
04:15 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement
I first tested if the sequence of CREATE/UPDATE has the same effect like @INSERT@. My fear was that if user skips the... Ovidiu Maxiniuc

11/27/2012

06:58 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
It is an interesting finding (about the Linux line ending not being honored in P2J on Windows). Please test the same... Greg Shah
06:06 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The second part of the stream chapter:... Eugenie Lyzenko
06:32 PM Database Feature #1580: upgrade Hibernate to latest level
Eric Faulhaber wrote:
> ... Although I haven't looked at the latest Hibernate source, I suspect Hibernate is using a...
Eric Faulhaber
06:21 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Please explain your SQLFunction idea more fully. It is intriguing.
I think this is a relatively new feature in Hi...
Eric Faulhaber
06:03 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
How to proceed with this task?.. Vadim Nebogatov
04:57 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
One more option is providing a custom comparing functions (org.hibernate.dialect.function.SQLFunction) registered wit... Vadim Nebogatov
04:29 PM Base Language Feature #1611: implement QUOTER utility
... Greg Shah
01:20 PM Base Language Feature #1611: implement QUOTER utility
... Costin Savin
12:33 PM Base Language Feature #1611: implement QUOTER utility
Made the changes according to feedback, there's some issue though:... Costin Savin
07:39 PM Base Language Feature #1611 (WIP): implement QUOTER utility
This is much better.
Feedback:
1. What are the results of your testing with these options? I see that you have ...
Greg Shah
09:59 AM Base Language Feature #1591: implement QUOTER built-in function
This javadoc:... Greg Shah
08:56 AM Base Language Feature #1591: implement QUOTER built-in function
Attached proposed update Costin Savin

11/26/2012

06:22 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I agreed absolutely. But it seems there is no choice if you want to fix this issue on the HQL level.
My draft idea ...
Vadim Nebogatov
12:05 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> > I don't remember this being a supported operator in HQL.
> What operator did you mean? H...
Eric Faulhaber
04:50 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Correct. Greg Shah
04:13 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Need to clarify in requirements for the following resources:... Eugenie Lyzenko
01:24 PM Base Language Feature #1611: implement QUOTER utility
Added proposed update, commityed testcases to bazaar, run regression tests (to see if they don't fail because of the ... Costin Savin
12:59 PM Database Feature #1666: add support for mixed-direction indexes
I use PostgreSQL 9.1 (not the latest available version but what I have installed) to test this issue. Also I have a p... Ovidiu Maxiniuc
12:41 PM Base Language Feature #1920: implement persistent procedures
... Greg Shah
12:02 PM Base Language Feature #1920: implement persistent procedures
A "message h:next-sibling:prev-sibling:next-sibling:name." statement gets parsed this way (from .parser file):... Constantin Asofiei
11:15 AM Base Language Feature #1920: implement persistent procedures
I wonder if treating COLON as a binary operator will help with the conversion.
I also wonder if we are parsing cha...
Greg Shah
09:14 AM Base Language Feature #1920: implement persistent procedures
Understood and agreed. Greg Shah
09:12 AM Base Language Feature #1920: implement persistent procedures
One thing about handle.unwrap. 4GL allows these kind of calls:... Constantin Asofiei
09:11 AM Base Language Feature #1920: implement persistent procedures
> In regards to the RUN <proc> PERSISTENT, is that a case where we know that <proc> is an external procedure (or shou... Constantin Asofiei
09:03 AM Base Language Feature #1920: implement persistent procedures
Sorry, I wish I was wrong on this point.
In regards to the RUN <proc> PERSISTENT, is that a case where we know tha...
Greg Shah
03:33 AM Base Language Feature #1920: implement persistent procedures
Greg, you are correct, 4GL allows '.', '\' and '/' characters as part of an internal procedure's name; so, we can't d... Constantin Asofiei
12:26 PM Database Feature #1926: create an en_GB@p2j_basic locale definition
Model this after locale/en_US@p2j_basic, customizing LC_CTYPE and LC_COLLATE sections. Use en_GB as a basis instead ... Eric Faulhaber
12:22 PM Database Feature #1926 (Hold): create an en_GB@p2j_basic locale definition
Eric Faulhaber

11/25/2012

04:56 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Yes, you are correct, I did not notice that issue concerns NHibernate, but all others I wrote about Hibernate.
CA...
Vadim Nebogatov
02:04 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do ...
Eric Faulhaber
12:25 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do not plan to support it:
...
Vadim Nebogatov

11/24/2012

05:00 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> What about limitations for SQL statement length which some databases have? Resulting SQL st...
Eric Faulhaber
03:30 PM Database Feature #1911 (WIP): add runtime support for sequences
Eric Faulhaber
03:25 PM Database Feature #1666: add support for mixed-direction indexes
Highest priority sub-tasks of this issue should be:
# to fix the creation of indexes during the data import proces...
Eric Faulhaber

11/23/2012

06:01 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Yes, I understand this. Converted code will be not affected in this case, HQLAst and parameter list changes should be... Vadim Nebogatov
05:53 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I'll let Eric comment on all the other good information and questions you have posed.
The only thing I want to mak...
Greg Shah
05:34 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
What about limitations for SQL statement length which some databases have? Resulting SQL statement could be very heavy. Vadim Nebogatov
05:15 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I have found out that not only inequality should be replaced but equality also work incorrectly in some cases.
Very ...
Vadim Nebogatov
04:42 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
For now the following features described in streams.odt chapter have testcases to demonstrate conversion in Windows. ... Eugenie Lyzenko
01:26 PM Database Feature #1582 (WIP): add conversion and runtime support for sequences
I have reviewed the progress.g changes. They are fine. My only request is for you to please change the ending copyr... Greg Shah
12:04 PM Database Feature #1582: add conversion and runtime support for sequences
My answers/comments to your questions:
* There is no separate ddl file generated for sequences. Only the xml that ge...
Ovidiu Maxiniuc
01:03 AM Database Feature #1582: add conversion and runtime support for sequences
I have done only a very high-level review of the update so far, and it looks like you've addressed all the necessary ... Eric Faulhaber
11:23 AM Base Language Feature #1920: implement persistent procedures
About the static calculation of called code in a RUN statement, I am concerned with this information you posted in #1... Greg Shah
10:37 AM Base Language Feature #1920: implement persistent procedures
Actually, the only case when conversion knows for sure what to emit is the RUN filename statement, when the filename ... Constantin Asofiei
08:56 AM Base Language Feature #1920: implement persistent procedures
... Greg Shah
08:36 AM Base Language Feature #1591: implement QUOTER built-in function
... Greg Shah
08:32 AM Database Feature #1580: upgrade Hibernate to latest level
I don't like putting a Hibernate-specific hack into our more generic implementation.
Let's back up a bit. In what...
Greg Shah

11/22/2012

03:04 PM Database Feature #1580: upgrade Hibernate to latest level
Eric, at 3 I'm not saying that is not feasible; as only Conversation threads can create hibernate Sessions, at a firs... Constantin Asofiei
01:16 PM Database Feature #1580: upgrade Hibernate to latest level
Regarding points 1 & 2 in the previous post: currently, there is no creation of Hibernate Session objects on anythin... Eric Faulhaber
11:42 AM Database Feature #1580: upgrade Hibernate to latest level
Thoughts about context cleanup:
# If the we decide to clean the Hibernate session on the Conversion thread, then we ...
Constantin Asofiei
11:02 AM Database Feature #1580: upgrade Hibernate to latest level
The Hibernate Session objects are created on the conversation thread (for that matter, all persistence runtime code o... Eric Faulhaber
09:52 AM Database Feature #1580: upgrade Hibernate to latest level
I don't think it is as simple as you suggest. By its nature, all contexts are accessed from multiple threads. At a ... Greg Shah
12:56 AM Database Feature #1580: upgrade Hibernate to latest level
Regarding the error...... Eric Faulhaber
12:35 AM Database Feature #1580: upgrade Hibernate to latest level
Eric Faulhaber wrote:
> How common was the
>
> [...]
>
> error in the regression server log? This looks a lot...
Stanislav Lomany
12:28 AM Database Feature #1580: upgrade Hibernate to latest level
How common was the... Eric Faulhaber
11:17 AM Base Language Feature #1920: implement persistent procedures
1 - This would be my choice too.
2 - Yes
3 - If there is only one handle.unwrap method to access the attributes...
Constantin Asofiei
10:29 AM Base Language Feature #1920: implement persistent procedures
In regard to the handle issue:... Greg Shah
06:36 AM Base Language Feature #1920: implement persistent procedures
Another thing about RUN filename PERSIST [SET handle] statement. We can either emit this something like (for a RUN te... Constantin Asofiei
04:57 AM Base Language Feature #1920: implement persistent procedures
Greg, something about the handle attributes in general. In 4GL, a code like this:... Constantin Asofiei
11:13 AM Base Language Feature #1591: implement QUOTER built-in function
1. This issue seems to appear when I recheck the files from the zip before submitting, I'm aware of it now.
3....
Costin Savin
09:44 AM Base Language Feature #1591: implement QUOTER built-in function
Feedback:
1. The file rules/convert/builtin_functions.rules~ should not be in the update zip.
2. There are stil...
Greg Shah
02:58 AM Base Language Feature #1591 (Review): implement QUOTER built-in function
Costin Savin
11:01 AM Database Feature #1582: add conversion and runtime support for sequences
Uploaded update patch that covers both conversion and runtime sub-tasks (1910 and 1911). Ovidiu Maxiniuc
09:17 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement
Yes, I agree completely. So far we have almost never seen this statement used in practice. It is an interesting com... Greg Shah
12:17 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement
Greg,
There are only 4 uses of this statement across both projects (all in the server project), and they are all o...
Eric Faulhaber
06:17 AM Database Feature #1911: add runtime support for sequences
I discovered a way to access the current value in PostgreSQL without calling @CURRVAL@ which fails if it's called bef... Ovidiu Maxiniuc
12:21 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Yes, I agree, let's put it in the HQLPreprocessor. Eric Faulhaber

11/21/2012

02:12 PM Base Language Feature #1591: implement QUOTER built-in function
Added revised update but for
14:
Couldn't find the wrong alignment...
Costin Savin
12:13 PM Base Language Feature #1591: implement QUOTER built-in function
Feedback:
1. Rename workQuoter() to quoterWorker().
2. workQuoter() is private static. Per the coding standard...
Greg Shah
07:52 AM Base Language Feature #1591: implement QUOTER built-in function
Added propposed update. Submited testcase quoter-builtin-function.p to bazaar testcases repository. Costin Savin
01:55 PM Base Language Feature #1920: implement persistent procedures
Sorry, I've changed it now, it was a typo mistake. Constantin Asofiei
01:53 PM Base Language Feature #1920: implement persistent procedures
Is the sample missing the empty ()?... Greg Shah
12:32 PM Base Language Feature #1920: implement persistent procedures
New important findings: the "handle" for the "RUN ... IN handle", "DYNAMIC-FUNCTION(... IN handle)" and "FUNCTION ...... Constantin Asofiei
12:58 PM Database Feature #1580: upgrade Hibernate to latest level
Modification of LogicalUserType completely solves the problem (unless regression testing will show a surprise). Other... Stanislav Lomany
12:11 PM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> 4. Possible work around: use quotes for boolean literals: 'true' and 'false'
> 5. I don't...
Eric Faulhaber
10:23 AM Database Feature #1580: upgrade Hibernate to latest level
About boolean literals:
1. The bug/feature is related only to the fields of the P2J LogicalUserType (and any other c...
Stanislav Lomany
11:16 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
Please review the features of the OS-DIR input stream type in the INPUT FROM language statement. You should implemen... Greg Shah
09:48 AM Database Feature #1911: add runtime support for sequences
Here are the result about MS SQL server. I used the free 2012 EXPRESS version with SP1, but I believe that there are ... Ovidiu Maxiniuc

11/20/2012

02:26 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. Eugenie Lyzenko
02:24 PM Base Language Feature #1648 (WIP): review all filesystem support (runtime) on Windows and fix/resolve any issues
Please review the streams.odt and file_system.odt chapters of the Conversion Reference. Both chapters have summary t... Greg Shah
02:17 PM Base Language Support #1700 (Closed): test the startup, basic processing and shutdown of the P2J server and P2J...
Greg Shah
07:53 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
I rebuilt staging. Please distribute the update via email. Greg Shah
07:32 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Checked in p2j bzr and applied to staging.
Need to run ant jar in staging p2j to take effect.
Eugenie Lyzenko
02:03 PM Base Language Feature #1591: implement QUOTER built-in function
After retest on Progress found that custom null can only be provided with 3 argument call, if a 2 argument it's tried... Costin Savin
12:13 PM Base Language Feature #1591: implement QUOTER built-in function
I understand. Don't worry about the fact that the result will not work in PostgreSQL. We know this. But any such d... Greg Shah
11:05 AM Base Language Feature #1591: implement QUOTER built-in function
Is the main purpose of quoter to be used with database query instructions like where clauses?
If so, there might be s...
Costin Savin
11:20 AM Database Feature #1911: add runtime support for sequences
1. There is no problem for Progress/OE having a simple code like:... Ovidiu Maxiniuc
10:53 AM Database Feature #1911: add runtime support for sequences
Please also research sequences in MS SQL Server, which we have to support for this project. Eric Faulhaber
10:38 AM Database Feature #1911: add runtime support for sequences
Ovidiu Maxiniuc wrote:
> [...]
>
> *PostgreSQL*
> * offers full support for sequences (min and max values, varia...
Eric Faulhaber
08:21 AM Database Feature #1911: add runtime support for sequences
I have done some investigations and here is what I found out:
The Hibernate @Dialect@ base class defines the followi...
Ovidiu Maxiniuc
09:20 AM Base Language Feature #1921: implement super-procedures
> This is ridiculous.
I agree, it took me a while to figure it out that the search mode is not for the caller, but ...
Constantin Asofiei
08:43 AM Base Language Feature #1921: implement super-procedures
This is ridiculous. Some thoughts in general:
1. The complexity of this behavior is high.
2. There is a mismatch...
Greg Shah
07:23 AM Base Language Feature #1921: implement super-procedures
To demonstrate how SEARCH-SELF and SEARCH-TARGET behave, let's assume we have this super-procedure hierarchy:... Constantin Asofiei
07:52 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
This should not be exploded into the code. It should be hidden in the HQL preprocessor.
There is even a good reas...
Greg Shah

11/19/2012

05:45 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
In common case 4GL inequality expression in WHERE clause
exp1!=exp2
should be replaced with
(exp1 is null and e...
Vadim Nebogatov
09:41 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Vadim Nebogatov wrote:
> Problem found. In common case is that not enough to change
>
> expr1 != expr2
>
> to
...
Eric Faulhaber
05:39 PM Database Feature #1910: add schema conversion support for sequences
So far the discussion has centered around the conversion of business logic references to sequences, but the highest p... Eric Faulhaber
01:33 PM Database Feature #1910: add schema conversion support for sequences
From progress.g:... Greg Shah
11:43 AM Database Feature #1910: add schema conversion support for sequences
The key point here is that the assignment style statements should already be working without duplicating the assignme... Greg Shah
11:40 AM Database Feature #1910: add schema conversion support for sequences
... Greg Shah
10:54 AM Database Feature #1910: add schema conversion support for sequences
I can now confirm that the statements also need "EQUALS! expr" at the end. Indeed, the syntax is stupid, but the antl... Ovidiu Maxiniuc
10:53 AM Database Feature #1910: add schema conversion support for sequences
What do you mean?
At this moment, the P2J work just fine, .p file is correctly converted.
Keeping @sequence_funcs@ ...
Ovidiu Maxiniuc
10:14 AM Database Feature #1910: add schema conversion support for sequences
OK, that explains things. When I added support for those, I had no way to test if the unquoted names could be used i... Greg Shah
10:02 AM Database Feature #1910: add schema conversion support for sequences
As far as I can see, they are already there:... Ovidiu Maxiniuc
09:54 AM Database Feature #1910: add schema conversion support for sequences
We have not yet written the backing class for the 64-bit integer. It will be called int64 when it is written. But t... Greg Shah
09:48 AM Database Feature #1910: add schema conversion support for sequences
The answer for 2nd question for now:
I am positive that DYNAMIC- forms require exactly 2 character parameters. This ...
Ovidiu Maxiniuc
09:27 AM Database Feature #1910: add schema conversion support for sequences
Questions:... Greg Shah
02:04 AM Database Feature #1910: add schema conversion support for sequences
I created the new @com.goldencode.p2j.util.Sequence@ class with the appropriate methods declarations.
However, the P...
Ovidiu Maxiniuc
05:16 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
You can check in the change to bzr and apply it to staging. Greg Shah
03:27 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The modified versions of the ChuiSimulator.java and SwingHelper.java have been uploaded for review. Eugenie Lyzenko
11:46 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Prepare the update zip file and attach it to this issue's history. I will then do a final code review and let you know. Greg Shah
11:22 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
OK. What about changes testing and uploading?
The code involved in the change does not affect the usual client beh...
Eugenie Lyzenko
07:42 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Go with your 2nd approach:... Greg Shah
05:05 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
This is a list of static fields/methods that should be moved from the character class to the new TextOps class.
*_...
Adrian Lungu
11:36 AM Base Language Feature #1921: implement super-procedures
Would you please show an example of both SEARCH-SELF and SEARCH-TARGET? Greg Shah
10:01 AM Base Language Feature #1921: implement super-procedures
SUPER-PROCEDURES attribute:
- contains the string representation of the super procedure stack
- the top of the stac...
Constantin Asofiei
05:30 AM Base Language Feature #1921: implement super-procedures
Just a note, I think we do probably have dynamic calls, even though the SUPER-PROCEDURE stack is effectively static. ... Guy M
10:27 AM Base Language Feature #1920: implement persistent procedures
Agreed. Greg Shah
10:26 AM Base Language Feature #1920: implement persistent procedures
The next steps for this task (and super-procedures) are:
1a. provide conversion support for all related 4GL features...
Constantin Asofiei
09:38 AM Database Feature #1580: upgrade Hibernate to latest level
Have you removed all the old versions of the Hibernate jar and its dependencies from the project and from the p2j.mf ... Eric Faulhaber
05:09 AM Database Feature #1580: upgrade Hibernate to latest level
I have some troubles with Hibernate. I have the small project to deal with different versions of Hibernate and while ... Stanislav Lomany

11/18/2012

05:42 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
We can only use constructs that can be expressed in HQL and which are supported across all major databases (e.g., Ora... Eric Faulhaber

11/17/2012

04:26 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Variant with changes in QUERY_SUBST is investigated. It is also possible solution but not very easy because QUERY_SU... Vadim Nebogatov

11/16/2012

06:25 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Your change is not enough to get the ChUI client working. Consider the constructor of the ChuiSimulator class. The ge... Eugenie Lyzenko
05:21 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
OK, this is close. But it seems that the real problem is just with our isMonospaced() implementation. In other word... Greg Shah
04:31 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
More investigation.
Looks like the reason for screen corruption in Windows monospaced has been found. The CHUI out...
Eugenie Lyzenko
07:35 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The debugging results:
1. The SwingHelper.getMonoFontList() and SwingHelper.isMonospaced() are seems to work fine....
Eugenie Lyzenko
05:40 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Problem found. In common case is that not enough to change
expr1 != expr2
to
expr1 is null and expr2 is not ...
Vadim Nebogatov
02:38 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
I recreated the longchar class as a subclass of character and added only the constructors.
I created the new class ...
Adrian Lungu
11:57 AM Database Feature #1910: add schema conversion support for sequences
Please show the changes you have had to make. I am especially interested in the progress.g changes, but show everyth... Greg Shah
11:35 AM Database Feature #1910 (WIP): add schema conversion support for sequences
Ovidiu Maxiniuc
07:50 AM Base Language Feature #1591: implement QUOTER built-in function
After more tests it seems that in fact quoter uses a fixed format for date not the format it is defined with:... Costin Savin
07:45 AM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> Interesting thing about boolean literals issue is that it presents in the latest Hibernate...
Eric Faulhaber
07:12 AM Database Feature #1580: upgrade Hibernate to latest level
Boolean literals can be fixed by the following changes in org.hibernate.hql.internal.ast.tree.BooleanLiteralNode:
<p...
Stanislav Lomany
07:09 AM Base Language Feature #1590: implement PROPATH assignment
Runtime regression testing has passed. The update was applied to staging (without the testcase), staging P2J was rebu... Constantin Asofiei

11/15/2012

06:04 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Based on idea above, new rule and function "replaceInequalityNode" are added. Function seems is not optimal, I think... Vadim Nebogatov
05:09 PM Database Feature #1580: upgrade Hibernate to latest level
So, what are your thoughts about how we address these 3 errors?
Also, thoughts on the deprecated, positional param...
Eric Faulhaber
03:10 PM Database Feature #1580: upgrade Hibernate to latest level
Interesting thing about boolean literals issue is that it presents in the latest Hibernate release (at first I though... Stanislav Lomany
07:09 AM Database Feature #1580: upgrade Hibernate to latest level
As far as I've analyzed the regression testing log (it is 500M), there are three types of errors:
1. Boolean literal...
Stanislav Lomany
04:58 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Go forward with this approach:
1. Make longchar a subclass of character. Override only as minimally necessary. I...
Greg Shah
02:11 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
I admit that a new longchar class with a lot of duplicated methods is not a solution but I went on this route to have... Adrian Lungu
02:03 PM Base Language Feature #1591: implement QUOTER built-in function
Make sure you test each data type with explicit format strings that are different from the default.
Example, try "...
Greg Shah
01:29 PM Base Language Feature #1591: implement QUOTER built-in function
Good point. In this case, it is probably best to call a variant of quoter(). Perhaps it should be named quoterForma... Greg Shah
01:23 PM Base Language Feature #1591: implement QUOTER built-in function
That may pose some problems since quoter can also be called with 2 or 3 parameters (custom unknown replacement and cu... Costin Savin
01:02 PM Base Language Feature #1591: implement QUOTER built-in function
This means that during conversion, you must emit any non-default format string for the variable into the quoter() cal... Greg Shah
11:49 AM Base Language Feature #1591: implement QUOTER built-in function
This seems to be only reproducible for quoter... Costin Savin
11:11 AM Base Language Feature #1591: implement QUOTER built-in function
Please provide a small sample here that shows the problem. Please note that when you say "string equivalent of the d... Greg Shah
10:11 AM Base Language Feature #1591: implement QUOTER built-in function
There seems to be a problem for date variables
Assuming we have the following variable:...
Costin Savin
01:04 PM Base Language Feature #1920: implement persistent procedures
OK, that all makes sense. Greg Shah
12:49 PM Base Language Feature #1920: implement persistent procedures
> IF this behavior was associated with widgets/frames, we would want to replace the referent with a dynamic proxy (in... Constantin Asofiei
08:52 AM Base Language Feature #1920: implement persistent procedures
... Greg Shah
08:27 AM Base Language Feature #1920: implement persistent procedures
For #1920-11 - I've added the comment to #1921, please update there all info about super procedures. Constantin Asofiei
07:11 AM Base Language Feature #1920: implement persistent procedures
Hi Greg,
Thanks for adding me in- that is interesting, but what a nightmare!
Why did Progress have to come up w...
Guy M
03:53 AM Base Language Feature #1920: implement persistent procedures
Answers for entry #1920-8
> Yes. The behavior also suggests that there may be an additional state of "deleted". Un...
Constantin Asofiei
02:43 AM Base Language Feature #1920: implement persistent procedures
Answers for #1920-7
> If I understand correctly, calls to these entry points are all done indirectly (e.g. RUN x IN ...
Constantin Asofiei
12:37 PM Base Language Feature #1590: implement PROPATH assignment
Regression testing is running in a staging copy. If it passes, I'll apply the update to staging. Constantin Asofiei
11:09 AM Base Language Feature #1590: implement PROPATH assignment
The proposed update looks good. Please work with Constantin to get runtime regression testing done on lightning stag... Greg Shah
05:17 AM Base Language Feature #1590: implement PROPATH assignment
Added proposed update. Done regression tests - resulting sources are identical. Costin Savin
09:50 AM Database Feature #1582: add conversion and runtime support for sequences
Ovidiu Maxiniuc wrote:
> ... I believe P2J implementation will focus on OE10.x at the moment so the P2J implementati...
Eric Faulhaber
07:53 AM Database Feature #1582: add conversion and runtime support for sequences
Seems like the OpenEdge version installed on windev01 is only at version 10.2 and does not support the new extra para... Ovidiu Maxiniuc
05:26 AM Database Feature #1582: add conversion and runtime support for sequences
At first attempt to read about and prepare the dynamic forms testcases I could not find them in Progress Reference do... Ovidiu Maxiniuc
08:59 AM Base Language Feature #1921: implement super-procedures
Agreed. See #1922. Greg Shah
08:36 AM Base Language Feature #1921: implement super-procedures
If we can somehow use hints to hard code the super procedure hierarchy and, during conversion, extract the entire hie... Constantin Asofiei
08:26 AM Base Language Feature #1921: implement super-procedures
Hi Greg,
Thanks for adding me in- that is interesting, but what a nightmare!
Why did Progress have to come up w...
Constantin Asofiei
08:59 AM Conversion Tools Feature #1922 (New): identify if and how we can convert the super procedure chain into an interfa...
Greg Shah

11/14/2012

03:38 PM Base Language Feature #1920: implement persistent procedures
Some thoughts on the implementation:... Greg Shah
02:52 PM Base Language Feature #1920: implement persistent procedures
Some thoughts on the 4GL behavior:... Greg Shah
09:40 AM Base Language Feature #1920: implement persistent procedures
A. Implementation problems:
1. still need to find out how the exposed TRIGGERs work in 4GL, but I'll leave this last...
Constantin Asofiei
09:40 AM Base Language Feature #1920: implement persistent procedures
0. a procedure handle will expose public internal procedures, functions and also triggers.
1. the standard procedu...
Constantin Asofiei
02:29 PM Base Language Feature #1590: implement PROPATH assignment
Only the build has failed. Check the build.xml to see the amount of memory needed for the compile target. Change th... Greg Shah
02:15 PM Base Language Feature #1590: implement PROPATH assignment
I made the changes and ran the regression tests however I got a message at the end that Error occurred during initia... Costin Savin
09:09 AM Base Language Feature #1590: implement PROPATH assignment
This sounds like a good approach.
Costin: please make the changes to EnvironmentOps and to Preprocessor.evaluate()...
Greg Shah
04:59 AM Base Language Feature #1590: implement PROPATH assignment
MAJIC conversion fails because cases like this:... Constantin Asofiei
01:38 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
1. We don't want to duplicate code. BUT
2. We need to limit the operators, built-in functions and so forth as neede...
Greg Shah
12:42 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
In order to go further with implementing the LONGCHAR data type I created the longchar class as a copy of the charact... Adrian Lungu

11/13/2012

06:34 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
I reviewed the 4gl operator functions and procedures implemented by the character class and also the ones taking LONC... Adrian Lungu
01:55 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Applied to staging and checked in Bazaar. Eugenie Lyzenko
01:29 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The update has been repackaged. Also it includes the directory.xml.win and directory.xml.linux files for both systems... Eugenie Lyzenko
11:56 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The only change needed is to re-zip the update without the p2j/ prefix. Zip everything from inside the p2j/ director... Greg Shah
12:03 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
I put aside all above and started with a fresh new idea. Please correct me if I'm wrong.
P2J is informed about cha...
Ovidiu Maxiniuc
11:40 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
This is an interesting idea, but it is pretty intrusive in the DMOs. Let's go with your first approach, limiting the... Eric Faulhaber
11:27 AM Base Language Feature #1590: implement PROPATH assignment
Looks good.
The next step is to get it fully regression tested. This change affects both conversion and runtime, ...
Greg Shah
10:52 AM Base Language Feature #1590: implement PROPATH assignment
Added revised update,
1. Corrected the Javadoc , hopefully I done most of the code formatting mistakes to remember t...
Costin Savin
09:48 AM Base Language Feature #1590: implement PROPATH assignment
Feedback:
1. Please see the JavaDoc section of the doc.html section of the coding standards. Your EnvironmentOps....
Greg Shah
10:11 AM Database Feature #1580: upgrade Hibernate to latest level
It seems like using JPA-style positional parameters (?1, ?2, ?3, ...) would be much easier than changing conversion o... Eric Faulhaber
08:37 AM Database Feature #1580: upgrade Hibernate to latest level
Log file is full of this kind of warnings:... Stanislav Lomany
09:27 AM Base Language Feature #1920: implement persistent procedures
Agreed. You mean that the handle.isValid() should be overridden in phandle? Greg Shah
08:11 AM Base Language Feature #1920: implement persistent procedures
I think the VALID-HANDLE function should be implemented too (it checks if a handle is valid), because after a DELETE ... Constantin Asofiei
08:04 AM Conversion Tools Feature #1565 (Closed): test the full conversion process on Windows and document all problems tha...
Greg Shah

11/12/2012

06:03 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The new version with commented out the dead command has been uploaded. Eugenie Lyzenko
01:34 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
> Package the changes as a proper update zip. These do not affect anything in the conversion or runtime, so we will j... Eugenie Lyzenko
11:43 AM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Package the changes as a proper update zip. These do not affect anything in the conversion or runtime, so we will ju... Greg Shah
01:02 PM Base Language Feature #1590: implement PROPATH assignment
Added revised proposed update Costin Savin
10:43 AM Base Language Feature #1590: implement PROPATH assignment
Please see the P2J Conversion Handbook, Project Setup chapter. In the "Global Configuration" section, look at the "un... Greg Shah
10:16 AM Base Language Feature #1590: implement PROPATH assignment
After looking for error replication discovered it fails when \ is at the end of the string operand.
Example:
<p...
Costin Savin
08:27 AM Base Language Feature #1590: implement PROPATH assignment
Feedback on the code:
1. EnvironmentOps still needs the copyright date updated to 2012.
2. Please put the first...
Greg Shah
08:10 AM Base Language Feature #1590: implement PROPATH assignment
Please show a very small sample 4GL procedure here where Progress deals with "\" correctly and P2J fails. Make the c... Greg Shah
12:46 PM Conversion Tools Feature #1565: test the full conversion process on Windows and document all problems that are found
The changes are in bzr. Eugenie Lyzenko
11:33 AM Conversion Tools Feature #1565: test the full conversion process on Windows and document all problems that are found
... Greg Shah
11:31 AM Conversion Tools Feature #1565: test the full conversion process on Windows and document all problems that are found
> Please check in your update to Bazaar. Remember that in Bazaar, we do NOT do any tagging of history entries.
>
>...
Eugenie Lyzenko
10:50 AM Conversion Tools Feature #1565: test the full conversion process on Windows and document all problems that are found
Please check in your update to Bazaar. Remember that in Bazaar, we do NOT do any tagging of history entries.
Do m...
Greg Shah
10:48 AM Conversion Tools Feature #1565: test the full conversion process on Windows and document all problems that are found
-------- Original Message --------
Subject: Re: The Windows conversion related update
Date: Wed, 07 Nov 2012 18:3...
Greg Shah
11:54 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Indeed, the @snapshot@ seems to be used for a similar reason, but I see it's only used for undo-s, it only stores ses... Ovidiu Maxiniuc
10:46 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Please review the use of the @snapshot@ instance variable in @RecordBuffer@. Can this variable (i.e., when it is a d... Eric Faulhaber
11:14 AM Conversion Tools Feature #1579 (Closed): review and merge 12/2011 conversion fixes into main P2J code base, regres...
Greg Shah
09:25 AM Database Feature #1911: add runtime support for sequences
See parent issue for requirements.
Runtime implementations of the statement/functions should leverage dialect infr...
Eric Faulhaber
09:21 AM Database Feature #1910 (New): add schema conversion support for sequences
See parent issue for description of what must be converted.
The statements in the schema export (.df) file must be...
Eric Faulhaber
03:54 AM Base Language Feature #1921: implement super-procedures
Implement the following 4GL features:
FUNCTION ... IN SUPER
PROCEDURE ... IN SUPER
RUN SUPER statement
SUPER func...
Constantin Asofiei
03:53 AM Base Language Feature #1921 (Closed): implement super-procedures
Constantin Asofiei

11/11/2012

03:09 PM Database Feature #1580: upgrade Hibernate to latest level
In order to get rid of the "(org.hibernate.internal.util.xml.DTDEntityResolver:WARN) HHH000223: Recognized obsolete h... Stanislav Lomany
02:54 PM Database Feature #1580: upgrade Hibernate to latest level
In order to enable EhCache, the following entry should be added to the directory:... Stanislav Lomany

11/10/2012

12:23 PM Base Language Feature #1590: implement PROPATH assignment
Added proposed update. Costin Savin
12:12 PM Base Language Feature #1590: implement PROPATH assignment
Already tried that with the same result - conversion fail, however double "\\" seems to work fine with p2j and progre... Costin Savin

11/09/2012

06:07 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
One more, pure database field test:
def temp-table tt
field f1 as logical
field f2 as logical.
create tt...
Vadim Nebogatov
05:30 PM Base Language Feature #1590: implement PROPATH assignment
For now, just use the preprocessor conditional processing and the OPSYS built-in to detect the platform on which the ... Greg Shah
04:23 PM Base Language Feature #1590: implement PROPATH assignment
There seems to be a problem with slash and backslash when defining directories
When run on windows PROGRESS using "...
Costin Savin
04:03 PM Base Language Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The new tests does not have the issues except one that related to the Swing screen representation. The basic function... Eugenie Lyzenko
12:07 PM Base Language Feature #1606: implement persistent procedures/super procedures
I've added #1920 for persistent procedures; I suggest to leave this task for tracking the implementation of the super... Constantin Asofiei
08:41 AM Base Language Feature #1606: implement persistent procedures/super procedures
I agree that we must work around the fact that the super-procedure chain is built at runtime NOT at compile time. You... Constantin Asofiei
08:18 AM Base Language Feature #1606: implement persistent procedures/super procedures
One approach is to use reflection to fully and "naturally" implement the features. We know that will work and it can... Greg Shah
08:10 AM Base Language Feature #1606: implement persistent procedures/super procedures
One of the major design decisions will relate to how we handle the super procedure chain. The idea of super procedur... Greg Shah
08:04 AM Base Language Feature #1606 (WIP): implement persistent procedures/super procedures
Constantin Asofiei
12:05 PM Base Language Feature #1920: implement persistent procedures
Implement the following 4GL features:
RUN [ PERSISTENT [SET handle]] [IN handle]
DELETE PROCEDURE/OBJECT statemen...
Constantin Asofiei
12:03 PM Base Language Feature #1920 (Closed): implement persistent procedures
Constantin Asofiei
11:51 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
A small problem regarding the implementation:
I could not find in the hibernate documentation a way to detect if a r...
Ovidiu Maxiniuc
11:22 AM Database Feature #1919: update HQLPreprocessor and calling code to better handle WHERE TRUE and WHERE FALS...
Runtime where clause optimizations can roll up a where clause such that the result passed to Hibernate is simply WHER... Eric Faulhaber
10:55 AM Database Feature #1919 (New): update HQLPreprocessor and calling code to better handle WHERE TRUE and WHER...
Eric Faulhaber
10:53 AM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> WHERE TRUE or WHERE FALSE are results of P2J runtime query optimization. I agree that we s...
Eric Faulhaber
10:22 AM Database Feature #1580: upgrade Hibernate to latest level
> Under what circumstances do we need to support WHERE TRUE and WHERE FALSE? Is this something we should optimize du... Stanislav Lomany
09:56 AM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> I found that HQL parser doesn't support WHERE TRUE or WHERE FALSE where clause. I've appli...
Eric Faulhaber
09:50 AM Database Feature #1580: upgrade Hibernate to latest level
If we didn't already have this workaround for a similar case, I would say let's fix it in Hibernate, but since we are... Eric Faulhaber
08:37 AM Database Feature #1580: upgrade Hibernate to latest level
Class cast exception bug exists in Hibernate bug tracker: https://hibernate.onjira.com/browse/HHH-4700 , not fixed ye... Stanislav Lomany
10:40 AM Database Feature #1601 (Closed): implement NUMERIC type in relational database schemas
I'm not sure to what this issue refers. Some time back, we added precision and scale information to the DDL for NUME... Eric Faulhaber
08:48 AM Database Bug #1913: default locking in a BROWSE widget
.df file attached.
.d file is irrelevant.
Ovidiu Maxiniuc
08:25 AM Conversion Tools Feature #1579 (Review): review and merge 12/2011 conversion fixes into main P2J code base, regres...
All changed docs are in bazaar (search for [CA] tag):
handbook: other_customization.odt running_conversion.odt
ref...
Constantin Asofiei
06:46 AM Runtime Infrastructure Feature #1916: improve the runtime statistics gathered by P2J
The attached files contain changes which expand the metrics gathered by BlockManager (to include total execution time... Constantin Asofiei
06:41 AM Runtime Infrastructure Feature #1916 (New): improve the runtime statistics gathered by P2J
Constantin Asofiei

11/08/2012

05:41 PM Database Bug #1913: default locking in a BROWSE widget
Please attach your test database's *.df file (and *.d file(s), if any), so that the worker of this issue can run the ... Eric Faulhaber
09:46 AM Database Bug #1913: default locking in a BROWSE widget
It appears that I have uncovered a bug in how we deal with default locking in a BROWSE widgets.
In order to test CUR...
Ovidiu Maxiniuc
09:36 AM Database Bug #1913 (New): default locking in a BROWSE widget
Ovidiu Maxiniuc
03:26 PM Base Language Feature #1590: implement PROPATH assignment
This does not work in the 4GL for a simple reason: most language statements that deal with the file system do not DIR... Greg Shah
02:47 PM Base Language Feature #1590: implement PROPATH assignment
Tried the following for creating a file... Costin Savin
11:55 AM Base Language Feature #1590: implement PROPATH assignment
I will implementing the 2nd choice, what I wanted to say about p2j starting from where the client is running referred... Costin Savin
11:08 AM Base Language Feature #1590: implement PROPATH assignment
... Greg Shah
11:01 AM Base Language Feature #1590: implement PROPATH assignment
Ran with the full path of prowin32:
When it is ran in this configuration the reference path "." is the directory whe...
Costin Savin
09:47 AM Base Language Feature #1590: implement PROPATH assignment
I don't know, it is possible that the PATH does not include the Progress directories. But you can do 2 simple things... Greg Shah
09:12 AM Base Language Feature #1590: implement PROPATH assignment
prowin32 and pro are not recognized as internal or external command, operable program or batch file on the Progress t... Costin Savin
08:47 AM Base Language Feature #1590: implement PROPATH assignment
Your problems all stem from the fact that when you run the test program from the "Procedure Editor", the environment ... Greg Shah
06:02 AM Base Language Feature #1590: implement PROPATH assignment
Progress seems to support relative paths in general so not sure why it wouldn't support it in PROPATH also
After run...
Costin Savin
02:07 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Please go ahead with optimizing these cases (e.g. true is null can be replaced with false). Greg Shah
02:02 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Concerning special cases
true is null
true is not null
false is null
false is not null
nul...
Vadim Nebogatov
01:43 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I agree that this file looks good. So it passes code review.
BUT:
1. There are more issues to resolve before ...
Greg Shah
01:25 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Attached variant seems ready to commit (when CVS is unlocked) Vadim Nebogatov
09:37 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Feedback on the normalize_expressions.rules changes:
1. You have removed the first line of the file, which should ...
Greg Shah
08:43 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
It would be better to test for and avoid emitting things like:
* true is null
* true is not null
* false is null
* fa...
Eric Faulhaber
12:09 PM Database Bug #1914: database conversion requires Internet connectivity
While converting a project without being connected to the Internet, I hit an exception when the JVM tried to resolve ... Eric Faulhaber
11:33 AM Database Bug #1914 (Closed): database conversion requires Internet connectivity
Eric Faulhaber
10:22 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
I am using a very simple database (one table with a few records) that I created manually which is somehow similar to ... Ovidiu Maxiniuc
01:15 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
It appears you have uncovered a bug in how we deal with default locking in a BROWSE. BTW, what database are you usin... Eric Faulhaber
10:17 AM Conversion Tools Feature #1579: review and merge 12/2011 conversion fixes into main P2J code base, regression test...
Both of these can be left out for now. This is not a feature I expect to be included long term. Greg Shah
09:16 AM Conversion Tools Feature #1579: review and merge 12/2011 conversion fixes into main P2J code base, regression test...
Some questions/info about the reporting changes:
* master_report_from_cache.xml - non-destructive point-in-time mast...
Constantin Asofiei
07:30 AM Database Feature #1580: upgrade Hibernate to latest level
9. Changes into ImportWorker:
Into ImportWorker.Library.initialize:...
Stanislav Lomany

11/07/2012

05:15 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Changed normalize_expressions.rules is attached (Test6 problems). Vadim Nebogatov
11:42 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Small correction:
A!=B
should be generated as
(A is null and B is not null) or (A is not null and (B is nu...
Vadim Nebogatov
05:02 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
From Adrian:... Greg Shah
03:38 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
There are no differences between CHAR and LONGCHAR related to code page.
* CODEPAGE–CONVERT works the same way for C...
Adrian Lungu
02:46 PM Base Language Feature #1590: implement PROPATH assignment
The other question: does Progress support relative paths in the PROPATH? I suspect it does, but you should determine... Greg Shah
02:43 PM Base Language Feature #1590: implement PROPATH assignment
It seems like SEARCH(PROGRAM-NAME(1)) will return the fully qualified filename of the current program (so long as the... Greg Shah
02:33 PM Base Language Feature #1590: implement PROPATH assignment
Researched and tried a couple of Progress methods to see if I can get to find the directory containing the test data ... Costin Savin
11:33 AM Base Language Feature #1590: implement PROPATH assignment
You should not need to prompt the user for pathing. Instead, use the filesystem features of the 4GL to make the prog... Greg Shah
10:11 AM Base Language Feature #1590: implement PROPATH assignment
20.
The default propath on Progress will allways contain these values:...
Costin Savin
12:02 PM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
However, I was unable to run the converted code from my previous note. When moving from a field to another, the clien... Ovidiu Maxiniuc
10:53 AM Database Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
To test two buffers within the same session I wrote the following test.
It FINDs the first record, then enables a B...
Ovidiu Maxiniuc
 

Also available in: Atom