FWD » Core Development

12/21/2012

02:29 PM Base Language Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

I've uploaded two draft files here, one for conversion handbook, another for developer guide. Now I'm thinking and st... Eugenie Lyzenko

01:26 PM Base Language Feature #1591: implement QUOTER built-in function

Feedback:
1. Remove the builtin_functions.rules from your zip. There are no changes there.
2. The character.ja... Greg Shah

01:09 PM Base Language Feature #1591: implement QUOTER built-in function

Added proposed update with the String overloaded methods. Costin Savin

12:12 PM Base Language Feature #1591: implement QUOTER built-in function

Yes. Greg Shah

12:09 PM Base Language Feature #1591: implement QUOTER built-in function

A quoter version which supports String instead of BaseDataType should probably be added to be reused for places where... Costin Savin

05:39 AM Base Language Feature #1591: implement QUOTER built-in function

Added the entry to expressions.odt Costin Savin

01:11 PM Base Language Feature #1920: implement persistent procedures

In addition to the general messiness that comes from having a global or "umbrella" interface, there is another practi... Greg Shah

12:35 PM Base Language Feature #1920: implement persistent procedures

The idea is, to be able to use handle.unwrap to access an attribute for any kind of handle (procedure handle, widget ... Constantin Asofiei

12:09 PM Base Language Feature #1920: implement persistent procedures

I thought we were going to use resource-specific interfaces instead of a global interface. I prefer it to be resourc... Greg Shah

09:32 AM Base Language Feature #1920: implement persistent procedures

Greg,
When collecting all the handle-related APIs in a "global" interface, I found some differences between the retu... Constantin Asofiei

12:54 PM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND

I still need to review customer reports to determine actual scenarios, but please start with some basic use cases. Eric Faulhaber

12:35 PM Database Feature #1910: add schema conversion support for sequences

I have merged the 1214a update with my local changes and tested a real-world database import with sequences. I found... Eric Faulhaber

12:19 PM Database Feature #1663: test/debug case-sensitive field support

This task is about defining temporary and permanent database tables with a mix of case-sensitive and case-insensitive... Eric Faulhaber

11:33 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The attached file contains only implementation and test cases for int64.
The changes are both syntactic and semantic... Ovidiu Maxiniuc

09:40 AM Database Feature #1580: upgrade Hibernate to latest level

OK, let's try it. Can you think of an easy (generic) way to determine when an entity has a collection, or do you pro... Eric Faulhaber

04:41 AM Database Feature #1580: upgrade Hibernate to latest level

Eric, the snippet represents the process of deletion and the following rollback of an entity in P2J (during rollback ... Stanislav Lomany

12/20/2012

06:28 PM Database Feature #1910: add schema conversion support for sequences

Code review 1214a:
Is the version of SequenceManager.java in this update the correct one? It doesn't compile. Fi... Eric Faulhaber

05:28 PM Database Feature #1580: upgrade Hibernate to latest level

PS: see the stacktrace in the #1566 bug. Constantin Asofiei

05:26 PM Database Feature #1580: upgrade Hibernate to latest level

Stas/Eric, just a thought: do you see the "Found two representations of same collection" issue any way related to the... Constantin Asofiei

05:07 PM Database Feature #1580: upgrade Hibernate to latest level

Sorry, I don't understand what your workaround example is trying to accomplish. What use case in P2J does this repre... Eric Faulhaber

06:23 AM Database Feature #1580: upgrade Hibernate to latest level

In order to reproduce the "Found two representations of same collection" issue the following Hibernate command sequen... Stanislav Lomany

01:36 PM Base Language Feature #1591: implement QUOTER built-in function

I forgot to ask you to update the documentation. Please update the builtin functions table in the expressions.odt ch... Greg Shah

08:59 AM Base Language Feature #1591 (Closed): implement QUOTER built-in function

Greg Shah

11:16 AM Base Language Feature #1921: implement super-procedures

Ok, that makes sense. Constantin Asofiei

10:58 AM Base Language Feature #1921: implement super-procedures

... Greg Shah

10:05 AM Base Language Feature #1921: implement super-procedures

I found a case which I haven't thought about until now. Consider we have these procedures:
* t1.p:... Constantin Asofiei

10:24 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream

Those parameters should NOT be emitted in the OS-DIR case. Greg Shah

09:58 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream

From default conversion logic p2j will also add 2 boolean parameters when calling StreamFactory.openOsDir: boolean w... Costin Savin

10:23 AM Base Language Feature #1611 (Test): implement QUOTER utility

I am OK with the proposed code.
Please work with Eugenie to put this through full runtime testing using lightning ... Greg Shah

10:03 AM Base Language Feature #1611: implement QUOTER utility

Actually it's the cs_upd20121219a.zip mistaken between the two quoter folders. Costin Savin

09:02 AM Base Language Feature #1611: implement QUOTER utility

This is the wrong update (it is the same one that goes with #1591). Please upload the proper update (probably it is ... Greg Shah

09:40 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Another error I found. The following sample code extracted from _OpenEdge® Development: ABL Reference_ (page 55) fail... Ovidiu Maxiniuc

08:45 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

The keyword is specified in the schema (.df file) as an option on a field:... Greg Shah

12/19/2012

05:59 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I read about this option, but I found no examples of it's using. Maybe it depends on 4GL version?
Syntax like
..... Vadim Nebogatov

04:35 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Progress uses the keyword MANDATORY to denote a non-nullable field.
Thanks,
Eric Vadim Nebogatov

04:34 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Reading and investigation of Progress 4GL documentation as regards not-nullable fields. I did not find any field opti... Vadim Nebogatov

07:28 AM Base Language Feature #1591: implement QUOTER built-in function

Applied to staging and P2J was rebuilt. MAJIC was not reconverted or rebuilt. Constantin Asofiei

06:35 AM Base Language Feature #1611: implement QUOTER utility

Added proposed update.
Also found a bug regarding the error message when input file does not exist and fixed it, th... Costin Savin

03:23 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Current status:
* added .rules changes and in various files (like ExpressionConversion etc) for int64 support (more ... Ovidiu Maxiniuc

12/18/2012

05:50 PM Database Feature #1926: create an en_GB@p2j_basic locale definition

Here is the information screen for the @<db_name>@ database on windev01 from the Data Administration --> Utilities --... Eric Faulhaber

01:10 PM Base Language Feature #1591: implement QUOTER built-in function

OK, it looks good.
Good ahead and do the following:
1. Work with Constantin to get the update applied to stagin... Greg Shah

12:27 PM Base Language Feature #1591: implement QUOTER built-in function

Added update. I assumed null -> &lt;code&gt;null&lt;/code&gt;
Costin Savin

11:32 AM Base Language Feature #1591: implement QUOTER built-in function

There is still a javadoc problem.... Greg Shah

06:43 AM Base Language Feature #1591: implement QUOTER built-in function

Done conversion regression testing, there are no differences. Costin Savin

12:49 PM Base Language Feature #1626: implement OS-DIR support as an INPUT stream

... Greg Shah

11:45 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream

Updated the Input from OS-Dir Specifications.
Certain things are not 100% clear:
From the list of arguments only NO-... Costin Savin

12:47 PM Database Feature #1580: upgrade Hibernate to latest level

1. Found two representations of same collection -- a day, may be two to find the cause and make a solution
2. Sessio... Stanislav Lomany

11:39 AM Database Feature #1580: upgrade Hibernate to latest level

Please summarize the current status of all known issues with this task and estimate (if you can) how much effort you ... Eric Faulhaber

12:33 PM Base Language Feature #1611: implement QUOTER utility

8. Yes ran all the tests and checked results it all looks good.
Will also test again after making the changes from r... Costin Savin

12:02 PM Base Language Feature #1611: implement QUOTER utility

Feedback:
1. The text "This may be specified as a file or as a stream." in the javadoc for can be removed. Statin... Greg Shah

12:03 PM Base Language Feature #1920: implement persistent procedures

That is fine with me. Greg Shah

08:58 AM Base Language Feature #1920: implement persistent procedures

The MAJIC sources, beside the ControlFlowOps and handle.unwrap changes, has this change: frame.getScreeValue(widget) ... Constantin Asofiei

12/17/2012

06:02 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Variant above does not require aliases mapping because argument type is calculated in HQLPreprocessor.
I made one m... Vadim Nebogatov

02:39 PM Base Language Feature #1591: implement QUOTER built-in function

Attached wrong update before. This is the correct one Costin Savin

02:30 PM Base Language Feature #1591: implement QUOTER built-in function

Added proposed update, started the regression test Costin Savin

12:57 PM Base Language Feature #1611: implement QUOTER utility

I understand , the final code should be be fully documented, respect the coding standards entirely , tested and broug... Costin Savin

12:16 PM Base Language Feature #1611: implement QUOTER utility

7. The text description is wrong it's 4't included not 5'th included. Corrected
Costin Savin

11:50 AM Base Language Feature #1584 (WIP): add conversion and runtime support for INT64 and DATETIME data types

Ovidiu Maxiniuc

08:23 AM Database Feature #1580: upgrade Hibernate to latest level

Testcase for the "Found two representations of same collection" issue:... Stanislav Lomany

12/15/2012

05:54 PM Base Language Feature #1591: implement QUOTER built-in function

Feedback:
This javadoc for the 2 parameter version needs to be changed:... Greg Shah

05:21 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Approach described above is implemented, it works and on testing now.
But I have found one more problem.
If where... Vadim Nebogatov

12/14/2012

03:26 PM Base Language Support #1928 (WIP): update documentation to explain how to convert, develop and run P2J on Windows

Yes, these are the projects that need to be updated.... Greg Shah

02:15 PM Base Language Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

If my understanding is OK the you mean the following directories need to be updated:
p2j_books/conversion_handbook
... Eugenie Lyzenko

03:22 PM Base Language Feature #1611: implement QUOTER utility

Feedback, Part 2:
14. I think that preProcessQuoter() needs to be renamed. It leaves the impression that it is ju... Greg Shah

12:58 PM Base Language Feature #1611: implement QUOTER utility

Feedback, Part 1:
ProcessDaemon:
1. The file needs its copyright date updated.
2. The changes in prepareComm... Greg Shah

06:20 AM Base Language Feature #1611 (Review): implement QUOTER utility

Costin Savin

06:16 AM Base Language Feature #1611: implement QUOTER utility

Submitted testcases to bazaar added proposed update (revised and re-tested) Costin Savin

01:49 PM Database Feature #1580: upgrade Hibernate to latest level

> Did this behavior change from 3.0.5?
Yes, 3.0.5 just checks if there is the entity in the persistence context (reg... Stanislav Lomany

01:13 PM Database Feature #1580: upgrade Hibernate to latest level

Stanislav Lomany wrote:
> The "crossReferenceItem already exists with" issue is about Session.contains function. In ... Eric Faulhaber

06:42 AM Database Feature #1580: upgrade Hibernate to latest level

The "crossReferenceItem already exists with" issue is about Session.contains function. In Hibernate 4 it returns FALS... Stanislav Lomany

01:46 PM Database Feature #1911: add runtime support for sequences

Ovidiu Maxiniuc wrote:
> ...The fact is, this is the exact way PostgreSQL handles sequences and this should be a goo... Eric Faulhaber

11:21 AM Database Feature #1911: add runtime support for sequences

I have discovered something at least interesting today. The Progress/4GL 9 and OpenEdge/ABL 11 Reference books, both ... Ovidiu Maxiniuc

01:34 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Please focus on the conversion aspects of this task first and only stub out the runtime support at first. Start with... Eric Faulhaber

12:15 PM Database Feature #1910: add schema conversion support for sequences

As I created a new test case file for sequences I discovered that the @Sequencemanager.setValue()@ set of overloaded ... Ovidiu Maxiniuc

09:49 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream

After testing the simple case of OS-DIR usage (no options)... Costin Savin

07:27 AM Base Language Feature #1626 (WIP): implement OS-DIR support as an INPUT stream

Costin Savin

07:25 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I understood the reason of problem with nested SQL Functions invocation (NPE on parsing SQL Function argument time): ... Vadim Nebogatov

07:16 AM Base Language Feature #1591: implement QUOTER built-in function

Added revised proposed update. From what I understand there are plans to move code that is not character specific fro... Costin Savin

12/13/2012

06:33 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Testing on both Linux and Windows reports the changes in
com/goldencode/p2j/util/character.java
com/goldencode/p2j/... Eugenie Lyzenko

02:38 PM Base Language Feature #1611: implement QUOTER utility

discovered a bug will add new update once fixed. Costin Savin

01:26 PM Base Language Feature #1611: implement QUOTER utility

Added proposed update and edited the quoter description post . Costin Savin

11:45 AM Base Language Feature #1611: implement QUOTER utility

I know of these cases, but the current ProcessDaemon code does not support them. You don't need to support it at thi... Greg Shah

11:26 AM Base Language Feature #1611: implement QUOTER utility

implemented logic to check for quoter case in all the cases, however there are cases like:... Costin Savin

12:21 PM Database Feature #1926: create an en_GB@p2j_basic locale definition

I have done a first cut of this as described above, but I'm pretty sure it's not quite right yet.
I exported the c... Eric Faulhaber

12/12/2012

06:22 PM Base Language Feature #1611: implement QUOTER utility

Assuming you have handled all the known issues, you can prepare/upload the update. Make sure the documentation you h... Greg Shah

06:21 PM Base Language Feature #1611: implement QUOTER utility

The documentation is pretty good. Some comments:... Greg Shah

02:56 PM Base Language Feature #1611: implement QUOTER utility

*QUOTER UTILITY DESCRIPTION*
The quoter utility will put the elements identified and extracted from the
input... Costin Savin

02:55 PM Base Language Feature #1611: implement QUOTER utility

1. If a quoter command will be split in this way in p2j it will also not work in Progress. Checked.
2. This doesn'... Costin Savin

05:11 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Some tests are attached and passed as expected.
Now I am working with tests containing nested sql functions - not a... Vadim Nebogatov

02:33 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Your latest approach is all good except that we don't need a new p2j.cfg.xml parameter. We already have one that is ... Greg Shah

01:37 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Do not use the current conversion platform to determine how we convert strings. We can't go this route.
OK. I se... Eugenie Lyzenko

12/11/2012

05:27 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Do not use the current conversion platform to determine how we convert strings. We can't go this route. The problem... Greg Shah

03:32 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Fix for backslash processing for conversion on Windows.
The suggested solution will be activated only when running... Eugenie Lyzenko

09:22 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

This is all a single update. Greg Shah

09:08 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The Windows tests is OK too. I would like to make more tests with simulated two chars path separator to be sure this ... Eugenie Lyzenko

08:22 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Looks good. Greg Shah

04:44 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I have attached SQL Functions I am going to test now. Sorry, there are no proper comments and formatting just because... Vadim Nebogatov

02:49 PM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

02:41 PM Base Language Feature #1611: implement QUOTER utility

Please show an example here that reproduces the problem. And show the error output from the 4GL. Greg Shah

02:39 PM Base Language Feature #1611: implement QUOTER utility

There is one case of error message which might not be able to be reproduced exactly as in Progress. When we pass the ... Costin Savin

03:33 AM Base Language Feature #1611: implement QUOTER utility

That would be much easier since I already have these checks in place before doing the pattern check which is supposed... Costin Savin

12:50 PM Conversion Tools Bug #1929 (Closed): conversion system needs to be on the Internet during conversion

Closed since this is a duplicate of #1914. Greg Shah

12:48 PM Conversion Tools Bug #1929: conversion system needs to be on the Internet during conversion

Check if this is the case. A report was made by Eric that suggested that the conversion system needed remote access ... Greg Shah

12:47 PM Conversion Tools Bug #1929 (Closed): conversion system needs to be on the Internet during conversion

Greg Shah

12:44 PM Base Language Support #1928: update documentation to explain how to convert, develop and run P2J on Windows

Update all P2J books to describe how to:
- run conversion on Windows
- run P2J (client and server) on Windows
- se... Greg Shah

12:42 PM Base Language Support #1928 (Closed): update documentation to explain how to convert, develop and run P2J on Wi...

Greg Shah

12:05 PM Database Feature #1910: add schema conversion support for sequences

Ovidiu Maxiniuc wrote:
> The @_seqvals.d@ is indeed the default filename for exported sequence values. I documented ... Eric Faulhaber

11:29 AM Database Feature #1910: add schema conversion support for sequences

Changes in today's update:
* @src@ directory structure fixed
* @dbimport@ replaced @seqimp@
* fixed indentation/al... Ovidiu Maxiniuc

11:04 AM Base Language Feature #1921: implement super-procedures

I'm OK with your approach. Greg Shah

10:48 AM Base Language Feature #1921: implement super-procedures

After looking at progress.g, SymbolResolver.addFunction and Function.annotateOptions, the simplest way I see to solve... Constantin Asofiei

10:12 AM Base Language Feature #1921: implement super-procedures

If there are frame definition inside a "to-be-hidden" local function or procedure, then the frame definition "leaks" ... Constantin Asofiei

09:29 AM Base Language Feature #1921: implement super-procedures

My first approach is to just drop the sub-trees.
Thanks for the frame definition tip, I'll check also how these case... Constantin Asofiei

09:21 AM Base Language Feature #1921: implement super-procedures

What is your approach to handling this behavior? Do you just hide or drop the sub-trees?
One thing to consider: a... Greg Shah

09:02 AM Base Language Feature #1921: implement super-procedures

Greg, the order of the procedure/function is not important. No matter how you mix the procedures/functions in the abo... Constantin Asofiei

08:28 AM Base Language Feature #1921: implement super-procedures

Good findings. I find it hard to understand the value of this complexity. Much of the behavior seems arbitrary.
... Greg Shah

07:51 AM Base Language Feature #1921: implement super-procedures

4GL allows procedure (and function) definitions with the same name, under some circumstances.
If two or more procedu... Constantin Asofiei

12/10/2012

05:39 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The new version of the fixupPropath() method.
1. Handles the arbitrary length of the path separator
2. Optimizing f... Eugenie Lyzenko

09:58 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

... Greg Shah

09:16 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> The fixupPropath() should be a little different. I don't want getPathSeparator() called more than once, because it ... Eugenie Lyzenko

08:24 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

I am OK with the changes to setSearchPath(), getPathSeparator(), getLegacyPathSeparator() and getLegacyFileSeparator(... Greg Shah

03:09 PM Conversion Tools Feature #1514: implement fully dynamic reports (backed by the database)

The scope of the reports should be chosen by the user:
- file-level
- a specific/arbitrary list of files
- an en... Greg Shah

03:07 PM Base Language Feature #1611: implement QUOTER utility

Is there anything wrong with my assumption that the path and the executable name will be in the same string AND that ... Greg Shah

03:01 PM Base Language Feature #1611: implement QUOTER utility

I've tried to cover that, here is an example for the latest pattern I've gotten today:... Costin Savin

02:55 PM Base Language Feature #1611: implement QUOTER utility

Costin: yes, we should handle paths on network shares.
Are we making this too difficult? The basic matching seem... Greg Shah

01:48 PM Base Language Feature #1611: implement QUOTER utility

> Should also windows network paths be detected as paths for quoter?
> I'm having a little trouble with the regular ... Eugenie Lyzenko

01:40 PM Base Language Feature #1611: implement QUOTER utility

Should also windows network paths be detected as paths for quoter?
I'm having a little trouble with the regular expr... Costin Savin

02:34 PM Database Feature #1580: upgrade Hibernate to latest level

About "Found two representations"-related issues:
1. In the first issue ("crossReferenceItem already exists with") p... Stanislav Lomany

02:19 PM Database Feature #1910: add schema conversion support for sequences

After you finish with the code changes resulting from the above code reviews, please review all places in the P2J Con... Eric Faulhaber

02:12 PM Database Feature #1910: add schema conversion support for sequences

Code review 1210b:
* Nice work! I'm excited to give this a test run with a real database.
* Is _seqvals.d a hard... Eric Faulhaber

01:38 PM Database Feature #1910 (WIP): add schema conversion support for sequences

Eric Faulhaber

01:38 PM Database Feature #1910: add schema conversion support for sequences

Code review 1210a:
Please note that the following files in your zip file:... Eric Faulhaber

11:11 AM Database Feature #1910 (Review): add schema conversion support for sequences

Added sequence current value import Ovidiu Maxiniuc

06:59 AM Database Feature #1910: add schema conversion support for sequences

Moved the generation of sequence ddl from .schema to .p2o file. Ovidiu Maxiniuc

11:37 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Vadim Nebogatov wrote:
> The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree l... Eric Faulhaber

12/08/2012

01:40 AM Database Feature #1580: upgrade Hibernate to latest level

> Yes, this needs to be fixed, but I'm not sure what the issue is here. In build.xml, we copy the ehcache configurat... Stanislav Lomany

12/07/2012

05:59 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The fix for path separator in PROPATH handling issue.
The idea is to have the helper method fixupPropath(String pr... Eugenie Lyzenko

05:26 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

The arguments passed to SQLFunction are strings; we can parse them separately to Ast tree like method parse() does:
... Vadim Nebogatov

12:50 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Vadim Nebogatov wrote:
> I tried to find out also how to simplify first approach for constant expressions and for no... Eric Faulhaber

02:53 PM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

02:45 PM Base Language Feature #1611: implement QUOTER utility

1.Already tested by copying the quoter executable in a path containing spaces and it works.
2. Working on it, my q... Costin Savin

02:37 PM Base Language Feature #1611: implement QUOTER utility

Yes, Eugenie found this as well. He is working on it.
In the meantime, you should do 2 things:
1. Make sure th... Greg Shah

02:16 PM Base Language Feature #1611: implement QUOTER utility

Coming back to the case of converting:... Costin Savin

11:53 AM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

11:41 AM Base Language Feature #1611: implement QUOTER utility

Is it safe to consider that if the code is converted with a certain OS specific it will also only be run in that OS?
... Costin Savin

02:48 PM Database Feature #1581: add conversion and runtime support for certain metadata constructs

Discussed with Greg. Probably the best approach is to use an embedded H2 database to provide access to these metadat... Eric Faulhaber

01:54 PM Database Feature #1583: add conversion and runtime support for the INSERT language statement

Code looks good, but I should not have suggested that this go into post-parse fixups. This is too early, and it will... Eric Faulhaber

01:01 PM Database Feature #1580: upgrade Hibernate to latest level

Stanislav Lomany wrote:
> 6. "(net.sf.ehcache.config.ConfigurationFactory:WARNING) No configuration found. Configuri... Eric Faulhaber

12:29 AM Database Feature #1580: upgrade Hibernate to latest level

I'm not so sure this behavior is about an unstable release. But I think you are right that the select statement is p... Eric Faulhaber

05:36 AM Base Language Feature #1921: implement super-procedures

Entry 43 for #1920 was added a test update which covers the conversion rules for both persistent and super-procedures... Constantin Asofiei

05:33 AM Base Language Feature #1920: implement persistent procedures

Attached there is a test update which contains:
1. rules/ - all rules files which affect the conversion of persisten... Constantin Asofiei

12/06/2012

03:37 PM Base Language Feature #1884: add some of the v10 data types and core built-ins

_*TextOps class*_
I'm attaching an update containing:
- the TextOps class including fields and (static and some uti... Adrian Lungu

03:22 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

... Greg Shah

02:54 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

You mean the current conversion "C:\Windows\system;C:\Users\Eugenie\bin;" to "C:Windowssystem;C:Users\033ugenie\bin;"... Eugenie Lyzenko

02:32 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

3. Yes, what I see in 4GL is predefined Progress-specific path. The code to display PROPATH:... Eugenie Lyzenko

02:23 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

1. The conversion of string literals when the target is Windows, should already double up the \ characters, but in th... Greg Shah

02:09 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Make sure your p2j.cfg.xml is properly setup for Windows conversions. This should not be happening.
The p2j.cfg.... Eugenie Lyzenko

10:53 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

... Greg Shah

02:52 PM Base Language Feature #1611: implement QUOTER utility

Tested for
to see the values from readFile.read() when the logic gets to them... Costin Savin

12:35 PM Base Language Feature #1611: implement QUOTER utility

available() just tells you if you are going to block or not on a read. If it returns > 0 then you will not block if ... Greg Shah

11:58 AM Base Language Feature #1611: implement QUOTER utility

The case I'm refferring to is when readFile is a BufferedReader pointing to System.in, in case readFile points to a f... Costin Savin

11:29 AM Base Language Feature #1611: implement QUOTER utility

I don't understand how the readFile.read() can help in this case. If readLine() returns null but you are not at EOF,... Greg Shah

11:09 AM Base Language Feature #1611: implement QUOTER utility

Actually this is the problem
readFile.readLine()) can return null if the stream hasn't put anything on yet and in th... Costin Savin

11:02 AM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

10:30 AM Base Language Feature #1611: implement QUOTER utility

The readFile is a BufferedReader obtained in this way:... Costin Savin

10:10 AM Base Language Feature #1611: implement QUOTER utility

Looking closer at the FileStream sub-class (which is the closest match) I don't think there is an easy way to turn a ... Greg Shah

10:01 AM Base Language Feature #1611: implement QUOTER utility

Which Stream can I use?
Looking at the com.goldencode.p2j.util.Stream implementations:
*FileStream* constructor... Costin Savin

09:19 AM Base Language Feature #1611: implement QUOTER utility

How about using one of the com.goldencode.p2j.util.Stream sub-classes to read the input? We have already written thi... Greg Shah

09:10 AM Base Language Feature #1611: implement QUOTER utility

1. You are right about the conversion settings I had them for Unix, will add the logic to handle this case.
2. Nor... Costin Savin

08:19 AM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

10:28 AM Database Feature #1910: add schema conversion support for sequences

Please make this issue your highest priority (including the import of current sequence values). We need to deliver a ... Eric Faulhaber

10:23 AM Database Feature #1910: add schema conversion support for sequences

Taking into consideration that the rules are more or less the same, a couple of hours should be enough to move the so... Ovidiu Maxiniuc

09:53 AM Database Feature #1910: add schema conversion support for sequences

I'm sorry, but in my review of your initial updates, I didn't notice that you were generating the sequence DDL from t... Eric Faulhaber

02:35 AM Database Feature #1910: add schema conversion support for sequences

I observed yesterday that the converted data dictionary file .p2o does not contains any reference to the sequence. Th... Ovidiu Maxiniuc

08:57 AM Database Feature #1580: upgrade Hibernate to latest level

About "Found two representations". After I've inserted the following code right after deletion of the target item the... Stanislav Lomany

02:09 AM Database Feature #1580: upgrade Hibernate to latest level

> Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but ... Stanislav Lomany

08:41 AM Base Language Feature #1920: implement persistent procedures

We have task #1634 which is where we will work on the rest of the native procedure support. I agree with your plan f... Greg Shah

02:39 AM Base Language Feature #1920: implement persistent procedures

My conclusions about native-procedure (PROCEDURE ... EXTERNAL cases) are:
* when a 4GL external procedure has a head... Constantin Asofiei

08:38 AM Base Language Feature #1634: implement full native library (.so or DLL) support

Please look at #1920-41 and the related prior notes for some very useful information regarding native procedures. Greg Shah

12/05/2012

05:38 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The following features were confirmed as working in native 4GL in Windows:
FILE-INFO:FILE-CREATE-DATE file_system_tr... Eugenie Lyzenko

05:35 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Several notes for PROPATH get/set functionality
1. The P2J converts, compile and run the PROPATH statement.
2. The ... Eugenie Lyzenko

03:03 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Yes, we should implement a Windows-specific default (what is it?) in EnvironmentOps. I don't want to have to put so... Eugenie Lyzenko

02:45 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

... Greg Shah

07:03 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The following calls has testcases to verify conversion result in Windows:... Eugenie Lyzenko

04:20 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I also think it is hard to predict now how will SQLFunction approch affect caching and performance. I hope not very m... Vadim Nebogatov

02:39 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

As far as when to do it, I would say to do a quick and dirty test soon if possible. You want to know now if there is... Greg Shah

02:00 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

AFAIK, we have not done any work to determine the potential performance penalty.
We will have to look at some typi... Eric Faulhaber

01:28 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Eric: my questions were not related to the potential worry that you have about performance issues. I was fully aware... Greg Shah

03:05 PM Base Language Feature #1611: implement QUOTER utility

@OS-COMMAND "c:\my stupid space \laden path\quoter.exe" -C 45-50 whatever > output.txt@
this kind of call might be... Costin Savin

01:32 PM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

02:32 PM Base Language Feature #1920: implement persistent procedures

... Greg Shah

01:49 PM Base Language Feature #1920: implement persistent procedures

1 - yes, I refer to PROCEDURE ... EXTERNAL case
2 - I don't have a fully working example (i.e. I don't have a dll ... Constantin Asofiei

01:23 PM Base Language Feature #1920: implement persistent procedures

Some questions/comments:
1. What do you mean by "native-proc"? Do you mean the invocation of something defined as... Greg Shah

12:47 PM Base Language Feature #1920: implement persistent procedures

Greg, should I add support for the "h:<read-only-attribute> = value" cases too ? Because 4GL does allow them (shows a... Constantin Asofiei

11:35 AM Base Language Feature #1920: implement persistent procedures

All RUN cases are handled by these rules:
- ControlFlowOps.invoke(String name, Object ... param) will be emitted for... Constantin Asofiei

02:15 PM Database Feature #1580: upgrade Hibernate to latest level

Good work on finding a reliable recreate. Please open a new bug issue in the database project for this error, but do... Eric Faulhaber

10:57 AM Database Feature #1580: upgrade Hibernate to latest level

About... Stanislav Lomany

11:51 AM Database Feature #1911: add runtime support for sequences

I spoke with Greg about this and he suggested a much more efficient (and simpler) solution:
Add flags to the direc... Eric Faulhaber

12/04/2012

06:43 PM Base Language Feature #1611: implement QUOTER utility

Greg: yes, the calls input through, output through and input-output through has the problem in Windows running after ... Eugenie Lyzenko

12:22 PM Base Language Feature #1611: implement QUOTER utility

Are there more possible extensions quoter can have besides .exe, on unix maybe? Using Quoter with a path containing s... Costin Savin

08:48 AM Base Language Feature #1611: implement QUOTER utility

In regards to note 36 (https://projsrv01/redmine/issues/1611#note-36):
Eugenie: please read that note carefully. Y... Greg Shah

04:27 AM Base Language Feature #1611: implement QUOTER utility

Greg, what Costin saw I think is a difference between how 4GL behaves on Windows and Linux environments. Assuming we ... Constantin Asofiei

06:05 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Investigation SQLFunctions processing in Hibernate&Antlr source code. SqlGenerator invokes SQLFunction.render() metho... Vadim Nebogatov

12:29 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Greg Shah wrote:
> Did I miss this?
Apparently, yes, you missed the post (# 49) where I voiced my concern about p... Eric Faulhaber

12:14 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Greg Shah wrote:
> I didn't realize that we already had eq and ne. When are they used? I previously thought that w... Eric Faulhaber

08:23 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Did I miss this? Is there a performance penalty to using the SQLFunction approach?
Also, what is the performance ... Greg Shah

08:22 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

equals and not_equals seem fine to me.
I didn't realize that we already had eq and ne. When are they used? I pre... Greg Shah

12:23 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Eric Faulhaber wrote:
> ...or even @eq@ and @neq@?
I just remembered @eq@ and @ne@ already are user defined funct... Eric Faulhaber

12:13 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

OK, it appears you have determined the SQLFunction approach is feasible. Let's go with it and see how it performs. ... Eric Faulhaber

09:06 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Hold it until we have all the changes ready for the task. Greg Shah

08:49 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

See https://projsrv01/redmine/issues/1611#note-36 for some useful notes. Greg Shah

01:43 AM Database Feature #1911: add runtime support for sequences

The implementation a service thread for handling sequence primitives (current/next/set) like this:
- the current val... Ovidiu Maxiniuc

12/03/2012

04:54 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Concerning Example 3:
I tested with H2 database: for case f1=true, f2=true expression
(tt.f1 != true and tt.f2... Vadim Nebogatov

04:29 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Do we need this change to be integrated into current P2J build? I mean regression testing and checking in to bzr? Or ... Eugenie Lyzenko

02:50 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

It looks good. Remove the MacOS support from indexOfNewLine() and go with it. Greg Shah

10:38 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

OK. The suggested helper is the method in Stream class:... Eugenie Lyzenko

09:43 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Although the Stream use of searching for NEWLINE isn't causing a problem right now, I still want it to be fixed. Try... Greg Shah

02:47 PM Base Language Feature #1611: implement QUOTER utility

I don't understand. My recent suggestion to modify ProcessDaemon to transform "quoter" into "java ... com.goldencode... Greg Shah

02:13 PM Base Language Feature #1611: implement QUOTER utility

Would launching the Quoter as a separate process be a solution for this? Costin Savin

10:40 AM Base Language Feature #1611: implement QUOTER utility

Compared p2j implementation results to progress,however there seems to be one problem :
When we use it in p2j the co... Costin Savin

01:23 PM Database Feature #1580: upgrade Hibernate to latest level

OK, it sounds like caching the Hibernation Configuration objects by schema is no longer a safe thing to do with this ... Eric Faulhaber

01:05 PM Database Feature #1580: upgrade Hibernate to latest level

> What "type" resource was scoped to one SessionFactory that is now being scoped to another? In other words, what re... Stanislav Lomany

12:06 PM Database Feature #1580: upgrade Hibernate to latest level

Stanislav Lomany wrote:
> ... Eric Faulhaber

09:44 AM Database Feature #1580: upgrade Hibernate to latest level

>The root cause might be because the ConnectionManager.local.cleanup is executed before the Persistence.Context.clean... Stanislav Lomany

08:56 AM Database Feature #1580: upgrade Hibernate to latest level

> 3. "error closing Hibernate session" is caused by fact that the session with a remote database is closed on applica... Constantin Asofiei

05:57 AM Database Feature #1580: upgrade Hibernate to latest level

Warning that appears when multiple servers are executed on the same machine:... Stanislav Lomany

05:53 AM Database Feature #1580: upgrade Hibernate to latest level

1.... Stanislav Lomany

12/02/2012

06:21 AM Database Feature #1580: upgrade Hibernate to latest level

The following issue:... Stanislav Lomany

11/30/2012

06:12 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

All the following calls from the file_system.odt have testcases, converts and run in Windows environment:... Eugenie Lyzenko

06:01 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

I just retested and have the correction. The case 1 can be left untouched. And moreover case 2 can be unchanged too. ... Eugenie Lyzenko

05:10 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Is case 1 really a problem? That is about writing a newline, not searching for one. I think it should write the loc... Greg Shah

11/29/2012

04:24 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

SQLFunctionTemplate does not allow repeating parameters, but direct implementation of SQLFunction interface seems res... Vadim Nebogatov

04:20 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

SQLFunction approach (SQLFunctions are already in Hibernate v3.0.5).
I have added
registerFunction("p2j... Vadim Nebogatov

03:42 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The investigation results:
Affected code is located in com.goldencode.p2j.util package, classes Stream and FileStrea... Eugenie Lyzenko

09:29 AM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

09:27 AM Base Language Feature #1611: implement QUOTER utility

Constantin, you raise some good points.
Here are the differences as I know them:
- On Windows, the executable... Greg Shah

09:19 AM Base Language Feature #1611: implement QUOTER utility

Related to this
Quoter syntax is:
@quoter [options] [input_file] >[output_file]@
In the quoter implementation I... Costin Savin

03:13 AM Base Language Feature #1611: implement QUOTER utility

I don't think it is that easy to replace "quoter" references from the process-launching command with the "java ..." c... Constantin Asofiei

05:35 AM Database Feature #1580: upgrade Hibernate to latest level

> When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack t... Stanislav Lomany

10:30 PM Database Feature #1580: upgrade Hibernate to latest level

When those first warnings appear in the log, is it just the messages themselves, or is there any associated stack tra... Eric Faulhaber

11:25 PM Database Feature #1582: add conversion and runtime support for sequences

Some additional code review comments for the 1123a drop:
* How is CustomSequence to be used? AFAIK, Progress sequ... Eric Faulhaber

10:40 PM Database Feature #1911: add runtime support for sequences

If we need transaction processing separate from the current (application-defined) database transaction, it sounds lik... Eric Faulhaber

11/28/2012

03:33 PM Database Feature #1580: upgrade Hibernate to latest level

I looked at the original log carefully and now we have reproduction:
V-C-select RFQ-Enter (RFQ server should be runn... Stanislav Lomany

10:26 AM Database Feature #1580: upgrade Hibernate to latest level

Stas, my conclusion about this being a threading issue was based on some cursory Internet research. Please dig into ... Eric Faulhaber

06:09 AM Database Feature #1580: upgrade Hibernate to latest level

Stanislav,
From the org.hibernate.Session javadoc (http://docs.jboss.org/hibernate/orm/4.1/javadocs/org/hibernate/Se... Constantin Asofiei

05:54 AM Database Feature #1580: upgrade Hibernate to latest level

A session CAN be closed in another thread:... Stanislav Lomany

01:27 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

OK. Please propose a fix as part of this task. Greg Shah

12:51 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The testing respective 4GL program in Windows OpenEdge10 discovers the 4GL accepts both Linux and Windows style line ... Eugenie Lyzenko

08:18 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Yes and yes. Correct. Greg Shah

07:17 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

> Please test the same case in 4GL on Windows. In other words: does the 4GL properly honor the Linux line end the sam... Eugenie Lyzenko

11:06 AM Database Feature #1911: add runtime support for sequences

An issue related to PSQL, but not only:
On a finite, non cycling sequences, calling @nextVal@ will return an error... Ovidiu Maxiniuc

09:39 AM Base Language Feature #1590 (Closed): implement PROPATH assignment

Greg Shah

09:00 AM Base Language Feature #1590 (Review): implement PROPATH assignment

Costin Savin

08:45 AM Base Language Feature #1611: implement QUOTER utility

Constantin: you make very good points here. Yes, these other cases are problems. And the client-side invocation is ... Greg Shah

08:28 AM Base Language Feature #1611: implement QUOTER utility

Tested @INPUT THROUGH@ and @OUTPUT THROUGH@ stream case and they are viable.
The @INPUT-OUTPUT THROUGH@ stream case ... Costin Savin

07:10 AM Base Language Feature #1611: implement QUOTER utility

Greg, some thoughts about the QUOTER utility: as this is an external program invoked via the OS-COMMAND and other pro... Constantin Asofiei

04:18 AM Database Feature #1583 (Review): add conversion and runtime support for the INSERT language statement

Ovidiu Maxiniuc

04:18 AM Database Feature #1583 (WIP): add conversion and runtime support for the INSERT language statement

Ovidiu Maxiniuc

04:15 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement

I first tested if the sequence of CREATE/UPDATE has the same effect like @INSERT@. My fear was that if user skips the... Ovidiu Maxiniuc

11/27/2012

06:58 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

It is an interesting finding (about the Linux line ending not being honored in P2J on Windows). Please test the same... Greg Shah

06:06 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

The second part of the stream chapter:... Eugenie Lyzenko

06:32 PM Database Feature #1580: upgrade Hibernate to latest level

Eric Faulhaber wrote:
> ... Although I haven't looked at the latest Hibernate source, I suspect Hibernate is using a... Eric Faulhaber

06:21 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Please explain your SQLFunction idea more fully. It is intriguing.
I think this is a relatively new feature in Hi... Eric Faulhaber

06:03 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

How to proceed with this task?.. Vadim Nebogatov

04:57 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

One more option is providing a custom comparing functions (org.hibernate.dialect.function.SQLFunction) registered wit... Vadim Nebogatov

04:29 PM Base Language Feature #1611: implement QUOTER utility

... Greg Shah

01:20 PM Base Language Feature #1611: implement QUOTER utility

... Costin Savin

12:33 PM Base Language Feature #1611: implement QUOTER utility

Made the changes according to feedback, there's some issue though:... Costin Savin

07:39 PM Base Language Feature #1611 (WIP): implement QUOTER utility

This is much better.
Feedback:
1. What are the results of your testing with these options? I see that you have ... Greg Shah

09:59 AM Base Language Feature #1591: implement QUOTER built-in function

This javadoc:... Greg Shah

08:56 AM Base Language Feature #1591: implement QUOTER built-in function

Attached proposed update Costin Savin

11/26/2012

06:22 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I agreed absolutely. But it seems there is no choice if you want to fix this issue on the HQL level.
My draft idea ... Vadim Nebogatov

12:05 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Vadim Nebogatov wrote:
> > I don't remember this being a supported operator in HQL.
> What operator did you mean? H... Eric Faulhaber

04:50 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Correct. Greg Shah

04:13 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

Need to clarify in requirements for the following resources:... Eugenie Lyzenko

01:24 PM Base Language Feature #1611: implement QUOTER utility

Added proposed update, commityed testcases to bazaar, run regression tests (to see if they don't fail because of the ... Costin Savin

12:59 PM Database Feature #1666: add support for mixed-direction indexes

I use PostgreSQL 9.1 (not the latest available version but what I have installed) to test this issue. Also I have a p... Ovidiu Maxiniuc

12:41 PM Base Language Feature #1920: implement persistent procedures

... Greg Shah

12:02 PM Base Language Feature #1920: implement persistent procedures

A "message h:next-sibling:prev-sibling:next-sibling:name." statement gets parsed this way (from .parser file):... Constantin Asofiei

11:15 AM Base Language Feature #1920: implement persistent procedures

I wonder if treating COLON as a binary operator will help with the conversion.
I also wonder if we are parsing cha... Greg Shah

09:14 AM Base Language Feature #1920: implement persistent procedures

Understood and agreed. Greg Shah

09:12 AM Base Language Feature #1920: implement persistent procedures

One thing about handle.unwrap. 4GL allows these kind of calls:... Constantin Asofiei

09:11 AM Base Language Feature #1920: implement persistent procedures

> In regards to the RUN <proc> PERSISTENT, is that a case where we know that <proc> is an external procedure (or shou... Constantin Asofiei

09:03 AM Base Language Feature #1920: implement persistent procedures

Sorry, I wish I was wrong on this point.
In regards to the RUN <proc> PERSISTENT, is that a case where we know tha... Greg Shah

03:33 AM Base Language Feature #1920: implement persistent procedures

Greg, you are correct, 4GL allows '.', '\' and '/' characters as part of an internal procedure's name; so, we can't d... Constantin Asofiei

12:26 PM Database Feature #1926: create an en_GB@p2j_basic locale definition

Model this after locale/en_US@p2j_basic, customizing LC_CTYPE and LC_COLLATE sections. Use en_GB as a basis instead ... Eric Faulhaber

12:22 PM Database Feature #1926 (Hold): create an en_GB@p2j_basic locale definition

Eric Faulhaber

11/25/2012

04:56 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Yes, you are correct, I did not notice that issue concerns NHibernate, but all others I wrote about Hibernate.
CA... Vadim Nebogatov

02:04 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Vadim Nebogatov wrote:
> IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do ... Eric Faulhaber

12:25 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

IS [NOT] DISTINCT FROM predicate is not supported with Hibernate and it seems they even do not plan to support it:
... Vadim Nebogatov

11/24/2012

05:00 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Vadim Nebogatov wrote:
> What about limitations for SQL statement length which some databases have? Resulting SQL st... Eric Faulhaber

03:30 PM Database Feature #1911 (WIP): add runtime support for sequences

Eric Faulhaber

03:25 PM Database Feature #1666: add support for mixed-direction indexes

Highest priority sub-tasks of this issue should be:
# to fix the creation of indexes during the data import proces... Eric Faulhaber

11/23/2012

06:01 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Yes, I understand this. Converted code will be not affected in this case, HQLAst and parameter list changes should be... Vadim Nebogatov

05:53 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I'll let Eric comment on all the other good information and questions you have posed.
The only thing I want to mak... Greg Shah

05:34 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

What about limitations for SQL statement length which some databases have? Resulting SQL statement could be very heavy. Vadim Nebogatov

05:15 PM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

I have found out that not only inequality should be replaced but equality also work incorrectly in some cases.
Very ... Vadim Nebogatov

04:42 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues

For now the following features described in streams.odt chapter have testcases to demonstrate conversion in Windows. ... Eugenie Lyzenko

01:26 PM Database Feature #1582 (WIP): add conversion and runtime support for sequences

I have reviewed the progress.g changes. They are fine. My only request is for you to please change the ending copyr... Greg Shah

12:04 PM Database Feature #1582: add conversion and runtime support for sequences

My answers/comments to your questions:
* There is no separate ddl file generated for sequences. Only the xml that ge... Ovidiu Maxiniuc

01:03 AM Database Feature #1582: add conversion and runtime support for sequences

I have done only a very high-level review of the update so far, and it looks like you've addressed all the necessary ... Eric Faulhaber

11:23 AM Base Language Feature #1920: implement persistent procedures

About the static calculation of called code in a RUN statement, I am concerned with this information you posted in #1... Greg Shah

10:37 AM Base Language Feature #1920: implement persistent procedures

Actually, the only case when conversion knows for sure what to emit is the RUN filename statement, when the filename ... Constantin Asofiei

08:56 AM Base Language Feature #1920: implement persistent procedures

... Greg Shah

08:36 AM Base Language Feature #1591: implement QUOTER built-in function

... Greg Shah

08:32 AM Database Feature #1580: upgrade Hibernate to latest level

I don't like putting a Hibernate-specific hack into our more generic implementation.
Let's back up a bit. In what... Greg Shah

11/22/2012

03:04 PM Database Feature #1580: upgrade Hibernate to latest level

Eric, at 3 I'm not saying that is not feasible; as only Conversation threads can create hibernate Sessions, at a firs... Constantin Asofiei

01:16 PM Database Feature #1580: upgrade Hibernate to latest level

Regarding points 1 & 2 in the previous post: currently, there is no creation of Hibernate Session objects on anythin... Eric Faulhaber

11:42 AM Database Feature #1580: upgrade Hibernate to latest level

Thoughts about context cleanup:
# If the we decide to clean the Hibernate session on the Conversion thread, then we ... Constantin Asofiei

11:02 AM Database Feature #1580: upgrade Hibernate to latest level

The Hibernate Session objects are created on the conversation thread (for that matter, all persistence runtime code o... Eric Faulhaber

09:52 AM Database Feature #1580: upgrade Hibernate to latest level

I don't think it is as simple as you suggest. By its nature, all contexts are accessed from multiple threads. At a ... Greg Shah

12:56 AM Database Feature #1580: upgrade Hibernate to latest level

Regarding the error...... Eric Faulhaber

12:35 AM Database Feature #1580: upgrade Hibernate to latest level

Eric Faulhaber wrote:
> How common was the
>
> [...]
>
> error in the regression server log? This looks a lot... Stanislav Lomany

12:28 AM Database Feature #1580: upgrade Hibernate to latest level

How common was the... Eric Faulhaber

11:17 AM Base Language Feature #1920: implement persistent procedures

1 - This would be my choice too.
2 - Yes
3 - If there is only one handle.unwrap method to access the attributes... Constantin Asofiei

10:29 AM Base Language Feature #1920: implement persistent procedures

In regard to the handle issue:... Greg Shah

06:36 AM Base Language Feature #1920: implement persistent procedures

Another thing about RUN filename PERSIST [SET handle] statement. We can either emit this something like (for a RUN te... Constantin Asofiei

04:57 AM Base Language Feature #1920: implement persistent procedures

Greg, something about the handle attributes in general. In 4GL, a code like this:... Constantin Asofiei

11:13 AM Base Language Feature #1591: implement QUOTER built-in function

1. This issue seems to appear when I recheck the files from the zip before submitting, I'm aware of it now.
3.... Costin Savin

09:44 AM Base Language Feature #1591: implement QUOTER built-in function

Feedback:
1. The file rules/convert/builtin_functions.rules~ should not be in the update zip.
2. There are stil... Greg Shah

02:58 AM Base Language Feature #1591 (Review): implement QUOTER built-in function

Costin Savin

11:01 AM Database Feature #1582: add conversion and runtime support for sequences

Uploaded update patch that covers both conversion and runtime sub-tasks (1910 and 1911). Ovidiu Maxiniuc

09:17 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement

Yes, I agree completely. So far we have almost never seen this statement used in practice. It is an interesting com... Greg Shah

12:17 AM Database Feature #1583: add conversion and runtime support for the INSERT language statement

Greg,
There are only 4 uses of this statement across both projects (all in the server project), and they are all o... Eric Faulhaber

06:17 AM Database Feature #1911: add runtime support for sequences

I discovered a way to access the current value in PostgreSQL without calling @CURRVAL@ which fails if it's called bef... Ovidiu Maxiniuc

12:21 AM Database Bug #18: issues with ne/equal and true/false conversion in WHERE clauses

Yes, I agree, let's put it in the HQLPreprocessor. Eric Faulhaber