Project

General

Profile

Activity

From 06/21/2015 to 07/20/2015

07/20/2015

06:05 PM User Interface Feature #2252: implement GUI client support
Rebased task branch 2424b from P2J trunk revision 10897 (branch revision 10898). Hynek Cihlar
05:13 PM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10897 (branch revision 10916).
Constantin Asofiei
05:49 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10898@.
The fixes including:
1. Fix for wrong initial selecti...
Eugenie Lyzenko
10:41 AM User Interface Feature #2546: implement combo-box widget in GUI
Created task branch @2546b@ from P2J trunk revision @10897@. Eugenie Lyzenko
10:41 AM User Interface Feature #2546: implement combo-box widget in GUI
The branch @2546a@ has been merged and committed to trunk as revision @10897@. Archived. Eugenie Lyzenko
10:28 AM User Interface Feature #2546: implement combo-box widget in GUI
>Also, somethign else: P2J automatically selects first element in this test, while 4GL does not...
For this issue,...
Eugenie Lyzenko
08:14 AM User Interface Feature #2546: implement combo-box widget in GUI
Please merge task branch 2546a to trunk, commit and send the notification email. Greg Shah
05:17 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
About the FRAME-COL/ROW/X/Y coordinate attributes: the current BaseConfig.column/row/x/y fields are actually for the ... Constantin Asofiei
03:02 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this t...
Igor Skornyakov
03:00 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
> Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this task?
Yes.
Greg Shah
01:34 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added NO-TAB-STOP option and TAB-STOP attribute conversion support. Commited to branch 2567a. New revno 10905.
Gre...
Igor Skornyakov
11:45 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added CONTEXT-HELP-ID conversion and runtime support. Commited to branch 2567a. New revno 10904 Igor Skornyakov
11:05 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added DEBLANK conversion and runtime support. Commited to branch 2567a. New revno 10903 Igor Skornyakov
07:23 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added BLANK conversion and runtime support. Commited to branch 2567a. New revno 10902 Igor Skornyakov
05:17 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added PASSWORD-FIELD runtime support. Commited to branch 2567a. New revno 10901 Igor Skornyakov
03:45 PM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> 1. What about the case of letters? Note, that "PgDn" is shown in the specified testcase, but D...
Constantin Asofiei
03:29 PM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Here it is
> >
> > [...]
> >
> > Have a look how the menu...
Vadim Gindin
03:09 PM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Here it is
>
> [...]
>
> Have a look how the menu-item "Mi1 item" looks. It's accelerato...
Constantin Asofiei
02:32 PM User Interface Feature #1790: implement menu support
Here it is... Vadim Gindin
02:16 PM User Interface Feature #1790: implement menu support
Greg Shah wrote:
> Greg Shah wrote:
> > > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labe...
Constantin Asofiei
10:11 AM User Interface Feature #1790: implement menu support
Greg Shah wrote:
> > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN...
Greg Shah
10:04 AM User Interface Feature #1790: implement menu support
> It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN", "NEXT-PAGE", "NEX... Greg Shah
10:22 AM User Interface Feature #2422: add features to BROWSE
It is OK to base your work on the unoptimized/current approach, but please:
1. Add a comment to the @ConfigManager...
Greg Shah
10:19 AM User Interface Feature #2422: add features to BROWSE
That is interesting:... Stanislav Lomany
09:54 AM User Interface Feature #2422: add features to BROWSE
> # Widget re-creation resets its backup configuration. Backup configuration should match the previous state sent to ... Greg Shah
09:19 AM User Interface Feature #2422: add features to BROWSE
Rebased task branch 2422b from P2J trunk revision 10896. Stanislav Lomany
05:24 AM User Interface Feature #2422: add features to BROWSE
Greg, for editing cells we have a single @FillInWidget@ for each column. Its configuration is send to the client and ... Stanislav Lomany
10:08 AM Base Language Bug #2592: improve support for implicit type conversions
> Using the BaseDataType could be a solution, but we need to store somewhere the compatibility matrix. I guess this w... Greg Shah

07/19/2015

06:03 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Added PASSWORD-FIELD conversion support. Commited to branch 2567a. New revno 10900 Igor Skornyakov
03:15 PM User Interface Feature #1790: implement menu support
It seems, that GUI menu widgets use only system colors. Documentation says that it is possible to set bgcolor and fgc... Vadim Gindin

07/18/2015

01:59 PM Database Bug #1914: database conversion requires Internet connectivity
Currently, this is what http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd returns:
"The sourceforge.net w...
Eric Faulhaber
11:46 AM User Interface Feature #2546: implement combo-box widget in GUI
Greg,
According to handbook rules I'm waiting for approval confirmation to start merging the branch into the trunk.
Eugenie Lyzenko
11:34 AM User Interface Feature #2546: implement combo-box widget in GUI
Testing completed without regressions. Had to start @CTRL-C@ 3-way tests in a separate session. The results are in @2... Eugenie Lyzenko
09:20 AM User Interface Feature #2546: implement combo-box widget in GUI
The main part for @2546a@ finished without regressions, running the @CTRL-C@ one. Eugenie Lyzenko
09:20 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Perhaps it makes sense to work on other attributes first? That would give Constantin time to fix...
Igor Skornyakov
08:21 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > This is again a bug in @ZeroColumnLayout@. Although server logic c...
Greg Shah
07:57 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> This is again a bug in @ZeroColumnLayout@. Although server logic correctly assigns the widget'...
Igor Skornyakov
07:40 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I've used the attached test to understand the correlation between ROW/COLUMN and FRAME-ROW/...
Hynek Cihlar
05:35 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
I've used the attached test to understand the correlation between ROW/COLUMN and FRAME-ROW/FRAME-COL attributes. It s... Igor Skornyakov

07/17/2015

07:17 PM Database Bug #1914: database conversion requires Internet connectivity
Majic changes for review to fix build failure from sourceforge down.
I have found 3 files:...
Eugenie Lyzenko
04:52 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >The remaining task is computing the combo's dimension as in 4GL. Consider the test at note...
Constantin Asofiei
02:06 PM User Interface Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10897@ (new branch revision @10908@ - a few words added in comme... Eugenie Lyzenko
12:23 PM User Interface Feature #2546: implement combo-box widget in GUI
>The remaining task is computing the combo's dimension as in 4GL. Consider the test at note 130 with a font8 set to T... Eugenie Lyzenko
08:59 AM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> > if all issues (except dimension) are fixed, please get it into regression testing and release i...
Constantin Asofiei
08:39 AM User Interface Feature #2546: implement combo-box widget in GUI
> if all issues (except dimension) are fixed, please get it into regression testing and release it
Constantin: he ...
Greg Shah
06:51 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10907@.
>
> The update has improved ...
Constantin Asofiei
09:04 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10907@.
The update has improved implementation for width scali...
Eugenie Lyzenko
04:39 PM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10896 (branch revision 10915). Constantin Asofiei
04:30 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > More, there is another issue: in 4GL, widget coordinates are re...
Constantin Asofiei
12:12 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10896 (new branch revision 10898). Igor Skornyakov
08:52 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> More, there is another issue: in 4GL, widget coordinates are relative to the parent. Bu...
Hynek Cihlar
06:15 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> >
> > - a bug in @ZeroLayoutColumn@ positioning the selection-list wid...
Constantin Asofiei
04:00 PM Base Language Bug #2592: improve support for implicit type conversions
Constantin Asofiei wrote:
> Ovidiu, about revision 10912:
> * SourceNameMapper.getParameter:941 - you should check ...
Ovidiu Maxiniuc
02:22 PM Base Language Bug #2592: improve support for implicit type conversions
Greg Shah wrote:
> Aren't all implicit cases using the BaseDataType constructor?
At this point, no. The @ControlF...
Ovidiu Maxiniuc
02:07 PM Base Language Bug #2592: improve support for implicit type conversions
Aren't all implicit cases using the BaseDataType constructor? Greg Shah
01:57 PM Base Language Bug #2592: improve support for implicit type conversions
I was going further and investigating some other failed tests from #1868. I noticed that in P2J some query was failin... Ovidiu Maxiniuc
06:05 AM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu, about revision 10912:
* SourceNameMapper.getParameter:941 - you should check for @param >= ie.getParameterLi...
Constantin Asofiei
05:36 AM Base Language Bug #2592: improve support for implicit type conversions
Paul Eames wrote:
> I see this is marked as blocking #1868.
>
> Can you give me a couple of examples of where we ...
Ovidiu Maxiniuc
05:06 AM Base Language Bug #2592: improve support for implicit type conversions
I see this is marked as blocking #1868.
Can you give me a couple of examples of where we are relying on this impli...
Paul E
11:43 AM User Interface Feature #2563 (Closed): implement GUI EDITOR widget
Greg Shah
11:36 AM User Interface Feature #2563: implement GUI EDITOR widget
Branch 2563b was merged to trunk as revno 10896 then it was archived. Constantin Asofiei
06:22 AM User Interface Feature #2563: implement GUI EDITOR widget
Code Review Task Branch 2563b, Revision 10907
I'm fine with the changes. If it passes testing, please merge/commit...
Greg Shah
05:01 AM User Interface Feature #2563: implement GUI EDITOR widget
Please review task branch 2563b, revision 10907.
I'm running regression testing one more time, to clear some false...
Constantin Asofiei

07/16/2015

04:46 PM Database Bug #2591 (Closed): incorrect queries when MATCH operator is involved
Eric Faulhaber
04:18 PM Conversion Tools Bug #2609: Modify conversion processing so that basename can be specified with a trailing /
if ~/projects/testcases/uast/cfg/p2j.cfg.xml sets the "basepath" parameter with a trailing "/"(for example, <paramete... Sergey Ivanovskiy
04:07 PM Conversion Tools Bug #2609 (New): Modify conversion processing so that basename can be specified with a trailing /
Sergey Ivanovskiy
01:57 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Igor, I fixed this as part of 2424b.
Thank you Hynek.
Igor Skornyakov
01:53 PM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
>
> - a bug in @ZeroLayoutColumn@ positioning the selection-list widget at @ROW@ 3 instead of 1. ...
Hynek Cihlar
11:28 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Igor Skornyakov wrote:
> > I've noticed that X and Y attributes' p2j support is not compatible wit...
Hynek Cihlar
10:02 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attach...
Greg Shah
09:54 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attached test the values are (1,... Igor Skornyakov
10:08 AM User Interface Feature #2546: implement combo-box widget in GUI
> Some consideration for introducing the push screen definition lock to discuss.
> ...
Constantin will handle the...
Greg Shah
08:20 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10906@.
In this update:
1. According to my previous suggest t...
Eugenie Lyzenko
09:09 AM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> You may say that at the point of widget registration its state should already be synchroni...
Hynek Cihlar
08:26 AM User Interface Feature #2422: add features to BROWSE
Guys, about "transparent" data sending with AspectJ. P2J code calculates differences between "active (current) config... Stanislav Lomany
03:40 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> >
> > Don't consider it as a suggestion but if JWindow is replaced ...
Sergey Ivanovskiy
11:11 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> * if a procedure was called then that is a serious error and the condition will stop execut...
Eric Faulhaber

07/15/2015

04:05 PM Base Language Bug #2592: improve support for implicit type conversions
I updated the branch. What is new in revno 10910:
* moved @FieldAssigner@, @OutputExtentField@ and @InputOutputExten...
Ovidiu Maxiniuc
05:31 AM Base Language Bug #2592: improve support for implicit type conversions
The revno 10909/2592 test ended with some failures:
* 3 tests in CTRL+C (known to fail in most runs)
* gso_269/48 i...
Ovidiu Maxiniuc
03:47 PM User Interface Feature #2546: implement combo-box widget in GUI
Some consideration for introducing the push screen definition lock to discuss.
I would suggest another way of impl...
Eugenie Lyzenko
01:59 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or oth...
Constantin Asofiei
03:06 PM User Interface Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> @ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sur...
Greg Shah
12:50 PM User Interface Feature #1811: implement the AJAX client driver
@ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sure @ContentPane.quit()@ ... Hynek Cihlar
12:46 PM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Some questions related to window creation/destruction:
>
> 1. What is the purpose of the title pa...
Hynek Cihlar
12:29 PM User Interface Feature #1811: implement the AJAX client driver
Some questions related to window creation/destruction:
1. What is the purpose of the title passed to the @JWindow@...
Greg Shah
01:50 PM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10895 (branch revision 10914). Constantin Asofiei
08:42 AM User Interface Feature #2252: implement GUI client support
Sergey Ivanovskiy wrote:
>
> Don't consider it as a suggestion but if JWindow is replaced by JDialog, then a deskt...
Hynek Cihlar
06:12 AM User Interface Feature #2252: implement GUI client support
Greg, Hynek
What is the reason to implement a JFrame for any normal 4GL window and a JWindow for alert-boxes/dialog...
Sergey Ivanovskiy
12:16 PM User Interface Feature #1790: implement menu support
> So, the easiest way is to emit new Object[] instead of new handle[] for the value of second parameter of addEvent.
...
Greg Shah
04:58 AM User Interface Feature #1790: implement menu support
I faced with the following conversion problem. I have a testcase with different triggers defined and here are 2 of th... Vadim Gindin
08:17 AM User Interface Feature #2422: add features to BROWSE
Please implement both. Greg Shah
07:52 AM User Interface Feature #2422: add features to BROWSE
Greg, should I implement @browse:MODIFIED@ attribute or @column:MODIFIED@ too? I ask because they have completely dif... Stanislav Lomany
07:54 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hello Eugenie.
I've introduced the internal ids exactly for the correct restoring of the selected item. I've tested...
Igor Skornyakov
07:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Eugenie.
> From the other side I've realized now that if one replaces LIST-ITEMS/LISTS-ITE...
Eugenie Lyzenko
05:34 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie.
The test seems running OK with my version of the code and looking at your version of the @ComboBoxWidget@ I...
Igor Skornyakov
02:28 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> @uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI com...
Igor Skornyakov
11:40 PM Database Feature #2581: improve performance of non-preselect, multi-table joins
Rebased branch 2581a to trunk rev. 10895. Eric Faulhaber

07/14/2015

07:49 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10905@.
This small update fixes the dynamic combo-box behavior...
Eugenie Lyzenko
07:46 PM User Interface Feature #2546: implement combo-box widget in GUI
Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or other frame related call that... Eugenie Lyzenko
04:41 PM User Interface Feature #2546: implement combo-box widget in GUI
> To cover the case of setting the FRAME attr in and outside the CREATE ... ASSIGN clause, we can:
> ...
Yes, g...
Greg Shah
04:38 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> We should be able to bypass pushing screen definitions until the frame is set.
Yes, this is alr...
Constantin Asofiei
04:22 PM User Interface Feature #2546: implement combo-box widget in GUI
I should say this a different way.
I understand that we can't depend on there being a FRAME defined in the ASSIGN....
Greg Shah
04:13 PM User Interface Feature #2546 (WIP): implement combo-box widget in GUI
Wouldn't it be better to always bracket @CREATE WINDOW@ assign by setting @batch@ mode on in @GenericFrame@ and then ... Greg Shah
04:03 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10903@.
I'm OK with these changes.
Constantin Asofiei
04:00 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10904@.
Consider that the widget's FRA...
Constantin Asofiei
09:19 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10904@.
This update adds batch mode lock when widget attribute...
Eugenie Lyzenko
06:30 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
@uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI combo-box recent code too(bra... Eugenie Lyzenko
05:35 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ ...
Igor Skornyakov
05:27 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ outside the @define ... vi... Eugenie Lyzenko
04:52 PM User Interface Feature #2563: implement GUI EDITOR widget
Code Review Task Branch 2563b, Revision 10903
I'm fine with the changes. If it passes testing, please merge/commi...
Greg Shah
03:41 PM User Interface Feature #2563: implement GUI EDITOR widget
Please review task branch 2563b, revision 10903.
Revision 10901 is currently in runtime testing. Revisions 10902/...
Constantin Asofiei
04:43 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> >> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to av...
Hynek Cihlar
04:38 PM User Interface Feature #2252: implement GUI client support
>> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to avoid this?
>
> To i...
Greg Shah
03:42 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > The window is moved to negative Y so that the bottom of the window is visible on the screen.
>...
Hynek Cihlar
03:15 PM User Interface Feature #2252: implement GUI client support
> The window is moved to negative Y so that the bottom of the window is visible on the screen.
Is this implicitly ...
Greg Shah
02:45 PM User Interface Feature #2252: implement GUI client support
It seems that 4GL internally limits coordinates to smaller values than allowed in positional attributes (X, Y).
He...
Hynek Cihlar
08:17 AM User Interface Feature #2252: implement GUI client support
The value of 39.48 seems to be the height of the display less window decorations. The value indeed copies screen reso... Hynek Cihlar
08:05 AM User Interface Feature #2252: implement GUI client support
I am guessing that when converted to a pixel value (based on the default font's metrics), that (at least some of) the... Greg Shah
02:44 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> There is another reason for my question: once those classed are moved to new package the co...
Eric Faulhaber
02:18 PM Base Language Bug #2592: improve support for implicit type conversions
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... To be honest, I am not completely pleased with the class hie...
Ovidiu Maxiniuc
02:07 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> The new part is in @ else if (AEP.isAssignableFrom(expectedType) && AEP.isAssignableFrom(ar...
Eric Faulhaber
01:56 PM Base Language Bug #2592: improve support for implicit type conversions
Eric Faulhaber wrote:
> Code review 2592/10908
>
> I only looked at the diffs from 10907 to 10908.
>
> The con...
Ovidiu Maxiniuc
12:16 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> ... To be honest, I am not completely pleased with the class hierarchy I merged because it ...
Eric Faulhaber
12:12 PM Base Language Bug #2592: improve support for implicit type conversions
Code review 2592/10908
I only looked at the diffs from 10907 to 10908.
The conversion change in @control_flow.r...
Eric Faulhaber
02:37 PM User Interface Feature #1811: implement the AJAX client driver
I am working on the new window and new child window support for the web client. In the current implementation, we us... Greg Shah
09:17 AM User Interface Feature #1811: implement the AJAX client driver
Rebased task branch 1811o from P2J trunk revision 10895. Greg Shah
08:29 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Tha task branch 2567a has been created. First updates are committed to the branch, revno: 10896 Igor Skornyakov

07/13/2015

06:27 PM User Interface Feature #2252: implement GUI client support
For #2424, please assess whether any of these should be replicated in P2J.
*Case 1*...
Hynek Cihlar
03:17 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Also, it seems to me that now is the time to go ahead and implement a cleaner set of classes for ...
Hynek Cihlar
02:47 PM User Interface Feature #2252: implement GUI client support
OK, please go ahead and implement a compatible max sizing algorithm.
Also, it seems to me that now is the time to ...
Greg Shah
02:09 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > The question is how far should we go to replicate this?
>
> I'd like to see the algorithm be...
Hynek Cihlar
11:13 AM User Interface Feature #2252: implement GUI client support
> A way out of this could be an interactive calibration process that would provide these (and possibly other) dynamic... Greg Shah
10:59 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> > A Windows theme may differ with Windows versions.
>
> Yes, but for us it is going to be some...
Hynek Cihlar
10:32 AM User Interface Feature #2252: implement GUI client support
> The window border size is however hardcoded to a constant value.
I expect that we will allow this to be configur...
Greg Shah
10:18 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> The window decoration dimensions are values that we hard code in P2J based on the chosen Windows ...
Hynek Cihlar
09:43 AM User Interface Feature #2252: implement GUI client support
> It seems that 4GL calculates these maximum values based on window decorations - i.e. window caption size and border... Greg Shah
09:28 AM User Interface Feature #2252: implement GUI client support
This relates to #2424.
I identified a problem related to the max allowed window size. In GUI, a window widget trun...
Hynek Cihlar
05:38 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10903@.
This update includes the changes required to complete ...
Eugenie Lyzenko
01:44 PM User Interface Feature #2546: implement combo-box widget in GUI
More finding for @MAX-CHARS@ in 4GL @COMBO-BOX@.
The default value is @0@, not @255@, like as the reaction to sett...
Eugenie Lyzenko
01:25 PM User Interface Feature #2546: implement combo-box widget in GUI
For @MAX-CHARS@ implementation in @COMBO-BOX@:
In all modes, the attribute is ignoring, @MAX-CHAR@ maximum value i...
Eugenie Lyzenko
12:02 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co...
Constantin Asofiei
08:46 AM User Interface Feature #2546: implement combo-box widget in GUI
Try using @createJavaAst()@ instead of @createPeerAst()@. Greg Shah
05:20 PM User Interface Feature #1811: implement the AJAX client driver
A first pass implementation of clipboard support is checked in to task branch 1811o. The rest of the work will be de... Greg Shah
02:56 PM Base Language Bug #2592: improve support for implicit type conversions
I have found a new issue when calling a procedure with a single EXTENT parameter. Consider a procedure... Ovidiu Maxiniuc
07:15 AM Base Language Bug #2592: improve support for implicit type conversions
Eric Faulhaber wrote:
> Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks ...
Ovidiu Maxiniuc
12:16 AM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks as though you're nearly f... Eric Faulhaber
01:55 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
All changes except Stream class is passed regression testing.
Changes in Stream class is not fully correct. gso_103 ...
Evgeny Kiselev
01:07 PM User Interface Feature #1790: implement menu support
As Constantin and I have noted multiple times:
> the MenuContainerWidget needs to inherit from BaseEntity.
Sea...
Greg Shah
12:18 PM User Interface Feature #1790: implement menu support
When I refactored menu classes I removed unneeded fields from classes and those setters, that appear in config classe... Vadim Gindin
09:33 AM User Interface Feature #1790: implement menu support
This is a problem, but do not work on it now. We will leave this as a TODO.
We also have this same problem with t...
Greg Shah
12:25 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> I meant what testcase did you use to check the SET-SELECTED method?
I think it was the ...
Igor Skornyakov
12:23 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, can you point me to a testcase which covers your H046 ...
Constantin Asofiei
12:16 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Igor, can you point me to a testcase which covers your H046 change in Editor.java? This ...
Igor Skornyakov
12:07 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, can you point me to a testcase which covers your H046 change in Editor.java? This no longer works with the #256... Constantin Asofiei
12:01 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit...
Constantin Asofiei
12:05 PM User Interface Feature #2422: add features to BROWSE
> So considering this complexity and that it is not likely to be used, I suggest to add it to the quirks list.
OK.
Greg Shah
11:51 AM User Interface Feature #2422: add features to BROWSE
Greg, about @REFRESHABLE@. Its typical use case is to turn it off - reposition - turn it on. However there is a poten... Stanislav Lomany
11:59 AM User Interface Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10895 (new branch revision 10899).
There is a compile problem, n...
Constantin Asofiei

07/10/2015

06:29 PM User Interface Feature #1790: implement menu support
I faced with the difficulty. When nested submenus exceed window size (width or height) they do not shrink to window s... Vadim Gindin
05:44 PM User Interface Feature #2422: add features to BROWSE
At this point there are the following issues left:
# In 4GL repositioned row is <= DOWN value. DOWN value is calcula...
Stanislav Lomany
05:38 PM User Interface Feature #2546: implement combo-box widget in GUI
I put the following rule into @convert/ui_statements.rules@(end of @ascent-rules@ section):... Eugenie Lyzenko
01:29 PM User Interface Feature #2546: implement combo-box widget in GUI
> We need to generate special marker indicating the last internal assignment in CREATE WIDGET... may be.
Correct. ...
Greg Shah
12:10 PM User Interface Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10895@, new branch revision is @10902@. Eugenie Lyzenko
12:09 PM User Interface Feature #2546: implement combo-box widget in GUI
>For static frames, we handle this in GenericFrame.setupFrame(). In other words, in GenericFrame.pushScreenDefinition... Eugenie Lyzenko
11:39 AM User Interface Feature #2546: implement combo-box widget in GUI
> In P2J every assignment inside create widget... causes the pushScreenDefinition() call and almost everything after ... Greg Shah
11:19 AM User Interface Feature #2546: implement combo-box widget in GUI
>Is this different from how the 4GL works?
Yes in 4GL there is no such condition, INNER-LINES setting can be after...
Eugenie Lyzenko
10:34 AM User Interface Feature #2546: implement combo-box widget in GUI
> For dynamic widget we have to place INNER-LINES setting before VISIBLE and SENSITIVE to have proper scrollbar. This... Greg Shah
10:33 AM User Interface Feature #2546: implement combo-box widget in GUI
The testcase set updated to rev @1290@. The only change is in @combo_box15.p@. For dynamic widget we have to place @I... Eugenie Lyzenko
09:38 AM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co...
Eugenie Lyzenko
09:29 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that could not be done in #... Greg Shah
08:58 AM User Interface Feature #2546: implement combo-box widget in GUI
> I think 4GL makes the row reposition at runtime on the layout stage so the screen coordinate for combo_box15.p is ... Greg Shah
08:54 AM User Interface Feature #2546: implement combo-box widget in GUI
> This is the list I see.
>
> ...
Yes, I know that we have many attributes and methods that are not yet finishe...
Greg Shah
08:04 AM User Interface Feature #2546: implement combo-box widget in GUI
>I think you are correct - P2J uses the ROW relative as to the top frame border, while 4GL uses the ROW as relative t... Eugenie Lyzenko
07:54 AM User Interface Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Please commit the tests you are using for the screens you posted...
Done. Committed...
Eugenie Lyzenko
11:54 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> I think this is not @combo-box@ specific issue, but all dynamic widgets with explicit coord...
Constantin Asofiei
11:35 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The only issue I see for now is the proper location in case we have NOT side labeled widget...
Constantin Asofiei
02:15 PM Database Bug #2295: In Progress output parameters ignore decimal precision
I don't know of any specific code in the customer application that is affected by this, but I am setting this issue t... Eric Faulhaber
02:08 PM Base Language Bug #2592: improve support for implicit type conversions
Sorry I didn't make this connection sooner. OK, so we've never implemented a solution. Ovidiu, please move forward wi... Eric Faulhaber
02:03 PM Base Language Bug #2592: improve support for implicit type conversions
Sorry I didn't realize this earlier, the output parameter precision for fields is covered by #2295. Hynek Cihlar
02:00 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:...
Eric Faulhaber
01:49 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> The problem is that we need to temporarily overwrite the precision of the database field un...
Eric Faulhaber
01:25 PM Base Language Bug #2592: improve support for implicit type conversions
It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... Ovidiu Maxiniuc
12:42 PM Base Language Bug #2592: improve support for implicit type conversions
Eric Faulhaber wrote:
> Ovidiu, please try this testcase without your changes applied and track back to where it bro...
Ovidiu Maxiniuc
12:40 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu, please try this testcase without your changes applied and track back to where it broke (which may be part of ... Eric Faulhaber
12:33 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu,
it's been a while since I was playing with extents.
The case you refer to shows that 4GL doesn't propag...
Hynek Cihlar
12:32 PM Base Language Bug #2592: improve support for implicit type conversions
Hynek,
I found in one of your testcase files the following test:...
Ovidiu Maxiniuc
09:35 AM Base Language Bug #2592: improve support for implicit type conversions
The 2592 branch was rebased with 10895 main trunk and now it is at revno 10906. Ovidiu Maxiniuc
01:49 PM User Interface Bug #2607: The java generated code isn't compiled due to there is some implicit scoping that goes...
The following exceptions occur if the conversion 4GL->Java is applied to the attached addressApp.p
compile:
[ja...
Sergey Ivanovskiy
01:39 PM User Interface Bug #2607 (New): The java generated code isn't compiled due to there is some implicit scoping tha...
Sergey Ivanovskiy
10:19 AM User Interface Feature #2606: implement GUI runtime support for SELECTION-LIST
This task is for full implementation of the GUI widget implementation for SELECTION-LIST. Both static and dynamic us... Greg Shah
10:16 AM User Interface Feature #2606 (Closed): implement GUI runtime support for SELECTION-LIST
Greg Shah
09:27 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit...
Igor Skornyakov
09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
No, you are not wrong. I'm just confirming my understanding that the only remaining functionality from this task is ... Greg Shah
09:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Igor: is the only feature left for this task the MAX-CHARS GUI support?
Greg. In my understand...
Igor Skornyakov
09:18 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor: is the only feature left for this task the MAX-CHARS GUI support? Greg Shah
09:01 AM User Interface Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah
09:02 AM User Interface Feature #2486 (Closed): enhance editor functionality
Greg Shah

07/09/2015

06:54 PM User Interface Feature #2546: implement combo-box widget in GUI
>1. Check and implement if required the possibility to handle not character data by combo-box. I mean if the combo-bo... Eugenie Lyzenko
06:49 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Can you let me know what you are thinking here? #2534 already has quite a few changes for combo-...
Eugenie Lyzenko
05:43 PM User Interface Feature #2546: implement combo-box widget in GUI
> 2. Verify and implement all attribute and method for both static and dynamic combo-box.
Can you let me know what...
Greg Shah
03:13 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10900@.
I'm OK with the changes.
Constantin Asofiei
12:51 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10900@.
The updates included change for drop-down button reloc...
Eugenie Lyzenko
05:31 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150709b.zip
I'm good with the changes.
Please commit and distribute this update. Well done!
Greg Shah
05:23 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
After two runs the intersection of the failed tests' sets is @tc_job_002@ only. Igor Skornyakov
09:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> BTW: the problem was with the extra pushScreenDefinition which overrides dynamic header. It seems a little bit frag... Greg Shah
09:25 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I'm fine with the changes.
>
> The only thing I need you to change is that you should not have...
Igor Skornyakov
09:12 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150709a.zip
I'm fine with the changes.
The only thing I need you to change is that you should ...
Greg Shah
05:18 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
After a fix the test passed OK in a manual run. Full regression restarted. Igor Skornyakov
11:37 AM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> ...
> Since the @rv@ is really the same object as in first call, the fields will be overwr...
Eric Faulhaber
10:15 AM Base Language Bug #2592: improve support for implicit type conversions
It looks to me that line 4551 in 2592/10903 will only check for types errors: both argument and formal parameter to b... Ovidiu Maxiniuc
09:58 AM User Interface Bug #2605: pushScreenDefinition overrides dynamic header of the frame
The problem was revealed in the regression testing of the #2534. In the changes the conditional invocation of the @pu... Igor Skornyakov
09:46 AM User Interface Bug #2605 (New): pushScreenDefinition overrides dynamic header of the frame
Igor Skornyakov

07/08/2015

05:46 PM User Interface Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10899@.
The enhancements has been made to mouse event handling...
Eugenie Lyzenko
02:18 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> I guess that if the size is handles in @ControlFlowOps@, there is no need for the additiona...
Eric Faulhaber
01:07 PM Base Language Bug #2592: improve support for implicit type conversions
Eric Faulhaber wrote:
> I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point...
Ovidiu Maxiniuc
11:16 AM Base Language Bug #2592: improve support for implicit type conversions
I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point above, because it appear... Eric Faulhaber
11:07 AM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu wrote (in email):
> There are two main issues I would like to discuss and I would appreciate additional help:...
Eric Faulhaber
09:44 AM User Interface Feature #2252: implement GUI client support
CUT/COPY/PASTE have alternative key mappings in Windows. I think we need to add those to @GuiKeyboard.standardKeyFun... Greg Shah

07/07/2015

07:54 PM User Interface Feature #2546: implement combo-box widget in GUI
Please review task branch @2546a@, revision @10898@.
This update has new approach that fixes the multiple combo-bo...
Eugenie Lyzenko
02:41 PM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > The only issue I have is with code like this: @if (child != ...
Constantin Asofiei
01:56 PM User Interface Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> The only issue I have is with code like this: @if (child != null && child instanceof Scr...
Eugenie Lyzenko
07:59 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Please review task branch @2546a@, revision @10897@.
The only issue I have is with code li...
Constantin Asofiei
10:49 PM User Interface Feature #2546: implement combo-box widget in GUI
Please review task branch @2546a@, revision @10897@.
Adding drop-down press opening fix. The main logic of drop-do...
Eugenie Lyzenko
09:30 PM User Interface Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10894@. Eugenie Lyzenko
05:16 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. M...
Igor Skornyakov
04:57 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. Make sure to exclude ... Greg Shah
04:51 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The situation is very strange. On my machine the manual testing is OK (the dynamic header is in place). Igor Skornyakov
04:36 PM User Interface Feature #1807: implement clipboard support
Some things to note:
1. ChUI does support use of the CLIPBOARD system handle (including the VALUE attribute for bo...
Greg Shah
04:20 PM User Interface Feature #1811: implement the AJAX client driver
The current clipboard support for the ChUI web client has many of the building blocks that are needed for GUI clipboa... Greg Shah
11:25 AM User Interface Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10894 (new branch revision 10898).
Constantin Asofiei
10:02 AM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10894 (branch revision 10906).
Constantin Asofiei

07/06/2015

07:33 PM User Interface Feature #2252: implement GUI client support
Rebased task branch 2424 from P2J trunk revision 10894 (branch revision 10896). Hynek Cihlar
03:37 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Greg, a conversion question; in 4GL, the following frames are equivalent:
> [...]
> In...
Greg Shah
10:39 AM User Interface Feature #2252: implement GUI client support
Task branch 2559e committed to trunk as revision 10894. Hynek Cihlar
09:49 AM User Interface Feature #2252: implement GUI client support
> I only didn't expect any ChUI-specific features, hence no ChUI-specific sublass.
I see. Good.
Greg Shah
09:43 AM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> I think the best approach is to create GUI and ChUI subclasses of @WindowManager@ that can have m...
Hynek Cihlar
09:34 AM User Interface Feature #2252: implement GUI client support
Go ahead and merge 2559e into the trunk.
The next time we have some work in @WindowManager@, we can make some fact...
Greg Shah
08:06 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2559e Revision 10896
> >
> > This is good.
>...
Hynek Cihlar
05:03 PM User Interface Feature #2546: implement combo-box widget in GUI
> Should I try to reboot it(not sure if I have enough permissions)?
No, let the customer handle that.
> The exc...
Greg Shah
04:42 PM User Interface Feature #2546: implement combo-box widget in GUI
The exception from drop-down dismiss rule is mouse events in combo-box entry field or outside drop-down or combo-box(... Eugenie Lyzenko
04:30 PM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Does the 4GL code (actually, it is really the Windows drop-down control) dismiss the drop-down on...
Eugenie Lyzenko
09:48 AM User Interface Feature #2546: implement combo-box widget in GUI
> The root cause was too early dismiss the drop-down. I have preferred to use mouse press due to mouse press does imm... Greg Shah
07:46 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Could you help me to find why sub-menu body is truncated and where the truncating is happen?
...
Constantin Asofiei
04:42 AM User Interface Feature #1790: implement menu support
Constantin, could you look at my current changes in 1790d?
Here is my testcase:...
Vadim Gindin

07/03/2015

07:29 PM User Interface Feature #2546: implement combo-box widget in GUI
Please review task branch @2546a@, revision @10894@.
This is my first usage of the branch upload process. All curr...
Eugenie Lyzenko
05:16 PM User Interface Feature #2546: implement combo-box widget in GUI
Created task branch @2546a@ from P2J trunk revision @10893@. Eugenie Lyzenko
06:07 AM User Interface Feature #2546: implement combo-box widget in GUI
>Another issue with this test is some z-order problem: when the drop-down covers one or more widget, currently the co... Eugenie Lyzenko
04:42 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Well, the problem with the screen was reproduced manually. Igor Skornyakov
04:40 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> Try @CTRL-X@. This should also produce @GO@ function.
Thanks a lot! It works!
Igor Skornyakov
04:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send V...
Hynek Cihlar
04:36 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Try @CTRL-X@. This should also produce @GO@ function. Eugenie Lyzenko
04:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send VK_F1 at some step, but whe... Igor Skornyakov
02:58 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> MAJIC has some built-in "help" triggered by pressing F2 in almost all screens - this wil...
Igor Skornyakov
02:35 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Did you check this scenario by hand (manually trying the same inputs)...
Constantin Asofiei
02:31 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Did you check this scenario by hand (manually trying the same inputs)?
Actually I tried to fin...
Igor Skornyakov
01:55 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Did you check this scenario by hand (manually trying the same inputs)? Greg Shah
10:36 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The tc_item_stockroom_011 still fails. The mismatching screen is ... Igor Skornyakov
08:19 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
See #2603 for a response on the harness change. Greg Shah
05:22 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
After the second run only the tc_item_stockroom_011 test failed. However the mismatched screen in the report looks id... Igor Skornyakov
01:13 PM User Interface Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2559e Revision 10896
>
> This is good.
>
> 1. It is not a big deal,...
Hynek Cihlar
12:34 PM User Interface Feature #2252: implement GUI client support
Code Review Task Branch 2559e Revision 10896
This is good.
1. It is not a big deal, but I'd prefer a better way to ...
Greg Shah
08:49 AM User Interface Feature #2252: implement GUI client support
Greg, a conversion question; in 4GL, the following frames are equivalent:... Constantin Asofiei
08:21 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Please create a task branch for this task (@2567a@) and commit all your current work. All subsequent work should be ... Greg Shah
08:18 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
I've finished with the WIDGET-ID. Igor Skornyakov
08:00 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Basically, yes.
>
> We need to do whatever the 4GL does when the command line parameter @-usew...
Igor Skornyakov
07:57 AM User Interface Feature #2567 (WIP): add misc widget support part 2: more options, attributes and methods
Igor said:
> To you mean that we only need to support the conversion of the access to the WIDGET-ID attribute with...
Greg Shah

07/02/2015

06:55 PM User Interface Feature #2252: implement GUI client support
For #2559 I have:
Implemented window modality independently on the actual UI driver.
Improved positioning of top-...
Hynek Cihlar
06:41 AM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10893 (branch revision 10898).
Constantin Asofiei
05:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Well, the situation is much better now. All CTRL-C tests passed. Only one gso_test (gso_269) and two rc_tests (tc_ite... Igor Skornyakov
01:17 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> With the workaround, we are losing type information about the serialized field but in this cas...
Igor Skornyakov
12:22 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> I suggest the following workaround in the @NativeTypeSerializer@
>
> public static vo...
Hynek Cihlar
12:08 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Fixed serialization for the null string. Regression test restarted
When you have abends li...
Constantin Asofiei
12:05 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Fixed serialization for the null string. Regression test restarted Igor Skornyakov
11:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> (the visibility of the @mark@ field becomes 'public').
Please leave it protected instead o...
Constantin Asofiei
11:44 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I'm OK with this.
Constantin/Hynek?
Greg Shah
11:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Thank you Greg. I'm looking at this now. However NPE in @writeUFT()@ is weird. I've used it...
Igor Skornyakov
10:55 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I guess this has something to do with your changes to the configuration processing or widget conf...
Igor Skornyakov
10:47 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> Here is the stack trace for another common failure.
>
> com.goldencode.p2j.net.SilentUnwindException: Connection ...
Greg Shah
10:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I don't understand what this bug has to do with our failure. They state that it is specific to J...
Igor Skornyakov
10:17 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I don't understand what this bug has to do with our failure. They state that it is specific to JDK 9.
Please post...
Greg Shah
10:05 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Sorry. I've previously found a wrong reference (it was about @DataOutputStream@). See however this one: https://netbe... Igor Skornyakov
10:01 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The situation with NPE in @writeUTF()@ seems to be a known issue with OpenJDK. See https://bugs.openjdk.java.net/brow... Igor Skornyakov
09:14 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I'm fine with the changes. What is the status of testing for this update?
There are still a...
Igor Skornyakov
08:58 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150630a.zip
I'm fine with the changes. What is the status of testing for this update?
Greg Shah
04:01 PM User Interface Feature #1790: implement menu support
Created task branch 1790d from P2J trunk revision 10893 Vadim Gindin
07:47 AM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> I can do that after you finish your browse modifications if the issue doesn't bother you a...
Constantin Asofiei
07:45 AM User Interface Feature #2422: add features to BROWSE
I can do that after you finish your browse modifications if the issue doesn't bother you at this point. Stanislav Lomany
03:50 AM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query I...
Constantin Asofiei
02:38 AM User Interface Feature #2422: add features to BROWSE
Created task branch 2422b from P2J trunk revision 10893. Stanislav Lomany
07:06 AM User Interface Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10893 (new branch revision 10897).
Constantin Asofiei
05:51 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The next update for review presents the scaling factor implementation to eliminate hardcodi...
Constantin Asofiei
09:28 PM User Interface Feature #2546: implement combo-box widget in GUI
The next update for review presents the scaling factor implementation to eliminate hardcoding adjustments. The idea i... Eugenie Lyzenko
05:27 AM Database Feature #2581: improve performance of non-preselect, multi-table joins
Yes, the SQL SERVER has a similar concept for @LIMIT@, named @TOP@. It allows to return only the first @N@ rows from ... Ovidiu Maxiniuc
11:27 PM Database Feature #2581: improve performance of non-preselect, multi-table joins
Ovidiu, can you confirm that something like this SQL works in SQL Server 2012?... Eric Faulhaber

07/01/2015

06:11 PM User Interface Feature #2422: add features to BROWSE
Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query ID (I know that sounds stran... Stanislav Lomany
04:15 PM User Interface Feature #2422: add features to BROWSE
Stanislav, one more issue: is a little confusing that the query ID at some point is the same as the browse ID... this... Constantin Asofiei
09:00 AM User Interface Feature #2422: add features to BROWSE
Constantin, I have no objections. Stanislav Lomany
07:43 AM User Interface Feature #2422: add features to BROWSE
Stanislav, is there a query-related reason why the browse columns (at the widget level) are linked with the BrowseMod... Constantin Asofiei
03:44 PM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> This testcase defines 2 nested submenus "Insider" is nested in "Submenu".
You have the @buil...
Constantin Asofiei
10:57 AM User Interface Feature #1790: implement menu support
Constantin, your approach seems working at first sight. Now I have 2 problems with the testcase:... Vadim Gindin
02:32 PM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hynek:
>
> The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutpu...
Hynek Cihlar
01:09 PM User Interface Feature #1811: implement the AJAX client driver
Hynek:
The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutputManager.realizeChildWin...
Greg Shah
11:56 AM User Interface Feature #1811: implement the AJAX client driver
Created task branch 1811o from P2J trunk revision 10893.
There are 14 previous commits from this task. For this r...
Greg Shah
09:48 AM User Interface Feature #2252: implement GUI client support
Rebased task branch 2559e from P2J trunk revision 10894 (branch revision 10893). Hynek Cihlar
04:56 AM User Interface Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10892 (new branch revision 10896).
Constantin Asofiei

06/30/2015

06:46 PM User Interface Feature #2546: implement combo-box widget in GUI
This merged with recent code update for review adds support for current item selection by mouse hovering. The idea is... Eugenie Lyzenko
04:39 PM Database Bug #2602: A record returned twice because of RELEASE
Testcase:... Stanislav Lomany
04:26 PM Database Bug #2602 (New): A record returned twice because of RELEASE
Stanislav Lomany
03:54 PM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin, could you look at my update?
>
> Is that what you meant?
>
> When I'm movin...
Constantin Asofiei
02:59 PM User Interface Feature #1790: implement menu support
Constantin, could you look at my update?
Is that what you meant?
When I'm moving mouse pointer to menu-item in...
Vadim Gindin
02:18 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Merged with revno 10892 Igor Skornyakov
01:04 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've restarted majic build. Igor Skornyakov
12:48 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> I'm planning to restart regression with the most recent version right now.
Please post the merged update for re...
Greg Shah
12:40 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> What is the status of regression testing for the 0623b update?
>
> Also: I think you need to m...
Igor Skornyakov
09:31 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
What is the status of regression testing for the 0623b update?
Also: I think you need to merge to the latest P2J r...
Greg Shah
02:11 PM User Interface Feature #2422: add features to BROWSE
The latest update was converted to branch 2422a. Committed to bzr as P2J rev. 10892. Stanislav Lomany
09:25 AM User Interface Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...
Greg Shah
06:28 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
Constantin Asofiei wrote:
> I'm OK with the change, go ahead and release it.
Committed in bzr as @10891@.
Eugenie Lyzenko
04:33 AM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
> Please review the change. I can release it because as before no testing is required for GUI code.
I'm OK with the ...
Constantin Asofiei

06/29/2015

07:01 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
There is one more place to modify regarding this bug. The GUI button does not display image for default button. So th... Eugenie Lyzenko
06:24 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
The fix has been committed in bzr as @10890@. Will be distributed shortly. Eugenie Lyzenko
06:12 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
Eugenie Lyzenko wrote:
> >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - pleas...
Constantin Asofiei
06:04 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
>This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - please double check this branch... Eugenie Lyzenko
05:51 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
Eugenie Lyzenko wrote:
> The conclusion is only @DEFAULT-BUTTON@ frame option has meaning when defining the button t...
Constantin Asofiei
05:32 PM User Interface Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
>Write the following testcases to check behavior:
>
>1. Does @BUTTON:DEFAULT@ without frame's @DEFAULT-BUTTON@ opti...
Eugenie Lyzenko
05:39 PM Database Bug #2552 (Closed): bad hql caching prevents queries to position on the correct rows
The change fixed the unit tests I was targeting.
I rebased 2552a to trunk rev. 10888 to pick up Hynek's redirected...
Eric Faulhaber
04:24 PM Base Language Bug #2592: improve support for implicit type conversions
The issue for Hynek's earlier work is #2293. Eric Faulhaber
04:18 PM Base Language Bug #2592: improve support for implicit type conversions
As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c... Eric Faulhaber
02:48 PM Base Language Bug #2592: improve support for implicit type conversions
After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver... Ovidiu Maxiniuc
12:54 PM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> > Lets change the approach to this: take the menubar's clipping rectangle and, if the ScreenBi...
Constantin Asofiei
12:32 PM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > >...
Vadim Gindin
11:30 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > > A solution would be to repaint the...
Constantin Asofiei
10:27 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > > A solution would be to repaint the entire menubar or sub-menu...
Vadim Gindin
09:48 AM User Interface Feature #1790: implement menu support
> But when I did this change, the error didn't disappear. Was I wrong? Could you have a look at it?
Your change do...
Greg Shah
06:53 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> > A solution would be to repaint the entire menubar or sub-menu on mouseEnter/Exit. But I th...
Constantin Asofiei
06:34 AM User Interface Feature #1790: implement menu support
Constantin Asofiei wrote:
> What I think is happening is this:
> * you are calling a @repaint()@ for a certain menu...
Vadim Gindin
06:04 AM User Interface Feature #1790: implement menu support
Constantin, thank you, I'll try.
Greg, I've faced with parsing error with the following procedure:...
Vadim Gindin
04:45 AM User Interface Feature #1790: implement menu support
What I think is happening is this:
* you are calling a @repaint()@ for a certain menu-item; this ensures that an inv...
Constantin Asofiei
03:31 AM User Interface Feature #1790: implement menu support
Constantin, I have a problem with mouse ENTER and EXIT events processing. When I move mouse pointer from one menu-ite... Vadim Gindin
04:22 AM User Interface Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10888 (branch revision 10890). Constantin Asofiei
04:21 AM User Interface Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10888 (new branch revision 10892). Constantin Asofiei

06/28/2015

07:58 PM User Interface Feature #2546: implement combo-box widget in GUI
Merge with recent code base for review. In addition the event list chaining in drop-down cycle is now filtering to co... Eugenie Lyzenko
05:37 AM User Interface Bug #2601: Implement gap closing mechanism for browse
When some of the records contained in a browse are deleted in background (by @DELETE@, not @DELETE-*-ROW(S)@), "gaps"... Stanislav Lomany
04:11 AM User Interface Bug #2601 (New): Implement gap closing mechanism for browse
Stanislav Lomany
05:24 AM User Interface Feature #2252: implement GUI client support
Task branch 2559d passed regression testing and was committed to trunk as revision 10888. Hynek Cihlar

06/27/2015

08:14 PM User Interface Feature #2546: implement combo-box widget in GUI
Finally the update merged with the recent code base is ready with all fixes required:
1. Resolution for previous upd...
Eugenie Lyzenko
08:12 PM User Interface Bug #2600: Implement proper refresh after deletion if the deleted row is a new row outside of the...
Example of the behavior - @uast/browse/brws-offset5.p@:
down to 10, n, esc-R, up to 1, d - scrolled to 10.
The ...
Stanislav Lomany

06/26/2015

07:45 PM User Interface Bug #2600 (New): Implement proper refresh after deletion if the deleted row is a new row outside ...
Stanislav Lomany
07:13 PM User Interface Bug #2599: 4GL makes selection invalid after row deletion
4GL makes selection invalid if we have deleted a selected row and there was a new row in the set of selected rows.
...
Stanislav Lomany
07:08 PM User Interface Bug #2599 (New): 4GL makes selection invalid after row deletion
Stanislav Lomany
04:12 PM User Interface Bug #2598: Adding new row in REPLACE mode causes quirk
Scenario:... Stanislav Lomany
03:55 PM User Interface Bug #2598 (New): Adding new row in REPLACE mode causes quirk
Stanislav Lomany
04:03 PM Base Language Bug #2592: improve support for implicit type conversions
The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p... Ovidiu Maxiniuc
12:53 PM Base Language Bug #2592: improve support for implicit type conversions
The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ...
Ovidiu Maxiniuc
11:58 AM User Interface Feature #2252: implement GUI client support
Code Review Task Branch 2559d Revision 10888
The changes look good to me. Please get them tested.
Greg Shah
11:31 AM User Interface Feature #2252: implement GUI client support
For #2559 I have:
Fixed calculation of workspace size in redirection mode.
Fixed some unhandled exceptions when s...
Hynek Cihlar
06:19 AM User Interface Bug #2597: Rows are quirky committed on insert-row() call.
General description:
1. Update some row 1.
2. Leave it by calling INSERT-ROW in a trigger. Row 1 will contain updat...
Stanislav Lomany
05:37 AM User Interface Bug #2597 (New): Rows are quirky committed on insert-row() call.
Stanislav Lomany
01:48 AM Database Bug #2552 (WIP): bad hql caching prevents queries to position on the correct rows
I've re-opened this task to address a defect: it is possible for the @HQLPreprocessor@ to create invalid ASTs when th... Eric Faulhaber

06/25/2015

07:47 PM User Interface Feature #2546: implement combo-box widget in GUI
The condition of the application to finish is the pressing @RETURN@ key. It is very strange because it is happening e... Eugenie Lyzenko
06:38 PM User Interface Feature #2422: add features to BROWSE
Code Review svl_upd20150625a.zip
I'm OK with the changes. Please get them regression tested.
Greg Shah
04:45 PM User Interface Feature #2422: add features to BROWSE
Update for review. Fixes issue from the checklist in item 178. Stanislav Lomany
07:43 AM User Interface Feature #2422: add features to BROWSE
OK, add this to the quirks list. Greg Shah
06:12 PM User Interface Bug #2596: Implement missing browse quirks.
Parent task for tracking browse quirks. Stanislav Lomany
06:09 PM User Interface Bug #2596 (New): Implement missing browse quirks.
Stanislav Lomany
12:25 PM Base Language Bug #2592: improve support for implicit type conversions
Very good plan and design. Greg Shah
11:50 AM Base Language Bug #2592: improve support for implicit type conversions
Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat...
Ovidiu Maxiniuc
11:31 AM Base Language Bug #2592: improve support for implicit type conversions
These are very good points (the complete matrix and the support for variables). I think both of these issues need to... Greg Shah
10:10 AM Base Language Bug #2592 (WIP): improve support for implicit type conversions
I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n...
Ovidiu Maxiniuc
04:26 AM Base Language Bug #2592: improve support for implicit type conversions
Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi...
Constantin Asofiei
07:10 AM User Interface Feature #2412: Implement widget browser
The task branch 2412a was committed to trunk revision 10887. Hynek Cihlar

06/24/2015

07:11 PM User Interface Feature #2422: add features to BROWSE
Regarding "Check how addition of new row works in multiple selection mode (last selected row is used?)". Looks like a... Stanislav Lomany
05:34 PM User Interface Feature #2422: add features to BROWSE
Addition to "In 4GL (ChUI) last/first rows has invalid row value." behavior: if the value of the current cell was mod... Stanislav Lomany
11:04 AM User Interface Feature #2422: add features to BROWSE
> LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific.
OK, I see they are already listed in #2564. ...
Greg Shah
10:59 AM User Interface Feature #2422: add features to BROWSE
Yes, but LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific. Stanislav Lomany
10:53 AM User Interface Feature #2422: add features to BROWSE
SET-REPOSITIONED-ROW - used
MODIFIED - used
LABEL-BGCOLOR - used
MOVE-COLUMN - used
MIN-HEIGHT-CHARS - not sure; ...
Greg Shah
06:01 PM User Interface Feature #2412: Implement widget browser
Code Review Task Branch 2412a Revision 10887
The changes are OK.
Greg Shah
05:33 PM User Interface Feature #2412: Implement widget browser
I have improved Widget Browser GUI highlight. Restoring the highlighted area was causing artifacts. Also the highligh... Hynek Cihlar
05:31 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't suppor...
Greg Shah
05:07 PM User Interface Feature #2252: implement GUI client support
Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't support yet the SPACE clause. Constantin Asofiei
05:04 PM Base Language Bug #2592 (New): improve support for implicit type conversions
Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y...
Greg Shah
03:53 PM Base Language Bug #2592: improve support for implicit type conversions
10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp... Eric Faulhaber
03:48 PM Base Language Bug #2592 (WIP): improve support for implicit type conversions
New changes committed to revision 10889. Ovidiu Maxiniuc
03:29 PM Base Language Bug #2592: improve support for implicit type conversions
Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to...
Eric Faulhaber
03:01 PM Base Language Bug #2592: improve support for implicit type conversions
The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we... Ovidiu Maxiniuc
01:32 PM Base Language Bug #2592: improve support for implicit type conversions
Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>...
Eric Faulhaber
12:40 PM Base Language Bug #2592: improve support for implicit type conversions
> Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide...
Greg Shah
12:30 PM Base Language Bug #2592: improve support for implicit type conversions
Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con... Ovidiu Maxiniuc
11:55 AM Base Language Bug #2592: improve support for implicit type conversions
After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t...
Ovidiu Maxiniuc
10:47 AM Base Language Bug #2592: improve support for implicit type conversions
I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps... Ovidiu Maxiniuc
10:06 AM Base Language Bug #2592: improve support for implicit type conversions
I started the implementation for the optional conversions in message passing parameters. The forward checking is done... Ovidiu Maxiniuc
12:11 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please see #2594 - Implement a tracing facility for P2J. Hynek Cihlar
10:55 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Greg Shah wrote:
> > My point: I'd like this approach to be a "dtrace" for P2J. But as yo...
Greg Shah
10:23 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> My point: I'd like this approach to be a "dtrace" for P2J. But as you say, the AspectJ approach ...
Igor Skornyakov
10:04 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> The Aspect-way of monitoring method calls is slow, maybe it would make more sense to use the java.lang.instrument ... Greg Shah
09:57 AM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150623b.zip
I'm good with the changes.
Greg Shah
12:08 PM Runtime Infrastructure Feature #2594: Implement a tracing facility for P2J
When trying to understand internal workings of a complex system like P2J - spanning multiple hosts, processes and thr... Hynek Cihlar
11:04 AM Runtime Infrastructure Feature #2594 (New): Implement a tracing facility for P2J
Hynek Cihlar
09:41 AM User Interface Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> In addition to making the processing safer for drop-down, isn't the real problem that the trigger...
Eugenie Lyzenko
09:22 AM User Interface Feature #2546: implement combo-box widget in GUI
In addition to making the processing safer for drop-down, isn't the real problem that the trigger processing should b... Greg Shah
09:04 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Yes, the @DropDown@ doesn't have an ID yet. You can add a v...
Constantin Asofiei
08:54 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Review for 0622a.zip:
> > * @ComboBoxConfig@ - the added im...
Constantin Asofiei
08:35 AM User Interface Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Review for 0622a.zip:
> * @ComboBoxConfig@ - the added imports are unused
Please cla...
Eugenie Lyzenko
08:30 AM User Interface Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Yes, the @DropDown@ doesn't have an ID yet. You can add a virtual ID to it via @WidgetI...
Eugenie Lyzenko
04:10 AM User Interface Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The root cause for ignoring trigger call has been found. During obtaining the server method...
Constantin Asofiei
03:57 AM User Interface Feature #2546: implement combo-box widget in GUI
Review for 0622a.zip:
* @ComboBoxConfig@ - the added imports are unused
* @DropDown@ - the @fixVisibleRows@ abstrac...
Constantin Asofiei
08:30 PM User Interface Feature #2546: implement combo-box widget in GUI
The root cause for ignoring trigger call has been found. During obtaining the server method from proxy class the all ... Eugenie Lyzenko
09:24 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I don't know the answer, but usually the option is just the static way (compile-time) to define a...
Igor Skornyakov
09:18 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
I don't know the answer, but usually the option is just the static way (compile-time) to define a feature as part of ... Greg Shah
05:07 AM User Interface Feature #2567: add misc widget support part 2: more options, attributes and methods
It looks like there is very much in common between "Options" and "Attributes" sections in this task. Is there any dif... Igor Skornyakov
07:59 AM User Interface Feature #1790: implement menu support
Here is the current update Vadim Gindin
03:27 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Please, hepl my with my previous question about duplication. I still didn't find the reason.
...
Constantin Asofiei
03:15 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Duplication error has gone after the last Hynek's update! Sorry to trouble.
Please post your ...
Constantin Asofiei

06/23/2015

05:34 PM User Interface Feature #2422: add features to BROWSE
> Please make a list of browse features (methods, attributes, options) which are stubbed out but which have no runtim... Stanislav Lomany
03:42 PM User Interface Feature #2422: add features to BROWSE
For both of these quirks, can you easily detect that the problem would occur? If so, then let's detect those cases (... Greg Shah
03:28 PM User Interface Feature #2422: add features to BROWSE
> What does the implementation do today when there is an uncommitted update and INSERT-ROW() is called
At that tim...
Stanislav Lomany
02:35 PM User Interface Feature #2422: add features to BROWSE
It seems that there are a very large number of postponed browse quirks already. We need a much better approach to tra... Greg Shah
02:31 PM User Interface Feature #2422: add features to BROWSE
> Unless it is the first column, you cannot change copied value (only navigation and trigger keys work) until you re-... Greg Shah
02:29 PM User Interface Feature #2422: add features to BROWSE
> Side note: in multi-selection browse if a new row is selected and DELETE-CURRENT-ROW/DELETE-SELECTED-ROW was called... Greg Shah
02:27 PM User Interface Feature #2422: add features to BROWSE
> Actually rows get to the quirky state. The scenario:
> ...
> Should I reproduce this quirk?
What does the impl...
Greg Shah
02:23 PM User Interface Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> It is not implemented at runtime (@Browse.java@):
>
> [...]
This is not good. I did...
Greg Shah
10:11 AM User Interface Feature #2422: add features to BROWSE
Addition to note 180 ("In 4GL (ChUI) last/first rows has invalid row value"). Unless it is the first column, you cann... Stanislav Lomany
07:35 AM User Interface Feature #2422: add features to BROWSE
Greg,
> Check if new/existing rows are undone or committed on insert-row() call.
Actually rows get to the quirk...
Stanislav Lomany
05:18 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Fixed based on code review Igor Skornyakov
04:41 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Hynek Cihlar wrote:
> > Igor, I will not give you an answer to your question but I will at least...
Hynek Cihlar
03:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150623a.zip
1. @FillIn.isZapActive()@ is missing javadoc and needs a blank line after it.
...
Greg Shah
02:47 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
All done. Started regesssion testing. Igor Skornyakov
02:44 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt...
Greg Shah
02:37 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresp...
Greg Shah
12:50 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> >
> Thank you Hynek,
> What you've mentioned can be very useful indeed. However I had an...
Hynek Cihlar
12:38 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt...
Igor Skornyakov
12:28 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, I will not give you an answer to your question but I will at least share with you a little bit from my kitchen.... Hynek Cihlar
05:01 PM Database Bug #2591: incorrect queries when MATCH operator is involved
Committed to bzr as revno 10886. Ovidiu Maxiniuc
04:17 PM Database Bug #2591: incorrect queries when MATCH operator is involved
Please commit. Eric Faulhaber
03:57 PM Database Bug #2591: incorrect queries when MATCH operator is involved
Taking into account the changes involved, I deem the update passed the regression testing. It looks like it did well ... Ovidiu Maxiniuc
01:40 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The task branch 2559b has been...
Hynek Cihlar
01:35 PM User Interface Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The task branch 2559b has been merged with trunk. Eugenie, you ...
Constantin Asofiei
11:29 AM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda...
Constantin Asofiei
12:53 PM User Interface Feature #2559 (Closed): implement ALERT-BOX support
Greg Shah
11:58 AM User Interface Feature #1790: implement menu support
Duplication error has gone after the last Hynek's update! Sorry to trouble. Vadim Gindin
11:22 AM User Interface Feature #1790: implement menu support
Vadim Gindin wrote:
> Please, help me with my previous question about duplication. I still didn't find the reason.
...
Vadim Gindin
11:01 AM User Interface Feature #1790: implement menu support
Please, hepl my with my previous question about duplication. I still didn't find the reason.
Additional question. ...
Vadim Gindin
08:44 PM User Interface Feature #2546: implement combo-box widget in GUI
The update contains combo-box changes merged with recent code base without recently distributed @Scrollbar@ changes.
...
Eugenie Lyzenko

06/22/2015

06:46 PM User Interface Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresponding (noop) method @Abst... Igor Skornyakov
04:47 PM User Interface Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda...
Eugenie Lyzenko
04:14 PM User Interface Feature #2252: implement GUI client support
The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by updating the trunk branch. Hynek Cihlar
10:51 AM User Interface Feature #2252: implement GUI client support
Greg, there is a change that affects ChUI so I would like to finish regression testing first. Hynek Cihlar
10:13 AM User Interface Feature #2252: implement GUI client support
Hynek: I think you should merge task branch 2559b revision 10883 with trunk and commit it. This will allow Eugenie t... Greg Shah
08:54 AM User Interface Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> >The main window height was not properly calculated and so the scrollbar was shown when it ...
Hynek Cihlar
04:01 PM Database Bug #2591 (WIP): incorrect queries when MATCH operator is involved
The 1st round of testing just ended. There are a lot (17) of failures in @gso_ctrlc_tests@ and some in @tc_tests@ (11... Ovidiu Maxiniuc

06/21/2015

06:02 PM User Interface Feature #2252: implement GUI client support
>The main window height was not properly calculated and so the scrollbar was shown when it should not have. This is a... Eugenie Lyzenko
02:55 PM User Interface Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > For #2559, please review regression fixes committed to task branch...
Hynek Cihlar
 

Also available in: Atom