Project

General

Profile

Activity

From 02/26/2020 to 03/26/2020

03/26/2020

07:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Roger Borrello wrote:
> Right now, the error message is being displayed, but the client is cycling in a loop, and no...
Roger Borrello
07:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Look at the Hotel ChUI @p2j.cfg.xml@ for clues. You can also add things to that project to test, though the regular ... Greg Shah
06:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
For the ChUI, what is the key to building it as-if using ChUI development, so that @"{&window-system}" ... Roger Borrello
05:08 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I have the @frame_title_color_attributes.p@ testcase working on GUI. There are some differences, between FWD and 4GL,... Roger Borrello
04:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Correct. Greg Shah
04:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
In @common-progress.rules:read_only_attribute@ is included @prog.kw_titl_bgc@. I am going to remove this, since we ca... Roger Borrello
03:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Nevermind. Found the sources to our @readOnlyError@. Roger Borrello
03:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font...
Roger Borrello
02:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font is not converting t... Greg Shah
02:57 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
No, I don't think so. Greg Shah
02:56 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Why would we want it to be @extends@?
I don't want to do that. I believe I need to add our get...
Roger Borrello
02:38 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Why would we want it to be @extends@? Greg Shah
02:23 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Did you add it to @FrameWidget@?
ahh... @TitledElement@ is in there as @implements@, but not @...
Roger Borrello
02:21 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Did you add it to @FrameWidget@? Greg Shah
02:16 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Remove it from @CommonFrame@.
When @extends TitledElement@ is removed from @CommonFrame@, the ...
Roger Borrello
01:47 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Feel free to fix your bugs.
LOL... nowhere did I add a 4052 warning... I'll find and fix, whoeve...
Roger Borrello
01:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Remove it from @CommonFrame@.
> Proceeding with the testcase, with all getters/setters in both GenericFrame and Fr...
Greg Shah
12:46 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> @GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can st...
Roger Borrello
12:04 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
@GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can still leave the setter... Greg Shah
11:23 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> > Where are the frame-options methods?
>
> That is the @setTitleColor(ColorSpec)@ (which you k...
Roger Borrello
11:11 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Where are the frame-options methods?
That is the @setTitleColor(ColorSpec)@ (which you keep complaining about) w...
Greg Shah
11:01 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @Generic...
Roger Borrello
10:48 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @GenericFrame@ instance. Th... Greg Shah
10:38 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Using this to ef with @titleDColor@:... Roger Borrello
09:05 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> In setTitleColor(ColorSpec titleColor) on line 6860? That wasn't me... I mentioned how odd that method looked. Did ... Greg Shah
08:55 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11395
>
> The changes are moving the right direction.
...
Roger Borrello
07:29 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Code Review Task Branch 4231b Revision 11395
The changes are moving the right direction.
1. You've messed with ...
Greg Shah
06:53 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Does this mean titleDColor is stored outside GenericFrame?
Yes.
As I said in #4393-20:
> Thus, only @conf...
Greg Shah
09:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Updates are buildable in revision 11395. Right now @GenericFrame@ is the only update without stubs. Please review... ... Roger Borrello
09:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The documentation for Attributes:Frames for writing/assignment says...
_in ChUI:_
_before realization, all ...
Roger Borrello
05:21 PM Database Feature #4011: database/persistence layer performance improvements
If the directory has a flag to force everything to be treated as @NO-UNDO@, then I don't see the need for a conversio... Greg Shah
05:04 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4G...
Eric Faulhaber
04:29 PM Database Feature #4011: database/persistence layer performance improvements
> The only value I see is that of pointing out which temp-tables are NOT marked NO-UNDO in the 4GL code, which might ... Greg Shah
04:04 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Greg Shah wrote:
>
> > He mentioned that he believes his team never knowingly uses UNDOab...
Eric Faulhaber
03:43 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
IIRC, the @UndoStateProvider@ is used for two reasons:
* to allow the @undo@ property to be lazily set (in s...
Ovidiu Maxiniuc
03:10 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I am implementing the forced NO-UNDO override idea Greg mentioned above, and I have come across @UndoStatePro... Eric Faulhaber
03:02 PM Base Language Feature #4384: Builtin OO Implementation
Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
Constantin Asofiei
02:54 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
Eugenie Lyzenko
02:43 PM Base Language Feature #4384: Builtin OO Implementation
I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi...
Constantin Asofiei
01:55 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n...
Constantin Asofiei
01:06 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ...
Marian Edu
12:35 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu...
Marian Edu
10:17 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Branch 4231b revision 11395 includes @GenericFrame@ changes that complete @next-tab-item@ and @prev-tab-item@ per #41... Greg Shah

03/25/2020

03:42 PM User Interface Bug #4589: menu case sensitivity and conversion
> The current changes were checked with testcases/uast/menu tests that passed except 4 known cases:
Roger is worki...
Greg Shah
03:33 PM User Interface Bug #4589: menu case sensitivity and conversion
The current changes were checked with @testcases/uast/menu@ tests that passed except 4 known cases:... Sergey Ivanovskiy
03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
If everything is working so far and there are no regressions, then I am OK with it. Greg Shah
02:32 PM User Interface Bug #4589: menu case sensitivity and conversion
Greg, I compared the previous version and the current changes and found that this map used @submenu = names.convert(... Sergey Ivanovskiy
10:36 AM User Interface Bug #4589: menu case sensitivity and conversion
Code Review Task Branch 4231b Revision 11387
It seems wrong to use the javaname (even a lowercased one) as a key t...
Greg Shah
08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
Greg Shah wrote:
> This is not a problem with menu conversion. The skeletons should never be converted. They are s...
Hynek Cihlar
08:13 AM User Interface Bug #4589: menu case sensitivity and conversion
Hynek Cihlar wrote:
> Sergey, I think I stepped on another error during <large_app> conversion caused by the menu ch...
Hynek Cihlar
08:04 AM User Interface Bug #4589: menu case sensitivity and conversion
This is not a problem with menu conversion. The skeletons should never be converted. They are supposed to be exclud... Greg Shah
07:53 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey, I think I stepped on another error during <large_app> conversion caused by the menu changes.... Hynek Cihlar
03:20 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Consider the following facts:
* The reason we store state in a separate config class (e.g. @BaseConfig@) is to hav...
Greg Shah
02:41 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Are @titleBGgColor@ and @titleFgColor@ attributes to be kept with @titleDColor@ and @titleFont@ in @BaseConfig@? Roger Borrello
01:45 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
> Yes I did, but in that method, it is setting frame.config.titleDColor instead of frame.config.titleColor.
There ...
Greg Shah
01:34 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> Did you see this part in #4393-6:
>
> > @GenericFrame@: Add @getTitleDColor()@, @setTitleDColo...
Roger Borrello
12:59 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Did you see this part in #4393-6:
> @GenericFrame@: Add @getTitleDColor()@, @setTitleDColor(int64 dcolor)@, @setTi...
Greg Shah
12:52 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
@GenericFrame@ had a method that looks a little broken:... Roger Borrello
11:45 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just implement what is in @TitledElement@. The @ColorSpec@ stuff is not related. Greg Shah
11:44 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Should there be setters for *FG*, *BG*, and *D* which receive @(ColorSpec color)@? Or just @int64@ and @long@? Roger Borrello
11:21 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Greg Shah wrote:
> It is recommended anytime you are:
>
> * implementing a method from an interface (which you ar...
Roger Borrello
11:17 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
It is recommended anytime you are:
* implementing a method from an interface (which you are doing, right?) OR
* o...
Greg Shah
10:58 AM User Interface Feature #4393: add TITLE-DCOLOR attribute support
I'm in @BrowseWidget@ and I see some methods with @&#64;Override@ annotation, and some without. What determines wheth... Roger Borrello
09:49 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Just re-enable the warnings suppression. Greg Shah

03/24/2020

05:48 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Is the below caused by commented out @options { generateAmbigWarnings = false; }@ ? Was that just for debug?... Roger Borrello
05:06 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
Attached are my incomplete changes for this task. The intention is to *finish the implementation of all the options ... Greg Shah
03:47 PM Base Language Feature #4384: Builtin OO Implementation
@bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ... Greg Shah
03:44 PM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest...
Marian Edu
03:28 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev...
Constantin Asofiei
03:24 PM Base Language Feature #4384: Builtin OO Implementation
I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@. Greg Shah
03:23 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix...
Marian Edu
03:19 PM Base Language Feature #4384: Builtin OO Implementation
Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo...
Constantin Asofiei
04:09 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static...
Constantin Asofiei
02:57 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi...
Marian Edu
07:18 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="...
Sergey Ivanovskiy
06:07 AM User Interface Bug #4589: menu case sensitivity and conversion
The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="java.lang.String" key="in_wi... Sergey Ivanovskiy
05:37 AM User Interface Bug #4589: menu case sensitivity and conversion
This code... Sergey Ivanovskiy
05:12 AM User Interface Bug #4589: menu case sensitivity and conversion
The code is still needed to fix ACCELERATOR assignments for menu. I added new test case @test-accelerator-1.p@ into @... Sergey Ivanovskiy

03/23/2020

06:29 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Let me know if you have questions or need more test cases for this one.
Thanks Marian, I still ...
Constantin Asofiei
03:58 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I don't understand this part - do you have an explicit te...
Marian Edu
09:30 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I don't understand this part - do you have an explicit test?
I see it now... a two or m...
Constantin Asofiei
08:51 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> All assert methods in there are static, some use internalProcedure blocks but others don't and s...
Constantin Asofiei
08:17 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Can you isolate this in a simple example? Or point me to an existing test?
>
Since...
Marian Edu
06:12 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Say one methodA needs to call another methodB with some default parameters, the parameters sent ...
Constantin Asofiei
04:32 AM Base Language Feature #4384: Builtin OO Implementation
We somehow still have some issues with the error handling there.
Say one methodA needs to call another methodB wit...
Marian Edu
03:01 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> He mentioned that he believes his team never knowingly uses UNDOable temp-tables. In other wor...
Eric Faulhaber
02:58 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> [...]
> This would mean that the rollback for temp-tables would actually commit when this flag i...
Eric Faulhaber
02:25 PM Database Feature #4011: database/persistence layer performance improvements
I have fixed the issue in entry 157, please disregard it.
The problem was in annotations' path: in the paths were in...
Ovidiu Maxiniuc
01:40 PM Database Feature #4011: database/persistence layer performance improvements
I've was discussing (with a customer) the UNDO/transaction and sub-transaction rework that is happening in this task.... Greg Shah
12:52 PM Database Feature #4011: database/persistence layer performance improvements
While working on dynamic temp-tables I encountered the following issue: the @AsmClassLoader@ loads the dynamically ge... Ovidiu Maxiniuc
10:06 AM User Interface Bug #4598: define shared menu statement is converted using new name to reference the shared menu
This issue can be reproduced with @./menu/shared_new.p@ and @./menu/shared_use.p@ from the old @testcases/uast@ proje... Sergey Ivanovskiy
09:54 AM User Interface Bug #4598 (New): define shared menu statement is converted using new name to reference the shared...
Sergey Ivanovskiy
09:03 AM User Interface Bug #4589: menu case sensitivity and conversion
As long as the regression in the other customer's application is also fixed, then any remaining issues can be moved i... Greg Shah
08:53 AM User Interface Bug #4589: menu case sensitivity and conversion
I saw the Redmine entries about the regression, and I am grateful you found a better solution. The customer code stil... Roger Borrello
07:51 AM User Interface Bug #4589: menu case sensitivity and conversion
Roger Borrello wrote:
> I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you ...
Sergey Ivanovskiy
05:19 AM User Interface Bug #4589: menu case sensitivity and conversion
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@....
Sergey Ivanovskiy
03:55 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@. @SharedUseMmMenu.java@ i...
Hynek Cihlar

03/20/2020

05:17 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Please read the 4GL docs to see what the @FRAME-COL@ function is meant to do. It is the counterpart of @FRAME-ROW@ a... Greg Shah
11:10 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
This test is promising:
!frame_loc_attributes_get.png!
Code below. What else can I do to validate?...
Roger Borrello
09:01 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Stanislav Lomany wrote:
> Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. Yo...
Roger Borrello
04:32 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. You can just write @return br... Stanislav Lomany
03:50 PM User Interface Bug #4589: menu case sensitivity and conversion
I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you remove all your debug @pr... Roger Borrello
03:30 PM User Interface Bug #4589: menu case sensitivity and conversion
Roger Borrello wrote:
> Are you getting a conversion error or runtime?
This is the menu generation issue for shared...
Sergey Ivanovskiy
03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
Committed revision 11381 (4231b) fixed case-insensitive issue for menu identifiers but the shared menu and labels iss... Sergey Ivanovskiy
03:01 PM User Interface Bug #4589: menu case sensitivity and conversion
Are you getting a conversion error or runtime?
I've made a change to the @shared_new.p@ to make is easier to run o...
Roger Borrello
02:09 PM User Interface Bug #4589: menu case sensitivity and conversion
This diff @4589_6.patch@ fixed these tests (see #4589-28)... Sergey Ivanovskiy
01:44 PM User Interface Bug #4589: menu case sensitivity and conversion
I encountered a strange annotation generated for menu item... Sergey Ivanovskiy
11:10 AM User Interface Bug #4589: menu case sensitivity and conversion
These files... Sergey Ivanovskiy
09:20 AM User Interface Bug #4589: menu case sensitivity and conversion
It seems like you are getting close. Keep up the good work. If you need a hand on anything, please post. Roger Borrello
07:01 AM User Interface Bug #4589: menu case sensitivity and conversion
The following 3 types of exceptions were encountered with the last attached diff.
These tests...
Sergey Ivanovskiy
01:57 AM User Interface Bug #4589: menu case sensitivity and conversion
Roger, the last changes fixed your test case but these changes to use low case identifier are not correct. There is a... Sergey Ivanovskiy

03/19/2020

07:13 PM Database Feature #4011: database/persistence layer performance improvements
Greg, never mind.
This seems to have something to do with my registration mechanism. It works with other test case...
Eric Faulhaber
06:55 PM Database Feature #4011: database/persistence layer performance improvements
Greg, could you please double-check the @entry@ hook logic for this test case?... Eric Faulhaber
03:51 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The actual cause of NPW was the fact that the @activeOffset@ was accessed for the @snapshot...
Eric Faulhaber
03:26 PM Database Feature #4011: database/persistence layer performance improvements
The actual cause of NPW was the fact that the @activeOffset@ was accessed for the @snapshot@ of the @dmo@ of the @Rec... Ovidiu Maxiniuc
02:33 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, those places we are seeing the NPE on @BaseRecord.activeBuffer@ seem to be old code where we are calling a se... Eric Faulhaber
06:16 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Updated per suggestions. Thanks!... Roger Borrello
05:27 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
I don't see any value in @BrowseWidget.getBrowseCacheSize()@ when @getNumEntries()@ can call @LogicalTerminal.getBrow... Greg Shah
05:22 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
> * @ClientExports: public int getBrowseCacheSize(int browseId);@
> * @BrowseWidget: private int getBrowseCacheSize(...
Stanislav Lomany
05:04 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Stanislav Lomany wrote:
> Consider you have a browse:
>
> [...]
>
> DOWN is 5, cache size is 2.
Thanks.
...
Roger Borrello
03:32 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Consider you have a browse:... Stanislav Lomany
03:28 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Yes, except you will only have the @browseId@ parameter and you must return an @int@.
What's t...
Roger Borrello
02:33 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Yes, except you will only have the @browseId@ parameter and you must return an @int@. Greg Shah
02:24 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Stanislav Lomany wrote:
> > Do we already have an API for this? If not, do we store this value on the client?
>
...
Roger Borrello
09:33 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
As Stanislav noted above, FWD returning 11 is a BUG. So you don't need to analyze how 11 relates to anything.
> 4...
Greg Shah
09:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
FWD returning 11 leads me to believe there are still 11 rows in the view. Evidence is the slider on the scrollbar has... Roger Borrello
08:39 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Read the comments in @browse_num_entries.p@ and look carefully at the current FWD implementation/comments. Make sure... Greg Shah
05:38 PM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc...
Roger Borrello
04:03 PM User Interface Bug #4589: menu case sensitivity and conversion
It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc version now. I found that m... Sergey Ivanovskiy
09:22 AM User Interface Bug #4589: menu case sensitivity and conversion

* 4GL names are always case-insensitive. Java names are always case-sensitive. So we must handle this at conver...
Greg Shah
09:02 AM User Interface Bug #4589: menu case sensitivity and conversion
Yes, I have similar questions.
I have only this way to collect all @"javaname"@ annotations created for menus, sub...
Sergey Ivanovskiy
08:54 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because...
Roger Borrello
05:25 AM User Interface Bug #4589: menu case sensitivity and conversion
I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because the rules are not clear for... Sergey Ivanovskiy
03:04 AM User Interface Bug #4589: menu case sensitivity and conversion
It seems that the sub menu name from its definition should be here, but the converted name can use lower and upper ca... Sergey Ivanovskiy
09:27 AM Base Language Feature #4384: Builtin OO Implementation
FYI, the named enum instances will be @final static@ and will have no mutable state. I agree that we don't need @Con... Greg Shah
03:05 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... what does ContextLocal does?
> In FWD, all clients are on th...
Marian Edu

03/18/2020

07:01 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
> What is @NUM-ENTRIES@ attribute hold? Is it the number of entries left?
It is the number of data rows in the vie...
Stanislav Lomany
06:51 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Stanislav Lomany wrote:
> > > Stanislav: Please review.
> >
> > The approach in @getNumEntrie...
Roger Borrello
05:12 PM User Interface Bug #4589: menu case sensitivity and conversion
I updated the testcase to get the new failure:... Roger Borrello
04:46 PM User Interface Bug #4589: menu case sensitivity and conversion
I don't think it fixes the issue. The Javaname is now lowercase, but not found. Shouldn't it be a converted name?
...
Roger Borrello
04:06 PM User Interface Bug #4589: menu case sensitivity and conversion
Is this a complete fix for all known issues seen in this task? Greg Shah
03:58 PM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test...
Roger Borrello
03:41 PM User Interface Bug #4589: menu case sensitivity and conversion
Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test. Sergey Ivanovskiy
03:39 PM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SEN...
Roger Borrello
03:21 PM User Interface Bug #4589: menu case sensitivity and conversion
Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SENSITIVE = false.@ properly bu... Sergey Ivanovskiy
11:49 AM User Interface Bug #4589: menu case sensitivity and conversion
Sergey Ivanovskiy wrote:
> I think that frame scoping is not connected with this issue because this example 4GL GUI ...
Roger Borrello
11:41 AM User Interface Bug #4589: menu case sensitivity and conversion
I cannot think of ANY names in the 4GL that are case-sensitive. Our conversion needs to treat all menu, sub-menu and... Greg Shah
11:31 AM User Interface Bug #4589: menu case sensitivity and conversion
I think that frame scoping is not connected with this issue because this example 4GL GUI works similarly on the nativ... Sergey Ivanovskiy
11:27 AM User Interface Bug #4589: menu case sensitivity and conversion
There isn't a @frame@ scoping the menu in the new case. That is what the customer's code is doing, so we need to unde... Roger Borrello
11:23 AM User Interface Bug #4589: menu case sensitivity and conversion
According to this 4GL UI test:... Sergey Ivanovskiy
10:39 AM User Interface Bug #4589: menu case sensitivity and conversion
Thank you, I see it now. Sergey Ivanovskiy
10:16 AM User Interface Bug #4589: menu case sensitivity and conversion
If you change @thissubmenu:SENSITIVE@ to @ThisSUBMENU:SENSITIVE@ it will generate the correct results. Roger Borrello
10:13 AM User Interface Bug #4589: menu case sensitivity and conversion
Compiling of @testcases/uast/submenu_case-sensitive.p@ with 4231b (rev 11376) failed... Sergey Ivanovskiy
10:07 AM User Interface Bug #4589 (Closed): menu case sensitivity and conversion
Sergey Ivanovskiy
04:30 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Help me understand what you see as the advantage of separating things.
I think you're right that it is a single ...
Stanislav Lomany
09:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I assume that the layout parameters for use in both the screen/display and the reports.
Why do we want to keep thi...
Greg Shah
02:34 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> ... what does ContextLocal does?
In FWD, all clients are on the same Java process. And the Jav...
Constantin Asofiei
08:44 AM Base Language Feature #4384: Builtin OO Implementation
FYI, my work on enums (#4349) is in process. I will have generic conversion and runtime support for enums when I am ... Greg Shah
07:45 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin, while the conversion now seems to work we again don't see the client window status b...
Constantin Asofiei
07:24 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, how did you define the static members? This needs to be something like this:
> ...
Marian Edu
07:18 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s...
Marian Edu
07:15 AM Base Language Feature #4384: Builtin OO Implementation
Marian, how did you define the static members? This needs to be something like this:... Constantin Asofiei
05:49 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s...
Marian Edu
04:28 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> There's something weird - the code you posted in the stacktrace should never execute dur...
Marian Edu
03:58 AM Base Language Feature #4384: Builtin OO Implementation
There's something weird - the code you posted in the stacktrace should never execute during conversion. Did you add ... Constantin Asofiei
03:35 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
Marian Edu

03/17/2020

05:42 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
All kinds of colors and fonts, column width, order and visibility, row height. Stanislav Lomany
05:39 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
What are examples of "layout parameters"? Greg Shah
05:29 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg, I have some conceptual questions about report-related enhanced parameters. Enhanced parameters can be divided i... Stanislav Lomany
03:44 PM User Interface Feature #2683: reverse proxy implementation
> > It is used only to generate mapping on the fly for new connected broker client.
>
> Is it used for anything ex...
Sergey Ivanovskiy
03:31 PM User Interface Feature #2683: reverse proxy implementation
> It is used only to generate mapping on the fly for new connected broker client.
Is it used for anything external...
Greg Shah
03:22 PM User Interface Feature #2683: reverse proxy implementation
I rechecked if Jetty implements the reverse proxy support for wss connections and found that https://webtide.com/http... Sergey Ivanovskiy
02:29 PM User Interface Feature #2683: reverse proxy implementation
This hosts file is related only to the network configuration. It is used only to generate mapping on the fly for new ... Sergey Ivanovskiy
01:45 PM User Interface Feature #2683: reverse proxy implementation
> Should I change it to use the directory?
Is there any advantage to leaving it as a separate file?
Greg Shah
01:02 PM User Interface Feature #2683: reverse proxy implementation
Committed revision 11374 (4231b) fixed 1), 2), 4) and 5). The hosts file is used for mapping unique pairs of host and... Sergey Ivanovskiy
08:37 AM User Interface Feature #2683: reverse proxy implementation
Code Review Task Branch 4231b Revision 11372
Overall, it is a nicer implementation to have the @HostsManager@.
...
Greg Shah
07:51 AM User Interface Feature #2683: reverse proxy implementation
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Yes, it looks like the old issue documented in @WebClientP...
Sergey Ivanovskiy
11:43 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
It seems the changes in 4231b Revision 11372 are good. Sergey Ivanovskiy
11:11 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Code Review Task Branch 4231b Revision 11372
The changes seem good to me.
Sergey: Any objections?
Greg Shah
10:54 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Committed fix in 4231b/rev. 11373. The changes were minimal - only the space-bar generates additional released events. Adrian Lungu
06:11 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
After checking the @GUIKeyboardReader@, I see there is the following code which triggers that additional @keyups@:
<...
Adrian Lungu
05:16 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Now I see that this behavior can't be reproduced on Chrome. Maybe it is a bug in Firefox regarding long key presses? Adrian Lungu
05:10 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Greg Shah wrote:
> I don't want to send a large number of additional events up to Java if we only need a very small ...
Adrian Lungu
11:39 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
The custom format is implemented exactly according to this documentations https://docs.oracle.com/javase/tutorial/i18... Sergey Ivanovskiy
11:16 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
I think the @VALUE-CHANGED@ event and the custom beginning day of week will be needed.
> but the custom format the...
Greg Shah
10:46 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Working to improve the documentation of calendar. The current version of @Calendar@ can convert @DateTimeValue@ value... Sergey Ivanovskiy
09:29 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
I see that there is a good start on the documentation. Thank you!
I sent the link to some customers for review. ...
Greg Shah
06:25 AM Base Language Feature #4384: Builtin OO Implementation
> None of those files in conflict were changed by us locally so I would say I can just pick the 'other' version and r... Greg Shah
06:23 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I assume that you have not changed the files in the merge conflict list?
>
> The new 4231b bra...
Marian Edu
06:20 AM Base Language Feature #4384: Builtin OO Implementation
I assume that you have not changed the files in the merge conflict list?
The new 4231b branch is a "superset" of 4...
Greg Shah
06:04 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
Marian Edu

03/16/2020

06:33 PM Database Feature #4011: database/persistence layer performance improvements
In 4011a revision 11402, I have added @Finalizable.entry()@ which is called during @TransactionManager.blockSetup()@ ... Greg Shah
07:11 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Greg, how hard would it be to add a hook for the savepoint processing which is called at the...
Greg Shah
04:14 AM Database Feature #4011: database/persistence layer performance improvements
Greg, how hard would it be to add a hook for the savepoint processing which is called at the same point in the cycle ... Eric Faulhaber
12:17 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I need a few more days to work through the UNDO code. Some of the features I expected to see (e.g., the track... Eric Faulhaber
01:15 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
>> Even though the KEY_RELEASED event is not a progress event, it should be generated in order to properly reproduce ... Greg Shah
12:29 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Adrian Lungu wrote:
> Yet, I am not sure how the key events are handled in the web driver. But from this slim invest...
Sergey Ivanovskiy
12:12 PM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
It seems that @keyup@ browser's event means that a key is released. Is it correct to change this part of the js web c... Sergey Ivanovskiy
10:39 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Adrian Lungu wrote:
> I recently found a bug related to the issue here - regarding the web interface. The web driver...
Sergey Ivanovskiy
10:32 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Whatever solution is created, please minimize the number of events forwarded to the FWD client (Java side). Optimall... Greg Shah
10:21 AM User Interface Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
I recently found a bug related to the issue here - regarding the web interface. The web driver doesn't emit release e... Adrian Lungu
01:14 PM Database Feature #3813: misc DB features part deux
A fixed @CONNECT@ statement rework was committed to the branch 4231b revision 11368. Igor Skornyakov
04:04 AM Database Feature #3813: misc DB features part deux
Greg Shah wrote:
> If it does not depend on 4335a, you can put it in 4231b. If 4335a is needed first, then wait for...
Igor Skornyakov
08:35 AM Base Language Feature #4384: Builtin OO Implementation
@xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@ has been removed. Greg Shah
07:24 AM Base Language Feature #4384: Builtin OO Implementation
> Can we try to modify other classes - like longchar or CopyLob ( of course - only if we can do it ) ?
Yes, please...
Greg Shah
06:19 AM Base Language Feature #4384: Builtin OO Implementation
The email patches are in 4231b ref 11364
* Fixed an issue with method call's argument annotation in case of chained ...
Constantin Asofiei
04:59 AM Base Language Feature #4384: Builtin OO Implementation
When testing ByteBucket methods we have found that is need for improvement in other classes who is used by ByteBucket... Mihai Popescu-Tiganea

03/15/2020

06:07 PM Database Feature #3813: misc DB features part deux
If it does not depend on 4335a, you can put it in 4231b. If 4335a is needed first, then wait for the 4231b rebase fr... Greg Shah

03/14/2020

01:42 PM Database Feature #3813: misc DB features part deux
I've found the fix for the CONNECT conversion (see #3813-84).
To which branch should I commit it?
Thank you.
Igor Skornyakov
06:38 AM Database Feature #3813: misc DB features part deux
Igor Skornyakov wrote:
> It seems that the CONNECT statement which caused the @gso_241@ fail is incorrect.
> I've ...
Igor Skornyakov

03/13/2020

06:57 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Thinking over some of the issues you've been having, I expect the implicit transaction code ...
Ovidiu Maxiniuc
06:52 PM Database Feature #4011: database/persistence layer performance improvements
I am checking out 4011a2 now...
Thinking over some of the issues you've been having, I expect the implicit transac...
Eric Faulhaber
06:46 PM Database Feature #4011: database/persistence layer performance improvements
I have committed my changes to temporary branch 4011a2. Important things:
* @SavepointReversible@ - dead code;
* @C...
Ovidiu Maxiniuc
05:54 PM Database Feature #3813: misc DB features part deux
It seems that the CONNECT statement which caused the @gso_241@ fail is incorrect.
I've added logging and the argume...
Igor Skornyakov
03:45 PM Database Feature #3813: misc DB features part deux
Task branch 4335a was merged to trunk as revision 11345.
The @ConnectionManager@ change was removed before it was ...
Greg Shah
03:46 PM Base Language Feature #3810: SECURITY-POLICY and other security features
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:45 PM Base Language Feature #3254: add support for running 4GL on multiple threads in a single session
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:45 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:43 PM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:42 PM User Interface Feature #4472 (Closed): Allow pause for a fraction of a second
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:41 PM User Interface Feature #4170: add drag and drop support to treeview widget
Task branch 4335a was merged to trunk as revision 11345.
See #4170-21 for the remaining work.
Greg Shah
03:39 PM Base Language Feature #3867: direct java class access from 4GL code
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:37 PM Base Language Feature #3867 (Closed): direct java class access from 4GL code
Greg Shah
03:38 PM Runtime Infrastructure Bug #4122: spawner segmentation fault when OS user has no password set
Task branch 4335a was merged to trunk as revision 11345. Greg Shah
03:38 PM Runtime Infrastructure Bug #4122 (Closed): spawner segmentation fault when OS user has no password set
Greg Shah
10:58 AM Base Language Feature #3868: customer servlet integration/support
Greg Shah wrote:
> 1. What can we do to make it simple to configure/load these servlets? I want to avoid a huge amo...
Constantin Asofiei

03/12/2020

09:28 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Do you have a simple example for this? Conversion rules should choose the @putBytes_1@ if the argument is @Memptr@. Constantin Asofiei
09:25 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Constantin Asofiei wrote:
> See #3751-492 for a comprehensive list of overload rules. We need support for method ov...
Marian Edu

03/11/2020

04:05 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey: Please write up the documentation for this widget in "CALENDAR Widget and OCX Replacement":/projects/p2j/wiki... Greg Shah
04:00 PM Base Language Feature #4384: Builtin OO Implementation
> Greg, do we have some guildelines how the converted 4GL ENUMs should look? I think we need to add HashAlgorithmEnum... Greg Shah
02:54 PM User Interface Feature #2683: reverse proxy implementation
We don't have documentation yet. External widget support is only needed in special cases where the code cannot be pl... Greg Shah
02:25 PM User Interface Feature #2683: reverse proxy implementation
Greg, please could you provide me with information about external widget support? Are there ready examples? Sergey Ivanovskiy
02:18 PM User Interface Feature #2683: reverse proxy implementation
Although it should be safe, I prefer to avoid changes in 4335a. Please put your changes into 4231b after it is rebas... Greg Shah

03/10/2020

09:42 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> The issue was due to the fact that @GetEnum@ methods in skeleton class for Enum were not static,...
Constantin Asofiei
09:37 AM Base Language Feature #4384: Builtin OO Implementation
On 3/10/20 12:20 PM, Mihai Tiganea wrote:
> Getting deeper with tests for openedge.core.bytebucket I discover commen...
Constantin Asofiei
04:22 AM Base Language Feature #4384: Builtin OO Implementation
It turns out returning an object<> that has a reference that was not 'registered' with @ObjectOps@ will fail anyway w... Marian Edu
03:58 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> > * Gradlew.bat deploy.all for oo/openedge/core/memptr/test_method_get_hash_algorithm.p ...
Marian Edu
09:10 AM User Interface Feature #2683: reverse proxy implementation
Sergey Ivanovskiy wrote:
> I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These chan...
Sergey Ivanovskiy
08:42 AM User Interface Feature #2683: reverse proxy implementation
I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These changes are only to remove logs ... Sergey Ivanovskiy
04:34 AM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, I was missing the .ext-hints. After this, your sleep t...
Hynek Cihlar
03:56 AM User Interface Feature #4170: add drag and drop support to treeview widget
Roger Borrello wrote:
> I see many new keywords added related to @node@ and @nodes@. Were they a result of this issu...
Hynek Cihlar
03:31 AM Database Feature #4011: database/persistence layer performance improvements
Rev 11397 changes the @BaseRecord@ methods @getId()@ and @setId(Long)@ to @primaryKey()@ and @primaryKey(Long)@, resp... Eric Faulhaber

03/09/2020

06:24 PM User Interface Feature #2683: reverse proxy implementation
Sergey Ivanovskiy wrote:
> Yes, it looks like the old issue documented in @WebClientProtocol@
OK, please add javado...
Constantin Asofiei
06:23 PM User Interface Feature #2683: reverse proxy implementation
Greg Shah wrote:
> I don't have a problem with the patch, but Constantin should review.
I'm OK with the patch.
>...
Constantin Asofiei
05:38 PM User Interface Feature #2683: reverse proxy implementation
Yes, it looks like the old issue documented in @WebClientProtocol@... Sergey Ivanovskiy
04:59 PM User Interface Feature #2683: reverse proxy implementation
It is interesting if we should remove logs here in @ThinClient.initializePost@ because it would block the web client?... Sergey Ivanovskiy
04:31 PM User Interface Feature #2683: reverse proxy implementation
It seems that this hanging issue is reproduced only when I tried to connect @https://localhost/gui@ and the Apache pr... Sergey Ivanovskiy
04:04 PM User Interface Feature #2683: reverse proxy implementation
The hanging issue has this thread context:
1) @KeyReader@ thread is in this state...
Sergey Ivanovskiy
03:41 PM User Interface Feature #2683: reverse proxy implementation
No, the broker manager patch is related to the case when the broker manager is not used but clients to ports map is r... Sergey Ivanovskiy
03:28 PM User Interface Feature #2683: reverse proxy implementation
I don't have a problem with the patch, but Constantin should review.
> It requires to set up a broker configuratio...
Greg Shah
03:14 PM User Interface Feature #2683: reverse proxy implementation
I tested this Apache Reverse proxy configuration with this branch 4335a using Hotel Gui application. The current code... Sergey Ivanovskiy
05:15 PM User Interface Feature #4170: add drag and drop support to treeview widget
I see many new keywords added related to @node@ and @nodes@. Were they a result of this issue? I noticed that @node-e... Roger Borrello
04:55 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements
I've documented some ideas related to Constantin's CFS reflection optimization task (#1970). Greg Shah
04:55 PM Base Language Feature #1970: improve ControlFlowOps method resolution by reflection
I've been thinking about how we could cache method instances in @ControlFlowOps@ recently. I started to document my ... Greg Shah
03:49 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Constantin Asofiei wrote:
> Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fi...
Roger Borrello
03:41 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fine.
Please check your clas...
Constantin Asofiei
03:27 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger, sorry, I can't make anything to work (@gethostbyname@, @GetComputerNameA@). I don't recall how this was suppo... Constantin Asofiei
02:52 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Eric Faulhaber wrote:
> Sorry, no. If this test case is one of mine, I don't remember it.
>
> Are you getting a p...
Roger Borrello
02:48 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Sorry, no. If this test case is one of mine, I don't remember it.
Are you getting a particular error, or just no r...
Eric Faulhaber
02:39 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Eric, did you ever test the @myconn1.p@ testcase under FWD and Windows? I'm trying to get my @Kernel32:Sleep@ functio... Roger Borrello
02:35 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
I made a simplified version of @uast/myconn1.p@:... Roger Borrello
02:12 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
I made sure my pathing was correct by validating that @directory.xml@ contains:... Roger Borrello
01:26 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
@./src/com/goldencode/testcases/name_map.xml@ looks good... although perhaps the pathing is misconfigured?... Roger Borrello
01:21 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger Borrello wrote:
> When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_...
Constantin Asofiei
01:16 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_emulation.Kernel32Sleep"@... Roger Borrello
12:50 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'l...
Roger Borrello
12:27 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger Borrello wrote:
> I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'll try to find my way from here....
Constantin Asofiei
12:25 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I was expecting to hit my breakpoint, but I must be missing s...
Roger Borrello
12:19 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Roger Borrello wrote:
> I was expecting to hit my breakpoint, but I must be missing something.
You need to attach t...
Constantin Asofiei
12:17 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
I've been trying to catch this in the debugger, but since this is my first rodeo debugging client or server runtime, ... Roger Borrello
08:16 AM Base Language Feature #4384: Builtin OO Implementation
On 3/9/20 1:36 PM, Mihai Tiganea wrote:
>
> After create tests in progress for ByteBucket and Memptr constructors, ...
Constantin Asofiei

03/06/2020

05:43 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Greg Shah wrote:
> Did the conversion occur successfully?
Yes......
Roger Borrello
05:39 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
Did the conversion occur successfully? Greg Shah
05:32 PM User Interface Feature #4182: KERNEL32:SLEEP() emulation
List of testcases:... Roger Borrello
05:03 AM Database Feature #4011: database/persistence layer performance improvements
There is this constant:... Ovidiu Maxiniuc

03/05/2020

03:18 PM Database Feature #4011: database/persistence layer performance improvements
We have had customer requests to rename the @id@ field/column, which is a commonly used field name in applications. C... Eric Faulhaber
09:40 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Rebased task branch 3880a from P2J trunk revision 11344. Stanislav Lomany

03/04/2020

02:30 PM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
The chart-related classes are in 4335a rev 11452 Constantin Asofiei
06:53 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
The list of files I've added for charting are:... Constantin Asofiei
05:58 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Greg Shah wrote:
> OK. I'm fine with using Java getters/setters.
I haven't fixed this yet. The solution should wo...
Constantin Asofiei
10:32 AM User Interface Bug #4498 (Closed): Embedded assignment of extent in shared frame fails
Greg Shah
10:31 AM User Interface Bug #4488 (Closed): Wrong frame used after display includes widgets from other frame
Greg Shah
10:31 AM Base Language Bug #4484 (Closed): Accumulator confusion using same field for count and total
Greg Shah
10:31 AM Base Language Bug #4483 (Closed): Unable to use logical variable check in underline statement
Greg Shah
10:30 AM Base Language Bug #4482 (Closed): Enable/Disable with empty EXCEPT causes issues
Greg Shah
10:30 AM Base Language Bug #4480 (Closed): Extent does not become fixed when there is an initial list of values
Greg Shah
10:29 AM Base Language Bug #4455 (Closed): Extent field on unsubscripted next-prompt not converted properly
Greg Shah
10:29 AM Base Language Bug #4427 (Closed): Unable to convert keyword input when used to index into an extent
Greg Shah
10:29 AM Base Language Bug #4425 (Closed): Lost frame_id when converting code with missing field names to update
Greg Shah
10:28 AM Base Language Bug #4424 (Closed): Additional def var needed to receive table handle when keyword FOR included i...
Greg Shah
10:28 AM Base Language Bug #4423 (Closed): Incorrect buffer scoping when same buffer name used as a parameter to interna...
Greg Shah

03/03/2020

06:28 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
h2. Attributes
This documents the @TITLE-BGCOLOR@, @TITLE-DCOLOR@, @TITLE-FGCOLOR@ and @TITLE-FONT@ attributes for...
Greg Shah
02:56 PM User Interface Bug #4498: Embedded assignment of extent in shared frame fails
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:56 PM User Interface Bug #4488: Wrong frame used after display includes widgets from other frame
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:54 PM Base Language Bug #4484 (Review): Accumulator confusion using same field for count and total
Task branch 4207a was merged to trunk as revision 11344. Task can be moved to closed. It was still in WIP. Roger Borrello
02:53 PM Base Language Bug #4483: Unable to use logical variable check in underline statement
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:51 PM Base Language Bug #4482: Enable/Disable with empty EXCEPT causes issues
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:50 PM Base Language Bug #4480: Extent does not become fixed when there is an initial list of values
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:49 PM Base Language Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:46 PM Base Language Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Task branch 4207a was merged to trunk as revision 11344. There have not been any regressions or new issues related to... Roger Borrello
02:28 PM Base Language Bug #4453 (WIP): Handling of filename with quotation mark broken in control_flow.rules
Roger Borrello
02:43 PM Base Language Bug #4427: Unable to convert keyword input when used to index into an extent
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:42 PM Database Bug #4426: Cannot find parent when processing REPEAT PRESELECT
Task branch 4207a was merged to trunk as revision 11344. However, this task was worked around in customer code, and h... Roger Borrello
02:40 PM Base Language Bug #4425: Lost frame_id when converting code with missing field names to update
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:39 PM Base Language Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:38 PM Base Language Bug #4423: Incorrect buffer scoping when same buffer name used as a parameter to internal procedure
Task branch 4207a was merged to trunk as revision 11344. Roger Borrello
02:36 PM Base Language Bug #4476 (Closed): Shared frame does not get @ widget method generated
Greg Shah
02:26 PM Base Language Bug #4476: Shared frame does not get @ widget method generated
Greg Shah wrote:
> Task branch 4207a was merged to trunk as revision 11344.
>
> Is there anything left open in th...
Roger Borrello
02:24 PM Base Language Bug #4476: Shared frame does not get @ widget method generated
Task branch 4207a was merged to trunk as revision 11344.
Is there anything left open in this task?
Greg Shah
01:50 PM Base Language Bug #4563: assigning a dynamic extent var to a OO method call as rvalue
Static vars/properties (with dynamic extent) should be included. Constantin Asofiei
08:22 AM Base Language Bug #4563: assigning a dynamic extent var to a OO method call as rvalue
The @testcases/uast/ext_arg_*.p@ tests explore how a parameter/variable (dynamic extent or not) used as an argument e... Constantin Asofiei
08:14 AM Base Language Bug #4563 (New): assigning a dynamic extent var to a OO method call as rvalue
Constantin Asofiei
01:08 PM User Interface Feature #4174 (Closed): implement calendar control/dtpicker OCX replacement
Branch 4207a was merged to trunk as revision 11344.
The items in #4174-152 are deferred to a future task (when a c...
Greg Shah
07:55 AM User Interface Feature #4174 (Test): implement calendar control/dtpicker OCX replacement
Greg Shah
01:04 PM Database Bug #4450: implement shared query and shared browse
Branch 4207a was merged to trunk as revision 11344. Greg Shah
01:02 PM Database Bug #4450 (Closed): implement shared query and shared browse
Greg Shah
01:04 PM Base Language Bug #4123 (Closed): conversion generates incorrect java code for Extent statement
Branch 4207a was merged to trunk as revision 11344. Greg Shah
01:04 PM Base Language Bug #4160 (WIP): Arrays assigment issue
Branch 4207a was merged to trunk as revision 11344. Greg Shah
10:44 AM Database Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...
This has nothing to do with the FIND. The issue is in the assignment.... Greg Shah
10:16 AM Database Bug #4564: unqualified field references can get the wrong buffer name if a FORM or DEF FRAME is p...
h2. Description
Extra scoping causes issues with wrong buffer being used for unqualified field names. Same results...
Roger Borrello
10:08 AM Database Bug #4564 (New): unqualified field references can get the wrong buffer name if a FORM or DEF FRAM...
Roger Borrello

03/02/2020

06:43 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
h2. Title Phrase
Summary:
* the syntax processing of options for the frame phrase and the browse options phrase...
Greg Shah
05:30 PM User Interface Feature #4393: add TITLE-DCOLOR attribute support
The following testcases were created:... Greg Shah
05:20 PM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > This is probably OK for now, but we are really trying to achieve a...
Greg Shah
10:41 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Greg Shah wrote:
> This is probably OK for now, but we are really trying to achieve a generic data visualization wid...
Constantin Asofiei
09:59 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
> I'm placing everything related to chart in com.goldencode.p2j.ui.chart, except main widget class (ui.ChartWidget).
...
Greg Shah
08:08 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The chaining (for chart setup) is pretty deep and is easier to ...
Constantin Asofiei
07:58 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
Constantin Asofiei wrote:
> The chaining (for chart setup) is pretty deep and is easier to allow this instead of exp...
Hynek Cihlar
07:57 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
I'm placing everything related to chart in @com.goldencode.p2j.ui.chart@, except main widget class (@ui.ChartWidget@)... Constantin Asofiei
07:54 AM User Interface Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...
For chart, in the end I'm working on adding support for calls like:... Constantin Asofiei
03:52 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> UNDO update.
> The old implementation was using commits and rollbacks a bit aggressive, al...
Eric Faulhaber
03:17 PM Database Feature #4011: database/persistence layer performance improvements
UNDO update.
The old implementation was using commits and rollbacks a bit aggressive, altogether with creation of ne...
Ovidiu Maxiniuc
02:15 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> So, are you saying you also would expect @HQLPreprocessor@ to still handle the null paramete...
Ovidiu Maxiniuc
12:55 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Committed revision 11420 (4207a) fixed the custom format and color setters, removed extra elements from Calendar widg... Sergey Ivanovskiy
10:00 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
These MS Date/Time Picker features are not implemented yet:
1) to support MS @CustomFormat@ https://docs.microsoft...
Sergey Ivanovskiy

02/29/2020

02:24 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
This task branch 4174a has been merged into the trunc as rev 11343 and archived. Sergey Ivanovskiy
02:02 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Hynek Cihlar wrote:
> Code review 4174a revisions 11373..11379.
>
> @<action>map6.put("UpDown" , "UpDow...
Sergey Ivanovskiy
01:46 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Code review 4174a revisions 11373..11379.
@<action>map6.put("UpDown" , "UpDown")</action>@ is redundant ...
Hynek Cihlar
12:33 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Committed rev 11379 (4174a) fixed @DateTimeValue@ widget value to accept ISO date and time string value. Planning to ... Sergey Ivanovskiy
11:36 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Committed revision 11378 (4174a) fixed @SCREEN-VALUE@ for new calendar widget. Sergey Ivanovskiy

02/28/2020

05:38 PM Database Feature #4011: database/persistence layer performance improvements
So, are you saying you also would expect @HQLPreprocessor@ to still handle the null parameters before getting into th... Eric Faulhaber
04:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric, please grab the 11396 revision. In my hurry I did not fully test the do and I made it worse. Ovidiu Maxiniuc
02:37 PM Database Feature #4011: database/persistence layer performance improvements
Thanks. See @raq_nulls_sort.p@ in testcases. Eric Faulhaber
02:32 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I haven't debugged too deeply yet... shouldn't @HQLPreprocessor@ have taken care of those @n...
Ovidiu Maxiniuc
02:04 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I have this stack trace:... Eric Faulhaber
05:26 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
No objections. Greg Shah
05:19 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Committed revision 11377 (4174a) fixed the conversion for new calendar widget when common methods of @OcxMouse@ and @... Sergey Ivanovskiy
10:12 AM User Interface Bug #4558: The semitransparent picture of the web client page is displayed when dragging the mouse
With Firefox we can observe the default action when dragging the mouse (the left mouse button is pressed and the mous... Sergey Ivanovskiy
10:09 AM User Interface Bug #4558 (New): The semitransparent picture of the web client page is displayed when dragging th...
Sergey Ivanovskiy

02/27/2020

08:41 AM User Interface Bug #4557: radio-set deviations from the 4GL GUI
Eugenie found this list of bugs (testing with branch 4335a) while running the radio-set testcases (in @testcases/uast... Greg Shah
08:36 AM User Interface Bug #4557 (New): radio-set deviations from the 4GL GUI
Greg Shah
05:14 AM Base Language Feature #4384: Builtin OO Implementation
Mihai, yes, Java is not that comfortable with spaces in the path. Try to avoid folders with spaces. Constantin Asofiei
02:19 AM Base Language Feature #4384: Builtin OO Implementation
Mihai Popescu-Tiganea wrote:
>
> Constantin, can you guide me to build project?
Issue solved.
Seems that class...
Mihai Popescu-Tiganea

02/26/2020

02:13 PM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
During the @test_bar_test2.p@ I found the conversion issues and fixed them so the @ProgressBar@ can be wrapped into @... Sergey Ivanovskiy
10:04 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Yes, I missed this option in the hint file @progress_bar_test.p.ext-hints@... Sergey Ivanovskiy
09:59 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
But this test @uast/progressbar/progress_bar_test6.p@ doesn't have @control_load@ procedure and hence it can be used ... Sergey Ivanovskiy
09:36 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
I don't understand why the @.wrx@ file is needed. If you configure the @.ext-hints@ file, the @LoadControls@ will be... Greg Shah
09:30 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
The committed revision 11374 (4174a) fixed @progressbar@ widget issues and this test from @testcases@ must be fixed d... Sergey Ivanovskiy
01:43 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Greg Shah wrote:
> What testing (conversion and runtime) is needed before this can be merged to trunk?
The customer...
Sergey Ivanovskiy
01:13 PM Base Language Feature #4384: Builtin OO Implementation
> Please help us with new branch and bzr access.
For now, I think it is best to build upon 4335a. Make sure that ...
Greg Shah
10:22 AM Base Language Feature #4384: Builtin OO Implementation
> You already have access to it at @xfer.goldencode.com:/opt/fwd/4335a@.
I have get from bzr 4335a project.
Comm...
Mihai Popescu-Tiganea
09:09 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Well, it's true that the code is wrapped inside a @silent@ block in the converted source, howeve...
Constantin Asofiei
08:35 AM Base Language Feature #4384: Builtin OO Implementation
> Another thing that looks odd is that while FINALLY blocks gets converted alright no CATCH block seems to be convert... Greg Shah
07:19 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Mihai: When you are ready to start on the Java code, we will create a new branch 4384a and we w...
Mihai Popescu-Tiganea
05:13 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> NO-ERROR has both a conversion and runtime part. When NO-ERROR is used, you will see th...
Marian Edu
05:03 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> 11.7 is the best reference. If you do know if major changes to these classes in 12.x let us know...
Marian Edu
11:30 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
For enhanced browse changes created task branch 3880a from FWD trunk revision 11342. Stanislav Lomany
10:21 AM Database Bug #4450: implement shared query and shared browse
> Can you do regression testing?
Sure.
Stanislav Lomany
09:43 AM Database Bug #4450: implement shared query and shared browse
Stanislav Lomany wrote:
> > Would you like me to handle the change to @screen_buffer.rules@,
>
> That seems a sa...
Roger Borrello
09:34 AM Database Bug #4450: implement shared query and shared browse
> Would you like me to handle the change to @screen_buffer.rules@,
That seems a safer option to me.
Stanislav Lomany
09:32 AM Database Bug #4450: implement shared query and shared browse
Stanislav Lomany wrote:
> > This change in @screen_buffer.rules@ was making sure the @frame-id@ and the other widget...
Roger Borrello
08:42 AM Database Bug #4450: implement shared query and shared browse
> This change in @screen_buffer.rules@ was making sure the @frame-id@ and the other widget annotations are placed in ... Stanislav Lomany
 

Also available in: Atom