Project

General

Profile

Activity

From 06/01/2020 to 06/30/2020

07/01/2020

08:12 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it se...
Ovidiu Maxiniuc
08:10 PM Database Feature #4011: database/persistence layer performance improvements
About the 'reWriteBatchedInserts=true' optimization for data import. I think this is just reporting '0' after the in... Constantin Asofiei
08:00 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, we are still converting LOBs for DMOs (interfaces and implementation classes), it seems, same as before. What... Eric Faulhaber

06/30/2020

07:58 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Some details about postgresql are here: https://jdbc.postgre...
Constantin Asofiei
07:50 PM Database Feature #4011: database/persistence layer performance improvements
There's a change in 4011a_rebase which breaks @RecordBuffer.initialize@. This was previously done when @getDMOImplem... Constantin Asofiei
07:38 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Some details about postgresql are here: https://jdbc.postgresql.org/documentation/80/bin...
Ovidiu Maxiniuc
07:29 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> blob and clob import is broken now. I'm working on fixing @PropertyMapper@.
The same p...
Constantin Asofiei
07:09 PM Database Feature #4011: database/persistence layer performance improvements
blob and clob import is broken now. I'm working on fixing @PropertyMapper@. Constantin Asofiei
05:05 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There are some issues in @IndexHelper.getPrimaryIndex@:
> * it was using @dmoClass@ ins...
Constantin Asofiei
04:48 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > * @TemporaryBuffer@
> > ** @makeMutable@ - yes, we need ...
Constantin Asofiei
08:35 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> * @TemporaryBuffer@
> ** @makeMutable@ - yes, we need an interface there, otherwise the...
Constantin Asofiei
05:43 AM Database Feature #4011: database/persistence layer performance improvements
The patch looks ok to me. Eric Faulhaber
08:04 PM Database Feature #4011: database/persistence layer performance improvements
There are some issues in @IndexHelper.getPrimaryIndex@:
* it was using @dmoClass@ instead of @dmoIface@ to get the a...
Constantin Asofiei
04:39 PM Database Feature #3814: more schema metadata
Found a minor issue with @_Field-Trig@ population.
Committing to 3821c revision 11381. ...
Igor Skornyakov
03:57 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a...
Igor Skornyakov
03:24 AM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Very strange. Can you please send me your project? I will take a...
Igor Skornyakov
10:34 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Very strange. Can you please send me your project? I will take a look tomorrow.
> Thank yo...
Roger Borrello
04:35 PM User Interface Feature #4661: add support for missing formats to image loading
I don't think a testcase is really necessary, in that the customer application is already utilizing @gif@ images on b... Roger Borrello
08:30 AM User Interface Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. Yo...
Roger Borrello
08:12 AM User Interface Feature #4661: add support for missing formats to image loading
Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. You can test this pure... Greg Shah
08:10 AM User Interface Feature #4661: add support for missing formats to image loading
Can you make a summary of what Roger would have to do (e.g. something like "look at classes X, Y and Z, method A and ... Greg Shah
02:14 PM Database Support #4702: write temp-table performance test cases
It is a common case in which a lot of time is likely to be spent in real applications. Any server-side stuff is goin... Greg Shah
01:09 PM Database Support #4702: write temp-table performance test cases
Greg Shah wrote:
> Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and...
Eric Faulhaber
01:06 PM Database Support #4702: write temp-table performance test cases
Stanislav Lomany wrote:
> [...]
> Is that good for a start?
Yes.
Eric Faulhaber
08:58 AM Database Support #4702: write temp-table performance test cases
I'm think there will be tables which will have the same set of fields:
# integer
# char
# double
# date
# logica...
Stanislav Lomany
08:17 AM Database Support #4702: write temp-table performance test cases
Perhaps it makes sense to have a test that has some temp-tables with large numbers of columns and uses buffer-copy to... Greg Shah
01:14 PM Database Feature #4055: optimize temp-table output parameter copying
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > * Pre-validation of each record is necessary. If we leave it ...
Eric Faulhaber
06:00 AM Database Feature #4055: optimize temp-table output parameter copying
Eric Faulhaber wrote:
> * Pre-validation of each record is necessary. If we leave it to the database to reject uniqu...
Constantin Asofiei
11:11 AM Base Language Feature #4384: Builtin OO Implementation
Marian, I think this is your change, right?... Constantin Asofiei
06:02 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Igor Skornyakov wrote:
> Is it a top-priority task?
It is next highest priority behind any work needed to complet...
Eric Faulhaber
06:00 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
@TempTableDataSourceProvider@ was introduced in branch 4011a to provide database connections to the in-memory H2 data... Eric Faulhaber
05:53 AM Database Bug #4703: investigate whether performance of TempTableDataSourceProvider can be improved
Is it a top-priority task?
Thank you.
Igor Skornyakov
05:50 AM Database Bug #4703 (Hold): investigate whether performance of TempTableDataSourceProvider can be improved
Eric Faulhaber
08:24 PM Database Support #4701: try to improve H2 transaction commit performance
Eric Faulhaber wrote:
> Start with version 1.4.197 and apply our existing patches before you build. Constantin has a...
Constantin Asofiei
08:22 PM Database Bug #4057: h2 performance degradation
Eric Faulhaber wrote:
> Constantin has a recent patch which is not integrated into the FWD distribution yet; you wil...
Constantin Asofiei

06/29/2020

07:43 PM Database Support #4702: write temp-table performance test cases
We need a set of temp-table related test cases in support of issues #4057 and #4071. The tests need to stress H2 as t... Eric Faulhaber
05:11 PM Database Support #4702 (Closed): write temp-table performance test cases
Eric Faulhaber
07:16 PM Database Bug #4057: h2 performance degradation
Please get the source for the latest version of H2 (1.4.200 at the time of this writing) and port our existing patche... Eric Faulhaber
07:07 PM Database Support #4701: try to improve H2 transaction commit performance
H2's transaction commit code repeatedly shows up as a performance bottleneck when profiling FWD application code. We ... Eric Faulhaber
05:10 PM Database Support #4701 (Closed): try to improve H2 transaction commit performance
Eric Faulhaber
06:33 PM User Interface Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see th...
Eugenie Lyzenko
06:26 PM User Interface Feature #4661: add support for missing formats to image loading
Roger Borrello wrote:
> Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMo...
Eugenie Lyzenko
02:48 PM User Interface Feature #4661: add support for missing formats to image loading
Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see that we have the abili... Greg Shah
02:12 PM User Interface Feature #4661: add support for missing formats to image loading
Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMonkeys
It seems @gif@ i...
Roger Borrello
06:02 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, there is a TODO in @TableMapper@:... Eric Faulhaber
02:57 PM Database Feature #4011: database/persistence layer performance improvements
@DmoMetadataManager.getBasePackage@
LE: Sorry, it's actually @DmoMetadataManager.getDmoBasePackage@, and it will i...
Eric Faulhaber
02:52 PM Database Feature #4011: database/persistence layer performance improvements
What is the counterpart of the @DMOIndex.getBasePackage()@ in 4011a?
Thank you.
Igor Skornyakov
12:52 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > Greg Shah wrote:
> > > Is index size a problem for temp-tables?...
Greg Shah
08:54 AM Database Feature #4011: database/persistence layer performance improvements
* @SortCriterion@
** @WHERE_WITH_NULLS@ I think can be removed. I'll need to double-check the customer project, but...
Constantin Asofiei
08:30 AM Database Feature #4011: database/persistence layer performance improvements
@FWDDataObject@ - this class is used outside of the FWD context, by customer code via @LegacyJavaAppserver@. I'm wor... Constantin Asofiei
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Regarding the rebase TODO in @DatabaseManager.getDatabaseDMOs@...
The javadoc for @DatabaseManager.getDatabaseDMOs...
Eric Faulhaber
05:20 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Roger, what version of 3821c do you have? Note that trunk had a metadata generation issu...
Roger Borrello
05:17 PM Database Feature #3814: more schema metadata
Roger, what version of 3821c do you have? Note that trunk had a metadata generation issue which was solved in a 3821... Constantin Asofiei
05:08 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Roger,
> > I'm busy now with some urgent assignment. Was the @m...
Igor Skornyakov
05:03 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Roger,
> I'm busy now with some urgent assignment. Was the @meta_table_ddl.sql@ file gener...
Roger Borrello
04:48 PM Database Feature #3814: more schema metadata
Roger Borrello wrote:
> I started receiving this during runtime of my testcase:
> [...]
>
> I made a few updates...
Igor Skornyakov
04:38 PM Database Feature #3814: more schema metadata
I started receiving this during runtime of my testcase:... Roger Borrello
02:30 PM Database Feature #3814: more schema metadata
3821c revision 11377 fixes a regression DMO generation. The VIEW-AS text can have embedded quotes and escape sequenc... Greg Shah
11:40 PM Database Feature #3813: misc DB features part deux
Branch 3821c revision 11374 has the implementation of @BUFFER-FIELD:DEFAULT-VALUE@ as well as the fixes to @date@/@da... Greg Shah

06/27/2020

04:13 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Is index size a problem for temp-tables? I thought that was a SQLSer...
Eric Faulhaber

06/26/2020

07:33 PM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> Is index size a problem for temp-tables? I thought that was a SQLServer thing.
4GL has its own ...
Ovidiu Maxiniuc
07:27 PM Database Feature #4011: database/persistence layer performance improvements
Is index size a problem for temp-tables? I thought that was a SQLServer thing. Greg Shah
06:55 PM Database Feature #4011: database/persistence layer performance improvements
Note that in the cases where the DMO implementation classes are different, it is not just unique constraints that are... Eric Faulhaber
06:36 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > In @TemporaryBuffer.copyAllRows@, we can skip record validati...
Constantin Asofiei
06:13 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> In @TemporaryBuffer.copyAllRows@, we can skip record validation if:
> [...]
>
> This...
Eric Faulhaber

06/25/2020

04:10 PM Database Feature #3814: more schema metadata
Added _File-Trig and _Field-Trig population
Committing to 3821c revision 11366. ...
Igor Skornyakov
12:51 PM Database Feature #4011: database/persistence layer performance improvements
Regarding the test at #4011-633 - I've created a physical database with the same table structure and indexes, and OE ... Constantin Asofiei
12:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I'm not sure what you are asking. Across different DMO implementation classes, two unique in...
Constantin Asofiei
12:44 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> But, does anyone know if we have a way to check if the unique indexes in two DMO impl ma...
Eric Faulhaber
09:55 AM Database Feature #4011: database/persistence layer performance improvements
For temp-tables, FWD has problems with this test:... Constantin Asofiei
09:10 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, an idea about the temp-table flushing. We currently save on every touched field. ...
Constantin Asofiei
09:00 AM Database Feature #4011: database/persistence layer performance improvements
Eric, an idea about the temp-table flushing. We currently save on every touched field. But I think we can defer thi... Constantin Asofiei
06:36 AM Database Feature #4011: database/persistence layer performance improvements
In @TemporaryBuffer.copyAllRows@, we can skip record validation if:... Constantin Asofiei
04:00 AM Base Language Feature #4384: Builtin OO Implementation
We have some issues with OO named events, one of the tests does not pass conversion: @oo/openedge/net/http/filter/aut... Marian Edu

06/24/2020

06:49 PM Database Feature #4011: database/persistence layer performance improvements
The NULLS LAST/FIRST fix is in 4011a rev 11499. Constantin Asofiei
05:50 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I don't understand what is happening. The same SQL in the standalone H2 server knows to...
Constantin Asofiei
03:29 PM Database Feature #4011: database/persistence layer performance improvements
I don't understand what is happening. The same SQL in the standalone H2 server knows to move the nulls to last posit... Constantin Asofiei
02:35 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Also, H2 is wrong with or without a DESC index for F2 - the NULL must be first.
To be m...
Constantin Asofiei
02:33 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, add an ASC index for F1 and you will see that H2 is wrong - it will place the NULL first.
Also, H2 is wron...
Constantin Asofiei
02:32 PM Database Feature #4011: database/persistence layer performance improvements
... Ovidiu Maxiniuc
02:28 PM Database Feature #4011: database/persistence layer performance improvements
What's the result for @select * from t1 order by f1 desc;@? Constantin Asofiei
02:27 PM Database Feature #4011: database/persistence layer performance improvements
I did a quick test with H2:... Ovidiu Maxiniuc
02:24 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I have some tests, and OE sorts the nulls always last, regardless of direction.
Sorry, ...
Constantin Asofiei
02:01 PM Database Feature #4011: database/persistence layer performance improvements
I have some tests, and OE sorts the nulls always last, regardless of direction.
H2 has a bug in that it doesn't co...
Constantin Asofiei
01:16 PM Database Feature #4011: database/persistence layer performance improvements
Postgresql states that:
> By default, null values sort as if larger than any non-null value; that is, NULLS FIRST is...
Constantin Asofiei
11:48 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Another issue is that the SUBSELECT doesn't have the @NULLS LAST@. At least we should b...
Constantin Asofiei
11:42 AM Database Feature #4011: database/persistence layer performance improvements
There is a problem in 4011a, where we emit @NULLS LAST@ in the @ORDER BY@ clause. This causes a performance regressi... Constantin Asofiei
03:20 PM Database Feature #3814: more schema metadata
Finished with VIEW-AS field property conversion and population of the @_Field._View-As@.
Tested with a standalone te...
Igor Skornyakov
08:55 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, the fix is in 3821c rev 11363.
> >
> > Please test ...
Roger Borrello
08:40 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Constantin Asofiei wrote:
> Roger, the fix is in 3821c rev 11363.
>
> Please test with the customer scenario.
...
Roger Borrello
07:10 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger, the fix is in 3821c rev 11363.
Please test with the customer scenario.
Constantin Asofiei
05:58 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> I am attaching a patch because I didn't have a branch to which to commit. The attached patch...
Constantin Asofiei
05:28 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Constantin, please take it from here.
OK, I'm working on it.
Constantin Asofiei
01:33 AM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Roger Borrello wrote:
> That patch alleviated the NPE, and we now result in:
> * "Unable to PREPARE TEMP-TABLE bu...
Eric Faulhaber
07:05 AM Database Support #3871: determine how to change codepages/locales during import
This task is not about the runtime environment. This is only about database import.
What matters is that we must ...
Greg Shah
12:02 AM Database Support #3871: determine how to change codepages/locales during import
Analyzing the task history. The @FWD@ functionality from my understanding is to have tow separate parts, runtime envi... Eugenie Lyzenko

06/23/2020

07:54 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Yes and no :-)
>
> I am attaching a patch because I didn't have a branch to which to comm...
Roger Borrello
06:09 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Yes and no :-)
I am attaching a patch because I didn't have a branch to which to commit. The attached patch fixes ...
Eric Faulhaber
06:04 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Eric Faulhaber wrote:
> Nevermind, got it.
Are you looking at this? Did you see the notes in #4208-736 ?
Roger Borrello
04:55 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Nevermind, got it.... Eric Faulhaber
04:49 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Stack trace? Eric Faulhaber
04:01 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
Will there be different code-paths for a temp-table versus a standard table? I am walking through the testcase, tryin... Roger Borrello
01:17 PM Database Bug #3172: QUERY-PREPARE can be used on static queries (and the sorting can be dynamically changed)
This code generates a @NPE@ on @trunk-11347@:... Roger Borrello
07:17 PM Database Feature #4011: database/persistence layer performance improvements
I committed revision 11496 to 4011a. It is mainly a FLQ support update:
* added support for DMOs in FROM clause of S...
Ovidiu Maxiniuc
10:35 AM Database Feature #4011: database/persistence layer performance improvements
It is not clear to me why we match @PROPERTY@ in the lexer (as @DOT SYMBOL@). Since there are many possible qualifie... Greg Shah
10:22 AM Database Feature #4011: database/persistence layer performance improvements
Related to parsing of FQL: at this moment FQL2SQL is unable to parse queries like:
@from com.goldencode.appname.dmo....
Ovidiu Maxiniuc
06:06 AM Database Feature #4011: database/persistence layer performance improvements
I've committed revisions 11494 and 11495. 11494 is Ovidiu's import fix. 11495 partially fixes the test case in #4011-... Eric Faulhaber
05:38 PM Database Feature #3814: more schema metadata
After adding checks for @null@ to the @SymbolResolver@ I do not see warning anymore and there is a @KW_VIEW_AS@ note... Igor Skornyakov
05:12 PM Database Feature #3814: more schema metadata
> I do not see KW_VIEW_AS node in the .schema or .dict files. Maybe this is a result of NPE.
Yes, possibly so.
Greg Shah
05:04 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> > however, there is no KW_VIEW_AS node in the AST at all
>
> The @replaceAst()@ rewrites that ...
Igor Skornyakov
04:46 PM Database Feature #3814: more schema metadata
> however, there is no KW_VIEW_AS node in the AST at all
The @replaceAst()@ rewrites that @KW_VIEW_AS@ subtree, th...
Greg Shah
04:42 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, do you think is safe to set @dict=true@ at the @SymbolResolv...
Igor Skornyakov
04:37 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b...
Greg Shah
04:10 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created b...
Igor Skornyakov
03:39 PM Database Feature #3814: more schema metadata
Greg, do you think is safe to set @dict=true@ at the @SymbolResolver@ instance created by @SchemaLoader.postProcessIm... Constantin Asofiei
03:36 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > This is exactly what I did. It seems that not callers are re...
Igor Skornyakov
03:24 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> This is exactly what I did. It seems that not callers are ready for @null@. But I will try ...
Constantin Asofiei
03:19 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> > I've tried this. It doesn't help, NPE happens in @SymbolResolver.addWrappedWorker@
> ...
Igor Skornyakov
03:15 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > I think is enough to add a NPE check there for @currentCls@....
Constantin Asofiei
03:13 PM Database Feature #3814: more schema metadata
Constantin Asofiei wrote:
> I think is enough to add a NPE check there for @currentCls@. During schema parser, ther...
Igor Skornyakov
03:08 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> The conversion of the .df files produces a number of warnings like this:
> [...]
> This h...
Constantin Asofiei
02:59 PM Database Feature #3814: more schema metadata
The conversion of the .df files produces a number of warnings like this:... Igor Skornyakov
03:24 PM Base Language Feature #3753: I18N additions
Some things we've found and tried to fix soo far while implementing OO base classes...
- codepage conversion support...
Marian Edu
02:45 PM Base Language Feature #4384: Builtin OO Implementation
Just making a note so don't forget about it, there is an issue with destructors when there is an error thrown from a ... Marian Edu
02:41 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin, do you still need those extra tests for REST? I'm having troubles getting the deploy...
Constantin Asofiei
02:02 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Greg Shah wrote:
> Task branch 4231b has been merged to trunk as revision 11347.
Constantin, do you still need th...
Marian Edu
08:01 AM Database Support #3871 (WIP): determine how to change codepages/locales during import
Sergey Ivanovskiy wrote:
> I used the similar diff to the following one in order to setup the UTF-8 database with IN...
Greg Shah

06/22/2020

06:12 PM Database Feature #4011: database/persistence layer performance improvements
Some notes about @fql.g@ from my quick review:
* The overall structure looks ... familiar. :) This is not a compl...
Greg Shah
02:28 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There are issues in 4011a with the batch deletes:
> * the composite tables need to be d...
Constantin Asofiei
10:00 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r...
Eric Faulhaber
04:30 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Code Review Task Branch 3821c Revision 11358
This seems better. Confirm it with testing.
Greg Shah
10:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
This was implemented in @3821c-11358@. Please review, and let me know if there's a way to run an individual test for ... Roger Borrello
08:20 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Roger Borrello wrote:
> If @ConfigHelper.getAssignedRow(frame.config())@ can return @BaseConfig.INV_COORD@ as well, ...
Roger Borrello
08:16 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11354
>
> This is incorrect. @ConfigHelper.getAssigned...
Roger Borrello
06:50 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Code Review Task Branch 3821c Revision 11354
This is incorrect. @ConfigHelper.getAssignedColumn(frame.config())@ ...
Greg Shah
09:28 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Greg Shah wrote:
> As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
>
> I've ba...
Roger Borrello
01:42 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Good point. We should add a comparison of legacy "mandatory" fields with database columns marked "not null" as part o... Eric Faulhaber
12:48 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Additional indices are OK as they could improve performance (if we spot some series of queries that frequently use a ... Ovidiu Maxiniuc
12:38 PM Database Feature #4692: add sanity check at server startup to compare DMO indices with database indices
Branch 4011a eliminates the collection of index metadata from the database at startup to populate @IndexHelper@ data ... Eric Faulhaber
12:27 PM Database Feature #4692 (New): add sanity check at server startup to compare DMO indices with database indices
Eric Faulhaber
01:37 PM Database Support #4693: check whether our index consolidation adversely affects flushing behavior
During schema conversion, we do some consolidation of the original 4GL indices to eliminate redundant indices. I am w... Eric Faulhaber
01:28 PM Database Support #4693 (New): check whether our index consolidation adversely affects flushing behavior
Eric Faulhaber
11:24 AM Database Feature #3814: more schema metadata
Finished re-working metadata configuration in p2j.cfg.xml.
Now, if there is no <metadata> section on the @p2j.cfg.xm...
Igor Skornyakov
07:04 AM User Interface Feature #4170: add drag and drop support to treeview widget
Is there any remaining work or testing needed for this task? Greg Shah
06:39 AM User Interface Bug #4631 (Test): Widget scoped to wrong frame on hide
Code Review Task Branch 3821c Revision 11353
The changes are good.
Greg Shah
09:26 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
>
...
Roger Borrello

06/21/2020

07:28 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I assume that @ScrollPaneGuiImpl@ needs a change that gives more control over its positioning, sizing or over the dra... Greg Shah
07:26 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I don't think it makes sense to have an enhanced browse menu button inside a scrolling helper class. Greg Shah
07:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Can't the scrollbars be sized and positioned so that they don't overlap the space for the gear icon?
Sorry, don'...
Stanislav Lomany
07:00 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
You can subclass it if that is the best way. But it seems like the gear icon will always be there in this mode, so w... Greg Shah
06:55 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> I don't know the answer here, but I wouldn't want a generic helper class to have a browse-specific feature.
If t...
Stanislav Lomany
06:50 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
We should not take up more space than the 4GL compatible version. Instead we "sacrifice" a row.
> X-1 rows, but ...
Greg Shah
10:46 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg, I have a question about the "tray" which should appear if there are no scrollbars and we want to find a place f... Stanislav Lomany
06:51 PM Database Feature #3814: more schema metadata
Yes, I think that is fine. Greg Shah
10:54 AM Database Feature #3814: more schema metadata
Do we really need to support @p2j.cf.xml@ w/o a <metadata> section? It requires a lot of changes as in many places it... Igor Skornyakov
05:09 AM Database Feature #3814: more schema metadata
Backport of the @SEQUENCE@ support from 4011a and population of the @_Sequence@ table committed to 3821c rev. 11351. Igor Skornyakov

06/20/2020

01:34 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> 3821c not b
OK, thank you.
Igor Skornyakov
01:33 PM Database Feature #3814: more schema metadata
3821c not b Greg Shah
01:32 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Hynek will open 3821b shortly.
Got it. Thanks!
Igor Skornyakov
01:23 PM Database Feature #3814: more schema metadata
Hynek will open 3821b shortly. Greg Shah
12:45 PM Database Feature #3814: more schema metadata
Greg, which branch should I use for #3814 now?
Thank you.
Igor Skornyakov
12:00 PM Database Feature #3814: more schema metadata
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:11 PM User Interface Bug #4589 (Closed): menu case sensitivity and conversion
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:10 PM Database Bug #4492: database trigger defined with abbreviation should create a new buffer
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:10 PM Base Language Support #4657: memory overhead from preloading classes with LegacySignature
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:06 PM User Interface Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:04 PM User Interface Bug #3690 (Closed): BUTTON widget reaction on SPACEBAR and ENTER keys
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:03 PM User Interface Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:02 PM User Interface Feature #2683: reverse proxy implementation
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:01 PM Runtime Infrastructure Feature #3819: PROFILER system handle
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:01 PM Database Bug #3471: incremental conversion is regressed
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM Base Language Feature #4395 (Closed): add support for KEEP-MESSAGES option
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4393 (Closed): add TITLE-DCOLOR attribute support
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
12:00 PM User Interface Feature #4394 (Closed): add some frame options and attributes
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:59 AM Base Language Feature #4162 (Closed): enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:58 AM Base Language Feature #3812 (Closed): additions to SESSION system-handle
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:58 AM Base Language Feature #4381 (Closed): implement LIBRARY() and MEMBER() built-in functions
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:57 AM Database Feature #4397: add database attrs, methods and options
Task branch 4231b has been merged to trunk as revision 11347.
Is there anything left to do in this task?
Greg Shah
11:57 AM Database Feature #3813: misc DB features part deux
Task branch 4231b has been merged to trunk as revision 11347.
> Considering that the WHERE clause work has been mo...
Greg Shah
11:56 AM Database Feature #4375 (Closed): add support for -pf <profile_filename> option for CONNECT statement
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:55 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:55 AM Base Language Feature #3854: update appserver support with PASOE features
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:54 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:54 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Bug #4355 (Closed): exception member of the CATCH block can be referenced after the block catchin...
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Feature #4354: add GET-CLASS() function support
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:53 AM Base Language Feature #4349 (Closed): add support for 4GL ENUM
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:52 AM User Interface Feature #3876: add support for "direct font control" at the widget level
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:52 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:43 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The generic (no user version) of the URL should continue to work as well. Greg Shah
11:42 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The idea is that the user would have the URL bookmarked which would map to the right user name. Then the login form ... Greg Shah
11:08 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Yes, but by doing it this way the local storage would be specific to the user instead of the mach...
Hynek Cihlar
11:05 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes, but by doing it this way the local storage would be specific to the user instead of the machine. It isn't secur... Greg Shah
11:01 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Correct.
>
> A variant of this idea: if the initial URL had a user-account component (@https:/...
Hynek Cihlar
10:57 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Correct.
A variant of this idea: if the initial URL had a user-account component (@https://<host>:<port>/gui/<os_u...
Greg Shah
10:41 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Hynek Cihlar wrote:
> Wouldn't the cookie be subject of CORS when it would be read on a different port (not mentioni...
Hynek Cihlar
10:38 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Does anyone see a better alternative?
...
Hynek Cihlar
10:34 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Crazy-lazy idea: we could identify the client using the available browser information (agent, resolution, OS, versi... Greg Shah
10:13 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Does anyone see a better alternative?
>
> Crazy-lazy idea: we could i...
Constantin Asofiei
10:12 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> Does anyone see a better alternative?
Crazy-lazy idea: we could identify the client using the ...
Hynek Cihlar
09:08 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> What I see:
> # Start an app and save a configuration. In local storage browser I see tha...
Greg Shah
04:16 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I am using these settings for the web client:... Sergey Ivanovskiy
11:51 AM User Interface Feature #4174: implement calendar control/dtpicker OCX replacement
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:50 AM User Interface Feature #4170: add drag and drop support to treeview widget
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
11:50 AM User Interface Bug #4636: Make the Theme API independent on concrete implementation classes
Task branch 4231b has been merged to trunk as revision 11347. Greg Shah
10:18 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
If so, does that same ...
Greg Shah

06/19/2020

07:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sure!
I just need to resolve this ports story for my local configuration.
Stanislav Lomany
07:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I tested also with saving "All browses, Current User". The result after cold restart was all tables changes backgroun... Sergey Ivanovskiy
07:08 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I built FWD with these changes and applied them to Hotel GUI with @deploy.prepare@. Then cleaned all localStorage and... Sergey Ivanovskiy
07:00 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
What I see:
# Start an app and save a configuration. In local storage browser I see that the configuration is saved ...
Stanislav Lomany
06:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sorry, I forgot to mention it! Please test it while saving configuration for "This Browse, Current User" (or "All bro... Stanislav Lomany
06:51 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > It seems that now the browse configuration is restored.
>
> For me configuration is ...
Sergey Ivanovskiy
06:49 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
At least the cell's background color, height and font were persisted across the server restarts. Sergey Ivanovskiy
06:49 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> It seems that now the browse configuration is restored.
For me configuration is still not loaded after server r...
Stanislav Lomany
06:43 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
#3880-141 Thank you, I know:) Stanislav Lomany
06:40 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Well, I don't like new line symbol within a key and double quoting. But I'm not sure if th...
Sergey Ivanovskiy
05:51 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Well, I don't like new line symbol within a key and double quoting. But I'm not sure if that's an issue.
So, sorry, ...
Stanislav Lomany
05:47 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes, it looks like an issue. How it can be happened? Sergey Ivanovskiy
05:42 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The first I checked that the @localStorage@ has the same key and value after the server has been restarted. I observe... Sergey Ivanovskiy
05:34 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Planning to debug what was the issue.
I think I found the bug:...
Stanislav Lomany
05:27 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
User configurations can be "for all users" and user-specific. "For all users" are saved in the directory. User-specif... Stanislav Lomany
05:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
It is not obvious for me that the issue is the serialization/deserealization from the web @localStorage@. Planning to... Sergey Ivanovskiy
05:21 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
In this case it seems that the browse configuration doesn't read after the user is logged out and it is saved on the ... Sergey Ivanovskiy
05:15 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Yes, after the server has been restarted the configuration was not retrieved but it is not because of the different... Stanislav Lomany
05:07 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Sergey, does configurations survive server restart?
Yes, after the server has been restar...
Sergey Ivanovskiy
04:35 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Regarding exception. It is suppressed in @WebClientKeyValueStorage.getChunk@:... Stanislav Lomany
04:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sergey, does configurations survive server restart? It just crossed my mind that a dynamic port is assigned every tim... Stanislav Lomany
04:28 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Also I tried to save the browse configuration with blue background color for the particular user and restore it after... Sergey Ivanovskiy
04:18 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I checked the Hotel Gui with the web client for Firefox. It seems that the enhanced browse configuration is stored. I... Sergey Ivanovskiy
02:57 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I didn't encounter this exception. Could you provide a testcase to reproduce? At the time of my changes the enhanced ... Sergey Ivanovskiy
11:57 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
An enhanced browse configuration cannot be loaded from a web storage. I have to fix it before any other issue. If any... Stanislav Lomany
05:55 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> The ChUI testing is on @devsrv01@.
After the complete conversion testing, there were no artifa...
Roger Borrello
09:33 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
The ChUI testing is on @devsrv01@. Greg Shah
09:19 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
Greg Shah wrote:
> The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDicti...
Roger Borrello
05:13 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire se...
Eric Faulhaber
04:49 PM Database Feature #4011: database/persistence layer performance improvements
The old @cumulativeDirtyProps@ was stored in @ValidationHelper@ and contained the entire set of changes at the last (... Ovidiu Maxiniuc
04:37 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, regarding 4011a/11486: @RecordBuffer.cumulativeDirtyProps@ is never modified, only instantiated and used as a... Eric Faulhaber
04:09 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > the composite tables need to be deleted manually (or is t...
Ovidiu Maxiniuc
04:05 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> the composite tables need to be deleted manually (or is the foreign key 'on cascade de...
Eric Faulhaber
03:18 PM Database Feature #4011: database/persistence layer performance improvements
There are issues in 4011a with the batch deletes:
* the composite tables need to be deleted manually (or is the fore...
Constantin Asofiei
02:17 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The only issue I have is that @boolean doFlush = !rollback || hasUniqueConstraint;@ wi...
Eric Faulhaber
02:01 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, would you please carefully review the change? It did go through some regression ...
Constantin Asofiei
01:40 PM Database Feature #4011: database/persistence layer performance improvements
Committed rev 11487, which:
* bypasses database-level unique constraint validation when the backing table has no u...
Eric Faulhaber
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> some indexes keep their @unique@ attribute. I remember that we were intentionally doing s...
Eric Faulhaber
08:05 PM Database Feature #4011: database/persistence layer performance improvements
Eric,
As I informed by email, I noticed some differences in the generated indexes for our test framework. There are ...
Ovidiu Maxiniuc
06:08 AM Database Feature #3814: more schema metadata
Status summary update (see #3814-100)
# Added @_Sequence@ table population based on the new @SEQUENCE@ support (back...
Igor Skornyakov

06/18/2020

07:34 PM Database Feature #4011: database/persistence layer performance improvements
As part of cleaning up the branch, we should get rid of these ANTLR warnings:... Eric Faulhaber
01:30 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> This is a different issue than that which is addressed by the use of the @ParameterIndices@ ...
Constantin Asofiei
01:04 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > For a WHERE clause which has subscripted fields like @tt1...
Eric Faulhaber
09:25 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @...
Constantin Asofiei
08:34 AM Database Feature #4011: database/persistence layer performance improvements
For a WHERE clause which has subscripted fields like @tt1.f1[?]@, I need to inject the @tt1__10.list__index = ?@ at t... Constantin Asofiei
07:08 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDictionaryObject("frame_e... Greg Shah
04:52 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Ovidiu Maxiniuc wrote:
> The choice to use a @null@ context is due the performance. This might not be the most ele...
Eric Faulhaber
03:55 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Eric Faulhaber wrote:
> I'm reading through the changes, and this is not a full review yet, but I have some general ...
Ovidiu Maxiniuc
02:28 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
I'm reading through the changes, and this is not a full review yet, but I have some general questions about the 4011a... Eric Faulhaber
02:20 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Some new requirements have arisen for the dirty share feature set. Although we would like to eliminate this feature a... Eric Faulhaber
01:54 PM Database Feature #4690: re-integrate dirty share logic into new persistence implementation
Opening a separate issue for this, as it is a substantial topic on its own...
4011a_dirty is the branch in use for...
Eric Faulhaber
01:53 PM Database Feature #4690 (WIP): re-integrate dirty share logic into new persistence implementation
Eric Faulhaber
11:23 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
In Web client the @gui/driver/web/GuiWebDriver.java@ uses specific @X@ scaling factor for every font in use. This sho... Eugenie Lyzenko
10:32 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Put this under @/server/default/@ or @/server/<server_name>/@:... Stanislav Lomany
10:29 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
What is the "simple" (single boolean flag) directory configuration for enabling enhanced mode? Greg Shah
09:06 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> The scale factor should be different for Web as well as for Swing client. So why does the font chooser always uses ... Stanislav Lomany
07:09 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > The big concern here is that the web gives different results from Swing. Based on your ...
Hynek Cihlar
09:01 AM User Interface Feature #4164: implement misc UI features (frame options, misc attributes)
As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
The original code:...
Greg Shah
07:46 AM Base Language Feature #4384: Builtin OO Implementation
> Actually the offending one was org.aspectj.org.eclipse.jdt.internal.formatter.linewrap, if we need to add some extr... Greg Shah
07:29 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I've merged all the changes from 4384c (revisions 11569 through 11579) into 4231b revision 11606....
Marian Edu
06:39 AM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
> To modify the Possenet, we'd be creating an offshoot that we would need to document. I believe it's best to utilize... Greg Shah

06/17/2020

07:23 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> The big concern here is that the web gives different results from Swing. Based on your notes, I still don't unders... Stanislav Lomany
04:10 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
The font chooser case is not very important. If that was not working, it would be less of a concern.
The big conc...
Greg Shah
04:02 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> If scaling only happens for Swing, then why are the metrics for web the same (and wrong)?
It's not quite that wa...
Stanislav Lomany
06:40 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah wrote:
> Yes, but in FWD we have no such thing. I was not suggesting that we implement a "fake" procedure...
Roger Borrello
06:00 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Yes, but in FWD we have no such thing. I was not suggesting that we implement a "fake" procedure library result.
...
Greg Shah
05:50 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
More info related to the 4GL's behavior. It indicates we can proceed.
I was able to position a procedure library i...
Roger Borrello
05:34 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah wrote:
> For a @.r@ file that is part of the application, there is no procedure library involved. For a p...
Roger Borrello
04:12 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
For a @.r@ file that is part of the application, there is no procedure library involved. For a procedure that is a m... Greg Shah
04:04 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
The code in @adm2/containr.p@ does not specifically perform a @LIBRARY@ call, prior to the code snippet that we are a... Roger Borrello
02:12 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> OK, please commit the change to 4231b.
Committed revision 11609.
Igor Skornyakov
02:05 PM Database Feature #3814: more schema metadata
OK, please commit the change to 4231b. Greg Shah
01:58 PM Database Feature #3814: more schema metadata
Some additional fixes were made to run hotel apps w/o @p2j.cf.xml@. See attachment. Igor Skornyakov
12:33 PM Database Feature #3814: more schema metadata
Igor Skornyakov wrote:
> Greg Shah wrote:
> > The change looks good. Please test it with Hotel GUI and Hotel ChUI....
Greg Shah
12:32 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> The change looks good. Please test it with Hotel GUI and Hotel ChUI.
Both apps started OK. Pl...
Igor Skornyakov
12:11 PM Database Feature #3814: more schema metadata
The change looks good. Please test it with Hotel GUI and Hotel ChUI. Greg Shah
12:04 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? ...
Igor Skornyakov
11:55 AM Database Feature #3814: more schema metadata
Why did you remove the @throw@ in the @catch()@ block of @Configuration.createConfiguration()@? This means that the ... Greg Shah
11:48 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Code Review cfg.diff
>
> Please remove the new imports in @Configuration@ and also remove the ...
Igor Skornyakov
11:41 AM Database Feature #3814: more schema metadata
Code Review cfg.diff
Please remove the new imports in @Configuration@ and also remove the change for the @catch()@...
Greg Shah
11:11 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Code Review cfg.diff
>
> 1. At this time, it is intentional that we do not use logging in @Con...
Igor Skornyakov
10:17 AM Database Feature #3814: more schema metadata
Code Review cfg.diff
1. At this time, it is intentional that we do not use logging in @Configuration@. It is used...
Greg Shah
09:02 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Please post the change here in patch format so I can review it. If OK, you will check it in to 4...
Igor Skornyakov
08:06 AM Database Feature #3814: more schema metadata
Please post the change here in patch format so I can review it. If OK, you will check it in to 4231b since this is m... Greg Shah
07:54 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> A safe default configuration (which has nothing enabled) should be present if the file is not ava...
Igor Skornyakov
07:02 AM Database Feature #3814: more schema metadata
A safe default configuration (which has nothing enabled) should be present if the file is not available. No abends. Greg Shah
06:57 AM Database Feature #3814: more schema metadata
I've fixed the situation when there is no <metadata> section on the @p2j.cfg.xml@. However it seems that the applicat... Igor Skornyakov
05:55 AM Database Feature #3814: more schema metadata
Please make both cases safe. Greg Shah
02:55 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a ...
Igor Skornyakov
11:30 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
I have an update that I'd like reviewed. It correctly converted the testcase, as well as the customer procedure. Are ... Roger Borrello

06/16/2020

07:49 PM Base Language Feature #4162 (WIP): enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Ready for test. Roger Borrello
07:46 PM User Interface Bug #4631: Widget scoped to wrong frame on hide
Should the @descent-rules@ both add the scope at the appropriate time, and include the rules that had been in place i... Roger Borrello
07:31 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Are the metrics calculated before the scaling? The thing I don't understand is that the Swing browse draws everythin... Greg Shah
06:19 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Do we have accurate metrics that differ between Swing and web?
The metrics are the same, actual text size diff...
Stanislav Lomany
10:23 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Do you have an idea what we're are doing about Graphics2D or something else that could cause this difference? Web v... Greg Shah
05:46 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Regarding the font size: I found that actually may be it's not the case that a web font is larger, it's the case that... Stanislav Lomany
07:00 PM Database Feature #3814: more schema metadata
I'm using the ChUI regression test suite. I found that with 4231b, it is now required to have a @cfg/p2j.cfg.xml@ bu... Greg Shah
04:58 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > A variation of #4011-549 with the validation:
> > [...]
> >...
Constantin Asofiei
04:42 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A variation of #4011-549 with the validation:
> [...]
>
> The @CAN-FIND@ sees this r...
Eric Faulhaber
11:11 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c...
Constantin Asofiei
10:52 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I've been considering divorcing the cache from the session object to get more advantage from...
Constantin Asofiei
08:05 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've seen cases where we have a select like @select tt1.*...
Eric Faulhaber
06:54 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a s...
Constantin Asofiei
06:28 AM Database Feature #4011: database/persistence layer performance improvements
I've seen cases where we have a select like @select tt1.*, tt2.recid@ where @tt2@ is a standalone table or a composit... Constantin Asofiei
06:07 AM Database Feature #4011: database/persistence layer performance improvements
I've committed revision 11481, which minimizes the number of database savepoints being set for application sub-transa... Eric Faulhaber
12:43 AM Database Feature #4011: database/persistence layer performance improvements
Greg Shah wrote:
> > issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to c...
Eric Faulhaber
11:11 PM Database Feature #4011: database/persistence layer performance improvements
> issue in AnnotatedAst.iterator(), when walking from an AST with a single child. Need Greg to check if I'm missing ... Greg Shah
09:42 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. ...
Eric Faulhaber
04:43 PM Base Language Bug #4682: modify FILE-INFO processing to honor searches for 4GL programs
There is a common pattern in 4GL code that is used for "security". The idea is that the code will use some form of f... Greg Shah
04:34 PM Base Language Bug #4682 (Closed): modify FILE-INFO processing to honor searches for 4GL programs
Greg Shah
04:36 PM Database Feature #4681: prepared statement caching/pooling
I think we can simplify this idea a bit. I don't see the value in making a static cache. A @PreparedStatement@ instan... Eric Faulhaber
01:39 PM Database Feature #4681: prepared statement caching/pooling
My concern is related to multiple session close (they have a short life), which will invalidate the cached statements... Ovidiu Maxiniuc
12:58 PM Database Feature #4681: prepared statement caching/pooling
This issue is to discuss the implementation of @PreparedStatement@ caching/pooling as a potential performance optimiz... Eric Faulhaber
12:56 PM Database Feature #4681 (WIP): prepared statement caching/pooling
Eric Faulhaber

06/15/2020

07:23 PM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11480 refactors SortCriterion to allow indexed properties in the sort clause. FQL2SQL will take care of cr... Constantin Asofiei
07:11 PM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11479 adds the @AnnotatedAst.iterator()@ fix (#4011-574) and refactors rowStructure to allow for self-join. Constantin Asofiei
09:49 AM Database Feature #4011: database/persistence layer performance improvements
A variation of #4011-549 with the validation:... Constantin Asofiei
05:51 AM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11475 fixes ChangeSet.ensureCapacity. Constantin Asofiei
01:03 PM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Roger Borrello wrote:
> Is #4391 basically additional parsing in the same manner as this task?
Yes.
Greg Shah
10:54 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Is #4391 basically additional parsing in the same manner as this task? Roger Borrello
10:52 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Changes to support @-ininame@ are checked into *4231b-11608* (@LegacyCLI.java@). Testcases indicated there should be ... Roger Borrello
09:53 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Roger Borrello wrote:
> Ovidiu, you had made changes to @ClientCore@ in 2014 to emulate the @-ininame@ command-line ...
Roger Borrello
09:53 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
Ovidiu, you had made changes to @ClientCore@ in 2014 to emulate the @-ininame@ command-line parameter. Is there any c... Roger Borrello
08:12 AM User Interface Bug #4631: Widget scoped to wrong frame on hide
#4208-447 starts discussion of this same bug. This should be addressed before merging 4231b to trunk.
Constantin i...
Roger Borrello
09:06 PM Base Language Feature #4384: Builtin OO Implementation
I've merged all the changes from 4384c (revisions 11569 through 11579) into 4231b revision 11606.
I've created a n...
Greg Shah

06/14/2020

11:25 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
3880a has been merged into 4231b as rev 11604. 3880a has been archived. Stanislav Lomany
10:25 AM Database Feature #4011: database/persistence layer performance improvements
> BTW, in FWD (both 4011 and trunk) only the RAQ will consult the dirty database for possible leaking record. The 4GL... Greg Shah

06/13/2020

05:53 PM Database Feature #4011: database/persistence layer performance improvements
> There's nowhere to descend, nor another sibling. When iter.hasNext() is called after the BOOL_TRUE was processed, i... Greg Shah
03:17 PM User Interface Bug #4671: Widget drag doesn't work in web
One can drag a widget once, but not for the second time.
Reproduction: drag the button, then try to drag it again.
Stanislav Lomany
03:08 PM User Interface Bug #4671 (New): Widget drag doesn't work in web
Stanislav Lomany
02:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Fix for web issues (web column/row resize) committed into 4231b as rev 11603.
BTW there's one more minor web issue...
Stanislav Lomany

06/12/2020

07:03 PM Database Feature #4011: database/persistence layer performance improvements
Yes, if we can evaluate static sub-expressions during conversion, we roll them up to their result and replace the sub... Eric Faulhaber
07:00 PM Database Feature #4011: database/persistence layer performance improvements
Is it possible that the WHERE node was dropped in this case? Ovidiu Maxiniuc
06:57 PM Database Feature #4011: database/persistence layer performance improvements
AFAIK, we didn't change this in 4011a. I wonder why we are hitting this now. Eric Faulhaber
06:42 PM Database Feature #4011: database/persistence layer performance improvements
There's a bug in @AnnotatedAst.iterator@ when trying to iterate starting from the @BOOL_TRUE@ child (of the @WHERE@ c... Constantin Asofiei
06:20 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The not closed objects are most likely the reason for the me...
Constantin Asofiei
05:37 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready.
See...
Constantin Asofiei
05:25 PM Database Feature #4011: database/persistence layer performance improvements
Constantin, I am blocked by this as well. Please commit the fix as soon as it is ready. Eric Faulhaber
05:17 PM Database Feature #4011: database/persistence layer performance improvements
This was inspired by what I saw Hibernate was generating. The most signifiant 32 bit came naturally and will match th... Ovidiu Maxiniuc
05:02 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Or better yet, why use a hashcode for the FK? Just as a convention? This name needs to...
Eric Faulhaber
05:01 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There's something wrong in TempTableHelper when the constraint name is computed:
> [......
Constantin Asofiei
04:45 PM Database Feature #4011: database/persistence layer performance improvements
There's something wrong in TempTableHelper when the constraint name is computed:... Constantin Asofiei
03:57 PM Database Feature #4011: database/persistence layer performance improvements
OK, I think this is what Hibernate did as well. We may come back to @PreparedStatement@ caching as a potential optimi... Eric Faulhaber
03:49 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Ovidiu Maxiniuc
03:47 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I think we know when we are done with the statement in all cases, but do we cache @PreparedS...
Constantin Asofiei
03:43 PM Database Feature #4011: database/persistence layer performance improvements
I think we know when we are done with the statement in all cases, but do we cache @PreparedStatement@ instances to pr... Eric Faulhaber
03:42 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The not closed objects are most likely the reason for the memory issues. I tried to close s...
Constantin Asofiei
03:20 PM Database Feature #4011: database/persistence layer performance improvements
The not closed objects are most likely the reason for the memory issues. I tried to close some of them but it was rea... Ovidiu Maxiniuc
03:18 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> How were we handling cleanup of the Hibernate query resources?
I think Hibernate was taking...
Constantin Asofiei
03:09 PM Database Feature #4011: database/persistence layer performance improvements
@AbstractQuery@ has a @cleanup@ method, however, the use of @SQLQuery@ and even @Query@ is somewhat internal/hidden w... Eric Faulhaber
03:04 PM Database Feature #4011: database/persistence layer performance improvements
Another issue which I don't understand: the @SQLQuery@'s JDBC statement and ResultSet is never closed. Why? Who shou... Constantin Asofiei
03:02 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I've moved to another test as the current one is blocked ...
Constantin Asofiei
09:05 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> I've moved to another test as the current one is blocked with the flush/mandatory issue....
Constantin Asofiei
08:25 AM Database Feature #4011: database/persistence layer performance improvements
I've moved to another test as the current one is blocked with the flush/mandatory issue. Now I've reached an extent ... Constantin Asofiei
08:13 PM Database Feature #4011: database/persistence layer performance improvements
Not exactly. I will add it, thanks. Eric Faulhaber
11:21 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
> The comments in @LegacyCLI.getStartupParameters@ indicate "Returns a character string containing a _comma-separated... Greg Shah
10:55 AM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
The comments in @LegacyCLI.getStartupParameters@ indicate "Returns a character string containing a _comma-separated_ ... Roger Borrello
11:15 AM Conversion Tools Feature #1735: leverage lambda expressions (Java 8 "closures") to reduce code bloat
We sometimes see converted code which causes a fatal javac problem "error: too many parameters". This can happen wit... Greg Shah
03:29 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Is 4384c in a good place to merge the changes into 4231b? If it is OK, tomorrow I want to get th...
Marian Edu
08:40 PM Base Language Feature #4384: Builtin OO Implementation
Is 4384c in a good place to merge the changes into 4231b? If it is OK, tomorrow I want to get the merge done and the... Greg Shah
08:30 PM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Attached the patch for skeleton changes, in Eclipse and Bazaar format... this might also include...
Greg Shah

06/11/2020

07:57 PM Database Feature #4011: database/persistence layer performance improvements
Eric, do you have this case in your current flush/validation work?... Constantin Asofiei
06:37 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you e...
Eric Faulhaber
06:06 PM Database Feature #4011: database/persistence layer performance improvements
Eric, the NO-UNDO issue is related to passing the temp-table as a parameter, where you end up with two records like ... Constantin Asofiei
04:56 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE ...
Constantin Asofiei
03:39 PM Database Feature #4011: database/persistence layer performance improvements
A test related to NO-UNDO temp-tables (not related to STOP, replace it with UNDO, LEAVE and there is the same behavio... Constantin Asofiei
03:22 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, what's the difference between @FqlType.DECIMAL@ and @FqlType.DOUBLE@? How are th...
Ovidiu Maxiniuc
03:07 PM Database Feature #4011: database/persistence layer performance improvements
11467 contains the ScrollingResults fix, rollback of SqlQuery RSMD usage and another fix in FqlType. Constantin Asofiei
03:06 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Should I call @Persistence$Context.useSession@ for @Scrol...
Eric Faulhaber
02:58 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Should I call @Persistence$Context.useSession@ for @ScrollingResults@, too? I see that w...
Constantin Asofiei
02:48 PM Database Feature #4011: database/persistence layer performance improvements
I've got an infinite loop because this code:... Constantin Asofiei
12:28 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
>
> > That code already has a call for RSMD, @int columnCount =...
Constantin Asofiei
12:26 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> That code already has a call for RSMD, @int columnCount = resultSet.getMetaData().getC...
Eric Faulhaber
12:14 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > The foreign table is mapped by @MetaFile.class@ and by defau...
Constantin Asofiei
12:03 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, we have biased as much as we can in this implementation toward speed, so we are ...
Constantin Asofiei
11:45 AM Database Feature #4011: database/persistence layer performance improvements
Constantin, we have biased as much as we can in this implementation toward speed, so we are avoiding things like @Res... Eric Faulhaber
10:33 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The problem is the previous code assumed the SELECT was always retrieving full records. ...
Ovidiu Maxiniuc
10:24 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > 4011a rev 11465 contains my FQL fixes plus misc. Please rev...
Constantin Asofiei
09:38 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 4011a rev 11465 contains my FQL fixes plus misc. Please review.
I have only a questi...
Ovidiu Maxiniuc
03:21 PM Base Language Feature #4162: enhance existing SESSION:STARTUP-PARAMETERS support to honor -ininame value
See @SessionUtils.getStartupParameters()@ and @LegacyCLI@.
We should add a specific capability for directory confi...
Greg Shah
03:07 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Why is the row height static? It should be calculated based on whatever is being used at...
Greg Shah
03:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no s... Greg Shah
03:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Why is the row height static? It should be calculated based on whatever is being used at the time.
Currently, t...
Stanislav Lomany
03:04 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Code Review Task Branch 3880a Revisions 11347 through 11353
1. I really like the refactoring of the TC dialog proc...
Greg Shah
02:32 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no scr... Stanislav Lomany
01:38 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Can you see any case which this does not cover?
>
> If there is a vertical scrollbar ...
Greg Shah
01:35 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Can you see any case which this does not cover?
If there is a vertical scrollbar and NO horizontal scrollbar, we...
Stanislav Lomany
06:41 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
We will use the bottom right corner of the browse. In enhanced mode (simple boolean flag), we will always provide th... Greg Shah
06:29 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
!example.png! Stanislav Lomany
06:25 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Please show an example. Greg Shah
06:24 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Yes. Stanislav Lomany
06:21 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Is it possible to have a horizontal scrollbar without a vertical scrollbar? Greg Shah
05:58 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> * Is there always a vertical scrollbar?
It can be turned off.
> * Aren't there cases where there are row marker...
Stanislav Lomany
08:02 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
* Is there always a vertical scrollbar?
* Aren't there cases where there are row markers?
* Please show the same c...
Greg Shah
01:15 PM Base Language Bug #4669 (Test): Conversion error for output stream-handle - protected property.
Marian Edu
08:25 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Constantin Asofiei wrote:
> To determine how OE interprets the SOAP envelope, when resolving the arguments, we need ...
Marian Edu

06/10/2020

06:23 PM Database Feature #4011: database/persistence layer performance improvements
4011a rev 11465 contains my FQL fixes plus misc. Please review. Constantin Asofiei
06:17 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> The foreign table is mapped by @MetaFile.class@ and by default the 'foreign' field is also ...
Constantin Asofiei
01:53 PM Database Feature #4011: database/persistence layer performance improvements
Lots of regression after changing it... so no good. Constantin Asofiei
01:49 PM Database Feature #4011: database/persistence layer performance improvements
There is a problem at the fql.g parser:... Constantin Asofiei
01:43 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Found a broken feature I forgot about in 4011: sequences, see #3814-109.
> We need to add ...
Ovidiu Maxiniuc
12:05 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Replacing Record with Persistable fixes the above.
> I am n...
Constantin Asofiei
11:59 AM Database Feature #4011: database/persistence layer performance improvements
Constantin,
After running conversion with a newer metadata definition I have this:...
Ovidiu Maxiniuc
11:16 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu, I have a problem with the relation generated between the Field and File meta tab...
Ovidiu Maxiniuc
10:48 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Replacing Record with Persistable fixes the above.
I am not sure is not correct. Which ...
Ovidiu Maxiniuc
09:17 AM Database Feature #4011: database/persistence layer performance improvements
Replacing Record with Persistable fixes the above. Constantin Asofiei
09:02 AM Database Feature #4011: database/persistence layer performance improvements
I've fixed that manually (BTW, @name="id"@ should be @name="recid"@, depending on what you configured as the PK in p2... Constantin Asofiei
08:51 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I have a problem with the relation generated between the Field and File meta tables. In DMO index, I have th... Constantin Asofiei
08:37 AM Database Feature #4011: database/persistence layer performance improvements
11463 fixes the FqlType issue in #4011-517. But I think we need complete support for FqlType enum. Constantin Asofiei
07:53 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, I need a mapping between FQLType enum values and java.sql.Types. Can you provide a complete list? Constantin Asofiei
06:05 AM Database Feature #4011: database/persistence layer performance improvements
Rev 11462 fixes @TB.readAllRows@. It also has some validation, flush, rollback fixes that are work in process. They d... Eric Faulhaber
05:44 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Please post examples of the possible states that we can see for the the browse (with different options active).
!b...
Stanislav Lomany
05:24 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Why is the row height static? It should be calculated based on whatever is being used at the time. I guess this mea... Greg Shah
05:20 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
User changes font in web version, we set row height according to web font metrics, everything is looking nice. If the... Stanislav Lomany
05:14 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > I suppose that means you must determine what the minimum safe row height will be for tha...
Greg Shah
04:53 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> I suppose that means you must determine what the minimum safe row height will be for that font and implement it.
...
Stanislav Lomany
04:46 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Are you talking about item 3.2 from #3880-4?
>
> Yes.
This is a user override, so ...
Greg Shah
04:38 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Are you talking about item 3.2 from #3880-4?
Yes.
Stanislav Lomany
04:21 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
>> The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of th... Greg Shah
03:33 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Your found difference is especially large. Normally we don't see a difference that big. The use of multiple W cha... Stanislav Lomany
03:29 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of the... Stanislav Lomany
03:23 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
There is no way to get exactly the same results as the 4GL, even with the same exact fonts being used. We employ a r... Greg Shah
02:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Guys, all (most?) of the fonts look bigger in a browser compared to a standalone app. The lager the font, the bigger ... Stanislav Lomany
03:29 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Some thoughts:
> # @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverable...
Hynek Cihlar
05:33 PM Database Feature #4155 (WIP): remove conversion dependency on metadata .df file
Our ultimate objective with schema metadata is to eliminate the conversion of these DMOs and instead rely upon metada... Greg Shah
10:21 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) ...
Igor Skornyakov
10:19 AM Database Feature #3814: more schema metadata
As you check in updates for this task, the @rules/gaps/database.rules@ (@addMetaschema@ section) needs to be updated ... Greg Shah
08:10 AM Base Language Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> > * @ObjectOps.registerClass@ - now the method is a no-op, the @registerClass(clsName, cls);@ cal...
Marian Edu

06/09/2020

07:13 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> There is this code in @TemporaryBuffer.readAllRows@:
> [...]
>
> I would expect @res...
Constantin Asofiei
07:01 PM Database Feature #4011: database/persistence layer performance improvements
There is this code in @TemporaryBuffer.readAllRows@:... Constantin Asofiei
03:32 PM Database Feature #4011: database/persistence layer performance improvements
Actually, the code above will not work for PostgreSQL as the @getComputedColumnFormula@ will return @null@. It looks ... Ovidiu Maxiniuc
03:19 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > That is interesting. It looks like I added a regression when...
Ovidiu Maxiniuc
03:14 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> That is interesting. It looks like I added a regression when constructing validation messag...
Constantin Asofiei
03:12 PM Database Feature #4011: database/persistence layer performance improvements
That is interesting. It looks like I added a regression when constructing validation message in my recent commit. Ple... Ovidiu Maxiniuc
02:59 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu, one more - I don't understand where the "__i?" is coming from.... Constantin Asofiei
02:44 PM Database Feature #4011: database/persistence layer performance improvements
If the query already has fetched the full records, we already would have used the session cache to gain this optimiza... Eric Faulhaber
02:37 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Constantin,
> I think the change you refer to was mine. The idea was to fetch the exact am...
Constantin Asofiei
02:36 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> This part in @metaschema.xml@ is wrong:
> [...]
> We need to use the primary key as s...
Ovidiu Maxiniuc
02:30 PM Database Feature #4011: database/persistence layer performance improvements
Constantin,
I think the change you refer to in #4011-504 was mine. The idea was to fetch the exact amount of informa...
Ovidiu Maxiniuc
02:21 PM Database Feature #4011: database/persistence layer performance improvements
This part in @metaschema.xml@ is wrong:... Constantin Asofiei
01:31 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, what part is wrong here? The @Presorter$SortedResults@ which expects full records,...
Constantin Asofiei
01:12 PM Database Feature #4011: database/persistence layer performance improvements
Found a broken feature I forgot about in 4011: sequences, see #3814-109.
We need to add back initialization support ...
Ovidiu Maxiniuc
10:02 AM Database Feature #4011: database/persistence layer performance improvements
If you enable enhanced browse, and click the 'checkin' column in the Guests grid, you get a @ClassCastException@:
<p...
Constantin Asofiei
09:46 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Attached are my changes in process for the rollback fix. It is not working yet, but I am pos...
Constantin Asofiei
08:22 AM Database Feature #4011: database/persistence layer performance improvements
Attached are my changes in process for the rollback fix. It is not working yet, but I am posting because I need to ta... Eric Faulhaber
07:06 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > The reason I ask is that I noticed in the debugger that the...
Eric Faulhaber
07:01 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I guess all the changes for @LazyUndoable@ are just an optimization, but the core idea is st...
Constantin Asofiei
06:55 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Now my problem is that @LightweightUndoable@ is nothing like I remember it. I guess all th...
Eric Faulhaber
06:46 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> OK, so the record doesn't need to remain in the database, as the flush is rolledback, ...
Eric Faulhaber
06:38 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conc...
Constantin Asofiei
06:32 AM Database Feature #4011: database/persistence layer performance improvements
I don't understand this patch. I mean, I get the logic, but it doesn't look right to me conceptually. The point of ma... Eric Faulhaber
06:14 AM Database Feature #4011: database/persistence layer performance improvements
Eric, attached patch fixes this testcases:... Constantin Asofiei
05:47 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Going back to this: I've tried saving the record in the database, in @ChangeSet.rollba...
Eric Faulhaber
04:37 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Some thoughts:
# @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverableWidget@ on the JS side and do...
Stanislav Lomany
02:33 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> My worry here is that you are creating new things that will be hard to merge with 4011a. We plan...
Igor Skornyakov
02:16 PM Database Feature #3814: more schema metadata
My worry here is that you are creating new things that will be hard to merge with 4011a. We plan to do that merge ve... Greg Shah
01:29 PM Database Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
> Yes, the @DMOIndex@ c...
Igor Skornyakov
01:07 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
Yes, the @DMOIndex@ class is already gone in 4011a....
Ovidiu Maxiniuc
12:24 PM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Ovidiu: Doesn't @DMOIndex@ go away in 4011a?
I already use @DMOIndex@ in the @MetadataManager@...
Igor Skornyakov
12:12 PM Database Feature #3814: more schema metadata
Ovidiu: Doesn't @DMOIndex@ go away in 4011a? Greg Shah
12:04 PM Database Feature #3814: more schema metadata
Ovidiu Maxiniuc wrote:
> Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. Aft...
Igor Skornyakov
11:23 AM Database Feature #3814: more schema metadata
Of course, please see the last lines in @ddl/schema_table_<db-name>_<sql-dialect>.sql@. After a successuful conversio... Ovidiu Maxiniuc
04:27 AM Database Feature #3814: more schema metadata
Do we generate any artifacts for @SEQUENCE@? I cannot find any. The corresponding AST exists. Please advise.
Thank you.
Igor Skornyakov

06/08/2020

02:12 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Eric Faulhaber wrote:
> > > Constantin, at this level in...
Constantin Asofiei
02:00 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I didn't think so. We should be fetching it from the database...
Constantin Asofiei
01:54 PM Database Feature #4011: database/persistence layer performance improvements
Constantin,
in FWD runtime the primary key name is read from @persistence/primary-key-name@ and stored globally in @...
Ovidiu Maxiniuc
01:36 PM Database Feature #4011: database/persistence layer performance improvements
Eric, in #4011-303, you note that in @p2j.cfg.xml@ you used this:... Constantin Asofiei
11:13 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Constantin, at this level in the code, we are not dealing wit...
Constantin Asofiei
11:04 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, at this level in the code, we are not dealing with BDT instances.
You are corr...
Constantin Asofiei
11:00 AM Database Feature #4011: database/persistence layer performance improvements
Constantin, at this level in the code, we are not dealing with BDT instances. These are the lower level Java types wh... Eric Faulhaber
10:51 AM Database Feature #4011: database/persistence layer performance improvements
This fix solves all deadlocks related to locking (even those which exist in trunk), in @BaseRecord.setDatum@:... Constantin Asofiei
10:17 AM Database Feature #4011: database/persistence layer performance improvements
There is a deadlock when updating a Rate or a Guest by multiple clients, but this is an application logic problem.
...
Constantin Asofiei
08:57 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I didn't think so. We should be fetching it from the database on next access.
The problem ...
Constantin Asofiei
08:46 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:...
Eric Faulhaber
08:41 AM Database Feature #4011: database/persistence layer performance improvements
The abend in Reservations/Check-in/Delete Guest/Cancel Check-in is related to this test:... Constantin Asofiei
07:52 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to r...
Constantin Asofiei
07:04 AM Database Feature #4011: database/persistence layer performance improvements
Rev 11455 fixes an NPE and some validation logic. Eric Faulhaber
06:56 AM Database Feature #4011: database/persistence layer performance improvements
Constantin, please commit your change to always use @NopDirtyShareContext@, with a TODO to re-enable it when the re-i... Eric Faulhaber
06:48 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> So, the dirty share database should be used only for explicitly-configured tables/data...
Eric Faulhaber
06:04 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now g...
Constantin Asofiei
05:57 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> And another issue with the dirty database - previously there were @Reversible@ instances...
Constantin Asofiei
05:51 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please coordinate with Ovidiu on this; he is actively making changes in this area. The dirty...
Constantin Asofiei
05:46 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > BTW, also found these in the server log from the same work fl...
Eric Faulhaber
05:20 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> BTW, also found these in the server log from the same work flow:
>
> [...]
The root caus...
Constantin Asofiei
05:04 AM Database Feature #4011: database/persistence layer performance improvements
OK, I'll check with H2, too.
BTW, I still see the NPE for the 'delete guest' and 'Cancel', in the Reservations, C...
Constantin Asofiei
05:00 AM Database Feature #4011: database/persistence layer performance improvements
BTW, also found these in the server log from the same work flow:... Eric Faulhaber
04:59 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> I am using the default H2 database in my testing. I'll try with PostgreSQL.
Indeed, the...
Eric Faulhaber
04:42 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> 11454 does not compile for me:
> [...]
>
> I've bypassed this and I don't get your e...
Eric Faulhaber
04:35 AM Database Feature #4011: database/persistence layer performance improvements
11454 does not compile for me:... Constantin Asofiei
04:24 AM Database Feature #4011: database/persistence layer performance improvements
After another full @ant deploy.all@, this time with the data from Hotel GUI rev 212, I now get the following error wi... Eric Faulhaber
04:00 AM Database Feature #4011: database/persistence layer performance improvements
On a completely fresh run of Hotel GUI, first thing after running @ant deploy.all@ and server startup, I get some err... Eric Faulhaber
11:25 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin Asofiei wrote:
> > For this what I'm missing are tests with extent arguments (input/...
Constantin Asofiei
11:18 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> For this what I'm missing are tests with extent arguments (input/output) and tables with...
Marian Edu
07:02 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
For this what I'm missing are tests with extent arguments (input/output) and tables with extent fields. Constantin Asofiei
08:50 AM Database Feature #3814: more schema metadata
> Regarding the undocumented fields of the _Field table, I think that it can be sufficient to set them to a "typical"... Greg Shah
08:30 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> > This means that the _File._ianum is almost useless and has not any meaningful counterpart in FW...
Igor Skornyakov
08:01 AM Database Feature #3814: more schema metadata
> This means that the _File._ianum is almost useless and has not any meaningful counterpart in FWD. I understand the ... Greg Shah
07:38 AM Database Feature #3813: misc DB features part deux
Considering that the WHERE clause work has been moved to #4613, is there any reason to keep this task open? Greg Shah
07:06 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
To determine how OE interprets the SOAP envelope, when resolving the arguments, we need at least:
* all arguments as...
Constantin Asofiei

06/07/2020

11:50 AM Base Language Feature #3812: additions to SESSION system-handle
Greg, the only issues are:
* @session:current-request-info@ and @current-response-info@ - documentation states:
>Wh...
Constantin Asofiei
09:55 AM Base Language Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Greg, I meant the @public static void registerClass(Class<? extends _BaseObject_> cls, b...
Marian Edu
09:26 AM Base Language Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> > * @ObjectOps.registerClass@ - now the method is a no-op, the @registerClass(clsName, cls);@ cal...
Marian Edu
05:26 AM Base Language Feature #4349: add support for 4GL ENUM
Greg, I meant the @public static void registerClass(Class<? extends _BaseObject_> cls, boolean hierarchy)@. I can't ... Constantin Asofiei

06/06/2020

12:15 PM User Interface Bug #4135: high dpi screens display in low dpi
From the customer:
> The file HotelDemoDPR2.png is looking good. Text looks sharp.
>
> As mentioned earlier in ...
Greg Shah
12:10 PM User Interface Feature #4661: add support for missing formats to image loading
The 4GL uses Windows OS features for its image support. This is the known list (at this time) of supported 4GL image... Greg Shah
11:57 AM User Interface Feature #4661 (Closed): add support for missing formats to image loading
Greg Shah
10:19 AM Base Language Feature #3812: additions to SESSION system-handle
> I'll document them once I have them ready to be committed to 4231b.
Can you summarize the status/restrictions?
Greg Shah
08:08 AM Base Language Feature #4349: add support for 4GL ENUM
> * @ObjectOps.registerClass@ - now the method is a no-op, the @registerClass(clsName, cls);@ call is not longer ther... Greg Shah

06/05/2020

07:12 PM Database Feature #4011: database/persistence layer performance improvements
Unfortunately, I don't have the dirty share fully done yet.
To let my brain cool down I returned and fixed the uniqu...
Ovidiu Maxiniuc
05:57 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Virtual desktop and embedded mode get through this flow fine,...
Eric Faulhaber
05:42 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > The only issue I'm aware in Hotel GUI is the NPE related to C...
Constantin Asofiei
05:41 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Virtual desktop and embedded mode get through this flow fine, so it may be a client problem ...
Constantin Asofiei
05:36 PM Database Feature #4011: database/persistence layer performance improvements
Another issue I hit was in Swing only:
* log in
* from "Available Rooms", click "Check-In..."
* delete guest
* ...
Eric Faulhaber
05:32 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, afte...
Eric Faulhaber
05:15 PM Database Feature #4011: database/persistence layer performance improvements
The only issue I'm aware in Hotel GUI is the NPE related to Cancel the Reservation, after deleting the guest. Constantin Asofiei
05:13 PM Database Feature #4011: database/persistence layer performance improvements
This code in @RecordBuffer.delete@ doesn't set the @token@:... Constantin Asofiei
04:56 PM Database Feature #4011: database/persistence layer performance improvements
The deadlock described in #4011-385 can be duplicated like this in 11452:
* delete a room
* close and start another...
Constantin Asofiei
02:56 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> My changes to fix the #4011-385, the @deleteAll@ problem because there was no notificati...
Constantin Asofiei
05:35 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion...
Constantin Asofiei
05:17 AM Database Feature #4011: database/persistence layer performance improvements
Ok, that's what I'm doing. I wonder why I get different behavior. I'll run a full conversion from scratch and try it ... Eric Faulhaber
05:07 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Eric, the issue in #4011-412 is not solved by your changes.
...
Constantin Asofiei
04:57 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is not solved by your changes.
Constantin, I don't get a...
Eric Faulhaber
04:40 PM Base Language Feature #4349: add support for 4GL ENUM
Review for 4231b rev 11585:
* @ObjectOps.registerClass@ - now the method is a no-op, the @registerClass(clsName, cls...
Constantin Asofiei
02:14 PM Base Language Feature #4349 (Review): add support for 4GL ENUM
4231b rev 11585 completes the enum implementation. With the fixes in this revision, *all* of the @oo/enums/*.p@ test... Greg Shah
04:38 PM Database Feature #3814: more schema metadata
# restored @_database-feature@ support previously implemented by Ovidiu
# added the following @_file@ fields:...
Igor Skornyakov
11:34 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Thanks, I tested @browse-simple.p@ with 4231b and Firefox 76.0.1 on Ubuntu. It seems that the resizing column works... Stanislav Lomany
07:01 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> and create a new bug issue related to resizing and work on these issues because it seems that they are not related ... Greg Shah
04:12 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? ...
Hynek Cihlar
02:19 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Thanks, I tested @browse-simple.p@ with 4231b and Firefox 76.0.1 on Ubuntu. It seems that the resizing column works p... Sergey Ivanovskiy
08:27 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> What test case can help to reproduce these issues?
Is is attached: if you try to resize a row, you'll notice that ...
Stanislav Lomany
10:24 AM Base Language Support #4657 (WIP): memory overhead from preloading classes with LegacySignature
The lazy loading approach for external programs case is fixed in 4231b rev 11584
For legacy classes, they are all...
Constantin Asofiei
06:26 AM Base Language Feature #4384: Builtin OO Implementation
Attached the patch for skeleton changes, in Eclipse and Bazaar format... this might also include the previous changes... Marian Edu
06:19 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Understood. If there is no choice here, then keep going on this path. The code is actively used...
Marian Edu
02:32 AM Base Language Feature #4384: Builtin OO Implementation
A list of not particularly related issues just for further reference:
- I18N, code page support not really matching ...
Marian Edu

06/04/2020

05:20 PM Database Feature #3814: more schema metadata
Added conversion support for the @_Field.CAN-*@ fields and population of @CAN_*@ and @*-SA@ fields for @_File@/@_Fiel... Igor Skornyakov
04:08 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> In case of abends, I think FWD should release all locks, right?
Yes, it should. The...
Eric Faulhaber
01:03 PM Database Feature #4011: database/persistence layer performance improvements
My changes to fix the #4011-385, the @deleteAll@ problem because there was no notification of a newly created record ... Constantin Asofiei
12:39 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> If you know of any other issues in Hotel GUI which you suspect are related to this root caus...
Constantin Asofiei
08:30 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric, the issue in #4011-412 is no solved by your changes.
OK, thanks for testing. Th...
Eric Faulhaber
08:22 AM Database Feature #4011: database/persistence layer performance improvements
Eric, the issue in #4011-412 is not solved by your changes. Constantin Asofiei
07:21 AM Database Feature #4011: database/persistence layer performance improvements
I've committed rev 11450, which reworks the UNDO of DMOs to be primarily in memory on the FWD server, with less relia... Eric Faulhaber
09:49 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? ...
Sergey Ivanovskiy
09:09 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Actually, area is defined in @MouseDirectManipulation@, but it doesn't work because of the problem noted above. So sh... Stanislav Lomany
09:00 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? How can I specify a hoverab... Stanislav Lomany
01:54 AM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> It is interesting that _column_ resize is implemented in @BrowseColumnGuiImpl.mouseMoved@ ...
Sergey Ivanovskiy

06/03/2020

06:35 PM Database Feature #4011: database/persistence layer performance improvements
More details:
At this moment the unique-indexes are validated on SQL-tier, the result in case of failure being a dia...
Ovidiu Maxiniuc
05:26 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please disable the new query-based validation check for now, but then get back to integratin...
Ovidiu Maxiniuc
09:31 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> unique index validation: primarily a no 1 implementation (see entry 127), but also slight...
Eric Faulhaber
02:56 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
It is interesting that _column_ resize is implemented in @BrowseColumnGuiImpl.mouseMoved@ (it works), while _row_ res... Stanislav Lomany
01:27 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > MS Tree View doesn't expose @SEL...
Hynek Cihlar

06/02/2020

05:34 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Even if this particular issue is related to a regression in batch assign mode, I think the o...
Constantin Asofiei
05:34 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Eric Faulhaber wrote:
> >
> > > We probably need to centra...
Eric Faulhaber
04:36 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
>
> > We probably need to centralize the validation/flushing/notifi...
Constantin Asofiei
04:24 PM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> We probably need to centralize the validation/flushing/notification into one method to mak...
Eric Faulhaber
02:20 PM User Interface Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > MS Tree View doesn't expose @SELECTED-NODE@, but its node expose...
Sergey Ivanovskiy
01:55 PM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> MS Tree View doesn't expose @SELECTED-NODE@, but its node exposes @SELECTED@ attribute. @...
Hynek Cihlar
01:43 PM User Interface Feature #4170: add drag and drop support to treeview widget
MS Tree View doesn't expose @SELECTED-NODE@, but its node exposes @SELECTED@ attribute. @SELECTED-NODE@ is a FWD exte... Sergey Ivanovskiy
11:13 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Sergey Ivanovskiy wrote:
> > > It seems only @DropHighLight@ is no...
Hynek Cihlar
10:49 AM User Interface Feature #4170: add drag and drop support to treeview widget
Yes, I set it to 100%. Sergey Ivanovskiy
10:39 AM User Interface Feature #4170: add drag and drop support to treeview widget
Is this task ready for test status/100% completed? Greg Shah
10:34 AM User Interface Feature #4170: add drag and drop support to treeview widget
Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > It seems only @DropHighLight@ is not implemented but it can be impl...
Sergey Ivanovskiy
10:17 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> It seems only @DropHighLight@ is not implemented but it can be implemented as @SELECTED-N...
Greg Shah
10:09 AM User Interface Feature #4170: add drag and drop support to treeview widget
It seems only @DropHighLight@ is not implemented but it can be implemented as @SELECTED-NODE@ until new logic will no... Sergey Ivanovskiy
09:57 AM User Interface Feature #4170: add drag and drop support to treeview widget
This property ... Sergey Ivanovskiy
09:24 AM User Interface Feature #4170: add drag and drop support to treeview widget
Is there any remaining work for this task? Greg Shah
07:40 AM User Interface Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I don't know all requirements, the first assumption was that if ...
Sergey Ivanovskiy
02:48 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> I don't know all requirements, the first assumption was that if expand icon was not set d...
Hynek Cihlar
03:20 AM Base Language Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> It seems like @ObjectOps.WorkArea.legacyNames@ and @ObjectOps.WorkArea.name2cls@ are both truly s...
Constantin Asofiei
03:13 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Is there a way to keep on using the configuration file from file system instead of going through...
Constantin Asofiei
01:47 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I've updated the standard.df on xfer testcases with the latest one from the Hotel GUI pr...
Marian Edu

06/01/2020

05:42 PM Base Language Feature #4349: add support for 4GL ENUM
It seems like @ObjectOps.WorkArea.legacyNames@ and @ObjectOps.WorkArea.name2cls@ are both truly static data. It seem... Greg Shah
03:09 PM Database Feature #3814: more schema metadata
Added conversion support for the tables/fields string attributes (@*-SA@ properties)
Committed to 4231b rev. 11577.
Igor Skornyakov
12:14 PM Database Feature #3814: more schema metadata
Debugging the conversion I've realized that I have to add support for the new table/field properties to the @p2o.xml@... Igor Skornyakov
10:04 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" anno...
Igor Skornyakov
09:55 AM Database Feature #3814: more schema metadata
Put debug @printf@ statements in the @dmo_common.rules@ section for @graft "column-label-sa" annotation@. Either you... Greg Shah
09:38 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Yes.
Well, as you can see the new properties were not added.
Igor Skornyakov
09:02 AM Database Feature #3814: more schema metadata
Yes. Greg Shah
08:45 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. ...
Igor Skornyakov
08:16 AM Database Feature #3814: more schema metadata
I think you have shown the 4GL AST. The code calling @declareProperty@ is building a Java AST. Please show that Jav... Greg Shah
07:53 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Please show the output jast for the example field....
Igor Skornyakov
07:48 AM Database Feature #3814: more schema metadata
Please show the output jast for the example field. Greg Shah
07:32 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Post your @dmo_common.rules@.
>
> Are the annotations correct (as you would expect) in the AST...
Igor Skornyakov
07:25 AM Database Feature #3814: more schema metadata
Post your @dmo_common.rules@.
Are the annotations correct (as you would expect) in the AST?
Greg Shah
07:16 AM Database Feature #3814: more schema metadata
I see some strange situation:
There are two similar annotations for the field AST in the @.schema@ file:...
Igor Skornyakov
06:23 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> > Please note, that the TYPE for the LABEL property is KW_LABEL, but is VALEXP for VALEXP (not KW...
Igor Skornyakov
06:21 AM Database Feature #3814: more schema metadata
Greg Shah wrote:
> Feedback:
>
> 1. The artificial token definitions for @KW_COL_LAB@, @KW_HELP@ and @KW_LABEL@ s...
Igor Skornyakov
02:11 PM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed revision 11575 and 115...
Sergey Ivanovskiy
02:00 PM User Interface Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11575 and 11574 (4231b) fixed the found issue...
Sergey Ivanovskiy
12:35 PM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek Cihlar wrote:
> > > > Ser...
Hynek Cihlar
12:30 PM User Interface Feature #4170: add drag and drop support to treeview widget
I see that there are @setNodeIcon@ and @setExpandNodeIcon@ with the same parameter of @BaseDataType@. The original co... Sergey Ivanovskiy
12:25 PM User Interface Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Sergey Ivanovskiy wrote:
> > > > Com...
Sergey Ivanovskiy
11:47 AM User Interface Feature #4170: add drag and drop support to treeview widget
Eugenie Lyzenko wrote:
> >If so, Constantin made some updates in *4231b-11576* that fixed something that started in ...
Hynek Cihlar
11:45 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed revision 11575 and 115...
Hynek Cihlar
11:20 AM User Interface Feature #4170: add drag and drop support to treeview widget
Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > Starting with @11569@ the @4231b@ has still a c...
Eugenie Lyzenko
11:15 AM User Interface Feature #4170: add drag and drop support to treeview widget
Eugenie Lyzenko wrote:
> Guys,
>
> Starting with @11569@ the @4231b@ has still a conversion regression for custom...
Roger Borrello
09:39 AM User Interface Feature #4170: add drag and drop support to treeview widget
Guys,
Starting with @11569@ the @4231b@ has still a conversion regression for customer's application. Is somebody ...
Eugenie Lyzenko
07:34 AM User Interface Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11575 and 11574 (4231b) fixed the found issue...
Sergey Ivanovskiy
02:18 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > The issue from #4170-167 was due...
Hynek Cihlar
02:12 AM User Interface Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Committed revision 11575 and 11574 (4231b) fixed the found issues.
Code review 4231b r...
Hynek Cihlar
02:07 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limi...
Eric Faulhaber
02:02 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the ta...
Eric Faulhaber
12:42 PM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> Some thoughts: that article uses a pseudo randomized unindexed data set. They need the coun...
Constantin Asofiei
12:41 PM Database Feature #4011: database/persistence layer performance improvements
Some thoughts: that article uses a pseudo randomized unindexed data set. They need the count so the scan is mandatory... Ovidiu Maxiniuc
12:31 PM Database Feature #4011: database/persistence layer performance improvements
Indeed, the full scan will be required for both of @count(__)@ versions. However, the @limit 1@ will not help. The re... Ovidiu Maxiniuc
12:30 PM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> Anyway, looking at some benchmark articles, like https://www.citusdata.com/blog/2016/1...
Eric Faulhaber
11:50 AM Database Feature #4011: database/persistence layer performance improvements
Ovidiu Maxiniuc wrote:
> I suppose you are talking about the unique index validation. These are queries using standa...
Constantin Asofiei
11:42 AM Database Feature #4011: database/persistence layer performance improvements
Constantin Asofiei wrote:
> A note: we shouldn't use @select count(*)@ - this should be replaced by something like @...
Ovidiu Maxiniuc
08:12 AM Database Feature #4011: database/persistence layer performance improvements
About the #4011-385 - the issue is that the @ttRoomTypeAgg.deleteAll()@ is seeing the table as 'empty' (the @isTableD... Constantin Asofiei
07:41 AM Database Feature #4011: database/persistence layer performance improvements
A note: we shouldn't use @select count(*)@ - this should be replaced by something like @select count(recid)@ or whate... Constantin Asofiei
07:37 AM Database Feature #4011: database/persistence layer performance improvements
Eric Faulhaber wrote:
> Please continue to test Hotel GUI and work on fixes for any apparent regressions which do no...
Constantin Asofiei
05:08 AM Database Feature #4011: database/persistence layer performance improvements
Constantin, I am working on a solution, but it may take another day or so. The good news is that I think you may have... Eric Faulhaber
01:41 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> I think the problem is global; I'm having issues with dragging a button in FWD, on both ...
Sergey Ivanovskiy
01:11 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> I think the problem is global; I'm having issues with dragging a button in FWD, on both ...
Sergey Ivanovskiy
 

Also available in: Atom