Activity
From 05/17/2023 to 06/15/2023
06/15/2023
- 12:39 PM Bug #7443: performance of CentralLogger
- > Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I m...
- 12:38 PM Bug #7443: performance of CentralLogger
- > 1. Have you done performance testing on Java @isLoggable@ implementation? Think about it carefully.
All of our p... - 12:37 PM Bug #7443: performance of CentralLogger
- Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I mea...
- 11:47 AM Bug #7443: performance of CentralLogger
- I'm not sure if that got understood, but all loggers should listen to the change, this means a few hundred objects wr...
- 11:41 AM Bug #7443: performance of CentralLogger
- What I'm trying to say is that listeners and more state are a bad idea. It should be implemented with @WeakReference@...
- 11:33 AM Bug #7443: performance of CentralLogger
- Also Java logger has a tree :( I wanted to implement a tree as well, but didn't have the capacity of a Java team.
- 11:24 AM Bug #7443: performance of CentralLogger
- I made an expensive mistake, that removed will improve things 3 times... Now @getLevel@ checks in 3 concurrent maps, ...
- 11:13 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> Galya B wrote:
> > To me removing 50% of the calls sounds quite right. Or am I misreading your scr... - 10:59 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
I didn't s... - 10:58 AM Bug #7443: performance of CentralLogger
- Also as I've said, I have a mistake to fix.
- 10:57 AM Bug #7443: performance of CentralLogger
- To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
- 10:54 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
Reworking co... - 10:52 AM Bug #7443: performance of CentralLogger
- Do we have a branch here?
- 10:51 AM Bug #7443: performance of CentralLogger
- Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
- 10:49 AM Bug #7443: performance of CentralLogger
- Constantin, I started with a similar implementation, where the state also included the level, but there are other cav...
- 10:46 AM Bug #7443: performance of CentralLogger
- @isLoggable@ is meant to be used when there is a cost with resolving the arguments passed to the @log@ method. That'...
- 10:44 AM Bug #7443: performance of CentralLogger
- Even if I bend due to pure pressure and implement it, I don't recommend using @isLoggable@ just for the sake of looki...
- 10:29 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> It doesn't matter if the same logger name is being used by multiple logger instances, th... - 10:20 AM Bug #7443: performance of CentralLogger
- Greg Shah wrote:
> Bypassing everything but the logging level check has served us well. There is a performance reas... - 10:20 AM Bug #7443: performance of CentralLogger
- Galya, the problem is not @isLoggable@ being called excessively. @canLog@ relies too on @isLoggable@, so getting rid ...
- 10:14 AM Bug #7443: performance of CentralLogger
- Bypassing everything but the logging level check has served us well. There is a performance reason those checks were...
- 10:13 AM Bug #7443: performance of CentralLogger
- This is the entire @logging@ node. The @loggers@ levels is the same from before testing with @CentralLogger@....
- 10:08 AM Bug #7443: performance of CentralLogger
- Constantin, what is the logging level you tested with on this screenshot?
- 09:50 AM Bug #7443: performance of CentralLogger
- Also let's not forget that resource consumption is part of execution of applications and this feature was not existin...
- 09:44 AM Bug #7443: performance of CentralLogger
- There is no free lunch, it's either the CPU or the RAM. If I need to work on this task, I'll remove @isLoggable@ from...
- 09:40 AM Bug #7443: performance of CentralLogger
- And we know the complexity of accessing string keyed map. Do you think the concurrency of the map adds to the CPU usage?
- 09:39 AM Bug #7443: performance of CentralLogger
- Actually the cache map should have been the first lookup in the method. This is my bad.
- 09:33 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> We need to remove the map lookup. The log level needs to be cached at the logger instan... - 09:32 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> We can lower it to 1.8 million executions removing the unnecessary @if (LOG.isLoggable(Level.FINE))... - 09:31 AM Bug #7443: performance of CentralLogger
- ~1% of resources for 3.6 million executions sounds great to me!
Jokes aside...
We can lower it to 1.8 million e... - 08:13 AM Bug #7443: performance of CentralLogger
- @CentralLogger.isLoggable@ is called 3.6 million times when testing an application. In the profiler, this highlights...
- 08:08 AM Bug #7443 (Closed): performance of CentralLogger
- 10:52 AM Bug #7425 (WIP): Avoid directory usage in static blocks
- Danut, this is close to your work on #7388. I will do the review on caches there asap.
Please extend your research...
06/13/2023
- 02:15 AM Bug #7291: LOG-MANAGER to log on client-side
- I'll merge it with 7415c when ready.
06/12/2023
- 02:32 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> Galya, I missed something. Appserver logging must not be forced on server-side.
Well, ...
06/11/2023
- 05:59 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya, I missed something. Appserver logging must not be forced on server-side....
06/09/2023
- 10:01 AM Bug #7291: LOG-MANAGER to log on client-side
- > I can name it @merge notification for task 7291@ if there is no standard one.
That works. - 09:59 AM Bug #7291: LOG-MANAGER to log on client-side
- Fix merged to trunk as rev 14621.
- 09:53 AM Bug #7291: LOG-MANAGER to log on client-side
- I can name it @merge notification for task 7291@ if there is no standard one.
- 09:51 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg Shah wrote:
> In the future, when you post something like this that is expected to be committed immediately, pl... - 09:50 AM Bug #7291: LOG-MANAGER to log on client-side
- In the future, when you post something like this that is expected to be committed immediately, please include history...
- 09:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Diff attached. Fixes two NPEs when configs not present.
- 09:27 AM Bug #7291: LOG-MANAGER to log on client-side
- No, just post the full diff here for a quick review.
- 09:03 AM Bug #7291: LOG-MANAGER to log on client-side
- Do I create a whole new branch just for a null check?
- 06:32 AM Bug #7291 (Test): LOG-MANAGER to log on client-side
- 03:22 AM Bug #7291: LOG-MANAGER to log on client-side
- Task branch 7291a was merged to trunk as rev 14620 and archived. Email sent.
- 08:49 AM Bug #5703 (Closed): rationalize, standardize and simplify the client-side log file name configura...
- 04:35 AM Bug #7425: Avoid directory usage in static blocks
- After discussing with Constantin, mostly in regard to #7398, there are several places in FWD where the directory is r...
- 04:23 AM Bug #7425 (Test): Avoid directory usage in static blocks
06/08/2023
- 02:53 PM Bug #7291: LOG-MANAGER to log on client-side
- You can merge now.
- 11:40 AM Bug #7291: LOG-MANAGER to log on client-side
- Pushed a tiny NPE fix in r14629. Tested with gui and chui.
When do I merge? - 10:37 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> * @Utils.pollAll@ needs to return null if there is no message, there is no reason to tra... - 09:46 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> I've looked through all the changes, I don't see anything else wrong. Did you test agai... - 09:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, ... - 07:54 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, when you're done.
- 06:56 AM Bug #7291: LOG-MANAGER to log on client-side
- > Greg, this is not documented in the coding standards, please correct me if I'm wrong.
I think this is correct. ... - 06:43 AM Bug #7291: LOG-MANAGER to log on client-side
- Review for 7291a/14627:
* we don't usually use static imports except for interface constants. Without qualifying a ... - 06:28 AM Bug #7291: LOG-MANAGER to log on client-side
- 7291a r14627 file headers.
- 08:09 AM Feature #7418: assess the security of the Jetty web server
- And we need to differentiate between FWD server jetty and FWD client jetty.
- 08:04 AM Feature #7418: assess the security of the Jetty web server
- I think we should also document the full stack for each exposed endpoint including versions. For example for Keikai t...
- 07:59 AM Feature #7418: assess the security of the Jetty web server
- Constantin Asofiei wrote:
> * Hynek, is sheet.war starting another web server? If so, what URL is it using?
No, ... - 06:54 AM Feature #7418: assess the security of the Jetty web server
- The main internet-exposed point of FWD is the Jetty web server. This includes the web server running on the FWD serv...
- 06:45 AM Feature #7418 (New): assess the security of the Jetty web server
06/07/2023
- 07:19 PM Bug #7291: LOG-MANAGER to log on client-side
- > Do I add the file headers before or after the review?
Generally, before. It helps explain the changes which mak... - 02:21 PM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> Galya B wrote:
> > How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ i... - 09:34 AM Bug #7291: LOG-MANAGER to log on client-side
- Do I add the file headers before or after the review?
- 09:33 AM Bug #7291 (Review): LOG-MANAGER to log on client-side
- 7291a rebased on trunk r14616.
7291a r14626 tested and ready for review. - 09:31 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
... - 04:40 AM Bug #7291: LOG-MANAGER to log on client-side
- How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
06/05/2023
- 01:20 PM Bug #7291: LOG-MANAGER to log on client-side
- A few notes:
* Java file lock is respected by other Java processes on Windows and Linux and they will wait indefinit...
06/01/2023
- 09:46 AM Bug #7291: LOG-MANAGER to log on client-side
- > Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always b...
- 07:16 AM Bug #7291: LOG-MANAGER to log on client-side
- Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always be ...
- 06:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Task branch 5703d was merged to trunk as rev 14595 and archived. Email sent.
- 06:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Can you confirm this change ?
Yes, confirmed. It is a matter of preference. Some will like the change, some wi... - 05:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also most FWD devs trace issues on the console, while I do it using the files, so my opinion may differ based on that...
- 04:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> In @LoggingUtil@ please set @SORTABLE_DATETIME_FORMAT@ to "%tY%tm%td_%tH%tM%tS". It just condens...
05/31/2023
- 03:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Code Review Task Branch 5703d Revisions 14593 and 14594
The changes are good.
In @LoggingUtil@ please set @SORT... - 02:09 PM Bug #7291: LOG-MANAGER to log on client-side
- I'm fine with the plan.
- 12:25 PM Bug #7291: LOG-MANAGER to log on client-side
- Then what about making the design as simple and and clear as possible.
* @LOG-MANAGER@ will live on the server and t... - 09:06 AM Bug #7291: LOG-MANAGER to log on client-side
- We need to move ahead with this task. We cannot assume that all customers can use server-side logging for @LOG-MANAG...
05/30/2023
- 12:21 PM Bug #7291: LOG-MANAGER to log on client-side
- Pause the work while I consider what we lose by dropping this.
- 11:37 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg, I think LOG-MANAGER client-side implementation will end up:
* very fragile;
* with multiple rpc calls for one... - 08:24 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg, it's not that I'm lazy, but it really doesn't make sense to have LOG-MANAGER client-side. It's way too intertwi...
- 08:19 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> This is what I meant. It may work if all the validation/checks (which can raise OE erro... - 08:12 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> ... but there are plenty of OE errors in initialization and the setters.
This is what I meant. It... - 08:11 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> but there are plenty of OE errors in initialization and the setters.
... which is (as we already... - 08:09 AM Bug #7291: LOG-MANAGER to log on client-side
- There are no Java exceptions thrown, but there are plenty of OE errors in initialization and the setters.
It just ... - 07:51 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya, is there any condition which can be raised by any APIs which would use state sync? If this is so, then we must...
- 05:00 AM Bug #7291: LOG-MANAGER to log on client-side
- State sync doesn't seem to work well. On top of the the six getters, the following methods should also return a value...
- 08:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Galya B wrote:
> Are you using a real Windows system?
I set up a VirtualBox VM, here is t... - 08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm th... - 02:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm that the latest trun...
- 02:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Have you been able to run hotel_gui on Windows? I am having a lot of trouble getting clien...
05/29/2023
- 02:40 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> The Jetty info msg is not causing issues on any deployments. Do you still have this issue and can y... - 01:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703d r14593 loggers to fallback to the default log file name if the provided path is invalid (can't be created or no...
- 10:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a warning about th...
- 06:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a ... - 03:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote (#7378-909):
> Galya: The NPE is a bug that needs to be fixed. It needs to fail gracefully instead o... - 03:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Well the result is the server no longer functions. This is on a Windows VM for which I have ...
05/26/2023
- 10:31 AM Bug #7291: LOG-MANAGER to log on client-side
- The state sych honors the order of operations because of these facts:
# The execution of code is effectively singl... - 08:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Now that I think more about it, the whole merge-two-sources-of-events-and-execute-them thing is problematic. It can't...
- 08:32 AM Bug #7291: LOG-MANAGER to log on client-side
- How are supposed getters to work with state sync? I can create events for initialization, attr setters, write log rec...
05/24/2023
- 08:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> This is a @Jetty@'s message, may be a new one to our logs; with the proper @slf4j@ support now 3rd ... - 02:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> From what I researched, this means that the JVM doesn't support JPMS, which was introduced i...
05/23/2023
- 01:54 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Yes, all messages are always logged / sent to the listening server process, where they are filtered... - 11:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> DB import shows lots of INFO statements like:
> [...]
>
> These need to be lowered.
... - 09:03 AM Bug #5703 (Test): rationalize, standardize and simplify the client-side log file name configuration
- Task branch 5703c merged to trunk as rev 14583 and archived. Email sent. Logs wiki updated.
- 08:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya, please double-check the module name for all files changed in 5703c and also the h... - 08:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, please double-check the module name for all files changed in 5703c and also the history number:
* history num... - 07:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I need a dedicated tester only for the headers... Maybe we need automated tests.
@CentralLoggerClientConfigs@ was ... - 07:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- * @LegacyLogManagerConfigs@ - still needs history entry
* @CentralLogger@ - there are only two trunk commits in this... - 07:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- It may look weird, but it's not so bad, see:
Constantin Asofiei wrote:
> Galya, review for 5703c rev 14585:
> * ... - 07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, review for 5703c rev 14585:
* @CentralLogger@ - only a history number is needed, like this:... - 06:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c rebased on trunk r14579.
- 06:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c r14578 Fixed unused variable ‘j’ in spawn.c
- 06:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I think we hold off for now. Let's finalize 5703c and get it merged today.
I don't have anythin... - 06:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Do you know what, Greg! This was an awesome example of why @INFO@ level is so much needed for all logging. How otherw...
- 06:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > If it's a simple fix, someone can upload it to this branch. I'm not sure what needs to be done.
I think we hold ... - 06:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Is this to be solved in another task?
Yes, see #7377. - 06:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Is this to be solved in another task?
I think the related code was introduced with #2124 @bzr di... - 06:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> The core issue (already existing, not created by the logging changes) is that we are loading the ... - 06:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Roger, on executing @./server.sh -k@ with my configs now I get only:
> [...]
> But this was there... - 05:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, on executing @./server.sh -k@ with my configs now I get only:...
- 05:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c r14577 is up:
* Sets a default of WARNING to @SecurityCache@, when no explicit logging configs available for t... - 03:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, thank you for reporting the inconsistencies. The messages you've seen are generated by @SecurityCache@ on leve...
- 02:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > As far as I can see the debug level now is always on maximum. Sh... - 10:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Eugenie Lyzenko wrote:
> As far as I can see the debug level now is always on maximum. Showing as much info as possi... - 09:30 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> For the @winspawn.c@ I am lost as to how to find messages for debugging. Is there something ... - 08:01 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- For the @winspawn.c@ I am lost as to how to find messages for debugging. Is there something to put in the directory, ...
- 06:31 AM Bug #7377: ServerDriver.connect() should not force server-mode to be turned on
- As discussed in #5703-608 and previous notes, the @ServerDriver.connect()@ will call @bc.setSever(true)@ and try to l...
- 06:30 AM Bug #7377: ServerDriver.connect() should not force server-mode to be turned on
- Check #5703#note-610.
- 06:27 AM Bug #7377 (New): ServerDriver.connect() should not force server-mode to be turned on
- 05:45 AM Bug #7375: Prevent spoofed logs in CentralLogger
- Outside code can use @CentralLogger@ to create an instance of any @com.goldencode@ or anonymous (root) logger and use...
- 05:45 AM Bug #7375 (New): Prevent spoofed logs in CentralLogger
05/22/2023
- 04:42 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Aside from the new found logging, I am happy with the way things are looking with my logging configuration for the ap...
- 04:34 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I think this should be cleaned up.
I'm not sure by whom, but I was trying to delve a little de... - 02:50 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > The thing that she fixed in 5703c is that the previous version of @ServerDriver.configureLogging()@ always forced...
- 01:23 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> The thing that she fixed in 5703c is that the previous version of @ServerDriver.configureLogging(... - 12:03 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya mentioned that the code already had @ServerDriver.connect()@ line 939 where it forces @bc.setServer(true)@. Th...
- 11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> That seems like a bug, maybe one that already existed but it needs to be fixed. In @-s@ mode the... - 11:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- That seems like a bug, maybe one that already existed but it needs to be fixed. In @-s@ mode the server flag should ...
- 10:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Roger: Please check that your issues are cleared using 5703c.
What is causing this level of ou... - 09:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Roger: Please check that your issues are cleared using 5703c.
Will do. - 06:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger: Please check that your issues are cleared using 5703c.
05/19/2023
- 10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c r14576 (I uncommitted the previous revision): I think the logging with different server modes is fixed.
- 09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- ...
- 09:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Just a note: This is not a new change and it throws an exception when server is started in the modes without director...
- 08:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> The point here is: when something other than @MODE_START@ is being used, ServerDriver do... - 07:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > You can still print the same formatted messages from another anonymous logger somewhere else.
This was my point ... - 07:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Do we speak about intentional or unintentional logging fraud here? :)
- 07:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- But the past implementation still doesn't make sense... You can still print the same formatted messages from another ...
- 07:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- My conclusion is that the so called anonymous loggers that had some meaning in a security vulnerability prone Java Lo...
- 07:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > The output from it could be controlled such that the format was fixed and the class name portion was not overridden...
- 07:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> The idea was:
>
> * The instance was unique and could not be obtained by using the class or cl... - 07:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > It existed before as the anonymous logger implementation. You could not use the class from one file to obtain th...
- 07:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The only mutability in CentralLogger instance is the level and it's global, so consistent.
- 07:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I hope I made it clear that CentralLogger is not Java logger, it's lightweight, simplified, completely different impl...
- 07:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- ...
- 06:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > Galya, related to ServerDriver changes: only @MODE_START@ ne... - 06:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also I don't see how anonymous loggers save you from having other named loggers used by 3rd party users of the framew...
- 06:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> It existed before as the anonymous logger implementation. You could not use the class from one f... - 06:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > Just because it was designed in to the Java logging framework doesn't... - 06:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Just because it was designed in to the Java logging framework doesn't mean that it is a good idea... - 06:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Just because it was designed in to the Java logging framework doesn't mean that it is a good idea. In a JVM process ...
- 06:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya, related to ServerDriver changes: only @MODE_START@ needs to be checked against. ... - 06:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Traceability of logs is a matter of controlled reviewed development. But if you want to protect certain loggers, we c...
- 06:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, related to ServerDriver changes: only @MODE_START@ needs to be checked against. Also, I don't really understa...
- 06:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Check "Java doc on Logger":https://docs.oracle.com/javase/8/docs/api/java/util/logging/Logger.html, there are about 1...
- 06:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- We can call the logger for example "Security" and have 10 classes output using it.
- 06:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- ...
- 06:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I guess that means that anonymous loggers are not available in the new approach.
- 06:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Because random code should not be able to output to a logger for another class.
- 06:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Is it still possible to create anonymous loggers?
Why?
- 06:36 AM Bug #5703 (Review): rationalize, standardize and simplify the client-side log file name configura...
- 06:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is it still possible to create anonymous loggers? Based on what I have read above and on the wiki, it seems like thi...
- 05:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I'm done with what I'm aware of. If there are any outstanding issues, please let me know.
- 05:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Here are the server run modes:...
- 04:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c based on latest trunk r14572 has the following changes in r14573-14575:
* @%as@ properly supported for @server... - 02:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Galya Bogdanova wrote:
> > @%as@ placeholder (appserver name) is now properly supported for... - 02:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > I believe there is a regression in that when I run @./server.sh -w@ for checking on status of t... - 02:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Were these both resolved in 5703b?
> > > DB import shows lots of ... - 06:07 AM Bug #7354: do not log keystore/truststore passwords when dumping arguments during spawning
- Greg, as can be seen in #7354-3, the title of this task is a bit too narrow. Also @sun.java.command@ needs some secre...
05/18/2023
- 12:37 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> @%as@ placeholder (appserver name) is now properly supported for FWD log file names (previo... - 11:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > I believe there is a regression in that when I run @./server.sh -w@ for checking on status of the server process, a...
- 11:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Were these both resolved in 5703b?
> > DB import shows lots of INFO statements like:
Only this ... - 11:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > DB import shows lots of INFO statements like:
> ...
> Regression: @RemoteObject@ can be used from standalone JVMs... - 09:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703b merged in trunk as r14572, email sent. I'm starting on rotation disabling and server logs on console in 5703c.
- 09:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Roger, can I see this wrapper that parses logs, you're referring to?
See attached. - 08:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, please add a history entry to @CentralLoggerClientStandalone@ and after that you can merge. All is good on my...
- 08:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Then the last question would be if there is world where someone wants to get rid of my work... - 08:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > It seems reasonable. Any @rotation < 2@ should mean explict disabling.
>
> To me (for what it's worth :-), @r... - 08:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Constantin, can we merge 5703b to fix the class loader? Sergey has decided to not work on #... - 08:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> It seems reasonable. Any @rotation < 2@ should mean explict disabling.
To me (for what it's w... - 08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin, can we merge 5703b to fix the class loader? Sergey has decided to not work on #7357 until CentralLogger i...
- 08:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Or worse, 2 same files, or even worse, 1 file with FileHandler and srderr redirect writing to it.
- 08:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- OK, just keep in mind that someone may like the new configs, use them locally and migrate customers to having both se...
- 08:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > My problem with this whole rework "make it as it was before" is that noone will migrate properly customers, if it w...
- 08:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Then the last question would be if there is world where someone wants to get rid of my work .. I meant log files co...
- 08:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- My problem with this whole rework "make it as it was before" is that noone will migrate properly customers, if it wor...
- 08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Then the last question would be if there is world where someone wants to get rid of my work .. I meant log files comp...
- 08:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- If freedom should be allowed, then I can make @rotationLimit=0@ to completely disable rotation, instead of passing it...
- 08:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I'd rather have an explicit option to enable console logging (or anything else), this allows flexibility; 'DEV' is to...
- 08:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Or allow the comfort of the old world to everyone - put all in one easily replaceable file and print to console by se...
- 08:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- OK, what about if ... we get one new config called @logging/DEV@ that will enable server logs to System.err (like wha...
- 08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Logs in the IDE console is a convenience for development, but is it of any value to customers?
I agree this is p... - 08:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also keep in mind that server logs is just a piece of the whole picture and client logs will never be printed on the ...
- 08:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- You probably use the old integrated environment. Since I don't, I've never seen server logs in the console. Logs in t...
- 08:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Constantin, do you think about parsing the logs that's why rotation is in the way, or you h... - 08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- There are no rules for the pros I guess :)
- 08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > What is this @<node class="string" name="path.chui">@ ? Where did the @.gui@, @.chui@ come from... - 08:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > What is this @<node class="string" name="path.chui">@ ? Where did the @.gui@, @.chui@ come from?
We have a mecha... - 08:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > Galya, is there a way to configure the @logging@ so that there is a single file, with no rotation?
> At the mome... - 07:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin, do you think about parsing the logs that's why rotation is in the way, or you have different concerns?
- 07:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya, is there a way to configure the @logging@ so that there is a single file, with no... - 07:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, is there a way to configure the @logging@ so that there is a single file, with no rotation?
- 07:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > My only questions is should I include @serverSide=TRUE@.
Probably, yes. - 06:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Is @org.hibernate.cache@ still used? There is this logger in testcases configs and I believ... - 05:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is @org.hibernate.cache@ still used? There is this logger in testcases configs and I believe it's not used any more.
- 04:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, can I see this wrapper that parses logs, you're referring to?
- 03:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @%as@ placeholder (appserver name) is now properly supported for FWD log file names (previous worked only for legacy ...
- 02:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- As of @rotationCount@ if there is no disk space limitation known beforehand, I recommend to make it more, otherwise l...
- 02:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also @rotationLimit@ is by default @500000@, so you can just omit it.
- 02:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- What is this @<node class="string" name="path.chui">@ ? Where did the @.gui@, @.chui@ come from?
05/17/2023
- 05:25 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I think I am happy with my new configuration. With this, I can cover ChUI and GUI:...
- 05:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- FYI, tokens work fine. My entry for ChUI clients is:...
- 04:28 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Roger Borrello wrote:
> > Where does the @%as@ value come from?
>
> It looks like everyw... - 04:15 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Where does the @%as@ value come from?
It looks like everywhere @LoggingUtil.resolveLogFil... - 02:57 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Roger, I got you! You're running multiple servers at the same time and still asking why the... - 11:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Eugenie,
> This log is in fwd_server_*.log I guess:
> [...]
> Let's figure out why FINE ... - 11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > > ** ServerDriver special modes for status checking, shutdown processing, batch program launch
... - 10:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > ** ServerDriver special modes for status checking, shutdown processing, batch program launch
> Gold mine! It cli... - 10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Truth being told, @%m%g.log@ is not a prod config. It can work only for Hotel GUI and that is only if you don't do th...
- 10:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Conversion tools don't use sessions. Sessions are used by:
> [...]
> ** ServerDriver special m... - 09:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > I mean how do tools configure a session?
Conversion tools don't use sessions. Sessions are used by:
* FWD cl... - 09:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Eugenie,
This log is in fwd_server_*.log I guess:... - 09:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya: regarding log rotation. I have a config where the server log name is @server.log... - 09:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> i.e. why is the default logger used with RemoteObject?
A separate JVM connects via the app... - 09:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- i.e. why is the default logger used with RemoteObject?
- 08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I mean how do tools configure a session?
- 08:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Do we have RemoteObjects used by tools?
- 08:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- By the way the fix is up.
- 08:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> The problem is not that logs are filtered or not - the problem is @RemoteObject$RemoteAc... - 08:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Constantin, that being said, it's still not a critical bug. Logs are still properly filtere... - 08:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin, that being said, it's still not a critical bug. Logs are still properly filtered out in @publish(LogRecor...
- 08:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> See this test:
> [...]
> It prints @true@.
Aaaaah, that is because I developed withou... - 08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> I don't understand the problem. isLoggable should return true before the logging configs ki... - 08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, I want multithreaded Redmine tasks! How do I keep 3 conversations sensible in one timeline.
- 08:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Can you please clarify the new style log entries like this:
> ... - 08:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Eugenie Lyzenko wrote:
> Can you please clarify the new style log entries like this:
The problem I guess is that yo... - 08:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Eugenie Lyzenko wrote:
> Can you please clarify the new style log entries like this:
>
> [...]
>
> Is it expec... - 08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> > the problem in #5703-417 is still present; there is something wrong with this stack:
... - 08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya,
Can you please clarify the new style log entries like this:... - 07:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > the problem in #5703-417 is still present; there is something wrong with this stack:
because the isLoggable(Level)... - 07:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg Shah wrote:
> > > Hynek: please review the @ext/sheet/build.gradle@ change
> >
> >... - 07:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Roger Borrello wrote:
> > The wrapper needs to know what the server logfile name is, witho... - 07:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > If there is any other way to deploy the war without the main classpath, that is something to co... - 07:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > If there is any other way to deploy the war without the main classpath, that is something to consider.
Not that ... - 07:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also Eugenie tested it. Me too. If there is any other way to deploy the war without the main classpath, that is somet...
- 07:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> > Hynek: please review the @ext/sheet/build.gradle@ change
>
> Hynek is not available until Fr... - 07:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Hynek: please review the @ext/sheet/build.gradle@ change
Hynek is not available until Friday. We need to make t... - 07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703b r14577.
> * @src/com/goldencode/p2j/util/logging/CentralLoggerClientStandalone.java@ has just whitespace chang... - 06:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, review for 5703b rev 14576:
* @src/com/goldencode/p2j/util/logging/CentralLoggerClientStandalone.java@ has ju... - 06:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Can someone approve 5703b, cause it has important fixes that need to be merged and then we can improve on rotation in...
- 06:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I agree with Roger, that seems like a bug in the J2SE code. It is certainly not intuitive, when ... - 06:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Roger Borrello wrote:
> > The wrapper needs to know what the server logfile name is, witho... - 03:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- * 5703b r14576 server and client default log file names separated. Server default without pid.
* Tested.
* *Rea... - 03:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- What is the limitation in the wrapper of having no logic? Can it not find the last updated @server*.log@ file and par...
- 02:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> The wrapper needs to know what the server logfile name is, without having to make any logica... - 02:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> The wrapper needs to know what the server logfile name is, without having to make any logica...
Also available in: Atom