Activity
From 05/23/2023 to 06/21/2023
06/21/2023
- 11:00 AM Bug #7443 (WIP): performance of CentralLogger
- We know we need proper logging because there are 4GL language features that depend upon it. In addition, we must pro...
- 09:15 AM Bug #7443: performance of CentralLogger
- Another summary:
* @CentralLogger@ (used in new trunk) is 300% slower than @System.err@ redirected to file (used in ... - 09:02 AM Bug #7443: performance of CentralLogger
- Here is the java logger to file with the new formatter. There is slight degradation of performance (+6.3%), because t...
- 08:48 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> For example, can @String.format@ be replaced with something else, which parses the forma... - 08:41 AM Bug #7443: performance of CentralLogger
- Biased is a synonym for isolated? I have no idea what settings you use in your tests, while I shared my samples. Aren...
- 08:34 AM Bug #7443: performance of CentralLogger
- Galya, I think your tests are biased because they do not use the FWD runtime. My point was to test from within the F...
- 08:13 AM Bug #7443: performance of CentralLogger
- What I'm implying is: Console writes seem quite expensive, so the java logger performed poorly before, but the day wa...
- 08:10 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> From your results, are you saying that Java logger is 33seconds and CentraLogger is 14se... - 08:09 AM Bug #7443: performance of CentralLogger
- From your results, are you saying that Java logger is 33seconds and CentraLogger is 14seconds?
- 08:07 AM Bug #7443: performance of CentralLogger
- A little bit of history:
Once upon a time FWD used direct @System.err.print@ and @throwable.printStackTrace()@ sta... - 08:02 AM Bug #7443: performance of CentralLogger
- Here it is, the groundbreaking reality (in src.com.galya.LoggingTest):...
- 07:58 AM Bug #7443: performance of CentralLogger
- I don't understand what you mean by System.err. Previously, FWD was using @java.util.logging@ for logging support on...
- 04:39 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> using what was before CentraLogger
You mean @System.err@? server.log was "generated" by... - 04:01 AM Bug #7443: performance of CentralLogger
- Galya, please measure the following, for 1mm log lines:
* the LogTest modified program with CentralLogger and 7443a
... - 03:14 AM Bug #7443: performance of CentralLogger
- Let's set the requirements first before jumping into fixing. If I make @CentralLogger#describeContext@ (24,755%) and ...
- 02:50 AM Bug #7443: performance of CentralLogger
- Alexandru Lungu wrote:
> I got a result that is a bit slower than my trunk base-line before @CentralLogger@ (only +0... - 02:42 AM Bug #7443: performance of CentralLogger
- Alexandru, can you please try to run with the following configs:...
- 02:42 AM Bug #7443: performance of CentralLogger
- > Alexandru, please commit this change to 7443a. I expect 7443a to be merged to trunk before 7026e.
Done! Committe... - 01:41 AM Bug #7443: performance of CentralLogger
- Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Alexandru Lungu wrote:
> > > I commented an WARNING (that ...
06/20/2023
- 04:41 PM Bug #7443: performance of CentralLogger
- Galya, Alexandru I think is right, formatting the message is expensive. Please see how this can be improved. I've a...
- 10:00 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > I commented an WARNING (that is already fixed on another br... - 09:54 AM Bug #7443: performance of CentralLogger
- Alexandru Lungu wrote:
> I commented an WARNING (that is already fixed on another branch)
Is this already in trunk... - 09:42 AM Bug #7443: performance of CentralLogger
- I've done one set of profiling tests and got a slight improvement comparing to the state before #7443 (which was +3.1...
- 09:14 AM Bug #7443: performance of CentralLogger
- Code Review Task Branch 7443a Revision 14630
The change is good. I like that the code is in @Utils@ instead of @C... - 08:48 AM Bug #7443: performance of CentralLogger
- r14630 reverts @LogHelper#createThreadName@, requested in #7143-234.
- 04:23 AM Bug #7443: performance of CentralLogger
- I pushed r14629 to fix the compilation error. I haven't rebuilt with @all@.
- 03:40 AM Bug #7443: performance of CentralLogger
- 7443a/rev. 14628 doesn't compile: ...
- 01:47 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> Alexandru: please apply (locally) the 7443a changes to 7156b and run a new round of test... - 05:33 AM Bug #7425: Avoid directory usage in static blocks
- This bootstrap is triggered only on server start-up from @StandardServer@ hooks. Should we consider other FWD usages ...
- 04:55 AM Bug #7425: Avoid directory usage in static blocks
- There are a few classes that already have an @initialize@ method, so to avoid confusion I @bootstrap@ for the method ...
06/19/2023
- 11:50 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> 7443a r14628 based on trunk r14627 tested and ready for review.
The changes look reasonable, but t... - 10:40 AM Bug #7443 (Review): performance of CentralLogger
- 7443a r14628 based on trunk r14627 tested and ready for review.
- 04:19 AM Bug #7443 (WIP): performance of CentralLogger
- 7443a created.
- 07:03 AM Bug #7425: Avoid directory usage in static blocks
- Danut, try to make the initialization calls hierarchical. That is, do not list all initialization in @StandardServer@...
- 07:01 AM Bug #7425: Avoid directory usage in static blocks
- I found the following static initializers that use @directory.xml@:
* @TemporaryAccountPool@
* @WebHandler@: from t...
06/16/2023
- 09:02 AM Bug #7443: performance of CentralLogger
- Greg Shah wrote:
> What can't be slow or even as slow as a single map lookup is the @isLoggable()@.
Roger that. I... - 09:01 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> When invalidating the levels in all instances that will be a performance bottleneck, because all lo... - 02:44 AM Bug #7443: performance of CentralLogger
- When invalidating the levels in all instances that will be a performance bottleneck, because all loggers will need to...
06/15/2023
- 12:39 PM Bug #7443: performance of CentralLogger
- > Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I m...
- 12:38 PM Bug #7443: performance of CentralLogger
- > 1. Have you done performance testing on Java @isLoggable@ implementation? Think about it carefully.
All of our p... - 12:37 PM Bug #7443: performance of CentralLogger
- Galya, beside the FWD server startup, what are the condition under which a logger's level can be changed? Here I mea...
- 11:47 AM Bug #7443: performance of CentralLogger
- I'm not sure if that got understood, but all loggers should listen to the change, this means a few hundred objects wr...
- 11:41 AM Bug #7443: performance of CentralLogger
- What I'm trying to say is that listeners and more state are a bad idea. It should be implemented with @WeakReference@...
- 11:33 AM Bug #7443: performance of CentralLogger
- Also Java logger has a tree :( I wanted to implement a tree as well, but didn't have the capacity of a Java team.
- 11:24 AM Bug #7443: performance of CentralLogger
- I made an expensive mistake, that removed will improve things 3 times... Now @getLevel@ checks in 3 concurrent maps, ...
- 11:13 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> Galya B wrote:
> > To me removing 50% of the calls sounds quite right. Or am I misreading your scr... - 10:59 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
I didn't s... - 10:58 AM Bug #7443: performance of CentralLogger
- Also as I've said, I have a mistake to fix.
- 10:57 AM Bug #7443: performance of CentralLogger
- To me removing 50% of the calls sounds quite right. Or am I misreading your screenshot?
- 10:54 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
Reworking co... - 10:52 AM Bug #7443: performance of CentralLogger
- Do we have a branch here?
- 10:51 AM Bug #7443: performance of CentralLogger
- Give me 1h to rework @TransactionManager@ to my liking and see if it fixes something.
- 10:49 AM Bug #7443: performance of CentralLogger
- Constantin, I started with a similar implementation, where the state also included the level, but there are other cav...
- 10:46 AM Bug #7443: performance of CentralLogger
- @isLoggable@ is meant to be used when there is a cost with resolving the arguments passed to the @log@ method. That'...
- 10:44 AM Bug #7443: performance of CentralLogger
- Even if I bend due to pure pressure and implement it, I don't recommend using @isLoggable@ just for the sake of looki...
- 10:29 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> It doesn't matter if the same logger name is being used by multiple logger instances, th... - 10:20 AM Bug #7443: performance of CentralLogger
- Greg Shah wrote:
> Bypassing everything but the logging level check has served us well. There is a performance reas... - 10:20 AM Bug #7443: performance of CentralLogger
- Galya, the problem is not @isLoggable@ being called excessively. @canLog@ relies too on @isLoggable@, so getting rid ...
- 10:14 AM Bug #7443: performance of CentralLogger
- Bypassing everything but the logging level check has served us well. There is a performance reason those checks were...
- 10:13 AM Bug #7443: performance of CentralLogger
- This is the entire @logging@ node. The @loggers@ levels is the same from before testing with @CentralLogger@....
- 10:08 AM Bug #7443: performance of CentralLogger
- Constantin, what is the logging level you tested with on this screenshot?
- 09:50 AM Bug #7443: performance of CentralLogger
- Also let's not forget that resource consumption is part of execution of applications and this feature was not existin...
- 09:44 AM Bug #7443: performance of CentralLogger
- There is no free lunch, it's either the CPU or the RAM. If I need to work on this task, I'll remove @isLoggable@ from...
- 09:40 AM Bug #7443: performance of CentralLogger
- And we know the complexity of accessing string keyed map. Do you think the concurrency of the map adds to the CPU usage?
- 09:39 AM Bug #7443: performance of CentralLogger
- Actually the cache map should have been the first lookup in the method. This is my bad.
- 09:33 AM Bug #7443: performance of CentralLogger
- Constantin Asofiei wrote:
> We need to remove the map lookup. The log level needs to be cached at the logger instan... - 09:32 AM Bug #7443: performance of CentralLogger
- Galya B wrote:
> We can lower it to 1.8 million executions removing the unnecessary @if (LOG.isLoggable(Level.FINE))... - 09:31 AM Bug #7443: performance of CentralLogger
- ~1% of resources for 3.6 million executions sounds great to me!
Jokes aside...
We can lower it to 1.8 million e... - 08:13 AM Bug #7443: performance of CentralLogger
- @CentralLogger.isLoggable@ is called 3.6 million times when testing an application. In the profiler, this highlights...
- 08:08 AM Bug #7443 (Closed): performance of CentralLogger
- 10:52 AM Bug #7425 (WIP): Avoid directory usage in static blocks
- Danut, this is close to your work on #7388. I will do the review on caches there asap.
Please extend your research...
06/13/2023
- 02:15 AM Bug #7291: LOG-MANAGER to log on client-side
- I'll merge it with 7415c when ready.
06/12/2023
- 02:32 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> Galya, I missed something. Appserver logging must not be forced on server-side.
Well, ...
06/11/2023
- 05:59 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya, I missed something. Appserver logging must not be forced on server-side....
06/09/2023
- 10:01 AM Bug #7291: LOG-MANAGER to log on client-side
- > I can name it @merge notification for task 7291@ if there is no standard one.
That works. - 09:59 AM Bug #7291: LOG-MANAGER to log on client-side
- Fix merged to trunk as rev 14621.
- 09:53 AM Bug #7291: LOG-MANAGER to log on client-side
- I can name it @merge notification for task 7291@ if there is no standard one.
- 09:51 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg Shah wrote:
> In the future, when you post something like this that is expected to be committed immediately, pl... - 09:50 AM Bug #7291: LOG-MANAGER to log on client-side
- In the future, when you post something like this that is expected to be committed immediately, please include history...
- 09:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Diff attached. Fixes two NPEs when configs not present.
- 09:27 AM Bug #7291: LOG-MANAGER to log on client-side
- No, just post the full diff here for a quick review.
- 09:03 AM Bug #7291: LOG-MANAGER to log on client-side
- Do I create a whole new branch just for a null check?
- 06:32 AM Bug #7291 (Test): LOG-MANAGER to log on client-side
- 03:22 AM Bug #7291: LOG-MANAGER to log on client-side
- Task branch 7291a was merged to trunk as rev 14620 and archived. Email sent.
- 08:49 AM Bug #5703 (Closed): rationalize, standardize and simplify the client-side log file name configura...
- 04:35 AM Bug #7425: Avoid directory usage in static blocks
- After discussing with Constantin, mostly in regard to #7398, there are several places in FWD where the directory is r...
- 04:23 AM Bug #7425 (Test): Avoid directory usage in static blocks
06/08/2023
- 02:53 PM Bug #7291: LOG-MANAGER to log on client-side
- You can merge now.
- 11:40 AM Bug #7291: LOG-MANAGER to log on client-side
- Pushed a tiny NPE fix in r14629. Tested with gui and chui.
When do I merge? - 10:37 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> * @Utils.pollAll@ needs to return null if there is no message, there is no reason to tra... - 09:46 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> I've looked through all the changes, I don't see anything else wrong. Did you test agai... - 09:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, ... - 07:54 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin, please go ahead with reviewing the rest of the code, when you have time. I'll fix all, when you're done.
- 06:56 AM Bug #7291: LOG-MANAGER to log on client-side
- > Greg, this is not documented in the coding standards, please correct me if I'm wrong.
I think this is correct. ... - 06:43 AM Bug #7291: LOG-MANAGER to log on client-side
- Review for 7291a/14627:
* we don't usually use static imports except for interface constants. Without qualifying a ... - 06:28 AM Bug #7291: LOG-MANAGER to log on client-side
- 7291a r14627 file headers.
- 08:09 AM Feature #7418: assess the security of the Jetty web server
- And we need to differentiate between FWD server jetty and FWD client jetty.
- 08:04 AM Feature #7418: assess the security of the Jetty web server
- I think we should also document the full stack for each exposed endpoint including versions. For example for Keikai t...
- 07:59 AM Feature #7418: assess the security of the Jetty web server
- Constantin Asofiei wrote:
> * Hynek, is sheet.war starting another web server? If so, what URL is it using?
No, ... - 06:54 AM Feature #7418: assess the security of the Jetty web server
- The main internet-exposed point of FWD is the Jetty web server. This includes the web server running on the FWD serv...
- 06:45 AM Feature #7418 (New): assess the security of the Jetty web server
06/07/2023
- 07:19 PM Bug #7291: LOG-MANAGER to log on client-side
- > Do I add the file headers before or after the review?
Generally, before. It helps explain the changes which mak... - 02:21 PM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> Galya B wrote:
> > How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ i... - 09:34 AM Bug #7291: LOG-MANAGER to log on client-side
- Do I add the file headers before or after the review?
- 09:33 AM Bug #7291 (Review): LOG-MANAGER to log on client-side
- 7291a rebased on trunk r14616.
7291a r14626 tested and ready for review. - 09:31 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
... - 04:40 AM Bug #7291: LOG-MANAGER to log on client-side
- How do I configure @OSResourceManager.getInstance().isServerSideFileSystem()@ in directory.xml?
06/05/2023
- 01:20 PM Bug #7291: LOG-MANAGER to log on client-side
- A few notes:
* Java file lock is respected by other Java processes on Windows and Linux and they will wait indefinit...
06/01/2023
- 09:46 AM Bug #7291: LOG-MANAGER to log on client-side
- > Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always b...
- 07:16 AM Bug #7291: LOG-MANAGER to log on client-side
- Can we have clients running in the server JVM? Basically my question is if @ThinClient@ static fields will always be ...
- 06:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Task branch 5703d was merged to trunk as rev 14595 and archived. Email sent.
- 06:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Can you confirm this change ?
Yes, confirmed. It is a matter of preference. Some will like the change, some wi... - 05:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also most FWD devs trace issues on the console, while I do it using the files, so my opinion may differ based on that...
- 04:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> In @LoggingUtil@ please set @SORTABLE_DATETIME_FORMAT@ to "%tY%tm%td_%tH%tM%tS". It just condens...
05/31/2023
- 03:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Code Review Task Branch 5703d Revisions 14593 and 14594
The changes are good.
In @LoggingUtil@ please set @SORT... - 02:09 PM Bug #7291: LOG-MANAGER to log on client-side
- I'm fine with the plan.
- 12:25 PM Bug #7291: LOG-MANAGER to log on client-side
- Then what about making the design as simple and and clear as possible.
* @LOG-MANAGER@ will live on the server and t... - 09:06 AM Bug #7291: LOG-MANAGER to log on client-side
- We need to move ahead with this task. We cannot assume that all customers can use server-side logging for @LOG-MANAG...
05/30/2023
- 12:21 PM Bug #7291: LOG-MANAGER to log on client-side
- Pause the work while I consider what we lose by dropping this.
- 11:37 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg, I think LOG-MANAGER client-side implementation will end up:
* very fragile;
* with multiple rpc calls for one... - 08:24 AM Bug #7291: LOG-MANAGER to log on client-side
- Greg, it's not that I'm lazy, but it really doesn't make sense to have LOG-MANAGER client-side. It's way too intertwi...
- 08:19 AM Bug #7291: LOG-MANAGER to log on client-side
- Constantin Asofiei wrote:
> This is what I meant. It may work if all the validation/checks (which can raise OE erro... - 08:12 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> ... but there are plenty of OE errors in initialization and the setters.
This is what I meant. It... - 08:11 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya B wrote:
> but there are plenty of OE errors in initialization and the setters.
... which is (as we already... - 08:09 AM Bug #7291: LOG-MANAGER to log on client-side
- There are no Java exceptions thrown, but there are plenty of OE errors in initialization and the setters.
It just ... - 07:51 AM Bug #7291: LOG-MANAGER to log on client-side
- Galya, is there any condition which can be raised by any APIs which would use state sync? If this is so, then we must...
- 05:00 AM Bug #7291: LOG-MANAGER to log on client-side
- State sync doesn't seem to work well. On top of the the six getters, the following methods should also return a value...
- 08:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Galya B wrote:
> Are you using a real Windows system?
I set up a VirtualBox VM, here is t... - 08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm th... - 02:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, I always have troubles with Windows builds, but when that is out of the way I can confirm that the latest trun...
- 02:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Have you been able to run hotel_gui on Windows? I am having a lot of trouble getting clien...
05/29/2023
- 02:40 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> The Jetty info msg is not causing issues on any deployments. Do you still have this issue and can y... - 01:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703d r14593 loggers to fallback to the default log file name if the provided path is invalid (can't be created or no...
- 10:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a warning about th...
- 06:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Can you define @fail gracefully@? It will in all cases produce a crash log and the log does have a ... - 03:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote (#7378-909):
> Galya: The NPE is a bug that needs to be fixed. It needs to fail gracefully instead o... - 03:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Well the result is the server no longer functions. This is on a Windows VM for which I have ...
05/26/2023
- 10:31 AM Bug #7291: LOG-MANAGER to log on client-side
- The state sych honors the order of operations because of these facts:
# The execution of code is effectively singl... - 08:45 AM Bug #7291: LOG-MANAGER to log on client-side
- Now that I think more about it, the whole merge-two-sources-of-events-and-execute-them thing is problematic. It can't...
- 08:32 AM Bug #7291: LOG-MANAGER to log on client-side
- How are supposed getters to work with state sync? I can create events for initialization, attr setters, write log rec...
05/24/2023
- 08:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> This is a @Jetty@'s message, may be a new one to our logs; with the proper @slf4j@ support now 3rd ... - 02:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> From what I researched, this means that the JVM doesn't support JPMS, which was introduced i...
05/23/2023
- 01:54 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Yes, all messages are always logged / sent to the listening server process, where they are filtered... - 11:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> DB import shows lots of INFO statements like:
> [...]
>
> These need to be lowered.
... - 09:03 AM Bug #5703 (Test): rationalize, standardize and simplify the client-side log file name configuration
- Task branch 5703c merged to trunk as rev 14583 and archived. Email sent. Logs wiki updated.
- 08:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Constantin Asofiei wrote:
> Galya, please double-check the module name for all files changed in 5703c and also the h... - 08:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, please double-check the module name for all files changed in 5703c and also the history number:
* history num... - 07:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I need a dedicated tester only for the headers... Maybe we need automated tests.
@CentralLoggerClientConfigs@ was ... - 07:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- * @LegacyLogManagerConfigs@ - still needs history entry
* @CentralLogger@ - there are only two trunk commits in this... - 07:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- It may look weird, but it's not so bad, see:
Constantin Asofiei wrote:
> Galya, review for 5703c rev 14585:
> * ... - 07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya, review for 5703c rev 14585:
* @CentralLogger@ - only a history number is needed, like this:... - 06:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c rebased on trunk r14579.
- 06:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c r14578 Fixed unused variable ‘j’ in spawn.c
- 06:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I think we hold off for now. Let's finalize 5703c and get it merged today.
I don't have anythin... - 06:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Do you know what, Greg! This was an awesome example of why @INFO@ level is so much needed for all logging. How otherw...
- 06:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > If it's a simple fix, someone can upload it to this branch. I'm not sure what needs to be done.
I think we hold ... - 06:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Is this to be solved in another task?
Yes, see #7377. - 06:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Is this to be solved in another task?
I think the related code was introduced with #2124 @bzr di... - 06:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> The core issue (already existing, not created by the logging changes) is that we are loading the ... - 06:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya B wrote:
> Roger, on executing @./server.sh -k@ with my configs now I get only:
> [...]
> But this was there... - 05:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, on executing @./server.sh -k@ with my configs now I get only:...
- 05:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- 5703c r14577 is up:
* Sets a default of WARNING to @SecurityCache@, when no explicit logging configs available for t... - 03:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger, thank you for reporting the inconsistencies. The messages you've seen are generated by @SecurityCache@ on leve...
- 02:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > As far as I can see the debug level now is always on maximum. Sh... - 06:31 AM Bug #7377: ServerDriver.connect() should not force server-mode to be turned on
- As discussed in #5703-608 and previous notes, the @ServerDriver.connect()@ will call @bc.setSever(true)@ and try to l...
- 06:30 AM Bug #7377: ServerDriver.connect() should not force server-mode to be turned on
- Check #5703#note-610.
- 06:27 AM Bug #7377 (New): ServerDriver.connect() should not force server-mode to be turned on
- 05:45 AM Bug #7375: Prevent spoofed logs in CentralLogger
- Outside code can use @CentralLogger@ to create an instance of any @com.goldencode@ or anonymous (root) logger and use...
- 05:45 AM Bug #7375 (New): Prevent spoofed logs in CentralLogger
Also available in: Atom