Project

General

Profile

Activity

From 04/19/2024 to 05/18/2024

05/14/2024

04:45 PM Feature #6692: move FWD to Java 17
In each of these testing processes, please use the details in [[p2j:Switching_Between_Java_8_and_Java_17]] to migrate... Greg Shah
04:40 PM Feature #6692: move FWD to Java 17
The final phase of testing for 6692a is starting now. When each of the following are resolved, we will merge to trun... Greg Shah
09:08 AM Feature #6692: move FWD to Java 17
I've pushed @6692a/15240@ based on current @trunk/15205@ I guess which is ready for testing.
Please review commits 1... Tomasz Domin
08:24 AM Bug #8624: Stream should detect whether it is being used from the client or the server
Greg, what do I need to do in order to do server side stream operations? I noticed some setup steps from #4065, besid... Șerban Bursuc

05/13/2024

01:43 PM Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Tomasz Domin wrote:
> > Roger Borrello wrote:
> > > Tomasz Domin wrote:
> > > > I guess t... Tijs Wickardt
01:13 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Roger Borrello wrote:
> > Tomasz Domin wrote:
> > > I guess that was already planned to be c... Roger Borrello
01:03 PM Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Tomasz Domin wrote:
> > I guess that was already planned to be changed as @hotel_gui@ has a... Tomasz Domin
12:29 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> I guess that was already planned to be changed as @hotel_gui@ has already that change implemen... Roger Borrello
11:56 AM Feature #6692: move FWD to Java 17
I had some issues with FWD @build.gradle@ as it is using @javascript@ which is no longer available in JVM since JDK15... Tomasz Domin

05/09/2024

07:58 AM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> I have just pushed @6692a/15188@ with following updates:
>
> Next steps:
> - updating docu... Tomasz Domin

05/08/2024

06:04 AM Feature #6692: move FWD to Java 17
I have just pushed @6692a/15188@ with following updates:
* Support for versioned JS dependencies in @ReportWebServ... Tomasz Domin

05/06/2024

01:52 PM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > A remark - I don't think any of customer application would be ready for Java 17 right away - th... Eric Faulhaber
02:52 AM Bug #8206: Logging manager issues
Otherwise I'm ok with the changes. Galya B
02:52 AM Bug #8206: Logging manager issues
Vladimir Tsichevski wrote:
> This is the response on the #8206-11 finding and needs to be tested. I am not sure it w... Galya B

05/03/2024

05:41 PM Feature #6692: move FWD to Java 17
> > Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Record@ in converted... Greg Shah
05:12 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Greg Shah wrote:
> > Are you saying code changes are needed? I don't think we expose @com.go... Eugenie Lyzenko
04:00 PM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Reco... Tomasz Domin
07:58 AM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Tomasz Domin wrote:
> > * test customer applications for regression - the most important appl... Eugenie Lyzenko
06:03 AM Feature #6692: move FWD to Java 17
> A remark - I don't think any of customer application would be ready for Java 17 right away - they most probably nee... Greg Shah
04:52 AM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> * test customer applications for regression - the most important applications - I guess we nee... Tomasz Domin
10:55 AM Bug #8206: Logging manager issues
Galya B wrote:
> Vladimir Tsichevski wrote:
> > Log manager initialization fixed in 8206a rev. 15197. Please, revie... Vladimir Tsichevski
09:44 AM Bug #8206: Logging manager issues
Vladimir Tsichevski wrote:
> Log manager initialization fixed in 8206a rev. 15197. Please, review.
I'm not sure i... Galya B
09:21 AM Bug #8206 (Review): Logging manager issues
Log manager initialization fixed in 8206a rev. 15197. Please, review. Vladimir Tsichevski
06:29 AM Bug #8206 (WIP): Logging manager issues
OK, I'll rebase the branch and add the missing change. Vladimir Tsichevski
01:21 AM Bug #8206: Logging manager issues
Actually Vladimir is better familiar with these issues and has more insight on what needs to be achieved.
Vladimir... Galya B

05/02/2024

02:33 PM Feature #6692: move FWD to Java 17
Also I've found Java doc issue:... Eugenie Lyzenko
03:10 AM Feature #6692: move FWD to Java 17
From Tomasz via email:
You need to add -Djava.locale.providers=SPI,CLDR,COMPAT instead of and put fwdcpi.jar on a ... Constantin Asofiei
01:24 PM Bug #8206: Logging manager issues
Greg Shah wrote:
> Code Review Task Branch 8206a Revisions 14987 through 14992
> Vladimir/Galya: I understand tha... Vladimir Tsichevski
10:54 AM Bug #8206: Logging manager issues
With Theodoros gone, this will need to be rebased, tested and merged by someone else. Greg Shah
10:53 AM Bug #8206 (Internal Test): Logging manager issues
Code Review Task Branch 8206a Revisions 14987 through 14992
I have no objections to the changes.
As far as I kn... Greg Shah
07:55 AM Bug #7589 (Closed): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah
07:52 AM Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
This can be closed. We've delivered a way to disable the FWD's slf4j impl what was the issue. Galya B
06:32 AM Feature #8708 (Closed): cleanup of SLF4J
All the reported issues are resolved. Nice! Greg Shah
03:20 AM Feature #8708 (Test): cleanup of SLF4J
8708a was merged to trunk as rev. 15185 and archived. Galya B
02:27 AM Feature #8708: cleanup of SLF4J
Galya B wrote:
> Hynek Cihlar wrote:
> > Tested, it looks OK.
>
> Did you find any slf4j message from tika in th... Hynek Cihlar
02:01 AM Feature #8708: cleanup of SLF4J
Hynek Cihlar wrote:
> Tested, it looks OK.
Did you find any slf4j message from tika in the client log? Galya B

05/01/2024

06:55 PM Feature #6692: move FWD to Java 17
The first results for using Java 17 with big GUI application.
1. Conversion was completed. Build compiled.
2. The... Eugenie Lyzenko
09:27 AM Feature #6692: move FWD to Java 17
Yes, Hotel GUI in SSO mode works in trunk. Embedded mode does have a bug (see #8253) but it is not related to SSO. Greg Shah
09:24 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> Eugenie Lyzenko wrote:
> > Do you have worked @SSO@ enabled @Hotel GUI@ for *Web* client with curr... Eugenie Lyzenko
09:17 AM Feature #6692: move FWD to Java 17
P.S.S. I use SSO with trunk and testcases every week. Galya B
09:16 AM Feature #6692: move FWD to Java 17
P.S. SSO is working only for *Web*. And embedded doesn't work without SSO. Galya B
09:15 AM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> Do you have worked @SSO@ enabled @Hotel GUI@ for *Web* client with current @FWD@ trunk?
I'... Galya B
09:13 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> Eugenie Lyzenko wrote:
> > This was due to not configured SSO for hotel GUI. I disabled SSO and it... Eugenie Lyzenko
09:05 AM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> This was due to not configured SSO for hotel GUI. I disabled SSO and it works now.
Intrigu... Galya B
06:07 AM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Eugenie Lyzenko wrote:
> > Eugenie Lyzenko wrote:
> > > Roger Borrello wrote:
> > > > Eugenie ... Eugenie Lyzenko
03:43 AM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> Eugenie Lyzenko wrote:
> > Roger Borrello wrote:
> > > Eugenie Lyzenko wrote:
> > > > Ha... Greg Shah
10:11 PM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> Roger Borrello wrote:
> > Eugenie Lyzenko wrote:
> > > Have you tested @hotel_gui@ with w... Eugenie Lyzenko
08:46 PM Feature #6692: move FWD to Java 17
OK. To start application with Java 8 we need to add at least the following into @build.gradle@:... Eugenie Lyzenko
08:45 PM Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > Have you tested @hotel_gui@ with web client and Java 8? In my ca... Eugenie Lyzenko
08:41 PM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> Have you tested @hotel_gui@ with web client and Java 8? In my case the client session can n... Roger Borrello
03:44 PM Feature #8708 (Merge Pending): cleanup of SLF4J
It can merge to trunk. Greg Shah
03:37 PM Feature #8708: cleanup of SLF4J
Hynek Cihlar wrote:
> There are vulnerabilities in all the previous versions. We should stick to 2.9.x. I'll test if... Hynek Cihlar
03:17 PM Feature #8708: cleanup of SLF4J
Galya B wrote:
> Greg Shah wrote:
> > What do you mean? Jetty is working on those systems.
>
> The logging is b... Hynek Cihlar
02:28 PM Feature #8708: cleanup of SLF4J
Greg Shah wrote:
> What do you mean? Jetty is working on those systems.
The logging is broken.
Another way to... Galya B
02:14 PM Feature #8708: cleanup of SLF4J
What do you mean? Jetty is working on those systems. Greg Shah
02:13 PM Feature #8708: cleanup of SLF4J
Greg Shah wrote:
> If this breaks the tika code, then we can't merge it because we have a customer using it in real ... Galya B
02:12 PM Feature #8708: cleanup of SLF4J
If 6692a resolves this, then we may have to wait for it. We are literally trying to get Java 17 into trunk next week... Greg Shah
02:11 PM Feature #8708: cleanup of SLF4J
If this breaks the tika code, then we can't merge it because we have a customer using it in real life. Greg Shah
01:59 PM Feature #8708: cleanup of SLF4J
Greg Shah wrote:
> We're sure that the tika parser code we are using doesn't require slf4j?
It uses a new version... Galya B
01:48 PM Feature #8708: cleanup of SLF4J
We're sure that the tika parser code we are using doesn't require slf4j? Greg Shah
01:38 PM Feature #8708: cleanup of SLF4J
Can we merge this soon, because it's too annoying? Galya B
10:07 AM Feature #8708 (Review): cleanup of SLF4J
Galya B
10:07 AM Feature #8708: cleanup of SLF4J
8708a r15183 based on trunk r15182: remove the transitive dependency of @slf4j-api:2.0.10@ from @tika-core@.
Diff ... Galya B
09:48 AM Feature #8708 (WIP): cleanup of SLF4J
... Galya B
08:52 AM Feature #8708: cleanup of SLF4J
Someone did something... wasn't me and this should have never appeared.
This warnings @Class path contains SLF4J b... Galya B
07:56 AM Feature #8708: cleanup of SLF4J
As of trunk rev 15182, you can see the following.
1. During FWD build, there is this:... Greg Shah
07:43 AM Feature #8708 (Closed): cleanup of SLF4J
Greg Shah
10:42 AM Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
8656a was merged to trunk as rev. 15183 and archived. Galya B
10:29 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
You can merge to trunk now. Greg Shah
10:11 AM Bug #8656 (Merge Pending): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pd...
Hynek Cihlar
09:53 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
I did a comparison of the original behavior and output and the new one and shared the results in #8656-8. I can do mo... Galya B
09:50 AM Bug #8656 (Internal Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pd...
Galya B wrote:
> Hynek Cihlar wrote:
> > The code changes remove the zipping part for the split pdfs. Was this part... Hynek Cihlar
08:44 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Hynek Cihlar wrote:
> The code changes remove the zipping part for the split pdfs. Was this part of the requirements... Galya B
06:25 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Code review 8656a revisions 15156..15159.
The code changes remove the zipping part for the split pdfs. Was this pa... Hynek Cihlar
04:18 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Sergey/Hynek: Please review. Greg Shah
01:24 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Sergey Ivanovskiy wrote:
> Galya B wrote:
> > A side observation is that the server struggles with such big data wh... Galya B

04/30/2024

07:29 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Branch @6692a@ has been tested with @hotel_gui@, @hotel_chui@ and standard regression testing ... Eugenie Lyzenko
04:56 PM Feature #6692: move FWD to Java 17
Seems like I have new issue:... Eugenie Lyzenko
03:03 PM Feature #6692: move FWD to Java 17
I've tried ETF, but a suite gets into an infinite loop, while one passes. This was with Java 8 conversion and Java 1... Constantin Asofiei
01:43 PM Feature #6692: move FWD to Java 17
Branch @6692a@ has been tested with @hotel_gui@, @hotel_chui@ and standard regression testing suite. But it seems tha... Tomasz Domin
01:22 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Eugenie Lyzenko wrote:
>
> > I'm going to check Java 17 now. Is the code converted with Jav... Eugenie Lyzenko
12:18 PM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> I'm going to check Java 17 now. Is the code converted with Java 8 compatible with Java 17... Tomasz Domin
12:15 PM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Eugenie Lyzenko wrote:
> > Attempting to use @6692a@ with Java 8 causes exceptions:
> >
> ... Eugenie Lyzenko
12:12 PM Feature #6692: move FWD to Java 17
Eugenie Lyzenko wrote:
> Attempting to use @6692a@ with Java 8 causes exceptions:
>
> [...]
>
> Is it expected... Tomasz Domin
12:01 PM Feature #6692: move FWD to Java 17
Attempting to use @6692a@ with Java 8 causes exceptions:... Eugenie Lyzenko
03:32 PM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Galya B wrote:
> A side observation is that the server struggles with such big data when generating the report (@Rep... Sergey Ivanovskiy
02:29 PM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
A side observation is that the server struggles with such big data when generating the report (@ReportsManager.buildR... Galya B
02:24 PM Bug #8656 (Review): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pd...
8656a r15159 based on trunk r15156 ready for review.
@jPod@ was originally used only for merging big pdf documents... Galya B
02:15 PM Bug #8656 (WIP): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Galya B
07:57 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
The @ant report_server@ is related to FWD Analytics and is not related to @ReportServlet@ from our admin console. Th... Greg Shah
07:50 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
@ant report_server@ gives a lot of errors and eventually fails. Ends up with:... Galya B
05:16 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
But ReportServlet is from FWD Admin console - for that try admin/test123. Constantin Asofiei
05:15 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
I assume you've ran the report tasks? The default user is admin and the default password is the app's name as config... Constantin Asofiei
05:04 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
What is the user / pass for the reporting login in testcases? I tried admin/admin, but I get @socket closed (1011) - ... Galya B

04/29/2024

04:33 PM Bug #8206 (Review): Logging manager issues
Theodoros Theodorou

04/25/2024

04:24 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> Galya, 8383a/15059 does not compile.
The notorious @gradlew all@ doesn't work, while ... Galya B
04:14 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Galya, 8383a/15059 does not compile. Constantin Asofiei

04/23/2024

04:04 PM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > > Also, a question, since I may have missed a detail... are there changes to be made in the @cl... Tomasz Domin
02:47 PM Feature #6692: move FWD to Java 17
> > Also, a question, since I may have missed a detail... are there changes to be made in the @client.sh@ and/or @ser... Greg Shah
12:30 PM Feature #6692: move FWD to Java 17
Galya B wrote:
> We'll have to revert to cleanup, because the new mechanism of loading will have the default as part... Roger Borrello
11:47 AM Feature #6692: move FWD to Java 17
Roger Borrello wrote:
> Also, a question, since I may have missed a detail... are there changes to be made in the @c... Galya B
11:44 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> But I remembered a few more places that need update. The default @"fwd-slf4j"@ in @ClientBuilderOpt... Roger Borrello
11:30 AM Feature #6692: move FWD to Java 17
It could be an option if needed later on. For now I think it's not necessary. But I remembered a few more places that... Galya B
11:23 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Tomasz Domin
10:35 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4... Galya B
10:21 AM Feature #6692: move FWD to Java 17
OK, just one last clarification: Can you override the service loader with an empty property @-Dslf4j.provider=@? Galya B
10:19 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.... Tomasz Domin
08:57 AM Feature #6692: move FWD to Java 17
Tomasz, can you test if the property overwrites the service loader? If it works, it should be fine.
Also, to make ... Galya B
08:48 AM Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> I've added @CentralSlf4jProvider@ as service and it seems changes to @server.sh@ are not neede... Galya B
07:27 AM Feature #6692: move FWD to Java 17
Updated the patch, I needed to put a correct name into @build.xml@ Tomasz Domin
07:03 AM Feature #6692: move FWD to Java 17
Galya B wrote:
> From https://www.slf4j.org/faq.html#changesInVersion200
> > In SLF4J 2.0.x and later, during its i... Tomasz Domin
02:15 AM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> > Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Ds... Galya B
03:08 PM Feature #8651: Centralize inclusion of JS dependencies
> If there is such a case where customers want an embedded mode with a standard front-end, it makes sense to keep the... Greg Shah
02:32 AM Feature #8651: Centralize inclusion of JS dependencies
Greg Shah wrote:
> Nice analysis!
>
> I'm generally OK with the overall recommendations.
>
> > Decouple @hotel... Galya B

04/22/2024

07:23 PM Feature #8651: Centralize inclusion of JS dependencies
Nice analysis!
I'm generally OK with the overall recommendations.
> Decouple @hotel_gui@ from the server depend... Greg Shah
09:01 AM Feature #8651: Centralize inclusion of JS dependencies
There are a few places where js is used in FWD:
* On the default login page for Virtual Desktop and Embedded modes: ... Galya B
06:56 PM Feature #6692: move FWD to Java 17
> Attached a patch to @hotel_gui@ to make slf4j2 logging work (basically following property @-Dslf4j.provider=com.go... Greg Shah
04:38 PM Feature #6692: move FWD to Java 17
* Rebased to @trunk/15157@
* upgraded com.google.gwt/org.gwtproject dependencies
* reverted org.apache.pdfbox to la... Tomasz Domin
03:09 PM Feature #6692: move FWD to Java 17
Greg Shah wrote:
> The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be ... Tomasz Domin
02:31 PM Feature #6692: move FWD to Java 17
The logging patch looks reasonable. Tomasz: do you have any objections? If not, this should be committed into 6692a... Greg Shah
07:16 AM Feature #6692: move FWD to Java 17
As for the js dependencies, it seems the reporting server uses the resources from the jar, so they should stay, but a... Galya B
06:40 AM Feature #6692: move FWD to Java 17
Find attached the required changes to fix the logging dependencies and migrate slf4j implementation to version 2. Aft... Galya B
02:25 AM Feature #6692: move FWD to Java 17
I've noticed a few issues with the logging dependencies:
* @org.slf4j:jcl-over-slf4j:1.7.36@ is replaced by @org.slf... Galya B

04/19/2024

10:04 AM Bug #8656: Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Dependency @de.intarsys.opensource:jPod@ is used only in @ReportServlet.java@ and can be replaced by @org.apache.pdfb... Galya B
10:01 AM Bug #8656 (Test): Dependency de.intarsys.opensource:jPod to be replaced by org.apache.pdfbox:pdfbox
Galya B
 

Also available in: Atom