Alexandru Lungu's activity
From 07/14/2025 to 08/12/2025
08/12/2025
- 08:38 AM Base Language Bug #8273 (Internal Test): avoid ErrorConditionException for FIND ... NO-ERROR if no record is found
- I am OK with the changes in 8273a.
- 08:22 AM Database Bug #10390: FIND FIRST buffer field change does not propagate into the next FIRST FIRST statements.
- Ah, I see. The DMO is updated and validated. It is inserted in the @RecordNursery@ for future use. It is required at ...
- 08:14 AM Database Bug #10390: FIND FIRST buffer field change does not propagate into the next FIRST FIRST statements.
- Teodor, there is a particularity of FIND unique in the sense that if there are ambiguous results, calling @AMBIGUOUS ...
08/11/2025
- 07:37 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- > I am starting to do internal testing and I will tell if there is a problem.
I am OK with the plan. - 06:55 AM Database Bug #10337 (Test): Possible memory leak with FastFindCache
- 06:25 AM Database Bug #10337: Possible memory leak with FastFindCache
- Please merge 10337b to trunk after 10004a.
- 06:54 AM Base Language Bug #10004 (Test): NativeInvoker fails if an argument is of type integerConstant
- 06:15 AM Base Language Bug #10004 (Merge Pending): NativeInvoker fails if an argument is of type integerConstant
- Please merge 10004a to trunk after 10309b
- 06:52 AM Database Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
- Teodor, is this ready to be merged?
- 06:52 AM Base Language Feature #9448: compatibility test security features
- Teodor, is this ready to be merged?
- 06:13 AM Base Language Bug #10309: DATASET WRITE-JSON does not change value for a property
- After merge, please also add some tests with:
* output into memptr variable (i.e. @def var m as memptr.@, @ds:writ... - 06:08 AM Base Language Bug #10309 (Merge Pending): DATASET WRITE-JSON does not change value for a property
- 06:08 AM Base Language Bug #10309: DATASET WRITE-JSON does not change value for a property
- Please merge 10309b to trunk now.
- 04:28 AM Base Language Bug #10309 (Internal Test): DATASET WRITE-JSON does not change value for a property
- I don't have full expertise to review these changes, but as they are decremental in relation to 10309a, I suppose the...
- 03:59 AM Database Bug #10285 (Merge Pending): Static compound query returns no result
- Please merge 10285a to trunk now.
08/08/2025
- 11:07 AM Database Bug #10360 (Internal Test): FOR loop WHERE condition evaluation issue
- Nevermind. I think the code in #10360 is a super weird edge case....
- 11:01 AM Database Bug #10360 (WIP): FOR loop WHERE condition evaluation issue
- Teodor Gorghe wrote:
> I have one question which I've didn't found the answer: Why @ErrorManager.displayError@ is us... - 10:46 AM Base Language Bug #10284 (Test): JSON import error handing improvement
- Branch 10284a was merged to trunk revision 16102 and archived.
- 10:45 AM Base Language Bug #10284 (Merge Pending): JSON import error handing improvement
- 07:56 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
- Given that 10193a reached trunk, can we proceed with testing with this?
- 07:01 AM Database Bug #10337 (Merge Pending): Possible memory leak with FastFindCache
- > I also monitored memory allocation over time, it seems ok. There are still an excessive amount of nodes created and...
- 04:03 AM Base Language Bug #10366 (Merge Pending): ObjectOps.invokeStandalonePoly does not change output parameter value
- Please merge 10366a to trunk *after* 10356a.
- 04:03 AM Base Language Bug #10356 (Merge Pending): Invalid logical value: should throw error instead of warning
- Please merge 10356a to trunk *after* 10336a.
- 04:02 AM Base Language Bug #10336 (Merge Pending): Issue on object deletion: java.lang.IllegalStateException
- Please merge 10336a to trunk *after* 10309a.
- 04:02 AM Base Language Bug #10309 (Merge Pending): DATASET WRITE-JSON does not change value for a property
- Please merge 10309a to trunk *after* 10308a.
- 04:02 AM Base Language Bug #10308 (Merge Pending): DYNAMIC TEMP-TABLE issue when using READ-XML before TEMP-TABLE-PREPARE
- Please merge 10308a to trunk *after* 9055a.
- 04:00 AM User Interface Feature #9055: server-side processing of client platform dependencies in the UI
- Please merge 9055a to trunk now.
08/07/2025
- 06:51 AM Database Bug #10337: Possible memory leak with FastFindCache
- > I just realized that we don't actually need the values in the lruCache, it acts more like a queue, so only the node...
- 04:32 AM Database Bug #10337: Possible memory leak with FastFindCache
- Artur Școlnic wrote:
> I think the issue is that bulk invalidation where entire caches are cleared or removed do not...
08/06/2025
- 09:01 AM Database Bug #10337: Possible memory leak with FastFindCache
- > I think we are still leaking memory, after one hour or running Harness on loop, there are 500k 'live' Node objects,...
- 07:24 AM Database Bug #10337 (Internal Test): Possible memory leak with FastFindCache
- Review of 10337b:
* @hash = hashCode();@ and @public int hashCode() { return hash; }@ is not correct.
* there is ... - 06:19 AM Database Bug #10337: Possible memory leak with FastFindCache
- > You are right, this also caused the issue from note 43. After fixing this problem, the Nodes are kept at a reasonab...
- 05:15 AM Database Bug #10337: Possible memory leak with FastFindCache
- * Please make @Node@ class static again.
* short-circuit @equals@ so that @this == o@ returns true directly.
* *Imp... - 08:45 AM Conversion Tools Feature #5586 (Merge Pending): move all conversion artifacts/outputs into the cvtdb or into a ded...
- Please merge 5586a to trunk now.
- 05:21 AM Database Bug #6923 (Pending): inner transaction block reverts too much
- I integrated 6923a into 8388a as these changes alone are dependent upon record nursery proper rollbacking (which was ...
08/05/2025
- 08:29 AM Database Feature #9456: implement SQL Server dialect and helpers
- Constantin Asofiei wrote:
> Alexandru, is this something which prevents 9456b to be merged to trunk? Does it affect ... - 08:02 AM Database Feature #9456: implement SQL Server dialect and helpers
- I reviewed the changes and @toWhereExpendedNullExpression@ seems safe for all dialects. The things that drove the COA...
- 06:58 AM Database Feature #9456: implement SQL Server dialect and helpers
- Ah nevermind, is the one added at the beginning for @withNull@.
- 06:57 AM Database Feature #9456: implement SQL Server dialect and helpers
- Eduard, in @toWhereExpendedNullExpression@, isn't the last parenthesis unbalanced? You have @whereClause.append(" or ...
- 08:24 AM Database Bug #10337: Possible memory leak with FastFindCache
- Review of 10337b:
* add braces to the lambda inside @ReverseLookup@ c'tor
* Indent @lruCache@ javadoc (/** shouldn'... - 05:02 AM Database Bug #10337: Possible memory leak with FastFindCache
- Review of 10337b/16074:
* rewrite @reverseLookup.lruCache.get(new ReverseLookup.Node(l3Cache, k.k2));@ to @reverse...
08/04/2025
- 07:50 AM Database Feature #9456: implement SQL Server dialect and helpers
- > Not only for that, there are cases when user defined where clause might be different in SqlServer dialect and H2 bu...
- 05:14 AM Database Feature #9456: implement SQL Server dialect and helpers
- Review of 9456b:
* I see plenty of @isLimitBeforeOffset@ checks that alter the behavior of persistence code. Sometim... - 04:41 AM Database Bug #10360: FOR loop WHERE condition evaluation issue
- IMHO, there are multiple issues here:
* if no records actually "hit" the faulty clause, no error is thrown.
** if t...
08/01/2025
- 07:19 AM Database Bug #6923: inner transaction block reverts too much
- > Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be merged to fwd-h2 trunk (an...
- 06:57 AM Database Bug #6923: inner transaction block reverts too much
- > What happens at this step in FWD, when the sub-tx is rollbacked? I assume the record is removed completely from the...
- 06:22 AM Database Bug #6923: inner transaction block reverts too much
- > I think if a row is added to the scan index, then all indexes need to see this row.
My code is mostly like @getN... - 06:20 AM Database Bug #6923: inner transaction block reverts too much
- > Alexandru, how is reclaimPrimaryKey supposed to be used?
I can agree that my implementation was quite aggresive.... - 05:43 AM Database Bug #6923: inner transaction block reverts too much
- Constantin, just a reminder. Please review 6923a_h2/60. I want to merge it to FWD_H2 trunk and eventually make a rele...
- 06:06 AM Database Bug #10337: Possible memory leak with FastFindCache
- ...
- 05:52 AM Database Bug #10337: Possible memory leak with FastFindCache
- > Map<RecordIdentifier<String>, LRUList<L2Key>> reverseLookup = new WeakHashMap<>();
Considering the L3 cache for ... - 05:35 AM Database Bug #10337: Possible memory leak with FastFindCache
- > I think that if we make the reverseLookup a LRU cache with weak referenced keys, we can unbound the L3 cache.
Te...
07/31/2025
- 06:25 AM Database Bug #10337 (WIP): Possible memory leak with FastFindCache
- Artur, please reassess #10337-14 issue and #10337-19 idea. ReverseLookup collections are a 2D caches. Introducing a L...
07/30/2025
- 07:07 AM Database Bug #10337: Possible memory leak with FastFindCache
- > I think that the memory leak in 9802f was caused mainly by the absence of a designated ExpiryListener for the empty...
- 03:44 AM Database Bug #10337: Possible memory leak with FastFindCache
- In fact, I think there is a small caveat. We still need a @touch@ mechanism so that the LRU cache will mark the @Node...
- 03:31 AM Database Bug #10337 (WIP): Possible memory leak with FastFindCache
- 03:31 AM Database Bug #10337: Possible memory leak with FastFindCache
- Review of 10337b:...
07/29/2025
- 08:41 AM Base Language Bug #10277 (Internal Test): Adaptive Query REPOSITION statement/method error handling improvement
- I am OK with the changes.
- 08:31 AM Base Language Bug #10277: Adaptive Query REPOSITION statement/method error handling improvement
- > queryReposition implementation was simple, but there is queryRepositionByID(rowid[]) which has a little bit more lo...
- 07:38 AM Base Language Bug #10277: Adaptive Query REPOSITION statement/method error handling improvement
- > Alexandru, can you take a look, too, please?
Hmm, I was inclining to share the concern of #10277-15. But honestl... - 07:06 AM Base Language Bug #8273: avoid ErrorConditionException for FIND ... NO-ERROR if no record is found
- Please add any reproduction of these problems to the suite of unit tests you made for #8273 changes.
07/28/2025
- 07:11 AM Base Language Feature #10290 (Merge Pending): Add support for character string literals options
- Please merge 10290a to trunk *after* 9863a.
- 07:10 AM Conversion Tools Bug #9863 (Merge Pending): Fileset eXclude broken on native Windows
07/25/2025
- 08:18 AM Database Bug #10337 (WIP): Possible memory leak with FastFindCache
- I identified the culprit for the real memory leak:
* there is a FIND done in a @while true@
* first time is inser...
07/24/2025
- 10:16 AM Database Bug #6923: inner transaction block reverts too much
- > A new direct-access API to reclaim a PK. This is used for rollbacked records that were flushed, but reverted back t...
- 10:15 AM Database Bug #10337 (Merge Pending): Possible memory leak with FastFindCache
- Please merge to trunk.
- 10:06 AM Database Bug #10337 (Internal Test): Possible memory leak with FastFindCache
- I am OK with the changes. Please proceed with regression testing.
- 10:00 AM Database Bug #10337: Possible memory leak with FastFindCache
- ...
- 09:35 AM Database Bug #10337: Possible memory leak with FastFindCache
- Review of 10337a.
* The fix is almost complete. You are missing the cases where @resolved[i] = ((Resolvable) subst).... - 08:52 AM Database Bug #10337: Possible memory leak with FastFindCache
- PS: this is not caused directly by #9802, but rather a latent bug that is exposed by more "intensive" caching.
- 08:49 AM Database Bug #10337 (WIP): Possible memory leak with FastFindCache
- Artur, I think I identified a reason for a memory leak for the changes. This is only based on static analysis.
The... - 08:40 AM Database Bug #10337 (Test): Possible memory leak with FastFindCache
- 04:04 AM Database Feature #10094 (Merge Pending): RECIDs from different tenants of same logical database should not...
- > Ovidiu/Alexandru, 10094a needs to be merged today, if we plan to push to xfer.
This can be merged now.
07/23/2025
- 04:16 AM Base Language Bug #8273 (Internal Test): avoid ErrorConditionException for FIND ... NO-ERROR if no record is found
- I am OK with the changes. Please proceed with comprehensive testing.
07/21/2025
- 10:47 AM Database Bug #6923: inner transaction block reverts too much
- Committed xfer/testcases rev. 1792 with my unit tests for this. "safe" suites are ones that are cut-out in terms of p...
- 10:43 AM Database Bug #6923 (Review): inner transaction block reverts too much
- I committed 6923a/16047 and 6923a/16048 with:
* Fixed re-reserving of the PK after rollbacking flushed NEW records (... - 05:06 AM Base Language Bug #8273: avoid ErrorConditionException for FIND ... NO-ERROR if no record is found
- Review of 8273a:...
07/18/2025
- 10:07 AM Database Bug #6923: inner transaction block reverts too much
- What I continued investigating:
* I made the H2 changes to "reclaimPrimaryKey" if the DMO was NEW in the outer sub-t... - 06:35 AM User Interface Bug #9873 (Test): FILL-IN: client crashes on CTRL-SHIFT-LEFT or CTRL-SHIFT-RIGHT
- 04:30 AM User Interface Bug #9873: FILL-IN: client crashes on CTRL-SHIFT-LEFT or CTRL-SHIFT-RIGHT
- Please also merge 9873a change to 8755c and updated #8755.
07/16/2025
- 07:44 AM Database Bug #6923: inner transaction block reverts too much
- I committed 6923a/16047 containing more or less the change in #6923-7. However, I refined it to better consider sub-t...
07/15/2025
- 09:24 AM Base Language Bug #9411 (Closed): Implement SESSION:STREAM
- This can be closed.
- 09:23 AM Database Bug #9317 (Closed): FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause match...
- This can be closed.
- 04:02 AM Database Support #6709: track nested FIND inside a related FOR loop
- Is this ready for review? Or are you actively working on #6709-47?
- 03:49 AM Base Language Bug #8273 (WIP): avoid ErrorConditionException for FIND ... NO-ERROR if no record is found
- Review of 8273a:
The changes are good; only minor things to assess:
* The save/restore logic in @RandomAccessQu...
07/14/2025
- 06:54 AM Database Bug #6923: inner transaction block reverts too much
- I am encountering the same problem described here when dealing with #8388. The reason is exactly that the DMO is roll...
Also available in: Atom