Golden Code Redmine

09/19/2025

08:45 AM Base Language Bug #10522: Bring changes from 7156e/15727 to trunk

Committed *10522a/16177*. Changes from 7156e/15727 built on trunk/15726: Added change to collections java file from 6... Dănuț Filimon

06:43 AM Base Language Bug #10599: [Regression] undoLeaveTopLevel() generated during conversion, but it doesn't exist

I discussed with Eduard and he said that the issues should be fixed by 4602a. He also provided a patch I could use fo... Dănuț Filimon

06:23 AM Base Language Bug #10599: [Regression] undoLeaveTopLevel() generated during conversion, but it doesn't exist

The test case is:... Dănuț Filimon

06:20 AM Base Language Bug #10599 (New): [Regression] undoLeaveTopLevel() generated during conversion, but it doesn't exist

Dănuț Filimon

06:29 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Alexandru Lungu wrote:
> Danut, can you document which changes are mandatory for customer projects once 6083a gets i... Dănuț Filimon

03:15 AM Testing Support #6859: preprocessor tests

Dănuț Filimon wrote:
> Because the number of tests failing skyrocket when removing the revisions for #9903, I will l... Dănuț Filimon

02:09 AM Base Language Bug #10597: [Regression] extent field in form fails conversion

Nice find Stefanel! I modified the scenario to use temp-tables since it was easier, but the original one uses persist... Dănuț Filimon

09/18/2025

08:42 AM Base Language Bug #10597: [Regression] extent field in form fails conversion

Work on #10566 can't continue unless #10597 is fixed. Dănuț Filimon

08:40 AM Base Language Bug #10597: [Regression] extent field in form fails conversion

... Dănuț Filimon

08:39 AM Base Language Bug #10597 (Test): [Regression] extent field in form fails conversion

Dănuț Filimon

05:30 AM Testing Support #6859: preprocessor tests

Because the number of tests failing skyrocket when removing the revisions for #9903, I will leave 6859b intact. I wil... Dănuț Filimon

05:00 AM Testing Support #6859: preprocessor tests

I found that *6859b/16136 & 16137* are the ones that fix the #9903 problem, but also fix a number of other tests. Dănuț Filimon

09/16/2025

07:05 AM Testing Support #6859: preprocessor tests

The failures:... Dănuț Filimon

07:03 AM Testing Support #6859: preprocessor tests

Preprocessor tests status:... Dănuț Filimon

06:10 AM Testing Support #6859: preprocessor tests

Dănuț Filimon wrote:
> Alexandru also mentioned that I should revert the changes related to #9903 from 6859b to allo... Dănuț Filimon

09/15/2025

08:53 AM Testing Support #6859: preprocessor tests

There's testcases revisions 1735 and 1780 which I will have to look into and document. Alexandru also mentioned that ... Dănuț Filimon

09/12/2025

07:32 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Danut, I need to apply this fix to 9457c - what exactly should... Dănuț Filimon

04:39 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Constantin Asofiei wrote:
> Danut, I need to apply this fix to 9457c - what exactly should I patch? What was in 1046... Dănuț Filimon

05:56 AM Database Bug #9016 (Test): Improve performance in FQLPreprocessor by using astCache

Dănuț Filimon

05:56 AM Database Bug #9016: Improve performance in FQLPreprocessor by using astCache

Branch 9016a was merged into trunk as revision 16162 and archived. Dănuț Filimon

05:48 AM Database Bug #9016 (Merge Pending): Improve performance in FQLPreprocessor by using astCache

I'll be merging 9016a now. Dănuț Filimon

09/11/2025

08:22 AM Conversion Tools Bug #10469 (Pending): incremental conversion when basepath is more than one folder (aka abl/foo) ...

The fix from 10469a was integrated in *6083a*. Dănuț Filimon

05:49 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Constantin, I found a similar issue and mentioned it in #10536-9. Let me know if it is the same, as I've been testing... Dănuț Filimon

09/09/2025

07:35 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Since *6083a* contains changes for 3 tasks (#6083, #7793, #6738), the test plan should be done in the following order... Dănuț Filimon

07:17 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Greg Shah wrote:
> > How should I look for the name_map.xml in the jar if the expected path is @./cvt/name_map.xml@?... Dănuț Filimon

07:02 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

I think this needs a change to @SourceNameMapper.NAME_MAP_FILE_PATH@, assigning @Configuration.DEF_NAME_MAP_FILE@ ins... Dănuț Filimon

06:58 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Greg Shah wrote:
> Code Review Task Branch 6083a Revisions 16156 and 16157
>
> The changes are fine except I don'... Dănuț Filimon

05:58 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Committed *6083a/16157*. Added a default value for the name-map parameter, it can also be used in the rules. Dănuț Filimon

07:25 AM Database Bug #9016: Improve performance in FQLPreprocessor by using astCache

All regression tests passed, *9016a* can be merged. Dănuț Filimon

04:24 AM Conversion Tools Feature #10265 (Review): schema-only conversion

I committed *10265a/16140* for review. Dănuț Filimon

09/05/2025

07:50 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

To setup the name_map.xml in the cvt folder:
* @p2j.cfg.xml@:... Dănuț Filimon

07:21 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

I discussed with Alex and he mentioned that name_map.xml should be placed in the @cvt@ folder because it is an artifa... Dănuț Filimon

04:29 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Committed *6083a/16156*. Added support for having the name_map.xml in the @cfg@ folder (not @cvt@).
Greg, I think ... Dănuț Filimon

02:53 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

I ported the changes from *6738a/16145* to *6083a/16155*.
Greg Shah wrote:
> Code Review Task Branch 6738a Revisi... Dănuț Filimon

05:45 AM Conversion Tools Feature #10265 (Review): schema-only conversion

Greg, please review. Dănuț Filimon

05:40 AM Conversion Tools Feature #10265: schema-only conversion

Committed *10265a/16139*. Schema conversion will be executed during normal/incremental conversion, even if all files ... Dănuț Filimon

02:22 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Rebased *6083a* to latest *trunk/16147*, the branch is now at revision *16154*. Dănuț Filimon

09/04/2025

09:53 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Since I used a bit of code from *6083a* and the changes are related to the recent incremental work, should I port the... Dănuț Filimon

07:11 AM Conversion Tools Bug #6738 (Review): incremental conversion when deleting program or class files

Greg, please review. Dănuț Filimon

07:11 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Committed *6738a/16145*. Added support for incremental conversion when deleting a program.
The most important chan... Dănuț Filimon

08:50 AM Base Language Bug #10522: Bring changes from 7156e/15727 to trunk

The purpose of this task is to take the changes from 7156e/15727 and put them into a separate branch, then review and... Dănuț Filimon

08:48 AM Base Language Bug #10522 (New): Bring changes from 7156e/15727 to trunk

Dănuț Filimon

05:01 AM Database Support #6709: track nested FIND inside a related FOR loop

Rebased *6709a* to latest *trunk/16145*, the branch is now at revision *16152*. Dănuț Filimon

02:55 AM Database Bug #7793: incremental conversion with deleted table from .df

The following should be tested:
# Conversion test, the .df should contain an additional table from the start.
# Inc... Dănuț Filimon

09/03/2025

09:20 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

When deleting a file, incremental conversion must delete the following:
* The procedure name from @name_map.xml@
* ... Dănuț Filimon

07:16 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

I totally forgot that I have @this.filename@ for asts and that the name of the parsed file is always known. Dănuț Filimon

07:09 AM Database Bug #7793: incremental conversion with deleted table from .df

Fixed a bug where the md5 field was initialized to null instead of filename: *6083a/16131*. Dănuț Filimon

05:51 AM Database Bug #7793: incremental conversion with deleted table from .df

I committed *6083a/16130* to address the #7793-28 review. Dănuț Filimon

09/02/2025

09:11 AM Conversion Tools Bug #6738 (WIP): incremental conversion when deleting program or class files

Created task branch *6738a* from latest *trunk/16144*. Dănuț Filimon

08:21 AM Database Bug #7793: incremental conversion with deleted table from .df

Made a fix in *6083a/16129* for the issue mentioned in #7793-26, the DMO will also be deleted from the registry. Dănuț Filimon

08:06 AM Database Bug #7793: incremental conversion with deleted table from .df

There is an issue where the table should also be deleted from the registry.xml file. At a closer inspection I've foun... Dănuț Filimon

07:25 AM Database Bug #7793 (Review): incremental conversion with deleted table from .df

I committed *6083a/16128*. Added the changes mentioned in #7793-24.
Greg/Constantin, please review. Dănuț Filimon

06:34 AM Database Bug #7793: incremental conversion with deleted table from .df

I finally got something, the implementation works like this:
* In @ConversionData.java@, the @table_signature@ will ... Dănuț Filimon

02:16 AM Conversion Tools Feature #6256: improved profile support

Roger Borrello wrote:
> I made updates to an application to position the @.df@ files into the profile directory so t... Dănuț Filimon

09/01/2025

08:25 AM Conversion Tools Bug #6738: incremental conversion when deleting program or class files

Dănuț Filimon wrote:
> For #6738, I looked into the code and found @JavaPatternWorker$WorkArea.pfiles@, this helps u... Dănuț Filimon

06:08 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

The only ./cvt/ usage is in this phase:... Dănuț Filimon

05:50 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Constantin Asofiei wrote:
> I noticed something else during incremental conversion: the file is reported using @./cv... Dănuț Filimon

05:52 AM Database Bug #7793: incremental conversion with deleted table from .df

For #6738, I looked into the code and found @JavaPatternWorker$WorkArea.pfiles@, this helps us to track the persisted... Dănuț Filimon

05:48 AM Conversion Tools Bug #9917 (Test): Fileset not ignoring case

Branch 9917a was merged into trunk as revision 16139 and archived. Dănuț Filimon

05:17 AM Conversion Tools Feature #10265 (WIP): schema-only conversion

Created task branch *10265a* from *trunk/16138*. Dănuț Filimon

08/29/2025

09:08 AM Database Bug #7793: incremental conversion with deleted table from .df

We'd have to make a difference between code and schema artifacts, JavaPatternWorker.createJavaFile() is used for both... Dănuț Filimon

08:42 AM Database Bug #7793: incremental conversion with deleted table from .df

From the looks of it, I will need to load hotel.p2o which can give me access to the "path" annotation (com/goldencode... Dănuț Filimon

07:20 AM Database Bug #7793: incremental conversion with deleted table from .df

Alexandru told me that import.sh is able to determine the DMO, I'll investigate and check if this can be of help. Dănuț Filimon

06:59 AM Database Bug #7793: incremental conversion with deleted table from .df

The dmo file name is build in java_dmo.xml and I can't build the file name of a dmo that doesn't exist. The only opti... Dănuț Filimon

06:09 AM Database Bug #7793: incremental conversion with deleted table from .df

I tried to look into @DatabaseManager.getDatabaseDMOs()@ and @DatabaseManager.getDatabaseTables()@, but the issue wit... Dănuț Filimon

08/28/2025

09:15 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Committed #9383-17 to *9383a/16139*. Made transactionCommitting() default. Dănuț Filimon

09:09 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

You can do this:... Dănuț Filimon

08:49 AM Database Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Rebased *9383a* to latest *trunk/16136*, the branch is now at revision *16138*. Dănuț Filimon

06:54 AM Database Bug #7793: incremental conversion with deleted table from .df

6083a does give me a way to determine the deleted tables, the only problem is getting the *.java and *.java.jast file... Dănuț Filimon

05:45 AM Database Bug #7793: incremental conversion with deleted table from .df

I tested hotel using two persistent tables (pt1 and pt2), after removing the pt2 table I am still left with those two... Dănuț Filimon

03:22 AM Database Bug #7793 (WIP): incremental conversion with deleted table from .df

I'll pick this up since I worked on #6083. Dănuț Filimon

03:13 AM Conversion Tools Bug #10469 (Review): incremental conversion when basepath is more than one folder (aka abl/foo) w...

Committed the patch from #10469-7 to *10469a/16135*. Constantin, please review. Dănuț Filimon

08/27/2025

06:57 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Greg Shah wrote:
> > The only issue that I can see right now, is that the last table parsed will contain the df foot... Dănuț Filimon

06:28 AM Conversion Tools Feature #6083 (Review): schema (.df) changes in incremental conversion mode should only reconvert...

The only issue that I can see right now, is that the last table parsed will contain the df footer:... Dănuț Filimon

04:12 AM Conversion Tools Bug #9917: Fileset not ignoring case

The regression test plan passed with 9917a, the branch can be merged. Dănuț Filimon

08/26/2025

09:57 AM Testing Support #6859 (Internal Test): preprocessor tests

Rebased *6859b* to latest *trunk/16129*, the branch is now at revision *16143*.
I will create a regression test pl... Dănuț Filimon

08:49 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

So one section will be like this:... Dănuț Filimon

07:48 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Greg Shah wrote:
> If we are operating on the original text from the @.df@ then we would NOT be calculating any chan... Dănuț Filimon

06:14 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Dănuț Filimon wrote:
> To calculate the checksum for a table, we need:
> * The original text of the table, e.g.: @g... Dănuț Filimon

04:50 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

To calculate the checksum for a table, we need:
* The original text of the table, e.g.: @guest@
* The db_signature ... Dănuț Filimon

04:12 AM Base Language Bug #10474: Fix the remaining scenario and bring 9298a changes to trunk

The goal is to bring 9298a changes that were only ported to 7156c/e to trunk. However, 9298a introduces a problem whi... Dănuț Filimon

04:10 AM Base Language Bug #10474 (New): Fix the remaining scenario and bring 9298a changes to trunk

Dănuț Filimon

03:11 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

I experimented with the cvt and basepath parameters and also tried the scenario where:
* basepath is ./abl/hotel
* ... Dănuț Filimon

08/25/2025

09:25 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Greg Shah wrote:
> We could calculate the checksum for the original input text for that table. That would be more c... Dănuț Filimon

05:13 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Committed *6083a/16125*. Keep track of modified tables in incremental conversion.
I've noticed that during convers... Dănuț Filimon

06:56 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

I already tried to add abl/hotel to the propath:... Dănuț Filimon

06:27 AM Conversion Tools Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586

Constantin, is there any configuration missing? I get this error with the mentioned configuration:... Dănuț Filimon

06:06 AM Conversion Tools Bug #10469 (WIP): incremental conversion when basepath is more than one folder (aka abl/foo) with...

I'll look into the issue right away. Dănuț Filimon

06:00 AM Conversion Tools Feature #6256: improved profile support

Constantin, this is related to 5586a changes. Can you create a separate task? Dănuț Filimon

08/21/2025

09:22 AM Conversion Tools Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...

Rebased *6083a* to latest *trunk/16124*. Dănuț Filimon

09:08 AM Conversion Tools Bug #10208 (Test): do not convert the schema in incremental mode if it hasn't changed

Branch 10208a was merged into trunk as rev. 16124 and archived. Dănuț Filimon

05:37 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed

Testing went well, Radu also got the error from #10208-37 and it was related to trunk/16111 (since he converted with ... Dănuț Filimon

03:32 AM Conversion Tools Bug #9917 (Internal Test): Fileset not ignoring case

I retested conversion without revision 15971 for the problematic application and there were no issues.
Committed *... Dănuț Filimon