Project

General

Profile

Activity

From 01/20/2013 to 02/18/2013

02/19/2013

09:02 PM Feature #1640: implement DOM XML support
The update for new attributes/methods has been uploaded for review. Eugenie Lyzenko
07:14 PM Feature #2012: runtime support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:14 PM Feature #2012 (Closed): runtime support for _MSG() built-in
Greg Shah
07:13 PM Feature #2011: conversion support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:13 PM Feature #2011 (Closed): conversion support for _MSG() built-in
Greg Shah
07:12 PM Feature #1632: implement _MSG() undocumented built-in function
This is an undocumented built-in function. We need to determine what it does. at a high level it is used to create ... Greg Shah
07:07 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
The following is an example of the option in use:... Greg Shah
07:02 PM Feature #2010: runtime support for LANDSCAPE/PORTRAIT I/O options
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:02 PM Feature #2010 (Closed): runtime support for LANDSCAPE/PORTRAIT I/O options
Greg Shah
07:01 PM Feature #2009: conversion support for LANDSCAPE/PORTRAIT I/O option
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:01 PM Feature #2009 (Closed): conversion support for LANDSCAPE/PORTRAIT I/O option
Greg Shah

02/18/2013

06:39 PM Feature #1627: support for empty EXPORT statements
Good. Then the solution is to do the following:
1. In post_parse_fixups.rules, you should add a new rule-set like...
Greg Shah
05:35 PM Feature #1627: support for empty EXPORT statements
> Let me make sure I understand. In export_test[1-3].p, if you remove the empty EXPORT statement from those files, do... Eugenie Lyzenko
05:20 PM Feature #1627: support for empty EXPORT statements
> This redirects output to the file and produces non-empty file with real values of the variable like printing to the... Greg Shah
04:29 PM Feature #1627: support for empty EXPORT statements
> When a stream is not explicitly used (e.g. EXPORT STREAM my-stream...) then you must first redirect the terminal li... Eugenie Lyzenko
04:15 PM Feature #1627: support for empty EXPORT statements
> EXPORT cannot be used with output to the screen. (1105)
When a stream is not explicitly used (e.g. EXPORT STREAM...
Greg Shah
02:55 PM Feature #1627: support for empty EXPORT statements
The statements
EXPORT var1 (some-var2 + 54) var3.
EXPORT database-table.
both have run-time error in 4GL:
...
E...
Eugenie Lyzenko
09:59 AM Feature #1627: support for empty EXPORT statements
It is possible to have an "empty" EXPORT statement in the 4GL, as in:... Greg Shah
06:19 PM Feature #1979 (WIP): conversion support for DOM XML processing
Greg Shah
06:19 PM Feature #1640: implement DOM XML support
I have found that the following are actually in use in the application and need to be added for milestone 4:
Attri...
Greg Shah
05:46 PM Feature #2004: runtime support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:46 PM Feature #2004 (Closed): runtime support for SESSION handle
Greg Shah
05:45 PM Feature #2003: conversion support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:45 PM Feature #2003 (Closed): conversion support for SESSION handle
Greg Shah
05:43 PM Feature #1612: finish SESSION system handle support
The following are high priority:
Attributes:
CLIENT-TYPE
FIRST-BUFFER
NUMERIC-SEPARATOR
NUMERIC-DECIMAL-POIN...
Greg Shah
05:14 PM Feature #1608: implement full appserver support (from 4GL clients only)
I have reviewed the code, the only problem is that the unsubscribe_stmt still cannot match on the event name after th... Greg Shah
04:25 PM Feature #1608: implement full appserver support (from 4GL clients only)
Attached update with the mentioned issues fixed. Constantin Asofiei
04:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
> OK, so the idea the front phase should leave the ASTs as unchaged as possible.
Yes, that's right.
> Please le...
Greg Shah
04:10 PM Feature #1608: implement full appserver support (from 4GL clients only)
> I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_stmt and unsubscribe_stmt... Constantin Asofiei
03:46 PM Feature #1608: implement full appserver support (from 4GL clients only)
More Feedback:
1. handle.java is missing the "--JPRM--" in the header.
2. Is HandleChain.setType() always going...
Greg Shah
03:25 PM Feature #1608: implement full appserver support (from 4GL clients only)
Code Review Feedback:
I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_st...
Greg Shah
02:32 PM Feature #1608: implement full appserver support (from 4GL clients only)
Merged with revision 10178. Constantin Asofiei
02:01 PM Feature #1608: implement full appserver support (from 4GL clients only)
Attached update provides conversion support for app-server related statements and attributes/methods. Fixes progress.... Constantin Asofiei
12:00 PM Feature #1608: implement full appserver support (from 4GL clients only)
Greg Shah wrote:
> You will have to remove the expr option from that rule.
Yes, expr from widget_qualifier is no lo...
Constantin Asofiei
10:44 AM Feature #1608: implement full appserver support (from 4GL clients only)
I don't have a problem with your approach. I think it may work, but I do suspect there will be lookahead issues. Yo... Greg Shah
08:28 AM Feature #1608: implement full appserver support (from 4GL clients only)
I think the final solution is to get rid of the allowInProc quirk and call the widget_qualifier rule (in lvalue) only... Constantin Asofiei
04:20 PM Feature #1994 (Closed): conversion support for SOAP
Greg Shah
03:13 PM Feature #2002: refactor some "shared" attributes
Please implement appropriate interfaces for the following attributes which are shared between multiple resources:
...
Greg Shah
03:04 PM Feature #2002 (Closed): refactor some "shared" attributes
Greg Shah
02:25 PM Feature #1644: implement SOAP support
No changes in generated MAJIC sources, committed to bzr revision 10178. Constantin Asofiei
09:37 AM Feature #1644: implement SOAP support
And the latest update... Constantin Asofiei
09:37 AM Feature #1644: implement SOAP support
I've removed the trailing quotes. The conversion has been started on staging (with previous generated sources backedup). Constantin Asofiei
09:24 AM Feature #1644: implement SOAP support
I am OK with the update. The only thing I suggest is that the new javadoc entries have an unmatched trailing double ... Greg Shah
09:14 AM Feature #1644: implement SOAP support
Added update merged with bzr revision 10177. Constantin Asofiei
07:58 AM Feature #1644: implement SOAP support
> For these, 4GL allows only integer and int64 values (confirmed by testing).
OK. Please use long instead of int ...
Greg Shah
03:37 AM Feature #1644: implement SOAP support
> 1. The ErrorManager.WorkArea.soapFault member needs javadoc.
OK
> 2. For int parameters to methods like getHeader...
Constantin Asofiei
09:26 AM Feature #1987 (Closed): conversion support for SAX
Greg Shah
09:21 AM Feature #1620: implement EXTENT parameter support
Added testcases, for reference (they are in bzr too). Constantin Asofiei
08:29 AM Feature #1620: implement EXTENT parameter support
ca_upd20130218a.zip has been committed as 10175 (has passed regression testing). Constantin Asofiei
03:59 AM Feature #1620: implement EXTENT parameter support
This update fixes the following issues discovered on Saturday, during regression testing:
* ControlFlowOps NPE
* Bl...
Constantin Asofiei
09:18 AM Feature #1641: implement SAX XML support
The following attributes(SAX XML support) not yet implemented according to your note(a means SaxAttr, r means SaxRead... Eugenie Lyzenko
09:05 AM Feature #1641: implement SAX XML support
I have not cross-referenced your final code with the list of all possible features. Can you please make a list of al... Greg Shah
08:28 AM Feature #1641: implement SAX XML support
evl_upd20130215b.zip has been committed as 10176. Eugenie Lyzenko

02/17/2013

12:05 PM Feature #1644: implement SOAP support
Code Review Feedback:
1. The ErrorManager.WorkArea.soapFault member needs javadoc.
2. For int parameters to met...
Greg Shah
11:25 AM Feature #1644: implement SOAP support
OK, I understand now. Yes, this is an unfortunate side effect of our implementation. But at least the duplicate imp... Greg Shah
11:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
> Do you want us to get into the high-level design of the appserver's dispatcher/thread pool, startup/shutdown/connec... Greg Shah

02/16/2013

05:15 PM Feature #1608: implement full appserver support (from 4GL clients only)
Greg: as a side-note, at this time, how much of the runtime do you want to be stubbed out ? Do you want us to get int... Constantin Asofiei
11:53 AM Feature #1608: implement full appserver support (from 4GL clients only)
> do we have handle fields in the project?
Yes. I think they may only be supported in temp-tables in the 4GL. We...
Greg Shah
10:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
> 1. Determine the limits of what can be matched from the following "IN handle" cases:
For all cases, the @handle@ ca...
Constantin Asofiei
09:19 AM Feature #1608: implement full appserver support (from 4GL clients only)
> (thus the current approach of converting TRANSACTION DISTINCT to a KW_TRANS_DS token will not be correct).
You c...
Greg Shah
09:04 AM Feature #1608: implement full appserver support (from 4GL clients only)
> I assume that you don't need to change the looping of the parser. Instead you are referring to using fixups to for... Constantin Asofiei
08:32 AM Feature #1608: implement full appserver support (from 4GL clients only)
Some thoughts:
> The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and t...
Greg Shah
07:35 AM Feature #1608: implement full appserver support (from 4GL clients only)
And another PS: the SET clause for the ASYNCHRONOUS case behaves interesting:
* SET clause can be used without the A...
Constantin Asofiei
07:24 AM Feature #1608: implement full appserver support (from 4GL clients only)
PS: there is one syntax which can't be fixed that easy. Is related to RUN ... IN, as:... Constantin Asofiei
07:20 AM Feature #1608: implement full appserver support (from 4GL clients only)
The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and the conclusion is the... Constantin Asofiei
12:40 PM Feature #1644: implement SOAP support
> In each case where we are doing something different that the 4GL documentation, please make a statement like this:
...
Constantin Asofiei
12:26 PM Feature #1644: implement SOAP support
I will review it later today. Be prepared to merge it Monday morning with the pending 10174-10176 that is currently ... Greg Shah
12:07 PM Feature #1644: implement SOAP support
Attached update adds conversion support for SOAP-related attributes/methods and statements. Everything is stubbed, un... Constantin Asofiei
09:08 AM Feature #1644: implement SOAP support
I like the plan.
In regard to the "common" attributes (UNIQUE-ID, INSTANTIATING-PROCEDURE, LOCALNAME, NAMESPACE-UR...
Greg Shah
02:42 AM Feature #1620: implement EXTENT parameter support
This update:
- fixes decimals clause for 1-extent fields.
- fixes javadoc
- adds a TODO in decimal.setPrecision, f...
Constantin Asofiei
07:44 PM Feature #1620: implement EXTENT parameter support
FYI, there are some javadoc errors. You can fix them later (in a different check in).... Greg Shah
07:07 PM Feature #1641: implement SAX XML support
This is merged on top of ca_upd20130215d.zip (#1608) and ca_upd20130215e.zip (#1620 and #1621). It MUST be applied A... Greg Shah

02/15/2013

05:47 PM Feature #1641: implement SAX XML support
It looks good. I will merge it on top of Constantin's update and upload the result here. Greg Shah
05:21 PM Feature #1641: implement SAX XML support
The update merged with bzr 10173 has been uploaded. Eugenie Lyzenko
02:06 PM Feature #1641: implement SAX XML support
I appreciate it, but there are 3 of us that need to merge and it will be easier to use bzr. Greg Shah
02:00 PM Feature #1641: implement SAX XML support
> Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to c... Eugenie Lyzenko
01:46 PM Feature #1641: implement SAX XML support
Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to ch... Greg Shah
01:21 PM Feature #1641: implement SAX XML support
> ...
> 2. Merge with the bzr check-ins that should happen from the updates being tested in staging.
> ...
Does ...
Eugenie Lyzenko
12:35 PM Feature #1641: implement SAX XML support
Code Review Feedback:
1. Change the Abstract and class Javadoc in XmlFactory and XEntity so that they mention both...
Greg Shah
08:05 PM Feature #1641: implement SAX XML support
The SAX conversion and test file has been uploaded for you to review. Merged with recent P2J codebase.
The UniqueI...
Eugenie Lyzenko
03:22 PM Feature #1620: implement EXTENT parameter support
Attached update merged with bzr revision 10173. Constantin Asofiei
12:09 PM Feature #1620: implement EXTENT parameter support
Unfortunately the conversion on the linux box crashed when it was almost at the end, so I will not have a conclusion ... Constantin Asofiei
11:32 AM Feature #1620: implement EXTENT parameter support
OK, I've checked again and looks like I've been miss-interpreting the diff result, this update actually solves the is... Constantin Asofiei
11:26 AM Feature #1620: implement EXTENT parameter support
Do these problems already exist in Majic today? Greg Shah
11:20 AM Feature #1620: implement EXTENT parameter support
What I'm currently reconverting doesn't fix the dead-vars emitted in validateExpression and validateMessage methods. ... Constantin Asofiei
11:12 AM Feature #1620: implement EXTENT parameter support
The code looks good. Assuming your tests show that it needs no further changes, the plan is as follows:
1. As soo...
Greg Shah
07:02 AM Feature #1620: implement EXTENT parameter support
After checking the converted sources, the following issues were fixed/found:
# in some programs, the validation expr...
Constantin Asofiei
12:52 PM Feature #1608: implement full appserver support (from 4GL clients only)
The delete widget changes look good. We will keep it separate from the rest of the appserver update and instead incl... Greg Shah
12:19 PM Feature #1608: implement full appserver support (from 4GL clients only)
PS: I suggest to test and release this together with the #1620 changes, as we will be able to integrate the Deletable... Constantin Asofiei
12:12 PM Feature #1608: implement full appserver support (from 4GL clients only)
This update adds the Deletable interface and DELETE WIDGET support (note that with DELETE WIDGET any kind of resource... Constantin Asofiei
09:37 AM Feature #1608: implement full appserver support (from 4GL clients only)
Interesting finding. The permutations never seem to end. This also has implications about our runtime implementatio... Greg Shah
09:17 AM Feature #1608: implement full appserver support (from 4GL clients only)
OK, I will work on this. I will not push this change to all resources yet, only to what we are currently working.
...
Constantin Asofiei
09:11 AM Feature #1608: implement full appserver support (from 4GL clients only)
Good idea. Please go with the Deletable approach.
Also: please add support for DELETE WIDGET, which is the equiva...
Greg Shah
08:55 AM Feature #1608: implement full appserver support (from 4GL clients only)
A note about delete: currently, each deletable resource must be registered in HandleOps.delete and call its dedicated... Constantin Asofiei
11:17 AM Feature #1994 (WIP): conversion support for SOAP
Constantin Asofiei
11:02 AM Feature #1644: implement SOAP support
Implementation details:
* SOAPFactory - class with APIs for CREATE SOAP-HEADER and CREATE SOAP-HEADER-ENTRYREF state...
Constantin Asofiei

02/14/2013

06:15 PM Feature #1641: implement SAX XML support
> How soon can you provide an update for these features?
In a hour or so. I need to sync with the latest code, mak...
Eugenie Lyzenko
06:02 PM Feature #1641: implement SAX XML support
How soon can you provide an update for these features? Greg Shah
02:15 PM Feature #1608: implement full appserver support (from 4GL clients only)
Some quick notes on the update:
* SSL-SERVER-NAME (converted to SslServerAttribute interface) - make sure you don't ...
Constantin Asofiei
02:00 PM Feature #1608: implement full appserver support (from 4GL clients only)
Added an intermediate update for refference, the update does not contain implementation for the following server attr... Costin Savin
08:32 AM Feature #1608: implement full appserver support (from 4GL clients only)
Good idea. Greg Shah
08:31 AM Feature #1608: implement full appserver support (from 4GL clients only)
A note about emitting null for missing clauses: we can't map null with a 4GL token, so instead the solution is to cre... Constantin Asofiei
02:02 PM Feature #1990 (WIP): conversion support for appserver
Costin Savin
01:25 PM Feature #1620: implement EXTENT parameter support
> 1. I assume you have resolved the TRPL expression parsing error? If not, then we must solve this before going into... Constantin Asofiei
01:06 PM Feature #1620: implement EXTENT parameter support
Code Review Feedback:
This version looks good. I am fine with this, however I have questions:
1. I assume you ...
Greg Shah
11:25 AM Feature #1620: implement EXTENT parameter support
Attached version does the following:
# there is a feature which I think is valid only in 4GL v9:...
Constantin Asofiei
08:31 AM Feature #1620: implement EXTENT parameter support
... Greg Shah
12:12 AM Feature #1620: implement EXTENT parameter support
About issue 3 - I chose 0 to represent dynamic extent because this will produce a valid reference in the converted co... Constantin Asofiei
07:02 PM Feature #1620: implement EXTENT parameter support
Feedback:
1. The int members of enum ArgValidationErrors in ControlFlowOps need javadoc.
2. The progress.g need...
Greg Shah
12:29 PM Feature #1956 (Closed): implement conversion support for sockets
Greg Shah
12:10 PM Feature #1644: implement SOAP support
... Constantin Asofiei
08:51 AM Feature #1639: implement socket support
Committed conversion support for socket to bazaar as rev. 10167 and sent update mail to the team. Costin Savin
07:08 PM Feature #1995: runtime support for SOAP
This is just for time tracking. All history should be in parent task #1644. Greg Shah
07:07 PM Feature #1995 (Closed): runtime support for SOAP
Greg Shah
07:07 PM Feature #1994: conversion support for SOAP
This is just for time tracking and association with milestone 4. All history should be in the parent task #1644. Greg Shah
07:07 PM Feature #1994 (Closed): conversion support for SOAP
Greg Shah

02/13/2013

03:03 PM Feature #1620 (Review): implement EXTENT parameter support
Constantin Asofiei
11:14 AM Feature #1620: implement EXTENT parameter support
Beside the issues on comment 28, the attached fix adds only some startup code for extent parameter validation. What i... Constantin Asofiei
09:18 AM Feature #1620: implement EXTENT parameter support
> 1. def_var_stmt
No special work needed, define_stmt calls sym.annotateVariableOptions which sets the extent annota...
Constantin Asofiei
12:39 PM Feature #1641: implement SAX XML support
Both of these are only used for SAX and DOM, so they can go in an XCommon interface. Greg Shah
12:30 PM Feature #1641: implement SAX XML support
The other common attributes/methods:
NONAMESPACE-SCHEMA-LOCATION attribute(common with X-Document object)
ADD-SCHEMA...
Eugenie Lyzenko
12:09 PM Feature #1641: implement SAX XML support
Actually, UNIQUE-ID is common to more than just the DOM and SAX support. Other resources (e.g. procedure handles, SO... Greg Shah
08:45 AM Feature #1641: implement SAX XML support
I have encountered one issue. The attribute
UNIQUE-ID
is common not only for SAX XML objects but for DOM XML too. S...
Eugenie Lyzenko

02/12/2013

02:57 PM Feature #1620: implement EXTENT parameter support
I'm implementing these rules from last to first, and not obvious cases I'll leave last. About the validation problems... Constantin Asofiei
12:52 PM Feature #1620: implement EXTENT parameter support
Wow. Great work!
If we are far off from this implementation, then we will need to defer the runtime work until lat...
Greg Shah
11:40 AM Feature #1620: implement EXTENT parameter support
List of rules describing behavior of mixed extent and dynamic-extent in parameters and assignments:
1. output mode:
...
Constantin Asofiei
09:43 AM Feature #1620: implement EXTENT parameter support
Code feedback:
1. The OutputExtentParameter getVariable(int) method should be located above the private methods in...
Greg Shah
05:21 AM Feature #1620: implement EXTENT parameter support
About the validation clause attached to an extent variable/field and which uses the extent in the validation expressi... Constantin Asofiei
03:01 AM Feature #1620: implement EXTENT parameter support
> Did you resolve the getSourceCodeVersion TRPL error?
No, because the next step would have been to start checking t...
Constantin Asofiei
08:31 PM Feature #1620: implement EXTENT parameter support
I have reviewed the proposed ruleset changes. They look good. I'll look at the runtime changes tomorrow.
Did you...
Greg Shah
01:10 PM Feature #1608: implement full appserver support (from 4GL clients only)
I like your approach with the ControlFlowOps APIs.... Greg Shah
12:57 PM Feature #1608: implement full appserver support (from 4GL clients only)
Some notes about the RUN statement which targets a remote procedure:
# @RUN PERSISTENT [SET handle] ... ON server@ c...
Constantin Asofiei

02/11/2013

06:03 PM Feature #1641: implement SAX XML support
Yes, go ahead and add most of the others. Exclude the following attributes (they are not specific to SAX): ADM-DATA,... Greg Shah
04:49 PM Feature #1641: implement SAX XML support
The testcases has been uploaded. All statements inside are converted and compiled with stubs. I'm preparing Javadoc e... Eugenie Lyzenko
12:48 PM Feature #1620: implement EXTENT parameter support
> Please provide details of the error.
The warning is in red and it says:...
Constantin Asofiei
11:46 AM Feature #1620: implement EXTENT parameter support
... Greg Shah
11:40 AM Feature #1620: implement EXTENT parameter support
Attached update which:
* is merged with bzr revision 10166
* emit ArrayAssigner.lengthOf in case of dynamic-extent ...
Constantin Asofiei
10:58 AM Feature #1979 (Closed): conversion support for DOM XML processing
Greg Shah
10:54 AM Feature #1639: implement socket support
Looks good. We will get this into testing soon. Greg Shah
10:38 AM Feature #1639: implement socket support
Must have used a wrong version of language_statements , made the change and converted the tests, everything seems ok ... Costin Savin
10:25 AM Feature #1639: implement socket support
Everything looks OK except you have regressed something in the merge with language_statements.rules. The version the... Greg Shah
10:09 AM Feature #1639: implement socket support
Added update synchronized with latest version Costin Savin
08:40 AM Feature #1639: implement socket support
Eugenie will be checking in an update shortly. You will have at least 2 files to merge. Please do so quickly and th... Greg Shah
06:30 AM Feature #1639: implement socket support
Forgot to modify the module name from history header, when I renamed some of the classes. Costin Savin
05:51 AM Feature #1639: implement socket support
Updated with latest commit from CA. Costin Savin
08:58 AM Feature #1640: implement DOM XML support
The update evl_upd20130206c.zip has been passed the regression testing ans was committed in bzr as 10166. Eugenie Lyzenko
03:33 AM Feature #1884: add some of the v10 data types and core built-ins
Passed regression testing, committed to bzr revision 10165. Constantin Asofiei

02/09/2013

12:34 PM Feature #1620: implement EXTENT parameter support
Added almost final update which adds support for:
* support for p2j.cfg.xml's new source-code-version (see comments ...
Constantin Asofiei
12:33 PM Feature #1621: implement dynamic/unspecified EXTENT support
Dynamic-extent variables can not be used as widgets, like @form x with frame f1@ where @def var x as int extent@. Constantin Asofiei

02/08/2013

02:34 PM Feature #1608: implement full appserver support (from 4GL clients only)
... Greg Shah
02:08 PM Feature #1608: implement full appserver support (from 4GL clients only)
For Server handle the folllowing attributes have types that are not yet implemented... Costin Savin
08:37 AM Feature #1608: implement full appserver support (from 4GL clients only)
Lower priority features:
Server Handle Object methods:
CANCEL-REQUESTS()
CANCEL-REQUESTS-AFTER()
Server Handl...
Greg Shah
01:57 PM Feature #1641: implement SAX XML support
Actually, you are testing the new longchar data type support right now (in staging). Please map any longchar stuff t... Greg Shah
01:27 PM Feature #1641: implement SAX XML support
One point to clarify:
In some methods I see the LONGCHAR as possible data type for parameters. It is not currently...
Eugenie Lyzenko
08:42 AM Feature #1991: runtime support for appserver
This task is just for time tracking. All history should be in the parent task #1608. Greg Shah
08:41 AM Feature #1991 (Closed): runtime support for appserver
Greg Shah
08:41 AM Feature #1990: conversion support for appserver
This task is just for tracking time and associating the work with milestone 4. All history should be in the parent ta... Greg Shah
08:40 AM Feature #1990 (Closed): conversion support for appserver
Greg Shah
08:26 AM Feature #1639: implement socket support
Looks good. We will get it into testing shortly. Greg Shah
06:33 AM Feature #1639: implement socket support
Added proposed update(strangely that missplaced "=" sign didn't break conversion), converted previously created tests... Costin Savin
04:39 AM Feature #1884: add some of the v10 data types and core built-ins
Fixed another problem, related to the fact that Text was missing a @Text(Text)@ c'tor, to initialize it properly (@ch... Constantin Asofiei

02/07/2013

06:57 PM Feature #1639: implement socket support
Feedback:
1. methods_attributes.rules has a "stray" equal sign (=) just after prog.kw_set_s_o. I think that would...
Greg Shah
02:10 PM Feature #1639: implement socket support
Added the proposed update with reviewed issues + superclasses HandleChain and SensitiveResource implementing the comm... Costin Savin
12:14 PM Feature #1639: implement socket support
OK, I like it. Greg Shah
12:12 PM Feature #1639: implement socket support
I took a look at Costin's code and I think it will be a lot easier (and it will provide faster access) if we will mov... Constantin Asofiei
11:24 AM Feature #1639: implement socket support
We at least need a common superclass for Socket and SocketListener so that the code for these attributes (e.g. NAME..... Greg Shah
11:17 AM Feature #1639: implement socket support
> 13. We should have a superclass that can implement PRIVATE-DATA, NAME, TYPE, SENSITIVE... and other common attribut... Constantin Asofiei
10:11 AM Feature #1639: implement socket support
... Greg Shah
09:42 AM Feature #1639: implement socket support
> 7. I'm not sure why there are changes in widget_references.rules and frame_scoping.rules. I definitely don't want s... Costin Savin
05:09 PM Feature #1641: implement SAX XML support
Just add similar import creation code to the language_statements.rules. It doesn't hurt if the JAST gets more than 1... Greg Shah
04:58 PM Feature #1641: implement SAX XML support
I've found the strange conflict.
1. We need to import .xml.* package to the converted file.
2. It is happening in m...
Eugenie Lyzenko
04:14 PM Feature #1641: implement SAX XML support
Excellent, thanks! Greg Shah
03:46 PM Feature #1641: implement SAX XML support
> Everything is good in the plan, except I don't want XmlHelper to be the factory for create statements. Just add the... Eugenie Lyzenko
03:40 PM Feature #1641: implement SAX XML support
Everything is good in the plan, except I don't want XmlHelper to be the factory for create statements. Just add them... Greg Shah
03:32 PM Feature #1641: implement SAX XML support
Implementation plan:
1. The create statements will refer to static methods in XmlHelper class.
2. The methods and a...
Eugenie Lyzenko
11:21 AM Feature #1641: implement SAX XML support
Yes, you're right that SET-NODE is not for SAX. It is for SOAP support. Don't work on it here. Greg Shah
11:16 AM Feature #1641: implement SAX XML support
I have updated the SAX related attributes/methods list. The question for method set-node() you noted. I have not foun... Eugenie Lyzenko
02:04 PM Feature #1620: implement EXTENT parameter support
I was dropping it because I think it was emitting the extent literal (if present) in the generated code. I will modif... Constantin Asofiei
01:58 PM Feature #1620: implement EXTENT parameter support
OK. My only comment is that generally, I only drop nodes (using the !) that are "syntactic sugar". For example, DOT... Greg Shah
01:20 PM Feature #1620: implement EXTENT parameter support
> So progress.g needs to be updated to support that syntax. If the project code (server or gui) had that construct, ... Constantin Asofiei
11:25 AM Feature #1620: implement EXTENT parameter support
OK. Greg Shah
11:19 AM Feature #1620: implement EXTENT parameter support
To be sure we don't brake anything in MAJIC, we will need to add this flag for this task (IMO, this is a conversion i... Constantin Asofiei
10:04 AM Feature #1620: implement EXTENT parameter support
We are already needing a similar feature for int64 support. v9 compiles some things to integer that v10 compiles to ... Greg Shah
09:00 AM Feature #1620: implement EXTENT parameter support
In convert/variable_definitions.rules, on line 550, it states that all output parameters for functions will initializ... Constantin Asofiei
10:47 AM Feature #1963 (Closed): implement conversion support for MEMPTR/RAW
Greg Shah
10:44 AM Feature #1960 (Closed): conversion support for Windows environment/registry access
Greg Shah
10:23 AM Feature #1884: add some of the v10 data types and core built-ins
Update contains P2J fixes for:
# setter for character fields emit as Text
# operator.rules bug
# TextOps.concat re...
Constantin Asofiei
09:29 AM Feature #1884: add some of the v10 data types and core built-ins
... Greg Shah
07:47 AM Feature #1884: add some of the v10 data types and core built-ins
Beside the MAJIC-related changes (btw, MAJIC update should be attached here or to #1973?), there are a few other prob... Constantin Asofiei
02:04 AM Feature #1884: add some of the v10 data types and core built-ins
I've fixed the javadoc problems in this update (you are right, no special testing is needed for these changes, as the... Constantin Asofiei
08:24 AM Feature #1982 (Closed): conversion support for widget pools
Greg Shah
01:48 AM Feature #1982 (Review): conversion support for widget pools
Constantin Asofiei
08:22 AM Feature #1636 (Closed): implement peristent trigger support
Greg Shah
01:48 AM Feature #1636: implement peristent trigger support
Regression testing has passed, applied to bzr revision 10162. Constantin Asofiei
07:11 AM Feature #1640: implement DOM XML support
The remaining attribute/methods list has been updated after reviewing the 11.x Progress docs. Eugenie Lyzenko
01:51 AM Feature #1792: implement widget-pool support
Regression testing for the conversion support update has passed, applied to bzr revision 10162. Constantin Asofiei
01:50 AM Feature #1920: implement persistent procedures
Regression testing of the ca_upd20130131d.zip changes has passed, applied to bzr revision 10162. Constantin Asofiei

02/06/2013

05:45 PM Feature #1641: implement SAX XML support
From our document called "Getting Started with P2J Development":... Greg Shah
04:57 PM Feature #1641: implement SAX XML support
SAX-READER, SAX-WRITER, SAX-ATTRIBUTES Objects:
The already mentioned statements, attributes and methods:
CREATE SA...
Eugenie Lyzenko
07:58 PM Feature #1641: implement SAX XML support
Please document the full list of SAX-related features (e.g. everything related to the SAX-attributes/SAX-reader/SAX-w... Greg Shah
05:43 PM Feature #1639: implement socket support
Feedback:
1. The socket_events function in common-progress.rules seems to have the following issues:
a. It assu...
Greg Shah
02:07 PM Feature #1639: implement socket support
Added proposed update (also includes support for 4GL compiler variables READ-AVAILABLE and READ-EXACT-NUM used for ... Costin Savin
04:31 PM Feature #1620: implement EXTENT parameter support
The good news is that there is no usage of user-defined functions returning an extent in any of the project code. Th... Greg Shah
11:47 AM Feature #1620: implement EXTENT parameter support
# is cleaner to let -1 for non-extent, 0 for dynamic-extent and >0 for fixed-size extent (these constants will be use... Constantin Asofiei
08:25 AM Feature #1620: implement EXTENT parameter support
OK. Do it. Greg Shah
05:28 AM Feature #1620: implement EXTENT parameter support
> It may be time for this. However, I worry about how much development time this will take, since we have a tight sc... Constantin Asofiei
02:52 PM Feature #1640: implement DOM XML support
I have applied it. We will have to rebuild P2J before testing can start. Greg Shah
02:14 PM Feature #1640: implement DOM XML support
Another issue has been found. Please use the recent file. Does not affect the conversion. Eugenie Lyzenko
01:53 PM Feature #1640: implement DOM XML support
The fix has been uploaded. Eugenie Lyzenko
01:25 PM Feature #1640: implement DOM XML support
I applied the change to lightning and tried to rebuild P2J. I got these errors:... Greg Shah
12:49 PM Feature #1640: implement DOM XML support
No, don't add the low priority attributes/methods right now.
I am OK with the code as uploaded. It will go into t...
Greg Shah
11:34 AM Feature #1640: implement DOM XML support
As you can see the amount is more than 10. Do we need them to be added? Eugenie Lyzenko
10:24 AM Feature #1640: implement DOM XML support
The remaining attributes/methods:
Attributes
CHILD-NUM
ENCODING
HANDLE
INSTANTIATING-PROCEDURE
LOCAL-NAME
NAMESPACE...
Eugenie Lyzenko
08:19 AM Feature #1640: implement DOM XML support
Please review the Progress 4GL Reference and make a list of all other DOM XML features which are not listed above. I... Greg Shah
12:10 AM Feature #1640: implement DOM XML support
> 1. Don't we need a getNode() method to match the one in Progress? It should not be removed. It should just return a... Eugenie Lyzenko
02:27 PM Feature #1884: add some of the v10 data types and core built-ins
I have applied it. There are some compile warnings:
[javac] /mnt/san/sata/gc/20121029/p2j/src/com/goldencode...
Greg Shah
02:04 PM Feature #1884: add some of the v10 data types and core built-ins
OK, I've made the changes, the update is attached. Constantin Asofiei
01:58 PM Feature #1884: add some of the v10 data types and core built-ins
Just put it in the following:
1. In the TRPL rules where it emits "" as the default.
2. In the class level Javado...
Greg Shah
01:51 PM Feature #1884: add some of the v10 data types and core built-ins
For byteLength, OK, I've changed the javadoc. But I don't understand what javadoc I should change related to default ... Constantin Asofiei
01:47 PM Feature #1884: add some of the v10 data types and core built-ins
The code changes look good. My only concern is that the issues 1 (default init) and 3 (byte length) should have the ... Greg Shah
01:40 PM Feature #1884: add some of the v10 data types and core built-ins
1 - although documentation states longchar inits to unknown, practice says different - testing showed that initial va... Constantin Asofiei
07:47 PM Feature #1884: add some of the v10 data types and core built-ins
Feedback:
1. The Progress documentation states that the default initializer for longchar is unknown value. But no...
Greg Shah
11:33 AM Feature #1621: implement dynamic/unspecified EXTENT support
Once a dynamic-extent array has its size set using the @EXTENT@ statement, a second @EXTENT@ statement on that array ... Constantin Asofiei
07:52 PM Feature #1988: runtime support for SAX
This is a task for time tracking and association of the conversion portion with milestone 4. Put all history in the ... Greg Shah
07:52 PM Feature #1988 (Closed): runtime support for SAX
Greg Shah
07:51 PM Feature #1987: conversion support for SAX
This is a task for time tracking and association of the conversion portion with milestone 4. Put all history in the ... Greg Shah
07:50 PM Feature #1987 (Closed): conversion support for SAX
Greg Shah

02/05/2013

05:55 PM Feature #1640: implement DOM XML support
Code feedback:
1. Don't we need a getNode() method to match the one in Progress? It should not be removed. It sh...
Greg Shah
05:24 PM Feature #1640: implement DOM XML support
The point to discuss:
> 7. I think the runtime implementation is not correct. We don't need to keep a "parallel" tre...
Eugenie Lyzenko
02:57 PM Feature #1640: implement DOM XML support
The new drop has been uploaded:
1. The methods/attr relocated in alphabetical order.
2. The rule files have been ...
Eugenie Lyzenko
11:30 AM Feature #1640: implement DOM XML support
Feedback:
1. The versions of existing files (like methods_attributes.rules and language_statements.rules) need to ...
Greg Shah
09:03 PM Feature #1640: implement DOM XML support
The new update has been significantly reworked. Now it completely uses org.w3c.dom classes. The only remaining mappin... Eugenie Lyzenko
04:15 PM Feature #1620: implement EXTENT parameter support
... Greg Shah
04:08 PM Feature #1621: implement dynamic/unspecified EXTENT support
... Greg Shah
01:59 PM Feature #1920: implement persistent procedures
Added an email dispatched to the team:
> If you encounter problems with attributes/methods converting using an incor...
Constantin Asofiei
01:51 PM Feature #1920: implement persistent procedures
Two cases Vadim has found:... Constantin Asofiei
01:32 PM Feature #1920: implement persistent procedures
I agree chained unwrap and method calls instead of nested unwrap calls will look better, and the change is pretty sim... Constantin Asofiei
01:06 PM Feature #1920: implement persistent procedures
I know that recently we have had some issues related to handle chaining as well as with handle usage as an l-value. ... Greg Shah
01:08 PM Feature #1639: implement socket support
Yes, defer the SELF support for now. Greg Shah
01:01 PM Feature #1639: implement socket support
I will try to get it done tomorrow if SELF support is not needed for sockets at the moment. Costin Savin
12:46 PM Feature #1639: implement socket support
In regard to INSTANTIATING-PROCEDURE, working on that is not urgent right now.
SELF is used in the server project ...
Greg Shah
05:19 AM Feature #1639: implement socket support
The wait-for loop for socket events exposes another issue related to handles. In 4GL, it is legal something like:
<p...
Constantin Asofiei

02/04/2013

01:45 PM Feature #1621 (WIP): implement dynamic/unspecified EXTENT support
Constantin Asofiei
01:40 PM Feature #1621: implement dynamic/unspecified EXTENT support
Later edit for this statement:
> or, in cases when extent variables are passed to parameters, we should use a simila...
Constantin Asofiei
01:37 PM Feature #1621: implement dynamic/unspecified EXTENT support
Is there any case in P2J where something like @i = v[1]@ where v is an extent variable gets converted to the Java equ... Constantin Asofiei
08:29 AM Feature #1621: implement dynamic/unspecified EXTENT support
In Openedge 10.x, variables (and fields too?) can be defined as an indeterminate size that is "fixed" at runtime. Th... Greg Shah
01:45 PM Feature #1620 (WIP): implement EXTENT parameter support
Constantin Asofiei
01:40 PM Feature #1620: implement EXTENT parameter support
> Starting in Progress 10.x extent parameters are allowed in procedures and functions.
The solution is to use Java a...
Constantin Asofiei
08:27 AM Feature #1620: implement EXTENT parameter support
Starting in Progress 10.x extent parameters are allowed in procedures and functions. Also, function return values ca... Greg Shah
01:24 PM Feature #1639: implement socket support
Remaining Issues:
Event support is implemented at the moment as widgets origin only, I'll have to think a bit more o...
Costin Savin
10:45 AM Feature #1639: implement socket support
I realized at runtime the same kind of problem happens on the SENSITIVE attribute which is already implemented inside... Costin Savin
07:06 AM Feature #1639: implement socket support
The INSTANTIATING-PROCEDURE doesn't exist in the list of attributes to support for customer project task #1668 so it ... Costin Savin
07:08 AM Feature #1884: add some of the v10 data types and core built-ins
The attached update has the P2J sources merged with bzr revision 10160; javadocs are added, can be reviewed. Constantin Asofiei

02/03/2013

06:16 PM Feature #1649: implement Windows environment/registry access
Bit change to fix log entry number in header. There are no code changes, just wrong number from 008 to 018 fix. Eugenie Lyzenko
08:59 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I inadvertently missed a change in my update zip. The following diff is from com/goldencode/p2j/persist/type/DateUse... Greg Shah

02/02/2013

04:49 AM Feature #1920: implement persistent procedures
Conversion regression testing has passed (no changes in the generated sources). Constantin Asofiei
04:49 AM Feature #1636: implement peristent trigger support
Conversion regression testing has passed (no changes in the generated sources). Constantin Asofiei
07:15 PM Feature #1640: implement DOM XML support
The refined code to review with Javadoc and all stubs implemented. However I need to think a bit more on implementati... Eugenie Lyzenko

02/01/2013

03:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update fixes a regression found in testing. All timezone initialization changes have been backed out of the dat... Greg Shah
07:26 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update merges with the recent changes that should be in bazaar revision 10159. In addition, several javadoc err... Greg Shah
01:55 PM Feature #1639: implement socket support
After testing for the possible handles that can have the argument name the following results:
Handles which suppor...
Costin Savin
08:19 AM Feature #1639: implement socket support
Yes, do the same analysis on that one too. Please send an email to the entire team about INSTANTIATING-PROCEDURE to ... Greg Shah
08:14 AM Feature #1639: implement socket support
Besides the name attribute there is also an attribute called "INSTANTIATING-PROCEDURE" this appears in both SOCKET an... Costin Savin
08:07 AM Feature #1639: implement socket support
I agree that we need to add some support for setName() as it does seem to be writable. But it is not clear where to ... Greg Shah
06:20 AM Feature #1639: implement socket support
While converting the previously created tests for socket attributes and methods, I encountered the following problem:... Costin Savin
01:27 PM Feature #1792: implement widget-pool support
>1. Do we need to implement a global unnamed widget-pool like Progress does? This would ensure that "proper" deletes ... Constantin Asofiei
12:13 PM Feature #1640: implement DOM XML support
The very fist implementation uploaded. There are no Javadocs, the code is in early state and something is not yet imp... Eugenie Lyzenko
08:36 PM Feature #1640: implement DOM XML support
> For an example of how to add the import, search on "createImport" in rules/convert/methods_attributes.rules.
Tha...
Eugenie Lyzenko
08:21 PM Feature #1640: implement DOM XML support
Yes, both get-child(x-node-ref, index) and get-document-element(x-node-ref) have expressions of type handle as the 1s... Greg Shah
08:15 PM Feature #1640: implement DOM XML support
There are two methods unusual:
get-child(x-node-ref, index) and get-document-element(x-node-ref). The both of them r...
Eugenie Lyzenko
07:13 PM Feature #1640: implement DOM XML support
Yes, make an XEntity interface and make both the XDocument and XNodeRef extend that superinterface. That way they wi... Greg Shah
08:23 AM Feature #1920: implement persistent procedures
Added tests for the subscript and the method chain cases. Constantin Asofiei
08:02 AM Feature #1984: make methods to act as "read-only" attributes
In 4GL, a code which has a method name as a l-value compiles correctly:... Constantin Asofiei
08:01 AM Feature #1984 (New): make methods to act as "read-only" attributes
Constantin Asofiei
07:55 AM Feature #1636 (Review): implement peristent trigger support
Constantin Asofiei
07:50 AM Feature #1636: implement peristent trigger support
Attached are testcases and P2J sources which implement both conversion and runtime support for persistent triggers. Constantin Asofiei

01/31/2013

06:25 PM Feature #1640: implement DOM XML support
The point to discuss.
I'm implementing the attributes/methods conversion. It is OK with the current approach to de...
Eugenie Lyzenko
02:45 PM Feature #1636: implement peristent trigger support
PS for 11: and there is no need to save them in a global scope too, because when a persistent trigger is defined for ... Constantin Asofiei
02:39 PM Feature #1636: implement peristent trigger support
I don't think that would do the job, as a non-persistent trigger can hide a persistent trigger; the persistent trigge... Constantin Asofiei
02:33 PM Feature #1636: implement peristent trigger support
Our ScopedSymbolDictionary has a global scope facility that should do most of the work here. The only question I hav... Greg Shah
12:49 PM Feature #1636 (WIP): implement peristent trigger support
Constantin Asofiei
12:16 PM Feature #1636: implement peristent trigger support
Some other notes related to scoping:
# if there is a non-persistent and a persistent trigger for the same event, the...
Constantin Asofiei
10:31 AM Feature #1636: implement peristent trigger support
Code feedback:
In registerTriggerPersistent() it says:...
Greg Shah
09:25 AM Feature #1636: implement peristent trigger support
In regard to the global scope question for LT and TC:
1. The TriggerManager is scope-aware, but it currently has n...
Greg Shah
08:52 AM Feature #1636: implement peristent trigger support
Adds conversion support; runtime support is missing implementation for the "persistent" nature of these triggers. Bui... Constantin Asofiei
08:35 AM Feature #1636: implement peristent trigger support
The conversion support is done, and a major part of the runtime (i.e. trigger invocation). The only runtime problem r... Constantin Asofiei
01:17 PM Feature #1649: implement Windows environment/registry access
The new update merged with recent code from Constantin and moved used variable to the head of the file because furthe... Eugenie Lyzenko
12:49 PM Feature #1982 (WIP): conversion support for widget pools
Constantin Asofiei
11:46 AM Feature #1792: implement widget-pool support
> 1. The WidgetPool.create/delete methods need variants for character expressions.
OK, I've added them.
> 2. Perh...
Constantin Asofiei
10:16 AM Feature #1792: implement widget-pool support
Code feedback:
1. The WidgetPool.create/delete methods need variants for character expressions.
2. Perhaps I miss...
Greg Shah
09:56 AM Feature #1792: implement widget-pool support
It seems like there are 4 kinds of pools:
- un-named session pool (created automatically by the 4GL and used as th...
Greg Shah
08:49 AM Feature #1792: implement widget-pool support
Added update for review (on top of bzr revision 10158). Constantin Asofiei
08:41 AM Feature #1792: implement widget-pool support
From the documentation and some testing, it seems that scoping is done on the nearest executing block; we should be a... Constantin Asofiei
11:01 AM Feature #1920: implement persistent procedures
Looks good. Greg Shah
10:49 AM Feature #1920: implement persistent procedures
This update solves call chains like:... Constantin Asofiei
09:17 AM Feature #1920: implement persistent procedures
> my-handle:BUFFER-FIELD("field-name"):BUFFER-VALUE = <some_expression>.
This case is not covered yet; the method's ...
Constantin Asofiei
09:04 AM Feature #1920: implement persistent procedures
I am fine with the proposed changes. There is a large update in "front" of this for staging (my datetime, datetimetz... Greg Shah
04:50 AM Feature #1920: implement persistent procedures
I've added non-null protection for the amref case you mentioned. Also, I've fixed another case found by Ovidiu: @BUFF... Constantin Asofiei
08:35 AM Feature #1976 (Closed): conversion support for named events
Greg Shah
08:25 AM Feature #1976 (Feedback): conversion support for named events
Constantin Asofiei
08:17 AM Feature #1607: implement full named events support
Passed conversion regression testing, applied to bzr revision 10158. Not applied to staging. Constantin Asofiei

01/30/2013

06:58 PM Feature #1640: implement DOM XML support
Yes, you can put that in language_statements.rules. Greg Shah
06:49 PM Feature #1640: implement DOM XML support
> ...
> And the methods_attributes.rules must be modified to use the proper unwrap type (XDocument or XNodeRef) depe...
Eugenie Lyzenko
05:40 PM Feature #1640: implement DOM XML support
... Greg Shah
05:10 PM Feature #1640: implement DOM XML support
The implementation/design point to discuss. I'm looking for the place where we can implement the required DOM XML sup... Eugenie Lyzenko
10:35 AM Feature #1640: implement DOM XML support
INSERT-ATTRIBUTE() is a documented method (in the 4GL reference). But it is for the SAX XML support, not for DOM. I ... Greg Shah
10:25 AM Feature #1640: implement DOM XML support
The first release of the DOM XML test uploaded.
And the question:
I have not found the method insert-attribute() ...
Eugenie Lyzenko
04:22 PM Feature #1983: runtime support for widget pools
This task is only for tracking spent time and linking this work to milestone 4. All history updates should go into t... Greg Shah
04:22 PM Feature #1983 (Closed): runtime support for widget pools
Greg Shah
04:21 PM Feature #1982: conversion support for widget pools
This task is only for tracking spent time and linking this work to milestone 4. All history updates should go into t... Greg Shah
04:21 PM Feature #1982 (Closed): conversion support for widget pools
Greg Shah
04:19 PM Feature #1792: implement widget-pool support
This is heavily used, even on the server since it seems to affect non-UI resources too. Greg Shah
04:17 PM Feature #1636: implement peristent trigger support
Just implement the conversion support for now, unless it is trivial to do the runtime too. Greg Shah
03:59 PM Feature #1920: implement persistent procedures
I am OK with the change so long as amref is never null at line 1372. I suspect it is not ever null, but I haven't in... Greg Shah
11:39 AM Feature #1920: implement persistent procedures
Fixed the case mentioned by Ovidiu. Attached is the fix and testcase. Constantin Asofiei
05:50 AM Feature #1920: implement persistent procedures
While working on some methods and attributes I found the following testcase that fails to convert correctly:... Ovidiu Maxiniuc
02:44 PM Feature #1649: implement Windows environment/registry access
OK, this looks good. Let's wait until tomorrow for conversion testing, since Constantin is in testing with another c... Greg Shah
01:42 PM Feature #1649: implement Windows environment/registry access
Merged update has been uploaded. Eugenie Lyzenko
12:29 PM Feature #1649: implement Windows environment/registry access
I am OK with the changes. But there is a conflict in bzr. Please merge with the latest changes and upload it. Greg Shah
02:39 PM Feature #1607: implement full named events support
There are no conflicts with the stuff in staging. When this passes conversion testing, you can check it in and distr... Greg Shah
01:00 PM Feature #1607: implement full named events support
Good stuff. If it passes conversion testing, we will figure out the check in. I will find out if there are any confl... Greg Shah
12:52 PM Feature #1607: implement full named events support
Added rules to emit the parameter modes, for the PUBLISH statement. I will leave the conversion to run on my machine,... Constantin Asofiei
12:49 PM Feature #1607: implement full named events support
I'm fine with the changes, they look good.
Go ahead with conversion testing. We will bypass runtime testing for t...
Greg Shah
12:19 PM Feature #1607: implement full named events support
A note: for the PUBLISH statement, the mode for each parameter should be collected and emitted the same as is emitted... Constantin Asofiei
11:30 AM Feature #1607: implement full named events support
Added merged sources. Constantin Asofiei
09:06 AM Feature #1607: implement full named events support
Sources are built on top of their bazaar versions as of today.
Testcases will be committed to bzr shortly.
I'll do ...
Constantin Asofiei
07:50 AM Feature #1607: implement full named events support
After looking at what was already implemented in the conversion rules and stubed in the runtime, my conclusions are t... Constantin Asofiei
02:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Note 19 above discusses datetime and datetime-tz support. But the code updates also have a significant number of add... Greg Shah
02:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I have spent quite a bit of time working on this. I solved the known problems mentioned above (e.g. array initializa... Greg Shah
10:41 AM Feature #1635: implement MEMPTR/RAW support
Check it in to bzr and distribute the update. I will apply it to staging. Greg Shah
09:02 AM Feature #1635: implement MEMPTR/RAW support
Conversion tests finally passed (I had some problems with ant and antlr failing and it took some time to figure out w... Costin Savin
08:56 AM Feature #1639: implement socket support
-Conversion tests finally passed (I had some problems with ant and antlr failing and it took some time to figure out ... Costin Savin

01/29/2013

04:19 PM Feature #1649: implement Windows environment/registry access
> Please check it into bzr (p2j_repo/testcases/uast/).
Done.
Eugenie Lyzenko
03:38 PM Feature #1649: implement Windows environment/registry access
Uploaded updated conversion support.
And I have implementing just (character)null approach for missing parameters....
Eugenie Lyzenko
02:54 PM Feature #1649: implement Windows environment/registry access
... Greg Shah
02:28 PM Feature #1649: implement Windows environment/registry access
Another question. In the new approach I need to reformat incomplete calls like this:
getKeyValue(String section)
We...
Eugenie Lyzenko
02:05 PM Feature #1649: implement Windows environment/registry access
The latest testcase is fine. Please check it into bzr (p2j_repo/testcases/uast/). Greg Shah
01:56 PM Feature #1649: implement Windows environment/registry access
... Greg Shah
01:52 PM Feature #1649: implement Windows environment/registry access
The new testcase version has been uploaded here. Eugenie Lyzenko
01:34 PM Feature #1649: implement Windows environment/registry access
> The real worker method should be the form that has all wrapper constructors (e.g. getKeyValue(character, character)... Eugenie Lyzenko
01:13 PM Feature #1649: implement Windows environment/registry access
Code feedback:
1. The stub methods in EnvironmentOps cannot call character.getValue() (et al) without some unknown...
Greg Shah
01:04 PM Feature #1649: implement Windows environment/registry access
Feedback on the testcase:
Please add code that shows the use of:
1. LOAD with BASEKEY "INI"
2. PUT-KEY-VALU...
Greg Shah
09:25 PM Feature #1649: implement Windows environment/registry access
The first version to review. The modification log:
1. The file util/EnvironmentOps.java was changed adding the stubs...
Eugenie Lyzenko
02:01 PM Feature #1635: implement MEMPTR/RAW support
This looks OK. Regression test this for conversion only. I think the runtime portions should be safe enough to incl... Greg Shah
01:38 PM Feature #1635: implement MEMPTR/RAW support
Added proposed update Costin Savin
01:14 PM Feature #1635: implement MEMPTR/RAW support
I agree. Go with it. Greg Shah
12:58 PM Feature #1635: implement MEMPTR/RAW support
I thought that the method will get the type depending on the size/type of the variable.
The second idea seems simple...
Costin Savin
12:38 PM Feature #1635: implement MEMPTR/RAW support
... Greg Shah
12:29 PM Feature #1635: implement MEMPTR/RAW support
1 @It is my impression that you are coding it with little regard to the standard and then you clean it up later.@
T...
Costin Savin
10:31 AM Feature #1635: implement MEMPTR/RAW support
Feedback:
1. Please help me understand why your code formatting is still not matching our coding standards. From ...
Greg Shah
05:37 AM Feature #1635: implement MEMPTR/RAW support
Added proposed update. Costin Savin
01:29 PM Feature #1607: implement full named events support
> 1. Would these be used directly from the converted code or is this a statement about runtime internals?
I don't th...
Constantin Asofiei
01:18 PM Feature #1607: implement full named events support
... Greg Shah
01:07 PM Feature #1607: implement full named events support
Looking at how the PUBLISH and SUBSCRIBE/USUBSCRIBE work, I think these will need to be kept at the external program ... Constantin Asofiei
12:54 PM Feature #1640: implement DOM XML support
As with the other work for milestone 4, please only make the changes required for conversion (and compilation of the ... Greg Shah
12:47 PM Feature #1640: implement DOM XML support
I'm adding myself as watcher to be able to automatically receive the update notifications. Eugenie Lyzenko
12:32 PM Feature #1980 (Closed): runtime support for DOM XML processing
Greg Shah
12:31 PM Feature #1979: conversion support for DOM XML processing
This task is only for tracking time spent. Please put all history into the parent task #1640. Greg Shah
12:30 PM Feature #1979 (Closed): conversion support for DOM XML processing
Greg Shah
12:07 PM Feature #1608: implement full appserver support (from 4GL clients only)
Simple 4GL client code example:... Greg Shah
11:36 AM Feature #1644: implement SOAP support
The full set of related features:
SOAP Header Object:
STATEMENTS: CREATE-SOAP-HEADER
ATTRIBUTES: NUM-HEADER-EN...
Greg Shah
10:48 AM Feature #1977: implement the runtime support for named events
This task is only to track time spent. All history goes in the parent task #1607. Greg Shah
10:48 AM Feature #1977 (Closed): implement the runtime support for named events
Greg Shah
10:47 AM Feature #1976: conversion support for named events
This is just a task for managing time spent and for having the conversion work allocated to milestone 4. All history... Greg Shah
10:46 AM Feature #1976 (Closed): conversion support for named events
Greg Shah
10:35 AM Feature #1639: implement socket support
When I said "Create a class called com/goldencode/p2j/util/Socket for the main socket interfaces.", I was not referri... Greg Shah
10:28 AM Feature #1639: implement socket support
Creating the interface name Socket will cause ambiguities in existing code, is CommonSocket ok as a name replacement? Costin Savin
09:44 AM Feature #1639: implement socket support
Please work on the conversion support for sockets. I expect that you will take my recent feedback on the memptr/raw ... Greg Shah
10:35 AM Feature #1884: add some of the v10 data types and core built-ins
Attached update (although it misses javadoc for a lot of the new APIs) has the following changes:
# added base class...
Constantin Asofiei

01/28/2013

01:43 PM Feature #1635: implement MEMPTR/RAW support
Feedback:
1. The update is missing the NumberType.java file.
2. In BinaryData, please use the same approach to ...
Greg Shah
01:07 PM Feature #1635: implement MEMPTR/RAW support
Added proposed update Costin Savin
11:05 AM Feature #1635: implement MEMPTR/RAW support
The work is decent. Feedback:
1. I know that I said that @get-bits/put-bits should be in integer.java@, but looki...
Greg Shah
10:08 AM Feature #1635: implement MEMPTR/RAW support
Submited proposed update which supports conversion for the items on list except copy-lob and raw (merged with the mos... Costin Savin
09:44 AM Feature #1635: implement MEMPTR/RAW support
No, don't work on RAW() and RAW stmt for now. Greg Shah
08:56 AM Feature #1635: implement MEMPTR/RAW support
Hi, should raw built-in function/statement be present in the conversion support?
I'm asking because I saw it's low ...
Costin Savin
12:00 PM Feature #1884: add some of the v10 data types and core built-ins
Sorry, I missed the "builtin-functions" part. Yes, I agree that the built-ins should take the base class.
In rega...
Greg Shah
11:51 AM Feature #1884: add some of the v10 data types and core built-ins
I refer to the built-in functions which can accept both character and longchar for a parameter, like @replace@. As it... Constantin Asofiei
10:34 AM Feature #1884: add some of the v10 data types and core built-ins
Actually, I was still wanting the parameter set to the specific type. The reason is that this parameter mismatch cas... Greg Shah
10:27 AM Feature #1884: add some of the v10 data types and core built-ins
OK, I think I understand your approach. As we will use a base class (maybe named "text"?), all the built-in functions... Constantin Asofiei
10:16 AM Feature #1884: add some of the v10 data types and core built-ins
Normally, we always define parameters as the exact match to the type originally specified. I prefer to stay with tha... Greg Shah
09:46 AM Feature #1884: add some of the v10 data types and core built-ins
I've re-changed asignee back to me, I've changed it by mistake. Constantin Asofiei
09:17 AM Feature #1884: add some of the v10 data types and core built-ins
More notes about the longchar and character classes. In 4GL, if we have an user-defined function like this:... Constantin Asofiei
08:52 AM Feature #1884: add some of the v10 data types and core built-ins
... Greg Shah
05:23 AM Feature #1884: add some of the v10 data types and core built-ins
Merged ail_upd20121206a.zip with latest bazaar files (the APIs moved from character to TextOps were re-moved to TextO... Constantin Asofiei
09:42 AM Feature #1950 (Closed): conversion support for native library (.so or .DLL) access
Greg Shah
02:10 AM Feature #1950 (Feedback): conversion support for native library (.so or .DLL) access
Constantin Asofiei
01:59 AM Feature #1634: implement full native library (.so or DLL) support
Added testcases for conversion support. Constantin Asofiei
01:36 AM Feature #1634: implement full native library (.so or DLL) support
Passed conversion regression testing, applied to lightning and committed to bzr revision 10156. Constantin Asofiei
01:36 AM Feature #1920: implement persistent procedures
Passed regression testing, applied to lightning and committed to bzr revision 10155. Constantin Asofiei

01/26/2013

12:55 PM Feature #1884: add some of the v10 data types and core built-ins
After looking over Adrian's findings, to me it looks like the best solution is to have two classes - character and lo... Constantin Asofiei
09:12 AM Feature #1634: implement full native library (.so or DLL) support
Actually, I think the runtime part is pretty safe. So if it passes conversion testing, no runtime regression testing... Greg Shah
09:11 AM Feature #1634: implement full native library (.so or DLL) support
This looks good to me. If that is everything that is needed, then you can go ahead and convert/test this. Greg Shah
04:57 AM Feature #1634: implement full native library (.so or DLL) support
Attached update is built on top of https://proj.goldencode.com/redmine/attachments/249/ca_upd20130126a.zip (for #1920... Constantin Asofiei
04:50 AM Feature #1920: implement persistent procedures
The attached update is merged with bzr revision 10154. Constantin Asofiei

01/25/2013

11:51 AM Feature #1634: implement full native library (.so or DLL) support
> The PROCEDURE EXTERNAL doesn't load the library, no matter if it has PERSISTENT or not?
The fact that there is a P...
Constantin Asofiei
10:14 AM Feature #1634: implement full native library (.so or DLL) support
... Greg Shah
09:19 AM Feature #1634: implement full native library (.so or DLL) support
A. misc findings for PROCEDURE EXTERNAL case:
- the name used to define this kind of procedure is case-sensitive(to ...
Constantin Asofiei
09:33 AM Feature #1920: implement persistent procedures
... Greg Shah
07:59 AM Feature #1920: implement persistent procedures
> This should not affect your work, but it should be mentioned that the 4GL does support what I call "malformed" symb... Constantin Asofiei
03:09 AM Feature #1920: implement persistent procedures
The regressions were caused by the fact that I didn't push the correct this-procedure when a trigger was invoked and ... Constantin Asofiei

01/24/2013

03:11 PM Feature #1920: implement persistent procedures
GSO_419 and tc_po_receiving_009 have failed because I think an ERROR condition (caused in a external program invocati... Constantin Asofiei
07:14 AM Feature #1920: implement persistent procedures
Apply the missing changes from bzr to 1920/staging.merged4/ and start testing there as soon as the TIMCO run finishes. Greg Shah
07:04 AM Feature #1920: implement persistent procedures
staging_ca/1920/staging is a staging copy, without Eric's update (is almost in sync with what is in bazaar, only some... Constantin Asofiei
06:39 AM Feature #1920: implement persistent procedures
I am OK with the update.
But Eric's buffer handle changes are currently in staging and the testing yesterday may h...
Greg Shah
06:16 AM Feature #1920: implement persistent procedures
This update does the following:
# removed the bogus next-sibling/prev-sibling attributes from progress.g and methods...
Constantin Asofiei
06:07 AM Feature #1920: implement persistent procedures
Added testcases used for #1920 and #1921. bzr repository was updated too. Constantin Asofiei
12:28 PM Feature #1634: implement full native library (.so or DLL) support
... Greg Shah
12:00 PM Feature #1634: implement full native library (.so or DLL) support
> After copying the native method info into the name map, how do we handle the PROCEDURE EXTERNAL statement? Do we h... Constantin Asofiei
11:39 AM Feature #1634: implement full native library (.so or DLL) support
Good.
After copying the native method info into the name map, how do we handle the PROCEDURE EXTERNAL statement? ...
Greg Shah
11:28 AM Feature #1634: implement full native library (.so or DLL) support
> The conversion approach: generate a class for each DLL being called, the class should have static methods represent... Constantin Asofiei
11:14 AM Feature #1634: implement full native library (.so or DLL) support
> 1. What do we do with the PROCEDURE EXTERNAL calls for their purpose of *registration*? I understand that you are ... Constantin Asofiei
11:07 AM Feature #1635: implement MEMPTR/RAW support
In this example, you are just making 2 MEMPTR vars point to the same buffer. I don't think you can make one MEMPTR p... Greg Shah
10:33 AM Feature #1635: implement MEMPTR/RAW support
I understand now, the correct case to exemplify what I wanted to show looks like this:... Costin Savin
07:11 AM Feature #1635: implement MEMPTR/RAW support
You are mis-interpreting the documentation.
There are 2 serious problems with your example:
1. You should not u...
Greg Shah
05:40 AM Feature #1635: implement MEMPTR/RAW support
From what I've seen from documentation 4GL memptr memory can be shared with other variable:
For example according to...
Costin Savin

01/23/2013

03:01 PM Feature #1957 (Closed): develop a set of testcases that utilize all features of the 4GL socket an...
Greg Shah
02:36 PM Feature #1639: implement socket support
Updated the bazaar, below the wait-for read-response it was the alternate procedural equivalent so not sure why I put... Costin Savin
12:31 PM Feature #1639: implement socket support
Please remove this:... Greg Shah
10:59 AM Feature #1639: implement socket support
Corrected the wrong name , added two new files which implement the same example from point 3 but with procedural mode... Costin Savin
08:21 AM Feature #1639: implement socket support
... Greg Shah
07:21 AM Feature #1639: implement socket support
Corrected the name that used underscore and added 3 files with the test case described at points 3-4 using read and w... Costin Savin
02:35 PM Feature #1920: implement persistent procedures
OK, now I have the correct version of 0123e.zip, which does the following:
# ControlFlowOps APIs are re-written to u...
Constantin Asofiei
02:14 PM Feature #1920: implement persistent procedures
I've deleted 0123e.zip, as it wasn't supposed to get uploaded. Constantin Asofiei
02:03 PM Feature #1920: implement persistent procedures
> Actually, I meant to handle this case but the code I wrote was not correct. I think this form of my example is bet... Constantin Asofiei
01:03 PM Feature #1920: implement persistent procedures
... Greg Shah
12:51 PM Feature #1920: implement persistent procedures
And another thought about using generics: I would like to leave the non-generic versions of the functions in place, t... Constantin Asofiei
12:45 PM Feature #1920: implement persistent procedures
> [...]
>
> I agree. Please add a history entry providing the suitable details.
Understood.
> 1. What is stil...
Constantin Asofiei
12:26 PM Feature #1920: implement persistent procedures
Code review feedback: the latest code looks good.... Greg Shah
11:09 AM Feature #1920: implement persistent procedures
This version adds support for functions returning int64, rowid and recid. Note that if such functions are used with D... Constantin Asofiei
10:47 AM Feature #1920: implement persistent procedures
Code review feedback:
1. In ExpressionConversionWorker, the history entry needs to be 036. It also should not be ...
Greg Shah
09:44 AM Feature #1920: implement persistent procedures
> ... it almost passed regression testing in MAJIC (some tests have failed with what looks like a comon cause).
My c...
Constantin Asofiei
09:41 AM Feature #1920: implement persistent procedures
> Please add recid, rowid and int64.
Note that I will need to add BlockManager.*function APIs for these types too.
...
Constantin Asofiei
08:47 AM Feature #1920: implement persistent procedures
... Greg Shah
05:43 AM Feature #1920: implement persistent procedures
Constantin Asofiei wrote:
> 7. @FOR EACH table WHERE my-field = DYNAMIC-FUNCTION("something" IN some-handle)@
> [.....
Eric Faulhaber
03:36 AM Feature #1920: implement persistent procedures
1. please check the return types for all functions - currently, only these return types are supported: integer, decim... Constantin Asofiei
01:44 AM Feature #1920: implement persistent procedures
About the review feedback:
1. in functions.rules I need the 4GL function name from the static string passed to the D...
Constantin Asofiei
10:42 AM Feature #1972: provide full-support for DYNAMIC-FUNCTION set to function parameters
In 4GL, when a parameter of a function call is set as the the returned value of a DYNAMIC-FUNCTION call, as in:
<pre...
Constantin Asofiei
10:35 AM Feature #1972 (Closed): provide full-support for DYNAMIC-FUNCTION set to function parameters
Constantin Asofiei
10:04 AM Feature #1649: implement Windows environment/registry access
... Greg Shah
09:29 AM Feature #1649: implement Windows environment/registry access
Currently there are no significant issues with the statements:
PUT-KEY-VALUE, USE, LOAD, UNLOAD
The small questio...
Eugenie Lyzenko

01/22/2013

05:34 PM Feature #1920: implement persistent procedures
Code review feedback:
1. I'm not sure how important it is, but it may be better to use ExpressionConversionWorker....
Greg Shah
04:03 PM Feature #1920: implement persistent procedures
More research and thoughts on dynamic-function() return types:
1. I have been looking at all the call sites for th...
Greg Shah
11:10 AM Feature #1920: implement persistent procedures
Issues fixed/changed by this update:
# function/internal procedures are searched case-insensitive (both in the conve...
Constantin Asofiei
10:58 AM Feature #1920: implement persistent procedures
Let's go ahead and finalize your update and get it regression tested and checked in. If we have rework for some of t... Greg Shah
10:44 AM Feature #1920: implement persistent procedures
I ask this because I noticed that some attributes are read-only for some handle types and writable for others (thus w... Constantin Asofiei
10:27 AM Feature #1920: implement persistent procedures
... Greg Shah
06:59 AM Feature #1920: implement persistent procedures
> Don't forget that function names are matched case-insensitively.
About the case-insensitivity: I see that this app...
Constantin Asofiei
06:21 AM Feature #1920: implement persistent procedures
Greg: can you ran a report and let me know which attributes/methods are used in the project ? I want to make sure we ... Constantin Asofiei
12:44 PM Feature #1639: implement socket support
I looked at the new testcases. Here is some feedback:
1. Please do not use spaces in filenames. You can use bzr ...
Greg Shah
12:08 PM Feature #1639: implement socket support
In your opinion, are you done with this work? Greg Shah
12:07 PM Feature #1639: implement socket support
... Greg Shah
12:04 PM Feature #1639: implement socket support
Submited testcases to bazaar. Costin Savin
11:29 AM Feature #1639: implement socket support
Tried to implement a procedural model according to hints given by documentation using CONNECTED() and GET-BYTES-AVAIL... Costin Savin
10:52 AM Feature #1639: implement socket support
My guess: Progress implements MEMPTRs instances literally as an internal pointer to some memory. This probably means... Greg Shah
08:34 AM Feature #1639: implement socket support
The solution for this would be to use get-bytes-available and use it in get-string, like:... Costin Savin
07:31 AM Feature #1639: implement socket support
It seems there is a problem when reading in the connect procedure.
The problem seems to be with the buffer variable...
Costin Savin
12:13 PM Feature #1963 (WIP): implement conversion support for MEMPTR/RAW
Costin Savin

01/21/2013

03:04 PM Feature #1639: implement socket support
... Greg Shah
01:58 PM Feature #1639: implement socket support
*Notes from 4GL Test results*
- You can get the socket handle for which you set the response procedure by using *S...
Costin Savin
01:58 PM Feature #1639: implement socket support
1. Yes
2. Will test more.
3 - 4 built the program , unfortunately it seems to block when testing, I'm working to fi...
Costin Savin
01:33 PM Feature #1920: implement persistent procedures
Eric, thanks, I've tested it with the class of P2J frame instance and it returns true, so it will work with the class... Constantin Asofiei
12:56 PM Feature #1920: implement persistent procedures
Constantin, as discussed, I have added isProxyClass(Class<?>) to the ProxyFactory class and attached the update here.... Eric Faulhaber
12:20 PM Feature #1920: implement persistent procedures
This version does the following:
- a few fixes for issues discovered when using MAJIC
- collect the return types for ...
Constantin Asofiei
11:07 AM Feature #1920: implement persistent procedures
Yes, I think you are right. We process 1 AST *sequentially* through each rule-set.... Greg Shah
09:35 AM Feature #1920: implement persistent procedures
> Annotations is designed such that every rule-set is run against the entire set of source files before the next rule... Constantin Asofiei
07:49 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
To be able to use Java method calls for simple function calls (without IN SUPER or IN handle clauses), we need to emi... Constantin Asofiei
07:45 AM Bug #1971 (Closed): emit worker versions for functions to fix source-procedure handle
Constantin Asofiei
03:36 AM Feature #1970: improve ControlFlowOps method resolution by reflection
Cache the Method objects obtained by Class.getMethod (and other Class APIs) by class/method name/signature, to improv... Constantin Asofiei
03:35 AM Feature #1970 (WIP): improve ControlFlowOps method resolution by reflection
Constantin Asofiei
03:32 AM Bug #1969: buffer names in get-signature
In collect_names.rules, when collecting the name of the buffer from a BUFFER FOR <buf-name> parameter, the name must ... Constantin Asofiei
03:31 AM Bug #1969 (Closed): buffer names in get-signature
Constantin Asofiei
03:29 AM Bug #1968 (Closed): implement MAP TO actual-name IN handle clause for function definitions
Constantin Asofiei

01/20/2013

11:06 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Ovidiu: I am going to make the final modifications on the latest code you have posted. I know you are busy with othe... Greg Shah
 

Also available in: Atom