Activity
From 01/26/2014 to 02/24/2014
02/24/2014
- 02:26 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- Greg Shah wrote:
> > Can it ever happen to have the array reference registered to multiple scopes on the scope stack... - 02:18 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- > Can it ever happen to have the array reference registered to multiple scopes on the scope stack?
Yes. I believe... - 01:47 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- When the dynamic array is resized (@EXTENT@ statement is encountered), old array reference is "deregistered" and new ...
- 12:11 PM Feature #2145 (Closed): eliminate program-name limitations
- 11:50 AM Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> Have you retested the "standalone" super proc/persistent proc testcases?
Yes, the tests are OK.
... - 10:49 AM Feature #2145: eliminate program-name limitations
- Code Review 0222b/e
I am fine with the changes. This is another nice improvement/refactoring of the code such tha...
02/23/2014
- 03:15 PM Feature #1599 (WIP): shift EXP implementation (MathOps.pow()) to BigDecimal
- 03:13 PM Bug #2133 (WIP): fix precision for decimal, dynamic-extent variables
- 03:12 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- The decimal precision is effectively lost when (1) unfixed decimal array is defined and later fixed with the @EXTENT@...
- 04:18 AM Feature #2145 (Review): eliminate program-name limitations
- 04:14 AM Feature #2145: eliminate program-name limitations
- The 0222b.zip and 0222e.zip (from #2248) have passed regression testing, after checking the cumulative regression tes...
02/22/2014
- 09:47 AM Feature #2145: eliminate program-name limitations
- Failures during testing of 0222b.zip: there are cases like this (MAJIC uses them):...
- 05:05 AM Feature #2145: eliminate program-name limitations
- This version allows java-style calls for internal and external procedures and centralizes the maintenance of procedur...
02/21/2014
- 09:15 AM Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> Option 3 is the best solution, IF it is possible.
I think I will go ahead with this one. The onl... - 08:31 AM Feature #2145: eliminate program-name limitations
- Option 3 is the best solution, IF it is possible.
A modified option 1 may be the next best approach. The idea is ... - 04:10 AM Feature #2145 (WIP): eliminate program-name limitations
- Regression testing showed problems related to calling the hand-written java code: we need to determine the policy of ...
02/20/2014
- 04:45 PM Feature #1625: implement OUTPUT TO PRINTER on Windows
- The Linux/UNIX support for OUTPUT TO PRINTER is already done from the work in #1631. The remaining work for this tas...
- 04:37 PM Feature #1824 (Closed): client platform delegate implementation
- The design choices implemented in #1811 eliminate the need for this work.
- 11:05 AM Feature #2145: eliminate program-name limitations
- > The only dependence on reflection is the "java-style calls of legacy user-def functions", when we need to determine...
- 10:56 AM Feature #2145 (Review): eliminate program-name limitations
- Greg Shah wrote:
> We don't have much choice in coding so much dependence on reflection and the old approach was als... - 09:58 AM Feature #2145: eliminate program-name limitations
- Code Review 0220d
I am OK with the changes. As always with the procedure processing, this stuff is pretty nasty. ... - 09:21 AM Feature #2145 (WIP): eliminate program-name limitations
- This solves the OOME and the SOURCE- and TARGET-PROCEDURE deviations. Is going through testing now.
- 08:21 AM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0220a
Everything looks good. If it passes runtime regression testing, you can check it in and distrib... - 03:58 AM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- I also moved the @log@ private methods down to the private methods section. The attached changes are submitted for re...
- 01:26 AM Feature #1624: add support for PUT CONTROL
- Evgeny Kiselev wrote:
> Do I need to commit testcases ?
Of course, the testcases need to be in the repository. - 11:00 PM Feature #1624: add support for PUT CONTROL
- Do I need to commit testcases ?
- 11:59 PM Feature #2208: create a java application running web services for testing purposes
- I've committed intermediate version of test server to the @testcases/uast/web_services/server/@.
To run this from ID...
02/19/2014
- 03:41 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0219a
The code looks good. My only comments relate to some coding standards:
1. Lines 608 and 614 a... - 02:52 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Please review the attached changes. Testcases checked in to testcases/uast/math/exp.p.
- 12:15 PM Feature #1624 (Closed): add support for PUT CONTROL
- 11:52 AM Feature #1624: add support for PUT CONTROL
- update evk_upd20140214a.zip has been passed regression testing.
Committed to bzr revision 10470. - 11:13 PM Feature #1624 (Review): add support for PUT CONTROL
02/18/2014
- 01:50 PM Feature #2145: eliminate program-name limitations
- This should solve the SOURCE- and TARGET-PROCEDURE cases (when invoking an external program or a trigger). Also, it i...
- 11:02 AM Feature #1634: implement full native library (.so or DLL) support
- Almost.
> take the testcases from @native_library_calls_4gl_..._sample_20131107.zip@
No, that is just a slightly... - 10:51 AM Feature #1634: implement full native library (.so or DLL) support
- Greg,
The question about task #2234. The goal is to take the testcases from @native_library_calls_4gl_..._sample_2...
02/17/2014
02/16/2014
- 08:01 AM Feature #1624: add support for PUT CONTROL
- Check it in and distribute it.
- 03:20 AM Feature #1624: add support for PUT CONTROL
- Evgeny Kiselev wrote:
> Final update. Regression is running now.
Passed regression testing - 10:04 PM Feature #1634: implement full native library (.so or DLL) support
- Between 2 regression testing runs, all tests have passed except for GSO 167 (and TC JOB 002 which fails as expected i...
02/15/2014
- 01:24 PM Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> > my concern is that, if the PROPATH gets modified, we might resolve the relative name to a compl... - 01:20 PM Feature #2145: eliminate program-name limitations
- > my concern is that, if the PROPATH gets modified, we might resolve the relative name to a completely different prog...
- 09:06 AM Feature #2145: eliminate program-name limitations
- This one proves a little more challenging: the procedure names in error messages and the procedure's @FILE-NAME@ and ...
- 08:59 AM Feature #1634: implement full native library (.so or DLL) support
- This update is merged up to bzr revision 10466. I am going back through runtime regression testing. The first run f...
- 08:56 AM Feature #1598 (Closed): shift LOG implementation (MathOps.log()) to BigDecimal
- 07:32 AM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Committed to bzr revision 10466.
- 07:41 PM Feature #1624: add support for PUT CONTROL
- Final update. Regression is running now.
02/14/2014
- 05:47 PM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Code Review 0214a
The changes look good. You can check them in and distribute them. - 07:13 AM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Introduced @toBigDecimal@ abstract method in @NumberType@ and fixed the file headers. The code changes passed regress...
- 05:26 PM Feature #1624: add support for PUT CONTROL
- Update the copyright dates and post the final update here. Then start regression testing (both conversion and runtim...
- 07:45 PM Feature #1624: add support for PUT CONTROL
- Greg Shah wrote:
> Code Review 0208a
>
> 1. Does the @Steam.generateFormattedText()@ have implications when the s... - 02:16 AM Feature #2208: create a java application running web services for testing purposes
- Evgeny Kiselev wrote:
> Where I can upload update ?
> I've ~20mb zip archive (with axis2 libs and configs).
Commi... - 07:23 PM Feature #2208: create a java application running web services for testing purposes
- Where I can upload update ?
I've ~20mb zip archive (with axis2 libs and configs).
02/13/2014
- 01:30 PM Feature #1634: implement full native library (.so or DLL) support
- All testcase updates and captured logs/output are checked into the testcases project.
The code has passed conversi... - 01:03 PM Feature #1634: implement full native library (.so or DLL) support
- As can be seen from the logs, the remaining diffs are:
1. A missing error 86 in one call to output_float_from_buff... - 12:36 PM Feature #1634: implement full native library (.so or DLL) support
- This incorporates many fixes and the code review feedback. It allows the API tests to run properly on Linux. The on...
02/12/2014
- 06:27 PM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Code Review 0212a
It looks pretty good. Fix these minor issues and get it tested:
1. I'd prefer to add an abst... - 04:33 PM Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- The attached file contains @log@ function implementation and related changes for review.
The implemented @log@ fun... - 05:23 PM Feature #1634: implement full native library (.so or DLL) support
- > or better:...
- 03:59 PM Feature #1597 (Closed): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- 02:04 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Committed to revision 10461.
- 10:37 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0209a
The code looks good. Please commit and distribute it. - 10:23 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- The attached file is the final version.
Note, that the previously added condition of @sqrt(?) == 1@ was removed. ... - 01:26 AM Feature #2208: create a java application running web services for testing purposes
- Evgeny Kiselev wrote:
> Yes, you are right.
If you think you can solve this in 2-4 hours, then go ahead and solve i...
02/11/2014
- 05:48 PM Feature #2208: create a java application running web services for testing purposes
- Yes, you are right.
- 02:12 PM Feature #2208: create a java application running web services for testing purposes
- OK, I think I understand your problem: you are you using embedded AXIS2 web server, which does not support HTTPS. An...
- 08:17 PM Feature #2208: create a java application running web services for testing purposes
- I have problem with SSL. It's not possible to do it in the internal Axis2 web server(SimpleHttpServer).
Here is a ... - 05:47 PM Feature #1624: add support for PUT CONTROL
- Code Review 0208a
1. Does the @Steam.generateFormattedText()@ have implications when the statement is not PUT CONT...
02/10/2014
- 08:09 PM Feature #1624: add support for PUT CONTROL
- 1) Added conversion for @COPY-LOB@ from file to memptr
2) Added implementation for @COPY-LOB@
3) Added for @RAW@ ty...
02/06/2014
- 10:17 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Looks great!
- 10:02 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Yes, the "4GL" is a typo, thanks for catching it. I am attaching a fix and sending it to regression test.
- 08:15 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0205a
This looks good.
My only question is about this table:... - 07:20 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- The input of one is covered by the initial approximation, but yes it won't hurt if stated explicitly.
New in the a...
02/05/2014
- 09:03 AM Feature #1624: add support for PUT CONTROL
- > except wrong conversion of @copy-lob from file "test_put_control.txt" to m.@. P2J convert it's in uncompilable code...
- 07:58 PM Feature #1624: add support for PUT CONTROL
- ...
02/03/2014
- 06:57 PM Feature #1624: add support for PUT CONTROL
- The first testcase above has a bug (you write out 257 bytes but size the memptr at 256).
Also, it doesn't test the... - 07:15 PM Feature #1624: add support for PUT CONTROL
- updated tests....
- 06:46 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0203b
Overall, this is very good.
1. Should we put a quick out for BigDecimal.ONE?
2. Add javado... - 04:45 PM Feature #1597 (Review): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- 09:51 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Attached file changes the precision of the sqrt algorithm to be defined by @decimal.MAX_SCALE@.
- 05:06 AM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- I didn't realize the evaluator already casts the operands to proper types. Attached is the updated code.
- 06:25 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- There are 3 other versions of pow() and these all resolve down to using @Math.pow()@ and @double@. These need to be ...
- 04:49 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- The title of the issue mentions pow and exp. @MathOps@ contains only @pow@ method, but that is already using @BigDeci...
- 04:44 PM Feature #1598 (WIP): shift LOG implementation (MathOps.log()) to BigDecimal
02/02/2014
- 06:42 PM Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Attached are the changes for initial review.
The implemented algorithm yields the same results as the native Progr...
01/31/2014
- 09:20 AM Feature #1624: add support for PUT CONTROL
- It is close. Some things to add:
1. I think the testing code is too dependent upon using a delimiter. In a scena... - 08:03 AM Feature #1624: add support for PUT CONTROL
- Is this test correct ?...
- 06:45 AM Feature #1624 (WIP): add support for PUT CONTROL
01/30/2014
- 02:33 PM Feature #2145: eliminate program-name limitations
- > This suggests that looking into the java stack trace is not correct.
Yes. At the time it was originally coded, ... - 01:46 PM Feature #2145: eliminate program-name limitations
- This suggests that looking into the java stack trace is not correct. Instead, @ControlFlowOps@ should keep a stack f...
- 01:05 PM Feature #2145: eliminate program-name limitations
- To understand the limitations of the P2J @PROGRAM-NAME@ implementation, please see the JavaDoc for @EnvironmentOps.ge...
01/29/2014
- 12:27 PM Feature #1634: implement full native library (.so or DLL) support
- ... continued
*common-progress.rules*
is good except for the fact that maybe we should make the condition at line ...
01/28/2014
- 04:23 PM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> ...
> Ovidiu: please review the rules/include/* changes, in regard to assign trigger var def sup... - 07:54 PM Feature #1634: implement full native library (.so or DLL) support
- OK. Now we are completely using our own libffi Windows builds.
Building libffi libraries from sources using MSYS a...
01/27/2014
- 05:59 PM Feature #1634: implement full native library (.so or DLL) support
- > What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
Yes. But we would only use that envi... - 05:44 PM Feature #1634: implement full native library (.so or DLL) support
- Greg, the question. What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
- 02:34 PM Feature #1634: implement full native library (.so or DLL) support
- The update evl_upd20140127a.zip committed in bzr as 10456. No regression testing required, only Windows syntax code w...
- 01:38 PM Feature #1634: implement full native library (.so or DLL) support
- Conversion regression testing for ges_upd20140127a.zip has passed. No change occurs in the output. This has been ch...
- 01:31 PM Feature #1634: implement full native library (.so or DLL) support
- Code Review evl_upd20140127.zip
The change is fine. Check it in and distribute it. Then post the revision number... - 01:02 PM Feature #1634: implement full native library (.so or DLL) support
- The updates fixes compilation error on Wndows. Also the binaries allow to build p2j.dll on Windows. Has both 64-bit a...
- 11:27 AM Feature #1634: implement full native library (.so or DLL) support
- This update has some important fixes to make the commons cases work. There is still at least 1 known problem (dealin...
- 08:49 AM Feature #1634: implement full native library (.so or DLL) support
- Do you have the compilation fixes ready now? If so, please upload them for review.
Have you resolved the way to b...
Also available in: Atom