Activity
From 06/16/2015 to 07/15/2015
07/16/2015
- 11:11 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> * if a procedure was called then that is a serious error and the condition will stop execut...
07/15/2015
- 04:05 PM Bug #2592: improve support for implicit type conversions
- I updated the branch. What is new in revno 10910:
* moved @FieldAssigner@, @OutputExtentField@ and @InputOutputExten... - 05:31 AM Bug #2592: improve support for implicit type conversions
- The revno 10909/2592 test ended with some failures:
* 3 tests in CTRL+C (known to fail in most runs)
* gso_269/48 i...
07/14/2015
- 02:44 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> There is another reason for my question: once those classed are moved to new package the co... - 02:18 PM Bug #2592: improve support for implicit type conversions
- Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... To be honest, I am not completely pleased with the class hie... - 02:07 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> The new part is in @ else if (AEP.isAssignableFrom(expectedType) && AEP.isAssignableFrom(ar... - 01:56 PM Bug #2592: improve support for implicit type conversions
- Eric Faulhaber wrote:
> Code review 2592/10908
>
> I only looked at the diffs from 10907 to 10908.
>
> The con... - 12:16 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> ... To be honest, I am not completely pleased with the class hierarchy I merged because it ... - 12:12 PM Bug #2592: improve support for implicit type conversions
- Code review 2592/10908
I only looked at the diffs from 10907 to 10908.
The conversion change in @control_flow.r...
07/13/2015
- 02:56 PM Bug #2592: improve support for implicit type conversions
- I have found a new issue when calling a procedure with a single EXTENT parameter. Consider a procedure...
- 07:15 AM Bug #2592: improve support for implicit type conversions
- Eric Faulhaber wrote:
> Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks ... - 12:16 AM Bug #2592: improve support for implicit type conversions
- Ovidiu, I did a quick review of 2592/10907 (though you have not asked for it yet). It looks as though you're nearly f...
- 01:55 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- All changes except Stream class is passed regression testing.
Changes in Stream class is not fully correct. gso_103 ...
07/10/2015
- 02:08 PM Bug #2592: improve support for implicit type conversions
- Sorry I didn't make this connection sooner. OK, so we've never implemented a solution. Ovidiu, please move forward wi...
- 02:03 PM Bug #2592: improve support for implicit type conversions
- Sorry I didn't realize this earlier, the output parameter precision for fields is covered by #2295.
- 02:00 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:... - 01:49 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> The problem is that we need to temporarily overwrite the precision of the database field un... - 01:25 PM Bug #2592: improve support for implicit type conversions
- It seems like this case was somehow overlooked, with revno 10895 of main trunk it displays:...
- 12:42 PM Bug #2592: improve support for implicit type conversions
- Eric Faulhaber wrote:
> Ovidiu, please try this testcase without your changes applied and track back to where it bro... - 12:40 PM Bug #2592: improve support for implicit type conversions
- Ovidiu, please try this testcase without your changes applied and track back to where it broke (which may be part of ...
- 12:33 PM Bug #2592: improve support for implicit type conversions
- Ovidiu,
it's been a while since I was playing with extents.
The case you refer to shows that 4GL doesn't propag... - 12:32 PM Bug #2592: improve support for implicit type conversions
- Hynek,
I found in one of your testcase files the following test:... - 09:35 AM Bug #2592: improve support for implicit type conversions
- The 2592 branch was rebased with 10895 main trunk and now it is at revno 10906.
07/09/2015
- 11:37 AM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> ...
> Since the @rv@ is really the same object as in first call, the fields will be overwr... - 10:15 AM Bug #2592: improve support for implicit type conversions
- It looks to me that line 4551 in 2592/10903 will only check for types errors: both argument and formal parameter to b...
07/08/2015
- 02:18 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> I guess that if the size is handles in @ControlFlowOps@, there is no need for the additiona... - 01:07 PM Bug #2592: improve support for implicit type conversions
- Eric Faulhaber wrote:
> I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point... - 11:16 AM Bug #2592: improve support for implicit type conversions
- I read through @ControlFlowOps@ a bit more, and I must be misunderstanding your second point above, because it appear...
- 11:07 AM Bug #2592: improve support for implicit type conversions
- Ovidiu wrote (in email):
> There are two main issues I would like to discuss and I would appreciate additional help:...
06/29/2015
- 04:24 PM Bug #2592: improve support for implicit type conversions
- The issue for Hynek's earlier work is #2293.
- 04:18 PM Bug #2592: improve support for implicit type conversions
- As I was reviewing this code, I was wondering why @VariableAssigner@ and @OutputParameterAssigner@ were not in the @c...
- 02:48 PM Bug #2592: improve support for implicit type conversions
- After running the testcase procedure against P4GL, I was able to detect the cases where the automatic/implicit conver...
06/26/2015
- 04:03 PM Bug #2592: improve support for implicit type conversions
- The testcases project was updated with @uast/procedures/conversion-params.p@. It contains the matrix for conversion p...
- 12:53 PM Bug #2592: improve support for implicit type conversions
- The branch 2592 has been updated and rebased (main trunk revision 10887). It is not at revision 10892.
It passed my ...
06/25/2015
- 12:25 PM Bug #2592: improve support for implicit type conversions
- Very good plan and design.
- 11:50 AM Bug #2592: improve support for implicit type conversions
- Support for variables.
I am thinking of the following changes in code:
* an abstract class @Assigner@ with @BaseDat... - 11:31 AM Bug #2592: improve support for implicit type conversions
- These are very good points (the complete matrix and the support for variables). I think both of these issues need to...
- 10:10 AM Bug #2592 (WIP): improve support for implicit type conversions
- I updated the code according your reviews. The new revno is 10890.
Constantin: your 2nd question is very good. I n... - 04:26 AM Bug #2592: improve support for implicit type conversions
- Greg Shah wrote:
> Constantin: as the owner of @ControlFlowOps@, do you have any concerns with the update?
The logi...
06/24/2015
- 05:04 PM Bug #2592 (New): improve support for implicit type conversions
- Code Review Task Branch 2592 Revision 10889
The core functionality seems good.
1. In @FieldAssigner.assign()@ y... - 03:53 PM Bug #2592: improve support for implicit type conversions
- 10889 looks good, thanks, but I still want Greg or Constantin's stamp of approval, particularly on the @ControlFlowOp...
- 03:48 PM Bug #2592 (WIP): improve support for implicit type conversions
- New changes committed to revision 10889.
- 03:29 PM Bug #2592: improve support for implicit type conversions
- Code review 10888:
This looks good to me, with 2 very minor points:
* Please rename @FieldAssigner$Scope.list@ to... - 03:01 PM Bug #2592: improve support for implicit type conversions
- The branch has been updated to revision 10888. I already tested with ETF and it passed all +JULIAN_DATE tests that we...
- 01:32 PM Bug #2592: improve support for implicit type conversions
- Ovidiu Maxiniuc wrote:
> Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>... - 12:40 PM Bug #2592: improve support for implicit type conversions
- > Sorry for these incremental status updates.
You have done exactly the right thing in posting these different ide... - 12:30 PM Bug #2592: improve support for implicit type conversions
- Looks like my idea from note 7 can be easier implemented thanks to the @List<FieldAssigner>@ from @FieldAssigner@ con...
- 11:55 AM Bug #2592: improve support for implicit type conversions
- After further thinking:
what if we allow the internal variable from @FieldAssigner@ to be updated. For example, if t... - 10:47 AM Bug #2592: improve support for implicit type conversions
- I have created branch 2592 from the main trunk (revno 10886). I committed the intermediary changes in @ControlFlowOps...
- 10:06 AM Bug #2592: improve support for implicit type conversions
- I started the implementation for the optional conversions in message passing parameters. The forward checking is done...
06/19/2015
- 03:41 PM Bug #2592: improve support for implicit type conversions
- I continued by digging into procedure call mechanism. In @ControlFlowOps@, there is @InternalEntryCaller.validate()@ ...
- 03:39 PM Bug #2592: improve support for implicit type conversions
- On 06/19/2015 10:04 PM, Constantin Asofiei wrote:
> Eric/Ovidiu,
>
> This is a new discovery. And it looks like i... - 03:38 PM Bug #2592: improve support for implicit type conversions
- I found the following external procedure @caller.p@:...
- 03:36 PM Bug #2592 (Closed): improve support for implicit type conversions
Also available in: Atom