FWD » Core Development » Base Language

02/19/2019

06:08 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Good. :) I was worried that I had missed something.
As we are still on the overload subject: I ... Constantin Asofiei

05:53 PM Feature #3751: implement support for OO 4GL and structured error handling

Good. :) I was worried that I had missed something. Greg Shah

05:46 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Do you have a testcase that shows a different result?
No.
Constantin Asofiei

05:42 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> There's another case regarding the parameter modes at the method's signature: the caller... Greg Shah

02/18/2019

06:23 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> There's another case regarding the parameter modes at the method's signature: the caller... Constantin Asofiei

03:45 PM Feature #3751: implement support for OO 4GL and structured error handling

There's another case regarding the parameter modes at the method's signature: the caller is not required to specify t... Constantin Asofiei

02/14/2019

05:54 PM Feature #3751: implement support for OO 4GL and structured error handling

> But there is no tempidx annotation emitted by the parser, so I don't know the targeted constructor. Greg, can you p... Greg Shah

05:48 PM Feature #3751: implement support for OO 4GL and structured error handling

And something else to mention: after FUNCTION/PROCEDURES and the CALL handle, the 4GL's 'reflection' is the third way... Constantin Asofiei

05:30 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I understand the need for the modes/signature for proper runtime matching. It does seem like we ... Constantin Asofiei

05:21 PM Feature #3751: implement support for OO 4GL and structured error handling

> But there is no tempidx annotation emitted by the parser, so I don't know the targeted constructor. Greg, can you p... Greg Shah

05:15 PM Feature #3751: implement support for OO 4GL and structured error handling

I understand the need for the modes/signature for proper runtime matching. It does seem like we could put all of thi... Greg Shah

05:08 PM Feature #3751: implement support for OO 4GL and structured error handling

The same idea is with the constructors - the 4GL compilers 'hard links' the NEW with the constructor definition. We ... Constantin Asofiei

04:56 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > I solved this by emitting the signature at the Java method or constructor (for OO cases).
> ... Constantin Asofiei

04:50 PM Feature #3751: implement support for OO 4GL and structured error handling

> I solved this by emitting the signature at the Java method or constructor (for OO cases).
Can you clarify this... Greg Shah

04:24 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> FYI, @ClassDefinition.isWideningTypeMatch@ was not extracted correct.
Fixed in 3750b ... Greg Shah

02:11 PM Feature #3751: implement support for OO 4GL and structured error handling

FYI, @ClassDefinition.isWideningTypeMatch@ was not extracted correct. Constantin Asofiei

12:46 PM Feature #3751: implement support for OO 4GL and structured error handling

The constructors referenced by the @NEW@ statement must always be disambiguated by the parser phase. The reason is b... Constantin Asofiei

02/05/2019

11:24 AM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I understand. I was just wondering if our BlockManager exception infrastructure (try/catch/final... Constantin Asofiei

11:21 AM Feature #3751: implement support for OO 4GL and structured error handling

From Constantin:
> 4GL has some cases where a builtin ERROR condition gets converted to a SysError OO exception if... Greg Shah

01/31/2019

03:52 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu, about rev 11329:
* there was a merge typo in ObjectOps - I've fixed it in 11330
* you can use @AtomicIntege... Constantin Asofiei

10:41 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The idea is the @? extends Bar@ - Java doesn't allow accessing a private method from a s... Ovidiu Maxiniuc

08:55 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Does it compile if you edit the file to look like @((Bar) fo... Constantin Asofiei

08:49 AM Feature #3751: implement support for OO 4GL and structured error handling

The same cast is currently generated for private methods. Ovidiu Maxiniuc

08:45 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Does it compile if you edit the file to look like @((Bar) foo.ref()).myName.assign(p1);@... Ovidiu Maxiniuc

08:14 AM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> *2*. The destructors are not called for me because for me @ProcedureManager.getStackEntry(0... Constantin Asofiei

07:15 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin,
Three notes after our last conversation:
*1*. I got what you meant. I will add the necessary support f... Ovidiu Maxiniuc

06:26 AM Feature #3751: implement support for OO 4GL and structured error handling

I don't think counting these objects will be the problem. I think this can be easily done by a context-local integer ... Ovidiu Maxiniuc

01/30/2019

06:31 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > One more thing to add: do not convert to bulk delete a @for ... Constantin Asofiei

06:23 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> One more thing to add: do not convert to bulk delete a @for tt-buffer: delete tt-buffer... Eric Faulhaber

05:59 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I committed some fixes and a solution for bulk delete. The update contains some optimisatio... Constantin Asofiei

03:32 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> If you specify the @FOR@, then the name of the handle must be an existing variable in the externa... Constantin Asofiei

03:29 PM Feature #3751: implement support for OO 4GL and structured error handling

What a ridiculous undocumented "feature". To be clear: when the @FOR handle@ is present, it seems to map the "proced... Greg Shah

12:48 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The only way I can make it work is like this:
> [...]
> I think you are correct, the F... Constantin Asofiei

12:42 PM Feature #3751: implement support for OO 4GL and structured error handling

The only way I can make it work is like this:... Constantin Asofiei

12:37 PM Feature #3751: implement support for OO 4GL and structured error handling

There is an undocumented "feature" that allows @TABLE-HANDLE FOR@ to be specified. It was seen in customer code and ... Greg Shah

12:27 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin: Can you think of any reason I should fix this instead of deleting it?
I think it was... Constantin Asofiei

12:01 PM Feature #3751: implement support for OO 4GL and structured error handling

In @common-progress@ there is this function:... Greg Shah

01:45 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Please focus on finding the hooks for field assignment and record deletion. I'll fix an... Ovidiu Maxiniuc

01/29/2019

03:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > The DESTRUCTOR is called when the object is explicitly delet... Constantin Asofiei

10:25 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The DESTRUCTOR is called when the object is explicitly deleted (via @DELETE OBJECT@) or ... Ovidiu Maxiniuc

11:59 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> 3750b 11320 fixes a conversion problem.
It also converted and compiled fully with the P... Constantin Asofiei

01/28/2019

05:37 PM Feature #3751: implement support for OO 4GL and structured error handling

3750b 11320 fixes a conversion problem. Constantin Asofiei

03:43 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Do we not know which class' objects will be stored in a field at conversion time, and whethe... Constantin Asofiei

03:40 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Let me rephrase this. We wouldn't 'bulk delete' a loop like this, right?
> [...]
Co... Eric Faulhaber

03:35 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I think we still could maintain the bulk operations by queryi... Constantin Asofiei

03:25 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> I think we still could maintain the bulk operations by querying the object references first,... Constantin Asofiei

03:20 PM Feature #3751: implement support for OO 4GL and structured error handling

Exactly. This is what I meant in note 436. Ovidiu Maxiniuc

03:15 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Take for example an EMPTY-TEMP-TABLE statement or a table goi... Eric Faulhaber

03:02 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Take for example an EMPTY-TEMP-TABLE statement or a table going out of scope. We just do an ... Constantin Asofiei

02:56 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Are there side effects to an object being gc'd, such that the... Eric Faulhaber

02:55 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I don't think that this is possible (as you noted also, the bulk delete is the main cause h... Constantin Asofiei

02:41 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> BTW, I see that the destructor is not yet called. Will it be called automatically when the ... Constantin Asofiei

02:36 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Good question. Yes, there is legacy @DESTRUCTOR@ code which needs to be executed on del... Ovidiu Maxiniuc

02:30 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Are there side effects to an object being gc'd, such that the delete/gc has to happen at a v... Constantin Asofiei

02:29 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> How are you doing he reference counting for object references stored in temp-tables?
We are... Ovidiu Maxiniuc

02:24 PM Feature #3751: implement support for OO 4GL and structured error handling

Are there side effects to an object being gc'd, such that the delete/gc has to happen at a very specific time/order, ... Eric Faulhaber

02:21 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> How are you doing he reference counting for object references stored in temp-tables?
It doe... Constantin Asofiei

02:20 PM Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> # It is much trickier to know when a record is deleted. We optimize many types of bulk dele... Constantin Asofiei

02:18 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> As far as I can tell, if an object is stored in a TEMP-TABLE, it is not automatically disca... Eric Faulhaber

02:16 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric, is there an easy way to track a DMO property setter (when is being invoked, knowin... Eric Faulhaber

01:58 PM Feature #3751: implement support for OO 4GL and structured error handling

Simple tests with 3750b rev 11319 are working for static temp-tables, static class initialization, static and instanc... Constantin Asofiei

12:16 PM Feature #3751: implement support for OO 4GL and structured error handling

Sorry, my bad, the text capture was done with an object still referred by variable. I rerun the code and the destruct... Ovidiu Maxiniuc

12:05 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> There are a few interesting notes:
> * the second object created (@C3758Bar_4309@) is drop... Constantin Asofiei

11:54 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Did you find way to track if a field is changed (to unknown or some other ref)?
I start... Ovidiu Maxiniuc

01/24/2019

05:35 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Why do you say "We may need to look here without the arguments"? Do you have reason to believe t... Constantin Asofiei

04:27 PM Feature #3751: implement support for OO 4GL and structured error handling

> Are you planning to fix the method erasure where it can override only by parameter mode, not just type?
Yes. Greg Shah

04:27 PM Feature #3751: implement support for OO 4GL and structured error handling

From #3751-353:
> What I think is missing is the parent lookup:
>
> * in ClassDefinition.exactMethodLookup - thi... Greg Shah

01/23/2019

05:34 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> From #3751-346:
>
> > INPUT/OUTPUT/INPUT-OUPTUT for OO argument case.
>
> I assume this is ... Constantin Asofiei

05:11 PM Feature #3751: implement support for OO 4GL and structured error handling

From #3751-346:
> INPUT/OUTPUT/INPUT-OUPTUT for OO argument case.
I assume this is the TODO in @fuzzyMethodLook... Greg Shah

04:43 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> In @ClassDefinition.fuzzyMethodLookup()@ code starting at line 1548:
>
> * Shouldn't the code ... Constantin Asofiei

04:28 PM Feature #3751: implement support for OO 4GL and structured error handling

In @ClassDefinition.fuzzyMethodLookup()@:... Greg Shah

04:04 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Think only in the case of bulk delete when the entire table content is dropped with
Is it... Constantin Asofiei

02:45 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Ovidiu, you can now look into the object reference tracking for the temp-table fields (w... Ovidiu Maxiniuc

02:43 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg, have you checked properties defined in an interface or an abstract property (in an... Greg Shah

02:42 PM Feature #3751: implement support for OO 4GL and structured error handling

In @ClassDefinition.fuzzyMethodLookup()@ code starting at line 1548:
* Shouldn't the code at line 1563 be checking... Greg Shah

01:56 PM Feature #3751: implement support for OO 4GL and structured error handling

Please don't use the builtin 4GL classes in FWD - these are not implemented yet.
Use an explicitly defined class, ... Constantin Asofiei

01:53 PM Feature #3751: implement support for OO 4GL and structured error handling

... Ovidiu Maxiniuc

01:50 PM Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin,
>
> In @ObjectResource.delete()@, a new @ExternalProgramWrapper@ is used fo... Constantin Asofiei

01:47 PM Feature #3751: implement support for OO 4GL and structured error handling

Constantin,
In @ObjectResource.delete()@, a new @ExternalProgramWrapper@ is used for some cleanup. I do not think... Ovidiu Maxiniuc

01:14 PM Feature #3751: implement support for OO 4GL and structured error handling

3750b rev 11312 contains another batch of mostly conversion changes.
I've fixed review notes 1 to 3; 4 and 5 (comm... Constantin Asofiei

12:44 PM Feature #3751: implement support for OO 4GL and structured error handling

Greg, have you checked properties defined in an interface or an abstract property (in an abstract class)? These don'... Constantin Asofiei

10:57 AM Feature #3751: implement support for OO 4GL and structured error handling

Constantin: The changes are very good. I'm excited to see this coming together. Greg Shah

10:37 AM Feature #3751: implement support for OO 4GL and structured error handling

Code Review Task Branch 3750b Revision 11311
1. In @ArrayAssigner@, why is @ObjectOps.reRegister(array, copy);@ be... Greg Shah