FWD » Core Development » Base Language

03/07/2021

11:35 AM Support #5120: Date/Datetime - from iso

OK, defer the work. Please create a task for it. Greg Shah

10:57 AM Support #5120: Date/Datetime - from iso

Greg Shah wrote:
> Vladimir is making changes to the date parsing in #4880. Are the issues overlapping?
I think #4... Constantin Asofiei

10:51 AM Support #5120: Date/Datetime - from iso

Vladimir is making changes to the date parsing in #4880. Are the issues overlapping?
Are the tests broken because... Greg Shah

10:23 AM Support #5120: Date/Datetime - from iso

There are some differences in the error messages/codes reported by FWD in case of invalid literals, but the functiona... Constantin Asofiei

10:17 AM Support #5120: Date/Datetime - from iso

What is left to do on this task? Greg Shah

10:34 AM Bug #4978: Static method call in base class

See attached for the tests I used.
@o:foo()@ produces a compile error when called from @Extension@ because @o@ is ... Constantin Asofiei

10:07 AM Bug #4978: Static method call in base class

As part of the changes for #4350, I'm switching the @exactMethodLookup()@ to use @candidates()@ for making a list of ... Greg Shah

09:13 AM Bug #5035 (Test): Temp-Table index on P.L.O field

Greg Shah

03/06/2021

01:29 PM Bug #5035: Temp-Table index on P.L.O field

Greg Shah wrote:
> Constantin: Is there anything else to do here?
No.
Constantin Asofiei

10:41 AM Bug #5035: Temp-Table index on P.L.O field

Code Review Task Branch 3821c Revision 12088
The changes are OK for me.
Ovidiu: If you are OK with the persiste... Greg Shah

07:29 AM Bug #5035 (WIP): Temp-Table index on P.L.O field

The changes are in 3821c rev 12088.
Ovidiu: please review. Constantin Asofiei

10:17 AM Bug #4749: Conversion error for object indeterminate extent output parameter

Code Review Task Branch 3821c Revision 12087
The changes are good. Greg Shah

08:01 AM Bug #4749: Conversion error for object indeterminate extent output parameter

Greg Shah wrote:
> Please add javadoc to @ArrayAssigner.register(BaseDataType[] array)@ and @ArrayAssigner.registerD... Constantin Asofiei

03/05/2021

04:05 PM Bug #5035: Temp-Table index on P.L.O field

> I haven't touched com-handle field, I assume this is also mapped as Long in 4GL, but its weird to test in FWD. And ... Greg Shah

03:13 PM Bug #5035: Temp-Table index on P.L.O field

I've switched both handle and object fields to Long and incremental value. There are two more issues to check, unkn... Constantin Asofiei

11:41 AM Bug #5035: Temp-Table index on P.L.O field

> anyone can walk through session first object/handle and use next-sibling to get access to everything
Yes, this i... Greg Shah

11:07 AM Bug #5035: Temp-Table index on P.L.O field

I find this illusion of security kinda funny, random or incremental is exactly the same in a single threaded environm... Marian Edu

10:33 AM Bug #5035: Temp-Table index on P.L.O field

Greg Shah wrote:
> I understand it is more secure but does it break any existing 4GL behavior?
Only in cases of w... Constantin Asofiei

09:59 AM Bug #5035: Temp-Table index on P.L.O field

> The major reason why the resource ID for the persistent procedures/handles/etc needs to be random is because you ca... Greg Shah

09:43 AM Bug #5035: Temp-Table index on P.L.O field

Greg Shah wrote:
> This seems reasonable. Do I understand correctly that the internal representation will never be ... Constantin Asofiei

08:42 AM Bug #5035: Temp-Table index on P.L.O field

> I have the changes to move the object ID to a long, incrementing value. This will be used by the toString and temp-... Greg Shah

05:18 AM Bug #5035: Temp-Table index on P.L.O field

I have the changes to move the object ID to a long, incrementing value. This will be used by the toString and temp-t... Constantin Asofiei

07:36 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, the signature for @JsonArray:read@ as documented at https://docs.progress.com/bu... Marian Edu

06:30 AM Feature #4384: Builtin OO Implementation

I have a fix for the @jsonarray:read(handle)@ case - the conversion rules will emit the TableParameter for builtin OO... Constantin Asofiei

05:39 AM Feature #4384: Builtin OO Implementation

Marian, the signature for @JsonArray:read@ as documented at https://docs.progress.com/bundle/openedge-abl-reference-1... Constantin Asofiei

04:31 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Constantin Asofiei wrote:
> > @bzr merge@ is not working. Please unbind your skeleton project,... Constantin Asofiei

04:16 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> @bzr merge@ is not working. Please unbind your skeleton project, bind to the xfer proje... Marian Edu

04:03 AM Feature #4384: Builtin OO Implementation

@bzr merge@ is not working. Please unbind your skeleton project, bind to the xfer project, run @bzr update@ and afte... Constantin Asofiei

03:58 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, please use the skeleton checkout from xfer, @/opt/fwd/skeleton@ to create the pa... Marian Edu

03:34 AM Feature #4384: Builtin OO Implementation

Marian, please use the skeleton checkout from xfer, @/opt/fwd/skeleton@ to create the patch. That is at revision 99. Constantin Asofiei

02:04 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, you've made some changes to JsonConstruct and the read(TableParameter) method is... Marian Edu

07:22 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> I have a set of testcases in our old/crappy testcase repo. I will check them in to the new/hotness testcases repo. ... Greg Shah

03/04/2021

04:30 PM Feature #4384: Builtin OO Implementation

Marian, you've made some changes to JsonConstruct and the read(TableParameter) method is now gone.
This code no lo... Constantin Asofiei

02:14 PM Support #5120: Date/Datetime - from iso

The changes are in 3821c rev 12081.
Also, rev 1010 of the xfer testcases project contains a set of tests of how li... Constantin Asofiei

10:30 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Marian Edu wrote:
> Greg Shah wrote:
> > > If you want I can go ahead and fill in the tests unless this is already ... Greg Shah

03/03/2021

03:27 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> In other words, can you define the same dataset in 2 or more ways in source code?
Yes, you can ... Ovidiu Maxiniuc

08:41 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> > If you want I can go ahead and fill in the tests unless this is already covered someplace else.... Marian Edu

08:23 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> If you want I can go ahead and fill in the tests unless this is already covered someplace else.
How much work is... Greg Shah

08:09 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Marian/Ovidiu: Can you give me your best understanding of the answers to the above questions? ... Marian Edu

07:32 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

In regard to dataset and dataset-handle parameters, I need some help.
* Based on the 4GL docs, these are described... Greg Shah

12:30 AM Feature #5160: About cast() function support

I have same issues with regular methods and constructors. Even regular method got same error with output table parame... Deividas Varzgalys

03/02/2021

08:09 AM Feature #5160: About cast() function support

Coincidentally, I am already working on this root cause in #4350. The problem is that we need to better handle metho... Greg Shah

07:40 AM Feature #5160: About cast() function support

test.p file.... Deividas Varzgalys

03/01/2021

09:59 AM Feature #5160: About cast() function support

Please post a standalone example so that we can recreate the problem here. Greg Shah

09:46 AM Feature #5160: About cast() function support

I just pasted "*" due to the data safety of current project source code names. This error occurs in filenames without... Deividas Varzgalys

05:28 AM Feature #4965: Parameter annotation - qualified

Please post a small test which shows this problem. The reference is decremented somewhere where it should not be. Constantin Asofiei

05:17 AM Feature #4965: Parameter annotation - qualified

Constantin Asofiei wrote:
> Each object var definition should be declared outside the top-level block (in the Java m... Marian Edu

03:57 AM Feature #4965: Parameter annotation - qualified

Marian Edu wrote:
> This is part of the 'OO SDK' and as per your suggestion everything under @com.goldencode.p2j.oo@... Constantin Asofiei

03:48 AM Feature #4965: Parameter annotation - qualified

Constantin Asofiei wrote:
> Also, I see lots of classes have @null@ as the referent in i.e. its @BlockManager.functi... Marian Edu

02/26/2021

07:51 PM Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion

Actually the dereference operation pose other issues. The COPY-LOB is also not working correctly when a dereferenced ... Ovidiu Maxiniuc

02/25/2021

04:32 AM Feature #4965 (Test): Parameter annotation - qualified

Greg Shah

02/24/2021

11:19 AM Feature #5160: About cast() function support

> ./abl/*.p:741:37: unexpected token: GetData
> ...
> 2.Error processing .*.p --- Caused by: java.lang.NullPointerE... Greg Shah

11:08 AM Feature #5160: About cast() function support

> unexpected token: strict-entity-resolution
Correct, in your version of FWD we did not recognise this attribute a... Greg Shah

08:43 AM Feature #4965: Parameter annotation - qualified

Marian Edu wrote:
> How should we proceed were, a new merge or just wait for the new 4384 branch and fix whatever ne... Constantin Asofiei

07:55 AM Feature #4965: Parameter annotation - qualified

Constantin Asofiei wrote:
> Marian, there are some compile errors -
> [...]
>
> Is this a typo? Shouldn't each ... Marian Edu

08:40 AM Bug #4749 (Test): Conversion error for object indeterminate extent output parameter

Code Review Task Branch 3821c Revision 12052
Overall, the changes are good.
Please add javadoc to @ArrayAssigne... Greg Shah

02/23/2021

12:50 PM Feature #4384: Builtin OO Implementation

Branch 4384i was created from branch 3821c revision 12052.
Marian: please review revision 12051, it fixes some com... Constantin Asofiei

12:45 PM Bug #4749: Conversion error for object indeterminate extent output parameter

Constantin Asofiei wrote:
> As for the dynamic array issues - the root cause was the fact that the Java reference fo... Constantin Asofiei

12:21 PM Feature #4965: Parameter annotation - qualified

> Greg: I think we need a 4384i branch?
Yes. Please make one as soon as you are happy with the 3821c starting point. Greg Shah

12:18 PM Feature #4965: Parameter annotation - qualified

Marian, there are some compile errors - ... Constantin Asofiei

12:12 PM Feature #4965: Parameter annotation - qualified

Constantin Asofiei wrote:
> Marian, 4384h on xfer is still on rev 12004 - although I think is a little old, is still... Marian Edu

12:04 PM Feature #4965: Parameter annotation - qualified

Marian, 4384h on xfer is still on rev 12004 - although I think is a little old, is still good, because I could use it... Constantin Asofiei

02:46 AM Feature #4965: Parameter annotation - qualified

Greg Shah wrote:
> > I've pushed 3821c revision 12046 to xfer. Do you want to branch from that, apply your changes ... Marian Edu

10:26 AM Feature #5160: About cast() function support

Yes, GeneralInfoPart is my class.... Deividas Varzgalys

08:44 AM Feature #5160: About cast() function support

> Does your tool support cast() function in that way?
Yes, FWD does support chaining a method call off of a @cast(... Greg Shah

08:40 AM Feature #5160: About cast() function support

From Deividas:
> I have issue in conversion process that error show up with cast() function
> ... Greg Shah

05:05 AM Feature #5160 (New): About cast() function support

Deividas Varzgalys

02/22/2021

07:20 AM Feature #4965: Parameter annotation - qualified

> I've pushed 3821c revision 12046 to xfer. Do you want to branch from that, apply your changes and provide a bzr se... Greg Shah

07:18 AM Feature #4965: Parameter annotation - qualified

Greg Shah wrote:
> > since there seems to be some automatic changes applied to 'oo' packages should we make a new b... Marian Edu

06:55 AM Feature #4965: Parameter annotation - qualified

> since there seems to be some automatic changes applied to 'oo' packages should we make a new branch to incorporate... Greg Shah

04:09 AM Feature #4965: Parameter annotation - qualified

Marian Edu wrote:
> Constantin, just to clarify, the default to P.L.O is not for the (newly added) return type but f... Constantin Asofiei

03:08 AM Feature #4965: Parameter annotation - qualified

Constantin Asofiei wrote:
> I agree that the return type should be added. But the approach to 'default to PLO' if t... Marian Edu

08:14 PM Feature #4965: Parameter annotation - qualified

Perhaps the default value for @LegacySignature.returns()@ should be "VOID".
As for the poly cases, I think they sh... Greg Shah

03:24 AM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> Marian, regarding #5029-15 - I've tried duplicating using this test:
> [...]
>
> But... Marian Edu

02/21/2021

11:28 AM Feature #5146: record additional legacy class and method data in annotations

3821c rev 12042 to 12044 fixes the 'extent', 'qualified' and adds 'returns' annotation to all legacy p2j.oo methods. ... Constantin Asofiei

11:27 AM Feature #4965 (WIP): Parameter annotation - qualified

All changes are in 3821c revs 12042 to 12044.
I did not touch the poly methods/parameters:... Constantin Asofiei

09:27 AM Feature #4965: Parameter annotation - qualified

I've built a tool which automatically edits the source code for the @com.goldencode.p2j.oo@ classes and injects @qual... Constantin Asofiei

02/19/2021

04:15 PM Bug #4978: Static method call in base class

Lets assume you have a protected instance method @Base.foo@ and a class @Extension@ which extends @Base@.
# in a met... Constantin Asofiei

03:57 PM Bug #4978: Static method call in base class

We need to be careful using qualified/unqualified. Most of the time when we say qualified, we mean the "package" por... Greg Shah

01:28 PM Bug #4978 (WIP): Static method call in base class

The same behavior where the static member from a super-class can be accessed from a sub-class is allowed for variable... Constantin Asofiei

03:11 PM Feature #4965: Parameter annotation - qualified

Greg Shah wrote:
> > I already have code to calculate the return type using reflection and the existing annotations.... Constantin Asofiei

11:38 AM Feature #4965: Parameter annotation - qualified

> I already have code to calculate the return type using reflection and the existing annotations.
3821c rev 12032 ... Greg Shah

11:09 AM Feature #4965: Parameter annotation - qualified

I already have code to calculate the return type using reflection and the existing annotations. I will check it in s... Greg Shah

11:05 AM Feature #4965: Parameter annotation - qualified

It was easy to write a simple tool to check the @p2j.oo@ methods which have @LegacySignature@. The list of problems ... Constantin Asofiei

09:59 AM Feature #4965: Parameter annotation - qualified

> You mentioned at some point that the method's return type is not in LegacySignature - where was this logged?
See... Greg Shah

09:47 AM Feature #4965: Parameter annotation - qualified

Greg, you mentioned at some point that the method's return type is not in LegacySignature - where was this logged?
... Constantin Asofiei

01:55 PM Bug #4749: Conversion error for object indeterminate extent output parameter

The conversion issue for @ObjectExtentGlobal@ is already fixed.
As for the dynamic array issues - the root cause w... Constantin Asofiei

11:14 AM Bug #5029: OO constructor with array input parameter

Marian, regarding #5029-15 - I've tried duplicating using this test:... Constantin Asofiei

10:55 AM Feature #5146: record additional legacy class and method data in annotations

Regarding the return type for function and OO methods - my only problem is that there are ~3000 hand-written classes ... Constantin Asofiei

02/18/2021

12:17 PM Bug #5035: Temp-Table index on P.L.O field

Greg Shah wrote:
> > is there a way to resolve an instance from its ID, an equivalent for handle function?
>
> Ma... Marian Edu

10:24 AM Bug #5035: Temp-Table index on P.L.O field

> is there a way to resolve an instance from its ID, an equivalent for handle function?
Marian: We need your thoug... Greg Shah

10:22 AM Bug #4749 (WIP): Conversion error for object indeterminate extent output parameter

Greg Shah

02/16/2021

04:42 PM Feature #4384: Builtin OO Implementation

I've added wiki documentation that lists our currently "supported built-in OO classes":/projects/p2j/wiki/Object_Orie... Greg Shah

01:58 PM Bug #5029 (Test): OO constructor with array input parameter

Greg Shah

01:12 PM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> OK, that's because my tests always had the INPUT modifier. I'll fix this.
>
> For no... Constantin Asofiei

02/15/2021

08:20 AM Feature #4384: Builtin OO Implementation

Please use this patch. It will be in 3821c in the next couple of days.... Constantin Asofiei

08:04 AM Feature #4384: Builtin OO Implementation

Marian, the root cause is because the reference is incremented when the INPUT parameter is initialized in the propert... Constantin Asofiei

02:37 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> As long as you use @TypeFactory.object@ or @UndoableFactory.object@ to initialize a prop... Marian Edu

02/14/2021

10:51 AM Feature #4384: Builtin OO Implementation

As long as you use @TypeFactory.object@ or @UndoableFactory.object@ to initialize a property/var, then reference coun... Constantin Asofiei

10:47 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, I had to revert your @object.setUnknown@ change which decremented the reference ... Marian Edu

02/13/2021

05:51 PM Feature #4384: Builtin OO Implementation

Marian, I had to revert your @object.setUnknown@ change which decremented the reference - only @ObjectVar@ is allowed... Constantin Asofiei

02/12/2021

10:41 AM Feature #5146: record additional legacy class and method data in annotations

* We should be able to record (in an annotation) whether the converted class was a @CLASS@, @INTERFACE@ or @ENUM@ in ... Greg Shah

10:40 AM Feature #5146 (New): record additional legacy class and method data in annotations

Greg Shah

02/11/2021

08:32 AM Bug #5029: OO constructor with array input parameter

My current work touches how 4GL moves the data from the arguments to the parameters, via the stack, for the integer/i... Constantin Asofiei

08:24 AM Bug #5029: OO constructor with array input parameter

There is another thing with indeterminate extent output parameters, in 4GL it doesn't matter if the extent was alread... Marian Edu

08:20 AM Bug #5029: OO constructor with array input parameter

OK, that's because my tests always had the INPUT modifier. I'll fix this.
For now, change it like @INPUT cInExt@ ... Constantin Asofiei

08:14 AM Bug #5029: OO constructor with array input parameter

Constantin Asofiei wrote:
> What are you using exactly as argument? A OO property? A class variable? Something else?... Marian Edu

08:11 AM Bug #5029: OO constructor with array input parameter

What are you using exactly as argument? A OO property? A class variable? Something else? Constantin Asofiei

08:07 AM Bug #5029: OO constructor with array input parameter

Constantin, conversion is not using @InputOutputExtentParameter@ anymore but it's missing the cast to Object so it st... Marian Edu

02/10/2021

09:07 AM Feature #4384: Builtin OO Implementation

Marian, @LegacyClass@ is missing legacy constructor method(s). Please add them.
If you debug into the @newInstanc... Constantin Asofiei

08:51 AM Feature #4384: Builtin OO Implementation

Constantin, another thing that we've found is when using any instance level methods in @LegacyClass@ we get a nice NP... Marian Edu

02/08/2021

09:24 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, the root cause is @REGISTRY.set(registry);@ instead of @REGISTRY.get().assign(r... Marian Edu

09:14 AM Feature #4384: Builtin OO Implementation

Marian, the root cause is @REGISTRY.set(registry);@ instead of @REGISTRY.get().assign(registry);@ in @HttpHeaderBuil... Constantin Asofiei

08:52 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> What test do you use? Can you isolate this in something simple?
This is the simplest o... Marian Edu

07:21 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Right, but for an object this means the reference is the same... two objects pointing to the sam... Constantin Asofiei

07:19 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, please give me an example where you need equals/hashCode in the collection imple... Marian Edu

06:29 AM Feature #4384: Builtin OO Implementation

Marian, please give me an example where you need equals/hashCode in the collection implementations.
As a rule of t... Constantin Asofiei

02:47 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> Branch 4384h was created from branch 3821c revision 11992. Please note that some changes from 43... Marian Edu