FWD » Core Development » Base Language

05/23/2024

10:58 AM Feature #4347: add runtime support for STOP-AFTER block option

>> Is @STOP-AFTER@ essentially an @ON STOP UNDO, LEAVE@ but only matching a timeout and not other kinds of @STOP@?
>... Greg Shah

10:33 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> * 4GL syntax
> ** "time limit" value
> *** Test both literals and "complex" expressions (a vari... Eduard Soltan

09:35 AM Feature #4347: add runtime support for STOP-AFTER block option

> > Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1@ which has a @on stop... Greg Shah

09:34 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Greg Shah wrote:
> > > I think there is some behavior related to blocking UI statements... Greg Shah

09:26 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard, Please do the following:
* In the testcase, add elapsed timers around each of the cases where you are expe... Greg Shah

09:20 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if th... Constantin Asofiei

09:16 AM Feature #4347: add runtime support for STOP-AFTER block option

> I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ... Greg Shah

02:43 AM Feature #4347: add runtime support for STOP-AFTER block option

I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ST... Constantin Asofiei

02:39 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Marian Edu wrote:
> > That one works as expected for me (OE12.2), what you can do so it... Marian Edu

02:33 AM Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> That one works as expected for me (OE12.2), what you can do so it doesn't look like it's mining ... Constantin Asofiei

02:28 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1... Marian Edu

05/22/2024

06:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Committed on 4347a, revision 15205.
I understand from today's meeting that this commit add... Eric Faulhaber

02:48 AM Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15205.
Created a suite of test cases.
Also find some scenarios which behaviours in 4... Eduard Soltan

11:01 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> May I get a confirmation that @webtests_from_logs/results@ are results from Progress?
Yes, this is... Constantin Asofiei

08:44 AM Feature #6417: cleanup some known items in appserver support

May I get a confirmation that @webtests_from_logs/results@ are results from Progress? Galya B

02:26 AM Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

There are cases when even if an ERROR condition is supposed to be morphed into a structured exception, and re-thrown ... Constantin Asofiei

02:24 AM Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

05/21/2024

10:38 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Branch 6161a was merged to trunk rev 15229 and archived. Constantin Asofiei

08:34 AM Feature #6161 (Merge Pending): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

You can merge to trunk after 7417b. Greg Shah

08:04 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Greg Shah wrote:
> What testing do you propose?
DYNAMIC-PROPERTY is not being used in other projects than #8433. S... Constantin Asofiei

07:58 AM Feature #6161 (Internal Test): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

What testing do you propose? Greg Shah

07:58 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I think we just watch it in case it becomes a hotspot. One solution would be to group all the details of a property ... Greg Shah

07:30 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've moved the bulk getter/setter to be resolved only if no indexed setter/getter is resolved at all. I'm not sure w... Constantin Asofiei

08:38 AM Feature #4347: add runtime support for STOP-AFTER block option

That explains it. I was looking at the 12.x docs. Greg Shah

07:47 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> According to https://docs.progress.com/bundle/openedge-startup-and-parameter-reference-1... Marian Edu

05/20/2024

12:51 PM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Code Review Task Branch 6161a Revision 15222
The changes look good.
The only concern I have is about performa... Greg Shah

07:34 AM Feature #6161 (Review): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY...

Created task branch 6161a from trunk rev 15222. rev 15223 fixed validation of the DYNAMIC-PROPERTY arguments for stat... Constantin Asofiei

11:59 AM Feature #4347: add runtime support for STOP-AFTER block option

Good.
Eduard: Create a new task for the @-catchStop@ behavior. Focus your implementation for this task on the tr... Greg Shah

11:57 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
... Constantin Asofiei

11:40 AM Feature #4347: add runtime support for STOP-AFTER block option

> Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
Are you saying tha... Greg Shah

11:39 AM Feature #4347: add runtime support for STOP-AFTER block option

> I tried to run this code in Procedure Editor, but it does not work as expected.
Do not run any test code from in... Greg Shah

09:12 AM Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make ... Eduard Soltan

08:51 AM Feature #4347: add runtime support for STOP-AFTER block option

As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make sure you remove the @... Marian Edu

08:26 AM Feature #4347: add runtime support for STOP-AFTER block option

Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown. Do we want to implement ... Constantin Asofiei

05:24 AM Feature #4347: add runtime support for STOP-AFTER block option

... Eduard Soltan

05/16/2024

09:48 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> I thought that in #6407-71, this was changed to a @List@ approach which has proper FIFO ordering.... Galya B

09:31 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> You can include it in 8667a.
The fix was merged to trunk as rev. 15216. Galya B

08:30 AM Feature #6407: name_map.xml improvements

You can include it in 8667a. Greg Shah

02:08 AM Feature #6407: name_map.xml improvements

The comparison in the condition is solid... if it wasn't for @extProg.ooname = ooname.isEmpty() ? null : ooname;@. @o... Galya B

05/15/2024

10:38 AM Feature #6407: name_map.xml improvements

> Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedPro... Greg Shah

08:43 AM Feature #6407: name_map.xml improvements

Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedProgr... Constantin Asofiei

08:30 AM Feature #6407: name_map.xml improvements

> Interesting. Most of the discussion in this task is about how map resolvement should work and it's implemented acco... Greg Shah

03:00 AM Feature #6407: name_map.xml improvements

And let me state again, if there is a discrepancy in the content of the maps of two jars in the classpath, this is a ... Galya B

02:44 AM Feature #6407: name_map.xml improvements

I think we should actually be happy to have found this discrepancy in the scripts. Every time such malfunction appear... Galya B

02:40 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The... Galya B

05/14/2024

09:34 AM Feature #4347: add runtime support for STOP-AFTER block option

Code Review (Part 2) Task Branch 4347a Revision 15204
7. Should we (can we?) name the @Timer@ thread to make it cl... Greg Shah

09:21 AM Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15204
1. Please explain why @Control.blockInterrupt()@ adds a remote call a... Greg Shah

08:29 AM Feature #4347: add runtime support for STOP-AFTER block option

I'm reviewing the code now. After reviewing the 4GL docs, I do have some questions. I also added Marian to coordina... Greg Shah

06:20 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Ah, you are right, there is a single thread where the tasks are posted. So there is no ... Eduard Soltan

03:12 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Review for 4347a rev 15204:
> > * what happens if there are n... Constantin Asofiei

02:49 AM Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Review for 4347a rev 15204:
> * what happens if there are nested blocks with @STOP-AFTE... Eduard Soltan

02:16 AM Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15204:
* we need a @SessionListener@ to clean up the @StopAfterTimer.stopAfterTimerOuts@ map. ... Constantin Asofiei

05/13/2024

03:04 PM Feature #4347: add runtime support for STOP-AFTER block option

Greg or Constantin: please review. Eric Faulhaber

09:56 AM Feature #4347 (Review): add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15204. Eduard Soltan

03:03 PM Feature #6407: name_map.xml improvements

In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The issue turned out to... Greg Shah

05:10 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I'm looking back at the responses (in webtests_from_logs folder) and it does look like the asser... Galya B

05:02 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian Edu wrote:
> > Gayla
> It's Galya.
Galya :)
I'm looking back at the responses (in we... Marian Edu

04:50 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Gayla
It's Galya. Galya B

04:49 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> @com.goldencode.p2j.util.decimal@ has:
>
> [...]
>
> But testcases test @pipe_decimal_decimal... Marian Edu

04:48 AM Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > Marian, do you have any idea why this test executed as batch in 4GL gives th... Galya B

03:58 AM Feature #6417: cleanup some known items in appserver support

Greg, how is this going to work? I have more questions than the number of failing tests (quite a few and all over the... Galya B

03:26 AM Feature #6417: cleanup some known items in appserver support

@com.goldencode.p2j.util.decimal@ has:... Galya B

05/07/2024

03:09 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> This gets tricky if you pass an extent field via @::@. But yes, this would need to get ... Marian Edu

05/03/2024

07:40 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Galya B wrote:
> There are some failing tests. Is it the deployment or it's fine?
The failing tests are known failu... Constantin Asofiei

07:28 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> We have tests for `ParameterList` that are failing for extent parameters used as output/input-ou... Constantin Asofiei

05/02/2024

02:53 AM Feature #6410: implement additional built-in OO classes/interfaces

We have tests for `ParameterList` that are failing for extent parameters used as output/input-output. As it is now th... Marian Edu

04/30/2024

09:12 AM Feature #6424 (WIP): fill gaps in Java Open Client replacement (appserver client support)

There is one point in @AppServerConnectionPool@ that is bothering me. It's used only by @LegacyJavaAppserverClient@ a... Galya B

08:19 AM Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

I think we're doing a partial review of the Java client in #8456 and #8661. At least I'm getting familiar with the cl... Galya B

08:49 AM Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian, do you have any idea why this test executed as batch in 4GL gives the following result:
> ... Marian Edu

08:24 AM Feature #6417: cleanup some known items in appserver support

Marian, do you have any idea why this test executed as batch in 4GL gives the following result:... Galya B

08:45 AM Feature #6407 (Test): name_map.xml improvements

6407a was merged to trunk as rev. 15180 and archived.
Support for reading mappings from multiple name_map.xml file... Galya B

08:27 AM Feature #6407 (Merge Pending): name_map.xml improvements

6407a can be merged after 8486a. Greg Shah

08:12 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Constantin: Are there any reasons why this can't be merged to trunk?
No, it can be merged. Constantin Asofiei

08:12 AM Feature #6407: name_map.xml improvements

Constantin: Are there any reasons why this can't be merged to trunk?
Greg Shah

03:17 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin, I'm trying to rerun all tests for method invoke and parameter list but those fails to convert now because... Marian Edu

04/29/2024

04:39 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

The only thing pending for this ticket is #6422-65 Theodoros Theodorou

04:56 AM Feature #6407: name_map.xml improvements

6407a rebased on trunk r15171.
Constantin Asofiei wrote:
> Otherwise, if some testing with customers app works, ... Galya B

02:50 AM Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> Marian Edu wrote:
> > The code in `p2j.oo` almost exclusively use `returnNormal` and ex... Marian Edu

04/26/2024

11:27 AM Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Constantin: Are we good to go?
My main concern with Windows was that jar file separator which ne... Constantin Asofiei

11:17 AM Feature #6407 (Internal Test): name_map.xml improvements

> do I need to make hotel_gui or testcases run on Windows as part of this task
No. The Windows situation will not... Greg Shah

10:38 AM Feature #6407: name_map.xml improvements

I don't know what's going on now, but the client doesn't even spawn and I can't stop it in the cmd prompt. No errors ... Galya B

08:29 AM Feature #6407: name_map.xml improvements

OK, the java command for the task @create.db.h2@ exceeds @8191@ chars (the max length of commands in windows) due to ... Galya B

08:00 AM Feature #6407: name_map.xml improvements

There is an issue with the file separators indeed. It's @\@ on Windows for the jars on the file system, but the resou... Galya B

06:26 AM Feature #6407: name_map.xml improvements

Galya B wrote:
> Not sure what else to test in Win.
Try the Swing client for Hotel GUI on Windows. Constantin Asofiei

06:25 AM Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Regarding the @Utils.packageToPath@ change - please check runtime on Windows for i.e. Ho... Galya B

02:37 AM Feature #6407: name_map.xml improvements

Galya B wrote:
> With or without 6407a I get:
> [...]
>
> Not sure what it means.
There is ambiguity between th... Constantin Asofiei

02:34 AM Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > Actually if a dir with name map file is in the classpath the name ma... Galya B

07:12 AM Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there... Constantin Asofiei

07:04 AM Feature #6410: implement additional built-in OO classes/interfaces

The code in `p2j.oo` almost exclusively use `returnNormal` and expect the execution to end there instead of the `stor... Marian Edu

06:49 AM Feature #6410 (WIP): implement additional built-in OO classes/interfaces

I have a question on how is the proper way to return a value out of a OO method (really a function block), we've used... Marian Edu

04:40 AM Feature #8676: ABLUnit assert error messages are different in different OE versions

A quick search on testcases project shows we have 500 asserts on 'not null' error messages, for some tests of #6410 w... Marian Edu

03:57 AM Feature #8676: ABLUnit assert error messages are different in different OE versions

Greg Shah wrote:
> Marian: Please provide some more details on the specific changes that need to be made. Also, ple... Marian Edu

04/25/2024

02:24 PM Feature #6407: name_map.xml improvements

Galya B wrote:
> Actually if a dir with name map file is in the classpath the name map should have been found in the... Constantin Asofiei

07:53 AM Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> You are correct, at this point, unless the current folder is in the classpath, @ClassLoa... Galya B

07:51 AM Feature #6407: name_map.xml improvements

With the @classNameExists@ in mind, these changes don't affect conversion. Constantin Asofiei

07:22 AM Feature #6407: name_map.xml improvements

You are correct, at this point, unless the current folder is in the classpath, @ClassLoader.getSystemResource(sb.toSt... Constantin Asofiei

06:16 AM Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion... Galya B

05:32 AM Feature #6407: name_map.xml improvements

Galya B wrote:
> > * @SourceNameMapper@ - @convertJavaProg@ is used during conversion via @NameMappingWorker.classNa... Constantin Asofiei

05:13 AM Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Review for 6407a rev 15157:
> * @WebServer@ - please add a history entry
Fixed.
> * @... Galya B

04:01 AM Feature #6407: name_map.xml improvements

Review for 6407a rev 15157:
* @WebServer@ - please add a history entry
* @Utils.packageToPath@ - this replaces all ... Constantin Asofiei

04/24/2024

05:12 PM Feature #8676: ABLUnit assert error messages are different in different OE versions

Marian's team has written a large number of ABLUnit tests which relied upon OE (12.x?) error messages from the assert... Greg Shah

05:03 PM Feature #8676 (New): ABLUnit assert error messages are different in different OE versions

Greg Shah

08:34 AM Feature #4347: add runtime support for STOP-AFTER block option

> To replicate this in Java, we need all *converted* statements to check if there was a time-out or not, so it can ra... Greg Shah

04:30 AM Feature #4347: add runtime support for STOP-AFTER block option

Alexandru, the STOP AFTER needs to use a similar mechanism we have for CTRL-C support (which actually raises a STOP c... Constantin Asofiei

04:19 AM Feature #4347: add runtime support for STOP-AFTER block option

Eduard and I had a chat yesterday on this task an I took some "thinking" time on my own on this matter:
#4347-6 is... Alexandru Lungu