Project

General

Profile

Activity

From 07/30/2024 to 08/28/2024

08/28/2024

08:28 AM Bug #9032: Reduce the number of exceptions that are being thrown
Radu Apetrii wrote:
> Just to be sure, 9032b needs to be conversion tested, and *not* 9032a, right?
Yes. Constantin Asofiei
08:28 AM Bug #9032: Reduce the number of exceptions that are being thrown
Just to be sure, 9032b needs to be conversion tested, and *not* 9032a, right? Radu Apetrii
05:03 AM Bug #9032 (Review): Reduce the number of exceptions that are being thrown
Committed *9032b/15400*. Support silent mode methods in AbstractQuery.
*EDIT:* Only runtime changes. Dănuț Filimon
04:42 AM Bug #9032: Reduce the number of exceptions that are being thrown
I tested *9032b* with customer unit tests and there were no regressions. Lorian Sandu
04:03 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> This is a problem... In RandomAccessQuery I defined @silentFirst(), silentFirst(Object[]), si... Dănuț Filimon
02:30 AM Bug #9032: Reduce the number of exceptions that are being thrown
Constantin Asofiei wrote:
> There are conversion regressions for this construct:
> [...]
>
> This emits a @silen... Dănuț Filimon
06:29 AM Feature #4065 (WIP): server-side processing of client platform dependencies
4065e was merged to trunk as rev. 15402 and archived.
4065f created from trunk r15402. Galya B
05:49 AM Feature #4065 (Merge Pending): server-side processing of client platform dependencies
Galya, please merge 4065e in trunk. Hynek Cihlar
04:22 AM Feature #4065: server-side processing of client platform dependencies
4065e tested for regressions with hotel_gui and a customer project. Tested server-side and client-side environments a... Galya B

08/27/2024

01:47 PM Feature #4065 (Internal Test): server-side processing of client platform dependencies
Code review 4065e revision 15389. The changes look good.
 Hynek Cihlar
09:10 AM Feature #4065: server-side processing of client platform dependencies
All requested changes are in r15389. Galya B
08:47 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> 1. remove the env prop subscription mechanism altogether and call a new @ClientExports@ method from... Hynek Cihlar
08:42 AM Feature #4065: server-side processing of client platform dependencies
> If it returns null, the client crashes.
Whenever possible, we don't want a crash. For a critical problem, it wo... Greg Shah
08:41 AM Feature #4065: server-side processing of client platform dependencies
> For @EnvironmentAccessor.subscribe@ how is the serialization of @consumer@ resolved in case environment is server-s... Galya B
08:27 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Hynek Cihlar wrote:
> > > With server-side 'environments' @EnvironmentDaemon.unload@ calls @Window... Hynek Cihlar
08:18 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> > With server-side 'environments' @EnvironmentDaemon.unload@ calls @WindowManager@, which init... Galya B
08:04 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Hynek Cihlar wrote:
> > In @WindowManager@ the assignment
> > [...]
> > What is the connection b... Hynek Cihlar
07:53 AM Feature #4065: server-side processing of client platform dependencies
Hynek Cihlar wrote:
> In @WindowManager@ the assignment
> [...]
> What is the connection between @ThinClient.getIn... Galya B
07:15 AM Feature #4065: server-side processing of client platform dependencies
Code review 4065e.
Overall pretty nice set of changes!
@OsResourceType.java@, wrong date in the file history en... Hynek Cihlar
12:16 PM Bug #9032: Reduce the number of exceptions that are being thrown
There are conversion regressions for this construct:... Constantin Asofiei
07:36 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Good news, I tested a hotel_gui and a customer application conversion and both were successfu... Dănuț Filimon
07:33 AM Bug #9032: Reduce the number of exceptions that are being thrown
The #8363 app converted and compiled OK, and performance run showed a small improvement. I need to reconvert ETF and... Constantin Asofiei
02:14 AM Bug #9032: Reduce the number of exceptions that are being thrown
Good news, I tested a hotel_gui and a customer application conversion and both were successful. Dănuț Filimon

08/26/2024

10:37 AM Feature #4065: server-side processing of client platform dependencies
I've started testing. NPE fixed in r15387.
Server-side 'environments' auto enables server-side 'filesystem', but @... Galya B
08:12 AM Feature #4065: server-side processing of client platform dependencies
Hynek: Please review. Greg Shah
08:10 AM Feature #4065 (Review): server-side processing of client platform dependencies
Greg Shah
05:38 AM Feature #4065: server-side processing of client platform dependencies
4065e r15386 based on trunk r15381 for review.
What has been changed:
* Added support for @EnvironmentAccessor@ s... Galya B
03:51 AM Bug #9032: Reduce the number of exceptions that are being thrown
Rebased *9032b* to *trunk/15393*, the branch is now at revision *15399*. Dănuț Filimon
02:24 AM Bug #9032: Reduce the number of exceptions that are being thrown
Constantin Asofiei wrote:
> @addExternalBuffers@ in FindQuery need to return FindQuery, as a @FIND ... WHERE CAN-FIN... Dănuț Filimon

08/25/2024

04:03 AM Bug #9032: Reduce the number of exceptions that are being thrown
@addExternalBuffers@ in FindQuery need to return FindQuery, as a @FIND ... WHERE CAN-FIND()@ will emit an @addExterna... Constantin Asofiei

08/23/2024

04:21 PM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Shouldn't @opsys@ ("OPSYS function":https://documentation.progress.com/output/ua/OpenEdge_latest/pd... Greg Shah
04:20 PM Feature #4065: server-side processing of client platform dependencies
@ClientExports@ and @ServerExports@ is both UI-specific. We should avoid these in clientless mode and otherwise leav... Greg Shah
09:04 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Shouldn't @opsys@ ("OPSYS function":https://documentation.progress.com/output/ua/OpenEdge_latest/pd... Galya B
08:54 AM Feature #4065: server-side processing of client platform dependencies
Shouldn't @opsys@ ("OPSYS function":https://documentation.progress.com/output/ua/OpenEdge_latest/pdsoe/PLUGINS_ROOT/c... Galya B
04:42 AM Feature #4065: server-side processing of client platform dependencies
* @SessionExports@ is purely setting @date@ props client-side in @SessionDateUtils@.
* @LegacyLogManagerClientServic... Galya B
04:35 AM Feature #4065: server-side processing of client platform dependencies
The client registers certain servers @ClientExports@, @SessionExports@, @LegacyLogManagerClientService@, etc. Under w... Galya B
03:35 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> BTW, I think we would be better off removing the @process:arch:single=true@ mode. We never use i... Galya B

08/22/2024

12:27 PM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Actually the call is for gui in @FontManager.initialize@. So I'll ignore it and test with chui.
Bu... Galya B
12:24 PM Feature #4065: server-side processing of client platform dependencies
Actually the call is for gui in @FontManager.initialize@. So I'll ignore it and test with chui. Galya B
12:21 PM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > To allow for a complete server-side execution we should not be leaving any client calls to the ... Galya B
11:47 AM Feature #4065: server-side processing of client platform dependencies
> To allow for a complete server-side execution we should not be leaving any client calls to the server and they need... Greg Shah
11:31 AM Feature #4065: server-side processing of client platform dependencies
I'm somewhat confused, will appreciate any hint. To allow for a complete server-side execution we should not be leavi... Galya B
10:05 AM Feature #4065: server-side processing of client platform dependencies
I guess the default approach with migrating to server-side resources is to rework client dependencies and not registe... Galya B
09:30 AM Bug #9032: Reduce the number of exceptions that are being thrown
I rewrote the performance tests and retested:
* without 9032b
{{collapse(See results)
|_. Test |_. R... Dănuț Filimon
07:57 AM Bug #9032: Reduce the number of exceptions that are being thrown
This looks right! I am OK with the changes. Alexandru Lungu
07:51 AM Bug #9032 (Internal Test): Reduce the number of exceptions that are being thrown
Committed *9032b/15383*. Addressed the #9032-65 review. Dănuț Filimon
06:55 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown
Alexandru Lungu wrote:
> TBD: the times you are seeing are severely spoiled by the actual database look-up that is d... Dănuț Filimon
06:52 AM Bug #9032: Reduce the number of exceptions that are being thrown
TBD: the times you are seeing are severely spoiled by the actual database look-up that is done in order to find the r... Alexandru Lungu
06:50 AM Bug #9032: Reduce the number of exceptions that are being thrown
So you are testing the case when records are found? This is only checking the lambda removal. I think you should have... Alexandru Lungu
06:47 AM Bug #9032: Reduce the number of exceptions that are being thrown
Alexandru Lungu wrote:
> Also, can you share here the test you are doing for profiling?
Attached the tests. Dănuț Filimon
06:44 AM Bug #9032: Reduce the number of exceptions that are being thrown
Also, can you share here the test you are doing for profiling? Alexandru Lungu
06:44 AM Bug #9032: Reduce the number of exceptions that are being thrown
Review on 9032b:
* In @AdaptiveFind@, isn't better to do delegate the @lenientOffEnd@ stuff to @silent*@ method en... Alexandru Lungu
04:07 AM Bug #9032: Reduce the number of exceptions that are being thrown
Regression testing was successful and the results of the performance tests were not as great as the ones from #9032-6... Dănuț Filimon
06:37 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly
... Dănuț Filimon

08/21/2024

09:42 AM Bug #9032 (Review): Reduce the number of exceptions that are being thrown
Committed *9032b/15382*. Fixed QueryOffEndException being thrown in silent mode.
This fixes QOEE that was thrown b... Dănuț Filimon
07:53 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> I am already testing the fix (just catching the QueryOffEndException in the silent method) bu... Dănuț Filimon
06:54 AM Bug #9032: Reduce the number of exceptions that are being thrown
I've done a performance test after fixing #9032-58 and got the following results (average of 5 runs with 1 old run an... Dănuț Filimon
05:43 AM Bug #9032: Reduce the number of exceptions that are being thrown
Alexandru Lungu wrote:
> I just updated the branch but didn't had the chance to properly review it. Please consider ... Dănuț Filimon
05:41 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown
I just updated the branch but didn't had the chance to properly review it. Please consider fixing the found problem a... Alexandru Lungu
05:35 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> I found issues while running performance tests. It seems that FIND NEXT, FIND PREV are not ac... Dănuț Filimon
05:02 AM Bug #9032: Reduce the number of exceptions that are being thrown
I found issues while running performance tests. It seems that FIND NEXT, FIND PREV are not actually executing. Curren... Dănuț Filimon

08/20/2024

05:22 PM Bug #9037: Two timers problem: only one fires
Greg Shah wrote:
> Code Review Task Branch 8393b Revision 15374
>
> In @checkCaller()@, the @final int prefixLeng... Vladimir Tsichevski
02:27 PM Bug #9032: Reduce the number of exceptions that are being thrown
The changes are quite extensive and I will need a bit more time to get through them. I will re-schedule the review at... Alexandru Lungu
09:35 AM Bug #9032: Reduce the number of exceptions that are being thrown
Alexandru: Please review. Greg Shah
07:09 AM Bug #9032 (Review): Reduce the number of exceptions that are being thrown
I'm done with the initial set of conversion/runtime tests and I got the same results with/without the changes from 90... Dănuț Filimon
10:04 AM Feature #4065: server-side processing of client platform dependencies
In current implementation, you can have i.e. memptr on server-side and native APIs on client-side. But, native APIs ... Constantin Asofiei
09:50 AM Feature #4065: server-side processing of client platform dependencies
Why is @new MemoryDaemon(single)@ first called with @false@ on @ServerSideResourceManager.initializeMemptrResource@ a... Galya B
06:52 AM Feature #4065: server-side processing of client platform dependencies
@EnvironmentOps@ is forwarding certain methods to @EnvironmentDaemon@, this is what's common. Galya B
06:51 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > I think this is what should happen: When @environments@ is enabled server-side, then it creates... Galya B
06:48 AM Feature #4065: server-side processing of client platform dependencies
> I think this is what should happen: When @environments@ is enabled server-side, then it creates its server-side ins... Greg Shah
08:33 AM Bug #9061: Catch inside a catch block does not work.
To match the behavior of 4GL for the test case in #9061-1, I disabled @displayError@ in @undoThrowTopLevel@ and added... Artur Școlnic
07:38 AM Bug #9061: Catch inside a catch block does not work.
If @undoThrowTopLevel@ is called inside a catch block, @undoThrow@ is used instead for that error. @undoThrow@ simply... Artur Școlnic
07:19 AM Bug #9061: Catch inside a catch block does not work.
... Artur Școlnic
06:19 AM Bug #9061 (WIP): Catch inside a catch block does not work.
Artur Școlnic

08/19/2024

08:47 AM Bug #9032: Reduce the number of exceptions that are being thrown
Committed *9032b/15381*. Added silentFirst() and silentNext() methods for AdaptiveFind.
My conversion tests pass n... Dănuț Filimon
07:50 AM Bug #9032: Reduce the number of exceptions that are being thrown
It is right to extend the optimization to the @AdaptiveFind@ as well. Alexandru Lungu
07:00 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Now I have another conversion issue where an AdaptiveQuery ends up using the silent methods s... Dănuț Filimon
06:37 AM Bug #9032: Reduce the number of exceptions that are being thrown
Committed -*9032a/15380*- *9032b/15380*. Fixed deleted BLOCK node for FIND ... NO-ERROR when there is no silent lambda. Dănuț Filimon
04:04 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> I thought that the METHOD_CALL AST overrides the BLOCK AST in database_access.rule:1267 but I... Dănuț Filimon
07:08 AM Bug #9061: Catch inside a catch block does not work.
This task was derived from #8912-194. Artur Școlnic
07:07 AM Bug #9061: Catch inside a catch block does not work.
... Artur Școlnic
07:06 AM Bug #9061 (WIP): Catch inside a catch block does not work.
Artur Școlnic

08/16/2024

10:25 AM Bug #9060: Cache oftenly used values that are immutable
As part of the profiling work, the GC activity was detected as being high. This may be caused by the high number of a... Alexandru Lungu
10:20 AM Bug #9060 (Internal Test): Cache oftenly used values that are immutable
Alexandru Lungu
09:26 AM Feature #4065: server-side processing of client platform dependencies
The environments depend on @ClientStorage@. @ClientStorage@ is used for the enhanced browser configs, the registry fa... Galya B
08:53 AM Bug #9032: Reduce the number of exceptions that are being thrown
I thought that the METHOD_CALL AST overrides the BLOCK AST in database_access.rule:1267 but I checked the created ast... Dănuț Filimon
07:06 AM Bug #9032: Reduce the number of exceptions that are being thrown
The problem with point 1 from #9032-45 is that when the rules reach @include/common-progress.rules:11795@ it will cal... Dănuț Filimon
05:42 AM Bug #9032: Reduce the number of exceptions that are being thrown
I've created a larger test suite for FindQuery conversion so that I can maybe find a better example for the #9032-41.... Dănuț Filimon
04:45 AM Bug #9032: Reduce the number of exceptions that are being thrown
I tested the same customer scenario from #9032-35 (100 runs) using 9032a and monitored the process using VisualVM. Th... Dănuț Filimon
06:18 AM Bug #9037: Two timers problem: only one fires
Code Review Task Branch 8393b Revision 15374
In @checkCaller()@, the @final int prefixLength = "com.goldencode.p2j... Greg Shah
04:38 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
I don't recall if I got it going via the internal email server. I definitely got it working with external servers li... Greg Shah
02:27 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
In ChUI I can't reproduce the issue, so the task will be closed as Rejected, but still I want to ask if this example ... Galya B

08/15/2024

02:39 PM Bug #9058: NPE in NumberFormat with SMTP example procedure
It is designed to run in ChUI. Greg Shah
02:01 PM Bug #9058: NPE in NumberFormat with SMTP example procedure
Greg Shah wrote:
> > For me pressing @F1@ causes the @No application help is available@ message emitted.
>
> This... Vladimir Tsichevski
01:58 PM Bug #9058: NPE in NumberFormat with SMTP example procedure
> For me pressing @F1@ causes the @No application help is available@ message emitted.
This seems broken as well. ... Greg Shah
11:47 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
Can this be related to #7646? Did you try to paste non-existing contents in the @EDITOR@ area? This causes NPE for sure. Vladimir Tsichevski
11:35 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
For me pressing @F1@ causes the @No application help is available@ message emitted.
Is it the @F2@ key that should b... Vladimir Tsichevski
11:03 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
Which trunk version was used to get the stack trace? Vladimir Tsichevski
10:13 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
See the first procedure in [[p2j:Email_Send#Example-4GL-Programs]]. Galya B
10:12 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
Galya B wrote:
> Vladimir, I think you're familiar with the class @NumberFormat@. Can you help analyze what's going ... Vladimir Tsichevski
09:57 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
Vladimir, I think you're familiar with the class @NumberFormat@. Can you help analyze what's going on? Galya B
09:55 AM Bug #9058: NPE in NumberFormat with SMTP example procedure
The issue is reproducible with the procedure from the SMTP example in [[p2j:Email_Send#Example-4GL-Programs]]. On @F1... Galya B
09:50 AM Bug #9058 (New): NPE in NumberFormat with SMTP example procedure
Galya B
10:10 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > The environment resource depends on the filesystem. It's not a valid case to have client-side f... Galya B
09:40 AM Feature #4065: server-side processing of client platform dependencies
> > > > On F1 it says "No application help is available", but it doesn't send the form.
> > >
> > > The F2 key is ... Greg Shah
09:29 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Greg Shah wrote:
> > > On F1 it says "No application help is available", but it doesn't send the f... Galya B
09:27 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > On F1 it says "No application help is available", but it doesn't send the form.
>
> The F2 k... Galya B
09:27 AM Feature #4065: server-side processing of client platform dependencies
> @ProcessOps@ launches a new child process remotely (from the client JVM). Such functionality is not a good idea to ... Greg Shah
09:26 AM Feature #4065: server-side processing of client platform dependencies
> > > > For @SmtpEmail@ can I successfully send a message locally using the example in [[p2j:Email_Send#Example-4GL-P... Greg Shah
09:25 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> @SessionUtils@ uses @SessionExports@ to only push date/time/format configs to the client, while wri... Greg Shah
09:24 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> > > For @SmtpEmail@ can I successfully send a message locally using the example in [[p2j:Email_Se... Galya B
09:23 AM Feature #4065: server-side processing of client platform dependencies
> Is the code just using an existing mail server on the specified host or sets a server itself?
Yes, there must be... Greg Shah
09:23 AM Feature #4065: server-side processing of client platform dependencies
> > For @SmtpEmail@ can I successfully send a message locally using the example in [[p2j:Email_Send#Example-4GL-Progr... Greg Shah
09:21 AM Feature #4065: server-side processing of client platform dependencies
> The environment resource depends on the filesystem. It's not a valid case to have client-side filesystem and server... Greg Shah
08:11 AM Feature #4065: server-side processing of client platform dependencies
@ProcessOps@ launches a new child process remotely (from the client JVM). Such functionality is not a good idea to go... Galya B
08:02 AM Feature #4065: server-side processing of client platform dependencies
@SessionUtils@ uses @SessionExports@ to only push date/time/format configs to the client, while writing the same serv... Galya B
06:57 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> For @SmtpEmail@ can I successfully send a message locally using the example in [[p2j:Email_Send#Exa... Galya B
06:45 AM Feature #4065: server-side processing of client platform dependencies
For @SmtpEmail@ can I successfully send a message locally using the example in [[p2j:Email_Send#Example-4GL-Programs]... Galya B
06:18 AM Feature #4065: server-side processing of client platform dependencies
The environment resource depends on the filesystem. It's not a valid case to have client-side filesystem and server-s... Galya B

08/14/2024

10:00 AM Bug #9052: Identity crisis between upvalues of higher scope variables in do i=1 to N block
A customer encountered the following:
A piece of code was converted with a @do i=1 to ...@ block.
The do block ca... Tijs Wickardt
09:59 AM Bug #9052 (New): Identity crisis between upvalues of higher scope variables in do i=1 to N block

Tijs Wickardt
09:44 AM Feature #4065: server-side processing of client platform dependencies
> My point here is if the UI change is needed for #8661 we need the separate task assigned now.
Go ahead and defin... Greg Shah
09:23 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > Please complete this work for all client APIs *other ... Galya B
08:57 AM Feature #4065: server-side processing of client platform dependencies
> Is 4065c merged?
I don't know the status of it, but since there is no discussion here it is unlikely it was merg... Greg Shah
08:55 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Greg Shah wrote:
> > Please complete this work for all client APIs *other than* UI.
> Do we need ... Greg Shah
08:37 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Please complete this work for all client APIs *other than* UI.
Do we need the UI for the #8661? ... Galya B
08:20 AM Feature #4065: server-side processing of client platform dependencies
Is 4065c merged? Galya B
08:03 AM Feature #4065: server-side processing of client platform dependencies
That is a problem for the customer to resolve. If their application allows running multiple users using the same acc... Greg Shah
07:53 AM Feature #4065: server-side processing of client platform dependencies
Constantin Asofiei wrote:
> The OS access will be done using the FWD server's account. What do you mean by 'admin ... Galya B
03:43 AM Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> Greg Shah wrote:
> > Please complete this work for all client APIs *other than* UI.
>
> What ha... Constantin Asofiei
03:16 AM Feature #4065: server-side processing of client platform dependencies
How do client systems work on a server process started without admin permissions? Galya B
03:15 AM Feature #4065: server-side processing of client platform dependencies
Greg Shah wrote:
> Please complete this work for all client APIs *other than* UI.
What has to be completed? Galya B
06:55 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> A peer ast is created correctly for:
> [...] but with 9032b it is created for:
> [...]
If ... Dănuț Filimon
06:45 AM Bug #9032: Reduce the number of exceptions that are being thrown
A peer ast is created correctly for:... Dănuț Filimon
04:55 AM Bug #9032: Reduce the number of exceptions that are being thrown
Tested hotel_gui conversion and found the the following problem:... Dănuț Filimon
04:28 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown
Committed *9032b/15379*. Initial implementation for emitting a silent method instead of a lambda for FIND [FIRST|NEXT... Dănuț Filimon
03:10 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu Maxiniuc wrote:
> Review of 9032a/15367-9.
>
> I think the code is good. There are some issue I spotted:
... Dănuț Filimon
05:11 AM Feature #4347: add runtime support for STOP-AFTER block option
Thank you! Alexandru Lungu
04:45 AM Feature #4347: add runtime support for STOP-AFTER block option
In @directory.xml@ a new node should be added under @runtime/default/legacy-system@.... Eduard Soltan
04:41 AM Feature #4347: add runtime support for STOP-AFTER block option
I am asking for the developers that have more knowledge into @STOP-AFTER@. Is there a way to suppress it? I am runnin... Alexandru Lungu

08/13/2024

02:22 PM Feature #4065: server-side processing of client platform dependencies
Please complete this work for all client APIs *other than* UI. Greg Shah
12:13 PM Bug #9032: Reduce the number of exceptions that are being thrown
Review of 9032a/15367-9.
I think the code is good. There are some issue I spotted:
* @RuntimeJastInterpreter.ja... Ovidiu Maxiniuc
09:32 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu: Please review. Greg Shah
09:26 AM Bug #9032: Reduce the number of exceptions that are being thrown
Created *9032b*, this branch will contain conversion changes related to FindQuery silent operations with the purpose ... Dănuț Filimon
04:10 AM Bug #9032 (Review): Reduce the number of exceptions that are being thrown
Tested a customer scenario, 100 runs with and without 9032a/15367-9 and got the following results:
|_. Test ... Dănuț Filimon
09:10 AM Bug #9019 (Test): reduce the usage of capturing lambdas in FWD runtime
Branch 9019a was merged to trunk rev 15380 and archived. Stefanel Pezamosca
09:01 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Please merge 9019a now. Constantin Asofiei
08:30 AM Bug #9019 (Merge Pending): reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei
08:30 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
OK, will be merged after 8593e. Constantin Asofiei
08:20 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei wrote:
> Thanks. Any other testing needed? We need to put this in trunk. I've previously tested... Stefanel Pezamosca
08:07 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Thanks. Any other testing needed? We need to put this in trunk. I've previously tested ETF and was OK. Constantin Asofiei
06:44 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
> I think we can do the same for ScrollableResults.next(), and also avoid adding the 'impl' method - there is no reas... Stefanel Pezamosca
06:13 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I think we can do the same for @ScrollableResults.next()@, and also avoid adding the 'impl' method - there is no reas... Constantin Asofiei
05:56 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I have seen another place I could improve in @ScrollableResults.get(boolean)@ method.
*Committed in 9019a revision... Stefanel Pezamosca
03:32 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei wrote:
> Please make the invalidateImpl methods private. Otherwise, the changes are ok (invalida... Stefanel Pezamosca
03:30 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Stefanel Pezamosca wrote:
> I committed to 9019 revision 15390 capturing lambda reduction changes for invalidate me... Constantin Asofiei
03:17 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I committed to 9019 revision 15390 capturing lambda reduction changes for invalidate method in FastFindCache. Stefanel Pezamosca
03:01 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Eric Faulhaber wrote:
> In @TriggerTracker.getTracker@, are we sure that replacing @computeIfAbsent@ with @get@ and ... Stefanel Pezamosca
02:53 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Eric Faulhaber wrote:
> I looked at @FastFindCache@ after the rebase/rework. The changes look ok to me. Is there a r... Stefanel Pezamosca

08/12/2024

03:36 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I looked at @FastFindCache@ after the rebase/rework. The changes look ok to me. Is there a reason the same type of ca... Eric Faulhaber
01:51 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I'm trying to remember why I structured the @unknownModeResto... Constantin Asofiei
01:02 PM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Eric Faulhaber wrote:
> I'm trying to remember why I structured the @unknownModeRestore@ variable in @AbstractQuery.... Constantin Asofiei
10:31 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Code Review 9019a/15376-15386 (persistence-specific):
I'm trying to remember why I structured the @unknownModeRest... Eric Faulhaber
04:09 AM Bug #9032: Reduce the number of exceptions that are being thrown
I got blocked again as I am not able to reproduce the "null.*" import, the latest example I managed to create is:
<p... Dănuț Filimon

08/09/2024

11:44 AM Bug #9037 (Review): Two timers problem: only one fires
The 8393b rev. 15374 contains the change for #9037-7 and the fix for the #9037-12 issue. Please, review. Vladimir Tsichevski
10:16 AM Bug #9037: Two timers problem: only one fires
Vladimir Tsichevski wrote:
> I retested the issue once again: it appears sometimes still (but rarely), despite the p... Vladimir Tsichevski
08:47 AM Bug #9037 (WIP): Two timers problem: only one fires
I retested the issue once again: it appears sometimes still (but rarely), despite the problem with @ServerEvent@ init... Vladimir Tsichevski
10:25 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Code Review Task Branch 9019a Revisions 15376 through 15386
I'm good with the changes.
Eric: You need to review... Greg Shah
07:18 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
9019a has some other changes:
* rev 15386 - Inlined the SQLQuery logging, to avoid capturing lambdas.
* rev 15385 -... Constantin Asofiei
03:34 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
> Stefanel, unless you have more pending fixes, pleas consider 9019a frozen. My plan is to test this on my machine, ... Stefanel Pezamosca
03:29 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
9019a 15369 was rebased from trunk rev 15375 - new rev 15384.
Stefanel, unless you have more pending fixes, pleas ... Constantin Asofiei
03:27 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I'm rebasing 9019a now. Constantin Asofiei
03:18 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Stefanel, is 9019a in a good place to review/cleanup/test? Constantin Asofiei
09:16 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu Maxiniuc wrote:
> Dănuț Filimon wrote:
> > Ovidiu, do you have any small example that will reach @createImpo... Dănuț Filimon
07:44 AM Bug #9032: Reduce the number of exceptions that are being thrown
Committed *9032a/15369*. Removed usage of Arrays.stream(), incorporated the functionality in a separate method named ... Dănuț Filimon
06:48 AM Bug #9032: Reduce the number of exceptions that are being thrown
I've made a few adjustments to reduce the search for null parameter types. Instead of using @Arrays.stream(parTypes).... Dănuț Filimon
04:04 AM Bug #9032: Reduce the number of exceptions that are being thrown
Tested a customer scenario, 100 runs with and without 9032a and got the following results:
|_. Test |_.... Dănuț Filimon
02:08 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu Maxiniuc wrote:
> Back to your idea: indeed, the errors are (if not, they probably should be) immutable objec... Dănuț Filimon

08/08/2024

03:24 PM Bug #9037: Two timers problem: only one fires
Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > Yes, that makes sense. Should we switch all of the current synch... Vladimir Tsichevski
02:25 PM Bug #9037: Two timers problem: only one fires
> Also, I think, the following code should by executed synchronized:
Agreed. Greg Shah
02:05 PM Bug #9037: Two timers problem: only one fires
Greg Shah wrote:
> Yes, that makes sense. Should we switch all of the current synchronization to that same lock obj... Vladimir Tsichevski
01:41 PM Bug #9037: Two timers problem: only one fires
Yes, that makes sense. Should we switch all of the current synchronization to that same lock object? Greg Shah
01:34 PM Bug #9037: Two timers problem: only one fires
Greg Shah wrote:
> Code Review Task Branch 8393b Revision 15373
>
> I don't think it is correct to synchronize on... Vladimir Tsichevski
01:14 PM Bug #9037: Two timers problem: only one fires
Code Review Task Branch 8393b Revision 15373
I don't think it is correct to synchronize on @dependencies@. That i... Greg Shah
09:13 AM Bug #9037 (Review): Two timers problem: only one fires
Branch 8393b rev. 15373 fixes this issue. Please, review. Vladimir Tsichevski
09:12 AM Bug #9037 (WIP): Two timers problem: only one fires
Vladimir Tsichevski
09:59 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Ovidiu, do you have any small example that will reach @createImport()@? I've tried to create ... Ovidiu Maxiniuc
09:54 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Something I thought of based on #9032-17, we can have a single ErrorConditionException instan... Ovidiu Maxiniuc
08:55 AM Bug #9032: Reduce the number of exceptions that are being thrown
Something I thought of based on #9032-17, we can have a single ErrorConditionException instance that can be thrown fo... Dănuț Filimon
03:41 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu, do you have any small example that will reach @createImport()@? I've tried to create one similar to one of th... Dănuț Filimon
03:25 AM Bug #9032: Reduce the number of exceptions that are being thrown
Discussed during yesterday's meeting, relying on other exceptions to fill the callStack of the error for a LegacyErro... Dănuț Filimon
03:13 AM Bug #9032: Reduce the number of exceptions that are being thrown
I tested a customer scenario, 100 runs with 9032a/15268 and com.goldencode.p2j.util.DeferredLegacyErrorException does... Dănuț Filimon
02:47 AM Bug #9032: Reduce the number of exceptions that are being thrown
Committed *9032a/15268*.
* Reduce the number of DeferredLegacyErrorException by relying on a single instantiated obj... Dănuț Filimon

08/07/2024

04:10 PM Bug #9037: Two timers problem: only one fires
The problem is that the following code can be executed in *both* @PSTimer@ threads, so, the context for @ServerEvent.... Vladimir Tsichevski
03:43 PM Bug #9037: Two timers problem: only one fires
When two @PSTimer@ instances are defined to fire simultaneously, sometimes only one of them fires.
To reproduce ru... Vladimir Tsichevski
03:37 PM Bug #9037 (WIP): Two timers problem: only one fires
Vladimir Tsichevski
07:00 AM Bug #9032: Reduce the number of exceptions that are being thrown
Yes, we do this already. Any exception that doesn't need a stack trace is a candidate for this "trick". It saves a ... Greg Shah
05:47 AM Bug #9032: Reduce the number of exceptions that are being thrown
Greg Shah wrote:
> One idea: have a configurable option to throw a single pre-constructed instance (per context) of ... Dănuț Filimon

08/06/2024

10:06 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I committed other changes to *9019a revision 15369*.
About the usage of the new JMX_DEBUG flag: I think checking i... Stefanel Pezamosca
09:43 AM Bug #9032: Reduce the number of exceptions that are being thrown
> Also, about the @ErrorConditionException@ and NO-ERROR mode: I don't think we can aggressively change this so that ... Greg Shah
08:54 AM Bug #9032: Reduce the number of exceptions that are being thrown
Constantin Asofiei wrote:
> @printfln@ will be in the FWD server's log, but the logging level is @FINE@, so unless y... Dănuț Filimon
08:46 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Ovidiu Maxiniuc wrote:
> > However, inserting a @printfln("%s", copy.dumpTree(true))@ will r... Constantin Asofiei
08:45 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu Maxiniuc wrote:
> However, inserting a @printfln("%s", copy.dumpTree(true))@ will reveal the node type/text a... Dănuț Filimon
08:44 AM Bug #9032: Reduce the number of exceptions that are being thrown
Also, about the @ErrorConditionException@ and NO-ERROR mode: I don't think we can aggressively change this so that th... Constantin Asofiei
08:43 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> The jroot JavaAst when calling createImport() is:
> [...]
I was not referring to the JAST, ... Ovidiu Maxiniuc
08:36 AM Bug #9032: Reduce the number of exceptions that are being thrown
If you add @-Drules.tracing=true@ at the FWD server, I think the runtime conversion will emit the @by-rule@ annotatio... Constantin Asofiei
08:22 AM Bug #9032: Reduce the number of exceptions that are being thrown
The jroot JavaAst when calling createImport() is:... Dănuț Filimon
08:05 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> [...] Not sure where this CE3124 comes from?
The TRPL code is assembled into Java code. This... Ovidiu Maxiniuc
07:34 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> The "null.*" comes from @rules/convert/buffer_definitions.rules line 703@.
This is the probl... Dănuț Filimon
07:29 AM Bug #9032: Reduce the number of exceptions that are being thrown
The "null.*" comes from @rules/convert/buffer_definitions.rules line 703@. Dănuț Filimon
07:13 AM Bug #9032: Reduce the number of exceptions that are being thrown
I've identified where the "null.*" is added, it comes from @CE3124@ (I remember seeing this type of class a lot), the... Dănuț Filimon
06:26 AM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț Filimon wrote:
> Ovidiu Maxiniuc wrote:
> You are right, the import path is actually @"null."@ and not @null@... Ovidiu Maxiniuc
02:51 AM Bug #9032: Reduce the number of exceptions that are being thrown
Ovidiu Maxiniuc wrote:
> Dănuț,
>
> I looked over your changes in r15367, Jast interpreter. I have a few questio... Dănuț Filimon

08/05/2024

01:36 PM Bug #9032: Reduce the number of exceptions that are being thrown
Dănuț,
I looked over your changes in r15367, Jast interpreter. I have a few questions here:
* in which cases @im... Ovidiu Maxiniuc
09:29 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown
I've created *9032a* and committed revision *15367*, the changes include:
* Avoid looking up methods when the signat... Dănuț Filimon
09:05 AM Bug #9032: Reduce the number of exceptions that are being thrown
This is a separate issue created based on #7026-314.
From the same note:
4. Exceptions
|_. Class |_. Count |
|... Dănuț Filimon
08:27 AM Bug #9032 (WIP): Reduce the number of exceptions that are being thrown
Dănuț Filimon
10:22 AM Bug #9019 (Review): reduce the usage of capturing lambdas in FWD runtime
I committed my last changes to *9019a revision 15368*.
There were some changes before that were doing more bad tha... Stefanel Pezamosca
06:17 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Attached is the capturing lambda with 9019a/15367 and some changes I didn't yet commit. Constantin Asofiei
03:19 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
For now, just to be on the safe side I made a new Runnable field to store and use it in case all previous values are ... Stefanel Pezamosca

08/02/2024

05:25 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Can @setActiveBuffer@ ever be called while another call is active? I mean, currently we bracket this with @setActiveB... Constantin Asofiei
03:47 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
So, in @BaseRecord@ the only capturing lambda use I've seen is this one in @setActiveBuffer()@:... Stefanel Pezamosca

08/01/2024

10:08 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I committed to branch 9019a: (15363..15366)
* Extracted processCommit and processRollback lambdas to processCommitIm... Stefanel Pezamosca

07/31/2024

10:34 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
> Will be true if we add @-Djmx.debug@ to JVM arguments.
> Or something similar.
Let's name it @-Dfwd_jmx_debug@ ... Greg Shah
10:33 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I committed to branch 9019a revision 15362:
* I added the JMX_DEBUG flag in @FwdServerJMX.java@.
* Skipped the HYD... Stefanel Pezamosca
08:48 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
So, I can add something like:... Stefanel Pezamosca
08:26 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
I'm OK with that (for the debugging cases). The default should be no lambdas. Greg Shah
08:24 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg, adding a JVM-level argument to enable JMX lambdas may help (... Constantin Asofiei
08:23 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei wrote:
> Greg, adding a JVM-level argument to enable JMX lambdas may help (this would mean that d... Greg Shah
08:05 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Greg, adding a JVM-level argument to enable JMX lambdas may help (this would mean that depending on this flag we eith... Constantin Asofiei
07:38 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
No, that's still an instance created for the anon class. The point is to avoid instances being created (either via a... Constantin Asofiei
07:21 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Constantin, would this be considered as an improvement ? ... Stefanel Pezamosca
05:03 AM Bug #9019 (WIP): reduce the usage of capturing lambdas in FWD runtime
Sure, I will start working on this now. Stefanel Pezamosca
04:48 AM Bug #9019: reduce the usage of capturing lambdas in FWD runtime
Each capturing lambda in Java acts as a pseudo-anonymous class, and an instance of it is created on each call, to 'ca... Constantin Asofiei
04:36 AM Bug #9019 (Test): reduce the usage of capturing lambdas in FWD runtime
Constantin Asofiei
 

Also available in: Atom