FWD » Core Development » Base Language

11/21/2024

03:10 PM Bug #8309 (Review): Do the error handling for r-index and extend implementation to INDEX and LONG...

Issue fixed in rev. 15573. Review, please. Vladimir Tsichevski

01:31 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Vladimir Tsichevski wrote:
> Another issue discovered: the @R-INDEX@ implementation does not support @CHARACTER@ cas... Vladimir Tsichevski

07:28 AM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Another issue discovered: the @R-INDEX@ implementation does not support @CHARACTER@ case sensitivity, the comparison ... Vladimir Tsichevski

10:13 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> But a question: does this test still work in FWD with 8643a?
Well, not really. I cha... Eduard Soltan

03:41 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

The changes make sense, we've seen weird behavior for db-related errors in other places.
But a question: does this... Constantin Asofiei

11/20/2024

05:37 PM Bug #8309: Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

Branch 8309a rev. 15571 now handles invalid index argument for @R-INDEX@ correctly.
ABLUnit tests attached for the @... Vladimir Tsichevski

12:14 PM Bug #8309 (WIP): Do the error handling for r-index and extend implementation to INDEX and LONGCHAR

I've created the 8309a branch for this. Vladimir Tsichevski

09:55 AM Bug #6389: LENGTH function with COLUMN option

I am sorry, I forgot to add the 'destination' parameter for @chr@ function. I updated the procedures above. It turn o... Ovidiu Maxiniuc

09:19 AM Bug #6389: LENGTH function with COLUMN option

Constantin Asofiei wrote:
> But: are we sure characters in a certain string are not 'merged' into i.e. 3 columns eve... Artur Școlnic

09:10 AM Bug #6389: LENGTH function with COLUMN option

I extended the extractor to:... Ovidiu Maxiniuc

09:07 AM Bug #6389: LENGTH function with COLUMN option

We can keep this data in a file (or an array) directly, no need to complicate things with intervals.
But: are we s... Constantin Asofiei

09:02 AM Bug #6389: LENGTH function with COLUMN option

Correct me if I am wrong, but the main problem with an approach like this is the fact that we can't rely on intervals... Artur Școlnic

08:49 AM Bug #6389: LENGTH function with COLUMN option

To extract the column lengths for all 64Ki Unicode characters we can use the following procedure (do not forget to st... Ovidiu Maxiniuc

07:59 AM Bug #6389: LENGTH function with COLUMN option

Artur Școlnic wrote:
> Ovidiu, won't manually scanning the Unicode planes for any type of characters limit the funct... Ovidiu Maxiniuc

07:08 AM Bug #6389: LENGTH function with COLUMN option

Yes, the results are from OE. In FWD the @length@ function does not work with any of the parameters if multi byte cha... Artur Școlnic

07:03 AM Bug #6389: LENGTH function with COLUMN option

Are these results from OE? Greg Shah

06:12 AM Bug #6389: LENGTH function with COLUMN option

I was operating under the assumption that @chr(, "utf-8")@ encodes a character using utf-8 and 4gl will calculate the... Artur Școlnic

11/19/2024

12:51 PM Bug #6389: LENGTH function with COLUMN option

Eugenie Lyzenko wrote:
> However the main question here I think is to detect what is the output of the @LENGTH@ in 4... Ovidiu Maxiniuc

12:44 PM Bug #6389: LENGTH function with COLUMN option

+Review of 6389a/15563+
The solution seems close, but there are some issues we need to discuss:
* your sample in ... Ovidiu Maxiniuc

12:07 PM Bug #6389: LENGTH function with COLUMN option

The approach used in @15563@ should work for 16-bit Java characters. If 4GL @LENGTH@ function always return number of... Eugenie Lyzenko

08:04 AM Bug #6389: LENGTH function with COLUMN option

Ovidiu and Eugenie: Please review. Greg Shah

07:19 AM Bug #6389 (Review): LENGTH function with COLUMN option

The length of wide chars seems to be @2@ regardless of the mode the program is ran in (gui, chui, batch), of the outp... Artur Școlnic

09:15 AM Bug #9037 (Review): Two timers problem: only one fires

Branch 8393b on rev. 15573 fixes the problem. I (re)tested it with the @8393.p@ and the big customer application.
I ... Vladimir Tsichevski

09:01 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.

This issue is derived from #9271-11. Artur Școlnic

09:00 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.

start.p... Artur Școlnic

08:54 AM Bug #9354 (WIP): Invalid handle (3135) error is thrown insted of the 10068 error.

Artur Școlnic

11/18/2024

09:38 AM Bug #6389: LENGTH function with COLUMN option

I am using tests like the one in #6389-21. Artur Școlnic

09:36 AM Bug #6389: LENGTH function with COLUMN option

Did you test in both ChUI, GUI and batch process? Constantin Asofiei

09:19 AM Bug #6389: LENGTH function with COLUMN option

Should I commit the fix for the "Column" parameter, or fix the other ones too? Artur Școlnic

08:50 AM Bug #6389: LENGTH function with COLUMN option

I have a fix for the @COLUMN@ parameter, but it looks like the same method could be used for all the parameters. Artur Școlnic

08:49 AM Bug #6389: LENGTH function with COLUMN option

... Artur Școlnic

07:41 AM Bug #6389: LENGTH function with COLUMN option

I was not aware we already have it :), thank you. Artur Școlnic

07:32 AM Bug #6389: LENGTH function with COLUMN option

The same class exists in FWD as @p2j/build/lib/jline-2.14.6.jar:jline.console.WCWidth@. I'm confused why you need th... Constantin Asofiei

07:29 AM Bug #6389: LENGTH function with COLUMN option

Constantin Asofiei wrote:
> Artur, you mean this project? https://github.com/jline/jline3
No, it it a class in the ... Artur Școlnic

07:23 AM Bug #6389: LENGTH function with COLUMN option

Artur, you mean this project? https://github.com/jline/jline3
Greg: please comment about BSD. Constantin Asofiei

07:21 AM Bug #6389: LENGTH function with COLUMN option

I wrote an implementation for the @columnLength@ method, but it relies on the @jdk.internal.org.jline.utils.WCWidth@ ... Artur Școlnic

05:57 AM Bug #6389 (WIP): LENGTH function with COLUMN option

Artur Școlnic

08:11 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

We have analytics tooling that allows us to evaluate the level of support for each 4GL language feature. This is rep... Greg Shah

08:10 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

Greg Shah wrote:
> See [[p2j:Gap Analysis]].
Where is the gap marking for @LOG-MANAGER@? Galya B

08:06 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

How is this task different from #3853? Galya B

08:06 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

See [[p2j:Gap Analysis]]. Greg Shah

08:05 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

These are some items in reports for an application being evaluated.
* attributes
** @LOGGING-LEVEL@ (conversion f... Greg Shah

08:02 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong

What is the concern? I tested what I implemented, when I implemented it. Galya B

07:55 AM Bug #9350 (Internal Test): gap marking for LOG-MANAGER attributes and methods is probably wrong

Greg Shah

11/08/2024

08:26 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Note to self, review/explore the following things:
* How Java 17 affects lambda/method handle usage.
* Investigat... Greg Shah

11/01/2024

08:33 AM Bug #8944: FINALLY block transaction processing

Constantin Asofiei wrote:
> So, are all cases being 'faulty' or just the @popScope@ one?
I have seen issues only ... Artur Școlnic

08:19 AM Bug #8944: FINALLY block transaction processing

We have FINALLY being processed in FWD, in:
* @iterateWorker@ when the block is iterating
* @processRetry@ in case ... Constantin Asofiei

10/31/2024

03:15 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin, please review. Dănuț Filimon

10/30/2024

10:35 AM Bug #8643 (Review): ErrorManager not handling caught errors and error-status:error attribute prop...

Rebased 8643a, to latest trunk. And fixed some history entries in revision 15528.
Committed on 8643a, revision 155... Eduard Soltan

10:33 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Looking a bit more closely at the example from #8643-30, and the implementation of @BlockManager.processLegacyError@.... Eduard Soltan

07:34 AM Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Tested unittests with the changes from 8643a. It indeed solves a lot of tests in @service@ and some other modules. Bu... Eduard Soltan

10/29/2024

06:14 AM Bug #8944: FINALLY block transaction processing

deleted Artur Școlnic

05:23 AM Bug #8944: FINALLY block transaction processing

Considering that in 4GL, @finally@ is executed at the end of each iteration of the enclosing block, extracting the fi... Artur Școlnic

05:00 AM Bug #8944: FINALLY block transaction processing

*Further analysis into finally blocks and transactions based on the example in #8944-1.*
A scenario without a fina... Artur Școlnic

10/28/2024

10:46 AM Bug #8944: FINALLY block transaction processing

Using the @_TRANS@ VST with the examples above, I concluded that for the full transactions:
* @exclusive-lock@ forc... Artur Școlnic

10:27 AM Bug #8944: FINALLY block transaction processing

> _TRANS virtual system table is not supported by fwd
Correct Greg Shah

10:19 AM Bug #8944: FINALLY block transaction processing

I was trying to analyze transactions for the examples above using... Artur Școlnic