Project

General

Profile

Activity

From 12/08/2024 to 01/06/2025

01/06/2025

01:04 PM Feature #8138: ABLUnit configuration using environment variables
Greg Shah wrote:
> This still needs to be discussed and resolved.
I will look at it when I get back at the office... Marian Edu
08:26 AM Feature #8138 (WIP): ABLUnit configuration using environment variables
> Doesn't the change to use the driver's @shutdown()@ bypass the ncurses @terminate()@ call since it is not Windows? ... Greg Shah
11:15 AM Support #9398: Incomplete SESSION:DATE-FORMAT implementation in FWD and setting session date form...
Galya and/or Constantin can help with how to use the [[p2j:Testcases]] project to test appserver.
Batch mode is al... Greg Shah
10:17 AM Support #9398: Incomplete SESSION:DATE-FORMAT implementation in FWD and setting session date form...
Greg Shah wrote:
> Code Review Task Branch 9398a Revision 15628
>
> The changes look good.
>
> Although they a... Vladimir Tsichevski
09:57 AM Support #9398 (Internal Test): Incomplete SESSION:DATE-FORMAT implementation in FWD and setting s...
Code Review Task Branch 9398a Revision 15628
The changes look good.
Although they are relatively low risk, plea... Greg Shah

12/31/2024

01:54 PM Feature #8138: ABLUnit configuration using environment variables
Greg Shah wrote:
> Yes, good idea.
Done in 8138a rev. 15628. The patch from Marian applied, code indentation, sty... Vladimir Tsichevski
11:41 AM Feature #8138: ABLUnit configuration using environment variables
Yes, good idea. Greg Shah
11:30 AM Feature #8138: ABLUnit configuration using environment variables
Marian Edu wrote:
> This is a patch with the local changes we are using
Do you mind if I create the 8138a branch ... Vladimir Tsichevski
11:00 AM Feature #8138 (Review): ABLUnit configuration using environment variables
Code Review testengine.patch
Doesn't the change to use the driver's @shutdown()@ bypass the ncurses @terminate()@ ... Greg Shah
09:14 AM Feature #8138: ABLUnit configuration using environment variables
This is a patch with the local changes we are using - beside the option to specify the XML configuration file using a... Marian Edu
10:06 AM Bug #9411 (Internal Test): Implement SESSION:STREAM
I'm removing this from the merge queue so that the queue is not blocked. Let me know when you are ready to perform t... Greg Shah

12/20/2024

11:12 AM Bug #9411 (Merge Pending): Implement SESSION:STREAM
Code Review Task Branch 9411a Revision 15610
It is good.
You can merge to trunk now. Greg Shah
03:04 AM Bug #9411: Implement SESSION:STREAM
Committed 9411a revision 15610. Eduard Marcu

12/19/2024

01:29 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
Please checkout again the project fully, there was some references from the source project I used to build it, which ... Constantin Asofiei
12:40 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
OK, is there. I've included the @abl/ADE@ checkout, but couldn't include the .git folder, too. The commit message is... Constantin Asofiei
12:25 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
> Please let me know if you want to upload the ADE project I used.
Yes, we should have it located in @~/secure/cod... Greg Shah
11:47 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
I've ran the reports on the current parsed .cls files; these are some notes:
* unsupported handle attributes: ROLES
... Constantin Asofiei
10:23 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
I've started parsing the ADE .cls files - there are usages like this:
* generic usage... Constantin Asofiei
09:14 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
> To make this work, we will have to implement anything missing in @progress.lang.*@ since those are not written in ... Greg Shah
07:20 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
Greg Shah wrote:
> There are less than 450 classes in @src/corelib/@ and @src/netlib/@. Isn't that all we're worrie... Constantin Asofiei
07:14 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
There are less than 450 classes in @src/corelib/@ and @src/netlib/@. Isn't that all we're worried about? I don't th... Greg Shah

12/18/2024

05:31 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
Greg Shah wrote:
> Constantin: Please evaluate the gaps that need to be resolved to convert all the OO built-in clas... Constantin Asofiei
04:42 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4
As of 12.7.0, PSC has licensed all of its ADE code under the Apache 2.0 license (see https://github.com/progress/ADE/... Greg Shah
04:34 PM Feature #9488 (WIP): implement all built-in OO classes using the open source ADE code from 12.8.4
Greg Shah
09:46 AM Bug #9411: Implement SESSION:STREAM
Please update the gap marking for this attribute (mark it full/partial the same way that cpstream is marked).
Then... Greg Shah
03:13 AM Bug #9411 (Internal Test): Implement SESSION:STREAM
Alexandru Lungu
08:42 AM Bug #8944: FINALLY block transaction processing
There is another potential issue that maybe should be discussed.
In @notifyMasterFinish@ and @processFinalizables@, ... Artur Școlnic
07:43 AM Bug #8944 (Review): FINALLY block transaction processing
I tried to solve the issue without changing the existing 'infrastructure' and overall logic.
As I stated in note 29,... Artur Școlnic

12/17/2024

08:19 AM Bug #9482: Reduce logging for warnings coming outside FWD.
CentralLogger logs warning with throwables and their respective stack trace, if the throwable was passed as a paramet... Artur Școlnic
08:15 AM Bug #9482 (New): Reduce logging for warnings coming outside FWD.
Artur Școlnic
04:40 AM Bug #9037: Two timers problem: only one fires
Review:
Not sure if locking in @ContextLocal@ would introduce even more problems, but I've found that out while wor... Tomasz Domin

12/16/2024

09:37 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
There are some prints for debugging reasons.... Eduard Marcu

12/13/2024

02:13 PM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
> I think what is needed is to put an annotation when @chainedRef@ should be true and after a @REFERENCE@ gets added ... Greg Shah
09:48 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
For the progress code given by Alex: @obj:gen():gen():test():test().@... Eduard Marcu

12/12/2024

10:49 AM Bug #9037: Two timers problem: only one fires
> @SecurityContext@ instance (Greg, IIRC this is a singleton for each FWD context, right?)
In most cases, yes it i... Greg Shah
08:13 AM Bug #9037: Two timers problem: only one fires
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > Regarding the changes in 9037a...
>
> Branch 9037... Constantin Asofiei
08:13 AM Bug #9037: Two timers problem: only one fires
Constantin Asofiei wrote:
> Regarding the changes in 9037a...
Branch 9037a never existed :-(. The change is in ... Vladimir Tsichevski
07:54 AM Bug #9037: Two timers problem: only one fires
Greg/Vladimir: I agree that the synchronization in ContextLocal is faulty. But I propose to improve and fix the sync... Constantin Asofiei
10:01 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
> I like the second version more. Maybe use @ref()@, @chainedRef()@ (which will call @chainedRef(false)@ underneath) ... Greg Shah
09:36 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
I think your approach is right. Please consider:... Alexandru Lungu
08:54 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
... Eduard Marcu
04:29 AM Bug #9396: Improve Incompatible data types in expression or assignment. (223) error handling
I thought about this and found that we have a map storing function definitions in @SignatureHelper@ (@map_func@), thi... Dănuț Filimon

12/11/2024

03:57 AM Bug #9411: Implement SESSION:STREAM
I am OK with the changes in 9411a. Alexandru Lungu
09:01 PM Feature #9448: compatibility test security features
Check the tests in Testcases to ensure they are complete and comprehensive. Add tests if needed. Convert and run the ... Greg Shah
08:58 PM Feature #9448 (Closed): compatibility test security features
Greg Shah
08:53 PM Feature #9447: XML support feature improvements and testing
* @SAX-READER@ (also should be added to @X-DOCUMENT@ if easily done, but only the @SAX-READER@ version is used in the... Greg Shah
08:52 PM Feature #9447 (Closed): XML support feature improvements and testing
Greg Shah
08:20 PM Support #9446: compatibility test PUT-DOUBLE
Check the @PUT-DOUBLE@ tests in [[p2j:Testcases]] to ensure they are complete and comprehensive. Add tests if needed... Greg Shah
08:20 PM Support #9446 (Closed): compatibility test PUT-DOUBLE
Greg Shah
08:18 PM Support #9445: compatibility test FIX-CODEPAGE
Check the @FIX-CODEPAGE@ tests in [[p2j:Testcases]] to ensure they are complete and comprehensive. Add tests if need... Greg Shah
08:13 PM Support #9445 (Closed): compatibility test FIX-CODEPAGE
Greg Shah

12/10/2024

12:35 PM Feature #9442: implement limited support for RCODE-INFORMATION
Greg Shah wrote:
> Both start with an assignment of @RCODE-INFORMATION:FILENAME@ to some program name or class name.... Constantin Asofiei
12:32 PM Feature #9442: implement limited support for RCODE-INFORMATION
There are 2 patterns used that should be supported.
Both start with an assignment of @RCODE-INFORMATION:FILENAME@ ... Greg Shah
12:29 PM Feature #9442 (Closed): implement limited support for RCODE-INFORMATION
Greg Shah
09:59 AM Bug #9411: Implement SESSION:STREAM
Greg Shah wrote:
> Eugenie: Please review and comment on #9411-14.
>
> > is not needed then we can either change ... Eugenie Lyzenko
09:35 AM Bug #9411: Implement SESSION:STREAM
It is already committed! Eduard Marcu
09:28 AM Bug #9411: Implement SESSION:STREAM
Please apply the changes to the branch. Greg Shah
09:26 AM Bug #9411: Implement SESSION:STREAM
Committed 9411a revision 15609. ... Eduard Marcu
09:04 AM Bug #9411: Implement SESSION:STREAM
Perfect. OE treats these as synonyms too. Go ahead with that idea. Greg Shah
08:52 AM Bug #9411: Implement SESSION:STREAM
!6.png!
I think it's worth mentioning that even if I set @-stream "someEncoder"@ the error message contains @-cps... Eduard Marcu
08:27 AM Bug #9411: Implement SESSION:STREAM
Alexandru Lungu wrote:
> Running a 4GL application with @-cpstream@ option at CLI is also changing @STREAM@?
Yes.
... Eduard Marcu
08:12 AM Bug #9411: Implement SESSION:STREAM
> As such I think we can go ahead and make SESSION:STREAM be SESSION:CPSTREAM in conversion.
Running a 4GL applica... Alexandru Lungu
08:10 AM Bug #9411: Implement SESSION:STREAM
I tested with every encoder and I found the following:
* the encoder is the key of @convmap2JavaDefault@
* @SESSION... Eduard Marcu
06:47 AM Bug #9411: Implement SESSION:STREAM
Eugenie: Please review and comment on #9411-14.
> is not needed then we can either change the rules to call @getCP... Greg Shah
06:12 AM Bug #9411: Implement SESSION:STREAM
Alexandru Lungu wrote:
> Functional: I might not properly understand the use of @convmap2JavaDefault@. What is the g... Eduard Marcu
05:03 AM Bug #9411: Implement SESSION:STREAM
Review of 9411a:
* please keep the naming consistent with the rest of CommonSession API (aka use @get@ prefix)
* ... Alexandru Lungu
04:26 AM Bug #9411: Implement SESSION:STREAM
Since we moved the @stream()@ method we should also do the following changes:... Eduard Marcu
04:06 AM Bug #9411: Implement SESSION:STREAM
Committed 9411a revision 15610. Eduard Marcu
04:05 AM Bug #9411 (Review): Implement SESSION:STREAM
Greg Shah wrote:
> Code Review Task Branch 9411a Revision 15609
>
> 1. Instead of @SessionUtils@, the getter shou... Eduard Marcu
09:57 AM Bug #9350 (Internal Test): gap marking for LOG-MANAGER attributes and methods is probably wrong
Code Review Task Branch 9198a Revision 15486
The changes are good.
I've checked in rev 15487 with minor comment... Greg Shah
09:27 AM Bug #9350 (Review): gap marking for LOG-MANAGER attributes and methods is probably wrong
Galya B
09:27 AM Bug #9350: gap marking for LOG-MANAGER attributes and methods is probably wrong
Up in 9198a r15486.
Diff:... Galya B
08:52 AM Bug #9350 (WIP): gap marking for LOG-MANAGER attributes and methods is probably wrong
The current state should be:
1. LOG-MANAGER attributes:
* LOGFILE-NAME (KW_LOGF_NAM) - conversion full/runtime fu... Galya B
07:44 AM Bug #9354: Invalid handle (3135) error is thrown insted of the 10068 error.
I can reproduce the issue. The problem is in @object.ref@:... Eduard Marcu
04:28 AM Bug #9354 (WIP): Invalid handle (3135) error is thrown insted of the 10068 error.
Eduard Marcu
07:38 AM Feature #4392 (Closed): add -pf support for appserver CONNECT() method
Greg Shah
08:34 PM Feature #9437: enhancements for Progress.Lang.Class
... Greg Shah
08:33 PM Feature #9437 (Closed): enhancements for Progress.Lang.Class
Greg Shah
08:26 PM Feature #9436: add built-in OO classes
... Greg Shah
08:24 PM Feature #9436 (WIP): add built-in OO classes
Greg Shah

12/09/2024

06:50 PM Feature #9435: class-level virtual procedure/function definitions
Some procedures and functions can be defined in classes.
* @PROCEDURE EXTERNAL@
* @PROCEDURE/FUNCTION ... IN hand... Greg Shah
06:49 PM Feature #9435 (Closed): class-level virtual procedure/function definitions
Greg Shah
06:44 PM Bug #4602: fixes for OO 4GL and structured error handling
Some things to ensure are fully working:
* @CATCH@ with inner @UNDO, THROW@
* @FINALLY@ with @DELETE OBJECT@ (wit... Greg Shah
04:56 PM Bug #9411: Implement SESSION:STREAM
Code Review Task Branch 9411a Revision 15609
1. Instead of @SessionUtils@, the getter should be in @I18nOps@.
2... Greg Shah
10:05 AM Bug #9411: Implement SESSION:STREAM
Committed 9411a revision 15609. Eduard Marcu
09:39 AM Bug #9411: Implement SESSION:STREAM
That seems reasonable. Please put the changes in a branch. Greg Shah
09:24 AM Bug #9411: Implement SESSION:STREAM
... Eduard Marcu
09:20 AM Bug #9411: Implement SESSION:STREAM
I tested the OE application and introduced other encoding formats in startup. @SESSION:STREAM@ can also output other ... Eduard Marcu
09:07 AM Bug #9411: Implement SESSION:STREAM

In @method_attributes.rules@:... Eduard Marcu
03:03 AM Bug #9411 (WIP): Implement SESSION:STREAM
Eduard Marcu
11:55 AM Bug #6640: parsing bug for initial ",0000" for decimal variables or fields
What happens in OE when you set the decimal separator or group separator to different values?
You can set this on ... Greg Shah
10:44 AM Bug #6640: parsing bug for initial ",0000" for decimal variables or fields
Seems, the decimal separators are ignored completely when parsing a string to a number.
In OE this works as if the i... Vladimir Tsichevski
 

Also available in: Atom